[GitHub] cloudstack pull request: CLOUDSTACK-8977: remove session creation ...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/961#issuecomment-152178160 @K0zka @karuturi I am using tomcat 6 as well. agree with Rajani --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-9007 - Write test to check tha...

Github user serbaut commented on the pull request: https://github.com/apache/cloudstack/pull/1002#issuecomment-152180011 Thank you, that would have taken me days to write. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

Re: [PROPOSAL] remove travis pull request checks from github

The apache build reports rats, findbugs, pmd, coverage etc. On Thu, Oct 29, 2015 at 12:28 PM, Miguel Ferreira < mferre...@schubergphilis.com> wrote: > It would add speed. > > Just for running maven we could move the travis build to their docker > based infra which is faster than what we use now.

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-152160447 hmm, in a advanced network setup, these IP address would be the private IPs but if it has a static NAT, the VM would also have a public IP. For a user, it

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-152165313 @resmo the field value and label is same as on the detail view's Nic tab - the default nic (or nic 1). I'm sure there are more better ways of fixing the

[GitHub] cloudstack pull request: CLOUDSTACK-8977: remove session creation ...

Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/961#issuecomment-152176166 Hi @k0zka are you saying it might be specific to tomcat6? Reverting the the change works fine. Do you think we should revert this until we find a solution

Re: [PROPOSAL] remove travis pull request checks from github

On Thu, Oct 29, 2015 at 2:22 PM, Sebastien Goasguen wrote: > > > On Oct 29, 2015, at 2:19 PM, Daan Hoogland > wrote: > > > > Sebastien, it is not urgent but costing us time > > so just don;t look at it ? > ​no-op. it is there telling people that

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-152183473 I have same issue with Remi, there are two virtio-serial in the vm definition. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/996#issuecomment-152187750 Ping @remibergsma @DaanHoogland @borisroman @wido @miguelaferreira Thanks, @karuturi! :) LGTM :+1: Test results: * Hardware

[GitHub] cloudstack pull request: [4.5] ui/instances: show IP address of th...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1004#issuecomment-152159431 @wido not a really big feature, I think we should still accept UI changes? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-152163454 Yes I see, but the label "IP address" does not indicate that it is the first NIC's IP address :). It might make sense to change the label to be more precise in that.

Automatically trigger a new Jenkins build

Hi all, Just had a chat with Miguel. He showed me that if we setup Github to notify Jenkins on “issue comments” (next to “pull requests” we have now) and then set a “trigger phrase” in Jenkins, we could automatically trigger a new build by typing “go build”. No more need to force push commits

[GitHub] cloudstack pull request: CLOUDSTACk-9002: VM deployment is success...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/995#issuecomment-152192762 Testing this PR now. Cheers, Wilder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9007 - Write test to check tha...

Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1002#discussion_r43389852 --- Diff: test/integration/component/test_router_dhcphosts.py --- @@ -0,0 +1,381 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-152193618 by the way, for user vms, I think it is better to add the field in vm_instance/user_vm or zone/cluster/global setting to determine if the vm is qemu guest agent

[GitHub] cloudstack pull request: CLOUDSTACK-9007 - Write test to check tha...

Github user serbaut commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1002#discussion_r43384431 --- Diff: test/integration/component/test_router_dhcphosts.py --- @@ -0,0 +1,381 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: CLOUDSTACK-9007 - Write test to check tha...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1002#issuecomment-152189749 @remibergsma @karuturi All green... Do you have some time to review/merge this PR? It's a test, no code - neither on the routers nor the java side

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Ovm3HypervisorGuru wrong...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/975#issuecomment-152195378 @snuf Can you respond to the comment by @dahn? Then we can proceed to merge this. Thanks! --- If your project is set up for it, you can reply to this email and

Re: [PROPOSAL] remove travis pull request checks from github

It would add speed. Just for running maven we could move the travis build to their docker based infra which is faster than what we use now. I’m guess that the apache build does more stuff like packaging RPMs, but I’m not sure there. \ Miguel Ferreira

Re: [PROPOSAL] remove travis pull request checks from github

On Thu, Oct 29, 2015 at 2:38 PM, Sebastien Goasguen wrote: > > On Oct 29, 2015, at 2:28 PM, Daan Hoogland > wrote: > > On Thu, Oct 29, 2015 at 2:22 PM, Sebastien Goasguen > >>> On Oct 29, 2015, at 2:19 PM, Daan Hoogland

Re: [PROPOSAL] remove travis pull request checks from github

Sebastien, it is not urgent but costing us time and more important costing time of 'innocent' contributors. So ... revert at your will. On Thu, Oct 29, 2015 at 1:44 PM, Sebastien Goasguen wrote: > Not surprisingly I like Travis, because it outsources the “tests” and that > we

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-152187084 succeed after the following change: diff --git a/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-152191665 that is good idea. then we need to rebuild systemvm template with qemu-guest-agent --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-9007 - Write test to check tha...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1002#issuecomment-152194820 @wilderrodrigues Testing this now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

Github user serbaut commented on the pull request: https://github.com/apache/cloudstack/pull/981#issuecomment-152175108 Sorry, been busy. Running tests now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Fixed user_vm_view to only display keypai...

GitHub user nnesic opened a pull request: https://github.com/apache/cloudstack/pull/1006 Fixed user_vm_view to only display keypairs belonging to the account. The user_vm_view displayes the keypair information by joining vm_details with ssh_keypairs on the key value exclusively.

[GitHub] cloudstack pull request: CLOUDSTACK-8940: Wrong value is inserted ...

Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/916#issuecomment-152152422 @remibergsma @bhaisaab The above changes were made as the part of DHCP/DNS offload feature. The related ticket is

[GitHub] cloudstack pull request: CLOUDSTACK-8958: add dedicated ips to dom...

GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/1007 CLOUDSTACK-8958: add dedicated ips to domain (account for now) For now, we dedicate ip pool to account, however, other accounts in the same domain cannot fetch the ip from this ip pool.

Building SNAPSHOT debian packages

Hi, We are building Debian packages on unstable branches (4.5 branch to be specific). The Debian source format 30. rejects the version 4.5.3-SNAPSHOT with an error "Can't build with source format 3.0 native: native package version may not have a revision." Source format 1.0 allows this value,

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-152188711 Hmm, ok. That should be allowed. Since we want the Guest tools also to be supported on SSVMs to control them properly. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-152157162 @borisroman Could you give this PR a spin? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: kvm: Add UnitTests for LibvirtUtilitiesHe...

GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/1005 kvm: Add UnitTests for LibvirtUtilitiesHelper These were lacking, but this helper is used in various places inside the KVM code. Some simple tests to verify the helper is doing what

[GitHub] cloudstack pull request: [4.5] ui/instances: show IP address of th...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1004#issuecomment-152157062 Isn't 4.5 closed for features? I know this might sound picky, but as far as I know we are only supposed to fix bugs in a point release. --- If your project is set up

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-152162038 @resmo the IP of the first nic, not necessarily public/private. I removed displayname as adding ip address column screwed up the width/alignment issue and it's a

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-152161769 @wido I will also test it again today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: [PROPOSAL] remove travis pull request checks from github

Not surprisingly I like Travis, because it outsources the “tests” and that we can fix them by editing .travis.yml, which can be done by someone without access to the Jenkins servers/slaves. At the very least I agree with Miguel which should keep the mvn build, and possible rat etc…

Re: [PROPOSAL] remove travis pull request checks from github

> On Oct 29, 2015, at 2:19 PM, Daan Hoogland wrote: > > Sebastien, it is not urgent but costing us time so just don;t look at it ? > and more important costing > time of 'innocent' contributors. What do you mean by that, I am not understanding. > So ... revert at

Re: [PROPOSAL] remove travis pull request checks from github

> On Oct 29, 2015, at 2:28 PM, Daan Hoogland wrote: > > On Thu, Oct 29, 2015 at 2:22 PM, Sebastien Goasguen > wrote: > >> >>> On Oct 29, 2015, at 2:19 PM, Daan Hoogland >> wrote: >>> >>> Sebastien, it is not urgent but

[GitHub] cloudstack pull request: CLOUDSTACK-8964: Ovm3HypervisorGuru wrong...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/975#issuecomment-152189257 Ping @remibergsma @snuf I did not test any OVM3 specifics, but @snuf did. The PR doesn't break existing functionality. Although the

[GitHub] cloudstack pull request: CLOUDSTACK-8956: NSX/Nicira Plugin does n...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/935#issuecomment-152197682 @nvazquez I havent' forgotten your PR. I'm having some trouble with the automation to re-create a NSX cluster with a KVM host in our test environment. As

[GitHub] cloudstack pull request: CLOUDSTACK-8940: Wrong value is inserted ...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/916#issuecomment-152196235 Hi @kansal Should I deploy a basic zone with shared network in order to see if that fix is fine? I will also run the other set of tests,

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/996#issuecomment-152202839 Ping @bhaisaab you may want to backport this small fix to 4.5 --- If your project is set up for it, you can reply to this email and have your reply appear on

RE: Build fails on LocalTemplateDownloadTest

Build environment isn't Windows, it's Ubuntu 14.04 that I am getting this build failure on. From: Wido den Hollander Sent: Thursday, October 29, 2015 1:50 AM To: dev@cloudstack.apache.org Subject: Re: Build fails on

[GitHub] cloudstack pull request: CLOUDSTACK-8977: remove session creation ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/961#issuecomment-152208509 @K0zka If you know of a fix for Tomcat6 we can merge that. Otherwise I think we should consider reverting. We can wait a bit but if there is no solution at the

Re: Pull request on Admin docs failure

Hi Ron, Yes you need an account on github.com > On Oct 29, 2015, at 4:41 PM, Ron Wheeler > wrote: > > I am new to this and trying to create a pull request in Eclipse and get the > message: > "Unexpected error: API rate limit exceeded for 24.37.79.202." > > It

[GitHub] cloudstack pull request: CLOUDSTACK-8793 Enable s2s VPN connection...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/879#issuecomment-152234419 code reviewed. nothing strange. lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/981 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9007 - Write test to check tha...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1002#issuecomment-152208845 @serbaut If you think this should go into master, please comment LGTM (Looks Good To Me) with any testing / verification you did. We need 2 LGTMs before we can

Pull request on Admin docs failure

I am new to this and trying to create a pull request in Eclipse and get the message: "Unexpected error: API rate limit exceeded for 24.37.79.202." It goes on to suggest that balance would be restored to the universe if I was authenticated. Do I need to have an account to create pull

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/996#issuecomment-152201239 LGTM as well! ![screen shot 2015-10-29 at 15 41

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/996#issuecomment-152203911 @remibergsma good idea, will do thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9007 - Write test to check tha...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1002#issuecomment-152203550 LGTM Run this: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/996#issuecomment-152205902 @remibergsma just checked this does not apply for 4.5, 4.5 has no prefilter in that section (see screenshot on 4.5) ![screen shot 2015-10-29 at 8 25 52

[GitHub] cloudstack pull request: CLOUDSTACK-8919: Slow UI response while l...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/897#issuecomment-152214761 @nitin-maharana I looked at this, seems good. What is the best way to test this or see the difference? --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-8984: VPC Network offeri...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/996 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: kvm: Add UnitTests for LibvirtUtilitiesHe...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1005#issuecomment-152213938 @wido You'd onky changed a methode name and added a getter. But no Unit test were added right? Forgot "git add ." before commiting? --- If your project is set

[GitHub] cloudstack pull request: CLOUDSTACK-9007 - Write test to check tha...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1002#issuecomment-152220381 It says test failures 0. I have no idea why it's red! In addition, no Java code was changed!

[GitHub] cloudstack pull request: CLOUDSTACK-9007 - Write test to check tha...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1002#issuecomment-152264912 @remibergsma @wilderrodrigues Also ran the test against PR #981 => LGTM :+1: ``` === TestName: test_router_dhcphosts | Status : SUCCESS === ok

RE: Hyper-V clock on KVM node - CLOUDSTACK-8978

I think I figured it out. Started working on a subtask CLOUDSTACK-9004 to re-factor and add some needed features to HyperVEnlightenmentFeatureDef. I'll submit a PR for it once I finish and then start working on the implementation mentioned in the parent task CLOUDSTACK-8978

[GitHub] cloudstack pull request: CLOUDSTACK-8977: remove session creation ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/961#issuecomment-152271301 @karuturi @K0zka @ustcweizhou @DaanHoogland @miguelaferreira I just reverted the commit. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-8977: remove session creation ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/961#issuecomment-152269280 @remibergsma this doesn't work in tomcat7 either. We ran tests on centos7 and only half a page is loaded. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-8919: Slow UI response while l...

Github user sudhansu7 commented on the pull request: https://github.com/apache/cloudstack/pull/897#issuecomment-152273822 @remibergsma @runseb I have below performance analysis, which I did some time back. I trying to find out the dbdump to do a real test. But below analysis

[GitHub] cloudstack pull request: CLOUDSTACK-8969 VPN customer gateway can'...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/955#issuecomment-152275904 LGTM, based on a set of tests that I run on this branch (which I rebased myself first): ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s

[GitHub] cloudstack pull request: [4.7] secure and hidden config values are...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/927#issuecomment-152284702 @karuturi I tested the `test_vpc_site2site_vpn ` two more times, and it keeps failing. The same tests on master succeeds and also on other branches I recently

[GitHub] cloudstack pull request: CLOUDSTACK-9007 - Write test to check tha...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1002 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Pass LbProtocol down to the HAProxyConfig...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/848 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

extending macchinina image

Hi Nux, et all, How would I go about adding a strongswan ipsec client to the macchinina template? Are you also responsible for the images here? http://dl.openvm.eu/cloudstack/macchinina/x86_64/ Michael On 08/05/15 16:12, "David Nalley" wrote:

[GitHub] cloudstack pull request: CLOUDSTACK-8746: VM Snapshotting implemen...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/977#issuecomment-152302260 @wido @sateesh-chodapuneedi @bhaisaab can you please see if you are satisfied with the present state (with respect to your comments)? --- If your project is

[GitHub] cloudstack pull request: Pass LbProtocol down to the HAProxyConfig...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/848#issuecomment-152291324 code reviewed as requested by @remibergsma no comments. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-8793 Enable s2s VPN connection...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/879#issuecomment-152293339 Will run the tests again since the commit changed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-8961: Changes related to the U...

Github user milamberspace commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/941#discussion_r43433493 --- Diff: ui/scripts/network.js --- @@ -6504,7 +6432,123 @@ } } } -

[GitHub] cloudstack pull request: CLOUDSTACK-8961: Changes related to the U...

Github user milamberspace commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/941#discussion_r43433516 --- Diff: ui/scripts/network.js --- @@ -6504,7 +6432,123 @@ } } } -

[GitHub] cloudstack pull request: CLOUDSTACK-8961: Changes related to the U...

Github user milamberspace commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/941#discussion_r43433480 --- Diff: ui/scripts/network.js --- @@ -4495,99 +4511,11 @@

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/981#issuecomment-152302053 is 4.5 also affected by this issue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Fixed: Network Update from RVR offering t...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/818#issuecomment-152282736 LGTM, based on a set of tests that I run on this branch (which I rebased myself first): ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s

[GitHub] cloudstack pull request: Fixed: Network Update from RVR offering t...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/818#discussion_r43429125 --- Diff: engine/schema/src/com/cloud/network/dao/NetworkVO.java --- @@ -616,7 +616,8 @@ public void setStrechedL2Network(boolean strechedL2Network)

[GitHub] cloudstack pull request: CLOUDSTACK-9007 - Write test to check tha...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1002#issuecomment-152286968 Agree that the Jenkins failure is unrelated. Will soon merge. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-8962: Dedicated cluster is use...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/945#issuecomment-152290121 based on code review LGTM. @nitin-maharana makes sense to write a marvin test for this. could you? --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-8793 Enable s2s VPN connection...

Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/879#issuecomment-152300355 @remibergsma The commit didn't change, I just rebased --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-8969 VPN customer gateway can'...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/955#issuecomment-152279403 @SudharmaJain Your change looks good at first sight. Did you verify that your intended behaviour actually happens? and how? The name of the vpn is now

[GitHub] cloudstack pull request: Update L10N Web UI resource files before ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1001#issuecomment-152292108 let's save this to the last moment but ltgm @remibergsma @karuturi --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8872: Replaced all occ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/832#issuecomment-152300766 @borisroman Can you force push this PR please and rebase it with current master? Then we can run some tests! Pinging @dahn to look at the code. --- If your

[GitHub] cloudstack pull request: Rename xapi plugins for s3 and swift to m...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/982#issuecomment-152303070 @xenserverarmy Sure, it works. It's very easy, the files end up in `/etc/xapi.d/plugins`. Are you able to verify yourself? --- If your project is set up for

[GitHub] cloudstack pull request: CLOUDSTACK-8940: Wrong value is inserted ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/916#issuecomment-152290835 code lgtm @remibergsma can you retest? A newer commit is in since your lgtm --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-8962: Dedicated cluster is use...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/945 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Fixed user_vm_view to only display keypai...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1006#issuecomment-152306235 Thanks for the fix @nnesic ! Pinging @DaanHoogland @bhaisaab to review. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-152332158 uservm can not start 2015-10-29 21:04:38,017 WARN [resource.wrapper.LibvirtStartCommandWrapper]

[GitHub] cloudstack pull request: Rename xapi plugins for s3 and swift to m...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/982#issuecomment-152304547 @DaanHoogland @wilderrodrigues You can do this to test this PR: ``` ./kvm_local_deploy.py -r xenserver65

[GitHub] cloudstack pull request: CLOUDSTACK-7984: Collect network statisti...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/926#issuecomment-152306229 ran ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_vpc_redundant.py \

Git with Eclipse

Trying to help out with the docs without doing too much damage. I am new to git. I am using Eclipse with the egit/mylyn plug-in and I have managed to get the source for the docs-admin downloaded. The "Configure Fetch" has a Source Ref of "refs/heads/*" and a Desctination Ref of

[GitHub] cloudstack pull request: [FUTURE]CLOUDSTACK-8872: Replaced all occ...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/832#issuecomment-152337266 @remibergsma @wilderrodrigues @DaanHoogland Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: adjust packaging for centos7

GitHub user davidamorimfaria opened a pull request: https://github.com/apache/cloudstack/pull/1008 adjust packaging for centos7 Here are a few adjustments for the packaging in centos7. With these changes I was able to start the service. Please review. Thank you. You can merge

Re: [PROPOSAL] remove travis pull request checks from github

2 hours before this message was sent, there was a message about jenkins being unreliable. So I am starting to think that something other than Travis or Jenkins is the problem. --David On Thu, Oct 29, 2015 at 5:33 PM, Daan Hoogland wrote: > Guys and dolls, > > We have

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/981#issuecomment-152101614 ping @serbaut @remibergsma Can you please do a force push to see if we get Jenkins green? I know is a pain in the ass to depend on Jenkins/Travis

Jenkins failures

Hi, Can someone please look why Jenkins fails so often recently? It feels like a casino and slows down merging of PRs since we want to merge when they “are green”. This requires forse pushing many times now, including the wait. I’d prefer not to start ignoring them.. Thanks for the help!

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/998#issuecomment-152106800 Will merge when Travis and Jenkins are green. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/981#issuecomment-152106955 @serbaut Will merge when Travis and Jenkins are green. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: squashed commit for dockerfiles part#2 in...

Github user terbolous commented on the pull request: https://github.com/apache/cloudstack/pull/999#issuecomment-152107883 The changes themselves LGTM, I can test them as well just to be sure, takes some time though :-) --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

Github user wilderrodrigues commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/998#discussion_r43352356 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py --- @@ -41,27 +41,37 @@ from cs.CsMonitor import CsMonitor from

[GitHub] cloudstack pull request: CLOUDSTACK-8957 - VR password server feat...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/998#issuecomment-152087954 Ping @remibergsma @karuturi @miguelaferreira Test results * Hardware required: false * Management Server + MySQL on CentOS 7.1 * One

  1   2   >