date:20160418

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

2016-04-18 Thread swill

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1397#issuecomment-211725428
  
@bhaisaab I am still getting compile errors.  I will reconfigure my CI 
environment to use an older version of Java to see if that fixes the problem.

```
Tests run: 13, Failures: 2, Errors: 1, Skipped: 0, Time elapsed: 0.477 sec 
<<< FAILURE! - in org.apache.cloudstack.network.lb.CertServiceTest

runUploadSslCertWithCAChain(org.apache.cloudstack.network.lb.CertServiceTest)  
Time elapsed: 0.033 sec  <<< ERROR!
com.cloud.utils.exception.CloudRuntimeException: Error parsing certificate 
data Parsing certificate/key failed: Could not parse certificate: 
java.io.IOException: Empty input
at 
org.apache.cloudstack.network.lb.CertServiceImpl.uploadSslCert(CertServiceImpl.java:150)
at 
org.apache.cloudstack.network.lb.CertServiceTest.runUploadSslCertWithCAChain(CertServiceTest.java:143)

runUploadSslCertBadChain(org.apache.cloudstack.network.lb.CertServiceTest)  
Time elapsed: 0.007 sec  <<< FAILURE!
java.lang.AssertionError: null
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at 
org.apache.cloudstack.network.lb.CertServiceTest.runUploadSslCertBadChain(CertServiceTest.java:290)


runUploadSslCertNoRootCert(org.apache.cloudstack.network.lb.CertServiceTest)  
Time elapsed: 0.021 sec  <<< FAILURE!
java.lang.AssertionError: null
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at 
org.apache.cloudstack.network.lb.CertServiceTest.runUploadSslCertNoRootCert(CertServiceTest.java:342)
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: systemvm: preserve file permissions, set ...

2016-04-18 Thread swill

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1420#issuecomment-211706714
  
Do I need to do anything special with this merge because it includes 
systemvm changes?  If I need to do anything special, please help me understand 
the details.  Sorry, I am still learning some of the finer details of being the 
RM.  :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: systemvm: preserve file permissions, set ...

2016-04-18 Thread swill

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1420#issuecomment-211706541
  
With these results, I think this PR is ready.  I will add it to my merge 
list.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: systemvm: preserve file permissions, set ...

2016-04-18 Thread swill

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1420#issuecomment-211706355
  





## CI RESULTS

### 84/85 TESTS PASSED

The test that failed is a test that commonly fails in my environment and 
has been verified to be an environment issue.


**Associated Uploads**

**`test_network_ZLVUJX`:**

* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1420/test_network_ZLVUJX/results.txt)

**`test_vpc_routers_GD5AQI`:**

* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1420/test_vpc_routers_GD5AQI/results.txt)


Uploads will be available until `2016-06-19 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/swill/upr).*




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: systemvm: preserve file permissions, set ...

2016-04-18 Thread swill

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1420#issuecomment-211706237
  





## CI RESULTS

### 84/85 TESTS PASSED

The test that failed is a test that commonly fails in my environment and 
has been verified to be an environment issue.


**Associated Uploads**

**`test_network_ZLVUJX`:**

* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1420/test_network_ZLVUJX/results.txt)



*Comment created by [`upr comment`](https://github.com/swill/upr).*




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: ACS PRs Status - 2016/04/18

2016-04-18 Thread Will Stevens

For sure.  I will be doing a status report every Monday till the RC is
accepted to help keep everyone on the same page.  I think this will help us
organize ourselves to best utilize our limited resources and keep us
focused on getting PRs ready to merge.

This will all be easier to manage when we move the repo to the
'apache-cloudstack' github org.  I need to follow up with the ASF on that,
I have just been too busy recently.  With the new org we will be able to
track the status of each PR and the blockers to getting it merged via
Labels, which will make things easier and more transparent to everyone.
Right now I just have a bunch of todo lists that I am trying to keep up to
date.  Tt is not a perfect system by any stretch.

If I can get more people participating in code review, I think things will
start to move a bit faster.  I will be getting more people setup with CI
environments so we can start to distribute the CI load a little more, that
should start to really get things moving.  Gotta start somewhere.  :)

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Mon, Apr 18, 2016 at 10:10 PM, ilya  wrote:

> Hi Will
>
> Thanks for the detailed update and effort.
>
> Please keep us posted.
>
> Regards
> ilya
>
> On 4/18/16 1:48 PM, Will Stevens wrote:
> > ACS PRs
> >
> >- 1452 - master (ready, pending LGTM)
> >- 1475 - 4.7 (pending clarification)
> >- 1420 - master + svm (CI running)
> >- 1365 - 4.7 (pending ALL)
> >- 1402 - 4.7 (needs work)
> >- 1454 - master (ready, pending LGTM)
> >- 1459 - master (rerun CI) NOTE: This closes #561
> >- 1409 - master (pending CI)
> >- 1433 - master (pending CI)
> >- 1230 - master (pending CI)
> >- 1326 - master (*pending CI)
> >- 1436 - master (*pending CI)
> >- 1455 - master (*pending CI)
> >- 1423 - master + svm (*pending CI)
> >- 1428 - master (pending ALL)
> >- 1450 - 4.7 (pending ALL)
> >- 1453 - master (pending ALL)
> >- 1403 - master (pending ALL)
> >- 1331 - 4.7 (pending ALL)
> >- 1475 - 4.7 (pending ALL)
> >- 1458 - master (pending ALL)
> >- 1297 - master (pending CI)
> >- 1410 - 4.7 (pending ALL)
> >- 1483 - 4.7 (pending ALL)
> >- 1470 - 4.7 (pending ALL)
> >- 1471 - 4.7 (pending ALL)
> >- 1472 - 4.7 (pending ALL)
> >- 1473 - 4.7 (pending LGTM)
> >- 1474 - 4.7 (pending ALL)
> >- 1486 - 4.7 (pending ALL)
> >- 1483 - 4.7 (pending ALL)
> >- 1488 - master (pending ALL)
> >- 872 - master + svm (pending CI)
> >- 1489 - master (pending CI)
> >- 1456 - 4.7 (pending ALL)
> >- 1412 - 4.6 (pending ALL)
> >- 1406 - 4.6 (pending LGTM)
> >- 1378 - 4.6 (pending LGTM)
> >- 1491 - 4.7 (pending ALL)
> >- 1360 - master (pending LGTM)
> >- 1490 - 4.7 (pending ALL)
> >- 1493 - master (pending ALL)
> >- 1397 - master (pending CI)
> >- 1499 - master (pending ALL)
> >- 1371 - master + svm (pending ALL)
> >- 1500 - master (pending ALL)
> >
> > * Denotes special requirements for CI testing
> > svm = specifies that the PR will require an updated systemvm template
> >
> > ---
> >
> > Here is this Monday's status report.  It is looking like we will need a
> new
> > systemvm template with the 4.9 release, so I would like to try to get on
> > top of the PRs that will require systemvm template changes so we can make
> > sure to get them tested and in earlier in this release window.  This will
> > give us more time to work out any kinks prior to the RC.
> >
> > Sorry for the slow down on the CI.  I have been having some hardware
> > issues, but I think I have resolved my issues (fingers crossed).  We now
> > have Daan up and running with a CI environment as well, so that will help
> > as well.  I owe a couple people instructions for getting a CI environment
> > setup so they can start testing.  I will hopefully be able to get to that
> > tomorrow.
> >
> > If you can review the list above and try to give me code reviews on
> > anything that has a status of 'pending LGTM' since I am only missing code
> > review for those PRs (assuming my status is up to date).  Also, I need to
> > start getting code reviews on the PRs that have a status of 'pending
> ALL'.
> >
> > There are a few PRs that have come up that are targeting 4.6.  I would
> like
> > some guidance for how I should be handling them.  My understanding is
> that
> > the 4.7 release is the oldest supported release, so should I be asking
> the
> > author to close the PR and open a PR against the 4.7 code?
> >
> > Hope you all had a great weekend.  Looking forward to a productive week
> > this week.  :)
> >
> > Cheers,
> >
> > Will
> >
>

Re: ACS PRs Status - 2016/04/18

2016-04-18 Thread ilya

Hi Will

Thanks for the detailed update and effort.

Please keep us posted.

Regards
ilya

On 4/18/16 1:48 PM, Will Stevens wrote:
> ACS PRs
> 
>- 1452 - master (ready, pending LGTM)
>- 1475 - 4.7 (pending clarification)
>- 1420 - master + svm (CI running)
>- 1365 - 4.7 (pending ALL)
>- 1402 - 4.7 (needs work)
>- 1454 - master (ready, pending LGTM)
>- 1459 - master (rerun CI) NOTE: This closes #561
>- 1409 - master (pending CI)
>- 1433 - master (pending CI)
>- 1230 - master (pending CI)
>- 1326 - master (*pending CI)
>- 1436 - master (*pending CI)
>- 1455 - master (*pending CI)
>- 1423 - master + svm (*pending CI)
>- 1428 - master (pending ALL)
>- 1450 - 4.7 (pending ALL)
>- 1453 - master (pending ALL)
>- 1403 - master (pending ALL)
>- 1331 - 4.7 (pending ALL)
>- 1475 - 4.7 (pending ALL)
>- 1458 - master (pending ALL)
>- 1297 - master (pending CI)
>- 1410 - 4.7 (pending ALL)
>- 1483 - 4.7 (pending ALL)
>- 1470 - 4.7 (pending ALL)
>- 1471 - 4.7 (pending ALL)
>- 1472 - 4.7 (pending ALL)
>- 1473 - 4.7 (pending LGTM)
>- 1474 - 4.7 (pending ALL)
>- 1486 - 4.7 (pending ALL)
>- 1483 - 4.7 (pending ALL)
>- 1488 - master (pending ALL)
>- 872 - master + svm (pending CI)
>- 1489 - master (pending CI)
>- 1456 - 4.7 (pending ALL)
>- 1412 - 4.6 (pending ALL)
>- 1406 - 4.6 (pending LGTM)
>- 1378 - 4.6 (pending LGTM)
>- 1491 - 4.7 (pending ALL)
>- 1360 - master (pending LGTM)
>- 1490 - 4.7 (pending ALL)
>- 1493 - master (pending ALL)
>- 1397 - master (pending CI)
>- 1499 - master (pending ALL)
>- 1371 - master + svm (pending ALL)
>- 1500 - master (pending ALL)
> 
> * Denotes special requirements for CI testing
> svm = specifies that the PR will require an updated systemvm template
> 
> ---
> 
> Here is this Monday's status report.  It is looking like we will need a new
> systemvm template with the 4.9 release, so I would like to try to get on
> top of the PRs that will require systemvm template changes so we can make
> sure to get them tested and in earlier in this release window.  This will
> give us more time to work out any kinks prior to the RC.
> 
> Sorry for the slow down on the CI.  I have been having some hardware
> issues, but I think I have resolved my issues (fingers crossed).  We now
> have Daan up and running with a CI environment as well, so that will help
> as well.  I owe a couple people instructions for getting a CI environment
> setup so they can start testing.  I will hopefully be able to get to that
> tomorrow.
> 
> If you can review the list above and try to give me code reviews on
> anything that has a status of 'pending LGTM' since I am only missing code
> review for those PRs (assuming my status is up to date).  Also, I need to
> start getting code reviews on the PRs that have a status of 'pending ALL'.
> 
> There are a few PRs that have come up that are targeting 4.6.  I would like
> some guidance for how I should be handling them.  My understanding is that
> the 4.7 release is the oldest supported release, so should I be asking the
> author to close the PR and open a PR against the 4.7 code?
> 
> Hope you all had a great weekend.  Looking forward to a productive week
> this week.  :)
> 
> Cheers,
> 
> Will
>

[GitHub] cloudstack-www pull request: Update events from the landing pages

2016-04-18 Thread pdion891

GitHub user pdion891 opened a pull request:

https://github.com/apache/cloudstack-www/pull/26

Update events from the landing pages

Unfortunatly this PR also include last update of the website which was made 
for the release of 4.8.

The only missing commit in the asf-site branch is " 4.8.0 with APIs, change 
copyright date to 2016" 51c4e97.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pdion891/cloudstack-www master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-www/pull/26.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #26


commit 51c4e97e66b3aab9edef196b5c6651a4e4341c8c
Author: Pierre-Luc Dion 
Date:   2016-02-14T22:14:11Z

4.8.0 with APIs, change copyright date to 2016

commit ab73675bfa9e8d0057aa93592622c9f45dfa196f
Author: Pierre-Luc Dion 
Date:   2016-04-19T01:08:41Z

update event section for 2016 events




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

2016-04-18 Thread nvazquez

Github user nvazquez commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-211585759
  
Cool, I'll work on it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

2016-04-18 Thread rafaelweingartner

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-211581957
  
That is it, and then this new class would extend ManagerBase.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

2016-04-18 Thread nvazquez

Github user nvazquez commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-211581223
  
@rafaelweingartner I pushed unit tests for this new methods.
So the idea is that the 3 classes extend from a new class and not 
ManagerBase?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

ACS PRs Status - 2016/04/18

2016-04-18 Thread Will Stevens

ACS PRs

   - 1452 - master (ready, pending LGTM)
   - 1475 - 4.7 (pending clarification)
   - 1420 - master + svm (CI running)
   - 1365 - 4.7 (pending ALL)
   - 1402 - 4.7 (needs work)
   - 1454 - master (ready, pending LGTM)
   - 1459 - master (rerun CI) NOTE: This closes #561
   - 1409 - master (pending CI)
   - 1433 - master (pending CI)
   - 1230 - master (pending CI)
   - 1326 - master (*pending CI)
   - 1436 - master (*pending CI)
   - 1455 - master (*pending CI)
   - 1423 - master + svm (*pending CI)
   - 1428 - master (pending ALL)
   - 1450 - 4.7 (pending ALL)
   - 1453 - master (pending ALL)
   - 1403 - master (pending ALL)
   - 1331 - 4.7 (pending ALL)
   - 1475 - 4.7 (pending ALL)
   - 1458 - master (pending ALL)
   - 1297 - master (pending CI)
   - 1410 - 4.7 (pending ALL)
   - 1483 - 4.7 (pending ALL)
   - 1470 - 4.7 (pending ALL)
   - 1471 - 4.7 (pending ALL)
   - 1472 - 4.7 (pending ALL)
   - 1473 - 4.7 (pending LGTM)
   - 1474 - 4.7 (pending ALL)
   - 1486 - 4.7 (pending ALL)
   - 1483 - 4.7 (pending ALL)
   - 1488 - master (pending ALL)
   - 872 - master + svm (pending CI)
   - 1489 - master (pending CI)
   - 1456 - 4.7 (pending ALL)
   - 1412 - 4.6 (pending ALL)
   - 1406 - 4.6 (pending LGTM)
   - 1378 - 4.6 (pending LGTM)
   - 1491 - 4.7 (pending ALL)
   - 1360 - master (pending LGTM)
   - 1490 - 4.7 (pending ALL)
   - 1493 - master (pending ALL)
   - 1397 - master (pending CI)
   - 1499 - master (pending ALL)
   - 1371 - master + svm (pending ALL)
   - 1500 - master (pending ALL)

* Denotes special requirements for CI testing
svm = specifies that the PR will require an updated systemvm template

---

Here is this Monday's status report.  It is looking like we will need a new
systemvm template with the 4.9 release, so I would like to try to get on
top of the PRs that will require systemvm template changes so we can make
sure to get them tested and in earlier in this release window.  This will
give us more time to work out any kinks prior to the RC.

Sorry for the slow down on the CI.  I have been having some hardware
issues, but I think I have resolved my issues (fingers crossed).  We now
have Daan up and running with a CI environment as well, so that will help
as well.  I owe a couple people instructions for getting a CI environment
setup so they can start testing.  I will hopefully be able to get to that
tomorrow.

If you can review the list above and try to give me code reviews on
anything that has a status of 'pending LGTM' since I am only missing code
review for those PRs (assuming my status is up to date).  Also, I need to
start getting code reviews on the PRs that have a status of 'pending ALL'.

There are a few PRs that have come up that are targeting 4.6.  I would like
some guidance for how I should be handling them.  My understanding is that
the 4.7 release is the oldest supported release, so should I be asking the
author to close the PR and open a PR against the 4.7 code?

Hope you all had a great weekend.  Looking forward to a productive week
this week.  :)

Cheers,

Will

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

2016-04-18 Thread swill

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1365#issuecomment-211565374
  
@rafaelweingartner I am not sure.  @bhaisaab would you mind clarifying for 
us.  I am trying to stay on top of this stuff, but I am very much playing 
catchup.  :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Bump ssh retries to prevent false positiv...

2016-04-18 Thread swill

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1473#issuecomment-211563985
  
@remibergsma apparently Jenkins doesn't like us much now days.  Can you do 
a force push again for me.  Also, I am looking for another LGTM on this PR.  
Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

2016-04-18 Thread swill

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1454#issuecomment-211563367
  
@abhinandanprateek, I believe you are away this week, but can your address 
@jburwell's comments when you have a chance.  Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Check the existence of 'forceencap' param...

2016-04-18 Thread swill

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1402#issuecomment-211562114
  
@remibergsma can you review the functionality you expect.  I think the 
logic is wrong, and if it is not, then it is VERY misleading.

The code in question that is being executed is this: 
`CsHelper.bool_to_yn(obj['encap'])`

For reference, this is the code being executed:
```
def bool_to_yn(val):
if val:
return "yes"
return "no"
```

If I just read your code, I would assume you would want the final result to 
be `forceencaps=no`, but this code as written will result in `forceencaps=yes`.

Here is a simple test to prove the case...


![image](https://cloud.githubusercontent.com/assets/13644/14618718/f7f43556-0581-11e6-8ffb-2efd1577d433.png)

I think @alexandrelimassantana is right.  In order to get the expected 
behavior, you need to use the boolean `False`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

2016-04-18 Thread rafaelweingartner

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1365#issuecomment-211555695
  
@swill my final state is LGTM, will this be merged forward?
I believe @bhaisaab has mentioned that he has another PR that bumps VMware 
dependencies and that makes this PR obsolete, right? Or am my mistaking this 
with other PR?




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

2016-04-18 Thread rafaelweingartner

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-211553575
  
@nvazquez thanks for the analysis on the ManagerBase issue.
Giving that I think the best approach would be to let all of the three (3) 
classes extending it, and then we could create a hierarchy, instead of using 
static methods.

What do you think?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

2016-04-18 Thread swill

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1365#issuecomment-211554643
  
I think this one is pretty close.  I want to run CI against it since there 
have been changes since the last CI run.  I also need some LGTM code reviews.  
I don't see any yet even though there has been some pretty extensive review of 
this PR so far.  Can @jburwell @GabrielBrascher and @rafaelweingartner revisit 
this PR and give me your final review of the current state.  Thx...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

2016-04-18 Thread swill

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1500#issuecomment-211551366
  
would you mind squashing your commits for this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

CLOUDSTACK-9349: Enable root disk detach for KVM with new Marvin tests PR#1500

2016-04-18 Thread David Mabry

Hello all,

I submitted PR 1500 this morning that addresses JIRA issue CLOUDSTACK-9349 
around KVM Root Volume detach/attach.  This was really a very minor code change 
to java, but I also submitted a marvin integration test that I would love to 
get some feedback on.  This was my first pass at writing a marvin unit test and 
I did my best to follow the same style I saw in test_volumes.py, but again I 
would love to have someone more familiar with marvin take a look and make sure 
everything looks right to them.

Please see the original PR submission below for more details.

Thanks in advance for the feedback.

Thanks,
David Mabry





On 4/18/16, 8:20 AM, "dmabry"  wrote:

>GitHub user dmabry opened a pull request:
>
>https://github.com/apache/cloudstack/pull/1500
>
>CLOUDSTACK-9349
>
>This PR addresses the KVM detach/attach ROOT disks from VMs 
> (CLOUDSTACK-9349).  In short, this allows the KVM Hypervisor, and I added the 
> Simulator as a valid hypervisor for ease of development and testing of 
> marvin, to detach a root volume and the reattach a root volume using the 
> deviceid=0 flag to the attachVolume API.  I have also written a marvin 
> integration test that verifies this feature works for both KVM and the 
> Simulator.
>
>Below is the marvin results files of the full marvin test_volumes.py.  All 
> tests pass, including the new root detach/attach, on our KVM lab running with 
> the patches in this PR.
>
>
> [test_volumes_KIR4G3.zip](https://github.com/apache/cloudstack/files/223799/test_volumes_KIR4G3.zip)
>
>
>You can merge this pull request into a Git repository by running:
>
>$ git pull https://github.com/myENA/cloudstack KVM_root_detach
>
>Alternatively you can review and apply these changes as the patch at:
>
>https://github.com/apache/cloudstack/pull/1500.patch
>
>To close this pull request, make a commit to your master/trunk branch
>with (at least) the following in the commit message:
>
>This closes #1500
>
>
>commit 48ce76344040de2ab8014f76292abe0421d42f85
>Author: Simon Weller 
>Date:   2016-03-24T19:55:34Z
>
>Merge pull request #4 from apache/4.7
>
>4.7 PR
>
>commit d0a02640dfd4878da81a2e59588c4b5ff2a06401
>Author: Simon Weller 
>Date:   2016-04-14T13:28:37Z
>
>Let hypervisor type KVM detach root volumes
>
>commit 7807955433cea390bb7358e3bb90dbc9cc06bbea
>Author: David Mabry 
>Date:   2016-04-15T12:30:07Z
>
>updated test_volumes.py to include a test for detaching and reattaching a 
> root volume from a vm.  I also had to update base.py to all attach_volume to 
> have the parameter deviceid to be passed as needed.
>
>commit d7d55630daff4a5e17c9a374dc2e9bc478dff808
>Author: David Mabry 
>Date:   2016-04-18T02:41:29Z
>
>Added Simulator as valid hypervisor for root detach
>
>
>
>
>---
>If your project is set up for it, you can reply to this email and have your
>reply appear on GitHub as well. If your project does not have this feature
>enabled and wishes so, or if the feature is enabled but not working, please
>contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
>with INFRA.
>---

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

2016-04-18 Thread swill

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1371#issuecomment-211541350
  
Can you rebase this PR based on the current master so we can resolve the 
conflicts so we can get CI running against this again.  I want to do a push on 
the PRs that change the systemvms so we can get a head start on that before the 
release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

2016-04-18 Thread nvazquez

Github user nvazquez commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-211540538
  
Cool, I'll working on test cases.
`VMSnapshotManagerImpl` is using `_name` variable from `ManagerBase,` and 
`SnapshotManagerImpl` overrides `configure`, `start` and `stop` method


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Strongswan vpn feature

2016-04-18 Thread swill

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/872#issuecomment-211539172
  
I would like to get on top of the PRs that have systemvm changes, because 
it looks like we will have to push new systemvms for the 4.9 release.  We still 
have a bit of time, but I would like to have some breathing room getting the 
PRs in that have systemvm changes to make sure we have everything ironed out 
before the RC.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-04-18 Thread swill

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1423#issuecomment-211537431
  
Ok, thanks @bhaisaab.  So I need to get on the systemvm template stuff asap 
to try to get those PRs in a good place so we have a little breathing room 
before the RC date to work out any kinks.  Thanks for the help on this.  :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-04-18 Thread bhaisaab

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1423#issuecomment-211524917
  
@swill we can ask around on ML, afaik in addition to strongswan I known of 
the ospf stuff by @abhinandanprateek which needs zebra and related packages for 
ospf. Abhi is on leave this week, but we can discuss this next week. In 
general, we should evaluate and build a new systemvm template based on what new 
features end up in master until the freeze date in May (as you had shared on 
dev@).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed unnecessary code from getGuestOsT...

2016-04-18 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1262


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Strange XenServer SR behavior when deploying system VMs in Basic Zone on 4.9

2016-04-18 Thread Tutkowski, Mike

Thanks!

It's no rush from my point of view. Just happy to know it looks like the 
problem's been fixed. :)


From: Rafael Weingärtner 
Sent: Monday, April 18, 2016 11:41 AM
To: dev@cloudstack.apache.org
Subject: Re: Strange XenServer SR behavior when deploying system VMs in Basic 
Zone on 4.9

We found it last Saturday during the factoring of a test case! That was
pure lucky.

The code of the PR is not that good yet. But, we will work to get it ready
to be reviewed and merged.

On Mon, Apr 18, 2016 at 2:37 PM, Tutkowski, Mike 
wrote:

> Thanks, Rafael! That very much looks like it could solve the problem.
>
> I've subscribed to the PR for notifications. Once I see it's in the
> codebase, I can re-build my dev environment and see if I still have the
> issue.
> 
> From: Rafael Weingärtner 
> Sent: Monday, April 18, 2016 8:07 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Strange XenServer SR behavior when deploying system VMs in
> Basic Zone on 4.9
>
> Would the problem discussed here relate to the one here
> https://github.com/apache/cloudstack/pull/1499?
>
> On Mon, Apr 18, 2016 at 11:04 AM, Tutkowski, Mike <
> mike.tutkow...@netapp.com
> > wrote:
>
> > Looks like I already opened a ticket on this in January. :)
> >
> > https://issues.apache.org/jira/browse/CLOUDSTACK-9224
> >
> > I added info to it.
> > 
> > From: Tutkowski, Mike 
> > Sent: Saturday, April 16, 2016 9:58 AM
> > To: dev@cloudstack.apache.org
> > Subject: Re: Strange XenServer SR behavior when deploying system VMs in
> > Basic Zone on 4.9
> >
> > Thanks, Adrian!
> >
> > In my case, it's a dev environment, so it's not really hurting anything
> > (it just seems like weird behavior, so I was curious if others were
> seeing
> > it).
> >
> > I can create a ticket in Jira and add your info and mine to it.
> >
> > Thanks again!
> >
> > > On Apr 16, 2016, at 4:43 AM, Adrian Sender 
> > wrote:
> > >
> > > Hi Mike,
> > >
> > > Hi have observed this behavior on CCP 4.3.x mostly and xenserver 6.5
> > less so
> > > in 4.5.1. I use Fiber Channel LVMoHBA as the primary storage.
> > >
> > > Seems like the same issue.
> > >
> > > Disk Attached to Dom0 after snapshot or copy from secondary to primary:
> > >
> > > In this example we have a disk attached to dom0, we cannot delete the
> > disk
> > > until we detach it.
> > >
> > > admin.rc.precise 0 Created by template provisioner 42 GB   Control
> > domain on
> > > host cpms1-1.nsp.testlabs.com.au
> > >
> > > [root@cpms1-1 ~]# xe vdi-list name-label="admin.rc.precise 0"
> > >
> > > uuid ( RO): 3d79722b-294d-4358-bc57-af92b9e9dda7
> > > name-label ( RW): admin.rc.precise 0
> > >   name-description ( RW): Created by template provisioner
> > >sr-uuid ( RO): dce1ec02-cce0-347d-0679-f39c9ea64da1
> > >   virtual-size ( RO): 45097156608
> > >   sharable ( RO): false
> > >  read-only ( RO): false
> > >
> > > You will want to list out the VBD (connector object between VM and VDI)
> > based
> > > on the VDI UUID. Here is an example:
> > >
> > > [root@cpms1-1 ~]# xe vbd-list
> > vdi-uuid=3d79722b-294d-4358-bc57-af92b9e9dda7
> > >
> > > uuid ( RO) : d9e2d89e-a82f-9e6e-c97a-afe0af47468e
> > > vm-uuid ( RO): 0f4cb186-0167-47d6-afb5-89b00102250b
> > >   vm-name-label ( RO): Control domain on host:
> cpms1-1.nsp.nectar.org.au
> > >vdi-uuid ( RO): 3d79722b-294d-4358-bc57-af92b9e9dda7
> > >   empty ( RO): false
> > >  device ( RO):
> > >
> > >
> > > Once done, you want to first try to make VBD inactive (it may already
> be
> > > inactive), "The device is not currently attached"
> > >
> > > xe vbd-unplug uuid=d9e2d89e-a82f-9e6e-c97a-afe0af47468e
> > >
> > > Once done, you can then break the connection:
> > >
> > > xe vbd-destroy uuid=
> > >
> > > Now you can delete the disk from xencenter
> > >
> > > Regards,
> > > Adrian Sender
> > >
> > >
> > >
> > > -- Original Message ---
> > > From: Anshul Gangwar 
> > > To: "dev@cloudstack.apache.org" 
> > > Sent: Fri, 15 Apr 2016 06:48:59 +
> > > Subject: Re: Strange XenServer SR behavior when deploying system VMs in
> > Basic
> > > Zone on 4.9
> > >
> > >> Mike, what type of storage are you using?
> > >>
> > >>> On 15-Apr-2016, at 9:49 AM, Tutkowski, Mike <
> mike.tutkow...@netapp.com>
> > wrote:
> > >>>
> > >>> I'm not sure, Daan.
> > >>>
> > >>> I plan to keep an eye on this behavior for a while when creating new
> > clouds.
> > >>>
> > >>> 
> > >>> From: Daan Hoogland 
> > >>> Sent: Thursday, April 14, 2016 2:12 AM
> > >>> To: dev
> > >>> Subject: Re: Strange XenServer SR behavior when

[GitHub] cloudstack pull request: Fixing an issue in Marvin around creating...

2016-04-18 Thread mike-tutkowski

GitHub user mike-tutkowski opened a pull request:

https://github.com/apache/cloudstack/pull/1501

Fixing an issue in Marvin around creating a template from a snapshot

This fixes the following ticket: 
https://issues.apache.org/jira/browse/CLOUDSTACK-9354

The problem was that Marvin was requiring you to pass in the "ispublic" 
parameter when creating a template from a snapshot.

As the ticket notes, this issue was introduced by the following commit: 
https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=bbe0fc4be9527d51820b067a602886003991db4d

The solution I've provided is simply to check if the "ispublic" property is 
in the dictionary before referencing it.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mike-tutkowski/cloudstack cs-9354

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1501.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1501


commit df85825c1a7870b2de56898fb15ff2bb8323b490
Author: Mike Tutkowski 
Date:   2016-04-18T17:56:08Z

CLOUDSTACK-9354 - Fixing an issue in Marvin around creating a template from 
a snapshot (if âis publicâ is not provided, there was a problem)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

2016-04-18 Thread rafaelweingartner

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-211499145
  
@nv I am sorry, I might have seen the â@Localâ annotation in some other 
PR, and I thought I have seen on yours.

The classes VMSnapshotManagerImpl and SnapshotManagerImpl are using 
something from âManagerBaseâ?

I am ok with the static methods if there is no way to create a class 
hierarchic. They are clean and well documented. I am only missing the test 
cases for those two new methods.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-04-18 Thread swill

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1423#issuecomment-211502237
  
@bhaisaab Ok thanks.  Are there other things we want to get into the 
systemvm template if we do publish a new one?  Probably not the best place for 
this discussion, but maybe this is something we should discuss on dev@?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Strange XenServer SR behavior when deploying system VMs in Basic Zone on 4.9

2016-04-18 Thread Rafael Weingärtner

We found it last Saturday during the factoring of a test case! That was
pure lucky.

The code of the PR is not that good yet. But, we will work to get it ready
to be reviewed and merged.

On Mon, Apr 18, 2016 at 2:37 PM, Tutkowski, Mike 
wrote:

> Thanks, Rafael! That very much looks like it could solve the problem.
>
> I've subscribed to the PR for notifications. Once I see it's in the
> codebase, I can re-build my dev environment and see if I still have the
> issue.
> 
> From: Rafael Weingärtner 
> Sent: Monday, April 18, 2016 8:07 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Strange XenServer SR behavior when deploying system VMs in
> Basic Zone on 4.9
>
> Would the problem discussed here relate to the one here
> https://github.com/apache/cloudstack/pull/1499?
>
> On Mon, Apr 18, 2016 at 11:04 AM, Tutkowski, Mike <
> mike.tutkow...@netapp.com
> > wrote:
>
> > Looks like I already opened a ticket on this in January. :)
> >
> > https://issues.apache.org/jira/browse/CLOUDSTACK-9224
> >
> > I added info to it.
> > 
> > From: Tutkowski, Mike 
> > Sent: Saturday, April 16, 2016 9:58 AM
> > To: dev@cloudstack.apache.org
> > Subject: Re: Strange XenServer SR behavior when deploying system VMs in
> > Basic Zone on 4.9
> >
> > Thanks, Adrian!
> >
> > In my case, it's a dev environment, so it's not really hurting anything
> > (it just seems like weird behavior, so I was curious if others were
> seeing
> > it).
> >
> > I can create a ticket in Jira and add your info and mine to it.
> >
> > Thanks again!
> >
> > > On Apr 16, 2016, at 4:43 AM, Adrian Sender 
> > wrote:
> > >
> > > Hi Mike,
> > >
> > > Hi have observed this behavior on CCP 4.3.x mostly and xenserver 6.5
> > less so
> > > in 4.5.1. I use Fiber Channel LVMoHBA as the primary storage.
> > >
> > > Seems like the same issue.
> > >
> > > Disk Attached to Dom0 after snapshot or copy from secondary to primary:
> > >
> > > In this example we have a disk attached to dom0, we cannot delete the
> > disk
> > > until we detach it.
> > >
> > > admin.rc.precise 0 Created by template provisioner 42 GB   Control
> > domain on
> > > host cpms1-1.nsp.testlabs.com.au
> > >
> > > [root@cpms1-1 ~]# xe vdi-list name-label="admin.rc.precise 0"
> > >
> > > uuid ( RO): 3d79722b-294d-4358-bc57-af92b9e9dda7
> > > name-label ( RW): admin.rc.precise 0
> > >   name-description ( RW): Created by template provisioner
> > >sr-uuid ( RO): dce1ec02-cce0-347d-0679-f39c9ea64da1
> > >   virtual-size ( RO): 45097156608
> > >   sharable ( RO): false
> > >  read-only ( RO): false
> > >
> > > You will want to list out the VBD (connector object between VM and VDI)
> > based
> > > on the VDI UUID. Here is an example:
> > >
> > > [root@cpms1-1 ~]# xe vbd-list
> > vdi-uuid=3d79722b-294d-4358-bc57-af92b9e9dda7
> > >
> > > uuid ( RO) : d9e2d89e-a82f-9e6e-c97a-afe0af47468e
> > > vm-uuid ( RO): 0f4cb186-0167-47d6-afb5-89b00102250b
> > >   vm-name-label ( RO): Control domain on host:
> cpms1-1.nsp.nectar.org.au
> > >vdi-uuid ( RO): 3d79722b-294d-4358-bc57-af92b9e9dda7
> > >   empty ( RO): false
> > >  device ( RO):
> > >
> > >
> > > Once done, you want to first try to make VBD inactive (it may already
> be
> > > inactive), "The device is not currently attached"
> > >
> > > xe vbd-unplug uuid=d9e2d89e-a82f-9e6e-c97a-afe0af47468e
> > >
> > > Once done, you can then break the connection:
> > >
> > > xe vbd-destroy uuid=
> > >
> > > Now you can delete the disk from xencenter
> > >
> > > Regards,
> > > Adrian Sender
> > >
> > >
> > >
> > > -- Original Message ---
> > > From: Anshul Gangwar 
> > > To: "dev@cloudstack.apache.org" 
> > > Sent: Fri, 15 Apr 2016 06:48:59 +
> > > Subject: Re: Strange XenServer SR behavior when deploying system VMs in
> > Basic
> > > Zone on 4.9
> > >
> > >> Mike, what type of storage are you using?
> > >>
> > >>> On 15-Apr-2016, at 9:49 AM, Tutkowski, Mike <
> mike.tutkow...@netapp.com>
> > wrote:
> > >>>
> > >>> I'm not sure, Daan.
> > >>>
> > >>> I plan to keep an eye on this behavior for a while when creating new
> > clouds.
> > >>>
> > >>> 
> > >>> From: Daan Hoogland 
> > >>> Sent: Thursday, April 14, 2016 2:12 AM
> > >>> To: dev
> > >>> Subject: Re: Strange XenServer SR behavior when deploying system VMs
> in
> > > Basic Zone on 4.9
> > >>>
> > >>> Mike, did the iso copy process not complete as expected. Sound like
> > they
> > >>> are a remanence of some task ending in an exception. Probably a
> > silently
> > >>> ignored one ;|
> > >>>
> > >>> On Thu, Apr 14, 2016 at 2:49 AM, Tutkowski, Mike <
> > mike.tutkow...@netapp.com>
> > >>> wrote:
> >

Re: Strange XenServer SR behavior when deploying system VMs in Basic Zone on 4.9

2016-04-18 Thread Tutkowski, Mike

Thanks, Rafael! That very much looks like it could solve the problem.

I've subscribed to the PR for notifications. Once I see it's in the codebase, I 
can re-build my dev environment and see if I still have the issue.

From: Rafael Weingärtner 
Sent: Monday, April 18, 2016 8:07 AM
To: dev@cloudstack.apache.org
Subject: Re: Strange XenServer SR behavior when deploying system VMs in Basic 
Zone on 4.9

Would the problem discussed here relate to the one here
https://github.com/apache/cloudstack/pull/1499?

On Mon, Apr 18, 2016 at 11:04 AM, Tutkowski, Mike  wrote:

> Looks like I already opened a ticket on this in January. :)
>
> https://issues.apache.org/jira/browse/CLOUDSTACK-9224
>
> I added info to it.
> 
> From: Tutkowski, Mike 
> Sent: Saturday, April 16, 2016 9:58 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Strange XenServer SR behavior when deploying system VMs in
> Basic Zone on 4.9
>
> Thanks, Adrian!
>
> In my case, it's a dev environment, so it's not really hurting anything
> (it just seems like weird behavior, so I was curious if others were seeing
> it).
>
> I can create a ticket in Jira and add your info and mine to it.
>
> Thanks again!
>
> > On Apr 16, 2016, at 4:43 AM, Adrian Sender 
> wrote:
> >
> > Hi Mike,
> >
> > Hi have observed this behavior on CCP 4.3.x mostly and xenserver 6.5
> less so
> > in 4.5.1. I use Fiber Channel LVMoHBA as the primary storage.
> >
> > Seems like the same issue.
> >
> > Disk Attached to Dom0 after snapshot or copy from secondary to primary:
> >
> > In this example we have a disk attached to dom0, we cannot delete the
> disk
> > until we detach it.
> >
> > admin.rc.precise 0 Created by template provisioner 42 GB   Control
> domain on
> > host cpms1-1.nsp.testlabs.com.au
> >
> > [root@cpms1-1 ~]# xe vdi-list name-label="admin.rc.precise 0"
> >
> > uuid ( RO): 3d79722b-294d-4358-bc57-af92b9e9dda7
> > name-label ( RW): admin.rc.precise 0
> >   name-description ( RW): Created by template provisioner
> >sr-uuid ( RO): dce1ec02-cce0-347d-0679-f39c9ea64da1
> >   virtual-size ( RO): 45097156608
> >   sharable ( RO): false
> >  read-only ( RO): false
> >
> > You will want to list out the VBD (connector object between VM and VDI)
> based
> > on the VDI UUID. Here is an example:
> >
> > [root@cpms1-1 ~]# xe vbd-list
> vdi-uuid=3d79722b-294d-4358-bc57-af92b9e9dda7
> >
> > uuid ( RO) : d9e2d89e-a82f-9e6e-c97a-afe0af47468e
> > vm-uuid ( RO): 0f4cb186-0167-47d6-afb5-89b00102250b
> >   vm-name-label ( RO): Control domain on host: cpms1-1.nsp.nectar.org.au
> >vdi-uuid ( RO): 3d79722b-294d-4358-bc57-af92b9e9dda7
> >   empty ( RO): false
> >  device ( RO):
> >
> >
> > Once done, you want to first try to make VBD inactive (it may already be
> > inactive), "The device is not currently attached"
> >
> > xe vbd-unplug uuid=d9e2d89e-a82f-9e6e-c97a-afe0af47468e
> >
> > Once done, you can then break the connection:
> >
> > xe vbd-destroy uuid=
> >
> > Now you can delete the disk from xencenter
> >
> > Regards,
> > Adrian Sender
> >
> >
> >
> > -- Original Message ---
> > From: Anshul Gangwar 
> > To: "dev@cloudstack.apache.org" 
> > Sent: Fri, 15 Apr 2016 06:48:59 +
> > Subject: Re: Strange XenServer SR behavior when deploying system VMs in
> Basic
> > Zone on 4.9
> >
> >> Mike, what type of storage are you using?
> >>
> >>> On 15-Apr-2016, at 9:49 AM, Tutkowski, Mike 
> wrote:
> >>>
> >>> I'm not sure, Daan.
> >>>
> >>> I plan to keep an eye on this behavior for a while when creating new
> clouds.
> >>>
> >>> 
> >>> From: Daan Hoogland 
> >>> Sent: Thursday, April 14, 2016 2:12 AM
> >>> To: dev
> >>> Subject: Re: Strange XenServer SR behavior when deploying system VMs in
> > Basic Zone on 4.9
> >>>
> >>> Mike, did the iso copy process not complete as expected. Sound like
> they
> >>> are a remanence of some task ending in an exception. Probably a
> silently
> >>> ignored one ;|
> >>>
> >>> On Thu, Apr 14, 2016 at 2:49 AM, Tutkowski, Mike <
> mike.tutkow...@netapp.com>
> >>> wrote:
> >>>
>  Just an FYI, but when I kicked off my first VM in this cloud, the VR
>  happened to get deployed to XenServer-6.5-3 (which was one of my
> XenServer
>  hosts that had an un-expected shared SR pointing at secondary storage
>  beforehand).
> 
>  Once the process of copying the system template down to local storage
>  completed, the shared SR pointing at secondary storage went away (as
> you
>  would expect).
> 
>  This leaves me now with one un-expected shared SR pointing at
> secondary
>  storage on

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

2016-04-18 Thread nvazquez

Github user nvazquez commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-211487161
  
Thanks @rafaelweingartner I made a refactor based in your comments. I could 
remove "extends ManagerBase" from QueryManagerImpl but not from 
VMSnapshotManagerImpl and SnapshotManagerImpl so I 
decided to create static methods and use the new class as a helper instead of a 
superclass, do you think this is ok?

I couldn't find @Local to remove it, in which file did you 
mean to remove it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-04-18 Thread rafaelweingartner

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1331#issuecomment-211485538
  
I agree with you @syed, it is always good to discuss the patterns we use.
That example you brought up also works; it would do the same tricky to 
test, but using an appender stead of mocking. I am good with that too; I just 
coded differently, because I do not like much the idea of getting log entries 
by hand. But, I am willing to go either way. If you go the other way, please 
revert my commit, so the history does not get messed up.

For the new tests you have to write, you could mock the creation of the 
Object buffered writer, to one that you can control and check if the 
âwriteâ method is been used as expected. In other words, writing the 
strings you expect to write.
Here there is an example of that for the File class (it is not the same, 
but it will give you an idea):
http://stackoverflow.com/questions/11849728/simulate-file-in-java


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

2016-04-18 Thread Rafael Weingärtner

As I said I understand the check of "vm!= null". I was only referring to
the "vm.getType". I did not know that it could not be null.

I think what you were trying to say is that, once "vm" object is not null,
there is no way "getType" can return null, right? If that is a sure thing,
I am ok with the way it is right now.

On Mon, Apr 18, 2016 at 2:12 PM, bhaisaab  wrote:

> Github user bhaisaab commented on a diff in the pull request:
>
> https://github.com/apache/cloudstack/pull/1365#discussion_r60096454
>
> --- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
> @@ -1835,6 +1847,26 @@ private Volume
> orchestrateDetachVolumeFromVM(long vmId, long volumeId) {
>  }
>  }
>
> +public void updateMissingRootDiskController(final VMInstanceVO
> vm, final String rootVolChainInfo) {
> +if (vm == null ||
> !vm.getType().equals(VirtualMachine.Type.User) ||
> Strings.isNullOrEmpty(rootVolChainInfo)) {
> --- End diff --
>
> the order of evalution will be left to right -- the first case is vm
> == null; if this qualifies the if statement will branch into executing
> code; otherwise vm.getType() code will be executed (i.e. vm is not null);
> now here I think you're suggesting that perhaps vm.getType() may return
> null in which case we may have a NPE (unlikely based on db contraints (the
> type column should not be null), but I'll modify as suggested.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>



-- 
Rafael Weingärtner

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-04-18 Thread bhaisaab

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1423#issuecomment-211481666
  
@swill we'll need to publish a new systemvm template (i.e. we can no longer 
use the 4.6 systemvm template)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

2016-04-18 Thread bhaisaab

Github user bhaisaab commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1365#discussion_r60096454
  
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1835,6 +1847,26 @@ private Volume orchestrateDetachVolumeFromVM(long 
vmId, long volumeId) {
 }
 }
 
+public void updateMissingRootDiskController(final VMInstanceVO vm, 
final String rootVolChainInfo) {
+if (vm == null || !vm.getType().equals(VirtualMachine.Type.User) 
|| Strings.isNullOrEmpty(rootVolChainInfo)) {
--- End diff --

the order of evalution will be left to right -- the first case is vm == 
null; if this qualifies the if statement will branch into executing code; 
otherwise vm.getType() code will be executed (i.e. vm is not null); now here I 
think you're suggesting that perhaps vm.getType() may return null in which case 
we may have a NPE (unlikely based on db contraints (the type column should not 
be null), but I'll modify as suggested.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

2016-04-18 Thread rafaelweingartner

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1365#issuecomment-211479815
  
if you say so.
Be my guest.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

2016-04-18 Thread bhaisaab

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1365#issuecomment-211479011
  
@rafaelweingartner both your comments are opinionated and not technical; 
we've to agree to disagree here ask you to be practical and pragmatic here. 
I've left comments above and I disagree on both mentioned places. Finally, what 
you would consider may be a huge change but for me a +190/-42 lines is not 
huge. If you go on this path, you might even find issues with quarks and 
neutrinos, and there is no end to over-engineering. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

2016-04-18 Thread rafaelweingartner

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1365#discussion_r60095758
  
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1835,6 +1847,26 @@ private Volume orchestrateDetachVolumeFromVM(long 
vmId, long volumeId) {
 }
 }
 
+public void updateMissingRootDiskController(final VMInstanceVO vm, 
final String rootVolChainInfo) {
+if (vm == null || !vm.getType().equals(VirtualMachine.Type.User) 
|| Strings.isNullOrEmpty(rootVolChainInfo)) {
--- End diff --

@bhaisaab I was no talking about removing the "vm != null", that check I 
know we need to execute. 
I was only refering to the "vm.getType().equals(VirtualMachine.Type.User)", 
the "vm.getType" can return a null value.

Did you understand what I mean? Just inverting the comparison as I said 
before.
from
`vm.getType().equals(VirtualMachine.Type.User)`
to 
`VirtualMachine.Type.User.equals(vm.getType())`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

2016-04-18 Thread bhaisaab

Github user bhaisaab commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1365#discussion_r60095074
  
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1835,6 +1847,26 @@ private Volume orchestrateDetachVolumeFromVM(long 
vmId, long volumeId) {
 }
 }
 
+public void updateMissingRootDiskController(final VMInstanceVO vm, 
final String rootVolChainInfo) {
+if (vm == null || !vm.getType().equals(VirtualMachine.Type.User) 
|| Strings.isNullOrEmpty(rootVolChainInfo)) {
--- End diff --

@rafaelweingartner we'll get NPE anyway, we'll have to check vm != null as 
in what you've suggested we're doing equals against vm.getType() (therefore 
vm!=null check needed here).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-8562: add informati...

2016-04-18 Thread bhaisaab

Github user bhaisaab commented on the pull request:


https://github.com/apache/cloudstack-docs-admin/pull/37#issuecomment-211475206
  
Thanks @pdion891 sure after the freeze date, we can add to the release 
notes list of new APIs, list of new features along with any major changes etc.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

2016-04-18 Thread syed

Github user syed commented on the pull request:

https://github.com/apache/cloudstack/pull/1331#issuecomment-211455173
  
Loving the discussion here guys! Based on the comments by @jburwell I found 
http://stackoverflow.com/questions/1827677/how-to-do-a-junit-assert-on-a-message-in-a-logger
  @rafaelweingartner I would like your opinion on this. 

I've also added a function which basically writes the `template.properties` 
file out to the disk. Now I was thinking of mocking the `BufferedWriter` in 
that function and somehow catch the output and assert it with an expected 
output but the writer is a variable which is local to that function. How do 
mock that @rafaelweingartner 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...

2016-04-18 Thread DaanHoogland

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1452#issuecomment-211453267
  
@pedro-martins can you live with the present state?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed unnecessary code from getGuestOsT...

2016-04-18 Thread swill

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1262#issuecomment-211441451
  
Ok perfect, thanks @rafaelweingartner.  I will get this merged...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed unnecessary code from getGuestOsT...

2016-04-18 Thread rafaelweingartner

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1262#issuecomment-211438727
  
@swill thanks for the support.
I have already been very critical with this PR even before it was opened. 
So, the way it is now, it is good to be merged. There is only one thing I did 
not like at "CitrixResourceBaseTest .java", but as I discussed with Daan, we 
will be able to fix that once we use a newer version of Mockito.

I sure can give an LGTM to it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed unnecessary code from getGuestOsT...

2016-04-18 Thread swill

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1262#issuecomment-211436333
  
@rafaelweingartner I understand you feel like you have a conflict of 
interests, but at the same time, you are also very familiar with the code so 
are in a good position to review it.  If you trust yourself to be critical of 
the code in your review, I trust your review.  :P


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed unnecessary code from getGuestOsT...

2016-04-18 Thread rafaelweingartner

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1262#issuecomment-211431496
  
In this situation, I do not know if mine would count, giving that I also 
have helped with some code changes.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed unnecessary code from getGuestOsT...

2016-04-18 Thread swill

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1262#issuecomment-211419101
  
I need one more LGTM code review of this one, otherwise it is looking to be 
in good order...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remove unused images

2016-04-18 Thread swill

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1475#issuecomment-211417769
  
@remibergsma how should we handle this PR now that we have found references 
to these files?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Strange XenServer SR behavior when deploying system VMs in Basic Zone on 4.9

2016-04-18 Thread Rafael Weingärtner

Would the problem discussed here relate to the one here
https://github.com/apache/cloudstack/pull/1499?

On Mon, Apr 18, 2016 at 11:04 AM, Tutkowski, Mike  wrote:

> Looks like I already opened a ticket on this in January. :)
>
> https://issues.apache.org/jira/browse/CLOUDSTACK-9224
>
> I added info to it.
> 
> From: Tutkowski, Mike 
> Sent: Saturday, April 16, 2016 9:58 AM
> To: dev@cloudstack.apache.org
> Subject: Re: Strange XenServer SR behavior when deploying system VMs in
> Basic Zone on 4.9
>
> Thanks, Adrian!
>
> In my case, it's a dev environment, so it's not really hurting anything
> (it just seems like weird behavior, so I was curious if others were seeing
> it).
>
> I can create a ticket in Jira and add your info and mine to it.
>
> Thanks again!
>
> > On Apr 16, 2016, at 4:43 AM, Adrian Sender 
> wrote:
> >
> > Hi Mike,
> >
> > Hi have observed this behavior on CCP 4.3.x mostly and xenserver 6.5
> less so
> > in 4.5.1. I use Fiber Channel LVMoHBA as the primary storage.
> >
> > Seems like the same issue.
> >
> > Disk Attached to Dom0 after snapshot or copy from secondary to primary:
> >
> > In this example we have a disk attached to dom0, we cannot delete the
> disk
> > until we detach it.
> >
> > admin.rc.precise 0 Created by template provisioner 42 GB   Control
> domain on
> > host cpms1-1.nsp.testlabs.com.au
> >
> > [root@cpms1-1 ~]# xe vdi-list name-label="admin.rc.precise 0"
> >
> > uuid ( RO): 3d79722b-294d-4358-bc57-af92b9e9dda7
> > name-label ( RW): admin.rc.precise 0
> >   name-description ( RW): Created by template provisioner
> >sr-uuid ( RO): dce1ec02-cce0-347d-0679-f39c9ea64da1
> >   virtual-size ( RO): 45097156608
> >   sharable ( RO): false
> >  read-only ( RO): false
> >
> > You will want to list out the VBD (connector object between VM and VDI)
> based
> > on the VDI UUID. Here is an example:
> >
> > [root@cpms1-1 ~]# xe vbd-list
> vdi-uuid=3d79722b-294d-4358-bc57-af92b9e9dda7
> >
> > uuid ( RO) : d9e2d89e-a82f-9e6e-c97a-afe0af47468e
> > vm-uuid ( RO): 0f4cb186-0167-47d6-afb5-89b00102250b
> >   vm-name-label ( RO): Control domain on host: cpms1-1.nsp.nectar.org.au
> >vdi-uuid ( RO): 3d79722b-294d-4358-bc57-af92b9e9dda7
> >   empty ( RO): false
> >  device ( RO):
> >
> >
> > Once done, you want to first try to make VBD inactive (it may already be
> > inactive), "The device is not currently attached"
> >
> > xe vbd-unplug uuid=d9e2d89e-a82f-9e6e-c97a-afe0af47468e
> >
> > Once done, you can then break the connection:
> >
> > xe vbd-destroy uuid=
> >
> > Now you can delete the disk from xencenter
> >
> > Regards,
> > Adrian Sender
> >
> >
> >
> > -- Original Message ---
> > From: Anshul Gangwar 
> > To: "dev@cloudstack.apache.org" 
> > Sent: Fri, 15 Apr 2016 06:48:59 +
> > Subject: Re: Strange XenServer SR behavior when deploying system VMs in
> Basic
> > Zone on 4.9
> >
> >> Mike, what type of storage are you using?
> >>
> >>> On 15-Apr-2016, at 9:49 AM, Tutkowski, Mike 
> wrote:
> >>>
> >>> I'm not sure, Daan.
> >>>
> >>> I plan to keep an eye on this behavior for a while when creating new
> clouds.
> >>>
> >>> 
> >>> From: Daan Hoogland 
> >>> Sent: Thursday, April 14, 2016 2:12 AM
> >>> To: dev
> >>> Subject: Re: Strange XenServer SR behavior when deploying system VMs in
> > Basic Zone on 4.9
> >>>
> >>> Mike, did the iso copy process not complete as expected. Sound like
> they
> >>> are a remanence of some task ending in an exception. Probably a
> silently
> >>> ignored one ;|
> >>>
> >>> On Thu, Apr 14, 2016 at 2:49 AM, Tutkowski, Mike <
> mike.tutkow...@netapp.com>
> >>> wrote:
> >>>
>  Just an FYI, but when I kicked off my first VM in this cloud, the VR
>  happened to get deployed to XenServer-6.5-3 (which was one of my
> XenServer
>  hosts that had an un-expected shared SR pointing at secondary storage
>  beforehand).
> 
>  Once the process of copying the system template down to local storage
>  completed, the shared SR pointing at secondary storage went away (as
> you
>  would expect).
> 
>  This leaves me now with one un-expected shared SR pointing at
> secondary
>  storage on XenServer-6.5-1.
> 
>  
>  From: Tutkowski, Mike 
>  Sent: Wednesday, April 13, 2016 5:10 PM
>  To: dev@cloudstack.apache.org
>  Subject: Strange XenServer SR behavior when deploying system VMs in
> Basic
>  Zone on 4.9
> 
>  Hi,
> 
> 
>  Has anyone recently observed the following behavior:
> 
> 
>  http://imgur.com/8ALJmWb
> 
> 
>

Re: Strange XenServer SR behavior when deploying system VMs in Basic Zone on 4.9

2016-04-18 Thread Tutkowski, Mike

Looks like I already opened a ticket on this in January. :)

https://issues.apache.org/jira/browse/CLOUDSTACK-9224

I added info to it.

From: Tutkowski, Mike 
Sent: Saturday, April 16, 2016 9:58 AM
To: dev@cloudstack.apache.org
Subject: Re: Strange XenServer SR behavior when deploying system VMs in Basic 
Zone on 4.9

Thanks, Adrian!

In my case, it's a dev environment, so it's not really hurting anything (it 
just seems like weird behavior, so I was curious if others were seeing it).

I can create a ticket in Jira and add your info and mine to it.

Thanks again!

> On Apr 16, 2016, at 4:43 AM, Adrian Sender  wrote:
>
> Hi Mike,
>
> Hi have observed this behavior on CCP 4.3.x mostly and xenserver 6.5 less so
> in 4.5.1. I use Fiber Channel LVMoHBA as the primary storage.
>
> Seems like the same issue.
>
> Disk Attached to Dom0 after snapshot or copy from secondary to primary:
>
> In this example we have a disk attached to dom0, we cannot delete the disk
> until we detach it.
>
> admin.rc.precise 0 Created by template provisioner 42 GB   Control domain on
> host cpms1-1.nsp.testlabs.com.au
>
> [root@cpms1-1 ~]# xe vdi-list name-label="admin.rc.precise 0"
>
> uuid ( RO): 3d79722b-294d-4358-bc57-af92b9e9dda7
> name-label ( RW): admin.rc.precise 0
>   name-description ( RW): Created by template provisioner
>sr-uuid ( RO): dce1ec02-cce0-347d-0679-f39c9ea64da1
>   virtual-size ( RO): 45097156608
>   sharable ( RO): false
>  read-only ( RO): false
>
> You will want to list out the VBD (connector object between VM and VDI) based
> on the VDI UUID. Here is an example:
>
> [root@cpms1-1 ~]# xe vbd-list vdi-uuid=3d79722b-294d-4358-bc57-af92b9e9dda7
>
> uuid ( RO) : d9e2d89e-a82f-9e6e-c97a-afe0af47468e
> vm-uuid ( RO): 0f4cb186-0167-47d6-afb5-89b00102250b
>   vm-name-label ( RO): Control domain on host: cpms1-1.nsp.nectar.org.au
>vdi-uuid ( RO): 3d79722b-294d-4358-bc57-af92b9e9dda7
>   empty ( RO): false
>  device ( RO):
>
>
> Once done, you want to first try to make VBD inactive (it may already be
> inactive), "The device is not currently attached"
>
> xe vbd-unplug uuid=d9e2d89e-a82f-9e6e-c97a-afe0af47468e
>
> Once done, you can then break the connection:
>
> xe vbd-destroy uuid=
>
> Now you can delete the disk from xencenter
>
> Regards,
> Adrian Sender
>
>
>
> -- Original Message ---
> From: Anshul Gangwar 
> To: "dev@cloudstack.apache.org" 
> Sent: Fri, 15 Apr 2016 06:48:59 +
> Subject: Re: Strange XenServer SR behavior when deploying system VMs in Basic
> Zone on 4.9
>
>> Mike, what type of storage are you using?
>>
>>> On 15-Apr-2016, at 9:49 AM, Tutkowski, Mike  
>>> wrote:
>>>
>>> I'm not sure, Daan.
>>>
>>> I plan to keep an eye on this behavior for a while when creating new clouds.
>>>
>>> 
>>> From: Daan Hoogland 
>>> Sent: Thursday, April 14, 2016 2:12 AM
>>> To: dev
>>> Subject: Re: Strange XenServer SR behavior when deploying system VMs in
> Basic Zone on 4.9
>>>
>>> Mike, did the iso copy process not complete as expected. Sound like they
>>> are a remanence of some task ending in an exception. Probably a silently
>>> ignored one ;|
>>>
>>> On Thu, Apr 14, 2016 at 2:49 AM, Tutkowski, Mike 
>>> wrote:
>>>
 Just an FYI, but when I kicked off my first VM in this cloud, the VR
 happened to get deployed to XenServer-6.5-3 (which was one of my XenServer
 hosts that had an un-expected shared SR pointing at secondary storage
 beforehand).

 Once the process of copying the system template down to local storage
 completed, the shared SR pointing at secondary storage went away (as you
 would expect).

 This leaves me now with one un-expected shared SR pointing at secondary
 storage on XenServer-6.5-1.

 
 From: Tutkowski, Mike 
 Sent: Wednesday, April 13, 2016 5:10 PM
 To: dev@cloudstack.apache.org
 Subject: Strange XenServer SR behavior when deploying system VMs in Basic
 Zone on 4.9

 Hi,


 Has anyone recently observed the following behavior:


 http://imgur.com/8ALJmWb


 As you can see in the image, I have three 6.5 XenServer hosts in a
 resource pool.


 I just used them when creating a basic zone and the system VMs were
 deployed just fine. However, there are SRs pointing to secondary storage on
 my XenServer-6.5-1 and XenServer-6.5-3 hosts still (there used to be one on
 my XenServer-6.5-2 host, but it went away once the system VMs started up on
 that host).


 Thoughts?


 Thanks,

[GitHub] cloudstack pull request: CLOUDSTACK-9349

2016-04-18 Thread dmabry

Github user dmabry commented on the pull request:

https://github.com/apache/cloudstack/pull/1500#issuecomment-21138
  
Here is a manual test using cloudmonkey against our KVM lab.

`(local) ðµ > list volumes 
virtualmachineid=f2870d90-d294-474b-b7da-95bad01e6c09 listall=true
count = 1
volume:
id = 6bd1cf36-2225-4f9c-a378-fe2959142912
name = ROOT-42
account = admin-2177
created = 2016-04-14T07:54:23-0500
destroyed = False
deviceid = 0
displayvolume = True
domain = 2177
domainid = cf23158e-d33c-40c2-b176-0db4a163a93f
hypervisor = KVM
isextractable = False
path = 6bd1cf36-2225-4f9c-a378-fe2959142912
provisioningtype = thin
quiescevm = False
serviceofferingdisplaytext = Small Instance
serviceofferingid = b85e77fd-b897-4471-8fce-1190e71e5156
serviceofferingname = Small Instance
size = 5368709120
state = Ready
storage = rbd1
storageid = f0dbafaa-52a3-3077-bc53-d7ad3a5ac132
storagetype = shared
tags:
templatedisplaytext = Base CentOS 7
templateid = cf02d86b-145b-4777-999c-7f37b16c945b
templatename = Linux_CentOS_7-Minimal
type = ROOT
virtualmachineid = f2870d90-d294-474b-b7da-95bad01e6c09
vmdisplayname = VM-381
vmname = VM-f2870d90-d294-474b-b7da-95bad01e6c09
vmstate = Stopped
zoneid = f58958e8-d24f-4a52-9a9f-8ae11cf4a3b0
zonename = Zone1
(local) ðµ > detach volume id=6bd1cf36-2225-4f9c-a378-fe2959142912
 
accountid = 6b00c3ed-fc3f-11e5-9789-000c29b79f06
cmd = org.apache.cloudstack.api.command.admin.volume.DetachVolumeCmdByAdmin
created = 2016-04-16T13:45:56-0500
jobid = 8d499364-6c4a-49be-bc43-3a80ea800ffa
jobinstanceid = 6bd1cf36-2225-4f9c-a378-fe2959142912
jobinstancetype = Volume
jobprocstatus = 0
jobresult:
volume:
id = 6bd1cf36-2225-4f9c-a378-fe2959142912
name = ROOT-42
account = admin-2177
created = 2016-04-14T07:54:23-0500
destroyed = False
displayvolume = True
domain = 2177
domainid = cf23158e-d33c-40c2-b176-0db4a163a93f
hypervisor = KVM
isextractable = True
jobid = 8d499364-6c4a-49be-bc43-3a80ea800ffa
jobstatus = 0
path = 6bd1cf36-2225-4f9c-a378-fe2959142912
provisioningtype = thin
quiescevm = False
serviceofferingdisplaytext = Small Instance
serviceofferingid = b85e77fd-b897-4471-8fce-1190e71e5156
serviceofferingname = Small Instance
size = 5368709120
state = Ready
storage = rbd1
storageid = f0dbafaa-52a3-3077-bc53-d7ad3a5ac132
storagetype = shared
tags:
templatedisplaytext = Base CentOS 7
templateid = cf02d86b-145b-4777-999c-7f37b16c945b
templatename = Linux_CentOS_7-Minimal
type = DATADISK
zoneid = f58958e8-d24f-4a52-9a9f-8ae11cf4a3b0
zonename = Zone1
jobresultcode = 0
jobresulttype = object
jobstatus = 1
userid = 6b00cc09-fc3f-11e5-9789-000c29b79f06
(local) ðµ > 
(local) ðµ > 
(local) ðµ > list volumes 
virtualmachineid=f2870d90-d294-474b-b7da-95bad01e6c09 listall=true
(local) ðµ > 
(local) ðµ > 
(local) ðµ > attach volume id=6bd1cf36-2225-4f9c-a378-fe2959142912 
virtualmachineid=f2870d90-d294-474b-b7da-95bad01e6c09 
deviceid=  filter=id=virtualmachineid=  
(local) ðµ > attach volume id=6bd1cf36-2225-4f9c-a378-fe2959142912 
virtualmachineid=f2870d90-d294-474b-b7da-95bad01e6c09 deviceid=0
 
accountid = 6b00c3ed-fc3f-11e5-9789-000c29b79f06
cmd = org.apache.cloudstack.api.command.admin.volume.AttachVolumeCmdByAdmin
created = 2016-04-16T13:46:43-0500
jobid = 8b36e694-376a-457e-b2be-dc71872177ca
jobinstanceid = 6bd1cf36-2225-4f9c-a378-fe2959142912
jobinstancetype = Volume
jobprocstatus = 0
jobresult:
volume:
id = 6bd1cf36-2225-4f9c-a378-fe2959142912
name = ROOT-42
account = admin-2177
attached = 2016-04-16T13:46:44-0500
created = 2016-04-14T07:54:23-0500
destroyed = False
deviceid = 0
displayvolume = True
domain = 2177
domainid = cf23158e-d33c-40c2-b176-0db4a163a93f
hypervisor = KVM
isextractable = False
jobid = 8b36e694-376a-457e-b2be-dc71872177ca
jobstatus = 0
path = 6bd1cf36-2225-4f9c-a378-fe2959142912
provisioningtype = thin
quiescevm = False
serviceofferingdisplaytext = Small Instance
serviceofferingid = b85e77fd-b897-4471-8fce-1190e71e5156
serviceofferingname = Small Instance
size = 5368709120
state = Ready
storage = rbd1
storageid = f0dbafaa-52a3-3077-bc53-d7ad3a5ac132
storagetype = shared
tags:
templatedisplaytext = Base CentOS 7
templateid = cf02d86b-145b-4777-999c-7f37b16c945b
templatename = Linux_CentOS_7-Minimal
type = ROOT
virtualmachineid = f2870d90-d294-474b-b7da-95bad01e6c09
vmdisplayname = VM-381
vmname = VM-f2870d90-d294-474b-b7da-95bad01e6c09
vmstate = Stopped
zoneid =

[GitHub] cloudstack pull request: CLOUDSTACK-9349

2016-04-18 Thread dmabry

GitHub user dmabry opened a pull request:

https://github.com/apache/cloudstack/pull/1500

CLOUDSTACK-9349

This PR addresses the KVM detach/attach ROOT disks from VMs 
(CLOUDSTACK-9349).  In short, this allows the KVM Hypervisor, and I added the 
Simulator as a valid hypervisor for ease of development and testing of marvin, 
to detach a root volume and the reattach a root volume using the deviceid=0 
flag to the attachVolume API.  I have also written a marvin integration test 
that verifies this feature works for both KVM and the Simulator.

Below is the marvin results files of the full marvin test_volumes.py.  All 
tests pass, including the new root detach/attach, on our KVM lab running with 
the patches in this PR.


[test_volumes_KIR4G3.zip](https://github.com/apache/cloudstack/files/223799/test_volumes_KIR4G3.zip)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/myENA/cloudstack KVM_root_detach

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1500.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1500


commit 48ce76344040de2ab8014f76292abe0421d42f85
Author: Simon Weller 
Date:   2016-03-24T19:55:34Z

Merge pull request #4 from apache/4.7

4.7 PR

commit d0a02640dfd4878da81a2e59588c4b5ff2a06401
Author: Simon Weller 
Date:   2016-04-14T13:28:37Z

Let hypervisor type KVM detach root volumes

commit 7807955433cea390bb7358e3bb90dbc9cc06bbea
Author: David Mabry 
Date:   2016-04-15T12:30:07Z

updated test_volumes.py to include a test for detaching and reattaching a 
root volume from a vm.  I also had to update base.py to all attach_volume to 
have the parameter deviceid to be passed as needed.

commit d7d55630daff4a5e17c9a374dc2e9bc478dff808
Author: David Mabry 
Date:   2016-04-18T02:41:29Z

Added Simulator as valid hypervisor for root detach




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-04-18 Thread swill

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1423#issuecomment-211375246
  
Introducing an external dependency is probably going to cause some 
problems.  @bhaisaab can you review this and maybe give some feedback on the 
best way to handle this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

2016-04-18 Thread syed

Github user syed commented on the pull request:

https://github.com/apache/cloudstack/pull/1423#issuecomment-211374488
  
@swill I have added a marvin test to see if the VPN service starts 
correctly however I am having trouble getting marvin to work correctly. When I 
run the test I get the follwing error 

```
/usr/lib/python2.6/site-packages/nose/plugins/manager.py:395: 
RuntimeWarning: Unable to load plugin marvinPlugin = 
marvin.marvinPlugin:MarvinPlugin: 'module' object has no attribute 'case'
```
Basically marvin is failing to start. Have you had this problem? Also, in 
my script I use an external dependency `ike-scan`. If you are running this on 
the jenkins server, this binary has to be present for the test to pass and I 
could not find an easy way via the marvin test to inform of this dependency so 
I am assuming that the test framework assumes all the external dependencies to 
already be present. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-18 Thread swill

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1489#issuecomment-211374296
  
Nice work on the quality code reviews guys.  @DaanHoogland since there have 
been a bunch of changes, would you mind running your CI against this one?  I am 
sorting out some issues in my env right now cause I had to change my hardware.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...

2016-04-18 Thread swill

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1452#issuecomment-211370314
  
I think this is ready pending 1 more LGTM code review...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-8562: add informati...

2016-04-18 Thread pdion891

Github user pdion891 commented on the pull request:


https://github.com/apache/cloudstack-docs-admin/pull/37#issuecomment-211370130
  
LGTM,  but we will also have to add part of this addition into the release 
note of 4.9.

Thanks @bhaisaab


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9251: Fix issue in scale VM to...

2016-04-18 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1363


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...

2016-04-18 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1263


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixed Profiler's unit tests bugs.

2016-04-18 Thread rafaelweingartner

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1445#issuecomment-211359351
  
@swill thanks, I was expecting for this one a long time



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

2016-04-18 Thread rafaelweingartner

Github user rafaelweingartner commented on the pull request:

https://github.com/apache/cloudstack/pull/1365#issuecomment-211359119
  
@swill , @bhaisaab 
There are still questions to be addressed here. One example is the question 
at âVolumeApiServiceImplâ  line1857. Another one is at 
âVolumeApiServiceImplâ line 1851.

There maybe more, some message were hidden due to code changes. This is a 
huge PR, which makes it pretty hard to review and then to check the changes 
that are being made (the ones that are consequences of code review). I think we 
need more work here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fixed Profiler's unit tests bugs.

2016-04-18 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack/pull/1445


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-18 Thread bhaisaab

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1489#issuecomment-211320093
  
Doc PR - https://github.com/apache/cloudstack-docs-admin/pull/37


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-8562: add informati...

2016-04-18 Thread bhaisaab

GitHub user bhaisaab opened a pull request:

https://github.com/apache/cloudstack-docs-admin/pull/37

CLOUDSTACK-8562: add information on dynamic roles

Adds documentation on dynamic roles feature

/cc @swill @pdion891 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shapeblue/cloudstack-docs-admin 
dynamic-roles-master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack-docs-admin/pull/37.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #37


commit 300d0640308c36c3701eac50e8252b158a2d49ca
Author: Rohit Yadav 
Date:   2016-04-18T10:26:39Z

CLOUDSTACK-8562: add information on dynamic roles

Adds documentation on dynamic roles feature

Signed-off-by: Rohit Yadav 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Undetected bug correct and refactor of th...

2016-04-18 Thread rafaelweingartner

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1499#discussion_r60035839
  
--- Diff: 
services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
 ---
@@ -497,9 +506,7 @@ protected Answer 
copySnapshotToTemplateFromNfsToNfs(CopyCommand cmd, SnapshotObj
 try {
 _storage.create(destFile.getAbsolutePath(), 
"template.properties");
 try ( // generate template.properties file
- FileWriter writer = new FileWriter(metaFile);
- BufferedWriter bufferWriter = new 
BufferedWriter(writer);
-) {
+FileWriter writer = new FileWriter(metaFile); 
BufferedWriter bufferWriter = new BufferedWriter(writer);) {
--- End diff --

@alexandrelimassantana  Why use this inline?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Undetected bug correct and refactor of th...

2016-04-18 Thread rafaelweingartner

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1499#discussion_r60035791
  
--- Diff: 
services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
 ---
@@ -391,9 +395,15 @@ protected Answer copyFromS3ToNfs(CopyCommand cmd, 
DataTO srcData, S3TO s3, DataT
 return new CopyCmdAnswer(errMsg);
 }
 }
+
 File destFile = new File(downloadDirectory, 
substringAfterLast(srcData.getPath(), S3Utils.SEPARATOR));
+
 S3Utils.getFile(s3, s3.getBucketName(), srcData.getPath(), 
destFile).waitForCompletion();
 
+if (destFile == null) {
--- End diff --

@alexandrelimassantana you can remove this check here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

2016-04-18 Thread rafaelweingartner

Github user rafaelweingartner commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1365#discussion_r60035619
  
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1835,6 +1847,26 @@ private Volume orchestrateDetachVolumeFromVM(long 
vmId, long volumeId) {
 }
 }
 
+public void updateMissingRootDiskController(final VMInstanceVO vm, 
final String rootVolChainInfo) {
+if (vm == null || !vm.getType().equals(VirtualMachine.Type.User) 
|| Strings.isNullOrEmpty(rootVolChainInfo)) {
+return;
+}
+String rootDiskController = null;
+try {
+final VirtualMachineDiskInfo infoInChain = 
_gson.fromJson(rootVolChainInfo, VirtualMachineDiskInfo.class);
+if (infoInChain != null) {
--- End diff --

@jburwell I understand the idea of being defensive against NPE, but we 
should be pragmatic too. Otherwise, we will end up adding tons of null checks 
that are not needed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin pull request: Be explicit in regards to Open...

2016-04-18 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cloudstack-docs-admin/pull/35


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack-docs-admin pull request: Be explicit in regards to Open...

2016-04-18 Thread bhaisaab

Github user bhaisaab commented on the pull request:


https://github.com/apache/cloudstack-docs-admin/pull/35#issuecomment-211291830
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

2016-04-18 Thread bhaisaab

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1365#issuecomment-211264892
  
@swill can we get this merged, while ShapeBlue has tested this internally 
if you test with your non-vmware CI that should confirm it does not break 
anything else; ideally we would need a vmware-based CI to confirm this but if 
you can consider our internal testing results. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

2016-04-18 Thread bhaisaab

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1397#issuecomment-211263699
  
@swill advise how to proceed on this one? are you still getting the build 
issues
@DaanHoogland ping


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: systemvm: preserve file permissions, set ...

2016-04-18 Thread bhaisaab

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1420#issuecomment-211263537
  
@swill yes though we should run CI, the fix is simple and ensure that umask 
setting is used when creating new files. the umask 022 is default on most 
distros resulting in 644 or rw-r--r-- file mods (for example ubuntu: 
http://askubuntu.com/questions/44542/what-is-umask-and-how-does-it-work)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

2016-04-18 Thread bhaisaab

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1489#issuecomment-211262271
  
@swill I've fixed the outstanding issues, can you run your CI on this and 
help merge? thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

2016-04-18 Thread bhaisaab

Github user bhaisaab commented on the pull request:

https://github.com/apache/cloudstack/pull/1493#issuecomment-211261793
  
@swill I've fixed the outstanding issues, can you run your CI on this and 
help merge? thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

77 matches

Mail list logo