[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r61833516 --- Diff: plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java --- @@ -1363,24 +1364,15 @@ private Answer

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1321#discussion_r61833399 --- Diff: engine/orchestration/test/com/cloud/vm/VirtualMachineManagerImplTest.java --- @@ -505,4 +513,24 @@ public void testSendStopWithNullAnswer()

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-216435191 @swill yes indeed we've performed upgrade tests with 4.8.1 to 4.9.0-SNAPSHOT (not using the feature by default) and then using migrate-dyanamicroles.py script; the

Re: ACS PRs Status - 2016/05/02

hopefully we will have labels soon™. i am working on trying to get the repo moved from the 'apache' github org to 'apache-cloudstack' so we can control this sort of stuff and enable labels. it will make things SOO much easier. simon's contributions have been very helpful for me as RM though, so

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1321#issuecomment-216440946 Thanks @rhtyd. I will do a CI run on master before I merge anything else. I will also pull in a couple people who I know have worked on this code to review your

[GitHub] cloudstack pull request: CLOUDSTACK-9373: Class methods over-shawd...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1528#issuecomment-216433425 LGTM based on the discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1365#issuecomment-216433479 Obviously this merge conflict exists because something has been refactored in master which was not merged into previous versions. We need to understand what was

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1516#issuecomment-216435537 @sudhansu7 can you rebase against latest master, squash the changes to a single commit and push -f to re-kick travis. Thanks --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-216435475 @DaanHoogland thanks, how about you have consecutive changes by the same author squashed to one commit; while keep it separate per author in general --- If your

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-216442091 @DaanHoogland can you do a rebase and push -f, Travis failed for `test_01_scale_vm` test In general, LGTM (just code review) --- If your project is set up

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1365#issuecomment-216442130 @rhtyd thanks for fixing the merge conflicts. 👍 @GabrielBrascher and @mike-tutkowski, I know you guys have spent some time with this file, would you

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-216423449 @swill yes that's what I meant, therefore commented that it's ready for merge. Thanks. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers don't ha...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1519#issuecomment-216435381 @swill agree for keeping it against 4.7; but it would be great if @dsclose can squash the changes to a single commit as all of them solve for Cloudstack-9339 issue

[GitHub] cloudstack pull request: Marvin: Replace a timer.sleep(30) with pu...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1529#issuecomment-216444177 I tested this by walking through with the debugger when the delete method on Host was invoked from a test script of mine. --- If your project is set up for

Re: I cannot start agent - Cloudstack 4.8 - Connection closed with -1 on reading size

Ellie, Can you try forcing ACS Management to only bind to IPV4? Normally this is done in the JAVA_OPTS by setting -Djava.net.preferIPv4Stack=true -Djava.net.preferIPv4Addresses=true I think on the ACS Ubuntu release, JAVA_OPTS is set in your init scripts, but I'm not absolutely sure about

[GitHub] cloudstack pull request: kvm: Aqcuire lock when running security g...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1408#issuecomment-216423344 @swill no objection, let's merge this tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: Set default networkDomain to empty instea...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1485#issuecomment-216435060 tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Set default networkDomain to empty instea...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1485#issuecomment-216435050 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Vmdk findbugs

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1351#issuecomment-216442417 @DaanHoogland I'm seeing a lot of commits, can you rebase against 4.7? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1444#issuecomment-216436317 @rafaelweingartner for a project with thousands of commits, splitting the commits for a PR or bug that solves for the same logical issue results in fragmented

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-216441837 Thanks @rhtyd, this makes me feel a little more comfortable. @borisroman if you can give us a bit of an outline of what you have tested, I think it will help

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1321#discussion_r61833186 --- Diff: engine/orchestration/test/com/cloud/vm/VirtualMachineManagerImplTest.java --- @@ -505,4 +513,24 @@ public void testSendStopWithNullAnswer()

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r61833203 --- Diff: plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java --- @@ -1363,24 +1364,15 @@ private Answer

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-216421909 @swill forced pushed; the Jenkins server is not reliable -- as long as Travis is green we are alright; the only additional check Jenkins does is the rat check, which

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1321#discussion_r61833885 --- Diff: engine/orchestration/test/com/cloud/vm/VirtualMachineManagerImplTest.java --- @@ -505,4 +513,24 @@ public void testSendStopWithNullAnswer()

Re: ACS PRs Status - 2016/05/02

All, Will mentioned a little project we've been working on to try and help get a grasp on the open PR list. You can access it here: http://acs:a...@acspr.ena.net Due to the lack of github labels currently, there's quite a bit of regex/pattern matching involved in determining data sets, so

[GitHub] cloudstack pull request: Marvin: Replace a timer.sleep(30) with pu...

GitHub user mike-tutkowski opened a pull request: https://github.com/apache/cloudstack/pull/1529 Marvin: Replace a timer.sleep(30) with pulling logic https://issues.apache.org/jira/browse/CLOUDSTACK-9374 From the ticket: In the base.py file, there is a Host class

Re: ACS PRs Status - 2016/05/02

great job Simon David and Will. Given that we dont have github labels, this is very useful for the RM to pickup the prs to merge and for others to review pending. ~Rajani On Tue, May 3, 2016 at 9:47 AM, Simon Weller wrote: > All, > > Will mentioned a little project we've been

Re: I cannot start agent - Cloudstack 4.8 - Connection closed with -1 on reading size

also check java version and upgrade nss http://blog.backslasher.net/java-ssl-crash.html ~Rajani On Tue, May 3, 2016 at 7:36 AM, Simon Weller wrote: > Ellie, > > Can you try forcing ACS Management to only bind to IPV4? > Normally this is done in the JAVA_OPTS by setting >

[DISCUSS] Pull Requests Triage sprint

All, I've tried to triage all open PRs, starting from oldest to newest. Based on my understanding, I've put tag: in comments (as tagging was not allowed on PRs) to sort them as following: tag:mergeready - PRs that are ready for merge, may need one more LGTM tag:easypr

Re: Rafael Weingartner joining the PMC

Congrats Rafael. Regards, Rohit Yadav Regards, Rohit Yadav rohit.ya...@shapeblue.com  www.shapeblue.com 53 Chandos Place, Covent Garden, London WC2N 4HSUK @shapeblue On Apr 29 2016, at 1:20 am, Rafael Weingärtner wrote: Thank you all for the warm welcome. It

Re: [ANNOUNCE] New committer: Simon Weller

Congrats Simon. Regards, Rohit Yadav Regards, Rohit Yadav rohit.ya...@shapeblue.com  www.shapeblue.com 53 Chandos Place, Covent Garden, London WC2N 4HSUK @shapeblue On Apr 28 2016, at 12:53 pm, Erik Weber wrote: The Project Management Committee (PMC) for Apache

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-216251605 Done, thanks @rhtyd @swill @rafaelweingartner --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-9336 surround the execution of...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1463#issuecomment-216242001 @rhtyd better tag with tag:easypr the logic is that this need not be executed on ssvm or cpvm --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

GitHub user sverrirab opened a pull request: https://github.com/apache/cloudstack/pull/1526 Add perl-modules as install dependency for cloudstack-agent Required to run perl scripts that configure networking for VMs. That script fails silently if this is not installed.

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

Github user sverrirab commented on the pull request: https://github.com/apache/cloudstack/pull/1495#issuecomment-216233064 Created new PR on master: https://github.com/apache/cloudstack/pull/1526 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1514#issuecomment-216243431 code looks good and functionally sane but this needs extensive testing. Especially when master fails the dns functionality needs to be still available, i.e.

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1518#discussion_r61756086 --- Diff: plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java --- @@ -117,4 +154,79 @@ public void

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user borisstoyanov commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-216271049 Marvin tests where successful. Testing community submission of OOBM, which includes end to end regression testing with IPMI simulator. Issue power state

[GitHub] cloudstack pull request: When no zone name is available display a ...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1477#issuecomment-216232227 @swill apart from the PR author, it would be great if at least one more reviewer can share a screenshot; please proceed as per your discretion --- If your project

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1514#issuecomment-216232254 @rhtyd I'd love to. But I never used the Redundant VR, so I can't tell. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-9305: Cloudstack Usage Breaks ...

Github user Slair1 commented on the pull request: https://github.com/apache/cloudstack/pull/1433#issuecomment-216244116 Hi @rhtyd since it uses "ls" to get a list of packages, if the directory or .jar file does not exist it is no big deal. It will output a No such file or directory

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1365#issuecomment-216248411 did a code walk through and saw no extravaganzas and some useful extractions and renamings. As for the functionality, I have no clue. I am not a vmware user,

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1518#discussion_r61754039 --- Diff: core/src/com/cloud/agent/api/storage/StorageNfsVersionCommand.java --- @@ -0,0 +1,44 @@ +// +// Licensed to the Apache Software

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers don't ha...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1519#issuecomment-216267768 I am also fine with these being separate commits as they are functionally separate. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1518#discussion_r61756291 --- Diff: core/src/com/cloud/agent/api/storage/StorageNfsVersionCommand.java --- @@ -0,0 +1,44 @@ +// +// Licensed to the Apache Software

Re: [DISCUSS] Pull Requests Triage sprint

Thanks Rohit. This is very helpful. :) *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_ On Mon, May 2, 2016 at 10:01 AM, Daan Hoogland wrote: > great work Rohit,

Re: [DISCUSS] Pull Requests Triage sprint

great work Rohit, thanks I will go through my work, hopefully within the coming day (1 earth spin) On Mon, May 2, 2016 at 3:16 PM, Rohit Yadav wrote: > All, > > I've tried to triage all open PRs, starting from oldest to newest. Based > on my understanding, I've put

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-216254374 Sure @rhtyd, I'll add them. I was working on it based on @koushik-das suggestion but I still have to work on it. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1444#issuecomment-216266457 I think the two commits are fine in this case, so just leave it as it is. 👍 Can we get some LGTM code reviews on this one? Thanks... --- If your

[GitHub] cloudstack pull request: When no zone name is available display a ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1477#issuecomment-216233168 @rhtyd in general, I agree with you. The main blocker with that is the fact that very few people have the ability to test regional templates. The code is pretty

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers don't ha...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1519#issuecomment-216267457 @rhtyd is there a reason you want him to rebase to master? We still support 4.7, so all fixes to that branch will be forward merged to 4.8 and master. I think this

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1518#discussion_r61754369 --- Diff: core/src/com/cloud/agent/api/storage/StorageNfsVersionCommand.java --- @@ -0,0 +1,44 @@ +// +// Licensed to the Apache

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1482#issuecomment-216270026 Squash yes, but this can remain open against 4.7 as we are still fixing bugs and such against 4.7 and it is still supported (until 4.9 is released). Anything merged

[GitHub] cloudstack pull request: zip the processed json files so we save d...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1421#issuecomment-216285170 How do I test this and verify it is working? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-216270640 @rhtyd rebased, as these are several different commits by different people from different companies, I will not squash it. --- If your project is set up for

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-216287103 I need some code reviews on this one. Also, @DaanHoogland you may have to push again. Our lovely checkers are being annoying again... --- If your project is set

[GitHub] cloudstack pull request: Installing bzip2 since it is required for...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1490#issuecomment-216289492 We need more more code review on this one... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-216294699 I need some code reviews here. @jburwell can you let me know what that status of your review is? --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-216296997 @swill I'm a bit behind. I'm building this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-216300372 @rafaelweingartner This one seems to be in OK shape. I am missing one code review, given that you have actively reviewed this code, can I get your final status?

[GitHub] cloudstack pull request: agent: Enable IPv6 connectivity for KVM A...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1488#issuecomment-216289908 Need to run CI against this one to verify... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: kvm: Aqcuire lock when running security g...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1408#issuecomment-216293581 @wido is this code currently deployed and working in your prod environment? @rhtyd any suggestions for validating this code before merge? Have you tested this?

[GitHub] cloudstack pull request: Update L10N resource files with 4.7 strin...

Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/1374#issuecomment-216296425 @rhtyd rebase and squash done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-216296327 Missing one code review on this one. @rafaelweingartner? I saw you post in this thread, so I am calling you out. :P --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1518#discussion_r61756168 --- Diff: plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java --- @@ -117,4 +154,79 @@ public void

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-216274944 @jburwell I will be doing a group of merges in a couple of hours which will include this one. If you have any pending concerns with this one, speak up soon. :)

[GitHub] cloudstack pull request: zip the processed json files so we save d...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1421#issuecomment-216273377 @remibergsma requires force push again. Travis timed out... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: removed unused HypervDummyResourceBase cl...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1437#issuecomment-216291321 I don't have the ability to test HyperV. Can anyone verify this PR for me? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-216298669 No worries. Thanks... I also am a bit behind. I apparently have to just assume I won't get any work done on mondays. :P --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-216274536 I think this one is ready to merge... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-216289074 @kiwiflyer do you have test results on this one? Thanks... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1516#issuecomment-216286395 We are missing one code review on this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-216293439 @rafaelweingartner @cristofolini I refactored unit tests based on your comments, I also removed testStorageNfsVersionNotPresent as it is covered by tests

[GitHub] cloudstack pull request: Installing bzip2 since it is required for...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1490#issuecomment-216302867 I think this one is ready to merge given the scope of the change. Thanks... --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-216305206 @DaanHoogland please rebase and push -f again, to re-kickoff Travis; I'll review and test this change soon against a real KVM env tomorrow --- If your project is

[GitHub] cloudstack pull request: CLOUDSTACK-9336 surround the execution of...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1463#issuecomment-216306697 LGTM, @swill @wido @resmo @nvazquez @nlivens @koushik-das and others - one more LGTM needed tag:easypr --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61776712 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ConfigureOutOfBandManagementCmd.java --- @@ -0,0 +1,127 @@ +//

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61776673 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ChangeOutOfBandManagementPasswordCmd.java --- @@ -0,0 +1,116 @@ +//

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61776973 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/DisableOutOfBandManagementForHostCmd.java --- @@ -0,0 +1,107 @@ +//

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61777066 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/DisableOutOfBandManagementForZoneCmd.java --- @@ -0,0 +1,105 @@ +//

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61781601 --- Diff: engine/schema/src/org/apache/cloudstack/outofbandmanagement/dao/OutOfBandManagementDaoImpl.java --- @@ -0,0 +1,163 @@ +// Licensed to

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-216321608 @rafaelweingartner thanks. I understand completely... I know the `final` stuff is debatable, but I don't think that should block a PR. :) I think

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1516#issuecomment-216303934 LGTM, considdered it implied by the test report but here it is. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-9336 surround the execution of...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1463#issuecomment-216309949 Code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-216309958 @jburwell no worries, I know how that goes. :) Thanks for your support regardless... --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: kvm: Aqcuire lock when running security g...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1408#issuecomment-216304156 @swill I've validated the lock logic in a gist above, I've tested the elusiveness of critical code that runs when a lock is acquired; security groups is implemented

[GitHub] cloudstack pull request: CLOUDSTACK-9305: Cloudstack Usage Breaks ...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1433#issuecomment-216305899 fair enough, LGTM tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1516#issuecomment-216305760 @DaanHoogland thanks... @sudhansu7 can you do a force push to kick off the travis run again so we can get this PR green. Thx... --- If your project is set

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61777144 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/EnableOutOfBandManagementForClusterCmd.java --- @@ -0,0 +1,105 @@

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61777183 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/EnableOutOfBandManagementForHostCmd.java --- @@ -0,0 +1,107 @@ +//

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61778682 --- Diff: api/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementService.java --- @@ -0,0 +1,51 @@ +// Licensed to the Apache

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61780464 --- Diff: engine/schema/src/org/apache/cloudstack/outofbandmanagement/dao/OutOfBandManagementDaoImpl.java --- @@ -0,0 +1,163 @@ +// Licensed to

[GitHub] cloudstack pull request: kvm: Aqcuire lock when running security g...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1408#issuecomment-216319525 I am pretty comfortable with this because @wido is already using this. I don't have an SG environment setup right now for testing, so I would have to build one

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1321#issuecomment-216320768 gogogo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: Update L10N resource files with 4.7 strin...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1374#issuecomment-216324676 @swill I think you want to forward merge before this one and then merge -s ours or such to prevent this from being merged forward. 4.8 has its own

[GitHub] cloudstack pull request: Followup fix for #1162: Add support for n...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1330#issuecomment-216301175 We are still accepting bug fixes in 4.7 and 4.8, but all features should be added to master. Anything merged into 4.7 or 4.8 will be forward merged up through

[GitHub] cloudstack pull request: CLOUDSTACK-8867: Added retry logic to rec...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1269#issuecomment-216306144 I am missing code reviews on this one... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-216307184 @swill, I did a review on the comments and discussions to get me up to date (we had a discussion about some code duplications). Those discussions

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-216308956 @rafaelweingartner thanks for the review. :) I think what @rhtyd meant is anything outstanding is only cosmetic, I don't think he meant the entire discussion.

  1   2   3   4   >