[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61780464 --- Diff: engine/schema/src/org/apache/cloudstack/outofbandmanagement/dao/OutOfBandManagementDaoImpl.java --- @@ -0,0 +1,163 @@ +// Licensed to

[GitHub] cloudstack pull request: kvm: Aqcuire lock when running security g...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1408#issuecomment-216319525 I am pretty comfortable with this because @wido is already using this. I don't have an SG environment setup right now for testing, so I would have to build one

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61779846 --- Diff: api/src/org/apache/cloudstack/outofbandmanagement/driver/OutOfBandManagementDriverPowerCommand.java --- @@ -0,0 +1,33 @@ +// Licensed to

[GitHub] cloudstack pull request: kvm: Aqcuire lock when running security g...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1408#issuecomment-216318692 @swill and @rhtyd: The code in the PR is currently in production at PCextreme and running fine. With a 'with' statement in Python I couldn't get a proper

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61778988 --- Diff: api/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementService.java --- @@ -0,0 +1,51 @@ +// Licensed to the Apache

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61778682 --- Diff: api/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementService.java --- @@ -0,0 +1,51 @@ +// Licensed to the Apache

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61777665 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/IssueOutOfBandManagementPowerActionCmd.java --- @@ -0,0 +1,128 @@

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61777563 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/IssueOutOfBandManagementPowerActionCmd.java --- @@ -0,0 +1,128 @@

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61777306 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/IssueOutOfBandManagementPowerActionCmd.java --- @@ -0,0 +1,128 @@

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61777268 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/EnableOutOfBandManagementForZoneCmd.java --- @@ -0,0 +1,105 @@ +//

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61777183 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/EnableOutOfBandManagementForHostCmd.java --- @@ -0,0 +1,107 @@ +//

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61777144 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/EnableOutOfBandManagementForClusterCmd.java --- @@ -0,0 +1,105 @@

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61777066 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/DisableOutOfBandManagementForZoneCmd.java --- @@ -0,0 +1,105 @@ +//

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61776973 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/DisableOutOfBandManagementForHostCmd.java --- @@ -0,0 +1,107 @@ +//

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61776838 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/DisableOutOfBandManagementForClusterCmd.java --- @@ -0,0 +1,105 @@

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61776673 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ChangeOutOfBandManagementPasswordCmd.java --- @@ -0,0 +1,116 @@ +//

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61776712 --- Diff: api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ConfigureOutOfBandManagementCmd.java --- @@ -0,0 +1,127 @@ +//

[GitHub] cloudstack pull request: CLOUDSTACK-9336 surround the execution of...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1463#issuecomment-216310118 Thanks @nvazquez, I think this one is ready now... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-216309958 @jburwell no worries, I know how that goes. :) Thanks for your support regardless... --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-9336 surround the execution of...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1463#issuecomment-216309949 Code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-216309500 @swill I have gotten diverted from review. Hoping to pick up today. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-216308956 @rafaelweingartner thanks for the review. :) I think what @rhtyd meant is anything outstanding is only cosmetic, I don't think he meant the entire discussion.

[GitHub] cloudstack pull request: Update L10N resource files with 4.7 strin...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1374#issuecomment-216307729 #1515 is going in today and then we will validate that this one and #1376 don't have merge conflicts once #1515 is in and they will follow right after... --- If

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-216307184 @swill, I did a review on the comments and discussions to get me up to date (we had a discussion about some code duplications). Those discussions

[GitHub] cloudstack pull request: CLOUDSTACK-9336 surround the execution of...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1463#issuecomment-216306697 LGTM, @swill @wido @resmo @nvazquez @nlivens @koushik-das and others - one more LGTM needed tag:easypr --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: Update L10N resource files with 4.7 strin...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1374#issuecomment-216306406 Thanks @milamberspace cc @swill @DaanHoogland we need one more LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-8867: Added retry logic to rec...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1269#issuecomment-216306144 I am missing code reviews on this one... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1516#issuecomment-216305760 @DaanHoogland thanks... @sudhansu7 can you do a force push to kick off the travis run again so we can get this PR green. Thx... --- If your project is set

[GitHub] cloudstack pull request: CLOUDSTACK-9305: Cloudstack Usage Breaks ...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1433#issuecomment-216305899 fair enough, LGTM tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-216305206 @DaanHoogland please rebase and push -f again, to re-kickoff Travis; I'll review and test this change soon against a real KVM env tomorrow --- If your project is

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1365#issuecomment-216304460 Thanks @DaanHoogland -- though there is a way to run ESXi6 with vCenter 6 on KVM (http://rohit.yadav.xyz/logs/vmware-esxi-vcenter-on-kvm-cloudstack) /cc

[GitHub] cloudstack pull request: kvm: Aqcuire lock when running security g...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1408#issuecomment-216304156 @swill I've validated the lock logic in a gist above, I've tested the elusiveness of critical code that runs when a lock is acquired; security groups is implemented

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1516#issuecomment-216303934 LGTM, considdered it implied by the test report but here it is. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: Installing bzip2 since it is required for...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1490#issuecomment-216302867 I think this one is ready to merge given the scope of the change. Thanks... --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: Installing bzip2 since it is required for...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1490#issuecomment-216302469 That change makes sense to me. I do now if I have installed the “bzip2” program without noticing while installing some other tool, but in my MSs

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1321#issuecomment-216302010 All tests have passed on this and we have the required number of code reviews. There are no merge conflicts, so I think we should be fine to merge this PR as is.

[GitHub] cloudstack pull request: Followup fix for #1162: Add support for n...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1330#issuecomment-216301175 We are still accepting bug fixes in 4.7 and 4.8, but all features should be added to master. Anything merged into 4.7 or 4.8 will be forward merged up through

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-216300372 @rafaelweingartner This one seems to be in OK shape. I am missing one code review, given that you have actively reviewed this code, can I get your final status?

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-216298669 No worries. Thanks... I also am a bit behind. I apparently have to just assume I won't get any work done on mondays. :P --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-216296997 @swill I'm a bit behind. I'm building this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-216296327 Missing one code review on this one. @rafaelweingartner? I saw you post in this thread, so I am calling you out. :P --- If your project is set up for it, you can

[GitHub] cloudstack pull request: Update L10N resource files with 4.7 strin...

Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/1374#issuecomment-216296425 @rhtyd rebase and squash done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-216294699 I need some code reviews here. @jburwell can you let me know what that status of your review is? --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: kvm: Aqcuire lock when running security g...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1408#issuecomment-216293581 @wido is this code currently deployed and working in your prod environment? @rhtyd any suggestions for validating this code before merge? Have you tested this?

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-216293439 @rafaelweingartner @cristofolini I refactored unit tests based on your comments, I also removed testStorageNfsVersionNotPresent as it is covered by tests

[GitHub] cloudstack pull request: removed unused HypervDummyResourceBase cl...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1437#issuecomment-216291321 I don't have the ability to test HyperV. Can anyone verify this PR for me? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: agent: Enable IPv6 connectivity for KVM A...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1488#issuecomment-216289908 Need to run CI against this one to verify... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Installing bzip2 since it is required for...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1490#issuecomment-216289492 We need more more code review on this one... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-216289074 @kiwiflyer do you have test results on this one? Thanks... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1516#issuecomment-216286395 We are missing one code review on this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-216287103 I need some code reviews on this one. Also, @DaanHoogland you may have to push again. Our lovely checkers are being annoying again... --- If your project is set

[GitHub] cloudstack pull request: zip the processed json files so we save d...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1421#issuecomment-216285170 How do I test this and verify it is working? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: zip the processed json files so we save d...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1421#issuecomment-216273377 @remibergsma requires force push again. Travis timed out... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-216274944 @jburwell I will be doing a group of merges in a couple of hours which will include this one. If you have any pending concerns with this one, speak up soon. :)

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-216274536 I think this one is ready to merge... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1518#discussion_r61756168 --- Diff: plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java --- @@ -117,4 +154,79 @@ public void

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-216270640 @rhtyd rebased, as these are several different commits by different people from different companies, I will not squash it. --- If your project is set up for

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1518#discussion_r61756291 --- Diff: core/src/com/cloud/agent/api/storage/StorageNfsVersionCommand.java --- @@ -0,0 +1,44 @@ +// +// Licensed to the Apache Software

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user borisstoyanov commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-216271049 Marvin tests where successful. Testing community submission of OOBM, which includes end to end regression testing with IPMI simulator. Issue power state

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1518#discussion_r61756086 --- Diff: plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java --- @@ -117,4 +154,79 @@ public void

[GitHub] cloudstack pull request: Restore iptables at once using iptables-r...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1482#issuecomment-216270026 Squash yes, but this can remain open against 4.7 as we are still fixing bugs and such against 4.7 and it is still supported (until 4.9 is released). Anything merged

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers don't ha...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1519#issuecomment-216267768 I am also fine with these being separate commits as they are functionally separate. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1518#discussion_r61754369 --- Diff: core/src/com/cloud/agent/api/storage/StorageNfsVersionCommand.java --- @@ -0,0 +1,44 @@ +// +// Licensed to the Apache

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers don't ha...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1519#issuecomment-216267457 @rhtyd is there a reason you want him to rebase to master? We still support 4.7, so all fixes to that branch will be forward merged to 4.8 and master. I think this

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1518#discussion_r61754039 --- Diff: core/src/com/cloud/agent/api/storage/StorageNfsVersionCommand.java --- @@ -0,0 +1,44 @@ +// +// Licensed to the Apache Software

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1444#issuecomment-216266457 I think the two commits are fine in this case, so just leave it as it is. 👍 Can we get some LGTM code reviews on this one? Thanks... --- If your

CCCNA in Montreal - Price increase at 4PM EST

Hey Everyone, Just wanted to give you all a heads up. The early bird pricing of $150 + tax will be increasing to $250 + tax today at 4PM EST. Get your tickets today to save some money... CCCNA Website: http://ca.cloudstackcollab.org/ Registration Link:

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1444#issuecomment-216264551 @rhtyd I think it would not be a good idea to squash these commits. We will lose the history if we do it here. I only cherry picked the changes

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-216258261 Running CI now... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-216254374 Sure @rhtyd, I'll add them. I was working on it based on @koushik-das suggestion but I still have to work on it. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-216251605 Done, thanks @rhtyd @swill @rafaelweingartner --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1526#issuecomment-216248435 You can close this PR. Once #1495 is merged, it will be forward merged into 4.8 and master, so this PR is not needed. Thanks... :) --- If your project is set up

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1365#issuecomment-216248411 did a code walk through and saw no extravaganzas and some useful extractions and renamings. As for the functionality, I have no clue. I am not a vmware user,

Re: [DISCUSS] Pull Requests Triage sprint

Thanks Rohit. This is very helpful. :) *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_ On Mon, May 2, 2016 at 10:01 AM, Daan Hoogland wrote: > great work Rohit,

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1514#issuecomment-216243431 code looks good and functionally sane but this needs extensive testing. Especially when master fails the dns functionality needs to be still available, i.e.

[GitHub] cloudstack pull request: CLOUDSTACK-9305: Cloudstack Usage Breaks ...

Github user Slair1 commented on the pull request: https://github.com/apache/cloudstack/pull/1433#issuecomment-216244116 Hi @rhtyd since it uses "ls" to get a list of packages, if the directory or .jar file does not exist it is no big deal. It will output a No such file or directory

Re: [DISCUSS] Pull Requests Triage sprint

great work Rohit, thanks I will go through my work, hopefully within the coming day (1 earth spin) On Mon, May 2, 2016 at 3:16 PM, Rohit Yadav wrote: > All, > > I've tried to triage all open PRs, starting from oldest to newest. Based > on my understanding, I've put

[GitHub] cloudstack pull request: CLOUDSTACK-9336 surround the execution of...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1463#issuecomment-216242001 @rhtyd better tag with tag:easypr the logic is that this need not be executed on ssvm or cpvm --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: When no zone name is available display a ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1477#issuecomment-216233168 @rhtyd in general, I agree with you. The main blocker with that is the fact that very few people have the ability to test regional templates. The code is pretty

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

Github user sverrirab commented on the pull request: https://github.com/apache/cloudstack/pull/1495#issuecomment-216233064 Created new PR on master: https://github.com/apache/cloudstack/pull/1526 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

GitHub user sverrirab opened a pull request: https://github.com/apache/cloudstack/pull/1526 Add perl-modules as install dependency for cloudstack-agent Required to run perl scripts that configure networking for VMs. That script fails silently if this is not installed.

Re: [ANNOUNCE] New committer: Simon Weller

Congrats Simon. Regards, Rohit Yadav Regards, Rohit Yadav rohit.ya...@shapeblue.com  www.shapeblue.com 53 Chandos Place, Covent Garden, London WC2N 4HSUK @shapeblue On Apr 28 2016, at 12:53 pm, Erik Weber wrote: The Project Management Committee (PMC) for Apache

Re: Rafael Weingartner joining the PMC

Congrats Rafael. Regards, Rohit Yadav Regards, Rohit Yadav rohit.ya...@shapeblue.com  www.shapeblue.com 53 Chandos Place, Covent Garden, London WC2N 4HSUK @shapeblue On Apr 29 2016, at 1:20 am, Rafael Weingärtner wrote: Thank you all for the warm welcome. It

[GitHub] cloudstack pull request: When no zone name is available display a ...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1477#issuecomment-216232227 @swill apart from the PR author, it would be great if at least one more reviewer can share a screenshot; please proceed as per your discretion --- If your project

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1514#issuecomment-216232254 @rhtyd I'd love to. But I never used the Redundant VR, so I can't tell. --- If your project is set up for it, you can reply to this email and have your reply appear

[DISCUSS] Pull Requests Triage sprint

All, I've tried to triage all open PRs, starting from oldest to newest. Based on my understanding, I've put tag: in comments (as tagging was not allowed on PRs) to sort them as following: tag:mergeready - PRs that are ready for merge, may need one more LGTM tag:easypr

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-216231216 I will make sure this gets into 4.9 because I think it is really needed. We do need one more LGTM on the code. Also, since this PR does have some implications

[GitHub] cloudstack pull request: CLOUDSTACK-9365 : updateVirtualMachine wi...

Github user singalrahul commented on the pull request: https://github.com/apache/cloudstack/pull/1523#issuecomment-216230102 test_deploy_vm_userdata_MultiNic.py script is added for the verification of this Bug. It will verify that a user can deploy MultiNic VM when non-default nic

[GitHub] cloudstack pull request: CPU socket count reporting correction

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1520#issuecomment-216230034 @NuxRo thanks, please rebase and squash to a single commit LGTM tag:mergeready --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers don't ha...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1519#issuecomment-216229957 @dsclose rebase against master, squash changes to a single commit, thanks tag:needlove --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1516#issuecomment-216229873 @sudhansu7 rebase against master and push -f, squash changes to a single commit, thanks --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: L10n update 4.8 20160422

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1515#issuecomment-216229763 LGTM tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1514#issuecomment-216229708 Good pr, let's ask comments from @remibergsma @DaanHoogland @wido and others? tag:needlove --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-216229542 @DaanHoogland please rebase against latest master; after that I can help test this in my env. Thanks. tag:needlove --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-216229281 PR is code complete with testing efforts that @borisstoyanov can share tag:mergeready --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-216228984 Nice PR, though this would need some regression tests. Can you add marvin smoke tests around list APis (add them to travis yml file) tag:needlove --- If

[GitHub] cloudstack pull request: CLOUDSTACK-9350: KVM-HA- Fix CheckOnHost ...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1496#issuecomment-216228687 LGTM (code review) tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Add perl-modules as install dependency fo...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1495#issuecomment-216228633 tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: When no zone name is available display a ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1477#issuecomment-216228565 I think this is ready to merge. @remibergsma has shown screenshots to verify the UI change does what it is supposed to and we have the LGTMs required. --- If your

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-216228508 This PR is ready for merge, /cc @swill tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on

<    1   2   3   4   >