Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-216231216
I will make sure this gets into 4.9 because I think it is really needed.
We do need one more LGTM on the code. Also, since this PR does have some
implications regarding access to the system we should be pretty cautious. I am
pretty confident with a new install because that is what my CI has tested. I
think it would be prudent for us to do more testing of some upgrade scenarios
to make sure the code behaves as expected. I don't think this code should come
into play with upgrades because the old properties files should be ready, but I
think we need to validate the code behaves as expected. Has anyone tested this
yet?
I think we should be testing:
- Upgrading to 4.9 and NOT using this feature.
- Upgrading to 4.9 and running the `migrate-dynamicroles.py` script to
import the existing roles.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
