[GitHub] cloudstack pull request #1824: CLOUDSTACK-9657: Fixed security group ipset i...

[kishankavala]

Github user kishankavala commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1824#discussion_r101981147
  
--- Diff: scripts/vm/hypervisor/xenserver/vmops ---
@@ -232,28 +233,50 @@ def deleteFile(session, args):
 
 return txt
 
+#using all the iptables chain names length to 24 because cleanup_rules 
groups the vm chain excluding -def,-eg
+#to avoid multiple iptables chains for single vm there using length 24
 def chain_name(vm_name):
 if vm_name.startswith('i-') or vm_name.startswith('r-'):
 if vm_name.endswith('untagged'):
 return '-'.join(vm_name.split('-')[:-1])
 if len(vm_name) > 28:
-vm_name = vm_name[0:27]
+vm_name = vm_name[0:24]
 return vm_name
 
 def chain_name_def(vm_name):
+#iptables chain length max is 29 chars
+if len(vm_name) > 28:
--- End diff --

Check should be > 25, "-def" is suffixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #843: Security group ingress/egress issues with xenserver 6...

[kishankavala]

Github user kishankavala commented on the issue:

https://github.com/apache/cloudstack/pull/843
  
Code LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1971: CLOUDSTACK-9726 Update state is not changed to UPDAT...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1971
  
@bvbharatk is there unit tests for this change?
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1968: CLOUDSTACK-9666 Added basic configuration validation...

[koushik-das]

Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/1968
  
Code changes LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1967: CLOUDSTACK-9638 Problems caused when inputting doubl...

[koushik-das]

Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/1967
  
Code change LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1964: Bug-Id: CLOUDSTACK-9800 Enabled netscaler inline mod...

[koushik-das]

Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/1964
  
Code changes LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1883: CLOUDSTACK-9723: Enable unique mac address ac...

[jayapalu]

Github user jayapalu commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1883#discussion_r102888327
  
--- Diff: engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java ---
@@ -377,11 +377,16 @@ protected void addAccountToNetwork(final long 
networkId, final long accountId, f
 }
 
 @Override
-public String getNextAvailableMacAddress(final long networkConfigId) {
+public String getNextAvailableMacAddress(final long networkConfigId, 
Integer zoneMacIdentifier) {
--- End diff --

I tried writing unit test cases for it. I have difficulty in call static 
method. I tried with the PowerMockito.mockStatic but still I face NPE in 
fetch.getNextSequence. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR wh...

[bvbharatk]

Github user bvbharatk commented on the issue:

https://github.com/apache/cloudstack/pull/1965
  
@ustcweizhou 
Reformatted the code.
thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1825: CLOUDSTACK-9660: NPE while destroying volumes during...

[koushik-das]

Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/1825
  
@karuturi This can be merged


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

[anshul1886]

Github user anshul1886 commented on the issue:

https://github.com/apache/cloudstack/pull/669
  
@karuturi, We can merge this now. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

[sureshanaparti]

Github user sureshanaparti commented on the issue:

https://github.com/apache/cloudstack/pull/669
  
Tested manually. LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

[marcaurele]

Github user marcaurele commented on the issue:

https://github.com/apache/cloudstack/pull/1768
  
Forget my last comment, the files can remains as they are.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1971: CLOUDSTACK-9726 Update state is not changed t...

[bvbharatk]

GitHub user bvbharatk opened a pull request:

https://github.com/apache/cloudstack/pull/1971

CLOUDSTACK-9726 Update state is not changed to UPDATE_FAILED in case …

…when Host is put in Maintenance Mode.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bvbharatk/cloudstack CLOUDSTACK-9726

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1971.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1971


commit 670f24ec5dc067ab1e7a29f12c8cd4a709545c24
Author: Bharat Kumar 
Date:   2016-01-04T13:06:28Z

CLOUDSTACK-9726 Update state is not changed to UPDATE_FAILED in case when 
Host is put in Maintenance Mode.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1970: CLOUDSTACK-9725 Failed to update VPC Network ...

[bvbharatk]

GitHub user bvbharatk opened a pull request:

https://github.com/apache/cloudstack/pull/1970

CLOUDSTACK-9725 Failed to update VPC Network during N/w offering Upgr…

…ade which doesnt have ACL service Enabled.

check if acl service provider is configured when network is associated with 
a acl.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bvbharatk/cloudstack CLOUDSTACK-9725

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1970.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1970


commit bbff9f15754c06dc8a7a74fdd34ab7968b052c3f
Author: Bharat Kumar 
Date:   2016-01-05T05:53:49Z

CLOUDSTACK-9725 Failed to update VPC Network during N/w offering Upgrade 
which doesnt have ACL service Enabled.
check if acl service provider is configured when network is associated with 
a acl.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1969: CLOUDSTACK-9667 Enable resourcecount.check.in...

[bvbharatk]

GitHub user bvbharatk opened a pull request:

https://github.com/apache/cloudstack/pull/1969

CLOUDSTACK-9667 Enable resourcecount.check.interval by default



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bvbharatk/cloudstack CLOUDSTACK-9667

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1969.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1969


commit 0ef668b3d2f62bb94ce8ac95b8e315214b506c62
Author: Bharat Kumar 
Date:   2015-10-06T11:00:58Z

CLOUDSTACK-9667 Enable resourcecount.check.interval by default




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1968: CLOUDSTACK-9666 Added basic configuration val...

[bvbharatk]

GitHub user bvbharatk opened a pull request:

https://github.com/apache/cloudstack/pull/1968

CLOUDSTACK-9666 Added basic configuration validation for the config d…

…rive global settings

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bvbharatk/cloudstack CLOUDSTACK-9666

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1968.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1968


commit 366175b9a5dd3994b2807fcc5aaeed7a22052cae
Author: Bharat Kumar 
Date:   2015-10-06T11:02:58Z

CLOUDSTACK-9666 Added basic configuration validation for the config drive 
global settings




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1967: CLOUDSTACK-9638 Problems caused when inputtin...

[bvbharatk]

GitHub user bvbharatk opened a pull request:

https://github.com/apache/cloudstack/pull/1967

CLOUDSTACK-9638 Problems caused when inputting double-byte numbers fo…

…r custom compute offerings

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bvbharatk/cloudstack CLOUDSTACK-9638

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1967.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1967


commit 59312dd976a6fb5e4d5d3a5b701fc1cccac9a3d2
Author: Bharat Kumar 
Date:   2017-01-03T12:25:08Z

CLOUDSTACK-9638 Problems caused when inputting double-byte numbers for 
custom compute offerings




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1880: CLOUDSTACK-9720: [VMware] template_spool_ref table i...

[sureshanaparti]

Github user sureshanaparti commented on the issue:

https://github.com/apache/cloudstack/pull/1880
  
@rhtyd Can you please kick off the tests again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1897: CLOUDSTACK-9733: Concurrent volume snapshots of a VM...

[sureshanaparti]

Github user sureshanaparti commented on the issue:

https://github.com/apache/cloudstack/pull/1897
  
The failed test cases above are not related to this PR changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...

[ramkatru]

Github user ramkatru commented on the issue:

https://github.com/apache/cloudstack/pull/1774
  
@priyankparihar please check the test failures.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1840: CLOUDSTACK-9685: delete snapshot on primary associat...

[cloudmonger]

Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1840
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 385
 Hypervisor xenserver
 NetworkType Advanced
 Passed=105
 Failed=0
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**

**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_routers_network_ops.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

[anshul1886]

Github user anshul1886 commented on the issue:

https://github.com/apache/cloudstack/pull/1941
  
@GabrielBrascher, Those tests failure are not related to this PR and seems 
to be failing most of the time and reported as intermittent failures. @rhtyd 
@karuturi  @serg38, We have already run tests twice, Do we still need to re 
run? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] cloudstack issue #1966: CLOUDSTACK-9801: IPSec VPN does not work after vRout...

[Will Stevens]

I ha e done pretty extensive testing of the strongswan implementation, but
would be happy for you to verify if the problem exists in 4.10.

On Feb 23, 2017 9:23 PM, "Sean Lair"  wrote:

> It is open against the 4.9 branch.
>
> We are running 4.9.2.0, looks like it affects all 4.9.x.x
>
> We haven't tested against 4.10 (strongswan) yet.  But it could be a
> problem and will be worth testing.  If strongswan starts before cloudstack
> adds the nics to the VM it could have same issue.
>
>
> > On Feb 23, 2017, at 7:51 PM, swill  wrote:
> >
> > Github user swill commented on the issue:
> >
> >https://github.com/apache/cloudstack/pull/1966
> >
> >I can't see what branch this is opened against on my phone. What
> version of ACS is this opened against and which version do you have a
> problem in. The reason I ask is because #1741 was added in master to
> upgrade from openswan to strongswan. . Thx...
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have
> your
> > reply appear on GitHub as well. If your project does not have this
> feature
> > enabled and wishes so, or if the feature is enabled but not working,
> please
> > contact infrastructure at infrastruct...@apache.org or file a JIRA
> ticket
> > with INFRA.
> > ---
>

Re: [GitHub] cloudstack issue #1966: CLOUDSTACK-9801: IPSec VPN does not work after vRout...

[Sean Lair]

It is open against the 4.9 branch.

We are running 4.9.2.0, looks like it affects all 4.9.x.x

We haven't tested against 4.10 (strongswan) yet.  But it could be a problem and 
will be worth testing.  If strongswan starts before cloudstack adds the nics to 
the VM it could have same issue.
 

> On Feb 23, 2017, at 7:51 PM, swill  wrote:
> 
> Github user swill commented on the issue:
> 
>https://github.com/apache/cloudstack/pull/1966
> 
>I can't see what branch this is opened against on my phone. What version 
> of ACS is this opened against and which version do you have a problem in. The 
> reason I ask is because #1741 was added in master to upgrade from openswan to 
> strongswan. . Thx... 
> 
> 
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

[nathanejohnson]

Github user nathanejohnson commented on the issue:

https://github.com/apache/cloudstack/pull/1955
  
As an update, I'm working on a Marvin test, and I'm also planning to 
address wido's concerns.  Today had many distractions unfortunately.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1966: CLOUDSTACK-9801: IPSec VPN does not work after vRout...

[swill]

Github user swill commented on the issue:

https://github.com/apache/cloudstack/pull/1966
  
I can't see what branch this is opened against on my phone. What version of 
ACS is this opened against and which version do you have a problem in. The 
reason I ask is because #1741 was added in master to upgrade from openswan to 
strongswan. . Thx... 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1966: CLOUDSTACK-9801: IPSec VPN does not work afte...

[Slair1]

GitHub user Slair1 opened a pull request:

https://github.com/apache/cloudstack/pull/1966

CLOUDSTACK-9801: IPSec VPN does not work after vRouter reboot or recreate

After a vRouter is recreated  (e.g. reboot via CloudStack UI) and Remote 
Access VPN enabled, VPN won't work anymore. Here is the abbreviated output of 
"ipsec auto -status" while we were having the issue:

```
root@r-10-VM:~# ipsec auto --status
000 using kernel interface: netkey
000 interface lo/lo 127.0.0.1
000 interface lo/lo 127.0.0.1
000 interface eth0/eth0 169.254.1.45
000 interface eth0/eth0 169.254.1.45
000 %myid = (none)
```

After this commit, the following occurs and VPNs work:
```

root@r-10-VM:~# ipsec auto --status
000 using kernel interface: netkey
000 interface lo/lo 127.0.0.1
000 interface lo/lo 127.0.0.1
000 interface eth0/eth0 169.254.1.45
000 interface eth0/eth0 169.254.1.45
000 interface eth1/eth1 xxx.xxx.xxx.172
000 interface eth1/eth1 xxx.xxx.xxx.172
000 interface eth2/eth2 192.168.1.1
000 interface eth2/eth2 192.168.1.1
000 %myid = (none)

```
eth1 interface IP is masked, but now ipsec sees all the interfaces and VPN 
works.

Looks like this bug was introduced by Pull Request #1423

It added code to start ipsec 
(cloudstack/systemvm/patches/debian/config/opt/cloud/bin/configure.py)

```
if vpnconfig['create']:
logging.debug("Enabling remote access vpn on "+ public_ip)
CsHelper.start_if_stopped("ipsec")
```

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Slair1/cloudstack 
CLOUDSTACK-9801--IPSec-VPN-does-not-work-after-vRouter-reboot-or-recreate

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1966.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1966






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1962: CLOUDSTACK-9798 - Resizing root disk fails when usin...

[mike-tutkowski]

Github user mike-tutkowski commented on the issue:

https://github.com/apache/cloudstack/pull/1962
  
@syed Hey - I was also working on a feature like this, but related to both 
XenServer and VMware (adding in VMware-specific code on the resource side). Do 
you need these changes for 4.10 or can I incorporate what I need from them for 
4.11 into code that I'm building?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: VPN/IPSEC problem after upgrading to 4.9.2.0

[Sean Lair]

Looks like this bug was introduced by Pull Request #1423

https://github.com/apache/cloudstack/pull/1423

It added code to start ipsec 
(cloudstack/systemvm/patches/debian/config/opt/cloud/bin/configure.py)

if vpnconfig['create']:
logging.debug("Enabling  remote access vpn  on "+ public_ip)
CsHelper.start_if_stopped("ipsec")
self.configure_l2tpIpsec(public_ip, self.dbag[public_ip])


The issue is that if a reboot is issued from the CloudStack UI (as opposed to 
manually by logging into the vRouter), the NICS (except eth0) are not added to 
the VM until the cloud service is running.

Since ipsec was started before the nics were added to the VM and before the 
public IP address is added to the nic, ipsec is not listening on the public IP 
address and all VPNs are broken.

This is not a problem with the Site2Site VPN section of configure.py, because 
that section does not start ipsec if the public IP is not on the system yet...  


That is my synopsis at least.

Thanks
Sean


-Original Message-
From: Sean Lair 
Sent: Thursday, February 23, 2017 2:27 PM
To: dev@cloudstack.apache.org
Subject: VPN/IPSEC problem after upgrading to 4.9.2.0

We just upgraded from 4.8.1.1 to 4.9.2.0.  After upgrading we rebooted the 
virtual routers, and noticed that our site-to-site VPNs and remote-access VPNs 
would no longer connect.  After troubleshooting, we noticed that Openswan 
(ipsec.d) wasn't listening on the vRouter's IPs.  Here is the abbreviated 
output of "ipsec auto -status" while we were having the issue:

root@r-10-VM:~# ipsec auto --status
000 using kernel interface: netkey
000 interface lo/lo 127.0.0.1
000 interface lo/lo 127.0.0.1
000 interface eth0/eth0 169.254.1.45
000 interface eth0/eth0 169.254.1.45
000 %myid = (none)


Openswan only knows about the loopback and 169.254.1.45 address  We 
rebooted the vRouter several times with the same results.  However, if we 
manually stopped and started ipsec, then issued a "ipsec auto -status", the 
abbreviated output would be:

root@r-10-VM:~# ipsec auto --status
000 using kernel interface: netkey
000 interface lo/lo 127.0.0.1
000 interface lo/lo 127.0.0.1
000 interface eth0/eth0 169.254.1.45
000 interface eth0/eth0 169.254.1.45
000 interface eth1/eth1 192.103.11.172
000 interface eth1/eth1 192.103.11.172
000 interface eth2/eth2 192.168.1.1
000 interface eth2/eth2 192.168.1.1
000 %myid = (none)

Openswan now knows about the additional interfaces and VPNs function as 
expected...  It's like ipsec.d is started before all of the interfaces are 
configured?  Is this a known bug or I am off-base with my analysis somehow?

Thanks
Sean

[GitHub] cloudstack issue #1825: CLOUDSTACK-9660: NPE while destroying volumes during...

[cloudmonger]

Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1825
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 384
 Hypervisor xenserver
 NetworkType Advanced
 Passed=105
 Failed=0
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**

**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_routers_network_ops.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

VPN/IPSEC problem after upgrading to 4.9.2.0

[Sean Lair]

We just upgraded from 4.8.1.1 to 4.9.2.0.  After upgrading we rebooted the 
virtual routers, and noticed that our site-to-site VPNs and remote-access VPNs 
would no longer connect.  After troubleshooting, we noticed that Openswan 
(ipsec.d) wasn't listening on the vRouter's IPs.  Here is the abbreviated 
output of "ipsec auto -status" while we were having the issue:

root@r-10-VM:~# ipsec auto --status
000 using kernel interface: netkey
000 interface lo/lo 127.0.0.1
000 interface lo/lo 127.0.0.1
000 interface eth0/eth0 169.254.1.45
000 interface eth0/eth0 169.254.1.45
000 %myid = (none)


Openswan only knows about the loopback and 169.254.1.45 address  We 
rebooted the vRouter several times with the same results.  However, if we 
manually stopped and started ipsec, then issued a "ipsec auto -status", the 
abbreviated output would be:

root@r-10-VM:~# ipsec auto --status
000 using kernel interface: netkey
000 interface lo/lo 127.0.0.1
000 interface lo/lo 127.0.0.1
000 interface eth0/eth0 169.254.1.45
000 interface eth0/eth0 169.254.1.45
000 interface eth1/eth1 192.103.11.172
000 interface eth1/eth1 192.103.11.172
000 interface eth2/eth2 192.168.1.1
000 interface eth2/eth2 192.168.1.1
000 %myid = (none)

Openswan now knows about the additional interfaces and VPNs function as 
expected...  It's like ipsec.d is started before all of the interfaces are 
configured?  Is this a known bug or I am off-base with my analysis somehow?

Thanks
Sean

Re: Some Jira tickets clean up

[Rafael Weingärtner]

Thanks ;)

On Thu, Feb 23, 2017 at 3:14 PM, Tutkowski, Mike 
wrote:

> Thanks, Rafael. I uploaded an ISO and walked through the necessary parts
> of the wizard. I agree with you that it has been fixed. I commented on the
> ticket, then resolved and closed it just now.
>
> On 2/23/17, 12:46 PM, "Rafael Weingärtner" 
> wrote:
>
> Thanks for taking time to look at this Mike.
> The ticket (CLOUDSTACK-4164
> ) I managed to
> check, and I believe it can be closed.
>
> On Thu, Feb 23, 2017 at 2:39 PM, Tutkowski, Mike <
> mike.tutkow...@netapp.com>
> wrote:
>
> > Thanks for compiling this list, Rafael!
> >
> > I see I was the reporter for this issue:
> >
> > https://issues.apache.org/jira/browse/CLOUDSTACK-4164
> >
> > I plan to take a look at it and see what the current state is.
> >
> > On 2/23/17, 10:26 AM, "Rafael Weingärtner" <
> rafaelweingart...@gmail.com>
> > wrote:
> >
> > Hi folks,
> > I have been reviewing old Jira tickets and we have a bunch that
> can be
> > closed. The following are the ones I have gone through. Before I
> close
> > any
> > ticket I would like to check them with you, especially the ones
> from a
> > category called “Seems to be fixed has to be checked”. I will be
> > waiting
> > for your feedback before I proceed to close any ticket.
> >
> > - Have a title that does say much and the ticket does not have a
> > detailed
> > description
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-2225
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-917
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-947
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-1259
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-1441
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-1576
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-2705
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-5793
> >
> >
> > - Already solved
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-2532
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-6735
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-6837
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-7161
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-8202
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-8781
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-8817
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-9065
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-1069
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-1460
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-1702
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-1870
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-2075
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-2213
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-2439
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-6009
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-5219
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-4847
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-4778
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-4238
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-4164
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-4071
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-4055
> >
> > - Seems to be fixed has to be checked (I did not have how to
> check
> > these
> > right now)
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-8873
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-8918
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-963
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-1025
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-1177
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-1225
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-1283
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-1284
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-1285
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-1287
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-1442
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-1478
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-1659
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-2215
> > -- https://issues.apache.org/jira/browse/CLOUDSTACK-2436
> > -- 

Re: Some Jira tickets clean up

[Tutkowski, Mike]

Thanks, Rafael. I uploaded an ISO and walked through the necessary parts of the 
wizard. I agree with you that it has been fixed. I commented on the ticket, 
then resolved and closed it just now.

On 2/23/17, 12:46 PM, "Rafael Weingärtner"  wrote:

Thanks for taking time to look at this Mike.
The ticket (CLOUDSTACK-4164
) I managed to
check, and I believe it can be closed.

On Thu, Feb 23, 2017 at 2:39 PM, Tutkowski, Mike 
wrote:

> Thanks for compiling this list, Rafael!
>
> I see I was the reporter for this issue:
>
> https://issues.apache.org/jira/browse/CLOUDSTACK-4164
>
> I plan to take a look at it and see what the current state is.
>
> On 2/23/17, 10:26 AM, "Rafael Weingärtner" 
> wrote:
>
> Hi folks,
> I have been reviewing old Jira tickets and we have a bunch that can be
> closed. The following are the ones I have gone through. Before I close
> any
> ticket I would like to check them with you, especially the ones from a
> category called “Seems to be fixed has to be checked”. I will be
> waiting
> for your feedback before I proceed to close any ticket.
>
> - Have a title that does say much and the ticket does not have a
> detailed
> description
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-2225
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-917
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-947
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1259
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1441
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1576
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-2705
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-5793
>
>
> - Already solved
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-2532
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-6735
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-6837
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-7161
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-8202
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-8781
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-8817
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-9065
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1069
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1460
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1702
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1870
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-2075
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-2213
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-2439
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-6009
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-5219
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4847
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4778
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4238
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4164
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4071
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4055
>
> - Seems to be fixed has to be checked (I did not have how to check
> these
> right now)
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-8873
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-8918
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-963
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1025
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1177
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1225
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1283
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1284
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1285
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1287
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1442
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1478
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1659
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-2215
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-2436
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-5225
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4883
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4440 (I think
> Nicolás
> may be able to help checking this one)
> -- 

[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1896
  
Got it, thanks for the explanation. I saw that, and I was wondering if it 
could have been a bug or something else.

LGTM then.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....

[milamberspace]

Github user milamberspace commented on the issue:

https://github.com/apache/cloudstack/pull/1896
  
@rafaelweingartner It was because the source string (en) has been chenged 
by this PR 1803, so the translations have been deleted by Transifex to invite 
the translator to make the new translation.

https://github.com/apache/cloudstack/pull/1803/files


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Some Jira tickets clean up

[Rafael Weingärtner]

Thanks for taking time to look at this Mike.
The ticket (CLOUDSTACK-4164
) I managed to
check, and I believe it can be closed.

On Thu, Feb 23, 2017 at 2:39 PM, Tutkowski, Mike 
wrote:

> Thanks for compiling this list, Rafael!
>
> I see I was the reporter for this issue:
>
> https://issues.apache.org/jira/browse/CLOUDSTACK-4164
>
> I plan to take a look at it and see what the current state is.
>
> On 2/23/17, 10:26 AM, "Rafael Weingärtner" 
> wrote:
>
> Hi folks,
> I have been reviewing old Jira tickets and we have a bunch that can be
> closed. The following are the ones I have gone through. Before I close
> any
> ticket I would like to check them with you, especially the ones from a
> category called “Seems to be fixed has to be checked”. I will be
> waiting
> for your feedback before I proceed to close any ticket.
>
> - Have a title that does say much and the ticket does not have a
> detailed
> description
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-2225
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-917
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-947
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1259
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1441
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1576
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-2705
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-5793
>
>
> - Already solved
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-2532
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-6735
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-6837
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-7161
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-8202
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-8781
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-8817
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-9065
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1069
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1460
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1702
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1870
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-2075
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-2213
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-2439
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-6009
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-5219
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4847
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4778
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4238
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4164
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4071
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4055
>
> - Seems to be fixed has to be checked (I did not have how to check
> these
> right now)
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-8873
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-8918
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-963
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1025
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1177
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1225
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1283
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1284
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1285
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1287
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1442
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1478
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1659
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-2215
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-2436
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-5225
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4883
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-4440 (I think
> Nicolás
> may be able to help checking this one)
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-3784
>
> - May be able to close after brief discussion/conversation
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-7819 (are we
> supposed
> to be able to add tags to projects? Is it working right now?)
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1497 (Do we want
> to
> preserve alien VMs?)
> -- https://issues.apache.org/jira/browse/CLOUDSTACK-1570 (I did not
> understand if this is a feature that we already have and was only
> lacking
> documentation, or if it is a feature suggestion)
> -- 

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

[DaanHoogland]

Github user DaanHoogland commented on the issue:

https://github.com/apache/cloudstack/pull/1768
  
@blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Some Jira tickets clean up

[Tutkowski, Mike]

Thanks for compiling this list, Rafael!

I see I was the reporter for this issue:

https://issues.apache.org/jira/browse/CLOUDSTACK-4164

I plan to take a look at it and see what the current state is.

On 2/23/17, 10:26 AM, "Rafael Weingärtner"  wrote:

Hi folks,
I have been reviewing old Jira tickets and we have a bunch that can be
closed. The following are the ones I have gone through. Before I close any
ticket I would like to check them with you, especially the ones from a
category called “Seems to be fixed has to be checked”. I will be waiting
for your feedback before I proceed to close any ticket.

- Have a title that does say much and the ticket does not have a detailed
description
-- https://issues.apache.org/jira/browse/CLOUDSTACK-2225
-- https://issues.apache.org/jira/browse/CLOUDSTACK-917
-- https://issues.apache.org/jira/browse/CLOUDSTACK-947
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1259
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1441
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1576
-- https://issues.apache.org/jira/browse/CLOUDSTACK-2705
-- https://issues.apache.org/jira/browse/CLOUDSTACK-5793


- Already solved
-- https://issues.apache.org/jira/browse/CLOUDSTACK-2532
-- https://issues.apache.org/jira/browse/CLOUDSTACK-6735
-- https://issues.apache.org/jira/browse/CLOUDSTACK-6837
-- https://issues.apache.org/jira/browse/CLOUDSTACK-7161
-- https://issues.apache.org/jira/browse/CLOUDSTACK-8202
-- https://issues.apache.org/jira/browse/CLOUDSTACK-8781
-- https://issues.apache.org/jira/browse/CLOUDSTACK-8817
-- https://issues.apache.org/jira/browse/CLOUDSTACK-9065
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1069
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1460
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1702
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1870
-- https://issues.apache.org/jira/browse/CLOUDSTACK-2075
-- https://issues.apache.org/jira/browse/CLOUDSTACK-2213
-- https://issues.apache.org/jira/browse/CLOUDSTACK-2439
-- https://issues.apache.org/jira/browse/CLOUDSTACK-6009
-- https://issues.apache.org/jira/browse/CLOUDSTACK-5219
-- https://issues.apache.org/jira/browse/CLOUDSTACK-4847
-- https://issues.apache.org/jira/browse/CLOUDSTACK-4778
-- https://issues.apache.org/jira/browse/CLOUDSTACK-4238
-- https://issues.apache.org/jira/browse/CLOUDSTACK-4164
-- https://issues.apache.org/jira/browse/CLOUDSTACK-4071
-- https://issues.apache.org/jira/browse/CLOUDSTACK-4055

- Seems to be fixed has to be checked (I did not have how to check these
right now)
-- https://issues.apache.org/jira/browse/CLOUDSTACK-8873
-- https://issues.apache.org/jira/browse/CLOUDSTACK-8918
-- https://issues.apache.org/jira/browse/CLOUDSTACK-963
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1025
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1177
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1225
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1283
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1284
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1285
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1287
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1442
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1478
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1659
-- https://issues.apache.org/jira/browse/CLOUDSTACK-2215
-- https://issues.apache.org/jira/browse/CLOUDSTACK-2436
-- https://issues.apache.org/jira/browse/CLOUDSTACK-5225
-- https://issues.apache.org/jira/browse/CLOUDSTACK-4883
-- https://issues.apache.org/jira/browse/CLOUDSTACK-4440 (I think Nicolás
may be able to help checking this one)
-- https://issues.apache.org/jira/browse/CLOUDSTACK-3784

- May be able to close after brief discussion/conversation
-- https://issues.apache.org/jira/browse/CLOUDSTACK-7819 (are we supposed
to be able to add tags to projects? Is it working right now?)
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1497 (Do we want to
preserve alien VMs?)
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1570 (I did not
understand if this is a feature that we already have and was only lacking
documentation, or if it is a feature suggestion)
-- https://issues.apache.org/jira/browse/CLOUDSTACK-2535 (There is a
discussion one person said some old configuration should be removed and
other said that they should now. However, the discussion stopped there; I
think we can close this)
-- https://issues.apache.org/jira/browse/CLOUDSTACK-2616 (Database
connection validation, do we have a config in our connection pool to keep
those connections alive even when idle? Or at least recreate them when they
 

[GitHub] cloudstack pull request #1963: CLOUDSTACK-9799 - Unable to create volume fro...

[syed]

Github user syed closed the pull request at:

https://github.com/apache/cloudstack/pull/1963


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1963: CLOUDSTACK-9799 - Unable to create volume fro...

[syed]

Github user syed commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1963#discussion_r102798055
  
--- Diff: 
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
 ---
@@ -711,6 +711,7 @@ private void 
handleCreateVolumeFromSnapshotBothOnStorageSystem(SnapshotInfo snap
 }
 catch (Exception ex) {
 errMsg = ex.getMessage() != null ? ex.getMessage() : "Copy 
operation failed in 
'StorageSystemDataMotionStrategy.handleCreateVolumeFromSnapshotBothOnStorageSystem'";
+copyCmdAnswer = new CopyCmdAnswer(errMsg);
--- End diff --

That would be great @mike-tutkowski. That makes sure that the snapshot goes 
back to a good state if the storage driver operation fails. I will close this 
request then.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1963: CLOUDSTACK-9799 - Unable to create volume fro...

[mike-tutkowski]

Github user mike-tutkowski commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1963#discussion_r102793622
  
--- Diff: 
engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
 ---
@@ -711,6 +711,7 @@ private void 
handleCreateVolumeFromSnapshotBothOnStorageSystem(SnapshotInfo snap
 }
 catch (Exception ex) {
 errMsg = ex.getMessage() != null ? ex.getMessage() : "Copy 
operation failed in 
'StorageSystemDataMotionStrategy.handleCreateVolumeFromSnapshotBothOnStorageSystem'";
+copyCmdAnswer = new CopyCmdAnswer(errMsg);
--- End diff --

@syed What I don't have in my version of this fix is this line of code. I 
can add it to mine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1963: CLOUDSTACK-9799 - Unable to create volume from snaps...

[mike-tutkowski]

Github user mike-tutkowski commented on the issue:

https://github.com/apache/cloudstack/pull/1963
  
Yes, but the PR is scheduled for 4.11.

On Feb 23, 2017, at 10:58 AM, Syed Mushtaq Ahmed 
> wrote:


@mike-tutkowski If you already have this 
in your PR, I can close this. Let me know!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on 
GitHub, 
or mute the 
thread.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1896
  
@milamberspace @rhtyd do you know why the entry "label.host.alerts" was 
removed from some languages?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1935
  
@serg38 I did, the code is great as always. However, I have a concern about 
that `rollBackState` variable being static there. Because the 
`DomainManagerImpl ` is a singleton, using that variable may create problems. 
Instead of using the variable to indicate when the rollback has to be executed, 
we could do the same using an exception (the exception is already thrown when 
the variable is set to `true`).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1963: CLOUDSTACK-9799 - Unable to create volume from snaps...

[syed]

Github user syed commented on the issue:

https://github.com/apache/cloudstack/pull/1963
  
@mike-tutkowski If you already have this in your PR, I can close this. Let 
me know!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

[serg38]

Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1935
  
@rafaelweingartner Can you review latest updates from @nvazquez . Since 
tests are passing this PR will be ready for merging to 4.10


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Some Jira tickets clean up

[Rafael Weingärtner]

Hi folks,
I have been reviewing old Jira tickets and we have a bunch that can be
closed. The following are the ones I have gone through. Before I close any
ticket I would like to check them with you, especially the ones from a
category called “Seems to be fixed has to be checked”. I will be waiting
for your feedback before I proceed to close any ticket.

- Have a title that does say much and the ticket does not have a detailed
description
-- https://issues.apache.org/jira/browse/CLOUDSTACK-2225
-- https://issues.apache.org/jira/browse/CLOUDSTACK-917
-- https://issues.apache.org/jira/browse/CLOUDSTACK-947
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1259
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1441
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1576
-- https://issues.apache.org/jira/browse/CLOUDSTACK-2705
-- https://issues.apache.org/jira/browse/CLOUDSTACK-5793


- Already solved
-- https://issues.apache.org/jira/browse/CLOUDSTACK-2532
-- https://issues.apache.org/jira/browse/CLOUDSTACK-6735
-- https://issues.apache.org/jira/browse/CLOUDSTACK-6837
-- https://issues.apache.org/jira/browse/CLOUDSTACK-7161
-- https://issues.apache.org/jira/browse/CLOUDSTACK-8202
-- https://issues.apache.org/jira/browse/CLOUDSTACK-8781
-- https://issues.apache.org/jira/browse/CLOUDSTACK-8817
-- https://issues.apache.org/jira/browse/CLOUDSTACK-9065
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1069
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1460
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1702
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1870
-- https://issues.apache.org/jira/browse/CLOUDSTACK-2075
-- https://issues.apache.org/jira/browse/CLOUDSTACK-2213
-- https://issues.apache.org/jira/browse/CLOUDSTACK-2439
-- https://issues.apache.org/jira/browse/CLOUDSTACK-6009
-- https://issues.apache.org/jira/browse/CLOUDSTACK-5219
-- https://issues.apache.org/jira/browse/CLOUDSTACK-4847
-- https://issues.apache.org/jira/browse/CLOUDSTACK-4778
-- https://issues.apache.org/jira/browse/CLOUDSTACK-4238
-- https://issues.apache.org/jira/browse/CLOUDSTACK-4164
-- https://issues.apache.org/jira/browse/CLOUDSTACK-4071
-- https://issues.apache.org/jira/browse/CLOUDSTACK-4055

- Seems to be fixed has to be checked (I did not have how to check these
right now)
-- https://issues.apache.org/jira/browse/CLOUDSTACK-8873
-- https://issues.apache.org/jira/browse/CLOUDSTACK-8918
-- https://issues.apache.org/jira/browse/CLOUDSTACK-963
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1025
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1177
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1225
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1283
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1284
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1285
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1287
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1442
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1478
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1659
-- https://issues.apache.org/jira/browse/CLOUDSTACK-2215
-- https://issues.apache.org/jira/browse/CLOUDSTACK-2436
-- https://issues.apache.org/jira/browse/CLOUDSTACK-5225
-- https://issues.apache.org/jira/browse/CLOUDSTACK-4883
-- https://issues.apache.org/jira/browse/CLOUDSTACK-4440 (I think Nicolás
may be able to help checking this one)
-- https://issues.apache.org/jira/browse/CLOUDSTACK-3784

- May be able to close after brief discussion/conversation
-- https://issues.apache.org/jira/browse/CLOUDSTACK-7819 (are we supposed
to be able to add tags to projects? Is it working right now?)
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1497 (Do we want to
preserve alien VMs?)
-- https://issues.apache.org/jira/browse/CLOUDSTACK-1570 (I did not
understand if this is a feature that we already have and was only lacking
documentation, or if it is a feature suggestion)
-- https://issues.apache.org/jira/browse/CLOUDSTACK-2535 (There is a
discussion one person said some old configuration should be removed and
other said that they should now. However, the discussion stopped there; I
think we can close this)
-- https://issues.apache.org/jira/browse/CLOUDSTACK-2616 (Database
connection validation, do we have a config in our connection pool to keep
those connections alive even when idle? Or at least recreate them when they
expire?)
-- https://issues.apache.org/jira/browse/CLOUDSTACK-5550 (Is this a
problem? the keys are pretty big; I do not see the need to fully display
the keys. A simple "shift + end" can be used to select the keys and copy
them. Maybe a copy to transfer area button would be better?)
-- https://issues.apache.org/jira/browse/CLOUDSTACK-5182 (The pages do not
seem to exist anymore in new documentation page)
-- https://issues.apache.org/jira/browse/CLOUDSTACK-4018 (User entering
invalid information regarding the environment, I do not see this as a bug
(it is a user`s problem))
-- 

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

[marcaurele]

Github user marcaurele commented on the issue:

https://github.com/apache/cloudstack/pull/1768
  
I looked at the code inside `Upgrade481to490.java` and I cannot understand 
why the table alterations have been made inside the Java class instead of the 
SQL file. Because now we cannot move the code from the `-cleanup` without 
changing that class too, other the column `role_id` won't be present when 
creating the `account_view`.
To make the change transparent, I'll have to change those too. I'll push 
another commit for that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #351: This branch implements the CSV and native HA support ...

[cloudmonger]

Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/351
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 383
 Hypervisor xenserver
 NetworkType Advanced
 Passed=105
 Failed=0
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**

**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_routers_network_ops.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1958: CLOUDSTACK-5806: add presetup to storage type...

[serg38]

Github user serg38 commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1958#discussion_r102753237
  
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java 
---
@@ -508,7 +507,7 @@ public String updateConfiguration(final long userId, 
final String name, final St
 throw new InvalidParameterValueException("unable to 
find storage pool by id " + resourceId);
 }
 
if(name.equals(CapacityManager.StorageOverprovisioningFactor.key())) {
-if(pool.getPoolType() != 
StoragePoolType.NetworkFilesystem && pool.getPoolType() != 
StoragePoolType.VMFS) {
+if(pool.getPoolType().supportsOverProvisioning() ) {
--- End diff --

I believe it should be negated


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1957: CLOUDSTACK-9748:VPN Users search functionality broke...

[rafaelweingartner]

Github user rafaelweingartner commented on the issue:

https://github.com/apache/cloudstack/pull/1957
  
Actually, my concerns are not regarding the response. Reading the name of 
the method one can for sure understand what it returns. My concern is that 
reading the parameter name `keyword` I really have no clue that this keyword is 
part of a username. The `keyword` could be used to list users of domains that 
may match it; the same can be applied for projects. Did you understand what I 
mean?
I was trying to discuss if we could find a better way to document it. As 
you also checked, there are other methods that this situation happens. However, 
I really do not believe this is a good standard to follow.
Would not something like the following work as well?
```
...
sb.and("id", sb.entity().getId(), SearchCriteria.Op.EQ);
sb.and("state", sb.entity().getState(), Op.IN);
sb.and().op("username", sb.entity().getUsername(), 
SearchCriteria.Op.EQ).or("username", "%" + sb.entity().getUsername() + "%" , 
SearchCriteria.Op.LIKE);
...
```



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1953: CLOUDSTACK-9794: Unable to attach more than 14 devic...

[remibergsma]

Github user remibergsma commented on the issue:

https://github.com/apache/cloudstack/pull/1953
  
Thanks @sureshanaparti will test it soon! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...

[remibergsma]

Github user remibergsma commented on the issue:

https://github.com/apache/cloudstack/pull/1878
  
@sureshanaparti Thanks for the info!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1941: CLOUDSTACK-8663: Fixed various issues to allo...

[GabrielBrascher]

Github user GabrielBrascher commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1941#discussion_r102730127
  
--- Diff: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ---
@@ -1415,6 +1417,10 @@ public VM createWorkingVM(final Connection conn, 
final String vmName, final Stri
 vbdr.userdevice = "autodetect";
 vbdr.mode = Types.VbdMode.RW;
 vbdr.type = Types.VbdType.DISK;
+Long deviceId = volumeTO.getDeviceId();
+if (deviceId != null && (!isDeviceUsed(conn, vm, deviceId) || 
deviceId > 3)) {
--- End diff --

There is this one also https://github.com/apache/cloudstack/pull/1829.
However, after sorting out the tests failures and with the code approved I 
don't think that this would be a reason to not take the PR forward.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

[serg38]

Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1941
  
@borisstoyanov @rhtyd Can we re-test this with B.O. ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

[serg38]

Github user serg38 commented on the issue:

https://github.com/apache/cloudstack/pull/1961
  
@karuturi I agree with @nvazquez . This PR can be safely merged and then 
B.O. runtime environment needs to be adjusted to define nfs2 mountpoint in 
test_data.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1922: CLOUDSTACK-9757: Fixed issue in traffic from additio...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1922
  
LGTM as it is same to commit edd839ab10226760749d4fc15703a41eddc1dfdd
not tested yet, as VPC with RVR is working fine, so I assume this fixes the 
issue in VPC with single VR.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

[GabrielBrascher]

Github user GabrielBrascher commented on the issue:

https://github.com/apache/cloudstack/pull/1941
  
Thanks @anshul1886. I see that you improved this PR considering the 
comments from the one closed. Some tests failed. Are they false positives? 
Otherwise LGTM. Just need to confirm those failures.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubu...

[ustcweizhou]

Github user ustcweizhou commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1950#discussion_r102716218
  
--- Diff: .gitignore ---
@@ -51,7 +51,6 @@ tools/cli/build/
 *.jar
 *.war
 *.mar
-*.zip
--- End diff --

@wido ,yes, ./core/test/resources/vhds/test.vhd.zip for testing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR wh...

[ustcweizhou]

Github user ustcweizhou commented on the issue:

https://github.com/apache/cloudstack/pull/1965
  
@bvbharatk can you format the code ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1941: CLOUDSTACK-8663: Fixed various issues to allo...

[GabrielBrascher]

Github user GabrielBrascher commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1941#discussion_r102715520
  
--- Diff: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ---
@@ -1415,6 +1417,10 @@ public VM createWorkingVM(final Connection conn, 
final String vmName, final Stri
 vbdr.userdevice = "autodetect";
 vbdr.mode = Types.VbdMode.RW;
 vbdr.type = Types.VbdType.DISK;
+Long deviceId = volumeTO.getDeviceId();
+if (deviceId != null && (!isDeviceUsed(conn, vm, deviceId) || 
deviceId > 3)) {
--- End diff --

Is this PR https://github.com/apache/cloudstack/pull/1829 @koushik-das?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

[nvazquez]

Github user nvazquez commented on the issue:

https://github.com/apache/cloudstack/pull/1961
  
@karuturi @borisstoyanov next step will be updating Marvin's folder 
`test_data.py` file and configure an url for key "nfs2" similar as it was done 
for "nfs", this way it can be used to mount nfs in running environment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

[cloudmonger]

Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/669
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 382
 Hypervisor xenserver
 NetworkType Advanced
 Passed=105
 Failed=0
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**

**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_non_contigiousvlan.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_routers_network_ops.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1965: CLOUDSTACK-9727 Password reset discrepancy in...

[bvbharatk]

GitHub user bvbharatk opened a pull request:

https://github.com/apache/cloudstack/pull/1965

CLOUDSTACK-9727 Password reset discrepancy in RVR when one of the Rou…

…ter is not in Running state.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bvbharatk/cloudstack CLOUDSTACK-9727

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1965.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1965


commit 7ac5a03bbbda3249700bdb67481fb08f815fe76d
Author: Bharat Kumar 
Date:   2015-12-17T10:49:30Z

CLOUDSTACK-9727 Password reset discrepancy in RVR when one of the Router is 
not in Running state.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

[anshul1886]

Github user anshul1886 commented on the issue:

https://github.com/apache/cloudstack/pull/1941
  
@koushik-das, That PR is still not merged. @karuturi @rhtyd This PR has 
LGTM now. Can we merge it? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1941: CLOUDSTACK-8663: Fixed various issues to allo...

[koushik-das]

Github user koushik-das commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1941#discussion_r102698293
  
--- Diff: 
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
 ---
@@ -1415,6 +1417,10 @@ public VM createWorkingVM(final Connection conn, 
final String vmName, final Stri
 vbdr.userdevice = "autodetect";
 vbdr.mode = Types.VbdMode.RW;
 vbdr.type = Types.VbdType.DISK;
+Long deviceId = volumeTO.getDeviceId();
+if (deviceId != null && (!isDeviceUsed(conn, vm, deviceId) || 
deviceId > 3)) {
--- End diff --

I remember seeing these changes in another PR, check if that is merged or 
not


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubu...

[wido]

Github user wido commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1950#discussion_r102688184
  
--- Diff: .gitignore ---
@@ -51,7 +51,6 @@ tools/cli/build/
 *.jar
 *.war
 *.mar
-*.zip
--- End diff --

Why? Are we adding ZIP files to the repo?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1964: Bug-Id: CLOUDSTACK-9800 Enabled netscaler inl...

[kishankavala]

GitHub user kishankavala opened a pull request:

https://github.com/apache/cloudstack/pull/1964

Bug-Id: CLOUDSTACK-9800 Enabled netscaler inline mode. Added corresponding 
changes in UI

NetScaler can work in inline mode also along with other Firewall devices. 
Enabled netscaler inline mode capability

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kishankavala/cloudstack CLOUDSTACK-9800

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cloudstack/pull/1964.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1964


commit a0f990a2f270e8af92ed03a624a84e14da0ba4c0
Author: Kishan Kavala 
Date:   2017-02-23T09:53:56Z

Bug-Id: CLOUDSTACK-9800 Enabled netscaler inline mode. Added corrsponding 
changes in UI




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for K...

[wido]

Github user wido commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1955#discussion_r102687039
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -2059,6 +2060,13 @@ So if getMinSpeed() returns null we fall back to 
getSpeed().
 final InputDef input = new InputDef("tablet", "usb");
 devices.addDevice(input);
 
+// If we're using virtio scsi, then we need to add a virtual scsi 
controller
+if (getGuestDiskModel(vmTO.getPlatformEmulator()) == 
DiskDef.DiskBus.SCSI) {
+final SCSIDef sd = new SCSIDef((short)0, 0, 0, 9, 0);
+devices.addDevice(sd);
+s_logger.debug("Adding scsi definition:\n" + sd.toString());
--- End diff --

Might want to include the name of the VM here as well? And SCSI is written 
in upper-case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for K...

[wido]

Github user wido commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1955#discussion_r102687113
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -2158,6 +2166,7 @@ public int compare(final DiskTO arg0, final DiskTO 
arg1) {
 
 if (diskBusType == null) {
 diskBusType = 
getGuestDiskModel(vmSpec.getPlatformEmulator());
+s_logger.debug("disk bus type derived from 
getPlatformEmulator: " + vmSpec.getPlatformEmulator() + ", diskbustype is: 
"+diskBusType.toString());
--- End diff --

Same here, please add the name of the VM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for K...

[wido]

Github user wido commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1955#discussion_r102687170
  
--- Diff: 
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
 ---
@@ -2216,6 +2225,8 @@ public int compare(final DiskTO arg0, final DiskTO 
arg1) {
 
disk.setCacheMode(DiskDef.DiskCacheMode.valueOf(volumeObjectTO.getCacheMode().toString().toUpperCase()));
 }
 }
+
+s_logger.debug("Adding disk: " + disk.toString());
--- End diff --

Same here, please include the name of the VM

Also, do we really need all these logging lines?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1960
  
@rhtyd tests looks good, except this one: 
```
ERROR: Tests default ha providers list
--
Traceback (most recent call last):
  File "/marvin/tests/smoke/test_hostha_simulator.py", line 199, in 
test_ha_list_providers
response = self.apiclient.listHostHAProviders(cmd)[0]
TypeError: 'NoneType' object has no attribute '__getitem__'
```
Looks like when simulator is not deployed test would fail. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1768
  
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-532


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1897: CLOUDSTACK-9733: Concurrent volume snapshots of a VM...

[cloudmonger]

Github user cloudmonger commented on the issue:

https://github.com/apache/cloudstack/pull/1897
  
### ACS CI BVT Run
 **Sumarry:**
 Build Number 381
 Hypervisor xenserver
 NetworkType Advanced
 Passed=104
 Failed=1
 Skipped=7

_Link to logs Folder (search by build_no):_ 
https://www.dropbox.com/sh/yj3wnzbceo9uef2/AAB6u-Iap-xztdm6jHX9SjPja?dl=0


**Failed tests:**
* test_non_contigiousvlan.py

 * test_extendPhysicalNetworkVlan Failed


**Skipped tests:**
test_01_test_vm_volume_snapshot
test_vm_nic_adapter_vmxnet3
test_static_role_account_acls
test_11_ss_nfs_version_on_ssvm
test_nested_virtualization_vmware
test_3d_gpu_support
test_deploy_vgpu_enabled_vm

**Passed test suits:**
test_deploy_vm_with_userdata.py
test_affinity_groups_projects.py
test_portable_publicip.py
test_over_provisioning.py
test_global_settings.py
test_scale_vm.py
test_service_offerings.py
test_routers_iptables_default_policy.py
test_loadbalance.py
test_routers.py
test_reset_vm_on_reboot.py
test_deploy_vms_with_varied_deploymentplanners.py
test_network.py
test_router_dns.py
test_login.py
test_deploy_vm_iso.py
test_list_ids_parameter.py
test_public_ip_range.py
test_multipleips_per_nic.py
test_regions.py
test_affinity_groups.py
test_network_acl.py
test_pvlan.py
test_volumes.py
test_nic.py
test_deploy_vm_root_resize.py
test_resource_detail.py
test_secondary_storage.py
test_vm_life_cycle.py
test_routers_network_ops.py
test_disk_offerings.py


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #815: CLOUDSTACK-8841: Storage XenMotion from XS 6.2...

[abhinandanprateek]

Github user abhinandanprateek commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/815#discussion_r102671303
  
--- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java ---
@@ -4717,8 +4717,8 @@ public VirtualMachine 
migrateVirtualMachineWithVolume(Long vmId, Host destinatio
 }
 
 // Check if the source and destination hosts are of the same type 
and support storage motion.
-if 
(!(srcHost.getHypervisorType().equals(destinationHost.getHypervisorType()) && 
srcHost.getHypervisorVersion().equals(destinationHost.getHypervisorVersion( 
{
-throw new CloudRuntimeException("The source and destination 
hosts are not of the same type and version. " + "Source hypervisor type and 
version: "
+if 
(!(srcHost.getHypervisorType().equals(destinationHost.getHypervisorType( {
+throw new CloudRuntimeException("The source and destination 
hosts are not of the same type. " + "Source hypervisor type and version: "
--- End diff --

The Xenserver version on the target host can be same or higher, please see 
if the version check can be further improved.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1958
  
@abhinandanprateek I think we hit an issue with the test: 

```
  File "/marvin/tests/smoke/test_over_provisioning.py", line 83, in 
test_UpdateStorageOverProvisioningFactor

CloudstackAPIException: Execute cmd: updateconfiguration failed, due to: 
errorCode: 431, errorText:Unable to update  storage pool with id 2. 
Overprovision not supported for NetworkFilesystem
 >> begin captured stdout << -
=== TestName: test_UpdateStorageOverProvisioningFactor | Status : EXCEPTION 
===
```
Reading the code changes looks like over provisioning is not supported for 
NFS, if that's expected we should edit the test I think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #815: CLOUDSTACK-8841: Storage XenMotion from XS 6.2 to XS ...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/815
  
@priyankparihar there are lots of failures on Xen62sp1, can you have a look.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1914: CLOUDSTACK-9753 - Update L10N resource files with 4....

[milamberspace]

Github user milamberspace commented on the issue:

https://github.com/apache/cloudstack/pull/1914
  
@karuturi This is the PR for update le localization files for CS 4.10. I've 
just updated the PR with the latest translation data from Transifex. Please 
consider to merge this PR before the RC.

cc @rhtyd 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1955
  
@nathanejohnson Thanks, for this good enhancement. Can we have a marvin 
tests that covers the new functionality? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1768
  
@blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

[blueorangutan]

Github user blueorangutan commented on the issue:

https://github.com/apache/cloudstack/pull/1768
  
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep 
you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

[borisstoyanov]

Github user borisstoyanov commented on the issue:

https://github.com/apache/cloudstack/pull/1813
  
@priyankparihar can you take a look on the test failures?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

[rashmidixit]

Github user rashmidixit commented on the issue:

https://github.com/apache/cloudstack/pull/1944
  
@rhtyd Will be trying this out today - will post my comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....

[milamberspace]

Github user milamberspace commented on the issue:

https://github.com/apache/cloudstack/pull/1896
  
@karuturi Since master (4.10) use now JSON files for the localization files 
(and too because on Transifex the localization's resources for each version of 
CS are different), so this PR will be merge only on 4.9.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---