[GitHub] cloudstack pull request: CLOUDSTACK-9238: Increase URL fields to 2...

Github user kevindierkx commented on the pull request: https://github.com/apache/cloudstack/pull/1341#issuecomment-171685523 @borisroman Because VARCHAR can handle 'most common' supported URL lengths perfectly fine. Most modern browsers have a limit somewhere around 2000

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Increase URL fields to 2...

Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/1341#issuecomment-171681534 @wido @kevindierkx Why not use TEXT? Then we'll never have to worry again :-) --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Increase URL fields to 2...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1341#issuecomment-171703995 Like @kevindierkx indeed says. A VARCHAR can be up to 64k characters long. It seems that 2k is the maximum length of a URL used in most systems. That's why we

[GitHub] cloudstack-cloudmonkey pull request: Summary: Allow 'sync' as a ve...

GitHub user DenEric opened a pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/12 Summary: Allow 'sync' as a verb Allow 'sync' as a verb without overriding the cloudmonkey sync implementation BUG-ID: CLOUDSTACK-9233 Reviewed-by: Frank Maximus

[GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...

Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1277#issuecomment-171572729 If those changes are needed by the community in the futures, please let me know and I will reopen the PR. One can also feel free to create a PR on top of

[GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...

Github user wilderrodrigues closed the pull request at: https://github.com/apache/cloudstack/pull/1277 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: BVT Results Google Page -

no presure Raja. I just think it might be somewhat leading to color on a threshold other then 100%. On Thu, Jan 14, 2016 at 11:25 AM, Raja Pullela wrote: > @seb - yes, will try to update this and will also remove the links. > > @daan - colors - 90+ above is green etc -

[GitHub] cloudstack pull request: CLOUDSTACK-9237: Create LB Healthcheck is...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1339#issuecomment-171604545 Oops my mistake. I will make one. Thanks @remibergsma --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack-docs pull request: Update nuage-plugin.rst

Github user runseb commented on the pull request: https://github.com/apache/cloudstack-docs/pull/16#issuecomment-171586237 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack-docs pull request: Update nuage-plugin.rst

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack-docs/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: CLOUDSTACK-9237: Create LB Healthcheck is...

GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1339 CLOUDSTACK-9237: Create LB Healthcheck issues - button alignment and error message goes outside the window Browser - Chrome Version 47.0.2526.106 m Steps to Repro:

Re: BVT Results Google Page -

I like this initial shot at it Raja. As an added request, I would like to see some logic in the colors. Now it seems 90% is a threshold and this obscures that the coverage went down from monday to tuesday on xenserver basiczone. Also Xenserver with advanced zonegrew to the highest coverage level

[GitHub] cloudstack pull request: CLOUDSTACK-9237: Create LB Healthcheck is...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1339#issuecomment-171593329 @nitin-maharana Thanks for the fix. Can you open a PR against 4.7 please? --- If your project is set up for it, you can reply to this email and have your reply

Re: BVT Results Google Page -

> On Jan 14, 2016, at 10:49 AM, Raja Pullela wrote: > > Please take a look - ACS Master BVT Dashboard - > https://docs.google.com/spreadsheets/d/17i_Bd78SrKoLnu0cFpwXbC0R-YKBTqs9sOw15hQLP3o/pubhtml > > I am still trying to find a way to upload the test results

[GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1277#issuecomment-171597154 :( indeed, @remibergsma. We have a policy against having our fork on github (tell you over a beer someday) Otherwise I think it would be merged in our private

[GitHub] cloudstack pull request: CLOUDSTACK-9237: Create LB Healthcheck is...

Github user nitin-maharana commented on the pull request: https://github.com/apache/cloudstack/pull/1339#issuecomment-171607891 Created a request against 4.7. (PR #1340) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-9237: Create LB Healthcheck is...

GitHub user nitin-maharana opened a pull request: https://github.com/apache/cloudstack/pull/1340 CLOUDSTACK-9237: Create LB Healthcheck issues - button alignment and error message goes outside the window Browser - Chrome Version 47.0.2526.106 m Steps to Repro:

Build failed in Jenkins: build-master-slowbuild #2982

See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

BVT Results Google Page -

Please take a look - ACS Master BVT Dashboard - https://docs.google.com/spreadsheets/d/17i_Bd78SrKoLnu0cFpwXbC0R-YKBTqs9sOw15hQLP3o/pubhtml I am still trying to find a way to upload the test results related to these runs. Best, Raja

[GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1277#issuecomment-171591896 To bad this is taking to much effort. We or someone will run into this and need it. hopefully we get it in then or someday, @wilderrodrigues. Thanks for

RE: BVT Results Google Page -

@seb - yes, will try to update this and will also remove the links. @daan - colors - 90+ above is green etc - occasionally couple of tests keeps failing and will pass in the next run - this is partly attributes to the test env I am using as well. The other orange color is because I have some

Re: BVT Results Google Page -

Hi Raja, Jan 12/13/14 should be the same as there were no commits to master after the 11th of January. I have seen this before, some tests fail without a change. When you run them again, they might succeed. Investigating the actual errors/exceptions might show what’s going on. Regards, Remi

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1293#discussion_r49713222 --- Diff: engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java --- @@ -821,9 +819,9 @@ protected boolean

RE: BVT Results Google Page -

You are right Remi, it is kind of an env issue because the runs pick up servers at random. I will see to minimize that variability to get consistent results. Let's see, -Original Message- From: Remi Bergsma [mailto:rberg...@schubergphilis.com] Sent: Thursday, January 14, 2016 4:09

[GitHub] cloudstack pull request: [4.7] Critical VPCVR issues fixed: CLOUDS...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1277#issuecomment-171593083 @DaanHoogland This PR addresses serious issues. Without it we couldn't run a reliable production services. It's a shame we can't get it merged. :-( --- If

[GitHub] cloudstack pull request: CLOUDSTACK-9237: Create LB Healthcheck is...

Github user nitin-maharana closed the pull request at: https://github.com/apache/cloudstack/pull/1339 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Pull Requests we should include in 4.7.1 / 4.8.0

Update: we managed to merge 2 PRs only… Anyone able to help review and test these PRs? Regards, Remi From: Remi Bergsma > Date: Sunday 10 January 2016 13:23 To: "dev@cloudstack.apache.org"

[GitHub] cloudstack-cloudmonkey pull request: Update requester.py

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack-cloudmonkey/pull/11#issuecomment-171620358 I've tried the update network API with ACS 4.5.2 and 4.7.0 and it works for me, so it could be a 4.3.2 related limitation. In that case, we can have

Build failed in Jenkins: build-master-slowbuild #2983

See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

[GitHub] cloudstack pull request: CLOUDSTACK-9198: Virtual router gets depl...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1278#issuecomment-171619337 @anshul1886 I did not understand what you wanted to express presenting those commits, would you care to explain? I noticed the commits you pointed out,

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Increase URL fields to 2...

GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/1341 CLOUDSTACK-9238: Increase URL fields to 2048 charachters from 255 255 characters is to small for various URLs like S3 pre-signed URLs. This causes one or more characters to be chopped of

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Increase URL fields to 2...

Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1341#issuecomment-171657390 I tested this by manually applying all the SQL patches and verifying that all URLs are still in the database like they should be. Also added a new template

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1293#discussion_r49728823 --- Diff: engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java --- @@ -821,9 +819,9 @@ protected boolean

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1293#discussion_r49730831 --- Diff: engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java --- @@ -821,9 +819,9 @@ protected boolean

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1293#discussion_r49728579 --- Diff: plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/resource/wrapper/NiciraCheckHealthCommandWrapper.java --- @@ -0,0

[GitHub] cloudstack pull request: CLOUDSTACK-9238: Increase URL fields to 2...

Github user kevindierkx commented on the pull request: https://github.com/apache/cloudstack/pull/1341#issuecomment-171659089 Should resolve problems with template extracts where the generated URL exceeds the 255 character limit. BTW: 2048 is somewhere in the middle of what is

Build failed in Jenkins: build-master-slowbuild #2988

See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

Github user agneya2001 commented on the pull request: https://github.com/apache/cloudstack/pull/1321#issuecomment-171865987 tag should not be a reason for incompatibility. that is you can mover from a service offering that is similar but with any other set of tags. we should just do

[GitHub] cloudstack pull request: CLOUDSTACK-8830 CLONE - VM snapshot fails...

Github user alexandrelimassantana commented on the pull request: https://github.com/apache/cloudstack/pull/798#issuecomment-171739474 @maneesha-p you could extract the content of this if-condition into a method to test the TaskInfo object, making the code a little more reusable and

Re: Pull Requests we should include in 4.7.1 / 4.8.0

It looks like we are close on the Ceph deletion PR as well: https://github.com/apache/cloudstack/pull/1230 That one would be well received by anyone running Ceph. - Si From: Wido den Hollander Sent: Sunday, January 10, 2016 1:20 PM

[GitHub] cloudstack pull request: CLOUDSTACK-9211: Support passing vRAM siz...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1310#issuecomment-171752709 Hi @cristofolini Thanks for your comments. I refactored the method to make it more readable into two methods, and added description to both, like javadoc.

Build failed in Jenkins: build-master-slowbuild #2989

See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

[GitHub] cloudstack pull request: CLOUDSTACK-6181: Add 'root disk size' fie...

GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/1342 CLOUDSTACK-6181: Add 'root disk size' field in instance wizard for KVM templates This commit includes three changes: (1) Revert commit 13bf1ec5da9891eca98ef5dab61bf74b6db9530b to show

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1321#issuecomment-171885529 +1 for removing the check. I now hack the db if I want to do this and that shouldn't be necessary. --- If your project is set up for it, you can reply to

Build failed in Jenkins: build-master-slowbuild #2987

See -- [...truncated 28733 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

Build failed in Jenkins: build-master-slowbuild #2986

See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

Build failed in Jenkins: build-master-slowbuild #2985

See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

[GitHub] cloudstack pull request: CLOUDSTACK-9192: UpdateVpnCustomerGateway...

Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1300#issuecomment-171666469 Code changes LGTM, looked in the UpdateVpnGatewayCmd and checked the response name (it is 'updatevpngatewayresponse'). --- If your project is set up for it, you can

Build failed in Jenkins: build-master-slowbuild #2984

See -- [...truncated 28723 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

[GitHub] cloudstack pull request: Add Health Check Command to NSX plugin

Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1293#discussion_r49748364 --- Diff: plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/resource/wrapper/NiciraCheckHealthCommandWrapper.java --- @@ -0,0

Re: Unable to create VMs on master because of virtual router failing to start

So after a bit of debugging. I found that those scripts reside on the Dom0 of Xenserver. I removed the /opt/cloud directory from Xenserver, cleaned up the ssh key file, removed the tags and added the host back and it works now. On Thu, Jan 14, 2016 at 1:46 AM, Syed Mushtaq

[GitHub] cloudstack pull request: CLOUDSTACK-9211: Support passing vRAM siz...

Github user cristofolini commented on the pull request: https://github.com/apache/cloudstack/pull/1310#issuecomment-171798749 Thanks for taking the time to add the descriptions and refactoring, @nvazquez. It has helped readability quite a bit. :) Now, in case you're