[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

2016-03-20 Thread agneya2001
Github user agneya2001 commented on the pull request: https://github.com/apache/cloudstack/pull/1371#issuecomment-199133805 @bvbharatk Thank you for running the marvin tests. Do you think any specific test that is failing on this branch ? --- If your project is set up for it, you

[GitHub] cloudstack-docs-admin pull request: OSPF: WIP formatting documenta...

2016-03-20 Thread agneya2001
Github user agneya2001 commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/36#issuecomment-199133110 @GabrielBrascher all suggestions are good, made them for some i will have to tune the code, will do that too. --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

2016-03-20 Thread alexandrelimassantana
Github user alexandrelimassantana commented on the pull request: https://github.com/apache/cloudstack/pull/1410#issuecomment-199090954 Hello @ustcweizhou I am curious to know if this segment is really necessary: ```Java disk = new DiskTO(volumeTO, vol.getDeviceId(),

Re: [VOTE] Move 'apache/cloudstack' -> 'apache-cloudstack/cloudstack'

2016-03-20 Thread Shane Curcuru
Will Stevens wrote earlier: ... snip... > *Proposal:* > Transfer ownership of the 'apache/cloudstack' mirrored repository out of > the 'apache' github organization into the 'apache-cloudstack' github > organization (which I have already setup and started inviting users to). > Both members of the

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

2016-03-20 Thread cristofolini
Github user cristofolini commented on the pull request: https://github.com/apache/cloudstack/pull/1410#issuecomment-199072462 @ustcweizhou I still can't help but notice that lines 1066-1086 and 1362-1382 in the `VolumeOrchestrator` class seem to contain exactly the same piece of

[GitHub] cloudstack pull request: speedup iptables setup

2016-03-20 Thread cristofolini
Github user cristofolini commented on the pull request: https://github.com/apache/cloudstack/pull/1449#issuecomment-199059690 @kollyma I like what you did here. Besides apparently speeding up the iptables setup, the code looks more streamlined this way. But it seems your build

Re: Issue: CLOUDSTACK-9255 Unable to start VM DomainRouter due to error in finalizeStart

2016-03-20 Thread Remi Bergsma
Hi Martin, Thanks, will have a look at it! These scripts are in the systemvm.iso in the CloudStack release, so not in the template. If you build a custom package or war to update your management servers you can use it already. Otherwise you need the next release. Regards, Remi Sent from my

Re: Issue: CLOUDSTACK-9255 Unable to start VM DomainRouter due to error in finalizeStart

2016-03-20 Thread martin kolly
Hi Remi PR #1449 created as requested. Tests in our environment showed that it speeds up the router configuration quite a bit. In the meantime https://github.com/apache/cloudstack/pull/1356 seems to be merged which resolves CLOUDSTACK-9255. So not sure if PR#1449 is still of interest.. Do

[GitHub] cloudstack pull request: speedup iptables setup

2016-03-20 Thread kollyma
GitHub user kollyma opened a pull request: https://github.com/apache/cloudstack/pull/1449 speedup iptables setup PR against 4.7 as discussed with Remi Bergsma. This will speed up the iptables creation on the virtual router. Testing showed the following: with current

[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

2016-03-20 Thread alexandrelimassantana
Github user alexandrelimassantana commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1441#discussion_r56768712 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java --- @@ -440,41 +400,28 @@

Re: [IMPORTANT] Huge Github PR Backlog

2016-03-20 Thread John Burwell
All, While I am stating the obvious, but we must remember that commit/PR flow is the lifeblood our community. Over the past the month, there have been zero contributions to master [1] against 180 open PRs. As Simon points out, the longer the PR sits, the farther it diverges — increasing the

[GitHub] cloudstack pull request: More VR performance!

2016-03-20 Thread milamberspace
Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/1356#issuecomment-198946677 FYI This PR fixes the bug CLOUDSTACK-9255 https://issues.apache.org/jira/browse/CLOUDSTACK-9255 (perhaps need to backport this PR on 4.6

Re: [VOTE] Move 'apache/cloudstack' -> 'apache-cloudstack/cloudstack'

2016-03-20 Thread chunfeng tian
+1 On Sun, Mar 20, 2016 at 1:51 PM, Mattmann, Chris A (3980) < chris.a.mattm...@jpl.nasa.gov> wrote: > +1.. > > ++ > Chris Mattmann, Ph.D. > Chief Architect > Instrument Software and Science Data Systems Section (398) > NASA Jet

[GitHub] cloudstack pull request: CLOUDSTACK-9142 Migrate VM changes xmlDes...

2016-03-20 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1348#discussion_r56490248 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java --- @@ -190,4 +195,27 @@ Use

[GitHub] cloudstack pull request: Worked around some possible runtime excep...

2016-03-20 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1444#issuecomment-198889972 @remibergsma I understand your point. Anyways if we decide to revert that PR, I can get the changes it introduce and apply here; then we can follow

Build failed in Jenkins: build-master-slowbuild #3490

2016-03-20 Thread jenkins
See -- [...truncated 28692 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

[GitHub] cloudstack pull request: Worked around some possible runtime excep...

2016-03-20 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1444#issuecomment-198881402 This PR has some nice improvements, so that's great @rafaelweingartner! Still, I'm clueless why people merge without running a single integration

[GitHub] cloudstack pull request: CLOUDSTACK-9304: Add nuagevsp userdata te...

2016-03-20 Thread swill
Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1431#issuecomment-197920029 It was already merged. I will leave it for now, but I will take note of this PR to validate it once my CI is up and running to make sure it does not cause any

[GitHub] cloudstack pull request: Removed unused Classes

2016-03-20 Thread GabrielBrascher
GitHub user GabrielBrascher opened a pull request: https://github.com/apache/cloudstack/pull/1448 Removed unused Classes Remove unused Classes (classes with no references: - com.cloud.agent.api.CheckStateAnswer - com.cloud.agent.api.StartupVMMAgentCommand -

Re: External fork of Cloudstack (was Re: [GitHub] cloudstack pull request: Is the project attempting a fork on Githu...)

2016-03-20 Thread Will Stevens
I think what most of us are trying to achieve is the ability for the code to remain in sync, while getting access to the Github features we so desperately need. This is obviously a difficult problem for everyone involved and I respect that. A healthy debate on this is the only way we are going

[GitHub] cloudstack pull request: CLOUDSTACK-9297 - Reworked logic in Stora...

2016-03-20 Thread mike-tutkowski
Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1441#issuecomment-197942848 The canHandle method is used by CloudStack's snapshot infrastructure to determine which snapshot strategy to use. For example,

[GitHub] cloudstack pull request: Is the project attempting a fork on Githu...

2016-03-20 Thread chrismattmann
Github user chrismattmann commented on the pull request: https://github.com/apache/cloudstack/pull/1442#issuecomment-197484183 Sorry was talking about this: https://github.com/cloudstack/cloudstack which I saw pop up. --- If your project is set up for it, you can reply to this email

Re: External fork of Cloudstack (was Re: [GitHub] cloudstack pull request: Is the project attempting a fork on Githu...)

2016-03-20 Thread Tutkowski, Mike
I see your concern, Chris. Yes, the community will continue to discuss. Hopefully others will join in with their views. From: Mattmann, Chris A (3980) Sent: Thursday, March 17, 2016 10:16 AM To: dev@cloudstack.apache.org

Build failed in Jenkins: build-master-slowbuild #3482

2016-03-20 Thread jenkins
See -- [...truncated 28679 lines...] [INFO] [INFO] --- findbugs-maven-plugin:3.0.1:findbugs (findbugs) @ cloud-quickcloud --- [INFO] [INFO] <<< findbugs-maven-plugin:3.0.1:check

Re: Build failed in Jenkins: build-master-slowbuild #3368

2016-03-20 Thread Will Stevens
@Raja, did you have a chance to test this? https://github.com/apache/cloudstack/pull/1427 *Will STEVENS* Lead Developer *CloudOps* *| *Cloud Solutions Experts 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw @CloudOps_ On Wed, Mar 2, 2016 at 2:00 PM, Daan Hoogland