[GitHub] cloudstack pull request: maven: Upgrade dependency versions

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1397#issuecomment-211725428 @bhaisaab I am still getting compile errors. I will reconfigure my CI environment to use an older version of Java to see if that fixes the problem. ```

[GitHub] cloudstack pull request: systemvm: preserve file permissions, set ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1420#issuecomment-211706714 Do I need to do anything special with this merge because it includes systemvm changes? If I need to do anything special, please help me understand the details.

[GitHub] cloudstack pull request: systemvm: preserve file permissions, set ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1420#issuecomment-211706541 With these results, I think this PR is ready. I will add it to my merge list. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: systemvm: preserve file permissions, set ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1420#issuecomment-211706355 ## CI RESULTS ### 84/85 TESTS PASSED The test that failed is a test that commonly fails in my environment and has been

[GitHub] cloudstack pull request: systemvm: preserve file permissions, set ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1420#issuecomment-211706237 ## CI RESULTS ### 84/85 TESTS PASSED The test that failed is a test that commonly fails in my environment and has been

Re: ACS PRs Status - 2016/04/18

For sure. I will be doing a status report every Monday till the RC is accepted to help keep everyone on the same page. I think this will help us organize ourselves to best utilize our limited resources and keep us focused on getting PRs ready to merge. This will all be easier to manage when we

Re: ACS PRs Status - 2016/04/18

Hi Will Thanks for the detailed update and effort. Please keep us posted. Regards ilya On 4/18/16 1:48 PM, Will Stevens wrote: > ACS PRs > >- 1452 - master (ready, pending LGTM) >- 1475 - 4.7 (pending clarification) >- 1420 - master + svm (CI running) >- 1365 - 4.7 (pending

[GitHub] cloudstack-www pull request: Update events from the landing pages

GitHub user pdion891 opened a pull request: https://github.com/apache/cloudstack-www/pull/26 Update events from the landing pages Unfortunatly this PR also include last update of the website which was made for the release of 4.8. The only missing commit in the asf-site

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-211585759 Cool, I'll work on it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-211581957 That is it, and then this new class would extend ManagerBase. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-211581223 @rafaelweingartner I pushed unit tests for this new methods. So the idea is that the 3 classes extend from a new class and not ManagerBase? --- If your

ACS PRs Status - 2016/04/18

ACS PRs - 1452 - master (ready, pending LGTM) - 1475 - 4.7 (pending clarification) - 1420 - master + svm (CI running) - 1365 - 4.7 (pending ALL) - 1402 - 4.7 (needs work) - 1454 - master (ready, pending LGTM) - 1459 - master (rerun CI) NOTE: This closes #561 - 1409 -

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1365#issuecomment-211565374 @rafaelweingartner I am not sure. @bhaisaab would you mind clarifying for us. I am trying to stay on top of this stuff, but I am very much playing catchup. :)

[GitHub] cloudstack pull request: Bump ssh retries to prevent false positiv...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1473#issuecomment-211563985 @remibergsma apparently Jenkins doesn't like us much now days. Can you do a force push again for me. Also, I am looking for another LGTM on this PR. Thanks...

[GitHub] cloudstack pull request: CLOUDSTACK-9323: Fix cancel host maintena...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1454#issuecomment-211563367 @abhinandanprateek, I believe you are away this week, but can your address @jburwell's comments when you have a chance. Thanks. --- If your project is set up for

[GitHub] cloudstack pull request: Check the existence of 'forceencap' param...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1402#issuecomment-211562114 @remibergsma can you review the functionality you expect. I think the logic is wrong, and if it is not, then it is VERY misleading. The code in question

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1365#issuecomment-211555695 @swill my final state is LGTM, will this be merged forward? I believe @bhaisaab has mentioned that he has another PR that bumps VMware dependencies

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-211553575 @nvazquez thanks for the analysis on the ManagerBase issue. Giving that I think the best approach would be to let all of the three (3) classes

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1365#issuecomment-211554643 I think this one is pretty close. I want to run CI against it since there have been changes since the last CI run. I also need some LGTM code reviews. I don't see

[GitHub] cloudstack pull request: CLOUDSTACK-9349: Enable root disk detach ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1500#issuecomment-211551366 would you mind squashing your commits for this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

CLOUDSTACK-9349: Enable root disk detach for KVM with new Marvin tests PR#1500

Hello all, I submitted PR 1500 this morning that addresses JIRA issue CLOUDSTACK-9349 around KVM Root Volume detach/attach. This was really a very minor code change to java, but I also submitted a marvin integration test that I would love to get some feedback on. This was my first pass at

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1371#issuecomment-211541350 Can you rebase this PR based on the current master so we can resolve the conflicts so we can get CI running against this again. I want to do a push on the PRs that

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-211540538 Cool, I'll working on test cases. `VMSnapshotManagerImpl` is using `_name` variable from `ManagerBase,` and `SnapshotManagerImpl` overrides `configure`,

[GitHub] cloudstack pull request: Strongswan vpn feature

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-211539172 I would like to get on top of the PRs that have systemvm changes, because it looks like we will have to push new systemvms for the 4.9 release. We still have a bit

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1423#issuecomment-211537431 Ok, thanks @bhaisaab. So I need to get on the systemvm template stuff asap to try to get those PRs in a good place so we have a little breathing room before the RC

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1423#issuecomment-211524917 @swill we can ask around on ML, afaik in addition to strongswan I known of the ospf stuff by @abhinandanprateek which needs zebra and related packages for ospf.

[GitHub] cloudstack pull request: Removed unnecessary code from getGuestOsT...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1262 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: Strange XenServer SR behavior when deploying system VMs in Basic Zone on 4.9

Thanks! It's no rush from my point of view. Just happy to know it looks like the problem's been fixed. :) From: Rafael Weingärtner Sent: Monday, April 18, 2016 11:41 AM To: dev@cloudstack.apache.org Subject: Re: Strange

[GitHub] cloudstack pull request: Fixing an issue in Marvin around creating...

GitHub user mike-tutkowski opened a pull request: https://github.com/apache/cloudstack/pull/1501 Fixing an issue in Marvin around creating a template from a snapshot This fixes the following ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-9354 The problem was that

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-211499145 @nv I am sorry, I might have seen the “@Local” annotation in some other PR, and I thought I have seen on yours. The classes

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1423#issuecomment-211502237 @bhaisaab Ok thanks. Are there other things we want to get into the systemvm template if we do publish a new one? Probably not the best place for this discussion,

Re: Strange XenServer SR behavior when deploying system VMs in Basic Zone on 4.9

We found it last Saturday during the factoring of a test case! That was pure lucky. The code of the PR is not that good yet. But, we will work to get it ready to be reviewed and merged. On Mon, Apr 18, 2016 at 2:37 PM, Tutkowski, Mike wrote: > Thanks, Rafael! That

Re: Strange XenServer SR behavior when deploying system VMs in Basic Zone on 4.9

Thanks, Rafael! That very much looks like it could solve the problem. I've subscribed to the PR for notifications. Once I see it's in the codebase, I can re-build my dev environment and see if I still have the issue. From: Rafael Weingärtner

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-211487161 Thanks @rafaelweingartner I made a refactor based in your comments. I could remove "extends ManagerBase" from QueryManagerImpl but not from VMSnapshotManagerImpl

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-211485538 I agree with you @syed, it is always good to discuss the patterns we use. That example you brought up also works; it would do the same tricky to test,

Re: [GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

As I said I understand the check of "vm!= null". I was only referring to the "vm.getType". I did not know that it could not be null. I think what you were trying to say is that, once "vm" object is not null, there is no way "getType" can return null, right? If that is a sure thing, I am ok with

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1423#issuecomment-211481666 @swill we'll need to publish a new systemvm template (i.e. we can no longer use the 4.6 systemvm template) --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r60096454 --- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java --- @@ -1835,6 +1847,26 @@ private Volume orchestrateDetachVolumeFromVM(long vmId,

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1365#issuecomment-211479815 if you say so. Be my guest. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1365#issuecomment-211479011 @rafaelweingartner both your comments are opinionated and not technical; we've to agree to disagree here ask you to be practical and pragmatic here. I've left

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r60095758 --- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java --- @@ -1835,6 +1847,26 @@ private Volume orchestrateDetachVolumeFromVM(long

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r60095074 --- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java --- @@ -1835,6 +1847,26 @@ private Volume orchestrateDetachVolumeFromVM(long vmId,

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-8562: add informati...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/37#issuecomment-211475206 Thanks @pdion891 sure after the freeze date, we can add to the release notes list of new APIs, list of new features along with any major changes etc.

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-211455173 Loving the discussion here guys! Based on the comments by @jburwell I found

[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1452#issuecomment-211453267 @pedro-martins can you live with the present state? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: Removed unnecessary code from getGuestOsT...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1262#issuecomment-211441451 Ok perfect, thanks @rafaelweingartner. I will get this merged... --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Removed unnecessary code from getGuestOsT...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1262#issuecomment-211438727 @swill thanks for the support. I have already been very critical with this PR even before it was opened. So, the way it is now, it is good to be

[GitHub] cloudstack pull request: Removed unnecessary code from getGuestOsT...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1262#issuecomment-211436333 @rafaelweingartner I understand you feel like you have a conflict of interests, but at the same time, you are also very familiar with the code so are in a good

[GitHub] cloudstack pull request: Removed unnecessary code from getGuestOsT...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1262#issuecomment-211431496 In this situation, I do not know if mine would count, giving that I also have helped with some code changes. --- If your project is set up for it, you

[GitHub] cloudstack pull request: Removed unnecessary code from getGuestOsT...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1262#issuecomment-211419101 I need one more LGTM code review of this one, otherwise it is looking to be in good order... --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: Remove unused images

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1475#issuecomment-211417769 @remibergsma how should we handle this PR now that we have found references to these files? --- If your project is set up for it, you can reply to this email and

Re: Strange XenServer SR behavior when deploying system VMs in Basic Zone on 4.9

Would the problem discussed here relate to the one here https://github.com/apache/cloudstack/pull/1499? On Mon, Apr 18, 2016 at 11:04 AM, Tutkowski, Mike wrote: > Looks like I already opened a ticket on this in January. :) > >

Re: Strange XenServer SR behavior when deploying system VMs in Basic Zone on 4.9

Looks like I already opened a ticket on this in January. :) https://issues.apache.org/jira/browse/CLOUDSTACK-9224 I added info to it. From: Tutkowski, Mike Sent: Saturday, April 16, 2016 9:58 AM To: dev@cloudstack.apache.org

[GitHub] cloudstack pull request: CLOUDSTACK-9349

Github user dmabry commented on the pull request: https://github.com/apache/cloudstack/pull/1500#issuecomment-21138 Here is a manual test using cloudmonkey against our KVM lab. `(local) 🐵 > list volumes virtualmachineid=f2870d90-d294-474b-b7da-95bad01e6c09 listall=true

[GitHub] cloudstack pull request: CLOUDSTACK-9349

GitHub user dmabry opened a pull request: https://github.com/apache/cloudstack/pull/1500 CLOUDSTACK-9349 This PR addresses the KVM detach/attach ROOT disks from VMs (CLOUDSTACK-9349). In short, this allows the KVM Hypervisor, and I added the Simulator as a valid hypervisor for

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1423#issuecomment-211375246 Introducing an external dependency is probably going to cause some problems. @bhaisaab can you review this and maybe give some feedback on the best way to handle

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1423#issuecomment-211374488 @swill I have added a marvin test to see if the VPN service starts correctly however I am having trouble getting marvin to work correctly. When I run the test I get

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-211374296 Nice work on the quality code reviews guys. @DaanHoogland since there have been a bunch of changes, would you mind running your CI against this one? I am sorting

[GitHub] cloudstack pull request: CLOUDSTACK-9322: Support for Internal LB ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1452#issuecomment-211370314 I think this is ready pending 1 more LGTM code review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-8562: add informati...

Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/37#issuecomment-211370130 LGTM, but we will also have to add part of this addition into the release note of 4.9. Thanks @bhaisaab --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-9251: Fix issue in scale VM to...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1363 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Removed unused code from com.cloud.api.Ap...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1263 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Fixed Profiler's unit tests bugs.

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1445#issuecomment-211359351 @swill thanks, I was expecting for this one a long time --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1365#issuecomment-211359119 @swill , @bhaisaab There are still questions to be addressed here. One example is the question at “VolumeApiServiceImpl” line1857. Another one

[GitHub] cloudstack pull request: Fixed Profiler's unit tests bugs.

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1445 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-211320093 Doc PR - https://github.com/apache/cloudstack-docs-admin/pull/37 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack-docs-admin pull request: CLOUDSTACK-8562: add informati...

GitHub user bhaisaab opened a pull request: https://github.com/apache/cloudstack-docs-admin/pull/37 CLOUDSTACK-8562: add information on dynamic roles Adds documentation on dynamic roles feature /cc @swill @pdion891 You can merge this pull request into a Git repository by

[GitHub] cloudstack pull request: Undetected bug correct and refactor of th...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1499#discussion_r60035839 --- Diff: services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java --- @@ -497,9 +506,7

[GitHub] cloudstack pull request: Undetected bug correct and refactor of th...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1499#discussion_r60035791 --- Diff: services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java --- @@ -391,9 +395,15

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r60035619 --- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java --- @@ -1835,6 +1847,26 @@ private Volume orchestrateDetachVolumeFromVM(long

[GitHub] cloudstack-docs-admin pull request: Be explicit in regards to Open...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack-docs-admin/pull/35 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack-docs-admin pull request: Be explicit in regards to Open...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack-docs-admin/pull/35#issuecomment-211291830 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1365#issuecomment-211264892 @swill can we get this merged, while ShapeBlue has tested this internally if you test with your non-vmware CI that should confirm it does not break anything else;

[GitHub] cloudstack pull request: maven: Upgrade dependency versions

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1397#issuecomment-211263699 @swill advise how to proceed on this one? are you still getting the build issues @DaanHoogland ping --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: systemvm: preserve file permissions, set ...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1420#issuecomment-211263537 @swill yes though we should run CI, the fix is simple and ensure that umask setting is used when creating new files. the umask 022 is default on most distros

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-211262271 @swill I've fixed the outstanding issues, can you run your CI on this and help merge? thanks --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-211261793 @swill I've fixed the outstanding issues, can you run your CI on this and help merge? thanks --- If your project is set up for it, you can reply to this email