[GitHub] cloudstack pull request: Marvin: Replace a timer.sleep(30) with pu...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1529#issuecomment-216444177 I tested this by walking through with the debugger when the delete method on Host was invoked from a test script of mine. --- If your project is set up for

[GitHub] cloudstack pull request: Marvin: Replace a timer.sleep(30) with pu...

GitHub user mike-tutkowski opened a pull request: https://github.com/apache/cloudstack/pull/1529 Marvin: Replace a timer.sleep(30) with pulling logic https://issues.apache.org/jira/browse/CLOUDSTACK-9374 From the ticket: In the base.py file, there is a Host class

Re: I cannot start agent - Cloudstack 4.8 - Connection closed with -1 on reading size

also check java version and upgrade nss http://blog.backslasher.net/java-ssl-crash.html ~Rajani On Tue, May 3, 2016 at 7:36 AM, Simon Weller wrote: > Ellie, > > Can you try forcing ACS Management to only bind to IPV4? > Normally this is done in the JAVA_OPTS by setting >

[GitHub] cloudstack pull request: Vmdk findbugs

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1351#issuecomment-216442417 @DaanHoogland I'm seeing a lot of commits, can you rebase against 4.7? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1365#issuecomment-216442130 @rhtyd thanks for fixing the merge conflicts. 👍 @GabrielBrascher and @mike-tutkowski, I know you guys have spent some time with this file, would you

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-216442091 @DaanHoogland can you do a rebase and push -f, Travis failed for `test_01_scale_vm` test In general, LGTM (just code review) --- If your project is set up

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-216441837 Thanks @rhtyd, this makes me feel a little more comfortable. @borisroman if you can give us a bit of an outline of what you have tested, I think it will help

Re: ACS PRs Status - 2016/05/02

hopefully we will have labels soon™. i am working on trying to get the repo moved from the 'apache' github org to 'apache-cloudstack' so we can control this sort of stuff and enable labels. it will make things SOO much easier. simon's contributions have been very helpful for me as RM though, so

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1321#issuecomment-216440946 Thanks @rhtyd. I will do a CI run on master before I merge anything else. I will also pull in a couple people who I know have worked on this code to review your

Re: ACS PRs Status - 2016/05/02

great job Simon David and Will. Given that we dont have github labels, this is very useful for the RM to pickup the prs to merge and for others to review pending. ~Rajani On Tue, May 3, 2016 at 9:47 AM, Simon Weller wrote: > All, > > Will mentioned a little project we've been

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1444#issuecomment-216436317 @rafaelweingartner for a project with thousands of commits, splitting the commits for a PR or bug that solves for the same logical issue results in fragmented

[GitHub] cloudstack pull request: CLOUDSTACK-9366: Capacity of one zone-wid...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1516#issuecomment-216435537 @sudhansu7 can you rebase against latest master, squash the changes to a single commit and push -f to re-kick travis. Thanks --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-216435475 @DaanHoogland thanks, how about you have consecutive changes by the same author squashed to one commit; while keep it separate per author in general --- If your

[GitHub] cloudstack pull request: Cloudstack 9339: Virtual Routers don't ha...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1519#issuecomment-216435381 @swill agree for keeping it against 4.7; but it would be great if @dsclose can squash the changes to a single commit as all of them solve for Cloudstack-9339 issue

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-216435191 @swill yes indeed we've performed upgrade tests with 4.8.1 to 4.9.0-SNAPSHOT (not using the feature by default) and then using migrate-dyanamicroles.py script; the

[GitHub] cloudstack pull request: Set default networkDomain to empty instea...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1485#issuecomment-216435060 tag:easypr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Set default networkDomain to empty instea...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1485#issuecomment-216435050 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-9373: Class methods over-shawd...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1528#issuecomment-216433425 LGTM based on the discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1365#issuecomment-216433479 Obviously this merge conflict exists because something has been refactored in master which was not merged into previous versions. We need to understand what was

Re: ACS PRs Status - 2016/05/02

All, Will mentioned a little project we've been working on to try and help get a grasp on the open PR list. You can access it here: http://acs:a...@acspr.ena.net Due to the lack of github labels currently, there's quite a bit of regex/pattern matching involved in determining data sets, so

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1321#discussion_r61833885 --- Diff: engine/orchestration/test/com/cloud/vm/VirtualMachineManagerImplTest.java --- @@ -505,4 +513,24 @@ public void testSendStopWithNullAnswer()

[GitHub] cloudstack pull request: Quota: consolidated lockable account chec...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1350#issuecomment-216423449 @swill yes that's what I meant, therefore commented that it's ready for merge. Thanks. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: kvm: Aqcuire lock when running security g...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1408#issuecomment-216423344 @swill no objection, let's merge this tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r61833516 --- Diff: plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java --- @@ -1363,24 +1364,15 @@ private Answer

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1321#discussion_r61833399 --- Diff: engine/orchestration/test/com/cloud/vm/VirtualMachineManagerImplTest.java --- @@ -505,4 +513,24 @@ public void testSendStopWithNullAnswer()

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r61833203 --- Diff: plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java --- @@ -1363,24 +1364,15 @@ private Answer

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1321#discussion_r61833186 --- Diff: engine/orchestration/test/com/cloud/vm/VirtualMachineManagerImplTest.java --- @@ -505,4 +513,24 @@ public void testSendStopWithNullAnswer()

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-216421909 @swill forced pushed; the Jenkins server is not reliable -- as long as Travis is green we are alright; the only additional check Jenkins does is the rat check, which

Re: I cannot start agent - Cloudstack 4.8 - Connection closed with -1 on reading size

Ellie, Can you try forcing ACS Management to only bind to IPV4? Normally this is done in the JAVA_OPTS by setting -Djava.net.preferIPv4Stack=true -Djava.net.preferIPv4Addresses=true I think on the ACS Ubuntu release, JAVA_OPTS is set in your init scripts, but I'm not absolutely sure about

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

Github user Slair1 commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-216396939 @kiwiflyer and @rhtyd I've been troubleshooting the proxy issue and it was an issue in my environment! i have things worked out and everything works fine. ---

RM after 4.9

Hello All, As you all know, I am the RM for the 4.9 release. Unfortunately, this is not a position I will be able to maintain for the long term, so we should start this discussion sooner rather than later. I am actively working to simplify the RM role by working towards the following goals: -

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61817458 --- Diff: test/integration/smoke/test_outofbandmanagement.py --- @@ -0,0 +1,561 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61816897 --- Diff: test/integration/smoke/test_outofbandmanagement.py --- @@ -0,0 +1,561 @@ +# Licensed to the Apache Software Foundation (ASF) under one

ACS PRs Status - 2016/05/02

ACS PRs - 1433 - master (ready) - 1230 - master (ready) - 1350 - master (ready) - 1463 - master (ready) - 1502 - master (ready, pending comments) - 1054 - master (ready, do grep) - 1515 (1375) - 4.8 (ready, pending new 4.7 PR) - 1477 - 4.7 (ready, pending verification)

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61816189 --- Diff: test/integration/smoke/test_outofbandmanagement.py --- @@ -0,0 +1,561 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61816081 --- Diff: test/integration/smoke/test_outofbandmanagement.py --- @@ -0,0 +1,561 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user serverchief commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-216382896 @kiwiflyer, My testing with this patch - if you have at least several hundred KVM nodes connected to 2 MS via VIP and take 1 MS down, you will notice

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61815152 --- Diff: test/integration/smoke/test_outofbandmanagement.py --- @@ -0,0 +1,561 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61815144 --- Diff: test/integration/smoke/test_outofbandmanagement.py --- @@ -0,0 +1,561 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61814453 --- Diff: server/test/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceTest.java --- @@ -0,0 +1,119 @@ +// Licensed to the

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61814182 --- Diff: server/test/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceTest.java --- @@ -0,0 +1,119 @@ +// Licensed to the

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61813894 --- Diff: server/test/com/cloud/resource/MockResourceManagerImpl.java --- @@ -172,6 +173,12 @@ public Cluster getCluster(final Long clusterId) {

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61813822 --- Diff: server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java --- @@ -0,0 +1,532 @@ +// Licensed to the

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61813461 --- Diff: server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java --- @@ -0,0 +1,532 @@ +// Licensed to the

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-216378613 Thank you @kiwiflyer. 👍 @rhtyd can you force push this PR again to try to get Jenkins green? Thanks... Otherwise this one is ready... --- If your

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-216375175 I pulled this into a hardware lab on 4.8.1. I setup a number of fake clients and hammered 8250. Prior to the patch the agents end up in a disconnected state

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61810525 --- Diff: server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java --- @@ -0,0 +1,532 @@ +// Licensed to the

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61810461 --- Diff: server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java --- @@ -0,0 +1,532 @@ +// Licensed to the

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61810223 --- Diff: server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java --- @@ -0,0 +1,532 @@ +// Licensed to the

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61809934 --- Diff: server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java --- @@ -0,0 +1,532 @@ +// Licensed to the

[GitHub] cloudstack pull request: Update L10N resource files with 4.7 strin...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1527#issuecomment-216371746 Previous PR was #1374, for book keeping... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: Python Question (with regards to Marvin)

If a couple people could review this (it should be fast), I opened the following PR: https://github.com/apache/cloudstack/pull/1528 Thanks! Mike From: Tutkowski, Mike Sent: Sunday, May 1, 2016 7:16 PM To: dev@cloudstack.apache.org Subject: Re: Python

[GitHub] cloudstack pull request: CLOUDSTACK-9373: Class methods over-shawd...

GitHub user mike-tutkowski opened a pull request: https://github.com/apache/cloudstack/pull/1528 CLOUDSTACK-9373: Class methods over-shawdowing instance methods We have some methods in base.py that are named the same. Per my findings below, Python methods in a class should

[GitHub] cloudstack pull request: Update L10N resource files with 4.7 strin...

GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/1527 Update L10N resource files with 4.7 strings from Transifex (20160502) Force "translator" mode with the transifex client. cc @swill the new PR. You can merge this pu

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

Github user swill commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1321#discussion_r61808445 --- Diff: engine/orchestration/test/com/cloud/vm/VirtualMachineManagerImplTest.java --- @@ -505,4 +513,24 @@ public void testSendStopWithNullAnswer()

[GitHub] cloudstack pull request: Update L10N resource files with 4.7 strin...

Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/1374#issuecomment-216370438 @swill ok I will do this. But you must understand that the L10N resources files for each CS version are different and cannot merge together. On the Transifex

[GitHub] cloudstack pull request: Update L10N resource files with 4.7 strin...

Github user milamberspace closed the pull request at: https://github.com/apache/cloudstack/pull/1374 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61807854 --- Diff: server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java --- @@ -0,0 +1,532 @@ +// Licensed to the

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user swill commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1365#discussion_r61807823 --- Diff: plugins/hypervisors/vmware/src/com/cloud/storage/resource/VmwareStorageProcessor.java --- @@ -1363,24 +1364,15 @@ private Answer

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61806348 --- Diff: api/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementService.java --- @@ -0,0 +1,51 @@ +// Licensed to the Apache

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61804388 --- Diff: server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java --- @@ -0,0 +1,532 @@ +// Licensed to the

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1321 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61803751 --- Diff: server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java --- @@ -0,0 +1,532 @@ +// Licensed to the

[GitHub] cloudstack pull request: [4.7] vmware: improve support for disks

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1365 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Bump ssh retries to prevent false positiv...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1473 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Installing bzip2 since it is required for...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1490 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-216354858 After rebasing today, I re-ran SolidFire-related automated integration tests (about 3.5 hours of tests) and all were successful.

[GitHub] cloudstack pull request: CLOUDSTACK-9336 surround the execution of...

Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1463#issuecomment-216354228 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: Set default networkDomain to empty instea...

Github user imduffy15 commented on the pull request: https://github.com/apache/cloudstack/pull/1485#issuecomment-216353475 I'm not familiar with that block of code, remi's changes and justification seem fine though. Some very oddly/badly worded variable names. --- If your

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-216353485 @rafaelweingartner I squashed them, thanks for your comments and reviews! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61798443 --- Diff: server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java --- @@ -0,0 +1,532 @@ +// Licensed to the

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-216351223 Just an update, I forgot to ask, can you squash the commits? I think this one it is better to have all of the changes into a single commit. ---

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61795721 --- Diff: server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementServiceImpl.java --- @@ -0,0 +1,532 @@ +// Licensed to the

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61795629 --- Diff: server/src/org/apache/cloudstack/outofbandmanagement/OutOfBandManagementBackgroundTask.java --- @@ -0,0 +1,45 @@ +// Licensed to the

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-216347918 @nvazquez, that is great. As always your PRs are perfect, great job;) LGTM from me here. --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: Update L10N resource files with 4.7 strin...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1374#issuecomment-216347252 @milamberspace I think that is probably the best option. Then I will merge the new one (with these changes) first and forward merge and then merge #1515 and then if

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61793974 --- Diff: server/src/com/cloud/server/StatsCollector.java --- @@ -251,8 +262,9 @@ public boolean start() { } private void

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61792886 --- Diff: plugins/outofbandmanagement-drivers/ipmitool/test/org/apache/cloudstack/outofbandmanagement/driver/ipmitool/IpmitoolWrapperTest.java --- @@

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-216337441 Here are the results of my automated regression test: test_add_remove_host_with_solidfire_plugin (TestAddRemoveHosts.TestAddRemoveHosts) ... ===

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1518#discussion_r61790055 --- Diff: plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java --- @@ -117,4 +153,60 @@ public void

[GitHub] cloudstack pull request: KVM: Fix plugging ip addresses to the wro...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1524#issuecomment-216336787 this does not work for me as well. If there are multiple public interfaces in the VR, only the last one works. --- If your project is set up for it, you

[GitHub] cloudstack pull request: Update L10N resource files with 4.7 strin...

Github user milamberspace commented on the pull request: https://github.com/apache/cloudstack/pull/1374#issuecomment-216336456 @swill @DaanHoogland Yes, on my local machine, the branch are open against thr 4.7 branch. The PR in github is against the master, but will be against 4.7.

Re: Strange XenServer SR behavior when deploying system VMs in Basic Zone on 4.9

Just an FYI that I no longer see this problem (as was expected). Thanks! From: Tutkowski, Mike Sent: Monday, April 18, 2016 12:05 PM To: dev@cloudstack.apache.org Subject: Re: Strange XenServer SR behavior when deploying system

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61789411 --- Diff: plugins/outofbandmanagement-drivers/ipmitool/src/org/apache/cloudstack/outofbandmanagement/driver/ipmitool/IpmitoolWrapper.java --- @@ -0,0

[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/775#issuecomment-216333866 How should I test this? I think this is in a pretty good place pending some verification... --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

Github user nvazquez commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1518#discussion_r61788817 --- Diff: plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java --- @@ -117,4 +153,60 @@ public void

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

Github user rafaelweingartner commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1518#discussion_r61788211 --- Diff: plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java --- @@ -117,4 +153,60 @@ public void

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61787788 --- Diff: plugins/outofbandmanagement-drivers/ipmitool/src/org/apache/cloudstack/outofbandmanagement/driver/ipmitool/IpmitoolOutOfBandManagementDriver.java

[GitHub] cloudstack pull request: Update L10N resource files with 4.7 strin...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1374#issuecomment-216331189 @DaanHoogland I think this PR should probably be opened against the `4.7` branch though in order for your point to be valid. Right? --- If your project is set up

[GitHub] cloudstack pull request: Update L10N resource files with 4.7 strin...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1374#issuecomment-216328673 ok, the other way around, but you get what I am warning for. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Update L10N resource files with 4.7 strin...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1374#issuecomment-216327688 @DaanHoogland this is opened against `master` though while #1515 is opened against `4.8`, so the forward merge of #1515 will affect this one... --- If your project

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-216327328 Here is an integration test for this: [TestAddRemoveHosts.py.txt](https://github.com/apache/cloudstack/files/245702/TestAddRemoveHosts.py.txt) ---

[GitHub] cloudstack pull request: CLOUDSTACK-8901: PrepareTemplate job thre...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/880#issuecomment-216325329 We need another code review. How should I test this, does it have to be a manual test? --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: Update L10N resource files with 4.7 strin...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1374#issuecomment-216324676 @swill I think you want to forward merge before this one and then merge -s ours or such to prevent this from being merged forward. 4.8 has its own

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-216321608 @rafaelweingartner thanks. I understand completely... I know the `final` stuff is debatable, but I don't think that should block a PR. :) I think

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61781601 --- Diff: engine/schema/src/org/apache/cloudstack/outofbandmanagement/dao/OutOfBandManagementDaoImpl.java --- @@ -0,0 +1,163 @@ +// Licensed to

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61781371 --- Diff: engine/schema/src/org/apache/cloudstack/outofbandmanagement/dao/OutOfBandManagementDaoImpl.java --- @@ -0,0 +1,163 @@ +// Licensed to

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1321#issuecomment-216320768 gogogo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r61780914 --- Diff: engine/schema/src/org/apache/cloudstack/outofbandmanagement/dao/OutOfBandManagementDaoImpl.java --- @@ -0,0 +1,163 @@ +// Licensed to

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-216319655 Hi @swill no problem, you might be calling me on other PRs, and I might have not answered you. Sadly, duty is calling these days, few papers were

  1   2   3   4   >