[GitHub] cloudstack pull request: Strongswan vpn feature

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-218065380 @jayapalu I created systemvm templates from your PR and used them: https://packages.shapeblue.com/systemvmtemplate/custom/strongswanvpn I would like to see

[GitHub] cloudstack pull request: Strongswan vpn feature

Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-218063912 @rhtyd Previously tested the template generated from this branch remote access vpn and s2s vpn worked., you can find the templates from the comments. I

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-218059135 @jburwell as mentioned in comments above, due to a bug in ipmitool itself (https://bugzilla.redhat.com/show_bug.cgi?id=1286035) some executions may fail. I'll add

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r62612293 --- Diff: utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java --- @@ -0,0 +1,112 @@ +// +// Licensed to the Apache Software

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r62612221 --- Diff: utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java --- @@ -0,0 +1,112 @@ +// +// Licensed to the Apache Software

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r62612254 --- Diff: utils/src/main/java/org/apache/cloudstack/utils/process/ProcessResult.java --- @@ -0,0 +1,46 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r62612076 --- Diff: utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java --- @@ -0,0 +1,112 @@ +// +// Licensed to the Apache Software

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r62612035 --- Diff: utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java --- @@ -0,0 +1,112 @@ +// +// Licensed to the Apache Software

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-218057646 Thanks @SudharmaJain. I will get someone to look into this. @DaanHoogland do you or @pdion891 have access to this box to clean up the disk space so it is functional

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-218056377 @syed this is not compiling for me. Can you review? ``` [INFO] [INFO]

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/956#issuecomment-218056032 @swill I force pushed again and still it is failing. In logs I see following error. fatal: write error: No space left on device --- If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9350: KVM-HA- Fix CheckOnHost ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1496#issuecomment-218056068 Thanks for confirming @koushik-das. 👍 It is the middle of the night right now, so I am fading fast. --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218055176 Sorry, apparently I am not getting enough sleep now days. I looked at your code after you updated it to add the tags, which is why I was confused why the tests were

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1410#issuecomment-218054092 The CI is coming back clean for a general run. We still need code reviews... --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1410#issuecomment-218053964 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 0 Errors: 0 Duration: 8h 41m 18s ```

[GitHub] cloudstack pull request: Remove classes with no references

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1453#issuecomment-218053849 The one problem that is showing up in my CI does not appear to be related to this PR, but this is the first time I have ever seen this error. If someone else can

[GitHub] cloudstack pull request: Remove classes with no references

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1453#issuecomment-218052889 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 0 Errors: 1 Duration: 9h 04m 44s ``` **Summary of the

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1518#issuecomment-218052341 @koushik-das Will you be able to review this PR? It has been waiting for 2d LGTM for a while now. --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218051058 LGTM, ran the new tests. Test listing Volumes using 'ids' parameter ... === TestName: test_01_list_volumes | Status : SUCCESS === ok Test

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218048949 No problem ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218048625 @nvazquez My bad, didn't look at the changes. Thanks for the fixing the tests. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9350: KVM-HA- Fix CheckOnHost ...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1496#issuecomment-218048251 @swill The failures doesn't look related to this PR. This can be merged. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218047917 @koushik-das actually I've added tags, removed time.sleep and commented out test_04 --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218047244 @swill As I had mentioned in my last comment, newly added tests are not tagged. The command you used to run these tests has tags, don't pass any tags in order

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1466#issuecomment-218043423 Thanks @koushik-das, @swill now that there are 2 LGTM can we have this merged? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218033521 I am a bit confused why the attributes tag of `advanced` did not work in my test and zero tests ran. I will look at that quickly tomorrow to see if there is

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218031267 Sure @swill I pushed again. I also ran again tests in my environment: [root@ussarlabcsmgt41 cloudstack]# nosetests --with-marvin

[DISCUSS] replacement Jenkins for jenkins.buildacloud.org

while waiting to have hardware available on Apache infra, I'd like to setup a jenkins master on cloud.ca for now so we can phase out jenkins.buildacloud.org. I'm setting up a new jenkins server and shoud we take that oportunirty to change the URL? By something like builds.cloudstack.org ?

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218007214 @nvazquez: strange, this did not run any tests. Any ideas on that one? ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218006600 I am missing one code review for this one. @nvazquez can you re-push to kick off Travis again? Thx... --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218005270 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 0 Errors: 0 Duration: 4h 38m 35s ```

[GitHub] cloudstack pull request: CLOUDSTACK-8901: PrepareTemplate job thre...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/880#issuecomment-218004558 Thanks @koushik-das. I will run this through CI just to be sure everything is good... Thx. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-9365 : updateVirtualMachine wi...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1523#issuecomment-218004078 I will get this one into my CI queue. Thx... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1532#issuecomment-218003768 Thanks @DaanHoogland. 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Re: Test failure on master?

Rohit, can you look into this. It was first introduced in: https://github.com/apache/cloudstack/pull/1493 I thought the problem was fixed with this: https://github.com/apache/cloudstack/pull/1534 Apparently we still have a problem. This is intermittently emitting false negatives from what I

Test failure on master?

?Hi, I've seen this a couple times today. Is this a known issue? Results : Tests in error: NioTest.testConnection:152 » TestTimedOut test timed out after 6 milliseco... Tests run: 200, Failures: 0, Errors: 1, Skipped: 13 [INFO]

Re: Organizing CCCNA16 Hackathon

Pierre-Luc and WIll, While testing and CI are important topics, there may be additional topics of high importance to those attending the conference to discuss and work. Therefore, I think it is a good idea to collect everyone’s thoughts to ensure the priorities of all attendees are addressed.

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1423#issuecomment-217990022 Thanks @syed. I will get CI run against this. I see we have the required code review, so I just need to get CI run. Thx... --- If your project is set up for it,

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r62570929 --- Diff: utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java --- @@ -0,0 +1,112 @@ +// +// Licensed to the Apache

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r62570751 --- Diff: utils/src/main/java/org/apache/cloudstack/utils/process/ProcessResult.java --- @@ -0,0 +1,46 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r62570445 --- Diff: utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java --- @@ -0,0 +1,112 @@ +// +// Licensed to the Apache

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r62569864 --- Diff: utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java --- @@ -0,0 +1,112 @@ +// +// Licensed to the Apache

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r62569447 --- Diff: utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java --- @@ -0,0 +1,112 @@ +// +// Licensed to the Apache

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r62569193 --- Diff: utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java --- @@ -0,0 +1,112 @@ +// +// Licensed to the Apache

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1502#discussion_r62568855 --- Diff: utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java --- @@ -0,0 +1,112 @@ +// +// Licensed to the Apache

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1423#issuecomment-217972968 @swill Sqashed. I believe this is good to go. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: [CLOUDSTACK-8973] Fix create template fro...

Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1424#issuecomment-217972386 @rhtyd Squashed. It is pending a LGTM. If you can have a quick look at this one, it would be awesome! --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-217971133 @rafaelweingartner @jburwell Sorry for the late reply to this. I was on vacation and returned today. I've decided to use John's approach for the logging test as I

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r62547345 --- Diff: plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/SolidFireHostListener.java --- @@ -91,18 +280,5

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-217947984 @syed Thanks for the code review! @swill I believe we are good to go on this PR. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r62548252 --- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java --- @@ -1570,17 +1578,35 @@ private boolean checkCIDR(final HostPodVO pod, final

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r62547209 --- Diff: plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/SolidFireHostListener.java --- @@ -65,22 +94,182

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r62547042 --- Diff: plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/SolidFireHostListener.java --- @@ -18,40 +18,69

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r62546959 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -933,7 +937,7 @@ private PlugNicAnswer

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-217944726 @rhtyd it looks like one of the OOBM smoke tests failed on the Travis build. Could you please investigate? --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r62546214 --- Diff: engine/components-api/src/com/cloud/agent/Listener.java --- @@ -87,6 +93,18 @@ boolean processDisconnect(long agentId, Status

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r62546243 --- Diff: engine/components-api/src/com/cloud/agent/Listener.java --- @@ -87,6 +93,18 @@ boolean processDisconnect(long agentId, Status

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r62545797 --- Diff: engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/HypervisorHostListener.java --- @@ -21,7 +21,13 @@ import

Re: hidden configuration items revisited

listConfiguration returns unencrypted values for Secure items, but they need to be stored encrypted in the db. You'd need to check If those values ever change, If they don't you may try encrypting the value and change category to Secure Erik Den mandag 9. mai 2016 skrev Nathan Johnson

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-217892225 This has the required code reviews. @mike-tutkowski have a look at the comments @syed made. I will get this into my CI queue so we can get it moving forward.

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user syed commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-217890036 @mike-tutkowski I've reviewed the code and it LGTM. I have a few minor comments that should be fairly simple to adress. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: Removed Unused Void Class

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1440#issuecomment-217889598 CI has come back clean. 👍 I will add this to my merge queue. Thx... --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r62513240 --- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java --- @@ -1570,17 +1578,35 @@ private boolean checkCIDR(final HostPodVO pod, final String

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1428#issuecomment-217887345 I think this one is ready. The failures are things that periodically fail in my environment and are unrelated to this code. Thanks... --- If your project is set

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r62511172 --- Diff: plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/SolidFireHostListener.java --- @@ -91,18 +280,5 @@ public

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r62509977 --- Diff: plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/SolidFireHostListener.java --- @@ -65,22 +94,182 @@ public

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r62509667 --- Diff: plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/SolidFireHostListener.java --- @@ -18,40 +18,69 @@ */

[GitHub] cloudstack pull request: CLOUDSTACK-9350: KVM-HA- Fix CheckOnHost ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1496#issuecomment-217884184 The two failures are not ones I am used to seeing in my environment, but I did a quick once through of the code and I don't think they problem is related to this PR.

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r62508121 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -933,7 +937,7 @@ private PlugNicAnswer

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-217880689 Hi @koushik-das thanks for reviewing! Actually it took so long due to setUpClass method, after that, test are really simple and quick. I included 12 minutes sleep

Re: hidden configuration items revisited

Erik Weber wrote: > I believe Kishan suggested that you could change those Hidden config items > to Secure (an existing category), as Secure items are returned with the > listConfiguration API. This is chicken and egg. I need the unencrypted values so I can decrypt other

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r62505386 --- Diff: engine/components-api/src/com/cloud/agent/Listener.java --- @@ -87,6 +93,18 @@ boolean processDisconnect(long agentId, Status state);

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r62505426 --- Diff: engine/components-api/src/com/cloud/agent/Listener.java --- @@ -87,6 +93,18 @@ boolean processDisconnect(long agentId, Status state);

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/816#discussion_r62505096 --- Diff: engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/HypervisorHostListener.java --- @@ -21,7 +21,13 @@ import

[GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...

Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1246#issuecomment-217875751 @SudharmaJain, I've added a few comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1246#discussion_r62503852 --- Diff: server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java --- @@ -1588,6 +1588,16 @@ protected StringBuilder

[GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1246#discussion_r62503776 --- Diff: server/src/com/cloud/network/guru/GuestNetworkGuru.java --- @@ -396,6 +396,16 @@ public NicProfile allocate(final Network network, NicProfile

[GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...

Github user nlivens commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1246#discussion_r62503830 --- Diff: server/src/com/cloud/network/router/NetworkHelperImpl.java --- @@ -755,6 +755,16 @@ protected HypervisorType

[GitHub] cloudstack pull request: agent: Enable IPv6 connectivity for KVM A...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1488#issuecomment-217873032 We have the required code review and tests, I will add this to my merge queue. Thx... --- If your project is set up for it, you can reply to this email and have

Re: hidden configuration items revisited

I believe Kishan suggested that you could change those Hidden config items to Secure (an existing category), as Secure items are returned with the listConfiguration API. I don't know if you can do an in-place switch, or if the value has to be encrypted first for it to work, but you should be able

Re: hidden configuration items

Anshul Gangwar wrote: > > ms ——authenticate—> CPVM ——for VNC console—>Hypervisor > ^ > | gets images from CPVM > web browser > > Which of the above components

Re: hidden configuration items revisited

Kishan Kavala wrote: > Nathan, > You can use "Secure" category instead of "Hidden". Config items with > "Secure" category are encrypted and also included in listConfigurations API > response. The data that I need (specifically security.encryption.iv and

[GitHub] cloudstack pull request: Honour GS use_ext_dns and redundant VR VI...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1536#issuecomment-217867940 @ustcweizhou, I suppose it still LGTM to you as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: Honour GS use_ext_dns and redundant VR VI...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1536#issuecomment-217867849 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1532#issuecomment-217866994 LGTM based on code, CI pending --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: Number of NICs in VMWare - CS 4.6 bug?

I’m afraid not - I found the 25155 ticket reference in some release notes but that’s as far as it goes really… On 09/05/2016 12:11, "Abhinandan Prateek" > wrote: It seems there is a limit of 8 NICS that Hyper-V will

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/pull/1371#issuecomment-217859785 @abhinandanprateek please check the Jenkins issues and trigger a rebuild to get this PR green. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-9365 : updateVirtualMachine wi...

Github user nlivens commented on the pull request: https://github.com/apache/cloudstack/pull/1523#issuecomment-217858039 @DaanHoogland, the file has been renamed to make use of the python naming standards --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user NuxRo commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-217857669 Same here. Is this XenServer specific, can anyone with an XS test bed help? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: Marvin: Replace a timer.sleep(30) with pu...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1529#issuecomment-217856530 All tests are done and I have the code reviews I need. Adding to merge queue. Thx... --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-217856052 @ don't thank me, I just started to check but my infra is based on KVM and it doesn't support scalevm, so I cannot investigate further --- If your project is

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1489#issuecomment-217855833 We have the required code reviews and CI results. I will add this to merge queue. Thx... --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user NuxRo commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-217853178 Thanks Daan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-9199: Fixed deployVirtualMachi...

Github user alexandrelimassantana commented on the pull request: https://github.com/apache/cloudstack/pull/1280#issuecomment-217842674 as @pedro-martins stated, it seems to be fitting that this method is extracted to a class to be documented/tested. The code looks good but if the

[GitHub] cloudstack pull request: CLOUDSTACK-8958: release dedicated ip ran...

Github user alexandrelimassantana commented on the pull request: https://github.com/apache/cloudstack/pull/1357#issuecomment-217840055 Is there a test already to check if the ip ranges release method is called? If there is none, I think it should be added --- If your project is set

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-217839619 @nuxro I have rebased but did not get to testing. I don't trust the scalevm problem. It might be in the test, in the test environment or in the actual code.

[GitHub] cloudstack pull request: CLOUDSTACK-9365 : updateVirtualMachine wi...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1523#issuecomment-217839187 @nlivens thanks for the extra test effort you put into this. Can you rename the marvin test to adhere to python naming standards (i.e. no camal case

RE: Migrating CloudStack content from download.cloud.com

Hi, Short Term - all the content has moved to cloudstack.apt-get.eu Which sections to be modified? The Install Guide needs to be modified. Sample links/details are mentioned below for 4.6 and same needs to be updated for other Released versions of Cloudstack documentation:

[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1532#discussion_r62482644 --- Diff: framework/db/src/com/cloud/utils/db/GenericDaoBase.java --- @@ -942,12 +942,18 @@ public T findOneBy(final SearchCriteria sc) {

Re: Number of NICs in VMWare - CS 4.6 bug?

It seems there is a limit of 8 NICS that Hyper-V will support for user VMS: https://technet.microsoft.com/en-us/library/jj680093.aspx It seems CS-25155 is some internal jira ticket, do you know if the summary/extract can be shared ? On 06/05/16, 8:15 PM, "Octavian Popescu"

  1   2   >