[GitHub] cloudstack pull request: Strongswan vpn feature

[rhtyd]

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/872#issuecomment-218065380
  
@jayapalu I created systemvm templates from your PR and used them: 
https://packages.shapeblue.com/systemvmtemplate/custom/strongswanvpn

I would like to see two changes: use strongswan from wheezy-backports i.e. 
version 5.x and that clients behind NAT can also connect to the VPN, with at 
least default clients working out of the box on OSX and Windows. Linux and 
Android would be great too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Strongswan vpn feature

[jayapalu]

Github user jayapalu commented on the pull request:

https://github.com/apache/cloudstack/pull/872#issuecomment-218063912
  
@rhtyd 
Previously tested the template generated from this branch remote access vpn 
and s2s vpn worked., you can find the templates from the comments. 
I will find some time and post the results.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

[rhtyd]

Github user rhtyd commented on the pull request:

https://github.com/apache/cloudstack/pull/1502#issuecomment-218059135
  
@jburwell as mentioned in comments above, due to a bug in ipmitool itself 
(https://bugzilla.redhat.com/show_bug.cgi?id=1286035) some executions may fail. 
I'll add code to skip/workaround that known bug for the specific failing test, 
I had already added some code to skip test when the specific ipmitool bug was 
hit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1502#discussion_r62612293
  
--- Diff: 
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
@@ -0,0 +1,112 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package org.apache.cloudstack.utils.process;
+
+import com.cloud.utils.concurrency.NamedThreadFactory;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Strings;
+import org.apache.log4j.Logger;
+import org.joda.time.Duration;
+
+import java.io.BufferedReader;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.util.List;
+import java.util.concurrent.Callable;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+
+public class ProcessRunner {
+public static final Logger LOG = Logger.getLogger(ProcessRunner.class);
+
+private static final ExecutorService processExecutor = 
Executors.newCachedThreadPool(new NamedThreadFactory("ProcessRunner"));
+
+private static String readStream(final InputStream inputStream) {
+String text = null;
+try {
+final BufferedReader bufferedReader = new BufferedReader(new 
InputStreamReader(inputStream));
+String line;
+while ((line = bufferedReader.readLine()) != null) {
+if (Strings.isNullOrEmpty(text)) {
+text = line;
+} else {
+text = text + "\n" + line;
+}
+}
+} catch (IOException e) {
+if (LOG.isTraceEnabled()) {
+LOG.trace("ProcessRunner::readStream failed due to: " + 
e.getMessage());
+}
+}
+return text;
+}
+
+public static ProcessResult executeCommands(final List 
commands, final Duration timeOut) {
+Preconditions.checkArgument(commands != null && timeOut != null);
+
+int retVal = -2;
+String stdOutput = null;
+String stdError = null;
+
+try {
+final Process process = new 
ProcessBuilder().command(commands).start();
+if (timeOut.getStandardSeconds() > 0) {
+final Future processFuture = 
processExecutor.submit(new Callable() {
+@Override
+public Integer call() throws Exception {
+return process.waitFor();
+}
+});
+try {
+retVal = 
processFuture.get(timeOut.getStandardSeconds(), TimeUnit.SECONDS);
+} catch (ExecutionException | TimeoutException e) {
+retVal = -1;
+stdError = "Operation timed out, aborted";
+if (LOG.isTraceEnabled()) {
+LOG.trace("Failed to complete the requested 
command within timeout: " + e.getMessage());
+}
+} finally {
+if (Strings.isNullOrEmpty(stdError)) {
+stdOutput = readStream(process.getInputStream());
+stdError = readStream(process.getErrorStream());
+}
+}
+} else {
+retVal = process.waitFor();
+stdOutput = readStream(process.getInputStream());
+stdError = readStream(process.getErrorStream());
+}
+process.destroy();
--- End diff --

process.destroy() is common to both cases when timeout is 0 or non-zero; 
cleanup is ensured in either 

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1502#discussion_r62612221
  
--- Diff: 
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
@@ -0,0 +1,112 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package org.apache.cloudstack.utils.process;
+
+import com.cloud.utils.concurrency.NamedThreadFactory;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Strings;
+import org.apache.log4j.Logger;
+import org.joda.time.Duration;
+
+import java.io.BufferedReader;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.util.List;
+import java.util.concurrent.Callable;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+
+public class ProcessRunner {
+public static final Logger LOG = Logger.getLogger(ProcessRunner.class);
+
+private static final ExecutorService processExecutor = 
Executors.newCachedThreadPool(new NamedThreadFactory("ProcessRunner"));
--- End diff --

This is a general utility, so it won't be possible to configure the 
executor service pool size here without passing a global setting variable on 
initialization. The cached pool ensures to reuse threads and still a better way 
than spawning separate threads on each run. Wrt oobm, for each issue command 
only one thread is spawned that execs an ipmitool process, a maximum of 250 (or 
size specified in db.properties which forces the size of max. no of concurrent 
async jobs) ipmitool processes can be spawned at any given time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1502#discussion_r62612254
  
--- Diff: 
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessResult.java ---
@@ -0,0 +1,46 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.utils.process;
+
+public class ProcessResult {
--- End diff --

Will fix that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1502#discussion_r62612076
  
--- Diff: 
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
@@ -0,0 +1,112 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package org.apache.cloudstack.utils.process;
+
+import com.cloud.utils.concurrency.NamedThreadFactory;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Strings;
+import org.apache.log4j.Logger;
+import org.joda.time.Duration;
+
+import java.io.BufferedReader;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.util.List;
+import java.util.concurrent.Callable;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+
+public class ProcessRunner {
+public static final Logger LOG = Logger.getLogger(ProcessRunner.class);
+
+private static final ExecutorService processExecutor = 
Executors.newCachedThreadPool(new NamedThreadFactory("ProcessRunner"));
+
+private static String readStream(final InputStream inputStream) {
+String text = null;
+try {
+final BufferedReader bufferedReader = new BufferedReader(new 
InputStreamReader(inputStream));
+String line;
+while ((line = bufferedReader.readLine()) != null) {
+if (Strings.isNullOrEmpty(text)) {
+text = line;
+} else {
+text = text + "\n" + line;
+}
+}
+} catch (IOException e) {
+if (LOG.isTraceEnabled()) {
+LOG.trace("ProcessRunner::readStream failed due to: " + 
e.getMessage());
+}
+}
+return text;
+}
+
+public static ProcessResult executeCommands(final List 
commands, final Duration timeOut) {
+Preconditions.checkArgument(commands != null && timeOut != null);
+
+int retVal = -2;
+String stdOutput = null;
+String stdError = null;
+
+try {
+final Process process = new 
ProcessBuilder().command(commands).start();
+if (timeOut.getStandardSeconds() > 0) {
+final Future processFuture = 
processExecutor.submit(new Callable() {
+@Override
+public Integer call() throws Exception {
+return process.waitFor();
+}
+});
+try {
+retVal = 
processFuture.get(timeOut.getStandardSeconds(), TimeUnit.SECONDS);
+} catch (ExecutionException | TimeoutException e) {
--- End diff --

Will split the catch cases separately.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

[rhtyd]

Github user rhtyd commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1502#discussion_r62612035
  
--- Diff: 
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
@@ -0,0 +1,112 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package org.apache.cloudstack.utils.process;
+
+import com.cloud.utils.concurrency.NamedThreadFactory;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Strings;
+import org.apache.log4j.Logger;
+import org.joda.time.Duration;
+
+import java.io.BufferedReader;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.util.List;
+import java.util.concurrent.Callable;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+
+public class ProcessRunner {
+public static final Logger LOG = Logger.getLogger(ProcessRunner.class);
+
+private static final ExecutorService processExecutor = 
Executors.newCachedThreadPool(new NamedThreadFactory("ProcessRunner"));
+
+private static String readStream(final InputStream inputStream) {
+String text = null;
+try {
+final BufferedReader bufferedReader = new BufferedReader(new 
InputStreamReader(inputStream));
+String line;
+while ((line = bufferedReader.readLine()) != null) {
+if (Strings.isNullOrEmpty(text)) {
+text = line;
+} else {
+text = text + "\n" + line;
+}
+}
+} catch (IOException e) {
+if (LOG.isTraceEnabled()) {
+LOG.trace("ProcessRunner::readStream failed due to: " + 
e.getMessage());
+}
+}
+return text;
+}
+
+public static ProcessResult executeCommands(final List 
commands, final Duration timeOut) {
+Preconditions.checkArgument(commands != null && timeOut != null);
+
+int retVal = -2;
+String stdOutput = null;
+String stdError = null;
+
+try {
+final Process process = new 
ProcessBuilder().command(commands).start();
+if (timeOut.getStandardSeconds() > 0) {
--- End diff --

Yes, in case of initialization where we are checking the version etc a 
timeout may not be specified (0 = wait until process returns/exits). Also, this 
is a general utility not specifically tied to oobm.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/956#issuecomment-218057646
  
Thanks @SudharmaJain.  I will get someone to look into this.  @DaanHoogland 
do you or @pdion891 have access to this box to clean up the disk space so it is 
functional again?  I am not sure who had access to these boxes...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1331#issuecomment-218056377
  
@syed this is not compiling for me.  Can you review?

```
[INFO] 

[INFO] Building Apache CloudStack Plugin - RabbitMQ Event Bus 4.7.2-SNAPSHOT
[INFO] 

[WARNING] *
[WARNING] * Your build is requesting parallel execution, but project  *
[WARNING] * contains the following plugin(s) that are not marked as   *
[WARNING] * @threadSafe to support parallel building. *
[WARNING] * While this /may/ work fine, please look for plugin updates*
[WARNING] * and/or request plugins be made thread-safe.   *
[WARNING] * If reporting an issue, report it against the plugin in*
[WARNING] * question, not against maven-core  *
[WARNING] *
[WARNING] The following plugins are not marked @threadSafe in Apache 
CloudStack Plugin - RabbitMQ Event Bus:
[WARNING] org.apache.maven.plugins:maven-site-plugin:3.1
[WARNING] *
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) @ 
cloud-mom-rabbitmq ---
[INFO] Starting audit...
Audit done.

[INFO] 
[INFO] --- maven-remote-resources-plugin:1.3:process (default) @ 
cloud-mom-rabbitmq ---
log4j:ERROR Could not parse url 
[file:/data/git/cs1/cloudstack/services/secondary-storage/server/test/../conf/log4j.xml].
java.io.FileNotFoundException: 
/data/git/cs1/cloudstack/services/secondary-storage/server/test/../conf/log4j.xml
 (No such file or directory)
at java.io.FileInputStream.open(Native Method)
at java.io.FileInputStream.(FileInputStream.java:146)
at java.io.FileInputStream.(FileInputStream.java:101)
at 
sun.net.www.protocol.file.FileURLConnection.connect(FileURLConnection.java:90)
at 
sun.net.www.protocol.file.FileURLConnection.getInputStream(FileURLConnection.java:188)
at 
org.apache.log4j.xml.DOMConfigurator$2.parse(DOMConfigurator.java:765)
at 
org.apache.log4j.xml.DOMConfigurator.doConfigure(DOMConfigurator.java:871)
at 
org.apache.log4j.xml.DOMConfigurator.doConfigure(DOMConfigurator.java:778)
at 
org.apache.log4j.helpers.OptionConverter.selectAndConfigure(OptionConverter.java:526)
at org.apache.log4j.LogManager.(LogManager.java:127)
at org.apache.log4j.Logger.getLogger(Logger.java:117)
at 
com.cloud.resource.ServerResourceBase.(ServerResourceBase.java:45)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:195)
at javassist.runtime.Desc.getClassObject(Desc.java:43)
at javassist.runtime.Desc.getClassType(Desc.java:152)
at javassist.runtime.Desc.getType(Desc.java:122)
at javassist.runtime.Desc.getType(Desc.java:78)
at 
org.apache.cloudstack.storage.resource.NfsSecondaryStorageResourceTest.setUp(NfsSecondaryStorageResourceTest.java:49)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:606)
at 
org.junit.internal.runners.MethodRoadie.runBefores(MethodRoadie.java:132)
at 
org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:95)
at 
org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.executeTest(PowerMockJUnit44RunnerDelegateImpl.java:294)
at 
org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.executeTestInSuper(PowerMockJUnit47RunnerDelegateImpl.java:127)
at 
org.powermock.modules.junit4.internal.impl.PowerMockJUnit47RunnerDelegateImpl$PowerMockJUnit47MethodRunner.executeTest(PowerMockJUnit47RunnerDelegateImpl.java:82)
at 
org.powermock.modules.junit4.internal.impl.PowerMockJUnit44RunnerDelegateImpl$PowerMockJUnit44MethodRunner.runBeforesThenTestThenAfters(PowerMockJUnit44RunnerDelegateImpl.java:282)
at 
org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:86)
at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:49)
at 

[GitHub] cloudstack pull request: CLOUDSTACK-8970 Centos 6.{1,2,3,4,5} gues...

[SudharmaJain]

Github user SudharmaJain commented on the pull request:

https://github.com/apache/cloudstack/pull/956#issuecomment-218056032
  
@swill I force pushed again and still it is failing. In logs I see 
following error.

fatal: write error: No space left on device


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9350: KVM-HA- Fix CheckOnHost ...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1496#issuecomment-218056068
  
Thanks for confirming @koushik-das.  👍  It is the middle of the night 
right now, so I am fading fast.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-218055176
  
Sorry, apparently I am not getting enough sleep now days.  I looked at your 
code after you updated it to add the tags, which is why I was confused why the 
tests were not run in my case.  I thought I had checked that they had tags when 
I added them to my tests, but I blame on that on being tired too.  :)

This one is ready to merge.  Thanks guys...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1410#issuecomment-218054092
  
The CI is coming back clean for a general run.  We still need code 
reviews...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-6928: fix issue disk I/O throt...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1410#issuecomment-218053964
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 0
   Errors: 0
 Duration: 8h 41m 18s
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_09_2016_06_51_48_5423HJ:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1410/tmp/MarvinLogs/DeployDataCenter__May_09_2016_06_51_48_5423HJ/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1410/tmp/MarvinLogs/DeployDataCenter__May_09_2016_06_51_48_5423HJ/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1410/tmp/MarvinLogs/DeployDataCenter__May_09_2016_06_51_48_5423HJ/runinfo.txt)

**`/tmp/MarvinLogs/test_network_G4PI03:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1410/tmp/MarvinLogs/test_network_G4PI03/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1410/tmp/MarvinLogs/test_network_G4PI03/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1410/tmp/MarvinLogs/test_network_G4PI03/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_IL209Q:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1410/tmp/MarvinLogs/test_vpc_routers_IL209Q/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1410/tmp/MarvinLogs/test_vpc_routers_IL209Q/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1410/tmp/MarvinLogs/test_vpc_routers_IL209Q/runinfo.txt)


Uploads will be available until `2016-07-10 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remove classes with no references

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1453#issuecomment-218053849
  
The one problem that is showing up in my CI does not appear to be related 
to this PR, but this is the first time I have ever seen this error.  If someone 
else can confirm that this would not be related, I would appreciate it.  :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Remove classes with no references

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1453#issuecomment-218052889
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 0
   Errors: 1
 Duration: 9h 04m 44s
```

**Summary of the problem(s):**
```
ERROR: Test VPC offering without port forwarding service
--
Traceback (most recent call last):
  File 
"/data/git/cs1/cloudstack/test/integration/component/test_vpc_offerings.py", 
line 799, in test_05_vpc_off_without_pf
domainid=self.account.domainid
  File "/usr/lib/python2.7/site-packages/marvin/lib/base.py", line 4217, in 
create
return VPC(apiclient.createVPC(cmd).__dict__)
  File 
"/usr/lib/python2.7/site-packages/marvin/cloudstackAPI/cloudstackAPIClient.py", 
line 2182, in createVPC
response = self.connection.marvinRequest(command, 
response_type=response, method=method)
  File "/usr/lib/python2.7/site-packages/marvin/cloudstackConnection.py", 
line 379, in marvinRequest
raise e
Exception: Job failed: {jobprocstatus : 0, created : 
u'2016-05-09T15:20:37+0200', jobresult : {errorcode : 530, errortext : u'Failed 
to create VPC'}, cmd : 
u'org.apache.cloudstack.api.command.admin.vpc.CreateVPCCmdByAdmin', userid : 
u'7762822f-15a0-11e6-91f9-5254001daa61', jobstatus : 2, jobid : 
u'b5b0ebc2-11b3-451f-ab08-5b45ce58d61e', jobresultcode : 530, jobresulttype : 
u'object', jobinstancetype : u'None', accountid : 
u'77626b72-15a0-11e6-91f9-5254001daa61'}
--
Additional details in: /tmp/MarvinLogs/test_vpc_routers_I1C28S/results.txt
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_09_2016_06_45_25_CAQM5J:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1453/tmp/MarvinLogs/DeployDataCenter__May_09_2016_06_45_25_CAQM5J/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1453/tmp/MarvinLogs/DeployDataCenter__May_09_2016_06_45_25_CAQM5J/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1453/tmp/MarvinLogs/DeployDataCenter__May_09_2016_06_45_25_CAQM5J/runinfo.txt)

**`/tmp/MarvinLogs/test_network_MTB4IB:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1453/tmp/MarvinLogs/test_network_MTB4IB/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1453/tmp/MarvinLogs/test_network_MTB4IB/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1453/tmp/MarvinLogs/test_network_MTB4IB/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_I1C28S:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1453/tmp/MarvinLogs/test_vpc_routers_I1C28S/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1453/tmp/MarvinLogs/test_vpc_routers_I1C28S/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1453/tmp/MarvinLogs/test_vpc_routers_I1C28S/runinfo.txt)


Uploads will be available until `2016-07-10 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9368: Fix for Support configur...

[serg38]

Github user serg38 commented on the pull request:

https://github.com/apache/cloudstack/pull/1518#issuecomment-218052341
  
@koushik-das  Will you be able to review this PR? It has been waiting for 
2d LGTM for a while now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-218051058
  
LGTM, ran the new tests.

Test listing Volumes using 'ids' parameter ... === TestName: 
test_01_list_volumes | Status : SUCCESS ===
ok
Test listing Templates using 'ids' parameter ... === TestName: 
test_02_list_templates | Status : SUCCESS ===
ok
Test listing Snapshots using 'ids' parameter ... === TestName: 
test_03_list_snapshots | Status : SUCCESS ===
ok

--
Ran 3 tests in 148.845s

OK


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[nvazquez]

Github user nvazquez commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-218048949
  
No problem ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-218048625
  
@nvazquez My bad, didn't look at the changes. Thanks for the fixing the 
tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9350: KVM-HA- Fix CheckOnHost ...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1496#issuecomment-218048251
  
@swill The failures doesn't look related to this PR. This can be merged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[nvazquez]

Github user nvazquez commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-218047917
  
@koushik-das actually I've added tags, removed time.sleep and commented out 
test_04


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[koushik-das]

Github user koushik-das commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-218047244
  
@swill As I had mentioned in my last comment, newly added tests are not 
tagged. The command you used to run these tests has tags, don't pass any tags 
in order to run them.
@nvazquez Please tag the tests appropriately, something like 
@attr(tags = ["devcloud", "advanced", "advancedns", "smoke", "basic", 
"sg"], required_hardware="false")


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9340: General DB Optimization

[nvazquez]

Github user nvazquez commented on the pull request:

https://github.com/apache/cloudstack/pull/1466#issuecomment-218043423
  
Thanks @koushik-das, @swill now that there are 2 LGTM can we have this 
merged?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-218033521
  
I am a bit confused why the attributes tag of `advanced` did not work in my 
test and zero tests ran. I will look at that quickly tomorrow to see if there 
is something different about these tests from the others I am running this way. 
I think this one is in pretty good shape now. Will verify everything when I am 
back at a computer. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[nvazquez]

Github user nvazquez commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-218031267
  
Sure @swill I pushed again. I also ran again tests in my environment:


[root@ussarlabcsmgt41 cloudstack]# nosetests --with-marvin 
--marvin-config=setup/dev/advanced.cfg 
test/integration/smoke/test_list_ids_parameter.py

 Marvin Init Started 

=== Marvin Parse Config Successful ===

=== Marvin Setting TestData Successful===

 Log Folder Path: /tmp//MarvinLogs//May_09_2016_17_39_25_ETC1VH. All 
logs will be available here 

=== Marvin Init Logging Successful===

 Marvin Init Successful 
===final results are now copied to: 
/tmp//MarvinLogs/test_list_ids_parameter_A7VS1H===
[root@ussarlabcsmgt41 cloudstack]# cat 
/tmp//MarvinLogs/test_list_ids_parameter_A7VS1H/results.txt
Test listing Volumes using 'ids' parameter ... === TestName: 
test_01_list_volumes | Status : SUCCESS ===
ok
Test listing Templates using 'ids' parameter ... === TestName: 
test_02_list_templates | Status : SUCCESS ===
ok
Test listing Snapshots using 'ids' parameter ... === TestName: 
test_03_list_snapshots | Status : SUCCESS ===
ok

--
Ran 3 tests in 446.512s

OK



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[DISCUSS] replacement Jenkins for jenkins.buildacloud.org

[Pierre-Luc Dion]

while waiting to have hardware available on Apache infra,

I'd like to setup a jenkins master on cloud.ca for now so we can phase out
jenkins.buildacloud.org.

I'm setting up a new jenkins server and shoud we take that oportunirty to
change the URL?
By something like builds.cloudstack.org ?  cloudstack.org is own by
apache,org.

I'm planning to put all the documentation about that new jenkins system on
our wiki[1]


[1]
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=62695640


Thanks,

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-218007214
  
@nvazquez: strange, this did not run any tests.  Any ideas on that one?

```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced 
smoke/test_list_ids_parameter.py
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-218006600
  
I am missing one code review for this one.  @nvazquez can you re-push to 
kick off Travis again?  Thx...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-218005270
  


### CI RESULTS

```
Tests Run: 85
  Skipped: 0
   Failed: 0
   Errors: 0
 Duration: 4h 38m 35s
```



**Associated Uploads**

**`/tmp/MarvinLogs/DeployDataCenter__May_09_2016_07_17_28_RFHUY6:`**
* 
[dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1497/tmp/MarvinLogs/DeployDataCenter__May_09_2016_07_17_28_RFHUY6/dc_entries.obj)
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1497/tmp/MarvinLogs/DeployDataCenter__May_09_2016_07_17_28_RFHUY6/failed_plus_exceptions.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1497/tmp/MarvinLogs/DeployDataCenter__May_09_2016_07_17_28_RFHUY6/runinfo.txt)

**`/tmp/MarvinLogs/test_network_DL9JLX:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1497/tmp/MarvinLogs/test_network_DL9JLX/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1497/tmp/MarvinLogs/test_network_DL9JLX/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1497/tmp/MarvinLogs/test_network_DL9JLX/runinfo.txt)

**`/tmp/MarvinLogs/test_suite_9BKAZW:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1497/tmp/MarvinLogs/test_suite_9BKAZW/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1497/tmp/MarvinLogs/test_suite_9BKAZW/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1497/tmp/MarvinLogs/test_suite_9BKAZW/runinfo.txt)

**`/tmp/MarvinLogs/test_vpc_routers_MX5M6P:`**
* 
[failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1497/tmp/MarvinLogs/test_vpc_routers_MX5M6P/failed_plus_exceptions.txt)
* 
[results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1497/tmp/MarvinLogs/test_vpc_routers_MX5M6P/results.txt)
* 
[runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1497/tmp/MarvinLogs/test_vpc_routers_MX5M6P/runinfo.txt)


Uploads will be available until `2016-07-09 02:00:00 +0200 CEST`

*Comment created by [`upr comment`](https://github.com/cloudops/upr).*



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8901: PrepareTemplate job thre...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/880#issuecomment-218004558
  
Thanks @koushik-das.  I will run this through CI just to be sure everything 
is good...  Thx.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9365 : updateVirtualMachine wi...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1523#issuecomment-218004078
  
I will get this one into my CI queue.  Thx...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1532#issuecomment-218003768
  
Thanks @DaanHoogland.  👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Test failure on master?

[Will Stevens]

Rohit, can you look into this.

It was first introduced in: https://github.com/apache/cloudstack/pull/1493

I thought the problem was fixed with this:
https://github.com/apache/cloudstack/pull/1534

Apparently we still have a problem.  This is intermittently emitting false
negatives from what I can tell...

*Will STEVENS*
Lead Developer

*CloudOps* *| *Cloud Solutions Experts
420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
w cloudops.com *|* tw @CloudOps_

On Mon, May 9, 2016 at 5:34 PM, Tutkowski, Mike 
wrote:

> ?Hi,
>
>
> I've seen this a couple times today.
>
>
> Is this a known issue?
>
>
> Results :
>
>
> Tests in error:
>
>   NioTest.testConnection:152 » TestTimedOut test timed out after 6
> milliseco...
>
>
> Tests run: 200, Failures: 0, Errors: 1, Skipped: 13
>
>
> [INFO]
> 
>
> [INFO] Reactor Summary:
>
> [INFO]
>
> [INFO] Apache CloudStack Developer Tools - Checkstyle Configuration
> SUCCESS [  1.259 s]
>
> [INFO] Apache CloudStack .. SUCCESS [
> 1.858 s]
>
> [INFO] Apache CloudStack Maven Conventions Parent . SUCCESS [
> 1.528 s]
>
> [INFO] Apache CloudStack Framework - Managed Context .. SUCCESS [
> 4.882 s]
>
> [INFO] Apache CloudStack Utils  FAILURE [01:20
> min]??
>
>
> Thanks,
>
> Mike
>
>

Test failure on master?

[Tutkowski, Mike]

?Hi,


I've seen this a couple times today.


Is this a known issue?


Results :


Tests in error:

  NioTest.testConnection:152 » TestTimedOut test timed out after 6 
milliseco...


Tests run: 200, Failures: 0, Errors: 1, Skipped: 13


[INFO] 

[INFO] Reactor Summary:

[INFO]

[INFO] Apache CloudStack Developer Tools - Checkstyle Configuration SUCCESS [  
1.259 s]

[INFO] Apache CloudStack .. SUCCESS [  1.858 s]

[INFO] Apache CloudStack Maven Conventions Parent . SUCCESS [  1.528 s]

[INFO] Apache CloudStack Framework - Managed Context .. SUCCESS [  4.882 s]

[INFO] Apache CloudStack Utils  FAILURE [01:20 
min]??


Thanks,

Mike

Re: Organizing CCCNA16 Hackathon

[John Burwell]

Pierre-Luc and WIll,

While testing and CI are important topics, there may be additional topics of 
high importance to those attending the conference to discuss and work.  
Therefore, I think it is a good idea to collect everyone’s thoughts to ensure 
the priorities of all attendees are addressed.  Additionally, my hope is that 
some advance organization and coordination will allow people to participate 
virtually.

Thanks,
-John

> 
Regards,

John Burwell

john.burw...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
@shapeblue
On May 5, 2016, at 1:32 PM, Pierre-Luc Dion  wrote:
> 
> Thanks John  for that initiative.
> 
> Good idea to start organizing teams and topics since we won't have much
> time on site. As Will said the main theme would be around CI, and we are
> working to get enought hardware and ressource so all teams could have their
> own setup...
> 
> Cheers,
> 
> PL
> 
> On Thu, May 5, 2016 at 12:02 PM, Will Stevens 
> wrote:
> 
>> Hey John,
>> Thanks for the initiative.  We will be focusing the hackathon mainly
>> around testing.  I will be setting up full environments for the teams to
>> work with and those details will be made available on the day of the
>> hackathon.
>> 
>> I think it is a good idea to have a general theme for the hackathon to
>> help focus us on getting actionable work done.
>> 
>> I like the idea of having topics submitted early and teams getting
>> organized prior to the actual hackathon.
>> 
>> Cheers,
>> 
>> Will
>> 
>> On Thu, May 5, 2016 at 10:23 AM, John Burwell 
>> wrote:
>> 
>>> All,
>>> 
>>> In advance of the CCNA16 Hackathon on Wednesday, 1 June 2016, it seems
>>> like it would be wise to organize the topics which people are interested in
>>> addressing.  My thought is anyone may suggest a topic and/or register their
>>> interest in a topic.  Also, since there will likely be a number of people
>>> unable to physically attend, we can create a Google Hangout for each
>>> group.  Hopefully, by organizing the topics in advance and broadcasting our
>>> work, we can further extend participation across the community.
>>> 
>>> To begin organizing topics, I have created a public Google Spreadsheet
>>> [1] with columns for group name, organizer/proposer,  interested
>>> participants, and a Hangout URL.  If you would like to propose a topic,
>>> create a new row with the name of the group, your name and email, and a
>>> Hangout URL (instructions[2]).  If you are interested in one or more
>>> topics, please add your name and email to the row.  I would also like to
>>> propose that we record the Hangout sessions (upload location TBD), and that
>>> the organizer of the topic report any results of their efforts with a URL
>>> of the recording back to dev@.
>>> 
>>> Finally, I have included users@ and marketing@ as they may also wish to
>>> participate.
>>> 
>>> Thanks,
>>> -John
>>> 
>>> [1]:
>>> https://docs.google.com/spreadsheets/d/14U0E1YpgZvsBc88SHVojo-XzOLAKs-WFEkMxXlrAl_o/edit#gid=0
>>> [2]: https://support.google.com/hangouts/answer/3111943?hl=en
>>> 
>>> 
>>> 
>>> 
>>> 
>>> john.burw...@shapeblue.com
>>> www.shapeblue.com
>>> @shapeblue
>>> 
>> 
>> 

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1423#issuecomment-217990022
  
Thanks @syed.  I will get CI run against this.  I see we have the required 
code review, so I just need to get CI run.  Thx...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1502#discussion_r62570929
  
--- Diff: 
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
@@ -0,0 +1,112 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package org.apache.cloudstack.utils.process;
+
+import com.cloud.utils.concurrency.NamedThreadFactory;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Strings;
+import org.apache.log4j.Logger;
+import org.joda.time.Duration;
+
+import java.io.BufferedReader;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.util.List;
+import java.util.concurrent.Callable;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+
+public class ProcessRunner {
+public static final Logger LOG = Logger.getLogger(ProcessRunner.class);
+
+private static final ExecutorService processExecutor = 
Executors.newCachedThreadPool(new NamedThreadFactory("ProcessRunner"));
+
+private static String readStream(final InputStream inputStream) {
+String text = null;
+try {
+final BufferedReader bufferedReader = new BufferedReader(new 
InputStreamReader(inputStream));
+String line;
+while ((line = bufferedReader.readLine()) != null) {
+if (Strings.isNullOrEmpty(text)) {
+text = line;
+} else {
+text = text + "\n" + line;
+}
+}
+} catch (IOException e) {
+if (LOG.isTraceEnabled()) {
+LOG.trace("ProcessRunner::readStream failed due to: " + 
e.getMessage());
+}
+}
+return text;
+}
+
+public static ProcessResult executeCommands(final List 
commands, final Duration timeOut) {
+Preconditions.checkArgument(commands != null && timeOut != null);
+
+int retVal = -2;
+String stdOutput = null;
+String stdError = null;
+
+try {
+final Process process = new 
ProcessBuilder().command(commands).start();
+if (timeOut.getStandardSeconds() > 0) {
+final Future processFuture = 
processExecutor.submit(new Callable() {
+@Override
+public Integer call() throws Exception {
+return process.waitFor();
+}
+});
+try {
+retVal = 
processFuture.get(timeOut.getStandardSeconds(), TimeUnit.SECONDS);
+} catch (ExecutionException | TimeoutException e) {
+retVal = -1;
+stdError = "Operation timed out, aborted";
+if (LOG.isTraceEnabled()) {
+LOG.trace("Failed to complete the requested 
command within timeout: " + e.getMessage());
+}
+} finally {
+if (Strings.isNullOrEmpty(stdError)) {
+stdOutput = readStream(process.getInputStream());
+stdError = readStream(process.getErrorStream());
+}
+}
+} else {
+retVal = process.waitFor();
+stdOutput = readStream(process.getInputStream());
+stdError = readStream(process.getErrorStream());
+}
+process.destroy();
--- End diff --

Should this call be part of a ``finally`` block to ensure cleanup in all 
circumstances?


---
If your 

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1502#discussion_r62570751
  
--- Diff: 
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessResult.java ---
@@ -0,0 +1,46 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.utils.process;
+
+public class ProcessResult {
--- End diff --

Could this class be collapsed as a ``static final`` class in 
``ProcessRunner``?  Also, the class should be ``final`` and the constructor to 
should either be default (standalone class) or ``private`` (static inner class).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1502#discussion_r62570445
  
--- Diff: 
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
@@ -0,0 +1,112 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package org.apache.cloudstack.utils.process;
+
+import com.cloud.utils.concurrency.NamedThreadFactory;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Strings;
+import org.apache.log4j.Logger;
+import org.joda.time.Duration;
+
+import java.io.BufferedReader;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.util.List;
+import java.util.concurrent.Callable;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+
+public class ProcessRunner {
+public static final Logger LOG = Logger.getLogger(ProcessRunner.class);
+
+private static final ExecutorService processExecutor = 
Executors.newCachedThreadPool(new NamedThreadFactory("ProcessRunner"));
--- End diff --

A cached thread pool is unbounded.  Should we consider the use of a bounded 
thread pool to prevent shell processes from overwhelming the management server?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1502#discussion_r62569864
  
--- Diff: 
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
@@ -0,0 +1,112 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package org.apache.cloudstack.utils.process;
+
+import com.cloud.utils.concurrency.NamedThreadFactory;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Strings;
+import org.apache.log4j.Logger;
+import org.joda.time.Duration;
+
+import java.io.BufferedReader;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.util.List;
+import java.util.concurrent.Callable;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+
+public class ProcessRunner {
+public static final Logger LOG = Logger.getLogger(ProcessRunner.class);
+
+private static final ExecutorService processExecutor = 
Executors.newCachedThreadPool(new NamedThreadFactory("ProcessRunner"));
+
+private static String readStream(final InputStream inputStream) {
+String text = null;
+try {
+final BufferedReader bufferedReader = new BufferedReader(new 
InputStreamReader(inputStream));
+String line;
+while ((line = bufferedReader.readLine()) != null) {
+if (Strings.isNullOrEmpty(text)) {
+text = line;
+} else {
+text = text + "\n" + line;
+}
+}
+} catch (IOException e) {
+if (LOG.isTraceEnabled()) {
+LOG.trace("ProcessRunner::readStream failed due to: " + 
e.getMessage());
+}
+}
+return text;
+}
+
+public static ProcessResult executeCommands(final List 
commands, final Duration timeOut) {
+Preconditions.checkArgument(commands != null && timeOut != null);
+
+int retVal = -2;
+String stdOutput = null;
+String stdError = null;
+
+try {
+final Process process = new 
ProcessBuilder().command(commands).start();
+if (timeOut.getStandardSeconds() > 0) {
+final Future processFuture = 
processExecutor.submit(new Callable() {
+@Override
+public Integer call() throws Exception {
+return process.waitFor();
+}
+});
+try {
+retVal = 
processFuture.get(timeOut.getStandardSeconds(), TimeUnit.SECONDS);
+} catch (ExecutionException | TimeoutException e) {
--- End diff --

Why are signaling a failure with a return value instead of an exception?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1502#discussion_r62569447
  
--- Diff: 
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
@@ -0,0 +1,112 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package org.apache.cloudstack.utils.process;
+
+import com.cloud.utils.concurrency.NamedThreadFactory;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Strings;
+import org.apache.log4j.Logger;
+import org.joda.time.Duration;
+
+import java.io.BufferedReader;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.util.List;
+import java.util.concurrent.Callable;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+
+public class ProcessRunner {
+public static final Logger LOG = Logger.getLogger(ProcessRunner.class);
+
+private static final ExecutorService processExecutor = 
Executors.newCachedThreadPool(new NamedThreadFactory("ProcessRunner"));
+
+private static String readStream(final InputStream inputStream) {
+String text = null;
+try {
+final BufferedReader bufferedReader = new BufferedReader(new 
InputStreamReader(inputStream));
+String line;
+while ((line = bufferedReader.readLine()) != null) {
+if (Strings.isNullOrEmpty(text)) {
+text = line;
+} else {
+text = text + "\n" + line;
+}
+}
+} catch (IOException e) {
--- End diff --

Why don't we re-throw this exception as an unchecked exception?  Failing to 
read the standard out and error streams seems like it would represent a failure 
of the operation.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1502#discussion_r62569193
  
--- Diff: 
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
@@ -0,0 +1,112 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package org.apache.cloudstack.utils.process;
+
+import com.cloud.utils.concurrency.NamedThreadFactory;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Strings;
+import org.apache.log4j.Logger;
+import org.joda.time.Duration;
+
+import java.io.BufferedReader;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.util.List;
+import java.util.concurrent.Callable;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+
+public class ProcessRunner {
+public static final Logger LOG = Logger.getLogger(ProcessRunner.class);
+
+private static final ExecutorService processExecutor = 
Executors.newCachedThreadPool(new NamedThreadFactory("ProcessRunner"));
+
+private static String readStream(final InputStream inputStream) {
+String text = null;
+try {
+final BufferedReader bufferedReader = new BufferedReader(new 
InputStreamReader(inputStream));
+String line;
--- End diff --

Convert to a ``StringBuilder`` to avoid unnecessary String re-allocation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1502#discussion_r62568855
  
--- Diff: 
utils/src/main/java/org/apache/cloudstack/utils/process/ProcessRunner.java ---
@@ -0,0 +1,112 @@
+//
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+//
+
+package org.apache.cloudstack.utils.process;
+
+import com.cloud.utils.concurrency.NamedThreadFactory;
+import com.google.common.base.Preconditions;
+import com.google.common.base.Strings;
+import org.apache.log4j.Logger;
+import org.joda.time.Duration;
+
+import java.io.BufferedReader;
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.InputStreamReader;
+import java.util.List;
+import java.util.concurrent.Callable;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.Future;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.TimeoutException;
+
+public class ProcessRunner {
+public static final Logger LOG = Logger.getLogger(ProcessRunner.class);
+
+private static final ExecutorService processExecutor = 
Executors.newCachedThreadPool(new NamedThreadFactory("ProcessRunner"));
+
+private static String readStream(final InputStream inputStream) {
+String text = null;
+try {
+final BufferedReader bufferedReader = new BufferedReader(new 
InputStreamReader(inputStream));
+String line;
+while ((line = bufferedReader.readLine()) != null) {
+if (Strings.isNullOrEmpty(text)) {
+text = line;
+} else {
+text = text + "\n" + line;
+}
+}
+} catch (IOException e) {
+if (LOG.isTraceEnabled()) {
+LOG.trace("ProcessRunner::readStream failed due to: " + 
e.getMessage());
+}
+}
+return text;
+}
+
+public static ProcessResult executeCommands(final List 
commands, final Duration timeOut) {
+Preconditions.checkArgument(commands != null && timeOut != null);
+
+int retVal = -2;
+String stdOutput = null;
+String stdError = null;
+
+try {
+final Process process = new 
ProcessBuilder().command(commands).start();
+if (timeOut.getStandardSeconds() > 0) {
--- End diff --

Should a command without a timeout be accepted? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-9296] Start ipsec for client ...

[syed]

Github user syed commented on the pull request:

https://github.com/apache/cloudstack/pull/1423#issuecomment-217972968
  
@swill Sqashed. I believe this is good to go. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: [CLOUDSTACK-8973] Fix create template fro...

[syed]

Github user syed commented on the pull request:

https://github.com/apache/cloudstack/pull/1424#issuecomment-217972386
  
@rhtyd Squashed. It is pending a LGTM. If you can have a quick look at this 
one, it would be awesome!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

[syed]

Github user syed commented on the pull request:

https://github.com/apache/cloudstack/pull/1331#issuecomment-217971133
  
@rafaelweingartner @jburwell Sorry for the late reply to this. I was on 
vacation and returned today. I've decided to use John's approach for the 
logging test as I feel it is more natural. Also the dicussion about `final 
static` being immutable and skipped by GC makes me feel that using an appender 
makes more sense. Furthermore, the `TestAppender` class provided by @jburwell 
is generic so that other tests can use it too. 

I will sqash the commits as it looking pretty good now unless you guys have 
any more comments. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

[mike-tutkowski]

Github user mike-tutkowski commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/816#discussion_r62547345
  
--- Diff: 
plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/SolidFireHostListener.java
 ---
@@ -91,18 +280,5 @@ public boolean hostConnect(long hostId, long 
storagePoolId) {
 assert (answer instanceof ModifyStoragePoolAnswer) : 
"ModifyStoragePoolAnswer expected ; Pool = " + storagePool.getId() + " Host = " 
+ hostId;
--- End diff --

Some like they; some don't. I'd say feel free to put asserts in your code. 
I don't think the community has a formal policy on it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

[mike-tutkowski]

Github user mike-tutkowski commented on the pull request:

https://github.com/apache/cloudstack/pull/816#issuecomment-217947984
  
@syed Thanks for the code review!
@swill I believe we are good to go on this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

[mike-tutkowski]

Github user mike-tutkowski commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/816#discussion_r62548252
  
--- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java ---
@@ -1570,17 +1578,35 @@ private boolean checkCIDR(final HostPodVO pod, 
final String serverPrivateIP, fin
 return true;
 }
 
+private HostVO isNewHost(StartupCommand[] startupCommands) {
--- End diff --

Changed - thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

[mike-tutkowski]

Github user mike-tutkowski commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/816#discussion_r62547209
  
--- Diff: 
plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/SolidFireHostListener.java
 ---
@@ -65,22 +94,182 @@ public boolean hostConnect(long hostId, long 
storagePoolId) {
 storagePoolHostDao.persist(storagePoolHost);
 }
 
-// just want to send the ModifyStoragePoolCommand for KVM
-if (host.getHypervisorType() != HypervisorType.KVM) {
-return true;
+if (host.getHypervisorType().equals(HypervisorType.XenServer)) {
+handleXenServer(host.getClusterId(), host.getId(), 
storagePoolId);
+}
+else if (host.getHypervisorType().equals(HypervisorType.KVM)) {
+handleKVM(hostId, storagePoolId);
+}
+
+return true;
+}
+
+@Override
+public boolean hostDisconnected(long hostId, long storagePoolId) {
+StoragePoolHostVO storagePoolHost = 
storagePoolHostDao.findByPoolHost(storagePoolId, hostId);
+
+if (storagePoolHost != null) {
+storagePoolHostDao.deleteStoragePoolHostDetails(hostId, 
storagePoolId);
+}
+
+return true;
+}
+
+@Override
+public boolean hostAboutToBeRemoved(long hostId) {
+HostVO host = _hostDao.findById(hostId);
+
+handleVMware(host, false);
--- End diff --

Unfortunately, it appears to be too late at that point because CloudStack 
can't talk to the host anymore.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

[mike-tutkowski]

Github user mike-tutkowski commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/816#discussion_r62547042
  
--- Diff: 
plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/SolidFireHostListener.java
 ---
@@ -18,40 +18,69 @@
  */
 package org.apache.cloudstack.storage.datastore.provider;
 
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
 import javax.inject.Inject;
 
 import org.apache.log4j.Logger;
 
 import org.apache.cloudstack.engine.subsystem.api.storage.DataStoreManager;
 import 
org.apache.cloudstack.engine.subsystem.api.storage.HypervisorHostListener;
+import org.apache.cloudstack.storage.datastore.db.PrimaryDataStoreDao;
+import org.apache.cloudstack.storage.datastore.db.StoragePoolDetailsDao;
+import org.apache.cloudstack.storage.datastore.db.StoragePoolVO;
+import org.apache.cloudstack.storage.datastore.util.SolidFireUtil;
 
 import com.cloud.agent.AgentManager;
 import com.cloud.agent.api.Answer;
 import com.cloud.agent.api.ModifyStoragePoolAnswer;
 import com.cloud.agent.api.ModifyStoragePoolCommand;
+import com.cloud.agent.api.ModifyTargetsCommand;
 import com.cloud.alert.AlertManager;
+import com.cloud.dc.ClusterDetailsDao;
+import com.cloud.dc.dao.ClusterDao;
 import com.cloud.host.HostVO;
 import com.cloud.host.dao.HostDao;
 import com.cloud.hypervisor.Hypervisor.HypervisorType;
 import com.cloud.storage.DataStoreRole;
 import com.cloud.storage.StoragePool;
 import com.cloud.storage.StoragePoolHostVO;
+import com.cloud.storage.VolumeVO;
 import com.cloud.storage.dao.StoragePoolHostDao;
+import com.cloud.storage.dao.VolumeDao;
 import com.cloud.utils.exception.CloudRuntimeException;
+import com.cloud.vm.VMInstanceVO;
+import com.cloud.vm.dao.VMInstanceDao;
 
 public class SolidFireHostListener implements HypervisorHostListener {
 private static final Logger s_logger = 
Logger.getLogger(SolidFireHostListener.class);
 
-@Inject
-private AgentManager _agentMgr;
-@Inject
-private AlertManager _alertMgr;
-@Inject
-private DataStoreManager _dataStoreMgr;
-@Inject
-private HostDao _hostDao;
-@Inject
-private StoragePoolHostDao storagePoolHostDao;
+@Inject private AgentManager _agentMgr;
+@Inject private AlertManager _alertMgr;
+@Inject private ClusterDao _clusterDao;
+@Inject private ClusterDetailsDao _clusterDetailsDao;
+@Inject private DataStoreManager _dataStoreMgr;
+@Inject private HostDao _hostDao;
+@Inject private PrimaryDataStoreDao _storagePoolDao;
+@Inject private StoragePoolDetailsDao _storagePoolDetailsDao;
+@Inject private StoragePoolHostDao storagePoolHostDao;
+@Inject private VMInstanceDao _vmDao;
+@Inject private VolumeDao _volumeDao;
+
+@Override
+public boolean hostAdded(long hostId) {
+HostVO host = _hostDao.findById(hostId);
+
+SolidFireUtil.hostAddedToOrRemovedFromCluster(hostId, 
host.getClusterId(), true, SolidFireUtil.PROVIDER_NAME,
+_clusterDao, _clusterDetailsDao, _storagePoolDao, 
_storagePoolDetailsDao, _hostDao);
+
+handleVMware(host, true);
--- End diff --

For now, yes (hypervisor hosts that require that we explicitly remove iSCSI 
targets in this scenario).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

[mike-tutkowski]

Github user mike-tutkowski commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/816#discussion_r62546959
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -933,7 +937,7 @@ private PlugNicAnswer execute(PlugNicCommand cmd) {
  */
--- End diff --

Interesting...this code does not appear to be commented out in the most 
recent version of the code on master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

[jburwell]

Github user jburwell commented on the pull request:

https://github.com/apache/cloudstack/pull/1502#issuecomment-217944726
  
@rhtyd it looks like one of the OOBM smoke tests failed on the Travis 
build.  Could you please investigate?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

[mike-tutkowski]

Github user mike-tutkowski commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/816#discussion_r62546214
  
--- Diff: engine/components-api/src/com/cloud/agent/Listener.java ---
@@ -87,6 +93,18 @@
 boolean processDisconnect(long agentId, Status state);
 
 /**
+ * This method is called by AgentManager when a host is about to be 
removed from a cluster.
+ * @param long the ID of the newly added host
--- End diff --

Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

[mike-tutkowski]

Github user mike-tutkowski commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/816#discussion_r62546243
  
--- Diff: engine/components-api/src/com/cloud/agent/Listener.java ---
@@ -87,6 +93,18 @@
 boolean processDisconnect(long agentId, Status state);
 
 /**
+ * This method is called by AgentManager when a host is about to be 
removed from a cluster.
+ * @param long the ID of the newly added host
+ */
+void processHostAboutToBeRemoved(long hostId);
+
+/**
+ * This method is called by AgentManager when a host is removed from a 
cluster.
+ * @param long the ID of the newly added host
--- End diff --

Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

[mike-tutkowski]

Github user mike-tutkowski commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/816#discussion_r62545797
  
--- Diff: 
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/HypervisorHostListener.java
 ---
@@ -21,7 +21,13 @@
 import com.cloud.exception.StorageConflictException;
 
 public interface HypervisorHostListener {
+boolean hostAdded(long hostId);
+
 boolean hostConnect(long hostId, long poolId) throws 
StorageConflictException;
 
 boolean hostDisconnected(long hostId, long poolId);
+
+boolean hostAboutToBeRemoved(long hostId);
--- End diff --

This event was added specifically to address hypervisors like VMware that 
need to be told to remove iSCSI targets.

Those kind of hypervisor hosts need to be notified to do this before the 
host is removed because CloudStack can no longer talk to those hosts once 
they're in the Removed state.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: hidden configuration items revisited

[Erik Weber]

listConfiguration returns unencrypted values for Secure items, but they
need to be stored encrypted in the db.

You'd need to check If those values ever change, If they don't you may try
encrypting the value and change category to Secure

Erik

Den mandag 9. mai 2016 skrev Nathan Johnson  følgende:

> Erik Weber > wrote:
>
> > I believe Kishan suggested that you could change those Hidden config
> items
> > to Secure (an existing category), as Secure items are returned with the
> > listConfiguration API.
>
> This is chicken and egg.  I need the unencrypted values so I can decrypt
> other payloads.  I need the keys plaintext, one way or another.
>

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/816#issuecomment-217892225
  
This has the required code reviews.  @mike-tutkowski have a look at the 
comments @syed made.  I will get this into my CI queue so we can get it moving 
forward.  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

[syed]

Github user syed commented on the pull request:

https://github.com/apache/cloudstack/pull/816#issuecomment-217890036
  
@mike-tutkowski I've reviewed the code and it LGTM. I have a few minor 
comments that should be fairly simple to adress. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Removed Unused Void Class

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1440#issuecomment-217889598
  
CI has come back clean.  👍 I will add this to my merge queue.  Thx...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

[syed]

Github user syed commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/816#discussion_r62513240
  
--- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java ---
@@ -1570,17 +1578,35 @@ private boolean checkCIDR(final HostPodVO pod, 
final String serverPrivateIP, fin
 return true;
 }
 
+private HostVO isNewHost(StartupCommand[] startupCommands) {
--- End diff --

Rename to `getNewHost` ?  `isNewHost` sounds like it should return a boolean


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Addresses CLOUDSTACK-9300 where the MySQL...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1428#issuecomment-217887345
  
I think this one is ready.  The failures are things that periodically fail 
in my environment and are unrelated to this code.  Thanks...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

[syed]

Github user syed commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/816#discussion_r62511172
  
--- Diff: 
plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/SolidFireHostListener.java
 ---
@@ -91,18 +280,5 @@ public boolean hostConnect(long hostId, long 
storagePoolId) {
 assert (answer instanceof ModifyStoragePoolAnswer) : 
"ModifyStoragePoolAnswer expected ; Pool = " + storagePool.getId() + " Host = " 
+ hostId;
--- End diff --

Off topic but I wanted to know what is the take on asserts? Personally I 
love asserts but not sure what the community thinks of it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

[syed]

Github user syed commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/816#discussion_r62509977
  
--- Diff: 
plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/SolidFireHostListener.java
 ---
@@ -65,22 +94,182 @@ public boolean hostConnect(long hostId, long 
storagePoolId) {
 storagePoolHostDao.persist(storagePoolHost);
 }
 
-// just want to send the ModifyStoragePoolCommand for KVM
-if (host.getHypervisorType() != HypervisorType.KVM) {
-return true;
+if (host.getHypervisorType().equals(HypervisorType.XenServer)) {
+handleXenServer(host.getClusterId(), host.getId(), 
storagePoolId);
+}
+else if (host.getHypervisorType().equals(HypervisorType.KVM)) {
+handleKVM(hostId, storagePoolId);
+}
+
+return true;
+}
+
+@Override
+public boolean hostDisconnected(long hostId, long storagePoolId) {
+StoragePoolHostVO storagePoolHost = 
storagePoolHostDao.findByPoolHost(storagePoolId, hostId);
+
+if (storagePoolHost != null) {
+storagePoolHostDao.deleteStoragePoolHostDetails(hostId, 
storagePoolId);
+}
+
+return true;
+}
+
+@Override
+public boolean hostAboutToBeRemoved(long hostId) {
+HostVO host = _hostDao.findById(hostId);
+
+handleVMware(host, false);
--- End diff --

Can this be done in `hostRemoved` ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

[syed]

Github user syed commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/816#discussion_r62509667
  
--- Diff: 
plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/provider/SolidFireHostListener.java
 ---
@@ -18,40 +18,69 @@
  */
 package org.apache.cloudstack.storage.datastore.provider;
 
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
 import javax.inject.Inject;
 
 import org.apache.log4j.Logger;
 
 import org.apache.cloudstack.engine.subsystem.api.storage.DataStoreManager;
 import 
org.apache.cloudstack.engine.subsystem.api.storage.HypervisorHostListener;
+import org.apache.cloudstack.storage.datastore.db.PrimaryDataStoreDao;
+import org.apache.cloudstack.storage.datastore.db.StoragePoolDetailsDao;
+import org.apache.cloudstack.storage.datastore.db.StoragePoolVO;
+import org.apache.cloudstack.storage.datastore.util.SolidFireUtil;
 
 import com.cloud.agent.AgentManager;
 import com.cloud.agent.api.Answer;
 import com.cloud.agent.api.ModifyStoragePoolAnswer;
 import com.cloud.agent.api.ModifyStoragePoolCommand;
+import com.cloud.agent.api.ModifyTargetsCommand;
 import com.cloud.alert.AlertManager;
+import com.cloud.dc.ClusterDetailsDao;
+import com.cloud.dc.dao.ClusterDao;
 import com.cloud.host.HostVO;
 import com.cloud.host.dao.HostDao;
 import com.cloud.hypervisor.Hypervisor.HypervisorType;
 import com.cloud.storage.DataStoreRole;
 import com.cloud.storage.StoragePool;
 import com.cloud.storage.StoragePoolHostVO;
+import com.cloud.storage.VolumeVO;
 import com.cloud.storage.dao.StoragePoolHostDao;
+import com.cloud.storage.dao.VolumeDao;
 import com.cloud.utils.exception.CloudRuntimeException;
+import com.cloud.vm.VMInstanceVO;
+import com.cloud.vm.dao.VMInstanceDao;
 
 public class SolidFireHostListener implements HypervisorHostListener {
 private static final Logger s_logger = 
Logger.getLogger(SolidFireHostListener.class);
 
-@Inject
-private AgentManager _agentMgr;
-@Inject
-private AlertManager _alertMgr;
-@Inject
-private DataStoreManager _dataStoreMgr;
-@Inject
-private HostDao _hostDao;
-@Inject
-private StoragePoolHostDao storagePoolHostDao;
+@Inject private AgentManager _agentMgr;
+@Inject private AlertManager _alertMgr;
+@Inject private ClusterDao _clusterDao;
+@Inject private ClusterDetailsDao _clusterDetailsDao;
+@Inject private DataStoreManager _dataStoreMgr;
+@Inject private HostDao _hostDao;
+@Inject private PrimaryDataStoreDao _storagePoolDao;
+@Inject private StoragePoolDetailsDao _storagePoolDetailsDao;
+@Inject private StoragePoolHostDao storagePoolHostDao;
+@Inject private VMInstanceDao _vmDao;
+@Inject private VolumeDao _volumeDao;
+
+@Override
+public boolean hostAdded(long hostId) {
+HostVO host = _hostDao.findById(hostId);
+
+SolidFireUtil.hostAddedToOrRemovedFromCluster(hostId, 
host.getClusterId(), true, SolidFireUtil.PROVIDER_NAME,
+_clusterDao, _clusterDetailsDao, _storagePoolDao, 
_storagePoolDetailsDao, _hostDao);
+
+handleVMware(host, true);
--- End diff --

Is hostAdded only applicable to VMWare? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9350: KVM-HA- Fix CheckOnHost ...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1496#issuecomment-217884184
  
The two failures are not ones I am used to seeing in my environment, but I 
did a quick once through of the code and I don't think they problem is related 
to this PR.

I think this PR is ready to merge.  Can I get one other person to review 
this quickly to make sure I am not missing anything and these failures could 
actually be related to this PR?

@rhtyd, @jburwell, @koushik-das : CCing you guys because you guys did code 
review so hopefully one of you can quickly confirm that the issues I got in my 
CI run are not relevant.  Thx...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

[syed]

Github user syed commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/816#discussion_r62508121
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ---
@@ -933,7 +937,7 @@ private PlugNicAnswer execute(PlugNicCommand cmd) {
  */
--- End diff --

Not directly related to the PR but I've been seening the discussion and 
I've also seen that you've cleaned up a lot of the code @mike-tutkowski. is it 
safe to remove this commented block also?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

[nvazquez]

Github user nvazquez commented on the pull request:

https://github.com/apache/cloudstack/pull/1497#issuecomment-217880689
  
Hi @koushik-das thanks for reviewing! Actually it took so long due to 
setUpClass method, after that, test are really simple and quick. I 
included 12 minutes sleep as you noticed due to vm snapshots bug, remaining 
time was (vm, templates, snapshots and vmsnapshots) creation


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: hidden configuration items revisited

[Nathan Johnson]

Erik Weber  wrote:

> I believe Kishan suggested that you could change those Hidden config items
> to Secure (an existing category), as Secure items are returned with the
> listConfiguration API.

This is chicken and egg.  I need the unencrypted values so I can decrypt  
other payloads.  I need the keys plaintext, one way or another.

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

[syed]

Github user syed commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/816#discussion_r62505386
  
--- Diff: engine/components-api/src/com/cloud/agent/Listener.java ---
@@ -87,6 +93,18 @@
 boolean processDisconnect(long agentId, Status state);
 
 /**
+ * This method is called by AgentManager when a host is about to be 
removed from a cluster.
+ * @param long the ID of the newly added host
--- End diff --

typo? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

[syed]

Github user syed commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/816#discussion_r62505426
  
--- Diff: engine/components-api/src/com/cloud/agent/Listener.java ---
@@ -87,6 +93,18 @@
 boolean processDisconnect(long agentId, Status state);
 
 /**
+ * This method is called by AgentManager when a host is about to be 
removed from a cluster.
+ * @param long the ID of the newly added host
+ */
+void processHostAboutToBeRemoved(long hostId);
+
+/**
+ * This method is called by AgentManager when a host is removed from a 
cluster.
+ * @param long the ID of the newly added host
--- End diff --

typo?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

[syed]

Github user syed commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/816#discussion_r62505096
  
--- Diff: 
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/HypervisorHostListener.java
 ---
@@ -21,7 +21,13 @@
 import com.cloud.exception.StorageConflictException;
 
 public interface HypervisorHostListener {
+boolean hostAdded(long hostId);
+
 boolean hostConnect(long hostId, long poolId) throws 
StorageConflictException;
 
 boolean hostDisconnected(long hostId, long poolId);
+
+boolean hostAboutToBeRemoved(long hostId);
--- End diff --

I am assuming this event is generated when moving to `Removing` state. Is 
there any action that is performed here which cannot be done when the host is 
in `Removed` state? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...

[nlivens]

Github user nlivens commented on the pull request:

https://github.com/apache/cloudstack/pull/1246#issuecomment-217875751
  
@SudharmaJain, I've added a few comments


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...

[nlivens]

Github user nlivens commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1246#discussion_r62503852
  
--- Diff: 
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ---
@@ -1588,6 +1588,16 @@ protected StringBuilder 
createGuestBootLoadArgs(final NicProfile guestNic, final
 return buf;
 }
 
+/**
+ * Return a string representing network Cidr for the specifeid network
+ * @param guestNetwork
+ * @return valid network Cidr for the specified network
+ */
+protected String getValidNetworkCidr(Network guestNetwork){
--- End diff --

I think you should extract this method to another common class (e.g. 
NetworkModel) since this method can be reused over the different classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...

[nlivens]

Github user nlivens commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1246#discussion_r62503776
  
--- Diff: server/src/com/cloud/network/guru/GuestNetworkGuru.java ---
@@ -396,6 +396,16 @@ public NicProfile allocate(final Network network, 
NicProfile nic, final VirtualM
 return nic;
 }
 
+/**
+ * Return a string representing network Cidr for the specifeid network
+ * @param guestNetwork
+ * @return valid network Cidr for the specified network
+ */
+protected String getValidNetworkCidr(Network guestNetwork){
--- End diff --

I think you should extract this method to another common class (e.g. 
NetworkModel) since this method can be reused over the different classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9165 unable to use reserved IP...

[nlivens]

Github user nlivens commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1246#discussion_r62503830
  
--- Diff: server/src/com/cloud/network/router/NetworkHelperImpl.java ---
@@ -755,6 +755,16 @@ protected HypervisorType 
getClusterToStartDomainRouterForOvm(final long podId) {
 return networks;
 }
 
+/**
+ * Return a string representing network Cidr for the specifeid network
+ * @param guestNetwork
+ * @return valid network Cidr for the specified network
+ */
+protected String getValidNetworkCidr(Network guestNetwork){
--- End diff --

I think you should extract this method to another common class (e.g. 
NetworkModel) since this method can be reused over the different classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: agent: Enable IPv6 connectivity for KVM A...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1488#issuecomment-217873032
  
We have the required code review and tests, I will add this to my merge 
queue.  Thx...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: hidden configuration items revisited

[Erik Weber]

I believe Kishan suggested that you could change those Hidden config items
to Secure (an existing category), as Secure items are returned with the
listConfiguration API.

I don't know if you can do an in-place switch, or if the value has to be
encrypted first for it to work, but you should be able to test that in a
test environment.

-- 
Erik

On Mon, May 9, 2016 at 3:53 PM, Nathan Johnson  wrote:

> Kishan Kavala  wrote:
>
> > Nathan,
> >   You can use "Secure" category instead of "Hidden". Config items with
> "Secure" category are encrypted and also included in listConfigurations API
> response.
>
> The data that I need (specifically security.encryption.iv and
> security.encryption.key) are already marked “Hidden".  These are the keys
> that are used to encrypt the response that I need to decrypt in the
> middleware.  The configuration item I’m proposing to add is a boolean, so
> that doesn’t make sense to be “Secure” either.  Unless I’m
> misunderstanding?
>
> Thanks for the reply
>
> Nathan
>
>
> >
> > ~kishan
> >
> > -Original Message-
> > From: Nathan Johnson [mailto:njohn...@ena.com]
> > Sent: 08 May 2016 22:01
> > To: dev@cloudstack.apache.org
> > Subject: hidden configuration items revisited
> >
> > I would like to get some feedback for a proposed addition of a feature
> > that would allow “Hidden” configuration items to be returned from the
> > listConfigurations endpoint.
> >
> > 1) There will be a new optional parameter for listConfigurations called
> > showhidden .  Defaults to false.  Existing behavior is preserved unless
> > showhidden is set to true.
> >
> > 2) There is a now configuration item, com.cloud.allowshowhidden , which
> > defaults to false.  This must be set to true in order for showhidden to
> > be allowed.  If showhidden=true is passed and
> > com.cloud.allowshowhidden=false, an InvalidParameterValueException is
> > thrown.
> >
> > So the web UI would still hide hidden configuration items regardless of
> > the state of com.cloud.allowshowhidden since it will not be passing
> > showhidden=true.  The main value of this would be from API
> > implementations / middleware, which is what our front-end talks to
> > instead of directly to cloudstack management server.
> >
> > Obviously there is an explicit reason hidden configuration items are not
> > displayed via the API at present.  The Hidden configuration items contain
> > some very sensitive data, such as private keys etc.  I would like to
> > submit a pull request that would make sense to everyone and still be
> > secure by default and not open up pandora’s box so to speak.  I have this
> > working in our lab, but I wanted to get a bit of feedback before
> > submitting a PR.
> >
> > So several questions:
> >
> > 1) Would it make sense for com.cloud.allowshowhidden to be a “Hidden”
> > configuration item?  The up side of this is that you could not toggle
> > this value from the API.  Marking it hidden means that a rogue root admin
> > api key holder could not grant themselves more access.  The down side is
> > that I’m not sure how to easily change this value outside of manually
> > going into the database and changing it, and one should hope that root
> > admin api key holders are well trusted.  Currently I have this
> > implemented as an “Advanced” configuration item.
> >
> > 2) I picked com.cloud.allowshowhidden out of my hat.  Is there a more
> > appropriate name that I should use?
> >
> >
> >
> >
> > DISCLAIMER
> > ==
> > This e-mail may contain privileged and confidential information which is
> > the property of Accelerite, a Persistent Systems business. It is intended
> > only for the use of the individual or entity to which it is addressed. If
> > you are not the intended recipient, you are not authorized to read,
> > retain, copy, print, distribute or use this message. If you have received
> > this communication in error, please notify the sender and delete all
> > copies of this message. Accelerite, a Persistent Systems business does
> > not accept any liability for virus infected mails.
>
>
>

Re: hidden configuration items

[Nathan Johnson]

Anshul Gangwar  wrote:
>
> ms ——authenticate—> CPVM ——for VNC console—>Hypervisor
>   ^
>   | gets images from CPVM
>   web  browser
>
> Which of the above components you want to keep and which to remove?

Currently when you hit the management server and pass it a vmid, you get a  
response that is a html payload with a link in an iframe to the console  
proxy VM, along with a parameter passed on the get string that constitutes  
an encrypted JSON payload.  This encrypted JSON payload includes all of the  
information that would be needed to connect via VNC.  We want to be able to  
make the request from our middleware, intercept and decrypt this JSON  
payload and be be able to use an alternative web based VNC client.

>
> Also you can look into other implementations of Console proxy which are  
> rarely used to get more info.
>

Could you point me to one?  I would be very interested to look at an  
alternative.

Thank you,
Nathan

Re: hidden configuration items revisited

[Nathan Johnson]

Kishan Kavala  wrote:

> Nathan,
>   You can use "Secure" category instead of "Hidden". Config items with 
> "Secure" category are encrypted and also included in listConfigurations API 
> response.

The data that I need (specifically security.encryption.iv and  
security.encryption.key) are already marked “Hidden".  These are the keys  
that are used to encrypt the response that I need to decrypt in the  
middleware.  The configuration item I’m proposing to add is a boolean, so  
that doesn’t make sense to be “Secure” either.  Unless I’m misunderstanding?

Thanks for the reply

Nathan


>
> ~kishan
>
> -Original Message-
> From: Nathan Johnson [mailto:njohn...@ena.com]
> Sent: 08 May 2016 22:01
> To: dev@cloudstack.apache.org
> Subject: hidden configuration items revisited
>
> I would like to get some feedback for a proposed addition of a feature  
> that would allow “Hidden” configuration items to be returned from the  
> listConfigurations endpoint.
>
> 1) There will be a new optional parameter for listConfigurations called  
> showhidden .  Defaults to false.  Existing behavior is preserved unless  
> showhidden is set to true.
>
> 2) There is a now configuration item, com.cloud.allowshowhidden , which  
> defaults to false.  This must be set to true in order for showhidden to  
> be allowed.  If showhidden=true is passed and  
> com.cloud.allowshowhidden=false, an InvalidParameterValueException is  
> thrown.
>
> So the web UI would still hide hidden configuration items regardless of  
> the state of com.cloud.allowshowhidden since it will not be passing  
> showhidden=true.  The main value of this would be from API  
> implementations / middleware, which is what our front-end talks to  
> instead of directly to cloudstack management server.
>
> Obviously there is an explicit reason hidden configuration items are not  
> displayed via the API at present.  The Hidden configuration items contain  
> some very sensitive data, such as private keys etc.  I would like to  
> submit a pull request that would make sense to everyone and still be  
> secure by default and not open up pandora’s box so to speak.  I have this  
> working in our lab, but I wanted to get a bit of feedback before  
> submitting a PR.
>
> So several questions:
>
> 1) Would it make sense for com.cloud.allowshowhidden to be a “Hidden”
> configuration item?  The up side of this is that you could not toggle  
> this value from the API.  Marking it hidden means that a rogue root admin  
> api key holder could not grant themselves more access.  The down side is  
> that I’m not sure how to easily change this value outside of manually  
> going into the database and changing it, and one should hope that root  
> admin api key holders are well trusted.  Currently I have this  
> implemented as an “Advanced” configuration item.
>
> 2) I picked com.cloud.allowshowhidden out of my hat.  Is there a more  
> appropriate name that I should use?
>
>
>
>
> DISCLAIMER
> ==
> This e-mail may contain privileged and confidential information which is  
> the property of Accelerite, a Persistent Systems business. It is intended  
> only for the use of the individual or entity to which it is addressed. If  
> you are not the intended recipient, you are not authorized to read,  
> retain, copy, print, distribute or use this message. If you have received  
> this communication in error, please notify the sender and delete all  
> copies of this message. Accelerite, a Persistent Systems business does  
> not accept any liability for virus infected mails.

[GitHub] cloudstack pull request: Honour GS use_ext_dns and redundant VR VI...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1536#issuecomment-217867940
  
@ustcweizhou, I suppose it still LGTM to you as well


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Honour GS use_ext_dns and redundant VR VI...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1536#issuecomment-217867849
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1532#issuecomment-217866994
  
LGTM based on code, CI pending


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Number of NICs in VMWare - CS 4.6 bug?

[Octavian Popescu]

I’m afraid not - I found the 25155 ticket reference in some release notes but 
that’s as far as it goes really…

On 09/05/2016 12:11, "Abhinandan Prateek" 
> 
wrote:

It seems there is a limit of 8 NICS that Hyper-V will support for user VMS: 
https://technet.microsoft.com/en-us/library/jj680093.aspx

It seems CS-25155 is some internal jira ticket, do you know if the 
summary/extract can be shared ?



On 06/05/16, 8:15 PM, "Octavian Popescu" 
> wrote:

Adding a bit to this – it looks like it’s a documented bug, fixed in CS-25155 
but unfortunately I couldn’t really find much about the fix other than vague 
references, any ideas how I could track it down?

Thanks,
Octavian

On 06/05/2016 10:28, "Octavian Popescu" 
>
 wrote:

Hello,

There seems to be a bug in CS 4.6 that prevents a VM running on VMWare from 
booting if it has more than 7 NICs – the NICs can be added just fine until you 
hit the VMWare limit (10) but on reboot it doesn’t start anymore until you 
remove them. Do you know if this was fixed in 4.7 or 4.8?

Thanks,
Octavian



Regards,

Abhinandan Prateek

abhinandan.prat...@shapeblue.com
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

[jburwell]

Github user jburwell commented on the pull request:

https://github.com/apache/cloudstack/pull/1371#issuecomment-217859785
  
@abhinandanprateek please check the Jenkins issues and trigger a rebuild to 
get this PR green.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9365 : updateVirtualMachine wi...

[nlivens]

Github user nlivens commented on the pull request:

https://github.com/apache/cloudstack/pull/1523#issuecomment-217858039
  
@DaanHoogland, the file has been renamed to make use of the python naming 
standards


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

[NuxRo]

Github user NuxRo commented on the pull request:

https://github.com/apache/cloudstack/pull/1297#issuecomment-217857669
  
Same here.

Is this XenServer specific, can anyone with an XS test bed help? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: Marvin: Replace a timer.sleep(30) with pu...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1529#issuecomment-217856530
  
All tests are done and I have the code reviews I need.  Adding to merge 
queue.  Thx...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1297#issuecomment-217856052
  
@ don't thank me, I just started to check but my infra is based on KVM and 
it doesn't support scalevm, so I cannot investigate further


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8562: Dynamic Role-Based API C...

[swill]

Github user swill commented on the pull request:

https://github.com/apache/cloudstack/pull/1489#issuecomment-217855833
  
We have the required code reviews and CI results.  I will add this to merge 
queue.  Thx...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

[NuxRo]

Github user NuxRo commented on the pull request:

https://github.com/apache/cloudstack/pull/1297#issuecomment-217853178
  
Thanks Daan


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9199: Fixed deployVirtualMachi...

[alexandrelimassantana]

Github user alexandrelimassantana commented on the pull request:

https://github.com/apache/cloudstack/pull/1280#issuecomment-217842674
  
as @pedro-martins stated, it seems to be fitting that this method is 
extracted to a class to be documented/tested. The code looks good but if the 
exception is to be launched I see no room for backward compatibility. If that's 
an issue, this needs to be rethinked as the raised exception would have to be 
treated and at that point we would have to think if raising the exception was 
really necessary. Overall the code looks good, simple and justified.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-8958: release dedicated ip ran...

[alexandrelimassantana]

Github user alexandrelimassantana commented on the pull request:

https://github.com/apache/cloudstack/pull/1357#issuecomment-217840055
  
Is there a test already to check if the ip ranges release method is called? 
If there is none, I think it should be added


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1297#issuecomment-217839619
  
@nuxro I have rebased but did not get to testing. I don't trust the scalevm 
problem. It might be in the test, in the test environment or in the actual 
code. Looking at it is in (the back of) my queue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request: CLOUDSTACK-9365 : updateVirtualMachine wi...

[DaanHoogland]

Github user DaanHoogland commented on the pull request:

https://github.com/apache/cloudstack/pull/1523#issuecomment-217839187
  
@nlivens thanks for the extra test effort you put into this. Can you rename 
the marvin test to adhere to python naming standards (i.e. no camal case 
underscores mix) For marvin in this case test_deploy_vm_userdata_multinic.py or 
test_deploy_vm_userdata_multi_nic.py would both be fine I guess. otherwise LGTM
@swill, can you schedule this one?




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: Migrating CloudStack content from download.cloud.com

[Raja Pullela]

Hi,

Short Term - all the content has moved to cloudstack.apt-get.eu

Which sections to be modified?

The Install Guide needs to be modified.  Sample links/details are mentioned 
below for 4.6 and same needs to be updated for other Released versions of 
Cloudstack documentation: 
http://docs.cloudstack.apache.org/projects/cloudstack-installation/en/4.6/management-server/#downloading-vhd-util
 
Section - Downloading vhd-util¶

What to do modified ?
modify URL from http://download.cloud.com.s3.amazonaws.com/tools/vhd-util to  
http://cloudstack.apt-get.eu/tools/vhd-util


@Rajsekhar can you please update the sections ?

Thanks
Raja
Senior Manager, Product Development
Accelerite,
2055, Laurelwood Road,  Santa Clara, CA 95054, USA
Phone: 1-408-216-7010,  www.accelerite.com, @accelerite

-Original Message-
From: sebgoa [mailto:run...@gmail.com] 
Sent: Wednesday, March 30, 2016 8:36 PM
To: dev@cloudstack.apache.org
Subject: Re: Migrating CloudStack content from download.cloud.com


> On Mar 30, 2016, at 7:36 AM, Raja Pullela  wrote:
> 
> Just to summarize... and to close this thread for now,
> 
> 1) short term - we will move the content to cloudstack.apt-get.eu
> 2) long term - can someone from PMC or Cloudstack Apache Infra help find out 
> the details on how to all the cloustack (downloads - software, sys templates 
> etc) content hosted on 'download.cloudstack.org'  or something similar.
> 

Can you start a separate thread on this last item, I don’t understand what you 
mean by it

> Best,
> Raja
> Senior Manager, Product Development
> Accelerite,
> 2055, Laurelwood Road,  Santa Clara, CA 95054, USA
> Phone: 1-408-216-7010,  www.accelerite.com, @accelerite
> 
> -Original Message-
> From: Paul Angus [mailto:paul.an...@shapeblue.com]
> Sent: Monday, March 28, 2016 1:38 PM
> To: dev@cloudstack.apache.org
> Subject: RE: Migrating CloudStack content from download.cloud.com
> 
> If someone can figure out a community/ASF acceptable way of the ACS community 
> owning a suitable vendor-neutral domain name, within the community we have 
> enough resources to physically host it (including the space donated by BT via 
> ShapeBlue).
> 
> 
> 
> Regards,
> 
> Paul Angus
> 
> paul.an...@shapeblue.com
> www.shapeblue.com
> 53 Chandos Place, Covent Garden, London  WC2N 4HSUK @shapeblue
> 
> -Original Message-
> From: Erik Weber [mailto:terbol...@gmail.com]
> Sent: Saturday, March 26, 2016 4:19 PM
> To: dev@cloudstack.apache.org
> Subject: Re: Migrating CloudStack content from download.cloud.com
> 
> One of the issues as far as I know is that as Apache CloudStack we have to be 
> strict with what we distribute. Meaning, we won't be able to push noredist 
> stuff, which is a pity.
> 
> Erik
> 
> Den lørdag 26. mars 2016 skrev Ian Rae  følgende:
> 
>> Does Apache provide such hosting services? It seems that the Apache 
>> infrastructure is very restrictive, perhaps we should ask whether 
>> they can provide reliable hosting for templates and other downloads.
>> 
>> If Apache is ruled out as an option I recommend we have the community 
>> contribute the hosting (happy to volunteer) but the URL should be a 
>> community URL and not specific to a commercial vendor. It should 
>> probably be mirrored geographically as well.
>> 
>> Ian
>> 
>> On Saturday, 26 March 2016, Ian Duffy > >
>> wrote:
>> 
>>> I could be completely wrong here, but wasn't there some specific 
>>> closed source citrix magic added to the templates at 
>>> downloads.cloud.com that
>> was
>>> Cloud Platform specific?
>>> 
>>> Ideally, this stuff should be hosted on an Apache Cloudstack 
>>> infrastructure or atleast the main community source ( 
>>> cloudstack.apt-get.eu, shapeblue repo, etc.).
>>> 
>>> On 25 March 2016 at 15:00, Sebastien Goasguen > 
>>> > wrote:
>>> 
 
> On Mar 25, 2016, at 10:24 AM, Raja Pullela <
>>> raja.pull...@accelerite.com  >
 wrote:
> 
> @Sebastien,  thanks for the feedback.  please note that the goal 
> of
>>> this
 exercise was not to impact any users during this migration and 
 hence
>> the
 efforts to place the content at a location where we could move it to.
 Since Wido is ok with hosting the content on 
 'cloudstack.apt-get.eu',
>> it
 is even better.  I will work with Wido on the next steps.
> 
 
 Ok cool.
 
 We had other threads about avoiding company specific URL in docs. 
 So
>>> let’s
 definitely avoid that.
 
 
> @Ilya,  'cloud.com' is not getting transferred.
> 
> Best,
> Raja
> Senior Manager, Product Development Accelerite, www.accelerite.com
> 
> -Original Message-
> From: Sebastien Goasguen [mailto:run...@gmail.com 
>> ]
> Sent: Friday, March 25, 2016 1:57 PM
> To: 

[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...

[DaanHoogland]

Github user DaanHoogland commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1532#discussion_r62482644
  
--- Diff: framework/db/src/com/cloud/utils/db/GenericDaoBase.java ---
@@ -942,12 +942,18 @@ public T findOneBy(final SearchCriteria sc) {
 @DB()
 @SuppressWarnings("unchecked")
 public T findById(final ID id) {
+T result = null;
 if (_cache != null) {
 final Element element = _cache.get(id);
-return element == null ? lockRow(id, null) : 
(T)element.getObjectValue();
+if (element == null) {
+result = lockRow(id, null);
+} else {
+result = (T)element.getObjectValue();
+}
 } else {
-return lockRow(id, null);
+result = lockRow(id, null);
 }
+return result
--- End diff --

a ';' missing :(


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Number of NICs in VMWare - CS 4.6 bug?

[Abhinandan Prateek]

It seems there is a limit of 8 NICS that Hyper-V will support for user VMS: 
https://technet.microsoft.com/en-us/library/jj680093.aspx

It seems CS-25155 is some internal jira ticket, do you know if the 
summary/extract can be shared ?



On 06/05/16, 8:15 PM, "Octavian Popescu"  wrote:

>Adding a bit to this – it looks like it’s a documented bug, fixed in CS-25155 
>but unfortunately I couldn’t really find much about the fix other than vague 
>references, any ideas how I could track it down?
>
>Thanks,
>Octavian
>
>On 06/05/2016 10:28, "Octavian Popescu" 
>> wrote:
>
>Hello,
>
>There seems to be a bug in CS 4.6 that prevents a VM running on VMWare from 
>booting if it has more than 7 NICs – the NICs can be added just fine until you 
>hit the VMWare limit (10) but on reboot it doesn’t start anymore until you 
>remove them. Do you know if this was fixed in 4.7 or 4.8?
>
>Thanks,
>Octavian
>
>

Regards,

Abhinandan Prateek

abhinandan.prat...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London  WC2N 4HSUK
@shapeblue