[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-218666241 @jburwell fixed the ProcessRunner issues, please do a final review and LGTM or suggest changes. Thanks. @nvazquez @swill I've fixed two CI issues (Travis and

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62967326 --- Diff: utils/src/main/java/com/cloud/utils/net/cidr/CIDR4.java --- @@ -0,0 +1,172 @@ +// +// Licensed to the Apache Software

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1502 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1502 CLOUDSTACK-9299: Out-of-band Management for CloudStack Support access to a host’s out-of-band management interface (e.g. IPMI, iLO, DRAC, etc.) to manage host power operations (on/off

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

Github user rhtyd commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1539#discussion_r62967100 --- Diff: test/integration/smoke/test_list_ids_parameter.py --- @@ -194,10 +194,7 @@ def setUpClass(cls): cls._cleanup = [

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62965518 --- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java --- @@ -1159,6 +1181,25 @@ public static boolean validateGuestCidr(final String

Metrics UI - Incorrect metrics data for zone/cluster

Hi, I came across an issue in the metrics for zone and cluster. I have logged a bug for the same. https://issues.apache.org/jira/browse/CLOUDSTACK-9377 To quickly summarize the issue: APIs have a pagesize restriction - the default.page.size global setting is used as the max result count -

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62963628 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsQuagga.py --- @@ -0,0 +1,85 @@ +# Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1539#issuecomment-218657103 I think one way to cleanup would be to do it case by case basis for each test case manually instead of relying on the class level cleanup. Also, it's best to avoid

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-218656836 @kiwiflyer along with this patch, have you also applied the optimization patch #1534 (make sure to apply the patch on both mgmt server and KVM agent) ? We can debug

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-218656345 @DaanHoogland done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user rhtyd closed the pull request at: https://github.com/apache/cloudstack/pull/1511 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

GitHub user rhtyd reopened a pull request: https://github.com/apache/cloudstack/pull/1511 4.9/master bountycastle changes This PR adds bountycastle related version and code fixes from @DaanHoogland on top of https://github.com/apache/cloudstack/pull/1510 I could not fix

[GitHub] cloudstack pull request: OSPF: adding dynamically routing capabili...

Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1371#discussion_r62962859 --- Diff: server/src/org/apache/cloudstack/network/topology/BasicNetworkVisitor.java --- @@ -316,4 +317,9 @@ public boolean visit(final

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1539#issuecomment-218654451 Sorry for the delay getting to this. I think this probably works in all cases, but I suspect it will not clean up correctly always. Because this was working

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

Github user rhtyd commented on the pull request: https://github.com/apache/cloudstack/pull/1539#issuecomment-218652190 LGTM, cc @swill let's merge this first to avoid other PRs failing --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-8715: Add VirtIO channel to al...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/985#issuecomment-218651517 Does this require a change to the system VM template? I am pulling this in for testing now... --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac address ...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1483#issuecomment-218649701 I need some code review on this one. Thanks... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: Apply static routes on change to master s...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-218649198 Thanks gents. I will get this merged... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Handle private gateways more reliably

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1474#issuecomment-218649126 Thank you sir. I will get this merged... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Make the generated json files unique to p...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1470#issuecomment-218648913 Thanks for the hard work @remibergsma. 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: Remove extraneous log directory and add c...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1537#issuecomment-218648825 This one is ready other than Jenkins. @PaulAngus, can you please either force push the PR or close and reopen it so it kicks off Jenkins so we can get this PR all

[GitHub] cloudstack pull request: CLOUDSTACK-6975: Prevent dnsmasq from sta...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1514#issuecomment-218611825 LGTM. Tested in hardware lab and works as designed. tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: Handle private gateways more reliably

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1474#issuecomment-218607576 LGTM. Tested in a hardware lab. tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: Apply static routes on change to master s...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-218607629 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: Apply static routes on change to master s...

Github user dmabry commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-218600092 LGTM. We tested this in our Lab on HW and all static routes on each PG came up as expected. --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: CLOUDSTACK-9373: Class methods over-shawd...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1528#issuecomment-218597484 I think this one is good to go... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Apply static routes on change to master s...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-218597071 @rafaelweingartner yes, it will be forward merged. Sorry I only just got around to answering your question. I need one more code review on this one. Thanks...

[GitHub] cloudstack pull request: Make the generated json files unique to p...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1470#issuecomment-218595232 Worked with @swill and @kiwiflyer and found the issue: one bit was missing in the backport from Cosmic. Will look into that tomorrow. --- If your project is

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1304#issuecomment-218596132 The additional run of these tests in a new environment gives the same results. I think this needs some work still... --- If your project is set up for it, you can

[GitHub] cloudstack pull request: Apply static routes on change to master s...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1472#issuecomment-218592243 LGTM. Tested in a hardware lab. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: Fix Sync of template.properties in Swift

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1331#issuecomment-218591057 @syed can you have a look at this one. I am not sure why, but I am having a lot of trouble with this PR. I have not been able to get a test run to actually

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1444#issuecomment-218579831 I think this one is pretty much ready. I have one code review on this one. Can I get one more person to look over this for me? Thanks... --- If your project is

[GitHub] cloudstack pull request: CLOUDSTACK-8800 : Improved the listVirtua...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1444#issuecomment-218579019 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 1 Errors: 0 Duration: 9h 12m 09s ``` **Summary of the

[GitHub] cloudstack pull request: Make the generated json files unique to p...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1470#issuecomment-218578631 ### CI RESULTS ``` Tests Run: 85 Skipped: 0 Failed: 24 Errors: 10 Duration: 10h 46m 24s ``` **Summary of

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user mike-tutkowski commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-218553761 @swill OK, looks like are OK here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-218544251 It was stuck due to another jenkins job running. I am still not sure I saw what I saw. when I stopped 1252, shortly after 1253 through 1256 finished. --- If

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-218543261 @swill PR1539 passed Jenkins and Travis. After you merge it should resolve the issue in other PRs --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-218542671 Good point, I am numb to travis timeouts. RM work remnance :( --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1403#issuecomment-218540891 Did a review, I have some remarks, some questions as well. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62892495 --- Diff: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java --- @@ -144,6 +145,8 @@ @Inject SnapshotDataStoreDao

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62892410 --- Diff: core/src/com/cloud/agent/api/StartupRoutingCommand.java --- @@ -35,7 +35,7 @@ long memory; long dom0MinMemory;

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62892193 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,78 +232,211 @@ private

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62891804 --- Diff: server/src/com/cloud/storage/StorageManagerImpl.java --- @@ -209,6 +211,8 @@ @Inject protected HostDao _hostDao;

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62890825 --- Diff: plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/driver/SolidFirePrimaryDataStoreDriver.java --- @@ -692,12

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62890766 --- Diff: plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/driver/SolidFirePrimaryDataStoreDriver.java --- @@ -665,22

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62886608 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java --- @@ -2351,17 +2376,52 @@ public SR

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62886063 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java --- @@ -1792,10 +1796,26 @@ protected

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62885313 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java --- @@ -164,9 +165,12 @@ *

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-218522071 No worries. 👍 I am really short on sleep, but I was pretty confident. :P --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-218520703 Sorry, I confused PRs. Please ignore my last comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-218520519 @rhtyd @kiwiflyer @swill a PR for fixing the problem #1539 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-218519246 @nvazquez I don't think #1539 is related to this PR. I think this one has completely separate issues... --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62881271 --- Diff: engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java --- @@ -554,6 +574,51 @@ protected Void

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62881152 --- Diff: engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java --- @@ -554,6 +574,51 @@ protected Void

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-218514854 @rhtyd @kiwiflyer @swill a PR for fixing the problem #1539 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62880956 --- Diff: engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java --- @@ -134,6 +146,14 @@ EndPointSelector

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62880949 --- Diff: engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java --- @@ -134,6 +146,14 @@ EndPointSelector

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62880464 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java --- @@ -289,7 +291,7 @@ public boolean

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62880347 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java --- @@ -347,38 +395,87 @@ private

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62879575 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java --- @@ -347,38 +395,87 @@ private

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62878912 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java --- @@ -72,8 +77,10 @@

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62876283 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -361,59 +603,221 @@

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62876182 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -361,59 +603,221 @@

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62876040 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -361,59 +608,225 @@

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62875666 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -255,99 +473,123 @@

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-218505040 @DaanHoogland it finished!!! :P --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request: Remove extraneous log directory and add c...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1537#issuecomment-218503981 I am testing now... 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62875028 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,78 +254,214 @@

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-218503116 @DaanHoogland well a timeout in combination with a connection is not being able to be established seems relevant since it is related to the code that has changed.

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62874090 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,78 +232,211 @@

Re: Question: commands.properties.in deprecated

I think this is the extent of the documentation at this point. https://github.com/apache/cloudstack-docs-admin/pull/37/files Rohit, maybe you can shed some light on this from a developer's perspective and how we should be handling this going forward? Are there official docs which covered how to

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218500189 Thank you, I will merge it assuming Jenkins and Travis come back clean. Thx... 👍 --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218499768 Done @swill @serg38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: CLOUDSTACK-9378: Fix for #1497

GitHub user nvazquez opened a pull request: https://github.com/apache/cloudstack/pull/1539 CLOUDSTACK-9378: Fix for #1497 JIRA TICKET: https://issues.apache.org/jira/browse/CLOUDSTACK-9378 After #1497 was merged, test_list_ids_parameter.py failed on Travis. It was noticed

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62872442 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -172,78 +232,211 @@

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62868269 --- Diff: engine/schema/src/com/cloud/dc/dao/ClusterDaoImpl.java --- @@ -260,4 +268,41 @@ public boolean remove(Long id) {

[GitHub] cloudstack pull request: Taking fast and efficient volume snapshot...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1403#discussion_r62867309 --- Diff: engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/PrimaryDataStoreInfo.java --- @@ -36,6 +36,7 @@ static final

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-218489553 I think we are definitely having issues with it not cleaning correctly. I have seen a couple cases where we get the "unable to update index" when it tries to do a

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218489998 Can you create a new PR to fix this and we will get it tested right away. Thanks for being on top of this. 👍 --- If your project is set up for it, you can

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1304#issuecomment-218483982 The added test fails, but lots of tests failed. I will rebuild my environment and test again to see if anything changes. --- If your project is set up for it, you

[GitHub] cloudstack pull request: [CLOUDSTACK-9207] Test to verify restarti...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1304#issuecomment-218483641 ### CI RESULTS ``` Tests Run: 7 Skipped: 0 Failed: 4 Errors: 0 Duration: 0h 37m 50s ``` **Summary of the

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user serg38 commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218480013 The issue that it couldn't find a snaphsot because it is already cleaned by account cleanup. +cls._cleanup = [ +

Question: commands.properties.in deprecated

Hi, I see in afcbd27 that we've deprecated commands.properties.in. Is there documentation on the new way that we specify permissions for a given API these days? Thanks! Mike

[GitHub] cloudstack pull request: Notify listeners when a host has been add...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/816#issuecomment-218480720 That is the rat test. it is usually right. I didn't see a new file without license though. May one of the to with a license starting with an empty comment line

[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...

GitHub user marcaurele reopened a pull request: https://github.com/apache/cloudstack/pull/1532 DAO: Hit the cache for entity flagged as removed too I came along this part of the code and I don't see any reason why the cache should not be used when fetching with the "removed" ones.

Re: Test failure on master?

I can't point to this PR for this, but I have noticed an increase in random failures in my CI runs since this code has gone in. I have not tracked it down to this, but resources are tight in those environments, so if we are getting CPU maxing out, that could potentially account for the higher

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-218473922  --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-9348: Use non-blocking SSL han...

Github user kiwiflyer commented on the pull request: https://github.com/apache/cloudstack/pull/1493#issuecomment-218473890 @rhtyd We're still seeing some odd behaviour related to the agent with this PR (and PR1534) applied to 2 of our hardware labs. What we're seeing is 100% cpu on

[GitHub] cloudstack pull request: 4.9/master bountycastle changes

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1511#issuecomment-218473575 a timeout @swill. in travis that is not a good indication of not working. I wouldn't know where to look. @rhtyd can you close and reopen? --- If your project

[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...

Github user marcaurele closed the pull request at: https://github.com/apache/cloudstack/pull/1532 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Test failure on master?

Rohit, I have seen quite a few issues with this feature so far. The change you made in #1538 does not change the actual code at all, it just reduces the number of tests, so you are less likely to run into the problem, but the problem still exists. I am CCing in Simon Weller as well. I was

Re: Virtual router failed to start on KVM + Linux Bridges

Thank you Wei & Remi !! I will start using the latest system VM templates. With regards, Prashanth On Wed, May 11, 2016 at 2:20 PM, Remi Bergsma wrote: > Hi Prashanth, > > As Wei suggested, when you use CloudStack 4.6/4.7/4.8/4.9 you also need > the systemvm

[GitHub] cloudstack pull request: DAO: Hit the cache for entity flagged as ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1532#issuecomment-218472093 @marcaurele instead of force push you can close and reopen after a few seconds. This usually works as well and seves you switching windows

[GitHub] cloudstack pull request: Remove extraneous log directory and add c...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1537#issuecomment-218470411 LGTM, @swill, I am being very formal but can you queue this for integration tests? --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-9265 cleanup around httpclient...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1385#issuecomment-218467871 @swill I closed and reopened. It started building anew but is now stuck in the archiving phase for quite some time. ``` [INFO]

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218469220 @serg38 I had a bunch of people re-push PRs last night and this morning to get everything green and 3 or 4 are failing with this. Here are a couple off the

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user swill commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218464050 @nvazquez this seems to have broken travis for everyone. We have this issue showing up in pretty much all travis runs right now `ContextSuite

[GitHub] cloudstack pull request: CLOUDSTACK-9299: Out-of-band Management f...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1502#issuecomment-218468571 @rhtyd sure, I'll examine this. This tests are introduced in #1497, I'll work on this --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request: CLOUDSTACK-9351: Add ids parameter to res...

Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/1497#issuecomment-218467920 @swill it's strange, as @serg38 says it succeeds for us and for @koushik-das, I'll investigate. Is there any log of the failure? --- If your project is set up

  1   2   >