Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1557#issuecomment-221426317
Hi @rafaelweingartner ,
Thanks for the advice. I will take a look on that and do the proper changes
as soon as I can.
---
If your project is set up for it,
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221409650
Oh, I think you were just resolving conflicts. I will run CI again just to
verify... Otherwise this is looking good. Thanks everyone...
---
If your project is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221409302
Was the only change since the last CI run the updating of the marvin test
(which I can't run anyway)?
---
If your project is set up for it, you can reply to this
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1560#issuecomment-221409198
Hi @nvazquez,
Thanks for the PR. Great work as always, especially on documenting the
problem.
I think we can improve it a little bit.
Github user KrisSterckx commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221394563
Thanks all folks, that gives the needed LGTM votes!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user nvazquez opened a pull request:
https://github.com/apache/cloudstack/pull/1560
CLOUDSTACK-9368: DS template copies donât get deleted in VMware ESXi with
multiple clusters and zone wide storage
JIRA TICKET: https://issues.apache.org/jira/browse/CLOUDSTACK-9386
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221349421
Thanks @nlivens, great work cleaning.
The code LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user footplus commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1555#discussion_r64432411
--- Diff: systemvm/scripts/config_ssl.sh ---
@@ -204,6 +203,7 @@ if [ -f "$customCACert" ]
then
keytool -delete -alias $aliasName -keystore
GitHub user syed reopened a pull request:
https://github.com/apache/cloudstack/pull/1423
[CLOUDSTACK-9296] Start ipsec for client VPN
This fix starts the IPSEC daemon when enabling client side vpn
You can merge this pull request into a Git repository by running:
$ git pull
Github user syed closed the pull request at:
https://github.com/apache/cloudstack/pull/1423
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-221324840
Thanks for the update. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user footplus commented on the pull request:
https://github.com/apache/cloudstack/pull/1555#issuecomment-221324378
Hum, please wait a bit before merging, it seems that in certain cases, a
problem occurs; I'm not sure yet, but there may be more to it.
I'll double check
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-221304669
@swill if you are happy to merge this without including the tests requested
by @jburwell then this PR is ready to merge.
@luhaijiao I've created
Github user pdion891 commented on the pull request:
https://github.com/apache/cloudstack/pull/1548#issuecomment-221301992
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r64402582
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -27,55 +27,53 @@
import org.apache.log4j.Logger;
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r64402502
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -27,55 +27,53 @@
import org.apache.log4j.Logger;
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1548#issuecomment-221284250
@moul can you close and reopen the PR or rebase and force push in order to
kick off Jenkins again so we can get this all green?
@pdion891 I think you have
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-221278559
@dsclose if you can fix the merge conflicts I can run this again and see
what is outstanding. Thanks...
---
If your project is set up for it, you can reply to this
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r64397004
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -27,55 +27,53 @@
import
Github user swill commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r64395993
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -27,55 +27,53 @@
import org.apache.log4j.Logger;
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1556#issuecomment-221277026
### CI RESULTS
```
Tests Run: 82
Skipped: 0
Failed: 0
Errors: 3
Duration: 8h 11m 34s
```
**Summary of the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-221278053
Apparently `status` is missing from the `listTemplates` response in some
cases. I will investigate after we freeze and before we cut an RC to see if we
can resolve
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1556#issuecomment-221277292
This is a clean run. The errors here are not related to this PR. I will
merge this. Thanks...
---
If your project is set up for it, you can reply to this email
Congratulations Will!
Regards,
Somesh
-Original Message-
From: Tutkowski, Mike [mailto:mike.tutkow...@netapp.com]
Sent: Monday, May 23, 2016 2:13 AM
To: dev@cloudstack.apache.org
Cc: us...@cloudstack.apache.org; market...@cloudstack.apache.org
Subject: Re: [ANNOUNCE] Will Stevens as new
Github user moul commented on the pull request:
https://github.com/apache/cloudstack/pull/1548#issuecomment-221256635
@swill, this solution is backward compatible, the `.dockerinit` file always
cohabited with `.dockerenv`, until recently, `.dockerinit` was removed while
`.dockerenv`
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221222391
@koushik-das, thanks for the review. Yes, all our model objects in the
Nuage VSP library are Serializable :)
---
If your project is set up for it, you can reply
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1545#issuecomment-221221816
I understand @swill. I'll leave this up to you.
The PR has two LGTMs, so we can merge when we want. Same goes for #1531
---
If your project is set up for it,
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-221220936
rebase, yes. I will keep reformat and functional/technical changes
segragated, however.
funny enough the .../push run is started again this time around
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221218765
LGTM. In some of the *Command.java and *Annswer.java classes, simple member
types has been replaced with types defined in the Nuage VSP library. As long as
all
Github user resmo commented on the pull request:
https://github.com/apache/cloudstack/pull/1257#issuecomment-221216726
would like to see this fixed, @sureshanaparti can I help you out?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1494#discussion_r64358114
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java
---
@@ -19,173 +19,43 @@
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-221215124
@DaanHoogland I don't know, can you rebase and squash push -f?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1494#issuecomment-221212242
@GabrielBrascher, @abhinandanprateek, resolved / commented on your notes
---
If your project is set up for it, you can reply to this email and have your
reply
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1530#issuecomment-221211912
tag:easypr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r64353975
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -74,8 +79,9 @@ public void parse(byte[] vmdkFileContent)
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r64353084
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -47,25 +49,28 @@ public void parse(byte[] vmdkFileContent)
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1530#discussion_r64352201
--- Diff:
vmware-base/src/com/cloud/hypervisor/vmware/mo/VmdkFileDescriptor.java ---
@@ -47,25 +49,28 @@ public void parse(byte[] vmdkFileContent)
Github user nlivens commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1494#discussion_r64350508
--- Diff: engine/schema/src/com/cloud/vm/dao/DomainRouterDaoImpl.java ---
@@ -432,4 +432,12 @@ public void removeRouterFromGuestNetwork(final long
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-221205073
timeouts in the before_script.sh again but I will investigate locally.
@rhtyd do you know why only continuous-integration/travis-ci/pr was run
this time
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1297#issuecomment-221202570
@swill, do you know what those errors are about? (always a dizzy feeling
when this happens)
---
If your project is set up for it, you can reply to this email
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1556#issuecomment-221202485
Simple changes. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user luhaijiao commented on the pull request:
https://github.com/apache/cloudstack/pull/1519#issuecomment-221202635
@dclose I think this PR is important for RvR environment too, particularly
to the commits d582358 and bf285e1. Would be very nice to have it in 4.9 if
you can
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/1531#issuecomment-221200314
LGTM based on code review and template build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-221190865
tnx @rhtyd
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-221189095
Done @DaanHoogland
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rhtyd closed the pull request at:
https://github.com/apache/cloudstack/pull/1511
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user rhtyd reopened a pull request:
https://github.com/apache/cloudstack/pull/1511
4.9/master bountycastle changes
This PR adds bountycastle related version and code fixes from @DaanHoogland
on top of https://github.com/apache/cloudstack/pull/1510
I could not fix
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1511#issuecomment-221186203
@rhtyd please re-open this one, if you will.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1531#issuecomment-221185506
sure tag:easypr LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1514#issuecomment-221184807
@swill There is a question about enhanced integration testing but no code
supplied so, tag:mergeready
---
If your project is set up for it, you can reply to
50 matches
Mail list logo
