[GitHub] cloudstack pull request #1824: CLOUDSTACK-9657: Fixed security group ipset i...

2017-02-23 Thread kishankavala
Github user kishankavala commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1824#discussion_r101981147 --- Diff: scripts/vm/hypervisor/xenserver/vmops --- @@ -232,28 +233,50 @@ def deleteFile(session, args): return txt

[GitHub] cloudstack issue #843: Security group ingress/egress issues with xenserver 6...

2017-02-23 Thread kishankavala
Github user kishankavala commented on the issue: https://github.com/apache/cloudstack/pull/843 Code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cloudstack issue #1971: CLOUDSTACK-9726 Update state is not changed to UPDAT...

2017-02-23 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1971 @bvbharatk is there unit tests for this change? @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack issue #1968: CLOUDSTACK-9666 Added basic configuration validation...

2017-02-23 Thread koushik-das
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1968 Code changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1967: CLOUDSTACK-9638 Problems caused when inputting doubl...

2017-02-23 Thread koushik-das
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1967 Code change LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack issue #1964: Bug-Id: CLOUDSTACK-9800 Enabled netscaler inline mod...

2017-02-23 Thread koushik-das
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1964 Code changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack pull request #1883: CLOUDSTACK-9723: Enable unique mac address ac...

2017-02-23 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1883#discussion_r102888327 --- Diff: engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java --- @@ -377,11 +377,16 @@ protected void addAccountToNetwork(final long

[GitHub] cloudstack issue #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR wh...

2017-02-23 Thread bvbharatk
Github user bvbharatk commented on the issue: https://github.com/apache/cloudstack/pull/1965 @ustcweizhou Reformatted the code. thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack issue #1825: CLOUDSTACK-9660: NPE while destroying volumes during...

2017-02-23 Thread koushik-das
Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1825 @karuturi This can be merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

2017-02-23 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/669 @karuturi, We can merge this now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

2017-02-23 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/669 Tested manually. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-23 Thread marcaurele
Github user marcaurele commented on the issue: https://github.com/apache/cloudstack/pull/1768 Forget my last comment, the files can remains as they are. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request #1971: CLOUDSTACK-9726 Update state is not changed t...

2017-02-23 Thread bvbharatk
GitHub user bvbharatk opened a pull request: https://github.com/apache/cloudstack/pull/1971 CLOUDSTACK-9726 Update state is not changed to UPDATE_FAILED in case … …when Host is put in Maintenance Mode. You can merge this pull request into a Git repository by running: $ git

[GitHub] cloudstack pull request #1970: CLOUDSTACK-9725 Failed to update VPC Network ...

2017-02-23 Thread bvbharatk
GitHub user bvbharatk opened a pull request: https://github.com/apache/cloudstack/pull/1970 CLOUDSTACK-9725 Failed to update VPC Network during N/w offering Upgr… …ade which doesnt have ACL service Enabled. check if acl service provider is configured when network is

[GitHub] cloudstack pull request #1969: CLOUDSTACK-9667 Enable resourcecount.check.in...

2017-02-23 Thread bvbharatk
GitHub user bvbharatk opened a pull request: https://github.com/apache/cloudstack/pull/1969 CLOUDSTACK-9667 Enable resourcecount.check.interval by default You can merge this pull request into a Git repository by running: $ git pull https://github.com/bvbharatk/cloudstack

[GitHub] cloudstack pull request #1968: CLOUDSTACK-9666 Added basic configuration val...

2017-02-23 Thread bvbharatk
GitHub user bvbharatk opened a pull request: https://github.com/apache/cloudstack/pull/1968 CLOUDSTACK-9666 Added basic configuration validation for the config d… …rive global settings You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request #1967: CLOUDSTACK-9638 Problems caused when inputtin...

2017-02-23 Thread bvbharatk
GitHub user bvbharatk opened a pull request: https://github.com/apache/cloudstack/pull/1967 CLOUDSTACK-9638 Problems caused when inputting double-byte numbers fo… …r custom compute offerings You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack issue #1880: CLOUDSTACK-9720: [VMware] template_spool_ref table i...

2017-02-23 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1880 @rhtyd Can you please kick off the tests again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack issue #1897: CLOUDSTACK-9733: Concurrent volume snapshots of a VM...

2017-02-23 Thread sureshanaparti
Github user sureshanaparti commented on the issue: https://github.com/apache/cloudstack/pull/1897 The failed test cases above are not related to this PR changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...

2017-02-23 Thread ramkatru
Github user ramkatru commented on the issue: https://github.com/apache/cloudstack/pull/1774 @priyankparihar please check the test failures. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1840: CLOUDSTACK-9685: delete snapshot on primary associat...

2017-02-23 Thread cloudmonger
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1840 ### ACS CI BVT Run **Sumarry:** Build Number 385 Hypervisor xenserver NetworkType Advanced Passed=105 Failed=0 Skipped=7 _Link to logs Folder

[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

2017-02-23 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1941 @GabrielBrascher, Those tests failure are not related to this PR and seems to be failing most of the time and reported as intermittent failures. @rhtyd @karuturi @serg38, We have already

Re: [GitHub] cloudstack issue #1966: CLOUDSTACK-9801: IPSec VPN does not work after vRout...

2017-02-23 Thread Will Stevens
I ha e done pretty extensive testing of the strongswan implementation, but would be happy for you to verify if the problem exists in 4.10. On Feb 23, 2017 9:23 PM, "Sean Lair" wrote: > It is open against the 4.9 branch. > > We are running 4.9.2.0, looks like it affects all

Re: [GitHub] cloudstack issue #1966: CLOUDSTACK-9801: IPSec VPN does not work after vRout...

2017-02-23 Thread Sean Lair
It is open against the 4.9 branch. We are running 4.9.2.0, looks like it affects all 4.9.x.x We haven't tested against 4.10 (strongswan) yet. But it could be a problem and will be worth testing. If strongswan starts before cloudstack adds the nics to the VM it could have same issue. > On

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-02-23 Thread nathanejohnson
Github user nathanejohnson commented on the issue: https://github.com/apache/cloudstack/pull/1955 As an update, I'm working on a Marvin test, and I'm also planning to address wido's concerns. Today had many distractions unfortunately. --- If your project is set up for it, you can

[GitHub] cloudstack issue #1966: CLOUDSTACK-9801: IPSec VPN does not work after vRout...

2017-02-23 Thread swill
Github user swill commented on the issue: https://github.com/apache/cloudstack/pull/1966 I can't see what branch this is opened against on my phone. What version of ACS is this opened against and which version do you have a problem in. The reason I ask is because #1741 was added in

[GitHub] cloudstack pull request #1966: CLOUDSTACK-9801: IPSec VPN does not work afte...

2017-02-23 Thread Slair1
GitHub user Slair1 opened a pull request: https://github.com/apache/cloudstack/pull/1966 CLOUDSTACK-9801: IPSec VPN does not work after vRouter reboot or recreate After a vRouter is recreated (e.g. reboot via CloudStack UI) and Remote Access VPN enabled, VPN won't work anymore.

[GitHub] cloudstack issue #1962: CLOUDSTACK-9798 - Resizing root disk fails when usin...

2017-02-23 Thread mike-tutkowski
Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1962 @syed Hey - I was also working on a feature like this, but related to both XenServer and VMware (adding in VMware-specific code on the resource side). Do you need these changes for 4.10

RE: VPN/IPSEC problem after upgrading to 4.9.2.0

2017-02-23 Thread Sean Lair
Looks like this bug was introduced by Pull Request #1423 https://github.com/apache/cloudstack/pull/1423 It added code to start ipsec (cloudstack/systemvm/patches/debian/config/opt/cloud/bin/configure.py) if vpnconfig['create']: logging.debug("Enabling remote access vpn on "+

[GitHub] cloudstack issue #1825: CLOUDSTACK-9660: NPE while destroying volumes during...

2017-02-23 Thread cloudmonger
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1825 ### ACS CI BVT Run **Sumarry:** Build Number 384 Hypervisor xenserver NetworkType Advanced Passed=105 Failed=0 Skipped=7 _Link to logs Folder

VPN/IPSEC problem after upgrading to 4.9.2.0

2017-02-23 Thread Sean Lair
We just upgraded from 4.8.1.1 to 4.9.2.0. After upgrading we rebooted the virtual routers, and noticed that our site-to-site VPNs and remote-access VPNs would no longer connect. After troubleshooting, we noticed that Openswan (ipsec.d) wasn't listening on the vRouter's IPs. Here is the

Re: Some Jira tickets clean up

2017-02-23 Thread Rafael Weingärtner
Thanks ;) On Thu, Feb 23, 2017 at 3:14 PM, Tutkowski, Mike wrote: > Thanks, Rafael. I uploaded an ISO and walked through the necessary parts > of the wizard. I agree with you that it has been fixed. I commented on the > ticket, then resolved and closed it just now. >

Re: Some Jira tickets clean up

2017-02-23 Thread Tutkowski, Mike
Thanks, Rafael. I uploaded an ISO and walked through the necessary parts of the wizard. I agree with you that it has been fixed. I commented on the ticket, then resolved and closed it just now. On 2/23/17, 12:46 PM, "Rafael Weingärtner" wrote: Thanks for

[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....

2017-02-23 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1896 Got it, thanks for the explanation. I saw that, and I was wondering if it could have been a bug or something else. LGTM then. --- If your project is set up for it, you can

[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....

2017-02-23 Thread milamberspace
Github user milamberspace commented on the issue: https://github.com/apache/cloudstack/pull/1896 @rafaelweingartner It was because the source string (en) has been chenged by this PR 1803, so the translations have been deleted by Transifex to invite the translator to make the new

Re: Some Jira tickets clean up

2017-02-23 Thread Rafael Weingärtner
Thanks for taking time to look at this Mike. The ticket (CLOUDSTACK-4164 ) I managed to check, and I believe it can be closed. On Thu, Feb 23, 2017 at 2:39 PM, Tutkowski, Mike wrote: > Thanks for compiling this

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-23 Thread DaanHoogland
Github user DaanHoogland commented on the issue: https://github.com/apache/cloudstack/pull/1768 @blueorangutan test --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

Re: Some Jira tickets clean up

2017-02-23 Thread Tutkowski, Mike
Thanks for compiling this list, Rafael! I see I was the reporter for this issue: https://issues.apache.org/jira/browse/CLOUDSTACK-4164 I plan to take a look at it and see what the current state is. On 2/23/17, 10:26 AM, "Rafael Weingärtner" wrote: Hi folks,

[GitHub] cloudstack pull request #1963: CLOUDSTACK-9799 - Unable to create volume fro...

2017-02-23 Thread syed
Github user syed closed the pull request at: https://github.com/apache/cloudstack/pull/1963 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request #1963: CLOUDSTACK-9799 - Unable to create volume fro...

2017-02-23 Thread syed
Github user syed commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1963#discussion_r102798055 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -711,6 +711,7 @@ private void

[GitHub] cloudstack pull request #1963: CLOUDSTACK-9799 - Unable to create volume fro...

2017-02-23 Thread mike-tutkowski
Github user mike-tutkowski commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1963#discussion_r102793622 --- Diff: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java --- @@ -711,6 +711,7 @@

[GitHub] cloudstack issue #1963: CLOUDSTACK-9799 - Unable to create volume from snaps...

2017-02-23 Thread mike-tutkowski
Github user mike-tutkowski commented on the issue: https://github.com/apache/cloudstack/pull/1963 Yes, but the PR is scheduled for 4.11. On Feb 23, 2017, at 10:58 AM, Syed Mushtaq Ahmed > wrote:

[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....

2017-02-23 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1896 @milamberspace @rhtyd do you know why the entry "label.host.alerts" was removed from some languages? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

2017-02-23 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1935 @serg38 I did, the code is great as always. However, I have a concern about that `rollBackState` variable being static there. Because the `DomainManagerImpl ` is a singleton, using

[GitHub] cloudstack issue #1963: CLOUDSTACK-9799 - Unable to create volume from snaps...

2017-02-23 Thread syed
Github user syed commented on the issue: https://github.com/apache/cloudstack/pull/1963 @mike-tutkowski If you already have this in your PR, I can close this. Let me know! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

2017-02-23 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1935 @rafaelweingartner Can you review latest updates from @nvazquez . Since tests are passing this PR will be ready for merging to 4.10 --- If your project is set up for it, you can reply to this

Some Jira tickets clean up

2017-02-23 Thread Rafael Weingärtner
Hi folks, I have been reviewing old Jira tickets and we have a bunch that can be closed. The following are the ones I have gone through. Before I close any ticket I would like to check them with you, especially the ones from a category called “Seems to be fixed has to be checked”. I will be

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-23 Thread marcaurele
Github user marcaurele commented on the issue: https://github.com/apache/cloudstack/pull/1768 I looked at the code inside `Upgrade481to490.java` and I cannot understand why the table alterations have been made inside the Java class instead of the SQL file. Because now we cannot move

[GitHub] cloudstack issue #351: This branch implements the CSV and native HA support ...

2017-02-23 Thread cloudmonger
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/351 ### ACS CI BVT Run **Sumarry:** Build Number 383 Hypervisor xenserver NetworkType Advanced Passed=105 Failed=0 Skipped=7 _Link to logs Folder

[GitHub] cloudstack pull request #1958: CLOUDSTACK-5806: add presetup to storage type...

2017-02-23 Thread serg38
Github user serg38 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1958#discussion_r102753237 --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- @@ -508,7 +507,7 @@ public String updateConfiguration(final long userId,

[GitHub] cloudstack issue #1957: CLOUDSTACK-9748:VPN Users search functionality broke...

2017-02-23 Thread rafaelweingartner
Github user rafaelweingartner commented on the issue: https://github.com/apache/cloudstack/pull/1957 Actually, my concerns are not regarding the response. Reading the name of the method one can for sure understand what it returns. My concern is that reading the parameter name

[GitHub] cloudstack issue #1953: CLOUDSTACK-9794: Unable to attach more than 14 devic...

2017-02-23 Thread remibergsma
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1953 Thanks @sureshanaparti will test it soon! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...

2017-02-23 Thread remibergsma
Github user remibergsma commented on the issue: https://github.com/apache/cloudstack/pull/1878 @sureshanaparti Thanks for the info! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request #1941: CLOUDSTACK-8663: Fixed various issues to allo...

2017-02-23 Thread GabrielBrascher
Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1941#discussion_r102730127 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java --- @@ -1415,6 +1417,10 @@ public

[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

2017-02-23 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1941 @borisstoyanov @rhtyd Can we re-test this with B.O. ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-02-23 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1961 @karuturi I agree with @nvazquez . This PR can be safely merged and then B.O. runtime environment needs to be adjusted to define nfs2 mountpoint in test_data.py --- If your project is set up

[GitHub] cloudstack issue #1922: CLOUDSTACK-9757: Fixed issue in traffic from additio...

2017-02-23 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1922 LGTM as it is same to commit edd839ab10226760749d4fc15703a41eddc1dfdd not tested yet, as VPC with RVR is working fine, so I assume this fixes the issue in VPC with single VR. ---

[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

2017-02-23 Thread GabrielBrascher
Github user GabrielBrascher commented on the issue: https://github.com/apache/cloudstack/pull/1941 Thanks @anshul1886. I see that you improved this PR considering the comments from the one closed. Some tests failed. Are they false positives? Otherwise LGTM. Just need to confirm those

[GitHub] cloudstack pull request #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubu...

2017-02-23 Thread ustcweizhou
Github user ustcweizhou commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1950#discussion_r102716218 --- Diff: .gitignore --- @@ -51,7 +51,6 @@ tools/cli/build/ *.jar *.war *.mar -*.zip --- End diff -- @wido ,yes,

[GitHub] cloudstack issue #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR wh...

2017-02-23 Thread ustcweizhou
Github user ustcweizhou commented on the issue: https://github.com/apache/cloudstack/pull/1965 @bvbharatk can you format the code ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request #1941: CLOUDSTACK-8663: Fixed various issues to allo...

2017-02-23 Thread GabrielBrascher
Github user GabrielBrascher commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1941#discussion_r102715520 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java --- @@ -1415,6 +1417,10 @@ public

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-02-23 Thread nvazquez
Github user nvazquez commented on the issue: https://github.com/apache/cloudstack/pull/1961 @karuturi @borisstoyanov next step will be updating Marvin's folder `test_data.py` file and configure an url for key "nfs2" similar as it was done for "nfs", this way it can be used to mount

[GitHub] cloudstack issue #669: Made the adding new keyboard language support easier

2017-02-23 Thread cloudmonger
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/669 ### ACS CI BVT Run **Sumarry:** Build Number 382 Hypervisor xenserver NetworkType Advanced Passed=105 Failed=0 Skipped=7 _Link to logs Folder

[GitHub] cloudstack pull request #1965: CLOUDSTACK-9727 Password reset discrepancy in...

2017-02-23 Thread bvbharatk
GitHub user bvbharatk opened a pull request: https://github.com/apache/cloudstack/pull/1965 CLOUDSTACK-9727 Password reset discrepancy in RVR when one of the Rou… …ter is not in Running state. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

2017-02-23 Thread anshul1886
Github user anshul1886 commented on the issue: https://github.com/apache/cloudstack/pull/1941 @koushik-das, That PR is still not merged. @karuturi @rhtyd This PR has LGTM now. Can we merge it? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request #1941: CLOUDSTACK-8663: Fixed various issues to allo...

2017-02-23 Thread koushik-das
Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1941#discussion_r102698293 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java --- @@ -1415,6 +1417,10 @@ public VM

[GitHub] cloudstack pull request #1950: [4.10] CLOUDSTACK-9462: Build packages on Ubu...

2017-02-23 Thread wido
Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1950#discussion_r102688184 --- Diff: .gitignore --- @@ -51,7 +51,6 @@ tools/cli/build/ *.jar *.war *.mar -*.zip --- End diff -- Why? Are we adding ZIP

[GitHub] cloudstack pull request #1964: Bug-Id: CLOUDSTACK-9800 Enabled netscaler inl...

2017-02-23 Thread kishankavala
GitHub user kishankavala opened a pull request: https://github.com/apache/cloudstack/pull/1964 Bug-Id: CLOUDSTACK-9800 Enabled netscaler inline mode. Added corresponding changes in UI NetScaler can work in inline mode also along with other Firewall devices. Enabled netscaler

[GitHub] cloudstack pull request #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for K...

2017-02-23 Thread wido
Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1955#discussion_r102687039 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -2059,6 +2060,13 @@ So if getMinSpeed()

[GitHub] cloudstack pull request #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for K...

2017-02-23 Thread wido
Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1955#discussion_r102687113 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -2158,6 +2166,7 @@ public int compare(final

[GitHub] cloudstack pull request #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for K...

2017-02-23 Thread wido
Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1955#discussion_r102687170 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -2216,6 +2225,8 @@ public int compare(final

[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

2017-02-23 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1960 @rhtyd tests looks good, except this one: ``` ERROR: Tests default ha providers list -- Traceback (most

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1768 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-532 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1897: CLOUDSTACK-9733: Concurrent volume snapshots of a VM...

2017-02-23 Thread cloudmonger
Github user cloudmonger commented on the issue: https://github.com/apache/cloudstack/pull/1897 ### ACS CI BVT Run **Sumarry:** Build Number 381 Hypervisor xenserver NetworkType Advanced Passed=104 Failed=1 Skipped=7 _Link to logs Folder

[GitHub] cloudstack pull request #815: CLOUDSTACK-8841: Storage XenMotion from XS 6.2...

2017-02-23 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/815#discussion_r102671303 --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java --- @@ -4717,8 +4717,8 @@ public VirtualMachine migrateVirtualMachineWithVolume(Long

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

2017-02-23 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1958 @abhinandanprateek I think we hit an issue with the test: ``` File "/marvin/tests/smoke/test_over_provisioning.py", line 83, in test_UpdateStorageOverProvisioningFactor

[GitHub] cloudstack issue #815: CLOUDSTACK-8841: Storage XenMotion from XS 6.2 to XS ...

2017-02-23 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/815 @priyankparihar there are lots of failures on Xen62sp1, can you have a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack issue #1914: CLOUDSTACK-9753 - Update L10N resource files with 4....

2017-02-23 Thread milamberspace
Github user milamberspace commented on the issue: https://github.com/apache/cloudstack/pull/1914 @karuturi This is the PR for update le localization files for CS 4.10. I've just updated the PR with the latest translation data from Transifex. Please consider to merge this PR before

[GitHub] cloudstack issue #1955: CLOUDSTACK-8239 Add VirtIO SCSI support for KVM host...

2017-02-23 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1955 @nathanejohnson Thanks, for this good enhancement. Can we have a marvin tests that covers the new functionality? --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-23 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1768 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-23 Thread blueorangutan
Github user blueorangutan commented on the issue: https://github.com/apache/cloudstack/pull/1768 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-02-23 Thread borisstoyanov
Github user borisstoyanov commented on the issue: https://github.com/apache/cloudstack/pull/1813 @priyankparihar can you take a look on the test failures? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1944: CLOUDSTACK-9783: Improve metrics view performance

2017-02-23 Thread rashmidixit
Github user rashmidixit commented on the issue: https://github.com/apache/cloudstack/pull/1944 @rhtyd Will be trying this out today - will post my comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1896: [CLOUDSTACK-9732] Update L10N resource files with 4....

2017-02-23 Thread milamberspace
Github user milamberspace commented on the issue: https://github.com/apache/cloudstack/pull/1896 @karuturi Since master (4.10) use now JSON files for the localization files (and too because on Transifex the localization's resources for each version of CS are different), so this PR