Re: Review Request 12759: CLOUDSTACK-3669: Bringing down the dynamic scalable check (for VM whether it has xstools or vmware tools in it) to the management layer.

2013-07-26 Thread Harikrishna Patnala
:05 a.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12759/ --- (Updated July 25, 2013, 6:05 a.m

Re: Review Request 12809: Fix for CLOUDSTACK-3703: change service offering of stopped vm on kvm is failing

2013-07-26 Thread Harikrishna Patnala
Diff: https://reviews.apache.org/r/12809/diff/ Testing --- Thanks, Harikrishna Patnala

Re: Review Request 12759: CLOUDSTACK-3669: Bringing down the dynamic scalable check (for VM whether it has xstools or vmware tools in it) to the management layer.

2013-07-29 Thread Harikrishna Patnala
server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 56b14cd Diff: https://reviews.apache.org/r/12759/diff/ Testing --- Thanks, Harikrishna Patnala

Review Request 13016: Fix for CLOUDSTACK-3848: Usage events for dynamic scaling of cpu/ram operation on VM

2013-07-29 Thread Harikrishna Patnala
/UserVmManagerImpl.java 0ec296e usage/src/com/cloud/usage/UsageManagerImpl.java 897ffbd Diff: https://reviews.apache.org/r/13016/diff/ Testing --- Tested locally Thanks, Harikrishna Patnala

Re: Review Request 13016: Fix for CLOUDSTACK-3848: Usage events for dynamic scaling of cpu/ram operation on VM

2013-07-30 Thread Harikrishna Patnala
/src/com/cloud/vm/UserVmManagerImpl.java 0ec296e usage/src/com/cloud/usage/UsageManagerImpl.java 897ffbd Diff: https://reviews.apache.org/r/13016/diff/ Testing --- Tested locally Thanks, Harikrishna Patnala

Re: Review Request 13016: Fix for CLOUDSTACK-3848: Usage events for dynamic scaling of cpu/ram operation on VM

2013-07-30 Thread Harikrishna Patnala
: https://reviews.apache.org/r/13016/diff/ Testing --- Tested locally Thanks, Harikrishna Patnala

Review Request 13102: CLOUDSTACK-3969: Upgrade failed from 3.0.3 to 4.2 in KVM host with error 4.2.0 KVM SystemVm template not found though systemvm-kvm-4.2 template is uploaded during 3.0.3 setup

2013-07-31 Thread Harikrishna Patnala
to '=' while searching for new system template. Diffs - engine/schema/src/com/cloud/upgrade/dao/Upgrade410to420.java 13074cf Diff: https://reviews.apache.org/r/13102/diff/ Testing --- Thanks, Harikrishna Patnala

Review Request 13107: CLOUDSTACK-2717: Adding optional parameter accuntid to listCapabilities API

2013-07-31 Thread Harikrishna Patnala
for Admin/user Thanks, Harikrishna Patnala

Re: Review Request 13107: CLOUDSTACK-2717: Adding optional parameter accuntid to listCapabilities API

2013-07-31 Thread Harikrishna Patnala
. Diffs (updated) - server/src/com/cloud/server/ManagementServerImpl.java 26efa10 Diff: https://reviews.apache.org/r/13107/diff/ Testing --- Tested locally by firing listcapabilities API call for Admin/user Thanks, Harikrishna Patnala

Review Request 13188: CLOUDSTACK-3042: handle System VM Scaling up of memory/CPU based on the presence of tools in the template

2013-08-01 Thread Harikrishna Patnala
/VirtualNetworkApplianceManagerImpl.java 3ee8a1c server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java 6859b0b Diff: https://reviews.apache.org/r/13188/diff/ Testing --- Tested locally Thanks, Harikrishna Patnala

Re: upgrade path 4.1.1 - 4.2/master

2013-08-01 Thread Harikrishna Patnala
http://jenkins.cloudstack.org/view/master/job/build-systemvm-master/ thanks, Daan On Thu, Aug 1, 2013 at 3:16 PM, Harikrishna Patnala harikrishna.patn...@citrix.com wrote: Hi Daan, Before upgrading to 4.2 we need to register the new system templates for each hypervisor with specific

Re: [4.1] getVMPassword how to decrypt

2013-08-01 Thread Harikrishna Patnala
Yes the password is encrypted with public key of ssh key pair assigned to the guest VM during deployment. We can decrypt it using the private key of that key pair. -Harikrishna On 01-Aug-2013, at 3:13 AM, Chiradeep Vittal chiradeep.vit...@citrix.commailto:chiradeep.vit...@citrix.com wrote:

Re: upgrade path 4.1.1 - 4.2/master

2013-08-01 Thread Harikrishna Patnala
the templates outside cloudstack somehow? (and promise I will never do it again) On Thu, Aug 1, 2013 at 4:43 PM, Harikrishna Patnala harikrishna.patn...@citrix.com wrote: My comments inline. Thanks Harikrishna On 01-Aug-2013, at 7:05 PM, Daan Hoogland daan.hoogl...@gmail.com wrote: Harikrishna

Re: Review Request 12358: CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen and kvm

2013-08-05 Thread Harikrishna Patnala
/ConsoleProxyManagerImpl.java 7c6fbd0 server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java b10fb7a Diff: https://reviews.apache.org/r/12358/diff/ Testing --- tested locally Thanks, Harikrishna Patnala

Review Request 13322: CLOUDSTACK-4070: upgrade from 2.2.14 to 4.2 is failing with 4.0 VMware SystemVm template not found. Cannot upgrade system Vms

2013-08-06 Thread Harikrishna Patnala
cluster and new system template registered in 2.2.14 setup and upgraded to 4.2. vm_template and vm_instance tables are getting updated as expected. Thanks, Harikrishna Patnala

Review Request 23547: CLOUDSTACK-7113: Ability to reset password when Router VM is stopped

2014-07-16 Thread Harikrishna Patnala
and restoreVM Diffs - server/src/com/cloud/network/element/VirtualRouterElement.java 3b3cacd server/src/com/cloud/vm/UserVmManagerImpl.java dac4acf Diff: https://reviews.apache.org/r/23547/diff/ Testing --- Thanks, Harikrishna Patnala

Re: changing cpu.overprovisioning.factor

2014-07-17 Thread Harikrishna Patnala
Please create a doc bug only for two parameters cpu and memory overprovisioning factors. Because for the remaining parameters till the value is defined at granular level, CS uses the value at global level. So in your case if it would have some parameter other than cpu and memory over

Re: What to modify to increase instance password length?

2014-07-18 Thread Harikrishna Patnala
Hi Ian, The commit was made only in 4.4 and not in master. Can you cherry pick the same to master. Thanks, Harikrishna On 26-Jun-2014, at 12:23 am, Ian Duffy i...@ianduffy.ie wrote: Just pushed a change for this to the 4.4-forward branch. Daan, will you review / cherrypick?

Re: What to modify to increase instance password length?

2014-07-20 Thread Harikrishna Patnala
. Will get on this tomorrow away from a computer for the weekend. On 18 Jul 2014 13:36, Harikrishna Patnala harikrishna.patn...@citrix.commailto:harikrishna.patn...@citrix.com wrote: Hi Ian, The commit was made only in 4.4 and not in master. Can you cherry pick the same to master. Thanks

Re: [ANNOUNCE] Rajani Karuturi as committer

2014-07-22 Thread Harikrishna Patnala
Congratulations Rajani :) -Harikrishna On 22-Jul-2014, at 12:11 pm, Punith S punit...@cloudbyte.com wrote: Congrats Rajani :) cheers! On Tue, Jul 22, 2014 at 12:04 PM, Suresh Sadhu suresh.sa...@citrix.com wrote: Congrats Rajani. -Original Message- From: Shweta Agarwal

Review Request 23837: CLOUDSTACK-7087: Downgrade openswan to previous version for VPN services to fix OSX client

2014-07-23 Thread Harikrishna Patnala
/systemvm64template/postinstall.sh 5ce0163 tools/appliance/definitions/systemvmtemplate/postinstall.sh 822cd5f Diff: https://reviews.apache.org/r/23837/diff/ Testing --- Thanks, Harikrishna Patnala

Re: Review Request 23837: CLOUDSTACK-7087: Downgrade openswan to previous version for VPN services to fix OSX client

2014-08-05 Thread Harikrishna Patnala
/appliance/definitions/systemvm64template/postinstall.sh 5ce0163 tools/appliance/definitions/systemvmtemplate/postinstall.sh 822cd5f Diff: https://reviews.apache.org/r/23837/diff/ Testing --- Thanks, Harikrishna Patnala

Re: Review Request 23837: CLOUDSTACK-7087: Downgrade openswan to previous version for VPN services to fix OSX client

2014-08-05 Thread Harikrishna Patnala
) - tools/appliance/definitions/systemvm64template/postinstall.sh 8763a9f tools/appliance/definitions/systemvmtemplate/postinstall.sh 587d44d Diff: https://reviews.apache.org/r/23837/diff/ Testing --- Thanks, Harikrishna Patnala

Re: [PROPOSAL] Solving the cherry-picking problem

2014-08-07 Thread Harikrishna Patnala
Hi Rohit, Thanks for the proposal. I’ve some concerns. If we work directly on release branch only (with out forward branch) I’m not sure how we control regressions in the release time. In case of forward branch cut from the release branch RMs will merge only critical bug fixes to release

Re: [DISCUSS] Removing template URL format checking logic

2014-08-10 Thread Harikrishna Patnala
Hi Rohit, This was already fixed for templates https://issues.apache.org/jira/browse/CLOUDSTACK-6940 We have to do the same for registering ISOs as well. Thanks, Harikrishna On 08-Aug-2014, at 11:20 pm, Rohit Yadav rohit.ya...@shapeblue.com wrote: Hi, With reference to

Re: Review Request 17941: CLOUDSTACK-6075: Increase the ram size for router service offering

2014-08-11 Thread Harikrishna Patnala
/router/VirtualNetworkApplianceManager.java 85ce8b9 setup/db/db/schema-441to450.sql 34d5f88 Diff: https://reviews.apache.org/r/17941/diff/ Testing --- tested locally Thanks, Harikrishna Patnala

Review Request 24549: CLOUDSTACK-7305: hypervisor type parameter is mandatory when deploying VM using ISO

2014-08-11 Thread Harikrishna Patnala
- api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 8ceccb9 server/src/com/cloud/vm/UserVmManagerImpl.java 05cc183 Diff: https://reviews.apache.org/r/24549/diff/ Testing --- Thanks, Harikrishna Patnala

Re: Review Request 24549: CLOUDSTACK-7305: hypervisor type parameter is mandatory when deploying VM using ISO

2014-08-12 Thread Harikrishna Patnala
when deploying VM using ISO Diffs - api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java 8ceccb9 server/src/com/cloud/vm/UserVmManagerImpl.java 05cc183 Diff: https://reviews.apache.org/r/24549/diff/ Testing --- Thanks, Harikrishna Patnala

Review Request 24646: CLOUDSTACK-7337: Volume state remains in allocated after volume creation faliure from snapshot

2014-08-13 Thread Harikrishna Patnala
/cloud/storage/VolumeApiServiceImpl.java 8d83225b5109ceb577d788e8fe931a8e45a84286 Diff: https://reviews.apache.org/r/24646/diff/ Testing --- Thanks, Harikrishna Patnala

Re: Review Request 24646: CLOUDSTACK-7337: Volume state remains in allocated after volume creation faliure from snapshot

2014-08-20 Thread Harikrishna Patnala
faliure. Diffs (updated) - server/src/com/cloud/storage/VolumeApiServiceImpl.java 8d83225 Diff: https://reviews.apache.org/r/24646/diff/ Testing --- Thanks, Harikrishna Patnala

Re: Review Request 24646: CLOUDSTACK-7337: Volume state remains in allocated after volume creation faliure from snapshot

2014-08-20 Thread Harikrishna Patnala
faliure. Diffs - server/src/com/cloud/storage/VolumeApiServiceImpl.java 8d83225 Diff: https://reviews.apache.org/r/24646/diff/ Testing (updated) --- Tested manually and validated my changes using simulator Thanks, Harikrishna Patnala

Re: Unable to start a VM due to insufficient capacity

2014-09-02 Thread Harikrishna Patnala
You can use http://pastebin.com/ to upload the logs and provide the link. -Harikrishna On 02-Sep-2014, at 10:06 am, Giri Prasad g_p...@yahoo.com.INVALID wrote: Thanks. The error occurs at line 20400th line in the management server log. Please let me know, where I can upload these 20400

Re: [ACS431] Help testing 4.3.1 vote candidate

2014-09-05 Thread Harikrishna Patnala
Yes the available 4.3 system vm templates on jenkins are post heart bleed. -Harikrishna On 05-Sep-2014, at 12:59 pm, Sebastien Goasguen run...@gmail.commailto:run...@gmail.com wrote: On Sep 4, 2014, at 5:25 PM, Rohit Yadav rohit.ya...@shapeblue.commailto:rohit.ya...@shapeblue.com wrote:

Re: [BLOCKED] Management server not starting

2014-09-24 Thread Harikrishna Patnala
This is fixed by reverting the commit 093fa6f0a53bd031a09e4042c3aa25860bc947e5 https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=2503aaafef5280ce20e319c77623f9709d85151a MS is now starting with no issues. -Harikrishna On 24-Sep-2014, at 2:25 pm, Alex Brett

Review Request 26171: CLOUDSTACK-7655: Fixing system vm template to build from newer debian iso links

2014-09-30 Thread Harikrishna Patnala
/systemvmtemplate/postinstall.sh dc3d130 tools/appliance/definitions/systemvmtemplate64/definition.rb 713ee75 tools/appliance/definitions/systemvmtemplate64/postinstall.sh a330cea Diff: https://reviews.apache.org/r/26171/diff/ Testing --- Thanks, Harikrishna Patnala

Re: Review Request 26171: CLOUDSTACK-7655: Fixing system vm template to build from newer debian iso links

2014-09-30 Thread Harikrishna Patnala
--- Thanks, Harikrishna Patnala

Review Request 26173: CLOUDSTACK-7658: Upgrading debian packages as part of system vm template build

2014-09-30 Thread Harikrishna Patnala
/definitions/systemvm64template/postinstall.sh 80cedc0 tools/appliance/definitions/systemvmtemplate/postinstall.sh 81d4f86 Diff: https://reviews.apache.org/r/26173/diff/ Testing --- Thanks, Harikrishna Patnala

Re: Review Request 26173: CLOUDSTACK-7658: Upgrading debian packages as part of system vm template build

2014-09-30 Thread Harikrishna Patnala
always. Diffs (updated) - tools/appliance/definitions/systemvm64template/postinstall.sh 80cedc0 tools/appliance/definitions/systemvmtemplate/postinstall.sh 81d4f86 Diff: https://reviews.apache.org/r/26173/diff/ Testing --- Thanks, Harikrishna Patnala

Review Request 26361: CLOUDSTACK-7660: Enhance system vm template to support baremetal

2014-10-06 Thread Harikrishna Patnala
/patches/debian/buildsystemvm.sh 7f6188a tools/appliance/definitions/systemvmtemplate/preseed.cfg 0d2f70b Diff: https://reviews.apache.org/r/26361/diff/ Testing --- Thanks, Harikrishna Patnala

Re: Review Request 26361: CLOUDSTACK-7660: Enhance system vm template to support baremetal

2014-10-06 Thread Harikrishna Patnala
the merging part of disk partitions. Diffs - systemvm/patches/debian/buildsystemvm.sh 7f6188a tools/appliance/definitions/systemvmtemplate/preseed.cfg 0d2f70b Diff: https://reviews.apache.org/r/26361/diff/ Testing --- Thanks, Harikrishna Patnala

Review Request 26408: CLOUDSTACK-7677: 4.2 systemvm template job failing

2014-10-07 Thread Harikrishna Patnala
://reviews.apache.org/r/26408/diff/ Testing --- Thanks, Harikrishna Patnala

Re: Review Request 23837: CLOUDSTACK-7087: Downgrade openswan to previous version for VPN services to fix OSX client

2014-10-07 Thread Harikrishna Patnala
(updated) - tools/appliance/definitions/systemvmtemplate/postinstall.sh 51006c9 tools/appliance/definitions/systemvmtemplate64/postinstall.sh 515348c Diff: https://reviews.apache.org/r/23837/diff/ Testing --- Thanks, Harikrishna Patnala

[ACS 4.4] cherry-pick request for CLOUDSTACK-6463 and CLOUDSTACK-6466

2014-05-05 Thread Harikrishna Patnala
Hi Daan, Could you cherry pick the following commits to 4.4 branch 1) Commit ce3074e9a23e71855798cb5decd01d7f9958f6c0 in cloudstack's branch refs/heads/4.4-forward [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ce3074e ] CLOUDSTACK-6463: password is not set for VMs created from

Review Request 21195: CLOUDSTACK-6544: [Automation] Failed to create template for ROOT volume in Xen, with Exception: callHostPlugin failed

2014-05-11 Thread Harikrishna Patnala
- scripts/vm/hypervisor/xenserver/xenserver62/patch 13f4f93 Diff: https://reviews.apache.org/r/21195/diff/ Testing --- Thanks, Harikrishna Patnala

Re: CLOUDSTACK-6551 should be closed?

2014-05-14 Thread Harikrishna Patnala
Hi Daan, These kind of errors come when there is no function defined with name revert_memory_snapshot in vmopsSnapshot plugin. Rayees, may I know the Xenserver version, is that XenServer 6.2 Fox ? In that case cloud-plugin-storage” plugin is being called where “revert_memory_snapshot” is not

Re: Review Request 21196: CLOUDSTACK-6551: [Automation] Failed to revert vm snapshot in xen

2014-05-15 Thread Harikrishna Patnala
/hypervisor/xenserver/xenserver62/cloud-plugin-storage 03a05b7 Diff: https://reviews.apache.org/r/21196/diff/ Testing --- Thanks, Harikrishna Patnala

Re: Review Request 21196: CLOUDSTACK-6551: [Automation] Failed to revert vm snapshot in xen

2014-05-15 Thread Harikrishna Patnala
) - plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/Xenserver625Resource.java d290194 Diff: https://reviews.apache.org/r/21196/diff/ Testing --- Thanks, Harikrishna Patnala

Re: CLOUDSTACK-6544 [Automation] Failed to create template for ROOT volume in Xen, with Exception: callHostPlugin failed

2014-05-15 Thread Harikrishna Patnala
Hi Daan, Both the issues CLOUDSTACK-6544 and CLOUDSTACK-6551 are related to Xenserver 6.2 Fox version. I’ll fix them by tomorrow. Thanks Harikrishna On 07-May-2014, at 4:41 pm, Daan Hoogland daan.hoogl...@gmail.com wrote: Harikrishna, Do you have an idea on a solutions for this issue,

Review Request 21805: CLOUDSTACK-6748: Creating an instance with user-data when network doesn't support user-data should error

2014-05-22 Thread Harikrishna Patnala
Diff: https://reviews.apache.org/r/21805/diff/ Testing --- Thanks, Harikrishna Patnala

Review Request 21924: [Automation]Fixed Regression issues in Xenserver and KVM runs

2014-05-27 Thread Harikrishna Patnala
/diff/ Testing --- Thanks, Harikrishna Patnala

Re: Review Request 21924: [Automation]Fixed issues in Xenserver and KVM runs

2014-05-27 Thread Harikrishna Patnala
/test_scale_vm.py f0ec534 test/integration/smoke/test_secondary_storage.py 90304b3 Diff: https://reviews.apache.org/r/21924/diff/ Testing --- Thanks, Harikrishna Patnala

Re: Review Request 21924: [Automation] Disabling the failed test cases in XenServer and KVM runs

2014-05-27 Thread Harikrishna Patnala
/test_primary_storage.py 3147d86 test/integration/smoke/test_scale_vm.py f0ec534 test/integration/smoke/test_secondary_storage.py 90304b3 Diff: https://reviews.apache.org/r/21924/diff/ Testing --- Thanks, Harikrishna Patnala

Review Request 21971: [Automation] Disabling the failed test cases in Xenserver and KVM runs

2014-05-28 Thread Harikrishna Patnala
integration.smoke.test_iso - CLOUDSTACK-6769, CLOUDSTACK-6774 Diffs - test/integration/smoke/test_iso.py 93f436f Diff: https://reviews.apache.org/r/21971/diff/ Testing --- Thanks, Harikrishna Patnala

Re: Review Request 21971: [Automation] Disabling the failed test cases in Xenserver and KVM runs

2014-05-28 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21971/#review44100 --- On May 28, 2014, 6:14 a.m., Harikrishna Patnala wrote

RE: Cpu, cpu speed and memory in usage records

2014-06-04 Thread Harikrishna Patnala
: Tuesday, June 03, 2014 8:54 PM To: dev@cloudstack.apache.org Cc: Harikrishna Patnala; Kishan Kavala Subject: Cpu, cpu speed and memory in usage records Hi, Is it normal if CloudStack does not return usage details (cpu cores, cpu speed and memory) in the usage records? Since the introduction of dynamic

Re: Cpu, cpu speed and memory in usage records

2014-06-05 Thread Harikrishna Patnala
Harikrishna for your answer. I created a ticket for this (CLOUDSTACK-6880 [1]). I can submit a review request for this issue, but I cannot assign the issue to myself on Jira. -- Olivier [1] https://issues.apache.org/jira/browse/CLOUDSTACK-6850 On Wed, Jun 4, 2014 at 10:55 AM, Harikrishna Patnala

Re: ssh keypair value overridden by template meta data

2014-06-09 Thread Harikrishna Patnala
Hi Hiroki, We should not override the ssh key pair provided in the deployVM API with the ssh key in template metadata. I just able to reproduce this. Please create a ticket for this issue. Thanks Harikrishna On 06-Jun-2014, at 5:18 pm, Hiroki Ohashi hiroki.s...@gmail.com wrote: Dear guys

Re: ssh keypair value overridden by template meta data

2014-06-09 Thread Harikrishna Patnala
/CLOUDSTACK-6869 Please confirm it. Best Regards 2014-06-09 15:59 GMT+09:00 Harikrishna Patnala harikrishna.patn...@citrix.com: Hi Hiroki, We should not override the ssh key pair provided in the deployVM API with the ssh key in template metadata. I just able to reproduce

Review Request 22456: CLOUDSTACK-6869: Public key content is overridden by template's meta data when you create a instance

2014-06-11 Thread Harikrishna Patnala
/com/cloud/vm/UserVmManagerImpl.java 14d2eef Diff: https://reviews.apache.org/r/22456/diff/ Testing --- Thanks, Harikrishna Patnala

[ACS-4.4] Cherry-pick request

2014-06-11 Thread Harikrishna Patnala
Hi Daan, Can you please cherry-pick the following commit to 4.4 branch Commit aa75b4388554a502b1073dd78050cd4b364a803e in cloudstack's branch refs/heads/4.4-forward from Harikrishna Patnala [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=aa75b43 ] CLOUDSTACK-6869: SSH Public key

Review Request 22613: CLOUDSTACK-6912: 4.2 32 bit system vm template job failing in jenkins

2014-06-16 Thread Harikrishna Patnala
--- Thanks, Harikrishna Patnala

Re: What to modify to increase instance password length?

2014-06-25 Thread Harikrishna Patnala
It is better to use ConfigKey class to define configuration parameters, this handles default values in case of NULL or db entry missing and no need to put in upgrade script. static final ConfigKeyLong CustomDiskOfferingMaxSize = new ConfigKeyLong(Advanced, Long.class,

Re: [ANNOUNCE] Santhosh Edukulla as a committer...

2014-06-30 Thread Harikrishna Patnala
Congratulations Santosh. On 01-Jul-2014, at 1:16 am, Animesh Chaturvedi animesh.chaturv...@citrix.com wrote: Congrats Santhosh -Original Message- From: Alex Huang [mailto:alex.hu...@citrix.com] Sent: Monday, June 30, 2014 9:25 AM To: dev@cloudstack.apache.org Subject:

Re: createTemplate API lacks sshkeyenabled?

2014-07-02 Thread Harikrishna Patnala
sshkeyenabled flag is no where used in the code. So even if sshkeyenabled flag is set false we send the SSH public key to VR. IMHO there is no need of this flag, if a user wants to set SSH key to VM, ssh key ( “keypair param ) is passed while deploying the VM and CS sends the same to VR.

Review Request: CLOUDSTACK-1830: ZWPS: NPE while create volume from snapshot

2013-04-02 Thread Harikrishna Patnala
- engine/storage/src/org/apache/cloudstack/storage/allocator/ZoneWideStoragePoolAllocator.java c45f8a8 Diff: https://reviews.apache.org/r/10239/diff/ Testing --- Thanks, Harikrishna Patnala

[DISCUSS] Granular Global Parameters

2013-04-10 Thread Harikrishna Patnala
Hi all, There are many global parameters which are used to set values/limits/boolean for various operations, but these parameters effects all zones/clusters/accounts/storage based on the parameter. Here I would like to discuss on granulising these parameters so that these parameters can be

Re: [DISCUSS] Granular Global Parameters

2013-04-15 Thread Harikrishna Patnala
, Harikrishna Patnala harikrishna.patn...@citrix.commailto:harikrishna.patn...@citrix.com wrote: Hi all, There are many global parameters which are used to set values/limits/boolean for various operations, but these parameters effects all zones/clusters/accounts/storage based on the parameter. Here

Review Request: CLOUDSTACK-741: Granular Global Parameters

2013-04-16 Thread Harikrishna Patnala
--- Tested locally - tested the modified UpdateConfiguration API and ListConfiguration API by providing the zone scope and zone id - tested the modified parameter to take the updated value at zone level(after updation). Thanks, Harikrishna Patnala

Re: Review Request: CLOUDSTACK-741: Granular Global Parameters

2013-04-16 Thread Harikrishna Patnala
://reviews.apache.org/r/10548/diff/ Testing --- Tested locally - tested the modified UpdateConfiguration API and ListConfiguration API by providing the zone scope and zone id - tested the modified parameter to take the updated value at zone level(after updation). Thanks, Harikrishna Patnala

Re: Review Request: CLOUDSTACK-741: Granular Global Parameters

2013-04-17 Thread Harikrishna Patnala
level(after updation). Thanks, Harikrishna Patnala

Re: Review Request: CLOUDSTACK-741: Granular Global Parameters

2013-04-18 Thread Harikrishna Patnala
the modified UpdateConfiguration API and ListConfiguration API by providing the zone scope and zone id - tested the modified parameter to take the updated value at zone level(after updation). Thanks, Harikrishna Patnala

Re: Review Request: CLOUDSTACK-741: Granular Global Parameters

2013-04-18 Thread Harikrishna Patnala
and ListConfiguration API by providing the zone scope and zone id - tested the modified parameter to take the updated value at zone level(after updation). Thanks, Harikrishna Patnala

Review Request: CLOUDSTACK-2180: restoreVirtualMachine returns no password if the template is password enabled

2013-04-25 Thread Harikrishna Patnala
/UserVmService.java 7e89cd3 server/src/com/cloud/vm/UserVmManagerImpl.java ebc5757 server/test/com/cloud/vm/MockUserVmManagerImpl.java d886fd8 server/test/com/cloud/vm/UserVmManagerTest.java e5e2ff2 Diff: https://reviews.apache.org/r/10772/diff/ Testing --- Thanks, Harikrishna Patnala

Re: Review Request: CLOUDSTACK-2180: restoreVirtualMachine returns no password if the template is password enabled

2013-04-25 Thread Harikrishna Patnala
--- Thanks, Harikrishna Patnala

Re: Review Request: (CLOUDSTACK-1325) add password in response of RestoreVM

2013-04-25 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9539/#review19694 --- Ship it! Ship It! - Harikrishna Patnala On April 2, 2013, 1:24

Re: Review Request: (CLOUDSTACK-1325) add password in response of RestoreVM

2013-04-25 Thread Harikrishna Patnala
On April 25, 2013, 8:55 a.m., Harikrishna Patnala wrote: Ship It! Not a right time to give comments but came across a difference when comparing with my patch on master. we need to load vm details _vmDao.loadDetails(vm) before getting the details vm.getDetail(SSH.PublicKey). since details

Re: Review Request: Adding more Granular Global Parameters

2013-04-25 Thread Harikrishna Patnala
/integration/smoke/test_global_settings.py 12b35d7 Diff: https://reviews.apache.org/r/10740/diff/ Testing --- Thanks, Harikrishna Patnala

Re: Review Request: Adding more Granular Global Parameters

2013-04-25 Thread Harikrishna Patnala
/test_global_settings.py 12b35d7 Diff: https://reviews.apache.org/r/10740/diff/ Testing --- Thanks, Harikrishna Patnala

Re: Review Request: Adding more Granular Global Parameters

2013-04-29 Thread Harikrishna Patnala
--- Thanks, Harikrishna Patnala

Review Request: Fixing network.throttling.rate to work per zone in case of vmware

2013-05-02 Thread Harikrishna Patnala
--- Fixing network.throttling.rate to work per zone in case of vmware This addresses bug CLOUDSTACK-741. Diffs - server/src/com/cloud/network/NetworkModelImpl.java 7b712ea Diff: https://reviews.apache.org/r/10902/diff/ Testing --- Tested in VMWare setup. Thanks, Harikrishna Patnala

Review Request: fix for CLOUDSTACK-2146: scaling up system vm failed.

2013-05-03 Thread Harikrishna Patnala
/MockUserVmManagerImpl.java 22bbbe8 Diff: https://reviews.apache.org/r/10914/diff/ Testing --- Tested scaling up both user vms and system vms. Thanks, Harikrishna Patnala

Review Request: CLOUDSTACK-658: Scaling up CPU and RAM for running VMs - Vmware

2013-05-09 Thread Harikrishna Patnala
Diff: https://reviews.apache.org/r/11025/diff/ Testing --- Tested locally by scaling the vm to an higher service offering. Thanks, Harikrishna Patnala

Re: Review Request: Fix test_global_settings.py which is checking for the wrong global setting

2013-05-09 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11006/#review20414 --- Ship it! Ship It! - Harikrishna Patnala On May 8, 2013, 9:15

RE: Review Request: (CLOUDSTACK-1325) add password in response of RestoreVM

2013-05-13 Thread Harikrishna Patnala
Chip, can you push this patch on 4.0.1, this patch is specific to 4.0.1. I have already pushed the similar patch on master. Thankyou From: Animesh Chaturvedi Sent: Friday, May 10, 2013 4:49 AM To: dev@cloudstack.apache.org; Prasanna Santhanam; Harikrishna Patnala

Re: Review Request: Fix for CLOUDSTACK-2085 VM weight on xen remain same as before vmscaleup

2013-05-15 Thread Harikrishna Patnala
/xenserver56fp1/patch d20e60f scripts/vm/hypervisor/xenserver/xenserver60/patch c9125f4 Diff: https://reviews.apache.org/r/10903/diff/ Testing --- Tested: tried scaling up a vm and checked on xenserver for the new values. Thanks, Harikrishna Patnala

Review Request: Fix for CLOUDSTACK-2354 Unable to create Windows VMs using ISO

2013-05-17 Thread Harikrishna Patnala
locally for guest vms and system vms Thanks, Harikrishna Patnala

Re: Review Request: Fix for CLOUDSTACK-2354 Unable to create Windows VMs using ISO

2013-05-17 Thread Harikrishna Patnala
://reviews.apache.org/r/11216/diff/ Testing --- Tested locally for guest vms and system vms Thanks, Harikrishna Patnala

Re: Review Request: Fix for CLOUDSTACK-2085 VM weight on xen remain same as before vmscaleup

2013-05-19 Thread Harikrishna Patnala
://reviews.apache.org/r/10903/#review20743 --- On May 15, 2013, 10:06 a.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request: Fix for CLOUDSTACK-2085 VM weight on xen remain same as before vmscaleup

2013-05-20 Thread Harikrishna Patnala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10903/#review20743 --- On May 15, 2013, 10:06 a.m., Harikrishna Patnala wrote

Re: [ANNOUNCE] New committer: Venkata Swamy

2013-05-23 Thread Harikrishna Patnala
Congrats :) On 24-May-2013, at 10:36 AM, Abhinandan Prateek cloudst...@aprateek.com wrote: Congrats Swamy and Sailaja ! On 24/05/13 10:24 AM, Saksham Srivastava saksham.srivast...@citrix.com wrote: Congrats Swamy. On Friday 24 May 2013 02:51 AM, Chip Childers wrote: The Project

Re: Review Request: CLOUDSTACK-1453: support restore for VM created from ISO

2013-05-23 Thread Harikrishna Patnala
/UserVmManagerTest.java 6a97114 Diff: https://reviews.apache.org/r/9779/diff/ Testing --- tested locally Thanks, Harikrishna Patnala

Re: Review Request: CLOUDSTACK-1453: support restore for VM created from ISO

2013-05-23 Thread Harikrishna Patnala
generated e-mail. To reply, visit: https://reviews.apache.org/r/9779/#review18578 --- On May 24, 2013, 5:52 a.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail

Re: [ANNOUNCE] New committer: Sailaja Mada

2013-05-23 Thread Harikrishna Patnala
Congratulations Sailaja :) On 24-May-2013, at 11:23 AM, Suresh Sadhu suresh.sa...@citrix.com wrote: Congrats Sailaja. On 5/23/13 2:20 PM, Chip Childers chip.child...@sungard.com wrote: The Project Management Committee (PMC) for Apache CloudStack has asked Sailaja Mada to become a

Re: [ANNOUNCE] New committer: Wei Zhou

2013-05-24 Thread Harikrishna Patnala
Congratulations Wei Zhou :) On 24-May-2013, at 11:42 AM, Sebastien Goasguen run...@gmail.com wrote: Great work Wei ! On May 24, 2013, at 1:22 AM, Bharat Kumar bharat.ku...@citrix.com wrote: Congrats Wei! On May 24, 2013, at 3:00 AM, Chip Childers chip.child...@sungard.com wrote:

Re: Review Request: CLOUDSTACK-1453: support restore for VM created from ISO

2013-05-24 Thread Harikrishna Patnala
/UserVmManagerTest.java 6a97114 Diff: https://reviews.apache.org/r/9779/diff/ Testing --- tested locally Thanks, Harikrishna Patnala

Review Request: Fix for CLOUDSTACK-2672: Adding isVolatile parameter in service offering response object

2013-05-24 Thread Harikrishna Patnala
/ServiceOfferingJoinDaoImpl.java ce20562 server/src/com/cloud/api/query/vo/ServiceOfferingJoinVO.java 598e1d1 setup/db/db/schema-410to420.sql 442a544 Diff: https://reviews.apache.org/r/11373/diff/ Testing --- Tested locally Thanks, Harikrishna Patnala

Re: Review Request: Fix for CLOUDSTACK-2672: Adding isVolatile parameter in service offering response object

2013-05-27 Thread Harikrishna Patnala
https://reviews.apache.org/r/11373/#comment43565 It cannot be null as serviceofferingJoinVO is populated from service offering table and while creating service offering entry we set to false if the isVolatile is null. - Harikrishna Patnala On May 24, 2013, 12:22 p.m

Re: Review Request: Fix for CLOUDSTACK-2672: Adding isVolatile parameter in service offering response object

2013-05-27 Thread Harikrishna Patnala
://reviews.apache.org/r/11373/#review21060 --- On May 24, 2013, 12:22 p.m., Harikrishna Patnala wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: 4.3 gets the wrong number of CPU sockets

2014-03-03 Thread Harikrishna Patnala
Hi, In case of KVM we read the socket count from the parameter ‘sockets’ in NodeInfo class. Can you check with the command “virsh nodeinfo” ? How many cores do you have per cpu ? Thanks Harikrishna On 02-Mar-2014, at 7:50 pm, Nux! n...@li.nux.ro wrote: Hello, Which script is

Re: [Proposal] Virtual Router service failure alerting

2014-03-04 Thread Harikrishna Patnala
:57 AM, Harikrishna Patnala harikrishna.patn...@citrix.commailto:harikrishna.patn...@citrix.com wrote: Hi Sheng, Thank you for the corrections and suggestions. My comments inline. On 14-Feb-2014, at 1:53 am, Sheng Yang sh...@yasker.orgmailto:sh...@yasker.orgmailto:sh...@yasker.org wrote: Hi Hari

<    1   2   3   4   5   >