[GitHub] cloudstack issue #1681: CLOUDSTACK-9491: incorrect parsing of device list to...

2016-10-31 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1681 @rhtyd could you check into the status of the test run for this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1680: CLOUDSTACK-9498: VR CsFile search utility methods fa...

2016-10-31 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1680 @blueorangutan test centos6 vmware55u3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1676: CLOUDSTACK-9502: DS template copies don’t get dele...

2016-10-31 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1676 @rhtyd can you check into the status of the test run? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1678: CLOUDSTACK-9503: Increased the VR script timeout. Mo...

2016-10-31 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1678 @abhinandanprateek this fix seems like a good fix for 4.8 users as well which I would like to get included in 4.8.2.0, as well as, 4.9.1.0 and 4.10.0.0. Could rebase this PR and change

[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

2016-10-31 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1545 @wido I would like to get this PR merged for 4.10.0.0. Could you please rebase to resolve conflicts and pick up the latest Marvin enhancements/fixes? Once this rebase is done, I will kick

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

2016-10-31 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1542 @nvazquez I would like to get this PR merged for 4.10.0.0. Could you please rebase this PR to pull the latest Marvin enhancements/fixes? Once that is done, I will kick off a regression test

[GitHub] cloudstack issue #1674: CLOUDSTACK-9460: For long running transactions, if t...

2016-10-31 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1674 @rhtyd this issue impacts any user with long-running secondary storage jobs. I think it is a valuable fix for all users as the only recourse to fix these errors is to manually cleanup

[GitHub] cloudstack issue #1580: CLOUDSTACK-9402 : Support for underlay features (Sou...

2016-10-31 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1580 @nlivens I would like to get this PR merged for 4.10.0.0. I will code review in the next few days. In the meantime, please rebase this PR to pick up the latest Marvin enhancements/fixes

[GitHub] cloudstack issue #1579: CLOUDSTACK-9403 : Support for shared networks in Nua...

2016-10-31 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1579 @nlivens I would like to get this PR merged for 4.10.0.0. I will code review in the next few days. In the meantime, please rebase this PR to pick up the latest Marvin enhancements/fixes

[GitHub] cloudstack issue #1577: CLOUDSTACK-9321 : Multiple Internal LB rules (more t...

2016-10-31 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1577 @nlivens I would like to get this PR merged for 4.10.0.0. I will code review in the next few days. In the meantime, please rebase this PR to pick up the latest Marvin enhancements/fixes

[GitHub] cloudstack issue #1578: CLOUDSTACK-9401 : Support for Internal DNS in Nuage ...

2016-10-31 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1578 @nlivens I would like to get this PR into 4.10.0.0. Could you please squash the commits? Once this is done, I will trigger a regression test across VMware, KVM, and XenServer. --- If your

[GitHub] cloudstack issue #1676: CLOUDSTACK-9502: DS template copies don’t get dele...

2016-10-31 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1676 @nvazquez kicking regression tests now. If they pass, then I will add my LGTM and merge. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1676: CLOUDSTACK-9502: DS template copies don’t get dele...

2016-10-31 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1676 @blueorangutan test centos6 vmware55u3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

2016-10-30 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1600 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

2016-10-30 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1600 @mike-tutkowski I will kick off regression tests now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1607: SSVM downloader now handles redirects properly.

2016-10-28 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1607 @ProjectMoon this seems like a really good fix for LTS users as well. Could you please rebase and change the base branch to 4.9? --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1655: Fix ajaxviewer.js to solve console on Firefox

2016-10-28 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1655 @lygutas ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1662: Fix bug juniper srx

2016-10-28 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1662 @digitalgust ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1675: CLOUDSTACK-9453: WIP

2016-10-28 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1675 @abhi can this PR be closed in favor of #1639? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1713: CLOUDSTACK-9552: Allow egress TCP/53 implicitly in B...

2016-10-28 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1713 @wido this fix seems like a great thing for LTS. Would it be possible for you to change the base branch to 4.9? --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack issue #1678: CLOUDSTACK-9503: Increased the VR script timeout. Mo...

2016-10-28 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1678 @blueorangutan test centos6 kvm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1711: Xenserver7 Support

2016-10-26 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1711 @syed +1 -- I would like to see a full component test run for this PR on XS 7 and smoke tests for XS 6.5. Also, we might want to consider a PR for 4.9 and then another PR for master like we

[GitHub] cloudstack issue #1711: Xenserver7 Support

2016-10-26 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1711 @syed given that XenServer 6.5 doesn't run on newer hardware, XenServer users don't have a realistic LTS release. Therefore, I propose that this PR be targeted to the 4.9 branch and forward

[GitHub] cloudstack issue #1677: CLOUDSTACK-8830 - [Vmware] VM snapshot fails for 12 ...

2016-10-25 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1677 @blueorangutan test centos7 vmware55u3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

2016-10-21 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1624 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1703: Trillian testrun on PR-1692 fwd-merged on 4.9 branch

2016-10-19 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1703 @nvazquez @serg38 thank you for your help verifying the is PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1681: CLOUDSTACK-9491: incorrect parsing of device list to...

2016-10-17 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1681 @murali-reddy could you please squash your commits? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1703: Trillian testrun on PR-1692 fwd-merged on 4.9 branch

2016-10-17 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1703 @karuturi @swill @wido @NuxRo @nvazquez we believe this PR is ready to merge. However, we need to cross check the test results. Would one (or more of you) be able to test this PR in order

[GitHub] cloudstack issue #1692: Fix Smoke Test Failures

2016-10-17 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1692 @karuturi @swill @wido @NuxRo @nvazquez we believe this PR is ready to merge. However, we need to cross check the test results. Would one (or more of you) be able to test this PR in order

[GitHub] cloudstack issue #1692: Fix Smoke Test Failures

2016-10-14 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1692 @karuturi can you provide a test LGTM from CloudMonger? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

2016-10-14 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1615 @koushik-das please see [this thread](http://markmail.org/thread/xp7ckhxhip2rbnr7) regarding the testing freeze discussion. Also, per our [community release schedule](https

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

2016-10-13 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1615 @koushik-das I would encourage you to discuss your concerns/perspective on dev@ in order to allow us a community to find consensus. There is never a good time to embark

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

2016-10-13 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1615 @koushik-das all merges remain on hold until the smoke tests are stabilized. I will be updating the list shortly on status and next steps. In short, #1692 and associated PRs should be moving

[GitHub] cloudstack issue #1572: CLOUDSTACK-9395: Add Virtio RNG device to Instances ...

2016-10-13 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1572 @karuturi am I missing the test results on this PR for the enhancements? All I see are tests against XenServer which have no bearing on this change. Why was this PR merged without a full

[GitHub] cloudstack issue #1704: Log refactoring/improving suggestions

2016-10-11 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1704 @nemo9cby no need to apologize -- greatly appreciate the effort. If this PR is done, please feel free to close it. We will focus our review and testing on #1705. Thanks again

[GitHub] cloudstack issue #1704: Log refactoring/improving suggestions

2016-10-11 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1704 @nemo9cby thank you for working to improve logging in CloudStack. It is an vital function that has not received the love it should. Please re-target this PR to the 4.9 branch rather

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

2016-10-05 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1600 @mike-tutkowski we are holding merges until we get all smoke tests passing on #1692 (and the subsequent PRs for the 4.9 and master branches). When those fixes are merged, we have you rebase

[GitHub] cloudstack issue #1692: Fix Smoke Test Failures

2016-10-03 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1692 @blueorangutan test centos6 kvm-centos6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1698: CLOUDSTACK-9525 add support for windows 10 guest os ...

2016-10-03 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1698 @serg38 @karuturi can you also include the mappings for KVM and HyperV? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1692: Fix Smoke Test Failures

2016-10-03 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1692 @serg38 @abhinandanprateek diagnosed the same issue earlier today. Reviewing #871, it is composed of commits fbc2e2e983938e6a16b7e44eb19db9e659b7a570

[GitHub] cloudstack issue #1692: Fix Smoke Test Failures

2016-10-03 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1692 @serg38 #571 has no Marvin test case changes and fixes the CPVM. How does it address the `test_01_test_vm_volume_snapshot` error? --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1699: CLOUDSTACK-9513 Migrate transifex workflow and forma...

2016-10-03 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1699 I will add this PR to the list to merge post resolution of #1692 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-10-03 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1696 @serg38 good catch regarding vSphere 6. As I noted earlier, I will be rolling back this merge, and we will address it on re-submission. Once we resolve the VMware 5.5, XenServer 6.5

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-10-03 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1696 @serg38 @rhtyd I am going to rollback this merge as it appears that the patch does not fix the issue. I would also like to explore @serg38's point that we shouldn't need to make code changes

[GitHub] cloudstack issue #1642: CLOUDSTACK-9504: System VMs on Managed Storage

2016-10-03 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1642 @rhtyd any ideas? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1642: CLOUDSTACK-9504: System VMs on Managed Storage

2016-10-03 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1642 @mike-tutkowski The Travis build is failing with the following error: ``` 0.04s$ ./tools/travis/script.sh ${TESTS} Running tests: smoke/test_usage_events smoke

[GitHub] cloudstack issue #1697: CLOUDSTACK-4858 Honors the snapshot.backup.rightafte...

2016-09-30 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1697 @nathanejohnson we making a hard push on #1692 to get all of the smoke tests to be super green. Once that PR is merged up, we will rebase and re-test this PR and there will be no more

[GitHub] cloudstack issue #1692: Fix Smoke Test Failures

2016-09-30 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1692 @serg38 raises a good point. @rhtyd do we explicitly need that commit to get the smoke tests to pass? As I understand, the macchininia template is (very nice) performance optimization

[GitHub] cloudstack pull request #:

2016-09-30 Thread jburwell
Github user jburwell commented on the pull request: https://github.com/apache/cloudstack/commit/2ed1df0186776c3ea592284cd6a28eca2b84bb34#commitcomment-19238615 @rhtyd can you please open a JIRA ticket for this issue and amend the commit message to include it? --- If your project

[GitHub] cloudstack issue #1545: CLOUDSTACK-8715: Add channel to Instances for Qemu G...

2016-09-29 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1545 @wido I misunderstood. I thought was fixing one or more bugs. Given that it is an enhancement, you are correct that it should only target master. As soon as we iron the smoke test issues

[GitHub] cloudstack issue #1673: CLOUDSTACK-9071: Properly parse stats.output.uri in ...

2016-09-29 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1673 @wido thank you for re-targeting the PR. Do you think running the smoke tests against one of the hypervisors is sufficient to verify this defect? Should we update a Marvin test to cover

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

2016-09-29 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1684 @rhtyd we have a case where two experienced users (and likely more to come) have gotten tripped up by this case. Therefore, we need to address it. As I mentioned previously, the solution

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

2016-09-29 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1600 @mike-tutkowski sounds good. I am putting together a test results email which should be out shortly. It outlines the issues we have found thus far. As such, I expect the testing period

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-29 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1696 @rhtyd 4.8 is still supported. However, support is for bug fixes, and this change is not a bug fix. 4.9 is an LTS branch which can take changes such as these. So I am cool with it being 4.9

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

2016-09-29 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1600 @syed @mike-tutkowski should the tests be re-executed to make sure everything is super green? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1692: Fix Smoke Test Failures

2016-09-29 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1692 @borisstoyanov could you please amend the first line of commit 62f4826 to be : ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack issue #1696: [4.9/lts] CLOUDSTACK-9364: Add Ubuntu 16.04 as a gue...

2016-09-29 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1696 @rhtyd do you think we should include this update in 4.8.2.0 as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

2016-09-29 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1684 @rhtyd discussing this issue with @paul, there is a scenario where this wedged condition can occur. If you perform an upgrade by creating a new management server VM

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

2016-09-29 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1684 @pdion891 based on the behavior reported, I believe we can make this experience much smoother if not completely consistent. Do you have time to grab a quick GTM to discuss tomorrow (29 Sept

[GitHub] cloudstack issue #1673: CLOUDSTACK-9071: Properly parse stats.output.uri in ...

2016-09-29 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1673 @wido the Travis and Jenkins are failing due a compilation error. It appears to be that `StringUtils` has not been imported into `StatsCollector`. --- If your project is set up for it, you

[GitHub] cloudstack issue #1684: CLOUDSTACK-9489: the new config vars that are added ...

2016-09-28 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1684 @rhtyd this issue feels like it should no occur. For example, could the role permission tables be populated with default values when they are created? If/when values are imported from

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

2016-09-28 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1600 @syed it appears that conflicts were introduced when #1689 was merged. Could you please resolve? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

2016-09-28 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1542 @rhtyd good idea to check the CPU flags. There is a part of me that would like to see a VM actually spin up inside a VM, but there are also many things that could go wrong

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

2016-09-28 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1615 LGTM for code review. We are currently investigating failures on #1692 which is intended to clean up a number of smoke test failures. Once we have those issues resolved, this PR can

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

2016-09-28 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1615#discussion_r81019103 --- Diff: test/integration/smoke/test_ssvm.py --- @@ -42,12 +43,19 @@ class TestSSVMs(cloudstackTestCase): def setUp(self

[GitHub] cloudstack issue #1676: CLOUDSTACK-9502: DS template copies don’t get dele...

2016-09-28 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1676 LGTM for code review. We are awaiting the results of failures in #1692 to merge smoke tests fixes. When that is completed, we will rebase this PR and execute smoke tests. Upon passage, we

[GitHub] cloudstack issue #1677: CLOUDSTACK-8830 - [Vmware] VM snapshot fails for 12 ...

2016-09-28 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1677 @serg38 @nvazquez tests for #1692 may have exposed a number of smoke test issues. We are investigating the root causes to ensure that they are environmental not due to bugs. Once we have

[GitHub] cloudstack issue #1690: Update L10N resource files with 4.10 strings from Tr...

2016-09-28 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1690 @rhtyd @karuturi we need a second LGTM to merge this PR for 4.10.0.0 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1692: fix ping tests to properly recognise successful ping...

2016-09-28 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1692 This PR has 39 test errors/failures. We are investigating the cause of each failure to determine the root cause (environmental, test defect, or CloudStack defect). I will update this PR when

[GitHub] cloudstack issue #1693: CLOUDSTACK-9505: Fix test_deploy_vgpu_enabled tests ...

2016-09-28 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1693 @nvazquez this change looks like it would benefit 4.8 and 4.9 as well. Could you please change the base branch to 4.8? --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

2016-09-27 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1542 @serg38 no problem --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

2016-09-27 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1542 @rhytd can you help @serg38 craft a template with KVM installed and the virsh commands to create a nested VM? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1642: CLOUDSTACK-9504: System VMs on Managed Storage

2016-09-27 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1642 @karuturi awaiting feature enhancement to blueorangutan which was delayed due to an medical emergency. Also, I want to wait to perform further testing until #1692 is tested and merged

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

2016-09-27 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1542 @serg38 the goal is not only verify that functionality works now, but in the future to protect against regressions. My thinking is that we could deploy a CentOS VM, install KVM, and verify

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

2016-09-27 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1600 @syed #1692 is testing now. It addresses ping test related failures in the smoke test suite. I am hoping the tests pass, and we can merge it first thing tomorrow. Once it has, we can rebase

[GitHub] cloudstack issue #1669: Make CloudStack JSP-free

2016-09-27 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1669 @milamberspace I agree because it appears to remove the need to maintain the Python compilation script which reduces complexity and doesn't add any more build time. --- If your project

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

2016-09-27 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1600 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1600: Support Backup of Snapshots for Managed Storage

2016-09-27 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1600 @syed could you please squash your commits? Once that is done, the following items will be need to be completed: * [ ] Re-execute functional test since the code has changed since

[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

2016-09-27 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1645 @nathanejohnson thank you for your confirmation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

2016-09-27 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1645 @nathanejohnson to confirm, the test results in your [26 Aug comment](https://github.com/apache/cloudstack/pull/1645#issuecomment-242715452) comment were from a run on KVM + Ceph

[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

2016-09-27 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1645 @nathanejohnson @kiwiflyer do you have test results to share for KVM + Ceph? If not, we need to rollback this PR until we get test confirmation of the functionality. --- If your project

[GitHub] cloudstack issue #1692: fix ping tests to properly recognise successful ping...

2016-09-27 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1692 Looks like the blueorangutan build didn't complete properly. I am re-kicking it now. @blueorangutan test matrix --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack issue #1669: Make CloudStack JSP-free

2016-09-27 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1669 @rhtyd @milamberspace I have started a conversation on dev@ to discuss transitioning to the JSON format. Is acceptable to hold this PR until we come to consensus on that thread? --- If your

[GitHub] cloudstack issue #1689: Switched to the official SolidFire SDK for Python

2016-09-27 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1689 @mike-tutkowski excellent -- thanks for adding that configuration bit. I am LGTM once the Jenkins and Travis complete successfully. @karuturi @rhtyd are you able to review

[GitHub] cloudstack pull request #1694: CLOUDSTACK-9509: Host Connects Without Storag...

2016-09-27 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1694#discussion_r80714655 --- Diff: server/test/com/cloud/storage/listener/StoragePoolMonitorTest.java --- @@ -0,0 +1,80 @@ +// Licensed to the Apache Software Foundation

[GitHub] cloudstack pull request #1694: CLOUDSTACK-9509: Host Connects Without Storag...

2016-09-27 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1694#discussion_r80714972 --- Diff: server/src/com/cloud/storage/listener/StoragePoolMonitor.java --- @@ -99,12 +99,12 @@ public void processConnect(Host host, StartupCommand

[GitHub] cloudstack issue #1593: CLOUDSTACK-9417: Usage module refactoring

2016-09-27 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1593 @serg38 I have this PR on a list to re-review. In my view, using a global setting for this value is whole inappropriate. I have been busy with other items, and haven't had a chance to get

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

2016-09-27 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1615 @koushik-das are you LGTM on this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

2016-09-27 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1615 @rhtyd can you add the configuration data to blueorangutan for the changes to `test_ssvm.py`? @serg38 @nvazquez once my review comments are addressed and blueorganutan has been

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

2016-09-27 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1615#discussion_r80701705 --- Diff: test/integration/smoke/test_ssvm.py --- @@ -1197,3 +1205,148 @@ def test_10_destroy_cpvm(self): # Call to verify cloud process

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

2016-09-27 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1615#discussion_r80702685 --- Diff: test/integration/smoke/test_ssvm.py --- @@ -1197,3 +1205,148 @@ def test_10_destroy_cpvm(self): # Call to verify cloud process

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

2016-09-27 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1615#discussion_r80704271 --- Diff: test/integration/smoke/test_ssvm.py --- @@ -1197,3 +1205,148 @@ def test_10_destroy_cpvm(self): # Call to verify cloud process

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

2016-09-27 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1615#discussion_r80701833 --- Diff: test/integration/smoke/test_ssvm.py --- @@ -1197,3 +1205,148 @@ def test_10_destroy_cpvm(self): # Call to verify cloud process

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

2016-09-27 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1615#discussion_r80702827 --- Diff: test/integration/smoke/test_ssvm.py --- @@ -1197,3 +1205,148 @@ def test_10_destroy_cpvm(self): # Call to verify cloud process

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

2016-09-27 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1615#discussion_r80700964 --- Diff: test/integration/smoke/test_ssvm.py --- @@ -1197,3 +1205,148 @@ def test_10_destroy_cpvm(self): # Call to verify cloud process

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

2016-09-27 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1615#discussion_r80701499 --- Diff: test/integration/smoke/test_ssvm.py --- @@ -1197,3 +1205,148 @@ def test_10_destroy_cpvm(self): # Call to verify cloud process

[GitHub] cloudstack pull request #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Ma...

2016-09-27 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1615#discussion_r80702139 --- Diff: test/integration/smoke/test_ssvm.py --- @@ -42,12 +43,19 @@ class TestSSVMs(cloudstackTestCase): def setUp(self

[GitHub] cloudstack issue #1615: CLOUDSTACK-9438: Fix for CLOUDSTACK-9252 - Make NFS ...

2016-09-27 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1615 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1542: CLOUDSTACK-9379: Support nested virtualization at VM...

2016-09-27 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1542 @serg38 @nvazquez I apologize that I am late to the review. I would like to see a Marvin test added that verifies that nested virtualization works when the global setting is enabled (i.e

[GitHub] cloudstack issue #1677: CLOUDSTACK-8830 - [Vmware] VM snapshot fails for 12 ...

2016-09-27 Thread jburwell
Github user jburwell commented on the issue: https://github.com/apache/cloudstack/pull/1677 @serg38 I just kicked a smoke test run on VMware. Assuming that passes, it will be good for 4.9.1.0. --- If your project is set up for it, you can reply to this email and have your reply

<    1   2   3   4   5   6   7   8   9   10   >