GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1470
Make the generated json files unique to prevent concurrency issues
The json files now have UUIDs to prevent them from getting overwritten
before they've been executed. Prevents config
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1472
Apply static routes on change to master state
Refactored static routes for private gateways so they also get loaded when
the router switches to master state. Otherwise they're lost
Github user remibergsma closed the pull request at:
https://github.com/apache/cloudstack/pull/1467
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user remibergsma closed the pull request at:
https://github.com/apache/cloudstack/pull/1469
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1473
Bump ssh retries to prevent false positives of test_loadbalance
No more false positives after this change.
```
[root@cs1 integration]# cat
/tmp//MarvinLogs
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1469
Bump ssh retries to prevent false positives of test_loadbalance
No more false positives after this change.
```
[root@cs1 integration]# cat
/tmp//MarvinLogs
Github user remibergsma closed the pull request at:
https://github.com/apache/cloudstack/pull/1468
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1471
Lower the time we wait for interfaces to appear
Waiting for interfaces is tricky. They might never appear.. for example
when we have entries in `/etc/cloudstack/ips.json` that haven't been
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1465#issuecomment-207051489
@DaanHoogland This can be pointed towards 4.7 so I will close this and open
one to 4.7 instead of master.
---
If your project is set up for it, you can reply
Github user remibergsma closed the pull request at:
https://github.com/apache/cloudstack/pull/1465
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1468
Apply static routes on change to master state
Refactored static routes for private gateways so they also get loaded when
the router switches to master state. Otherwise they're lost
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1467
Lower the time we wait for interfaces to appear after restart
Waiting for interfaces is tricky. They might never appear.. for example
when we have entries in `/etc/cloudstack/ips.json
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1465
Fix concurrency issue on virtual router
The json files now have UUIDs to prevent them from getting overwritten
before they've been executed. Prevents config to be pushed to the wrong
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1462#issuecomment-205452667
Works as expected, LGTM.
 I would recommend posting
the results though, the results.txt file shows which tests were run. If later
we
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1356#issuecomment-199270791
@milamberspace No back porting please :-) Just upgrade to 4.7, it's a
painless 10min job.
---
If your project is set up for it, you can reply to this email
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/780#issuecomment-199270124
Guys, LGTMs or not, there were no integration test results posted so it
shouldn't have been merged.
---
If your project is set up for it, you can reply
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1444#issuecomment-198881402
This PR has some nice improvements, so that's great @rafaelweingartner!
Still, I'm clueless why people merge without running a single integration
test
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/780#issuecomment-198515978
@swill Please do proceed with revert, I totally agree.
`git revert -m 1 dc0ba6bd1a774d3ff4bc4a4dcc00e1434ab1f6e3` will do. Let me
know if you need help
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1437#issuecomment-195625848
I see your point @rafaelweingartner, no hard feelings here. If we simply
always run the integration tests, there is no discussion whether or not we need
to run
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1437#issuecomment-195620065
@GabrielBrascher based on what tests? It was only compiled.
I'm with @eriweb here, this should not go in without testing. Ask on the ML
if someone
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-195547692
If there's a Marvin integration test for this feature, I'm wondering why it
succeeded without this fix. I think we might need to improve the test and show
it's
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1429#issuecomment-193384072
@kiwiflyer Thanks, have seen this as well and will try your fix when I have
some time :-)
---
If your project is set up for it, you can reply to this email
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1428#issuecomment-193383891
Hi @kiwiflyer, did you test this without MySQL HA as well? I doubt it will
work without `mysql-connector-java`. Also, this most likely also needs to be
fixed
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-190320208
Hi @nvazquez, when we run this in production weird stuff started to happen.
This happened with VPCs that have a private gateway attached. It seemed to get
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1422#issuecomment-187368247
@DaanHoogland I debugged so many routers recently that I think it's fair to
say this info on the top is most valuable :-) But feel free to disagree
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1422
Improve ordering of fields of VPC router detail tab
The field we use most are now on the top:
- name
- state
- hypervisor
- link local ip
- redundant state
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1421#discussion_r53555783
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/merge.py ---
@@ -272,5 +275,10 @@ def setPath(self, path):
def __moveFile(self
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1421#issuecomment-186664554
Test result:
.
You can merge this pull request into a Git
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1413#issuecomment-185635109
LGTM, based on the tests below. This runs in prod at SBP.
Test results:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1413#issuecomment-184191105
@DaanHoogland A private gw uses a single ip address so there's your issue
:-)
---
If your project is set up for it, you can reply to this email and have your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1413#issuecomment-183729063
LGTM
Master router:
![pr1413_router1](https://cloud.githubusercontent.com/assets/1630096/13029502/bb27f23c-d28e-11e5-9060-ebce22b3f9e7.png
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/667#issuecomment-183022736
Don't merge stuff without responding to the comments. Look at your commits,
two with the same title? How does that help? I asked to squash them on Aug 14
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1011#issuecomment-182276612
@runseb Totally agree, reverted merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1401#issuecomment-182276957
@runseb Keep an eye on this PR, it has the same ip address problem and I
commented last week already.
---
If your project is set up for it, you can reply
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1404
prevent RTNETLINK errors as we were iterating over empty list
Error seen:
RTNETLINK answers: File exists
Integration tests are running, will post results later.
You can
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1402
Check the existence of 'forceencap' parameter before use
Check the existence of 'forceencap' parameter before use.
Error seen:
```
Traceback (most recent call last
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1401#discussion_r51845671
--- Diff: tools/marvin/marvin/config/test_data.py ---
@@ -781,6 +781,15 @@
"ostype": "Cen
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1401#discussion_r51846029
--- Diff: tools/marvin/marvin/config/test_data.py ---
@@ -790,6 +799,26 @@
"format": "OVA",
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r51846623
--- Diff: setup/db/db/schema-471to480.sql ---
@@ -27,3 +27,10 @@ ALTER TABLE `cloud`.`image_store` MODIFY COLUMN `url`
varchar(2048);
ALTER
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1386#issuecomment-179703172
Test results, tested together with #1383:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1383#issuecomment-179703106
Test results, tested together with #1386:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1400#issuecomment-179708000
The integration tests succeed and this results in a massive speed
improvement for ACL rules. We've tested it with 500 and 1000 and it's like
50-60 times faster
Github user remibergsma closed the pull request at:
https://github.com/apache/cloudstack/pull/1388
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1387
CLOUDSTACK-8300: Set indexes on event table
When there are many events in the cloud.event table, the UI throws an SQL
exception and the management server spikes at 100% CPU for minutes
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1388
CLOUDSTACK-7836: Make s2s VPN CIDR list longer
We found the 200 char limit not sufficient. This should provide more room
for longer CIDR lists.
123.123.123.123/24 ==> 18 ch
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1271#issuecomment-177167744
The problem is clear:
![screen shot 2016-01-30 at 13 35
41](https://cloud.githubusercontent.com/assets/1630096/12695748/f207e5ce-c757-11e5-9097
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1363#issuecomment-177145863
The commits that get reverted here were supposed to fix a findbugs issue.
Will this reintroduce them? Can we both fix it and resolve the findbugs issue?
Ping
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1386
CLOUDSTACK-9266: Make deleting static routes in private gw work
The to-be-deleted static routes were removed from the json file, instead of
putting them there with revoke=true. The script
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1383
CLOUDSTACK-9264: Make /32 static routes for private gw work
Static routes for private gateways that were /32 failed because the `route`
command used had `-net` in it and a `/32` requires
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1383#issuecomment-176950230
Tested the following static routes:
https://cloud.githubusercontent.com/assets/1630096/12686942/1f0c9a3c-c6cd-11e5-9b65-60e813fdde47.png;>
Both s
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1384
Display hostname the VPC router runs on
This is displayed on Infra tab and it's annoying that on the VPC page only
the link local is mentioned and not the hostname. That is now corrected
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1288#issuecomment-176114078
@runseb We could see it as a bug, but I agree with @bhaisaab that it is a
non-issue that was "fixed" to make SonarQube happy. Fine to do tha
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/872#issuecomment-176011491
@jayapalu The test may pass, but my manual (scripted cloudmonkey) test
doesn't so we need to figure out what goes wrong. See my comments above.
---
If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1261#issuecomment-175782752
@bhaisaab Why merge without running integration tests? How do we know this
doesn't break anything else?
---
If your project is set up for it, you can reply
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1369#issuecomment-174941848
I'll also add the upgrade paths to this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1368#issuecomment-174941822
I'll also add the upgrade paths to this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1367#issuecomment-174941786
I'll also add the upgrade paths to this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1367
Set version to 4.7.2-SNAPSHOT in 4.7 branch
After releasing 4.7.1, next version is 4.7.2-SNAPSHOT in 4.7 branch.
You can merge this pull request into a Git repository by running
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1368
Set version to 4.8.1-SNAPSHOT in 4.8 branch
After releasing 4.8.0, next version is 4.8.1-SNAPSHOT in 4.8 branch.
You can merge this pull request into a Git repository by running
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1369
Set version to 4.9.0-SNAPSHOT in master branch
After releasing 4.8.0, next version is 4.9.0-SNAPSHOT in master branch.
You can merge this pull request into a Git repository by running
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1369#issuecomment-175051270
Tested the upgrade to `4.9.0` and that works fine:
```
2016-01-26 14:39:09,544 INFO [c.c.u.DatabaseUpgradeChecker] (main:null)
(logid:) DB version
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1369#issuecomment-175092697
Tested `4.6.2` to `4.9.0` upgrade and that works as expected.
```
2016-01-26 16:00:36,899 DEBUG [c.c.u.d.VersionDaoImpl] (main:null) (logid
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1367#issuecomment-174997795
Tried upgrade from `4.7.1` to `4.7.2` and that was successful:
```
2016-01-26 12:47:32,170 DEBUG [c.c.u.d.VersionDaoImpl] (main:null) (logid
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1367#issuecomment-174998354
Ping @DaanHoogland @borisroman Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1368#issuecomment-175004288
Ping @borisroman @DaanHoogland Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1368#issuecomment-175004146
Tested upgrade from `4.7.2` to `4.8.1` and that succeeded:
```
2016-01-26 13:06:13,421 INFO [c.c.u.DatabaseUpgradeChecker] (main:null)
(logid:) DB
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1364#issuecomment-174863942
`cat /etc/cloudstack/staticroutes.json` before and after change:
Before always had one entry:
```
{
"10.135.2
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1364
CLOUDSTACK-9256 add unique key for static routes in json
Static routes that are being set do not show up in the static_routes.json
file. The reason for this is that the index that is used
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1279#issuecomment-174196682
For the record: the upgrade works:
```
2016-01-23 16:06:44,796 INFO [c.c.u.DatabaseUpgradeChecker] (main:null)
(logid:) DB version = 4.6.2 Code
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1358#issuecomment-174210065
Ping @borisroman
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1358#issuecomment-174210050
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1354#issuecomment-174215209
LGTM
https://cloud.githubusercontent.com/assets/1630096/12532310/4bf04906-c211-11e5-9120-0988f28ebc1c.png;>
---
If your project is set up for it, you
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1279#issuecomment-174211604
@bhaisaab Let me rephrase: I tested your PR and that works :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1362
CLOUDSTACK-9254: Make longer names display pretty in UI
The arrow always fell off when I log in ;-)
Before change it looked like this:
https://cloud.githubusercontent.com
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1356#issuecomment-173863164
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1359#issuecomment-173872832
@ProjectMoon Indeed! :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1200#issuecomment-173955971
Ping @wilderrodrigues see answer above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1340#issuecomment-173357915
LGTM, wasn't able to check it with a Netscaler setup. Looks good and syntax
of js is OK.
https://cloud.githubusercontent.com/assets/1630096/12462979
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1348#issuecomment-173364862
@DaanHoogland This test is failing:
```
Test migrate VM ... === TestName: test_08_migrate_vm | Status : EXCEPTION
===
ERROR
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1346#issuecomment-173187438
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1349#issuecomment-173194446
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50251651
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsDhcp.py ---
@@ -96,29 +96,8 @@ def configure_server(self
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50251745
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1272#issuecomment-173205246
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1352#issuecomment-172977865
@DaanHoogland I think we agree cloud-early-config needs major refactoring
as it is one big copy/paste thing. Just don't think this is the time to do
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1352#issuecomment-173005222
`cloud-early-config` now logs:
```
Not setting up route of RFC1918 space to 192.168.22.1 befause 192.168.23.2
is RFC1918..
```
Routes
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1352#issuecomment-173002828
@nislim Can you please test the enhanced patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1352#issuecomment-173002681
Discussed with @DaanHoogland and he sent me a patch ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1321#issuecomment-172892988
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1321#issuecomment-172908360
@DaanHoogland This PR is better than the current situation and would
improve even more if the whole check would disappear. If the PR is changed,
I'll happily
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1352
CLOUDSTACK-9244 Fix setting up RFC1918 routes
Public ip var was empty so routes were always set. Corrected this.
You can merge this pull request into a Git repository by running
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1338#issuecomment-172537670
@nitin-maharana I like it when you put screenshots, as this speeds up my
testing because I can see what you mean. I will test it soon, can you help me
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1334#issuecomment-172539609
LGTM, not tested actual Netscaler integration as I don't have such a setup.
I did check the syntax and saw the UI still renders properly
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1288#issuecomment-172533708
LGTM, UI seems to display OK.
