[GitHub] cloudstack issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage...

2017-04-12 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/2035 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #2026: CLOUDSTACK-9861: Expire VM snapshots after co...

2017-04-10 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/2026#discussion_r110594291 --- Diff: setup/db/db/schema-4920to41000.sql --- @@ -232,3 +232,5 @@ WHERE (o.cpu is null AND o.speed IS NULL AND o.ram_size IS NULL

[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

2017-04-10 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1960 @koushik-das I see that main issue is that this is being confused as VM HA framework. Will like to again add that this framework is not for VM-HA but for host HA

[GitHub] cloudstack issue #2035: CLOUDSTACK-9867:VM snapshot on primary storage usage...

2017-04-07 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/2035 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #2035: CLOUDSTACK-9867:VM snapshot on primary storag...

2017-04-07 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/2035 CLOUDSTACK-9867:VM snapshot on primary storage usage metrics You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue

[GitHub] cloudstack pull request #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs...

2017-04-06 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/2030#discussion_r110145877 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java --- @@ -550,15 +552,21 @@ public boolean

[GitHub] cloudstack pull request #2030: WIP: CLOUDSTACK-9864 cleanup stale worker VMs...

2017-04-06 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/2030#discussion_r110145761 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java --- @@ -128,6 +129,7 @@ public

[GitHub] cloudstack issue #2001: CLOUDSTACK-9830 Fix DST bug in QuotaAlertManagerTest

2017-04-06 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/2001 @LGTM on code review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request #2029: CLOUDSTACK-9857: With this change if agent di...

2017-04-06 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at: https://github.com/apache/cloudstack/pull/2029 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #2024: CLOUDSTACK-9857: With this change if agent dies the ...

2017-04-06 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/2024 @rhtyd @karuturi here is the cherry picked PR on 4.9 https://github.com/apache/cloudstack/pull/2029 --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request #2029: CLOUDSTACK-9857: With this change if agent di...

2017-04-06 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/2029 CLOUDSTACK-9857: With this change if agent dies the systemd will catc… …h it properly and show process as exited You can merge this pull request into a Git repository by running

[GitHub] cloudstack pull request #2014: WIP: Fix primary storage usage for vm snaphot

2017-04-04 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at: https://github.com/apache/cloudstack/pull/2014 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #2014: WIP: Fix primary storage usage for vm snaphot

2017-04-04 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/2014 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #2026: CLOUDSTACK-9861: Expire VM snapshots after configure...

2017-04-04 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/2026 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #2014: WIP: Fix primary storage usage for vm snaphot

2017-04-04 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/2014 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #2026: CLOUDSTACK-9861: Expire VM snapshots after co...

2017-04-04 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/2026 CLOUDSTACK-9861: Expire VM snapshots after configured duration Default value of the account level global config vmsnapshot.expire.interval is -1 that conforms to legacy behaviour

[GitHub] cloudstack pull request #2020: WIP: Expire VM snapshots

2017-04-04 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at: https://github.com/apache/cloudstack/pull/2020 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #2014: WIP: Fix primary storage usage for vm snaphot

2017-04-04 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/2014 @borisstoyanov checking --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #2024: CLOUDSTACK-9857: With this change if agent di...

2017-04-03 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/2024 CLOUDSTACK-9857: With this change if agent dies the systemd will catc… …h it properly and show process as exited You can merge this pull request into a Git repository by running

[GitHub] cloudstack issue #2020: WIP: Expire VM snapshots

2017-04-02 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/2020 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #2014: WIP: Fix primary storage usage for vm snaphot

2017-03-31 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/2014 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #2020: IR25: WIP

2017-03-28 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/2020 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #2020: IR25: WIP

2017-03-28 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/2020 IR25: WIP You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack ir25 Alternatively you can review and apply

[GitHub] cloudstack issue #2014: WIP

2017-03-23 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/2014 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #2014: WIP

2017-03-22 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/2014 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #2014: IR24:WIP

2017-03-22 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/2014 IR24:WIP You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack ir24 Alternatively you can review and apply

[GitHub] cloudstack pull request #1998: CLOUDSTACK-4757: WIP: support for multidisk O...

2017-03-10 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at: https://github.com/apache/cloudstack/pull/1998 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1998: CLOUDSTACK-4757: WIP: support for multidisk OVA file...

2017-03-09 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1998 @sateesh-chodapuneedi you have worked on it, will you list down what needs to be additionally done on this PR to make it production ready. Will be really good if you can participate

[GitHub] cloudstack pull request #1998: Multidisk ova

2017-03-09 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1998 Multidisk ova You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack multidisk-OVA Alternatively you can review

[GitHub] cloudstack pull request #1989: WIP: CLOUDSTACK-4757: support for multidisk O...

2017-03-09 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at: https://github.com/apache/cloudstack/pull/1989 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request #1989: WIP: CLOUDSTACK-4757: support for multidisk O...

2017-03-09 Thread abhinandanprateek
GitHub user abhinandanprateek reopened a pull request: https://github.com/apache/cloudstack/pull/1989 WIP: CLOUDSTACK-4757: support for multidisk OVA files Signed-off-by: Abhinandan Prateek <abhinandan.prat...@shapeblue.com> You can merge this pull request into a Git repo

[GitHub] cloudstack pull request #1989: WIP: CLOUDSTACK-4757: support for multidisk O...

2017-03-09 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at: https://github.com/apache/cloudstack/pull/1989 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1989: WIP: CLOUDSTACK-4757: support for multidisk OVA file...

2017-03-09 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 This PR is basically merging https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=refs/heads/multiple-disk-ova. And continue to build on it. --- If your project

[GitHub] cloudstack issue #1995: CLOUDSTACK-9828: GetDomRVersionCommand fails to get ...

2017-03-09 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1995 @ustcweizhou another observation is that with the same systemvm.iso and VR templates; get version works on with some hosts while consistently failing in some cases. --- If your

[GitHub] cloudstack issue #1995: CLOUDSTACK-9828: GetDomRVersionCommand fails to get ...

2017-03-09 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1995 @ustcweizhou the file exists and the script works on the VR. It is not able to return the complete output though via the router_proxy. The signature file is part of the template

[GitHub] cloudstack pull request #1995: CLOUDSTACK-9828: GetDomRVersionCommand fails ...

2017-03-09 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1995 CLOUDSTACK-9828: GetDomRVersionCommand fails to get the correct versi… …on as output Fix tries to return the output as a single command, instead of appending output from

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-08 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-08 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-08 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-08 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-07 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-07 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-07 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1779: CLOUDSTACK-9610: Disabled Host Keeps Being up status...

2017-03-07 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1779 code review LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-07 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-07 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 @blueorangutan cancel --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #1779: CLOUDSTACK-9610: Disabled Host Keeps Being up...

2017-03-07 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1779#discussion_r104609930 --- Diff: server/src/com/cloud/resource/ResourceManagerImpl.java --- @@ -2488,6 +2488,22 @@ public boolean maintenanceFailed(final long hostId

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-06 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 @blueorangutan test centos7 vmware-55u3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-06 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 @blueorangutan test vmware-55u3 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-06 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 @blueorangutan test vmware --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-06 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-06 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1989 @serg38 Yes, the aim of the PR is to enable deployment from templates with multiple data disks. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request #1989: WIP: support for multidisk OVA files

2017-03-05 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1989 WIP: support for multidisk OVA files Signed-off-by: Abhinandan Prateek <abhinandan.prat...@shapeblue.com> You can merge this pull request into a Git repository by running:

[GitHub] cloudstack pull request #1979: CLOUDSTACK-9198: Donot allow VMs to be deplye...

2017-03-02 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at: https://github.com/apache/cloudstack/pull/1979 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-03-01 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1278 @anshul1886 @koushik-das I think with above info the fix looks good. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-03-01 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1278 @koushik-das @anshul1886 If we allow admin to deploy resources on disabled resources then this fix is fine. Even with the fix a non admin user will be able to restart a VM

[GitHub] cloudstack pull request #1979: CLOUDSTACK-9198: Donot allow VMs to be deplye...

2017-03-01 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1979 CLOUDSTACK-9198: Donot allow VMs to be deplyed on host that are in di… …sabled pod You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-03-01 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1278 @anshul1886 If you trace the method planDeployment in DeploymentPlanningManagerImpl then you will see that orderCluster is getting invoked at line 500. By that time I think

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-02-28 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1278 @anshul1886 I am not sure I thought deployment planner for VR and a regular VM is same. If a regular VM is not allowed in a cluster that is under disabled pod then the VR should also

[GitHub] cloudstack issue #1675: CLOUDSTACK-9453: WIP

2017-02-28 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1675 @rhtyd closing this PR as relevant portion of this are already in codebase via other VRs. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request #1675: CLOUDSTACK-9453: WIP

2017-02-28 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at: https://github.com/apache/cloudstack/pull/1675 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-02-28 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1278 @anshul1886 Should not we disallow any VM to be deployed in a disabled Pod, why just the VR ? cc @rhtyd @karuturi --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-02-28 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1278 @anshul1886 Should not we disallow any VM to be deployed in a disabled Pod, why just the VR ? cc @rhtyd @karuturi Lets merge this shapeblue/cloudstack-apple@359f652

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

2017-02-28 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1278 @anshul1886 Should not we disallow any VM to be deployed in a disabled Pod, why just the VR ? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

2017-02-28 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1960 @koushik-das The current framework is specifically implemented for Host HA with KVM HA as the initial implementation. This framework is supposed to replace the framework

[GitHub] cloudstack issue #1958: CLOUDSTACK-5806: add presetup to storage types that ...

2017-02-24 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1958 @borisstoyanov a condition got inverted by the change (serg38 pointed that out above), it is fixed now. Can you rerun the tests. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request #1958: CLOUDSTACK-5806: add presetup to storage type...

2017-02-24 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1958#discussion_r102918123 --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- @@ -508,7 +507,7 @@ public String updateConfiguration(final

[GitHub] cloudstack pull request #815: CLOUDSTACK-8841: Storage XenMotion from XS 6.2...

2017-02-23 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/815#discussion_r102671303 --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java --- @@ -4717,8 +4717,8 @@ public VirtualMachine migrateVirtualMachineWithVolume(Long

[GitHub] cloudstack pull request #1933: CLOUDSTACK-9569: add router.aggregation.comma...

2017-02-05 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at: https://github.com/apache/cloudstack/pull/1933 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request #1933: CLOUDSTACK-9569: add router.aggregation.comma...

2017-02-05 Thread abhinandanprateek
GitHub user abhinandanprateek reopened a pull request: https://github.com/apache/cloudstack/pull/1933 CLOUDSTACK-9569: add router.aggregation.command.each.timeout to agent… ….properties You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cloudstack pull request #1933: CLOUDSTACK-9569: add router.aggregation.comma...

2017-02-05 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1933 CLOUDSTACK-9569: add router.aggregation.command.each.timeout to agent… ….properties You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cloudstack pull request #1932: CLOUDSTACK-9473: Storage pool checker is igno...

2017-02-05 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at: https://github.com/apache/cloudstack/pull/1932 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request #1932: CLOUDSTACK-9473: Storage pool checker is igno...

2017-02-05 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1932 CLOUDSTACK-9473: Storage pool checker is ignored on resize and migrat… …e volume. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cloudstack pull request #1931: CLOUDSTACK-9473: Storage pool checker is igno...

2017-02-05 Thread abhinandanprateek
Github user abhinandanprateek closed the pull request at: https://github.com/apache/cloudstack/pull/1931 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request #1931: CLOUDSTACK-9473: Storage pool checker is igno...

2017-02-05 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1931 CLOUDSTACK-9473: Storage pool checker is ignored on resize and migrat… …e volume. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cloudstack pull request #1930: CLOUDSTACK-9687: if the allocated amount is 0...

2017-02-05 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1930 CLOUDSTACK-9687: if the allocated amount is 0 the capacity updates ar… …e not done, resulting in wrong values being shown as allocated value instead of zero You can merge

[GitHub] cloudstack issue #1888: CLOUDSTACK-9710: Switch to JRE1.8

2017-01-05 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1888 lgtm on code review @rhtyd --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1839: CLOUDSTACK-9683: system.vm.default.hypervisor will p...

2016-12-21 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1839 @rhtyd most of the automation environments are single hypervisor one, so will end up creating a mixed hypervisor zone for this test only. If that can be done i can put one together

[GitHub] cloudstack issue #1843: WIP: instrumeted code

2016-12-20 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1843 @blueorangutan package --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #1843: WIP: instrumeted code

2016-12-20 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1843 WIP: instrumeted code WIP You can merge this pull request into a Git repository by running: $ git pull https://github.com/shapeblue/cloudstack CLOUDSTACK-9687 Alternatively you

[GitHub] cloudstack issue #1839: CLOUDSTACK-9683: system.vm.default.hypervisor will p...

2016-12-19 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1839 @blueorangutan test centos6 kvm-centos6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1839: CLOUDSTACK-9683: system.vm.default.hypervisor will p...

2016-12-19 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1839 @blueorangutan test centos6 kvm-centos6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1839: CLOUDSTACK-9683: system.vm.default.hypervisor will p...

2016-12-19 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1839 @blueorangutan help --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request #1839: CLOUDSTACK-9683: system.vm.default.hypervisor...

2016-12-18 Thread abhinandanprateek
GitHub user abhinandanprateek opened a pull request: https://github.com/apache/cloudstack/pull/1839 CLOUDSTACK-9683: system.vm.default.hypervisor will pin the hypervisor… … for VR too with this fix You can merge this pull request into a Git repository by running: $ git

[GitHub] cloudstack issue #1823: CLOUDSTACK-9594: Fix regression in test_templates

2016-12-08 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1823 LGTM on code review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1800: CLOUDSTACK-9633:test_snapshot is failing due to inco...

2016-12-07 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1800 @rhtyd this is good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1807: CLOUDSTACK-9633: Revert addition of `vhd` extention ...

2016-12-07 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1807 @syed please do a check of various snapshot functions on a upgraded setup. @rhtyd this PR can be closed. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack issue #1807: CLOUDSTACK-9633: Revert addition of `vhd` extention ...

2016-12-07 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1807 @syed @swill @rhtyd @serg38 I think i missed some updates. This PR will only break the original PR. The patch suggested by @serg38 looks good. @syed in a upgraded setup, I think

[GitHub] cloudstack issue #1807: CLOUDSTACK-9633: Revert addition of `vhd` extention ...

2016-12-07 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1807 @syed @swill the change is good. What needs to be considered is what happens with old snapshots, from a older version upgraded to this version, that are without the .vhd extension

[GitHub] cloudstack issue #1763: CLOUDSTACK-9594: API "list templates templatefilter=...

2016-12-07 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1763 LGTM on code review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1763: CLOUDSTACK-9594: API "list templates templatefilter=...

2016-12-05 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1763 @sudhansu7 can you update on CLOUDSTACK-9376, were you able to check/test ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

2016-12-05 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1659 LGTM on code review and testing @murali-reddy @rhtyd --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1807: CLOUDSTACK-9633: Revert addition of `vhd` extention ...

2016-12-05 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1807 @syed yes I assume that PR in itself is good. You need to consider the broken test and broken upgrade ,where upgrading users will have path without the extension. --- If your

[GitHub] cloudstack issue #1807: CLOUDSTACK-9633: Revert addition of `vhd` extention ...

2016-12-05 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1807 @syed can you look at this 'revert' i guess this is going to be an issue with the managed storage change that has been put in. cc @rhtyd --- If your project is set up for it, you

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-12-05 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r91006590 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java --- @@ -538,7 +562,7

[GitHub] cloudstack issue #1784: CS-505: Marvin test to check VR internal DNS Service

2016-12-05 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1784 @rhtyd this can be merged if Murali feels multi nic test is also good to have we can add it later. cc @murali-reddy but lets not delay this as this test is complete in itself

[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...

2016-12-02 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1765 @rhtyd I have reverted to the sr name as it was. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request #1765: Cloudstack 9586: When using local storage wit...

2016-12-01 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1765#discussion_r90594670 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java --- @@ -100,36 +100,25

[GitHub] cloudstack issue #1765: Cloudstack 9586: When using local storage with Xense...

2016-12-01 Thread abhinandanprateek
Github user abhinandanprateek commented on the issue: https://github.com/apache/cloudstack/pull/1765 @jburwell rebased. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request #1600: Support Backup of Snapshots for Managed Stora...

2016-12-01 Thread abhinandanprateek
Github user abhinandanprateek commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1600#discussion_r90438253 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java --- @@ -538,7 +562,7

  1   2   3   4   5   >