[GitHub] cloudstack pull request #1996: CLOUDSTACK-9099: SecretKey is returned from t...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1996#discussion_r111075302 --- Diff: api/src/org/apache/cloudstack/api/command/admin/user/GetUserKeysCmd.java --- @@ -0,0 +1,76 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request #1996: CLOUDSTACK-9099: SecretKey is returned from t...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1996#discussion_r111075076 --- Diff: api/src/org/apache/cloudstack/api/command/admin/user/GetUserKeysCmd.java --- @@ -0,0 +1,76 @@ +// Licensed to the Apache Software

[GitHub] cloudstack pull request #1996: CLOUDSTACK-9099: SecretKey is returned from t...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1996#discussion_r111078382 --- Diff: server/src/com/cloud/api/ApiDBUtils.java --- @@ -559,6 +561,8 @@ @Inject private VpcManager vpcMgr; @Inject

Re: MySQL 5.7 and SQL Mode

Hi Wido, Check initDataSource() in TransactionLegacy.java. The connection properties are read from db.properties. -Koushik On 11/04/17, 10:27 PM, "Wido den Hollander" wrote: > Op 11 april 2017 om 10:51 schreef Rohit Yadav : > >

Re: growing #threads problem

Check the MS logs to see if there are OOM exceptions due to threads not available. If that’s the case then you may have to adjust nproc limits in /etc/security/limits.conf. On 11/04/17, 1:11 PM, "Daan Hoogland" wrote: My next step is to rebase my change to

[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1960 @abhinandanprateek Initially I also thought that this is about host HA. But after reading the FS I had doubts and asked about the definition of "host HA". If you refer to the

[GitHub] cloudstack issue #2032: CLOUDSTACK-9783: corrected the version number in met...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/2032 LGTM. Build is broken due to this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1960 There are open questions that I had asked in the dev@ list and haven't seen satisfactory answers to them. I am -1 on this feature till the need for a new VM HA framework is justified

[GitHub] cloudstack issue #2019: CLOUDSTACK-9851 travis CI build failure after merge ...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/2019 Code changes LGTM. @SudharmaJain Can you check on the travis failures? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack issue #1953: CLOUDSTACK-9794: Unable to attach more than 14 devic...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1953 @karuturi This PR is not correct and is resulting in travis CI failures. It needs to be properly fixed. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #2019: CLOUDSTACK-9851 travis CI build failure after merge ...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/2019 @SudharmaJain Although the PR fixes the tests but it is not correct. I looked at PR #1953 and the changes there are incorrect. getMaxDataVolumes() returns only the data volume count

[GitHub] cloudstack issue #1853: CLOUDSTACK-9696: Fixed Virtual Router deployment fai...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1853 Code change LGTM. @anshul1886 Please make sure Travis is green. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1867: CLOUDSTACK-9706: Added snapshots cleanup in start an...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1867 Code changes LGTM @anshul1886 Please check on travis failure --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1853#discussion_r106589966 --- Diff: server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java --- @@ -312,6 +317,65 @@ public DedicatedResourceVO findByHostId(Long hostId

[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1853#discussion_r106590720 --- Diff: server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java --- @@ -584,105 +583,64 @@ private void checkForNonDedicatedResources

[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1853#discussion_r106591079 --- Diff: server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java --- @@ -584,105 +583,64 @@ private void checkForNonDedicatedResources

[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1853#discussion_r106138864 --- Diff: server/src/com/cloud/dc/dao/DedicatedResourceDaoImpl.java --- @@ -312,6 +317,65 @@ public DedicatedResourceVO findByHostId(Long hostId

[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1853#discussion_r106142726 --- Diff: server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java --- @@ -584,105 +583,64 @@ private void checkForNonDedicatedResources

[GitHub] cloudstack pull request #1853: CLOUDSTACK-9696: Fixed Virtual Router deploym...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1853#discussion_r106145072 --- Diff: server/src/com/cloud/deploy/DeploymentPlanningManagerImpl.java --- @@ -584,105 +583,64 @@ private void checkForNonDedicatedResources

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1867#discussion_r106133214 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/SnapshotObject.java --- @@ -191,7 +191,8 @@ public void processEvent

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1867#discussion_r103894706 --- Diff: server/src/com/cloud/storage/snapshot/SnapshotManagerImpl.java --- @@ -1181,6 +1181,17 @@ public boolean configure(String name, Map<Str

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1867#discussion_r106134695 --- Diff: engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java --- @@ -194,18 +194,22 @@ protected

[GitHub] cloudstack pull request #1867: CLOUDSTACK-9706: Added snapshots cleanup in s...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1867#discussion_r106137098 --- Diff: server/src/com/cloud/storage/StorageManagerImpl.java --- @@ -1078,6 +1082,16 @@ public void cleanupStorage(boolean recurring

Re: [Proposal] - StorageHA

Hi Jeromy, Thanks for the proposal. It will good if you can create a FS in cwiki for the same. I saw your comment about force stopping VMs affected by primary storage outage. If this can be done without any issues then it can be leveraged to improve the current behavior of Cloudstack as well.

Re: :[VOTE] Apache Cloudstack 4.10.0.0

Looks like there is already a PR for the same issue https://github.com/apache/cloudstack/pull/1982 from Kishan. -Koushik On 03/03/17, 1:58 PM, "Rohit Yadav" wrote: -1 (binding) All, I've found an upgrade blocker. Pre 4.6 users are required to seed

[GitHub] cloudstack issue #1865: CLOUDSTACK-9705: Unauthenticated API allows Admin pa...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1865 Code changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request #1865: CLOUDSTACK-9705: Unauthenticated API allows A...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1865#discussion_r103875741 --- Diff: server/src/com/cloud/api/ApiServer.java --- @@ -430,8 +433,27 @@ public void handle(final HttpRequest request, final HttpResponse

[GitHub] cloudstack issue #1865: CLOUDSTACK-9705: Unauthenticated API allows Admin pa...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1865 @anshul1886 @karuturi Should this be treated as a security issue and fixed on priority? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1980: CLOUDSTACK-9805: Display VR list in network details

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1980 Is it only showing VR or other appliances providing service in that network? If it is the latter then the tab name is appropriate otherwise it is better to name it something like "Vi

[GitHub] cloudstack issue #1278: CLOUDSTACK-9198: Virtual router gets deployed in dis...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1278 I think disabled resource related checks are only applicable for regular users, root/system users can go ahead and deploy VMs in disabled resources as well. --- If your project is set up

[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1960 @abhinandanprateek If you refer to the discussion on dev@ https://goo.gl/cU8RuX, @rhtyd proposed it as a generic HA framework for any resources (and not limited to VM). Now if it just

[GitHub] cloudstack issue #1960: [4.11/Future] CLOUDSTACK-9782: Host HA and KVM HA pr...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1960 I have already raised some questions on dev@ on the need for a new HA framework when the existing HA framework can do all the things mentioned. The new framework only supports VM HA. If we

[GitHub] cloudstack pull request #:

Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/commit/fa85151be962824cc88776a0264e1ac6ef90560c#commitcomment-21082422 In server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java: In server/src/com/cloud/vm/snapshot

[GitHub] cloudstack issue #1975: Fix build failure on master

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1975 ping @karuturi --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack pull request #1975: Fix build failure on master

GitHub user koushik-das opened a pull request: https://github.com/apache/cloudstack/pull/1975 Fix build failure on master You can merge this pull request into a Git repository by running: $ git pull https://github.com/Accelerite/cloudstack build-failure Alternatively you can

[GitHub] cloudstack issue #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 err...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1886 Code changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1825: CLOUDSTACK-9660: NPE while destroying volumes during...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1825 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1968: CLOUDSTACK-9666 Added basic configuration validation...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1968 Code changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1967: CLOUDSTACK-9638 Problems caused when inputting doubl...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1967 Code change LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1964: Bug-Id: CLOUDSTACK-9800 Enabled netscaler inline mod...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1964 Code changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1825: CLOUDSTACK-9660: NPE while destroying volumes during...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1825 @karuturi This can be merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #1941: CLOUDSTACK-8663: Fixed various issues to allo...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1941#discussion_r102698293 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java --- @@ -1415,6 +1417,10 @@ public VM

[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1771#discussion_r102445777 --- Diff: server/src/com/cloud/network/NetworkServiceImpl.java --- @@ -3085,9 +3085,10 @@ public GuestVlan dedicateGuestVlanRange

[GitHub] cloudstack issue #1951: CLOUDSTACK-9792: Add upgrade path for 4.9.3.0

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1951 I already see schema-4920to41000.sql and the corresponding cleanup file in master. So how will this fit in the overall scheme? Is there any plans for 4.9.3? --- If your project is set up

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1773 I think changing the default API behaviour for fixing a bug should be ok as long as documented properly. Also in this case the deletion criteria is made more strict, so there is no unwanted

Re: [DISCUSS][FS] Host HA for CloudStack

uestions. Thanks. Regards. ____ From: Koushik Das <koushik@accelerite.com> Sent: 20 February 2017 11:45 To: dev@cloudstack.apache.org Subject: Re: [DISCUSS][FS] Host HA for CloudStack Rohit, Thanks for the effort y

Re: [DISCUSS][FS] Host HA for CloudStack

Rohit, Thanks for the effort you have put in writing the FS. I have some questions based on my initial reading of the FS. 1. “Host HA” – In the FS you are talking about a generic HA framework but it is not clear what is meaning of “host HA”. Is it something like all or some VMs running on a

[GitHub] cloudstack issue #1838: CLOUDSTACK-9682: Block VM migration to a storage whi...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1838 Code changes LGTM @karuturi This can be merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1771#discussion_r101486770 --- Diff: server/src/com/cloud/network/NetworkServiceImpl.java --- @@ -3085,9 +3085,10 @@ public GuestVlan dedicateGuestVlanRange

[GitHub] cloudstack issue #1829: CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1829 @borisstoyanov Sorry don't have a windows template --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1829: CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1829 @borisstoyanov try using a Windows template --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1834: CLOUDSTACK-9679:Allow master user to manage subordin...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1834 Code changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1758: CLOUDSTACK-9588: Add Load Balancer functionality in ...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1758 @karuturi This is ready for merge. UI change only, 2 LGTMs, UI screenshot --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request #1771: CLOUDSTACK-9611: Dedicating a Guest VLAN rang...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1771#discussion_r101451791 --- Diff: server/src/com/cloud/network/NetworkServiceImpl.java --- @@ -3085,9 +3085,10 @@ public GuestVlan dedicateGuestVlanRange

[GitHub] cloudstack issue #1786: CLOUDSTACK-9618: Load Balancer configuration page do...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1786 LGTM based on code review @karuturi Since this is a network plugin related fix and requires Netscaler, I don't think there is a need to run the BVTs. --- If your project is set up

[GitHub] cloudstack issue #1792: CLOUDSTACK-9623: Deploying virtual machine fails due...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1792 Code changes LGTM @nitin-maharana Can you check on the travis failure? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

Re: Attaching more than 14 data volumes to an instance

The hardcoded value of 15 needs to be fixed, it can be replaced with getMaxDataVolumesSupported() just above it. Please file a bug and if possible raise a PR as well. -Koushik On 15/02/17, 11:21 PM, "Voloshanenko Igor" wrote: On VM we try to emulate real

[GitHub] cloudstack issue #1889: CLOUDSTACK-9718: Revamp the dropdown showing lists o...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1889 LGTM based on code review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1885: CLOUDSTACK-9724: Fixed missing additional public ip ...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1885 Code changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request #1885: CLOUDSTACK-9724: Fixed missing additional pub...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1885#discussion_r100767709 --- Diff: server/src/com/cloud/network/IpAddressManagerImpl.java --- @@ -460,6 +460,12 @@ boolean checkIfIpAssocRequired(Network network, boolean

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1935#discussion_r100478202 --- Diff: server/src/com/cloud/user/DomainManagerImpl.java --- @@ -273,79 +274,97 @@ public boolean deleteDomain(long domainId, Boolean cleanup

[GitHub] cloudstack pull request #1935: CLOUDSTACK-9764: Delete domain failure due to...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1935#discussion_r100477949 --- Diff: server/src/com/cloud/user/DomainManagerImpl.java --- @@ -273,79 +274,97 @@ public boolean deleteDomain(long domainId, Boolean cleanup

[GitHub] cloudstack issue #1936: [CLOUDSTACK-9773] API: don't break API output with n...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1936 Code changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request #1906: CLOUDSTACK-9743 - ODL plugin responds to dele...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1906#discussion_r100281158 --- Diff: plugins/network-elements/opendaylight/src/main/java/org/apache/cloudstack/network/opendaylight/OpendaylightElement.java --- @@ -156,7

[GitHub] cloudstack issue #1930: CLOUDSTACK-9687: if the allocated amount is 0 the ca...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1930 Code changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1933: CLOUDSTACK-9569: add router.aggregation.command.each...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1933 @abhinandanprateek Looks like there is another PR #1856 related to this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request #1727: CLOUDSTACK-9539: Support changing Service off...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1727#discussion_r100267498 --- Diff: setup/db/db/schema-490to4910.sql --- @@ -71,3 +71,17 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervis

Re: re-introduction

Welcome back Daan! On 01/02/17, 1:56 PM, "Daan Hoogland" wrote: Hello, My name is Daan Hoogland. I've been mostly out of the community since May last year. I am now back through the generous sponsorship of my new employer and will be working

Re: Delete Volumes

Looks like a bug to me. Please file one in jira and if possible submit a PR to fix it. Thanks, Koushik On 13/01/17, 5:53 PM, "Wiesener, Erik" wrote: Hello CloudStack development team, It seems not very logical that the action : “delete Volume” is a

[GitHub] cloudstack issue #1819: CLOUDSTACK-9653 The system capacity was not getting ...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1819 Code changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request #1889: CLOUDSTACK-9718: Revamp the dropdown showing ...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1889#discussion_r95973044 --- Diff: api/src/org/apache/cloudstack/api/command/admin/host/ListHostsCmd.java --- @@ -206,7 +206,7 @@ public void execute() { } else

[GitHub] cloudstack pull request #1889: CLOUDSTACK-9718: Revamp the dropdown showing ...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1889#discussion_r95973392 --- Diff: ui/scripts/ui-custom/migrate.js --- @@ -0,0 +1,127 @@ +// Licensed to the Apache Software Foundation (ASF) under one --- End diff

[GitHub] cloudstack issue #1848: CLOUDSTACK-9693 Cluster View - Status symbol does no...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1848 @rashmidixit Please provide screenshots for UI changes (better if you also provide screenshot prior to the fix). Also for a cluster enabled/disabled and managed/unmanaged are different

[GitHub] cloudstack issue #1852: CLOUDSTACK-9695: VM snapshot is disabled if the VM I...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1852 @rashmidixit Code LGTM. Please provide screenshots of the changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1899: CLOUDSTACK-9650: Allow starting VMs regardless of cp...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1899 @rhtyd If you had checked #1812 you wouldn't have asked these questions :) This config was introduced in #1812 and the scope was incorrectly put as zone, the config is meant

[GitHub] cloudstack issue #1892: CLOUDSTACK-9731: Hardcoded label appears on the Add ...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1892 @sureshanaparti please post a screen shot of the UI change --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1899: CLOUDSTACK-9650: Allow starting VMs regardless of cp...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1899 @rhtyd Tests are present in #1812 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1899: CLOUDSTACK-9650: Allow starting VMs regardless of cp...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1899 Merging this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request #1727: CLOUDSTACK-9539: Support changing Service off...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1727#discussion_r95514039 --- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java --- @@ -350,6 +368,24 @@ public VMSnapshot allocVMSnapshot(Long vmId, String

[GitHub] cloudstack pull request #1727: CLOUDSTACK-9539: Support changing Service off...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1727#discussion_r95515374 --- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java --- @@ -338,10 +354,12 @@ public VMSnapshot allocVMSnapshot(Long vmId, String

[GitHub] cloudstack pull request #1727: CLOUDSTACK-9539: Support changing Service off...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1727#discussion_r95517419 --- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java --- @@ -707,16 +802,41 @@ private UserVm orchestrateRevertToVMSnapshot(Long

[GitHub] cloudstack pull request #1727: CLOUDSTACK-9539: Support changing Service off...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1727#discussion_r95517522 --- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java --- @@ -643,6 +679,65 @@ else if (jobResult instanceof Throwable

[GitHub] cloudstack pull request #1727: CLOUDSTACK-9539: Support changing Service off...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1727#discussion_r95514745 --- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java --- @@ -707,16 +802,41 @@ private UserVm orchestrateRevertToVMSnapshot(Long

[GitHub] cloudstack pull request #1727: CLOUDSTACK-9539: Support changing Service off...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1727#discussion_r95517926 --- Diff: setup/db/db/schema-490to4910.sql --- @@ -71,3 +71,17 @@ INSERT IGNORE INTO `cloud`.`guest_os_hypervisor` (uuid,hypervisor_type, hypervis

[GitHub] cloudstack pull request #1727: CLOUDSTACK-9539: Support changing Service off...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1727#discussion_r95516498 --- Diff: server/src/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java --- @@ -707,16 +802,41 @@ private UserVm orchestrateRevertToVMSnapshot(Long

[GitHub] cloudstack pull request #1727: CLOUDSTACK-9539: Support changing Service off...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1727#discussion_r95516609 --- Diff: engine/schema/src/com/cloud/vm/UserVmDetailVO.java --- @@ -80,4 +80,8 @@ public boolean isDisplay() { return display

[GitHub] cloudstack issue #1812: CLOUDSTACK-9650: Allow starting VMs regardless of cp...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1812 @rhtyd Sure will let you know if trillian tests are needed. In this case XS test results were already there from @cloudmonger. I used the git-pr script but not sure why the merge commit

[GitHub] cloudstack issue #1899: CLOUDSTACK-9650: Allow starting VMs regardless of cp...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1899 @ustcweizhou please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request #1899: CLOUDSTACK-9650: Allow starting VMs regardles...

GitHub user koushik-das opened a pull request: https://github.com/apache/cloudstack/pull/1899 CLOUDSTACK-9650: Allow starting VMs regardless of cpu/memory cluster.… …disablethreshold setting Fixed the scope of configuration flag 'cluster.threshold.enabled' introduced

[GitHub] cloudstack issue #1812: CLOUDSTACK-9650: Allow starting VMs regardless of cp...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1812 Looks like this is ready for merge. None of the test failures are related to this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack issue #1829: CLOUDSTACK-9363: Fix HVM VM restart bug in XenServer

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1829 @pdube The description mentions about a way to workaround the problem, thats the reason for not calling it a blocker. If you think the issue is important for the current 4.9 release, please

[GitHub] cloudstack issue #1882: CLOUDSTACK-8737: Removed the missed out-of-band VR r...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1882 Code changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request #1861: CLOUDSTACK-9698 Make hardcorded wait timeout ...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1861#discussion_r94206618 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java --- @@ -230,6 +230,7 @@ import

[GitHub] cloudstack pull request #1861: CLOUDSTACK-9698 Make hardcorded wait timeout ...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1861#discussion_r94206556 --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java --- @@ -123,12 +125,14 @@ import

[GitHub] cloudstack issue #1844: CLOUDSTACK-9668 : disksizeallocated of PrimaryStorag...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1844 LGTM. Unit tests? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1850: CLOUDSTACK-9694: Unable to limit the Public IPs in V...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1850 Code changes LGTM. Can you add some unit/marvin tests for the scenario that you have mentioned? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1841: CLOUDSTACK-9684 Invalid zone id error while listing ...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1841 Code changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1881: CLOUDSTACK-9721: Remove deprecated/unused global con...

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1881 Code changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request #1856: CLOUDSTACK-9569: propagate global configurati...

Github user koushik-das commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1856#discussion_r93603576 --- Diff: core/src/com/cloud/agent/api/SetHostParamsCommand.java --- @@ -0,0 +1,43 @@ +// +// Licensed to the Apache Software Foundation (ASF

[GitHub] cloudstack issue #1711: XenServer 7 Support

Github user koushik-das commented on the issue: https://github.com/apache/cloudstack/pull/1711 Code changes are good. In the last test run I am seeing test_01_primary_storage_iscsi is failing. Do we know the reason for that? --- If your project is set up for it, you can reply

  1   2   3   4   5   6   7   8   9   >