Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/2001
@rthyd I'm not sure if this was a joda time bug or (more likely) misuse of
joda time. I'm not even sure how best to verify that. All I know is that when
using the java data methods
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1955
I just re-depoyed and re-ran the test:
Test that libvirt properly created domain with scsi controller ... ===
TestName: test_01_verify_libvirt | Status : SUCCESS
GitHub user nathanejohnson opened a pull request:
https://github.com/apache/cloudstack/pull/2001
CLOUDSTACK-9830 Fix DST bug in QuotaAlertManagerTest
Replace the use of joda with Calendar, set explicitly to UTC when
doing date manipulation.
This fixes an issue where
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1955
@wido Actually I was just about to push a commit that changed the string to
enum, but builds are failing locally because of this test:
assertTrue
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1955
@wido I have removed all of the debug logging statements that didn't exist
before I touched the code, I have also added the discard option to the disks.
---
If your project is set up
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1955
@borisstoyanov Whenever you get a second could you kick off a blue
orangutan smoke test? I believe I have fixed the issue with ssh'ing into the
KVM hosts, I sue the IP now instead
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1955
Also, I just made a commit, I have not squashed it because I wanted to get
some feedback. I noticed that vmware uses details to pass rootDiskController
for the bus type
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1955
@borisstoyanov I have reworked the test so that it should now use the host
IP versus the hostname. Could you please re-run the blue orangutan test?
Thank you!
---
If your project
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1955
@borisstoyanov so the good news is it didn't skip the test. the bad news
is it didn't seem to have proper credentials for ssh'ing into your hosts. It
did pass the test where it ssh'ed
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1955
@borisstoyanov Quick questions, what tags need to be present to get picked
up by BO? I'm worried my smoke test might get skipped.
---
If your project is set up for it, you can reply
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1955
@wido I have removed the extraneous log messages.
@boris I have added a smoke test for this that tests both virsh output from
the host and lspci / lsblk output from the guest
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1955
As an update, I'm working on a Marvin test, and I'm also planning to
address wido's concerns. Today had many distractions unfortunately.
---
If your project is set up for it, you can
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1945
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user nathanejohnson commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1956#discussion_r102310032
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -744,14 +744,17 @@ protected boolean checkWorkItems(final
Github user nathanejohnson commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1956#discussion_r102309146
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -744,14 +744,17 @@ protected boolean checkWorkItems(final
Github user nathanejohnson commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1956#discussion_r102305779
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -744,14 +744,17 @@ protected boolean checkWorkItems(final
Github user nathanejohnson commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1956#discussion_r102298974
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -744,14 +744,17 @@ protected boolean checkWorkItems(final
Github user nathanejohnson commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1956#discussion_r102295771
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -744,14 +744,17 @@ protected boolean checkWorkItems(final
Github user nathanejohnson commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1956#discussion_r102290456
--- Diff:
engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ---
@@ -744,14 +744,17 @@ protected boolean checkWorkItems(final
GitHub user nathanejohnson opened a pull request:
https://github.com/apache/cloudstack/pull/1956
CLOUDSTACK-9796 - Fix NPE in VirtualMachineManagerImpl.java
This checks the work variable for NULL in all cases where it is
used. Fixes CLOUDSTACK-9796.
You can merge this pull
GitHub user nathanejohnson opened a pull request:
https://github.com/apache/cloudstack/pull/1955
CLOUDSTACK-8239 Add VirtIO SCSI support for KVM hosts
This is an initial implementation that we have working in the lab.
.
Thanks again!
---
If your project is set
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1694
@rhtyd I have an issue with circular dependencies trying to make the test
work with the new signature. In order to initialize the StoragePoolMonitor, I
need a DataStoreManagerImpl type
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1694
@rhtyd It appears that rolling this forward to 4.9 et al has broken builds.
The signature of the CreateStoragePool constructor changed between 4.8 and 4.9.
https://github.com
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1697
@blueorangutan could you send logs? I just verified that I could build a
centos 7 rpm from this branch, can't reproduce the failure.
Thanks!
---
If your project is set up
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1674
Code LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1697
@syed This is the PR we discussed on the call today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1697
Here are results running the following tests:
component/test_snapshots.py component/test_snapshots_improvement.py
component/test_snapshot_gc.py component/test_snapshot_limits.py
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1697
@jburwell @kiwiflyer @bvbharatk This is the new PR, I will post test
results soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user nathanejohnson opened a pull request:
https://github.com/apache/cloudstack/pull/1697
CLOUDSTACK-4858 Honors the snapshot.backup.rightafter configuration vâ¦
â¦ariable
Unhides snapshot.backup.rightafter from global configuration
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1644
@jburwell @kiwiflyer @bvbharatk I've gotten this to a place where I'm
feeling more comfortable with how it works, would you all like me to close this
PR, reopen it against 4.9
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@jburwell that is correct, the lab I tested on is running KVM + ceph.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@jburwell , test results were posted earlier in the thread.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1635
I did find one marvin test that does pass forced flag. Here are the
results.
https://gist.github.com/nathanejohnson/c4d1ffb8b61b19a8105dcb5326794b15
---
If your project is set
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1635
@jburwell sorry I've been silent, I've been on vacation for a bit and I
will be juggling plans this weekend as well. I plan to update this PR soon,
and as far as a Marvin test I am
Github user nathanejohnson commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1635#discussion_r76547668
--- Diff:
engine/api/src/org/apache/cloudstack/engine/cloud/entity/api/VirtualMachineEntity.java
---
@@ -115,6 +115,12 @@ String reserve
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@jburwell @si @wido
Here are the results of the nosetests. One test did throw an exception
during teardown, but I am not sure that this is anything to be concerned about
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@jburwell the smoke test completed successfully
Test Snapshot Root Disk ... === TestName: test_01_snapshot_root_disk |
Status : SUCCESS ===
ok
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@wido I don't know that the management server knows explicitly, it doesn't
actually seem to store the disk image format in the snapshot related tables at
all, only in volumes as far as I
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@jburwell as an update, the smoke test has completed successfully, and I'll
let the component tests run overnight. Hopefully they will have finished by
the morning.
---
If your
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@jburwell
I'm hoping that I can spend a good part of today on the requests you've
made on my three open pull requests.
---
If your project is set up for it, you can reply
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1645
@wido that seems to be the case, yes.
https://github.com/myENA/cloudstack/blob/44220a41c119020404c55e7a82a808ddee828116/plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1645
The snapshot in primary stays raw anyway, it's only the backup to secondary
that gets converted.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1645
```
before:
[njohnson@csm01.nsvltn secondary]$ ls -lh
snapshots/102/5022/a6baaf14-190a-4a06-b95a-5b502fbd7d06
-rw-r--r-- 1 root root 40G Aug 17 16:41
snapshots/102/5022
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1645
On KVM where primary storage is ceph / rbd, and a snapshot is backed up to
secondary, the comments seem to indicate that in this scenario the image will
be converted to qcow2 to save
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1644
Here is a snippet of the logs with storage.snapshot.backup.rightafter set
to false.
```2016-08-17 15:34:38,530 DEBUG [c.c.a.ApiServlet]
(catalina-exec-22:ctx-b9fb719f) (logid
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1644
`2016-08-17 15:34:38,530 DEBUG [c.c.a.ApiServlet]
(catalina-exec-22:ctx-b9fb719f) (logid:389a008f) ===START=== 10.16.0.21 -- GET
command=createSnapshot=json=c02b4f35-aed4-4c23-bbc3
GitHub user nathanejohnson opened a pull request:
https://github.com/apache/cloudstack/pull/1645
This converts the rbd raw format on disk to qcow2 for compression.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/myENA/cloudstack
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1644
I would like to get some feedback on this from the community, this has some
potentially unwanted side-effects with regards to usage-tracking. In the old
code, the amount of space used
GitHub user nathanejohnson opened a pull request:
https://github.com/apache/cloudstack/pull/1644
- Honors the snapshot.backup.rightafter configuration variable
- Unhides snapshot.backup.rightafter from global configuration
CLOUDSTACK-4858
You can merge this pull request
GitHub user nathanejohnson opened a pull request:
https://github.com/apache/cloudstack/pull/1635
CLOUDSTACK-9451
https://issues.apache.org/jira/browse/CLOUDSTACK-9451
Re-doing against 4.8 since this is a bug, not a feature.
You can merge this pull request into a Git
Github user nathanejohnson commented on the issue:
https://github.com/apache/cloudstack/pull/1632
@karaturi @ProjectMoon @rthyd I will close and reopen against 4.8, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user nathanejohnson closed the pull request at:
https://github.com/apache/cloudstack/pull/1632
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user nathanejohnson opened a pull request:
https://github.com/apache/cloudstack/pull/1632
Honor the forced parameter for stopVirtualMachine api call
CLOUDSTACK-9451
https://issues.apache.org/jira/browse/CLOUDSTACK-9451
You can merge this pull request into a Git
GitHub user nathanejohnson opened a pull request:
https://github.com/apache/cloudstack/pull/1522
Log asynchronous responses in the api log
Currently API responses for synchronous calls are logged, but asynchronous
call responses are not. This pull request makes a minor
64 matches
Mail list logo
