[GitHub] cloudstack issue #2044: CLOUDSTACK-9877 Cleanup unlinked templates

2017-04-14 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/2044 @DaanHoogland Not for us since we still use link clones but I am sure tons of other might be affected. Interestingly enough that with PR 1773 merged the default behavior in API is not to allow

[GitHub] cloudstack issue #2044: CLOUDSTACK-9877 Cleanup unlinked templates

2017-04-14 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/2044 @DaanHoogland Thanks. But for #1 the requirement for the code changes is that the template is deleted from cloudstack. In this condition restoreVirtualMachines when template ID is not specified

[GitHub] cloudstack issue #2044: CLOUDSTACK-9877 Cleanup unlinked templates

2017-04-14 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/2044 @DaanHoogland Can you clarify few questions/concerns 1. This change will likely to break restoreVirtualMachine functions. At the very least users should be able to turn off new behavior

[GitHub] cloudstack issue #1762: CLOUDSTACK-9595 Transactions are not getting retried...

2017-04-14 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1762 @yvsubhash Please, take this up. So far this PR hasn't moved forward. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #2043: CLOUDSTACK-9876: Removed test test_01_test_vm_volume...

2017-04-14 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/2043 LGTM on the code change. @borisstoyanov @rhtyd @DaanHoogland Can we re-kick vmware test for this PR? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1836: [4.10/master] Smoketest Health

2017-04-13 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1836 @rhtyd @karuturi This is a new improvement introduced in PR1941 that allows volume and VM snapshots to coexist. Now, test test_01_test_vm_volume_snapshot in test_vm_snapshots.py needs

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-04-05 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @borisstoyanov Let's re-run vmware B.O test for this PR now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #2002: CLOUDSTACK-9831: Previous pod_id still remains in th...

2017-03-30 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/2002 LGTM on the code review. @borisstoyanov @rhtyd Can you kick off tests for this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-30 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @priyankparihar Fortunately those API are already written. As per PR1767 you can get VM details including rootdiskcontroller using listVirtualMachines API and listTemplates. So if we

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

2017-03-28 Thread serg38
Github user serg38 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1813#discussion_r108580807 --- Diff: test/integration/smoke/test_deploy_vm_root_resize.py --- @@ -114,36 +134,46 @@ def test_00_deploy_vm_root_resize(self): # 2. root

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-28 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @borisstoyanov Can you also kick off vmware test in parallel? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-27 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @cloudsadhu Thanks for the changes. LGTM on the code review. @borisstoyanov @rhtyd @DaanHoogland Can you kick off another round of test for vmware and Xen for this PR ? --- If your project

[GitHub] cloudstack issue #2019: CLOUDSTACK-9851 travis CI build failure after merge ...

2017-03-27 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/2019 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #2017: CLOUDSTACK-9847 vm_network_map is not getting cleane...

2017-03-23 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/2017 @SudharmaJain Isn't it duplicate to PR1613 that is already merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

2017-03-20 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1994 @nvazquez Looks like Travis cant SSH into management server during the test . 2017-03-17 19:26:58,672 - DEBUG - mount -t nfs nfs:/export/automation/1/testprimary /mnt/marvin-1b4190cb

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

2017-03-14 Thread serg38
Github user serg38 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1813#discussion_r105932339 --- Diff: test/integration/smoke/test_deploy_vm_root_resize.py --- @@ -114,7 +114,13 @@ def test_00_deploy_vm_root_resize(self): # 2. root

[GitHub] cloudstack issue #2002: CLOUDSTACK-9831: Previous pod_id still remains in th...

2017-03-13 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/2002 @sudhansu7 Shouldn't we update POD id upon a successful migration? If migration fails we will have wrong POD id in the DB. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack issue #1253: CLOUDSTACK-9184: [VMware] vmware.ports.per.dvportgro...

2017-03-12 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1253 @sureshanaparti Why don't we just remove Config for this setting and leave default to be 8? Your logic to handle v4.1 will take care of old installations. As of May 2016 Vsphere 4.X

[GitHub] cloudstack issue #1257: CLOUDSTACK-9175: [VMware DRS] Adding new host to DRS...

2017-03-12 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1257 @sureshanaparti I've been thinking if there is better way to re-sync all portgroups and I couldn't come up with easy alternative. With that said if we are copying portgroups for newly added host

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-12 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @sadhugit NFS supports root disk resize with full clones. I don't see any restriction in the code and it actually works on Vmware no matter what kind of underlying storage technology is used

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

2017-03-10 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1994 @mike-tutkowski Can you test this fix in your environment? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-10 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @priyankparihar I think we need to improve smoke test test_deploy_vm_root_resize.py and introduce the logic you implemented in component test test_rootvolume_resize.py. We would want smoke

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

2017-03-10 Thread serg38
Github user serg38 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1813#discussion_r105409367 --- Diff: test/integration/component/test_rootvolume_resize.py --- @@ -0,0 +1,1140 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

2017-03-09 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1994 @rhtyd @borisstoyanov Can you kick off new tests for this release blocker? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-09 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @borisstoyanov @rhtyd Can you kick off new round of tests for this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

2017-03-09 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1994 @nvazquez Is storage_tag_view still in use after this change that reference old way of retrieving the tags? If not should we remove it? E.g. host tags don't have a separate view. --- If your

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

2017-03-08 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1994 @nvazquez Should we simply replace storage_tag_view instead of switching queries over to another view? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1994: CLOUDSTACK-9827: Storage tags stored in multiple pla...

2017-03-08 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1994 @mike-tutkowski @karuturi @koushik-das @rafaelweingartner Please review the fix for 4.10 blocker --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #793: CLOUDSTACK-8827: Move the VM snapshots stuck in trans...

2017-03-07 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/793 @anshul1886 I am curious if there is a way to cancel stuck vmsnapshot jobs without restarting management server. E.g. VM deployment go to error start upon any failure in the process

[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...

2017-03-07 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1774 LGTM tag: mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1879: CLOUDSTACK-9719: [VMware] VR loses DHCP settings and...

2017-03-06 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1879 LGTM @nvazquez Can we test it with shared networking? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1989: WIP: support for multidisk OVA files

2017-03-06 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1989 @abhinandanprateek I am curious if this PR will allow deploying VM with Data disk attached? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-03-06 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1961 LGTM tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-05 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @borisstoyanov Thanks. Can you check in B.O. what is value of global configuration 'vmware.create.full.clone', if the same configuration is set for the primary storage pool and if so what

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-03 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 Still fails but error is different now Exception: Job failed: {jobprocstatus : 0, created : u'2017-03-03T09:20:53+', jobresult : {errorcode : 530, errortext : u'Unable to start a VM due

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-03-03 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1961 @rhtyd @borisstoyanov did you have a chance to add nfs2 test data in B.O. ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-03-02 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @borisstoyanov Can you kick off B.O for Vmware again? Hopefully it will pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack issue #1774: CLOUDSTACK-9608: Errored State and Abandoned state T...

2017-03-01 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1774 @borisstoyanov That would be awesome . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #1813: CLOUDSTACK-9604: Root disk resize support for...

2017-03-01 Thread serg38
Github user serg38 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1813#discussion_r103719599 --- Diff: server/src/com/cloud/vm/UserVmManagerImpl.java --- @@ -3614,6 +3604,26 @@ public UserVmVO doInTransaction(TransactionStatus status) throws

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-02-28 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @rhtyd @borisstoyanov @DaanHoogland Can we get B.O. management server log to check why exception is generated? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-28 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1773 Thanks @priyankparihar . We verified in our environment that all is working fine including UI part. LGTM I think this one is tag:mergeready --- If your project is set up

[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

2017-02-26 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1935 @rhtyd @karuturi To fix errors in B.O in test_02_list_snapshots_with_removed_data_store we need to merge PR1961 and then adjust test_data on B.O side to have correct mapping for nfs2 label

[GitHub] cloudstack issue #1935: CLOUDSTACK-9764: Delete domain failure due to Accoun...

2017-02-23 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1935 @rafaelweingartner Can you review latest updates from @nvazquez . Since tests are passing this PR will be ready for merging to 4.10 --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request #1958: CLOUDSTACK-5806: add presetup to storage type...

2017-02-23 Thread serg38
Github user serg38 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1958#discussion_r102753237 --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- @@ -508,7 +507,7 @@ public String updateConfiguration(final long userId

[GitHub] cloudstack issue #1941: CLOUDSTACK-8663: Fixed various issues to allow VM sn...

2017-02-23 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1941 @borisstoyanov @rhtyd Can we re-test this with B.O. ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-02-23 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1961 @karuturi I agree with @nvazquez . This PR can be safely merged and then B.O. runtime environment needs to be adjusted to define nfs2 mountpoint in test_data.py --- If your project is set up

[GitHub] cloudstack issue #1961: Fix for test_snapshots.py using nfs2 instead of nfs ...

2017-02-22 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1961 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...

2017-02-22 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @karuturi @anshul1886 Can we tweak line 278 of test_snaphsot.py from self.services["nfs"], to self.services["nfs2"], and re-merge this PR so

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-22 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1773 @priyankparihar Well. API use cases can be recoded but not UI. Presently we can delete templates in UI even with active VMs. With your changes there will be no recourse. An easy option

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-22 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1773 @priyankparihar A part is still missing that will use forced option in UI but give a user option to cancel deletion if active VMs exist --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-21 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1773 @jburwell That was default behavior for few years to allow deletion of the template even if active VMs exist. Deletion of the template on secondary doesn't remove the template copy on primary

[GitHub] cloudstack issue #1768: CLOUDSTACK 9601: Upgrade: change logic for update pa...

2017-02-21 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1768 @marcaurele I tend to agree with @rhtydthat it could break some of the upgrades. If I get it right with your proposed changes, upgrade scripts become obsolete since all the changes can be done

[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...

2017-02-20 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @nvazquez @rhtyd @anshul1886 We might need to tweak the test_data.py to add additional nfs mount e.g. nfs1 and use it in this test. E.g adding "nfs1": { "u

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-20 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1773 @ustcweizhou @priyankparihar @borisstoyanov The default behavior was always equivalent of force=true. We seem to agree that the UI behavior should remain forced=true but with extra warning. We

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-17 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1773 @priyankparihar @ustcweizhou There seems to be just one case where it will affect resetVM operations. If template is deleted and root disk is migrated to another PS where there is no template

[GitHub] cloudstack issue #1773: CLOUDSTACK-9607: Preventing template deletion when t...

2017-02-17 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1773 @priyankparihar I agree with @ustcweizhou . Default behavior should remain forced. And in this case Web UI we should give a warning with "yes and no" if template has deployed VM so

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-02-16 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @priyankparihar Resize test still fails on vmware. It is hard to see the reason in blueorangutain output but you might want to make sure the test provisioning uses full clones via setting

[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...

2017-02-16 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1913 @karuturi This one is ready for merging. LGTM and test results are positive. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...

2017-02-16 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1913 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-02-15 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @priyankparihar You need to adjust smoke test test_deploy_vm_root_resize.py to support vmware root resize. Otherwise it will keep failing 2017-02-15 12:48:59,150 - CRITICAL - FAILED

[GitHub] cloudstack issue #1813: CLOUDSTACK-9604: Root disk resize support for VMware...

2017-02-15 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1813 @borisstoyanov Looks like some environmental issues with backend NFS. Can you kick it again for vmware ? u'2017-02-15T20:21:38+', jobresult : {errorcode : 530, errortext : u'Failed

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-13 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1727 @karuturi This one is ready for merging. Two LGTMs + tests passing on all 3 hypervisors --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack issue #927: secure and hidden config values are returned as plain...

2017-02-13 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/927 @karuturi Smoke test test_internal_lb.py uses a value of network.loadbalancer.haproxy.stats.auth which is encrypted for haproxy checks. settings["username"]

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-10 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1727 @borisstoyanov @DaanHoogland @rhtyd KVM tests passed but key smoke test is skipped test_change_service_offering_for_vm_with_snapshots Skipped To be on the safe side can we test

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-09 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1727 @DaanHoogland @borisstoyanov @rhtyd Guys can you kick off tests for this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

2017-02-09 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1747 @karuturi Test passed. Two LGTM received. Looks like it is ready for merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

2017-02-09 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1747 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

2017-02-08 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1747 @rafaelweingartner Do we get you LGTM? @DaanHoogland @rhtyd Can we kick off tests for this? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

2017-02-07 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1747 @rafaelweingartner This PR is two fold. 1. This is something that was done a long ago for hosts and was never implemented for storage. It transitions location of of storage tags over

[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...

2017-02-07 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1767 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

2017-02-07 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1747 @rafaelweingartner Can you review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-07 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1727 @koushik-das @rhtyd @rafaelweingartner Can you review changes @nvazquez put in place? CI tests are good. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-02-07 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1727 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1913: CLOUDSTACK-9752: [Vmware] Optimization of volume att...

2017-01-27 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1913 @rhtyd @karuturi Can we run vmware tests on this PR and merge on success ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1905: CLOUDSTACK-9738: Optimize vm expunge process for ins...

2017-01-27 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1905 @rhtyd @karuturi Can we run tests on this PR and merge on success ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...

2017-01-27 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1767 @karuturi Can we merge this one ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

2017-01-27 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1747 @rhtyd @karuturi Can we run tests on this PR and merge on success ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-01-27 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1727 @rhtyd @karuturi Can we run tests on this PR and merge on success ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1833: BUG-ID:CLOUDSTACK-9678

2017-01-24 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1833 @pdumbre I confirm your observation. LGTM on code review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack issue #1711: XenServer 7 Support

2017-01-21 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1711 Yes it is in 4.9.2. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-01-16 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1727 @nvazquez Since 4.9.2 is already released and this is not a bugfix the DB changes should go to schema-490to4910.sql --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack issue #1888: CLOUDSTACK-9710: Switch to JRE1.8

2017-01-14 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1888 We need to change one more setting for noredist build to work with updated iControl version in install-non-oss.sh mvn install:install-file -Dfile=cloud-iControl.jar      -DgroupId

[GitHub] cloudstack issue #1901: [4.9] CLOUDSTACK-9405: add details parameter in list...

2017-01-13 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1901 Thanks @ustcweizhou LGTM for code review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request #1901: [4.9] CLOUDSTACK-9405: add details parameter ...

2017-01-12 Thread serg38
Github user serg38 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1901#discussion_r95828294 --- Diff: api/src/org/apache/cloudstack/api/command/admin/domain/ListDomainsCmd.java --- @@ -53,6 +59,12 @@ description = "I

[GitHub] cloudstack issue #1735: CLOUDSTACK-9570: Bug in listSnapshots for snapshots ...

2017-01-10 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1735 @mike-tutkowski The only comments in this PR are about deletion of PS with a snapshot copy. I am 100% agree with your statement. This PR excludes destroyed snapshot copies including ones

[GitHub] cloudstack issue #1747: CLOUDSTACK-9574: Redesign storage views

2017-01-10 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1747 @rhtyd Can you kick off tests fro this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1767: CLOUDSTACK-9457: Allow retrieval and modification of...

2017-01-10 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1767 @rhtyd Can you kick off tests for this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1735: CLOUDSTACK-9570: Bug in listSnapshots for snapshots ...

2017-01-10 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1735 @mike-tutkowski @anshul1886 @rhtyd We had enough LGTM and successful test results for this PR. Are there any concern before merging it? --- If your project is set up for it, you can reply

[GitHub] cloudstack issue #1727: CLOUDSTACK-9539: Support changing Service offering f...

2017-01-10 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1727 @koushik-das @rhtyd This PR now supports custom service offerings. Can you review and kick off tests? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1899: CLOUDSTACK-9650: Allow starting VMs regardless of cp...

2017-01-10 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1899 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #977: [4.10] CLOUDSTACK-8746: VM Snapshotting implementatio...

2017-01-09 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/977 @rhtyd @ustcweizhou We need to enable smoke tests for vmsnaphsots for KVM in test_vm_snapshots.py if cls.hypervisor.lower() in (KVM.lower(), "hyperv&q

[GitHub] cloudstack issue #1847: CLOUDSTACK-9691: Fixed unhandeled excetion in list s...

2017-01-02 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1847 @mike-tutkowski @anshul-gangwar @nvazquez I believe the same issue is addressed in PR1735 but in a more consistent fashion --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack issue #1876: CLOUDSTACK-9715: Update somaxconn value to default v...

2016-12-29 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1876 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack-www pull request #32: Adding Sergey and Nicolas to commiters

2016-12-28 Thread serg38
Github user serg38 closed the pull request at: https://github.com/apache/cloudstack-www/pull/32 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack-www pull request #30: Added Sergey and Nicolas to committers

2016-12-27 Thread serg38
Github user serg38 closed the pull request at: https://github.com/apache/cloudstack-www/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack-www pull request #31: Adding Sergey and Nicolas to committers

2016-12-27 Thread serg38
Github user serg38 closed the pull request at: https://github.com/apache/cloudstack-www/pull/31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack-www pull request #32: Adding Sergey and Nicolas to commiters

2016-12-27 Thread serg38
GitHub user serg38 opened a pull request: https://github.com/apache/cloudstack-www/pull/32 Adding Sergey and Nicolas to commiters You can merge this pull request into a Git repository by running: $ git pull https://github.com/serg38/cloudstack-www master Alternatively you

[GitHub] cloudstack-www pull request #31: Addingn Sergey and Nicolas to committers

2016-12-27 Thread serg38
GitHub user serg38 opened a pull request: https://github.com/apache/cloudstack-www/pull/31 Addingn Sergey and Nicolas to committers You can merge this pull request into a Git repository by running: $ git pull https://github.com/serg38/cloudstack-www patch-2 Alternatively you

[GitHub] cloudstack-www pull request #30: Added Sergey and Nicolas to committers

2016-12-27 Thread serg38
GitHub user serg38 opened a pull request: https://github.com/apache/cloudstack-www/pull/30 Added Sergey and Nicolas to committers You can merge this pull request into a Git repository by running: $ git pull https://github.com/serg38/cloudstack-www patch-1 Alternatively you

[GitHub] cloudstack issue #1846: CLOUDSTACK-9688: Fix failing smoke tests

2016-12-21 Thread serg38
Github user serg38 commented on the issue: https://github.com/apache/cloudstack/pull/1846 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

  1   2   3   >