Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/2003
ok. Thanks everyone. I am merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@karuturi we have 3 LGTMs, I think we're good to merge this.
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
I think #2011 fixes the observed issue, but this PR improves the IP
ordering fix originally added to the strongswan pr. This implementation
ensures (again) that duplicate public ips will not be
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@karuturi to be honest, I think PR#2011 fixes the issue, not this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@rhtyd I think this was introduced with the StrongSwan implementation which
was 4.10 I think.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/2003
LGTM, does this affect 4.9 as well @swill ? /cc @borisstoyanov
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@ustcweizhou can you also review this fix? Is pr #2011 still required?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@DaanHoogland you could review it as well it addressed in
https://github.com/apache/cloudstack/pull/2011/files
---
If your project is set up for it, you can reply to this email and have
Github user DaanHoogland commented on the issue:
https://github.com/apache/cloudstack/pull/2003
code LGTM but @ustcweizhou 's patch still makes sense to me. Maybe you can
add that separately? travis still fails!
---
If your project is set up for it, you can reply to this email and
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/2003
ping @rhtyd @DaanHoogland @abhinandanprateek @PaulAngus for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/2003
Trillian test result (tid-958)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31840 seconds
Marvin logs:
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has
been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
thank you sir. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@blueorangutan test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has
been kicked to run smoke tests
---
If your project is set up for it, you can reply to this email and have your
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/2003
Packaging result: âcentos6 âcentos7 âdebian. JID-594
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep
you posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/2003
not sure about the CI tests @swill, I think the easiest way to kick Travis
tests is the close/reopen the PR.
I'll pick it up as soon as possible. I'll rebuild and run the smoketests.
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@borisstoyanov alright, this is ready for you to start testing. Can you
kick off CI on this as well?
I will be doing testing of this locally as well.
This implementation is
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
Thanks @remibergsma. I am going to use `source_nat` as it better
represents what it is I am trying to establish and it seems to always be in the
object where `first_i_p` does not always seem to
Github user remibergsma commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@swill FYI if you look for `first_i_p` as seen in the json on the Python
side, then on the Java side it's called `firstIP`, as the gson lib replaces
every capital with an underscore and
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@borisstoyanov could you please test with my suggestion? I think it should
fix the duplicated nics in VR.
---
If your project is set up for it, you can reply to this email and have your
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/2003
Hi @swill, could you please let us know when do you expect to address the
changes you have mentioned, so I could schedule the testing accordingly. Thanks.
---
If your project is set up
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
I am considering changing my implementation to be the same as the old
implementation (which removed the IP from the dbag in the initial loop of the
merge), but if `source_nat` is present and it
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@borisstoyanov
I suspect this is caused by the name of your public interface (p55p1).
can you please try the following change
```
diff --git
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/2003
Thanks @ustcweizhou
here's the StartCommand log
```
2017-03-16 08:48:46,068 DEBUG [cloud.agent.Agent]
(agentRequest-Handler-3:null) (logid:be1f1987) Request:Seq
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@borisstoyanov I think this is caused by KVM plugin.
can you please perform the following on KVM host ?
(1) change INFO to DEBUG in /etc/cloudstack/agent/log4j-cloud.xml, and
restart
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@swill
first_i_p in json -> firstIP in java. This is formatted by google.gson
it is defined in api/src/com/cloud/agent/api/to/IpAddressTO.java, and used
in
Github user swill commented on the issue:
https://github.com/apache/cloudstack/pull/2003
Does anyone know what `first_i_p` represents in the `ips.json` dbag? I am
assuming it is the Source NAT IP, but I can't find it represented anywhere in
the code (other than in a test). If it
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/2003
nics in database seems ok, so it looks some issue in creating
ip_associations.json
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user borisstoyanov commented on the issue:
https://github.com/apache/cloudstack/pull/2003
@ustcweizhou
- I was able to restart the network with cleanup. New VR came up with
duplicated eth2 and eth3.
