Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@karuturi Do you happen to have any resources we can use to fulfill John's
test requests? Thanks
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@mike-tutkowski the background makes sense. I would like to see that
comment amended to commit message. I have the following outstanding
questions/items:
1. Is there a JIRA ticket
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@mike-tutkowski I am +1 on the changes and ready to merge from my end.
Once you and @jburwell come to an agreement, I will merge.
---
If your project is set up for it, you can reply to this
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1642
How are we doing on this one? Do my comments above make sense to everyone?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@jburwell Let me provide a bit of additional background for this PR.
As noted in the initial comment, it was possible to spin up system VMs on
managed storage prior to this PR.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@mike-tutkowski @karuturi it seems like this PR should have all smoke tests
+ system VM integration test suites (SSVM, CPVM, and VR) + the new test
integration test suite added for this PR run
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@jburwell I changed the sleep/delay to a wait_until.
Here is the most recent test run for this integration test:
test_01_create_system_vms_on_managed_storage
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1642
Just a note that @syed and I discussed his idea and decided to open a
separate PR for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@karuturi I think John is just asking if we can run test_ssvm.py (a smoke
test) on VMware and KVM.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@jburwell
My test run is on NFS. I dont have managed storage.
Are you running the tests on managed storage with KVM and VMWare?
---
If your project is set up for it, you can reply to
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1642
Oh @jburwell I thought you were asking for new regression tests to be
created. I think you and I are on the same page now.
---
If your project is set up for it, you can reply to this
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@mike-tutkowski the reason I would like the regression tests run is to
confirm that assumption.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@jburwell At present, this is really only supported on XenServer. As long
as our other integration tests don't fail due to anything in here, we should be
OK.
---
If your project is set
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@mike-tutkowski sorry I forgot the precise way to do it -- thanks for
digging it out. It makes tests far more resilient to differences between test
environments.
As I mentioned
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@jburwell I now retrieve the template in a non-hard-coded manner. I
attached a diff because I squashed the commit and force pushed it up to GitHub.
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1642
I think I know how to acquire the template name without hard-coding it now:
cls.template = get_template(
cls.apiClient,
zone.id,
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1642
Hey @syed I like your idea here. How's about we work on a separate PR for
it so that I can incorporate your idea into all of the integration scripts I
have?
---
If your project is set
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@syed Yeah, I'd like to externalize that data. I just haven't taken the
time to investigate how that works with Marvin. :)
---
If your project is set up for it, you can reply to this
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@mike-tutkowski Currently, all the info in the `TestData` is hardcoded.
Would it be possible to add a system to override some values so that I can test
this as well (IP addresses for example)?
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@karuturi I had posted this earlier in the PR. Is this OK?
Also, I have run the following tests (all successfully):
TestVolumes.py (both
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@koushik-das "Currently is solidfire the only managed storage provider?"
CloudByte is a managed-storage provider, but I have not seen them active in our
community for years now. These
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@jburwell Do you know what that standard way of acquiring a template name
is? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@koushik-das didn't notice that path, but completely agree. I'd like to
see a generic test requirement for managed storage which make the test cases
more reusable for future storage drivers.
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@mike-tutkowski Thanks for adding marvin tests. Some observations regarding
the tests.
I see that you have put the tests under solidfire folder. Currently is
solidfire the only managed
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1642
That is exactly what I said in my last comment. I am waiting for mike to
resolve it so that I can merge. That is the only pending item on this PR.
---
If your project is set up for it, you
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@karuturi there remains the issue of the hard coded template name.
Therefore, I am -1 until the issue of the hardcoded template name is addressed.
These hardcoded values cause massive
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@mike-tutkowski can you address @jburwell's comment? other than that, its
ready to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user cloudmonger commented on the issue:
https://github.com/apache/cloudstack/pull/1642
### ACS CI BVT Run
**Sumarry:**
Build Number 97
Hypervisor xenserver
NetworkType Advanced
Passed=103
Failed=0
Skipped=4
_Link to logs Folder
Github user karuturi commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@mike-tutkowski started our internal CI run on this PR(xen server
advanced). It will run the smoke tests and post the results here. once it
confirms there are no regressions, I will merge this
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@syed @rhtyd @jburwell I have provided new integration tests for this PR.
Also, I have run the following tests (all successfully):
TestVolumes.py (both with and without
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1642
Sounds good, @jburwell
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@mike-tutkowski we usually increase the garbage collection frequency and
reduce any wait time global settings in order to speed up tests. Coupled with
the wait_until Marvin, you build fairly
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1642
Ah, I think I "jumped the gun" on this. It looks like the three SRs (and
corresponding volumes on the SAN) were to be deleted by a background thread
(which I didn't wait for).
I
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1642
I have been performing additional tests manually on this PR and noticed one
issue that I want to investigate:
When I put the managed primary storage that the system VMs are
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@mike-tutkowski determining the required tests to run for a PR is at the
top of my TODO list. For now, I would say running all smoke tests and
associated component tests on hardware would
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@jburwell Have we as a community defined what a test review must encompass?
Is there a set of particular tests that must generally be run for each PR?
---
If your project is set up for
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@mike-tukowski any committer may merge a PR with at least one code review
LGTM, at least one test LGTM, and no -1s. For this PR, I don't see a test LGTM
with test results. Until it has at
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1642
Thank you both for providing your reviews and subsequent LGTMs. :)
I believe this PR is ready to be merged.
Who is responsible for doing that these days? Can I or do we
Github user syed commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@mike-tutkowski the code LGTM. We have a managed storage in-house. I will
run it there and report if I see any problems.
---
If your project is set up for it, you can reply to this email
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1642
Thanks @rhtyd for the review!
I believe @syed will provide a review when he has time, as well.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1642
Packaging result: âcentos6 âcentos7 âdebian repo:
http://packages.shapeblue.com/cloudstack/pr/1642
Job ID-88
---
If your project is set up for it, you can reply to this email
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@blueorangutan package
@mike-tutkowski LGTM, we don't have any hardware to test it. I guess since
builds have passed and if packaging passes too, we can merge with enough
reviews.
---
Github user blueorangutan commented on the issue:
https://github.com/apache/cloudstack/pull/1642
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you
posted as I make progress.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mike-tutkowski commented on the issue:
https://github.com/apache/cloudstack/pull/1642
Here is a screen capture on the changes to the System Service Offering
dialog.
[](url)
44 matches
Mail list logo
