Re: [PROPOSAL] remove travis pull request checks from github

2015-10-30 Thread Rajani Karuturi
Jenkins though unstable is right at what it does. That is, if its green, the build works fine, there are no check style errors, there are no new PMD/Findbugs errors etc. On the other hand, Travis green/red doesnt say anything at the moment. It can be red due to a timeout and sometimes its green

Re: [PROPOSAL] remove travis pull request checks from github

2015-10-30 Thread Daan Hoogland
On Fri, Oct 30, 2015 at 7:05 AM, Rajani Karuturi wrote: ​+1'ed and further > On Fri, Oct 30, 2015 at 4:55 AM, David Nalley wrote: > > > 2 hours before this message was sent, there was a message about > > jenkins being unreliable. > ​both are not perfect,

Re: [PROPOSAL] remove travis pull request checks from github

2015-10-29 Thread Daan Hoogland
The apache build reports rats, findbugs, pmd, coverage etc. On Thu, Oct 29, 2015 at 12:28 PM, Miguel Ferreira < mferre...@schubergphilis.com> wrote: > It would add speed. > > Just for running maven we could move the travis build to their docker > based infra which is faster than what we use now.

Re: [PROPOSAL] remove travis pull request checks from github

2015-10-29 Thread Daan Hoogland
On Thu, Oct 29, 2015 at 2:22 PM, Sebastien Goasguen wrote: > > > On Oct 29, 2015, at 2:19 PM, Daan Hoogland > wrote: > > > > Sebastien, it is not urgent but costing us time > > so just don;t look at it ? > ​no-op. it is there telling people that

Re: [PROPOSAL] remove travis pull request checks from github

2015-10-29 Thread Miguel Ferreira
It would add speed. Just for running maven we could move the travis build to their docker based infra which is faster than what we use now. I’m guess that the apache build does more stuff like packaging RPMs, but I’m not sure there. \ Miguel Ferreira

Re: [PROPOSAL] remove travis pull request checks from github

2015-10-29 Thread Daan Hoogland
On Thu, Oct 29, 2015 at 2:38 PM, Sebastien Goasguen wrote: > > On Oct 29, 2015, at 2:28 PM, Daan Hoogland > wrote: > > On Thu, Oct 29, 2015 at 2:22 PM, Sebastien Goasguen > >>> On Oct 29, 2015, at 2:19 PM, Daan Hoogland

Re: [PROPOSAL] remove travis pull request checks from github

2015-10-29 Thread Daan Hoogland
Sebastien, it is not urgent but costing us time and more important costing time of 'innocent' contributors. So ... revert at your will. On Thu, Oct 29, 2015 at 1:44 PM, Sebastien Goasguen wrote: > Not surprisingly I like Travis, because it outsources the “tests” and that > we

Re: [PROPOSAL] remove travis pull request checks from github

2015-10-29 Thread Sebastien Goasguen
Not surprisingly I like Travis, because it outsources the “tests” and that we can fix them by editing .travis.yml, which can be done by someone without access to the Jenkins servers/slaves. At the very least I agree with Miguel which should keep the mvn build, and possible rat etc…

Re: [PROPOSAL] remove travis pull request checks from github

2015-10-29 Thread Sebastien Goasguen
> On Oct 29, 2015, at 2:19 PM, Daan Hoogland wrote: > > Sebastien, it is not urgent but costing us time so just don;t look at it ? > and more important costing > time of 'innocent' contributors. What do you mean by that, I am not understanding. > So ... revert at

Re: [PROPOSAL] remove travis pull request checks from github

2015-10-29 Thread Sebastien Goasguen
> On Oct 29, 2015, at 2:28 PM, Daan Hoogland wrote: > > On Thu, Oct 29, 2015 at 2:22 PM, Sebastien Goasguen > wrote: > >> >>> On Oct 29, 2015, at 2:19 PM, Daan Hoogland >> wrote: >>> >>> Sebastien, it is not urgent but

Re: [PROPOSAL] remove travis pull request checks from github

2015-10-29 Thread David Nalley
2 hours before this message was sent, there was a message about jenkins being unreliable. So I am starting to think that something other than Travis or Jenkins is the problem. --David On Thu, Oct 29, 2015 at 5:33 PM, Daan Hoogland wrote: > Guys and dolls, > > We have

[PROPOSAL] remove travis pull request checks from github

2015-10-29 Thread Daan Hoogland
Guys and dolls, We have been having travis builds for a while now and they seem to generate more work then help. There are a lot of time-outs, (false positive) and when a suite passes it is often because all tests where skipped (false negative). In addition, and this may be just me, I've never

Re: [PROPOSAL] remove travis pull request checks from github

2015-10-29 Thread Remi Bergsma
+1 it doesn’t help like this. I look at actual test result people post combined with code reviews. Plus an OK from Jenkins should be more than enough to judge a PR. Let’s make Jenkins more reliable, that would help as well. Regards, Remi On 29/10/15 10:33, "Daan Hoogland"

Re: [PROPOSAL] remove travis pull request checks from github

2015-10-29 Thread Miguel Ferreira
I do agree that at the moment Travis is either creating false sense of security when it is green, or a burden for contributors when it is red, because most of the time it goes red for no good reason. However, I would still find it valuable to have travis run a single command: mvn clean isntall

Re: [PROPOSAL] remove travis pull request checks from github

2015-10-29 Thread Daan Hoogland
On Thu, Oct 29, 2015 at 10:51 AM, Miguel Ferreira < mferre...@schubergphilis.com> wrote: > However, I would still find it valuable to have travis run a single > command: > mvn clean isntall -P developer,systemvv > > That is because, still many people commenting on PRs don’t even do that. > In