Re: CallFunctionNode problems in trunk

2006-05-14 Thread Carsten Ziegeler
Reinhard Poetz schrieb: Carsten Ziegeler wrote: Ok, so let's change the strategy and fix the standalone service selector... :) If svn works again I can do this on monday evening - if noone beats me to it. I didn't fix the StandaloneServiceSelector but replaced it with a factory.

Re: CallFunctionNode problems in trunk

2006-05-14 Thread Reinhard Poetz
Carsten Ziegeler wrote: Reinhard Poetz schrieb: Carsten Ziegeler wrote: Ok, so let's change the strategy and fix the standalone service selector... :) If svn works again I can do this on monday evening - if noone beats me to it. I didn't fix the StandaloneServiceSelector but replaced it

Re: CallFunctionNode problems in trunk

2006-05-14 Thread Carsten Ziegeler
Reinhard Poetz wrote: Right, but that's easily fixed (see http://people.apache.org/~reinhard/ProcessingNodeBuilderFactory.java). I would prefer getting rid of the StandaloneServiceSelector as it is everything else than a simple class for a simple task and why do all those builders need

Re: CallFunctionNode problems in trunk

2006-05-14 Thread Sylvain Wallez
Reinhard Poetz wrote: Carsten Ziegeler wrote: Reinhard Poetz schrieb: Carsten Ziegeler wrote: Ok, so let's change the strategy and fix the standalone service selector... :) If svn works again I can do this on monday evening - if noone beats me to it. I didn't fix the

Re: CallFunctionNode problems in trunk

2006-05-13 Thread Reinhard Poetz
Carsten Ziegeler wrote: Ok, so let's change the strategy and fix the standalone service selector... :) If svn works again I can do this on monday evening - if noone beats me to it. I didn't fix the StandaloneServiceSelector but replaced it with a factory. Basically the factory works for me

Re: CallFunctionNode problems in trunk

2006-05-13 Thread Carsten Ziegeler
Giacomo Pati wrote Doesn't get me any further. Still getting java.lang.NullPointerException at org.apache.cocoon.components.treeprocessor.sitemap.CallFunctionNode.invoke(CallFunctionNode.java:113) Any additional ideas? Yes :) The model is not evaluated in the selector. If you

CallFunctionNode problems in trunk

2006-05-12 Thread Reinhard Poetz
I'm not sure if I'm on the right track. What I found so far is that if a node is a LinkedProcessingNodeBuilder its linkNode() method is called. When the tree processor is set up, a node builder is registered for this step by adding it to the linkedBuilders collection: public

Re: CallFunctionNode problems in trunk

2006-05-12 Thread Carsten Ziegeler
Reinhard Poetz schrieb: I'm not sure if I'm on the right track. What I found so far is that if a node is a LinkedProcessingNodeBuilder its linkNode() method is called. When the tree processor is set up, a node builder is registered for this step by adding it to the linkedBuilders

Re: CallFunctionNode problems in trunk

2006-05-12 Thread Giacomo Pati
Subject: CallFunctionNode problems in trunk I'm not sure if I'm on the right track. What I found so far is that if a node is a LinkedProcessingNodeBuilder its linkNode() method is called. When the tree processor is set up, a node builder is registered for this step by adding it to the linkedBuilders

Re: CallFunctionNode problems in trunk

2006-05-12 Thread Carsten Ziegeler
Ignore my last email - the current code is correct. The singleton variable is set to false some lines below :( Carsten Carsten Ziegeler wrote: Yes, this could be the problem. I briefly looked through the code and (i'm not sure) it seems that avalon components without a lifecycle interface

Re: CallFunctionNode problems in trunk

2006-05-12 Thread Reinhard Poetz
Carsten Ziegeler wrote: Ignore my last email - the current code is correct. The singleton variable is set to false some lines below :( Just wanted to answer that it doesn't fix it. IIUC the container with the builders is setup in SitemapLanguage.java#405-430. But I don't understand how the

Re: CallFunctionNode problems in trunk

2006-05-12 Thread Carsten Ziegeler
Giacomo Pati schrieb: I'm hunting that bug too ;-) My observation until now is that: a) SitemapLanguage#createNodeBuilder creates the CallNodeBuilder b) it seems (during my debugging) there is only one CallNodeBuilder in the system (even though it is not marked ThreadSafe as other

Re: CallFunctionNode problems in trunk

2006-05-12 Thread Reinhard Poetz
Giacomo Pati wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I'm hunting that bug too ;-) My observation until now is that: a) SitemapLanguage#createNodeBuilder creates the CallNodeBuilder b) it seems (during my debugging) there is only one CallNodeBuilder in the system (even though

Re: CallFunctionNode problems in trunk

2006-05-12 Thread Carsten Ziegeler
Reinhard Poetz schrieb: Carsten Ziegeler wrote: Ignore my last email - the current code is correct. The singleton variable is set to false some lines below :( Just wanted to answer that it doesn't fix it. IIUC the container with the builders is setup in SitemapLanguage.java#405-430. But I

Re: CallFunctionNode problems in trunk

2006-05-12 Thread Reinhard Poetz
Carsten Ziegeler wrote: Giacomo Pati schrieb: I'm hunting that bug too ;-) My observation until now is that: a) SitemapLanguage#createNodeBuilder creates the CallNodeBuilder b) it seems (during my debugging) there is only one CallNodeBuilder in the system (even though it is not marked

Re: CallFunctionNode problems in trunk

2006-05-12 Thread Carsten Ziegeler
Reinhard Poetz wrote: Carsten Ziegeler wrote: Giacomo Pati schrieb: I'm hunting that bug too ;-) My observation until now is that: a) SitemapLanguage#createNodeBuilder creates the CallNodeBuilder b) it seems (during my debugging) there is only one CallNodeBuilder in the system (even

Re: CallFunctionNode problems in trunk

2006-05-12 Thread Giacomo Pati
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Fri, 12 May 2006, Carsten Ziegeler wrote: Date: Fri, 12 May 2006 16:05:16 +0200 From: Carsten Ziegeler [EMAIL PROTECTED] Reply-To: dev@cocoon.apache.org To: dev@cocoon.apache.org Subject: Re: CallFunctionNode problems in trunk Reinhard Poetz

Re: CallFunctionNode problems in trunk

2006-05-12 Thread Carsten Ziegeler
Giacomo Pati schrieb: On Fri, 12 May 2006, Carsten Ziegeler wrote: Date: Fri, 12 May 2006 16:05:16 +0200 From: Carsten Ziegeler [EMAIL PROTECTED] Reply-To: dev@cocoon.apache.org To: dev@cocoon.apache.org Subject: Re: CallFunctionNode problems in trunk Reinhard Poetz schrieb: Carsten

Re: CallFunctionNode problems in trunk

2006-05-12 Thread Giacomo Pati
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Fri, 12 May 2006, Carsten Ziegeler wrote: Date: Fri, 12 May 2006 16:23:58 +0200 From: Carsten Ziegeler [EMAIL PROTECTED] Reply-To: dev@cocoon.apache.org To: dev@cocoon.apache.org Subject: Re: CallFunctionNode problems in trunk Giacomo Pati

Re: CallFunctionNode problems in trunk

2006-05-12 Thread Giacomo Pati
On Fri, 12 May 2006, Giacomo Pati wrote: Date: Fri, 12 May 2006 16:56:28 +0200 (CEST) From: Giacomo Pati [EMAIL PROTECTED] Reply-To: dev@cocoon.apache.org To: dev@cocoon.apache.org Subject: Re: CallFunctionNode problems in trunk --[PinePGP]--[begin

Re: CallFunctionNode problems in trunk

2006-05-12 Thread Reinhard Poetz
Giacomo Pati wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I've something working for an app I'm migrating to cocoon-2.2. Could one of the other bug hunters check if the attached patch works for her, too? If so that patch could be a base for how to solve this issue. It works for

Re: CallFunctionNode problems in trunk

2006-05-12 Thread Giacomo Pati
On Fri, 12 May 2006, Reinhard Poetz wrote: Date: Fri, 12 May 2006 17:57:46 +0200 From: Reinhard Poetz [EMAIL PROTECTED] Reply-To: dev@cocoon.apache.org To: dev@cocoon.apache.org Subject: Re: CallFunctionNode problems in trunk Giacomo Pati wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1