Re: [Lang] Rounding Duration

2018-07-15 Thread Pascal Schumacher
Am 15.07.2018 um 22:09 schrieb Gary Gregory: Let's cut a Lang release and then update to Java 8. +1 - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [Lang] Rounding Duration

2018-07-15 Thread Gary Gregory
Let's cut a Lang release and then update to Java 8. Gary On Sun, Jul 15, 2018, 13:11 Aleksander Ściborek < aleksanderscibo...@gmail.com> wrote: > Yes, you are right > I forgot about it, but when new commons-lang will requires Java 8 I hope I > will be able to help you ;) > Al

Re: [Lang] Rounding Duration

2018-07-15 Thread Aleksander Ściborek
Yes, you are right I forgot about it, but when new commons-lang will requires Java 8 I hope I will be able to help you ;) Aleksander On 15 July 2018 at 21:06, Pascal Schumacher wrote: > Hi Aleksander, > > guess you are referring to java.time.Duration? > > This class was

Re: [Lang] Rounding Duration

2018-07-15 Thread Pascal Schumacher
Hi Aleksander, guess you are referring to java.time.Duration? This class was added in Java 8 and commons-lang currently only requires Java 7. Therefore we can not add this at the moment. Sorry, Pascal Am 14.07.2018 um 21:26 schrieb Aleksander Ściborek: Hello everyone During implamanting

Re: svn commit: r27426 - /dev/commons/lang/3.8-SNAPSHOT-RC1/site/

2018-06-13 Thread Rob Tompkins
> Adding release directories: commons-lang3, version: 3.8-SNAPSHOT >> >> Added: >>dev/commons/lang/3.8-SNAPSHOT-RC1/site/ >> >> - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: svn commit: r27427 - /dev/commons/lang/3.8-SNAPSHOT-RC1/site/apidocs/

2018-06-13 Thread Rob Tompkins
at 9:16 AM wrote: > >> Author: chtompki >> Date: Wed Jun 13 15:16:43 2018 >> New Revision: 27427 >> >> Log: >> Adding release directories: commons-lang3, version: 3.8-SNAPS

Re: svn commit: r27427 - /dev/commons/lang/3.8-SNAPSHOT-RC1/site/apidocs/

2018-06-13 Thread Gary Gregory
NAPSHOT > > Added: > dev/commons/lang/3.8-SNAPSHOT-RC1/site/apidocs/ > >

Re: svn commit: r27426 - /dev/commons/lang/3.8-SNAPSHOT-RC1/site/

2018-06-13 Thread Gary Gregory
elease directories: commons-lang3, version: 3.8-SNAPSHOT > > Added: > dev/commons/lang/3.8-SNAPSHOT-RC1/site/ > >

Re: svn commit: r27427 - /dev/commons/lang/3.8-SNAPSHOT-RC1/site/apidocs/

2018-06-13 Thread Rob Tompkins
ase directories: commons-lang3, version: 3.8-SNAPSHOT > > Added: >dev/commons/lang/3.8-SNAPSHOT-RC1/site/apidocs/ > - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [LANG] Java 9 problems because of dependencies to java.desktop (Was: Re: [LANG] Thoughts about Lang 4.0)

2018-06-10 Thread Chas Honton
, with no replacement? And then add a > note in the next release that those classes will be removed in the future? > > B > > > From: Stephen Colebourne > To: Commons Developers List > Sent: Monday, 11 June 2018 9:26 AM > Subject: Re

Re: [LANG] Java 9 problems because of dependencies to java.desktop (Was: Re: [LANG] Thoughts about Lang 4.0)

2018-06-10 Thread Bruno P. Kinoshita
9:26 AM Subject: Re: [LANG] Java 9 problems because of dependencies to java.desktop (Was: Re: [LANG] Thoughts about Lang 4.0) Good spot. I think that means [lang] would have to have its own copy of the JDK interfaces. or just deprecate the functionality without replacement. Stephen On 10 June

Re: [LANG] Java 9 problems because of dependencies to java.desktop (Was: Re: [LANG] Thoughts about Lang 4.0)

2018-06-10 Thread Stephen Colebourne
Good spot. I think that means [lang] would have to have its own copy of the JDK interfaces. or just deprecate the functionality without replacement. Stephen On 10 June 2018 at 22:11, Gilles wrote: > Hello. > > On Sun, 10 Jun 2018 21:34:49 +0200, Oliver Heger wrote: >> >&g

Re: [LANG] Java 9 problems because of dependencies to java.desktop (Was: Re: [LANG] Thoughts about Lang 4.0)

2018-06-10 Thread Gilles
Hello. On Sun, 10 Jun 2018 21:34:49 +0200, Oliver Heger wrote: Hi Bruno, Am 10.06.2018 um 00:52 schrieb Bruno P. Kinoshita: Hi all, There is a patch [1] for LANG-1339 [2] that I would like to merge. The discussion around this issue can be found in the rest of this e-mail thread

Re: [LANG] Java 9 problems because of dependencies to java.desktop (Was: Re: [LANG] Thoughts about Lang 4.0)

2018-06-10 Thread Oliver Heger
Hi Bruno, Am 10.06.2018 um 00:52 schrieb Bruno P. Kinoshita: > Hi all, > > There is a patch [1] for LANG-1339 [2] that I would like to merge. The > discussion around this issue can be found in the rest of this e-mail thread. > > The patch basically deprecates the existing c

Re: [LANG] Java 9 problems because of dependencies to java.desktop (Was: Re: [LANG] Thoughts about Lang 4.0)

2018-06-10 Thread Stephen Colebourne
ds to use those classes, then they have to add the > dependency to java.desktop in their code. When [lang] is used in classpath mode, there is no problem as java.desktop is included anyway. When [lang] is used in module mode, the user should get a compile error unless they add the java.desktop d

Re: [LANG] Java 9 problems because of dependencies to java.desktop (Was: Re: [LANG] Thoughts about Lang 4.0)

2018-06-09 Thread Bruno P. Kinoshita
about this issue (-: Bruno From: Gary Gregory To: Commons Developers List ; Bruno P. Kinoshita Sent: Sunday, 10 June 2018 10:56 AM Subject: Re: [LANG] Java 9 problems because of dependencies to java.desktop (Was: Re: [LANG] Thoughts about Lang 4.0) So

Re: [LANG] Java 9 problems because of dependencies to java.desktop (Was: Re: [LANG] Thoughts about Lang 4.0)

2018-06-09 Thread Gary Gregory
So the dependency on desktop is declared as optional but it still exists? Gary On Sat, Jun 9, 2018, 16:52 Bruno P. Kinoshita wrote: > Hi all, > > There is a patch [1] for LANG-1339 [2] that I would like to merge. The > discussion around this issue can be found in the rest of this e

Re: [LANG] Java 9 problems because of dependencies to java.desktop (Was: Re: [LANG] Thoughts about Lang 4.0)

2018-06-09 Thread Bruno P. Kinoshita
Hi all, There is a patch [1] for LANG-1339 [2] that I would like to merge. The discussion around this issue can be found in the rest of this e-mail thread. The patch basically deprecates the existing classes that depend on java.desktop, and provide alternative implementations. The previous

Re: [lang] [LANG-1393] Add API SystemUtils.String getEnvironmentVariable(final String name, final String defaultValue).

2018-04-22 Thread Gary Gregory
Thank you for the review. Done: https://issues.apache.org/jira/browse/LANG-1394 Gary On Sun, Apr 22, 2018 at 7:06 AM, sebb <seb...@gmail.com> wrote: > On 22 April 2018 at 13:44, Gary Gregory <garydgreg...@gmail.com> wrote: > > On Sun, Apr 22, 2018, 03:55 sebb <

Re: [lang] [LANG-1393] Add API SystemUtils.String getEnvironmentVariable(final String name, final String defaultValue).

2018-04-22 Thread sebb
On 22 April 2018 at 13:44, Gary Gregory <garydgreg...@gmail.com> wrote: > On Sun, Apr 22, 2018, 03:55 sebb <seb...@gmail.com> wrote: > >> On 20 April 2018 at 15:55, <ggreg...@apache.org> wrote: >> > Repository: commons-lang >> > Updated Branches:

Re: [lang] [LANG-1393] Add API SystemUtils.String getEnvironmentVariable(final String name, final String defaultValue).

2018-04-22 Thread Gary Gregory
On Sun, Apr 22, 2018, 03:55 sebb <seb...@gmail.com> wrote: > On 20 April 2018 at 15:55, <ggreg...@apache.org> wrote: > > Repository: commons-lang > > Updated Branches: > > refs/heads/master 8e3ec1722 -> efba54d35 > > > > > > [LANG-1393] A

Re: [lang] [LANG-1393] Add API SystemUtils.String getEnvironmentVariable(final String name, final String defaultValue).

2018-04-22 Thread sebb
On 20 April 2018 at 15:55, <ggreg...@apache.org> wrote: > Repository: commons-lang > Updated Branches: > refs/heads/master 8e3ec1722 -> efba54d35 > > > [LANG-1393] Add API SystemUtils.String getEnvironmentVariable(final > String name, final String defaultValue

Re: [lang] Todo utility class

2018-03-19 Thread Paul King
Groovy has some features which might give you some ideas. Firstly, it let's you easily create dynamic objects in numerous ways. Typically you might use a Closure or map of Closures. You can optionally specify one or more interfaces and if needed give a base class. You could no doubt do something

Re: [lang] Todo utility class

2018-03-19 Thread Matt Benson
Thanks all. This has gone elsewhere. Matt On Mar 19, 2018 8:21 PM, "Matt Sicker" wrote: > I’ve used NotImplementedException as a way to do this. In Scala, there is a > function called ??? which throws a similar exception, and in Kotlin, > there’s an equivalent function called

Re: [lang] Todo utility class

2018-03-19 Thread Matt Sicker
I’ve used NotImplementedException as a way to do this. In Scala, there is a function called ??? which throws a similar exception, and in Kotlin, there’s an equivalent function called TODO. On Mon, Mar 19, 2018 at 20:09, Gary Gregory wrote: > Been out with the flu,

Re: [lang] Todo utility class

2018-03-19 Thread Gary Gregory
Been out with the flu, jumping in late... It seems like using one or more annotations would be better for tooling... Gary On Sun, Mar 18, 2018, 07:57 Gilles wrote: > On Sun, 18 Mar 2018 13:20:18 +0100, Jochen Wiedmann wrote: > > On Fri, Mar 16, 2018 at 12:05 AM,

Re: [lang] Todo utility class

2018-03-18 Thread Gilles
On Sun, 18 Mar 2018 13:20:18 +0100, Jochen Wiedmann wrote: On Fri, Mar 16, 2018 at 12:05 AM, Gilles wrote: Perhaps "Commons Testing". IIUC, such calls are not meant to appear in released code. Neither would testing. Exactly, and the reason why I proposed that

Re: [lang] Todo utility class

2018-03-18 Thread Jochen Wiedmann
On Fri, Mar 16, 2018 at 12:05 AM, Gilles wrote: > Perhaps "Commons Testing". > IIUC, such calls are not meant to appear in released code. Neither would testing. I like the idea of a Todo class. Makes searching for such places extremely neat, and simple. Jochen

AW: [lang] Todo utility class

2018-03-17 Thread jhm
An: Commons Developers List > Betreff: Re: [lang] Todo utility class > > I also don't think it belongs in a testing module. OTOH, I appreciate > the desire not to have such hang around in finished code. I think I > might create a dedicated project around this (elsewhere) with a Maven >

Re: [lang] Todo utility class

2018-03-16 Thread Matt Benson
s >>>> NotImplementedException >>>> Baz baz = Todo.todo(RETURNING_NULL, "create a Baz"); //returns null and >>>> prints a message to System.err >>>> >>>> I would also think it a good (if odd) idea to make the whole class >>>&

Re: [lang] Todo utility class

2018-03-16 Thread Gilles
G_NULL, "create a Baz"); //returns null and prints a message to System.err I would also think it a good (if odd) idea to make the whole class deprecated so that its use is flagged in tools, etc. Does the community think this code would be suited to the commons-lang component? Perhaps

Re: [lang] Todo utility class

2018-03-16 Thread Bindul Bhowmik
tion >> Baz baz = Todo.todo(RETURNING_NULL, "create a Baz"); //returns null and >> prints a message to System.err >> >> I would also think it a good (if odd) idea to make the whole class >> deprecated so that its use is flagged in tools, etc. >> >&g

Re: [lang] Todo utility class

2018-03-15 Thread Gilles
hole class deprecated so that its use is flagged in tools, etc. Does the community think this code would be suited to the commons-lang component? Perhaps "Commons Testing". IIUC, such calls are not meant to appear in released code. Reg

[lang] Todo utility class

2018-03-14 Thread Matt Benson
community think this code would be suited to the commons-lang component? Matt

Re: [LANG] travis build failures

2018-02-28 Thread Matt Sicker
ehaviour.[2] > > Gilles > > [1] See here for example: > https://travis-ci.org/apache/commons-rng/builds/345961304 > [2] See here for example: > https://issues.apache.org/jira/projects/MATH/issues/MATH-1361 > > > I posted https://github.com/apache/commons-lang/pull/317 to

Re: [LANG] travis build failures

2018-02-28 Thread Otto Fowler
d behaviour.[2] Gilles [1] See here for example: https://travis-ci.org/apache/commons-rng/builds/345961304 [2] See here for example: https://issues.apache.org/jira/projects/MATH/issues/MATH-1361 > I posted https://github.com/apache/commons-lang/pull/317 to show this > approach > > On Wed, Fe

Re: [LANG] travis build failures

2018-02-28 Thread Gilles
seed vary (as in the application world) can reveal unexpected behaviour.[2] Gilles [1] See here for example: https://travis-ci.org/apache/commons-rng/builds/345961304 [2] See here for example: https://issues.apache.org/jira/projects/MATH/issues/MATH-1361 I posted https://github.com/apache/co

[Testing][Lang] Scope of new component?

2018-02-28 Thread Gilles
Hi. A timing utility was proposed by Otto Fowler for inclusion into [Lang]: https://issues.apache.org/jira/browse/LANG-1373 Gary questioned whether it was appropriate to include it in [Lang], and suggested the creation of a new "Commons Perf" component. I argued that the fea

Re: [LANG] travis build failures

2018-02-27 Thread Allon Mureinik
in Otto's original email - these tests do fail occasionally). I posted https://github.com/apache/commons-lang/pull/317 to show this approach On Wed, Feb 28, 2018 at 12:00 AM, Gary Gregory <garydgreg...@gmail.com> wrote: > Of course... but how would test then? Shuffle N times and accept a %

Re: [LANG] travis build failures

2018-02-27 Thread Gary Gregory
il. This > > > chance is higher for the testShuffleBoolean case where the array > contains > > > ten elements, but only two distinct values (true and false). > > > > > > I've sent a PR to remove these problematic assertions, let's see what > the > &g

Re: [LANG] travis build failures

2018-02-27 Thread Allon Mureinik
original array, and thus the test will fail. This > > chance is higher for the testShuffleBoolean case where the array contains > > ten elements, but only two distinct values (true and false). > > > > I've sent a PR to remove these problematic assertions, let's see what

Re: [LANG] travis build failures

2018-02-27 Thread Gary Gregory
PR to remove these problematic assertions, let's see what the > maintainers think of it: > https://github.com/apache/commons-lang/pull/316 > > > On Tue, Feb 27, 2018 at 6:59 PM, Otto Fowler <ottobackwa...@gmail.com> > wrote: > > > Note, this does pass in my person

Re: [LANG] travis build failures

2018-02-27 Thread Allon Mureinik
for the testShuffleBoolean case where the array contains ten elements, but only two distinct values (true and false). I've sent a PR to remove these problematic assertions, let's see what the maintainers think of it: https://github.com/apache/commons-lang/pull/316 On Tue, Feb 27, 2018 at 6:59 PM

Re: [LANG] travis build failures

2018-02-27 Thread Otto Fowler
Note, this does pass in my personal travis: https://travis-ci.org/ottobackwards/commons-lang/builds/346806991 On February 27, 2018 at 11:58:24, Otto Fowler (ottobackwa...@gmail.com) wrote: My PR is currently failing for java 9 on this test. Anyone have any idea why? [INFO] Running

[LANG] travis build failures

2018-02-27 Thread Otto Fowler
My PR is currently failing for java 9 on this test. Anyone have any idea why? [INFO] Running org.apache.commons.lang3.ArrayUtilsTest [ERROR] Tests run: 307, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.114 s <<< FAILURE! - in org.apache.commons.lang3.ArrayUtilsTest [ERROR]

Re: [LANG] question on Validate

2018-02-23 Thread Otto Fowler
Yeah, I found it. Sorry. On February 23, 2018 at 09:42:12, Otto Fowler (ottobackwa...@gmail.com) wrote: I just noticed the Validate class, and was wondering if I should be using it in my pr, but I have checks for StringUtils.isBlank() not just null… Would it make sense for Validate to have

[LANG] question on Validate

2018-02-23 Thread Otto Fowler
I just noticed the Validate class, and was wondering if I should be using it in my pr, but I have checks for StringUtils.isBlank() not just null… Would it make sense for Validate to have check methods corresponding to blank and empty? ottO

[lang] Merge PR for new StopWatch (StackWatch) from LANG-1373

2018-02-20 Thread Bruno P. Kinoshita
Hi, See https://issues.apache.org/jira/browse/LANG-1373 for the ticket history, and https://github.com/apache/commons-lang/pull/311 for the pull request review & discussion. I'm happy with the current design. It builds on top of the existing StopWatch, giving users the ability to

Re: [VFS][LANG] Jira rights

2018-02-19 Thread Otto Fowler
Thanks! On February 19, 2018 at 14:14:11, Gilles (gil...@harfang.homelinux.org) wrote: On Sun, 18 Feb 2018 20:48:34 -0600, Matt Sicker wrote: > On 17 February 2018 at 12:09, Otto Fowler > wrote: > >> I am familiar with the differences between a contributor or a >>

Re: [VFS][LANG] Jira rights

2018-02-19 Thread Gilles
On Sun, 18 Feb 2018 20:48:34 -0600, Matt Sicker wrote: On 17 February 2018 at 12:09, Otto Fowler wrote: I am familiar with the differences between a contributor or a committer both in the foundation and jira. I would like _contributor_ rights, not commit rights.

Re: [VFS][LANG] Jira rights

2018-02-19 Thread Otto Fowler
ng or mentioning commit rights. I just want to have > everything in my dashboard. > > But since commit rights keeps coming up. Is there a link to commit > procedures and requirements for VFS and or LANG or a guide for committers > etc? > I don’t imagine ‘just committing’ to eit

Re: [VFS][LANG] Jira rights

2018-02-19 Thread Matt Sicker
he issues > that I didn’t create but will > be creating Pull Requests for to myself. > > I am not requesting or mentioning commit rights. I just want to have > everything in my dashboard. > > But since commit rights keeps coming up. Is there a link to commit > procedures

Re: [VFS][LANG] Jira rights

2018-02-19 Thread Otto Fowler
but will be creating Pull Requests for to myself. I am not requesting or mentioning commit rights. I just want to have everything in my dashboard. But since commit rights keeps coming up. Is there a link to commit procedures and requirements for VFS and or LANG or a guide for committers etc? I

Re: [VFS][LANG] Jira rights

2018-02-19 Thread Otto Fowler
everything in my dashboard. But since commit rights keeps coming up. Is there a link to commit procedures and requirements for VFS and or LANG or a guide for committers etc? I don’t imagine ‘just committing’ to either LANG or VFS. I would feel more comfortable with the standard submit until we trust

Re: [VFS][LANG] Jira rights

2018-02-18 Thread Matt Sicker
On 17 February 2018 at 12:09, Otto Fowler wrote: > I am familiar with the differences between a contributor or a committer > both in the foundation and jira. > I would like _contributor_ rights, not commit rights. > In what context? You already have commit rights if

Re: [VFS][LANG] Jira rights

2018-02-18 Thread Gary Gregory
On Sat, Feb 17, 2018 at 11:09 AM, Otto Fowler <ottobackwa...@gmail.com> wrote: > Thanks! Please assign VFS-614, VFS-398, LANG-1373 to me. > > I am familiar with the differences between a contributor or a committer > both in the foundation and jira. > I would like _contributo

Re: [VFS][LANG] Jira rights

2018-02-17 Thread Gilles
On Sat, 17 Feb 2018 13:09:40 -0500, Otto Fowler wrote: Thanks! Please assign VFS-614, VFS-398, LANG-1373 to me. I am familiar with the differences between a contributor or a committer both in the foundation and jira. I would like _contributor_ rights, not commit rights. Given the info here

Re: [VFS][LANG] Jira rights

2018-02-17 Thread Otto Fowler
Thanks! Please assign VFS-614, VFS-398, LANG-1373 to me. I am familiar with the differences between a contributor or a committer both in the foundation and jira. I would like _contributor_ rights, not commit rights. Cheers! On February 17, 2018 at 12:33:22, Gary Gregory (garydgreg

Re: [VFS][LANG] Jira rights

2018-02-17 Thread Gary Gregory
il.com> wrote: I would like to assign the jiras for my PR’s to myself. And I pleased be given contributor rights to LANG and VFS? Thanks.

[VFS][LANG] Jira rights

2018-02-17 Thread Otto Fowler
I would like to assign the jiras for my PR’s to myself. And I pleased be given contributor rights to LANG and VFS? Thanks.

Re: Lists (was Re: [LANG] Github PR reviews)

2018-01-14 Thread sebb
On 12 January 2018 at 18:58, Stefan Bodewig <bode...@apache.org> wrote: > On 2018-01-12, sebb wrote: > >> On 12 January 2018 at 16:45, Stefan Bodewig <bode...@apache.org> wrote: > >>> By now we've got two different lists where notifications may end up, >

Lists (was Re: [LANG] Github PR reviews)

2018-01-12 Thread Stefan Bodewig
On 2018-01-12, sebb wrote: > On 12 January 2018 at 16:45, Stefan Bodewig <bode...@apache.org> wrote: >> By now we've got two different lists where notifications may end up, >> the github notifications for lang go to issues@commons, those for >> compress go to notificat

Re: [LANG] Github PR reviews

2018-01-12 Thread sebb
On 12 January 2018 at 16:45, Stefan Bodewig <bode...@apache.org> wrote: > On 2018-01-12, Otto Fowler wrote: > >> https://github.com/apache/commons-lang/pull/311 > >> I did not see a mail for it. If someone else *did* see it, then I am sorry. > > htt

Re: [lang] new IllegalArgumentException shorcut.

2018-01-12 Thread Gary Gregory
On Fri, Jan 12, 2018 at 10:45 AM, Pascal Schumacher < pascalschumac...@gmx.net> wrote: > Hi Gary, > > we already have Validate#isTrue(boolean expression, String message, > Object... values), which throws an IllegalArgumentException when the > expression is false. > Ah, but that is no good IMO

Re: [lang] new IllegalArgumentException shorcut.

2018-01-12 Thread Pascal Schumacher
Hi Gary, we already have Validate#isTrue(boolean expression, String message, Object... values), which throws an IllegalArgumentException when the expression is false. Cheers, Pascal Am 12.01.2018 um 18:30 schrieb Gary Gregory: Hi All: We have code like: throw new

Re: [LANG] Github PR reviews

2018-01-12 Thread Gary Gregory
I am hoping to find time this weekend to review... Gary On Fri, Jan 12, 2018 at 9:40 AM, Otto Fowler <ottobackwa...@gmail.com> wrote: > https://github.com/apache/commons-lang/pull/311 > > I did not see a mail for it. If someone else *did* see it, then I am > sorry. > >

Re: [lang] - Pull Requests containing new StringUtils methods

2018-01-12 Thread Gary Gregory
gt; methods: > > 1. astIndexOfAnyChar > > https://github.com/apache/commons-lang/pull/273 > > 2. extendIfNotBlank/extendIfNotEmpty > > https://github.com/apache/commons-lang/pull/278 > > https://issues.apache.org/jira/browse/LANG-1345 > > 3. indexesOf > > https:/

[lang] new IllegalArgumentException shorcut.

2018-01-12 Thread Gary Gregory
Hi All: We have code like: throw new IllegalArgumentException(String.format("Minimum abbreviation width is %d", minAbbrevWidth)); and I use this pattern a lot. I would like to short cut this as follows: throw IllegalArgumentExceptions.format("Minimum abbreviation width is %d",

Re: [LANG] Github PR reviews

2018-01-12 Thread Stefan Bodewig
On 2018-01-12, Otto Fowler wrote: > https://github.com/apache/commons-lang/pull/311 > I did not see a mail for it. If someone else *did* see it, then I am sorry. https://lists.apache.org/thread.html/fb76f5e54f6f3713c06465539e13100f7e7dfc6b7874d1bea47c2ab4@%3Cissues.commons.apache.

[lang] - Pull Requests containing new StringUtils methods

2018-01-12 Thread Pascal Schumacher
Hello everybody, currently there are three open pull requests containing new StringUtils methods: 1. astIndexOfAnyChar https://github.com/apache/commons-lang/pull/273 2. extendIfNotBlank/extendIfNotEmpty https://github.com/apache/commons-lang/pull/278 https://issues.apache.org/jira/browse

Re: [LANG] Github PR reviews

2018-01-12 Thread Otto Fowler
https://github.com/apache/commons-lang/pull/311 I did not see a mail for it. If someone else *did* see it, then I am sorry. On January 12, 2018 at 11:35:00, Gary Gregory (garydgreg...@gmail.com) wrote: We should get emails from GitHub... What is the link to your PR? Gary On Fri, Jan 12

Re: [LANG] Github PR reviews

2018-01-12 Thread Gary Gregory
We should get emails from GitHub... What is the link to your PR? Gary On Fri, Jan 12, 2018 at 6:05 AM, Otto Fowler wrote: > I see that github notices don’t get sent to this list, is there a procedure > to get a pr review? > Asking for a friend ;) > > O >

[LANG] Github PR reviews

2018-01-12 Thread Otto Fowler
I see that github notices don’t get sent to this list, is there a procedure to get a pr review? Asking for a friend ;) O

Re: [lang]

2018-01-11 Thread Gilles
On Thu, 11 Jan 2018 08:16:01 -0600, Matt Benson wrote: On Jan 11, 2018 7:59 AM, "Gilles" wrote: On Thu, 11 Jan 2018 07:49:40 -0600, Matt Benson wrote: On Jan 10, 2018 9:22 PM, "Gary Gregory" wrote: On Wed, Jan 10, 2018 at 5:44 PM,

Re: [lang]

2018-01-11 Thread Matt Benson
On Jan 11, 2018 7:59 AM, "Gilles" wrote: On Thu, 11 Jan 2018 07:49:40 -0600, Matt Benson wrote: > On Jan 10, 2018 9:22 PM, "Gary Gregory" wrote: > > On Wed, Jan 10, 2018 at 5:44 PM, Matt Benson wrote: > > As I'm sure

Re: [lang]

2018-01-11 Thread Gilles
On Thu, 11 Jan 2018 07:49:40 -0600, Matt Benson wrote: On Jan 10, 2018 9:22 PM, "Gary Gregory" wrote: On Wed, Jan 10, 2018 at 5:44 PM, Matt Benson wrote: As I'm sure you're aware, the planned obsolescence of this approach is its obvious

Re: [lang]

2018-01-11 Thread Matt Benson
On Jan 10, 2018 9:22 PM, "Gary Gregory" wrote: On Wed, Jan 10, 2018 at 5:44 PM, Matt Benson wrote: > As I'm sure you're aware, the planned obsolescence of this approach is its > obvious drawback (a similar drawback exists already in the JavaVersion >

Re: [lang]

2018-01-11 Thread Gilles
On Wed, 10 Jan 2018 20:21:53 -0700, Gary Gregory wrote: On Wed, Jan 10, 2018 at 5:44 PM, Matt Benson wrote: As I'm sure you're aware, the planned obsolescence of this approach is its obvious drawback (a similar drawback exists already in the JavaVersion parameter type).

Re: [lang]

2018-01-11 Thread Gilles
On Wed, 10 Jan 2018 20:23:04 -0700, Gary Gregory wrote: On Wed, Jan 10, 2018 at 5:47 PM, Gilles wrote: On Wed, 10 Jan 2018 17:34:55 -0700, Gary Gregory wrote: Hi All: I find myself writing a lot of this kind of code: if

Re: [lang]

2018-01-10 Thread Gary Gregory
On Wed, Jan 10, 2018 at 5:47 PM, Gilles wrote: > On Wed, 10 Jan 2018 17:34:55 -0700, Gary Gregory wrote: > >> Hi All: >> >> I find myself writing a lot of this kind of code: >> >> if (SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_1_8)) ... >> >> and >> >> >>

Re: [lang]

2018-01-10 Thread Gary Gregory
On Wed, Jan 10, 2018 at 5:44 PM, Matt Benson wrote: > As I'm sure you're aware, the planned obsolescence of this approach is its > obvious drawback (a similar drawback exists already in the JavaVersion > parameter type). I assume this is the reason you said "technical

Re: [lang]

2018-01-10 Thread Gilles
On Wed, 10 Jan 2018 17:34:55 -0700, Gary Gregory wrote: Hi All: I find myself writing a lot of this kind of code: if (SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_1_8)) ... and Assume.assumeTrue(SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_1_8)); I think this would be more tidy:

Re: [lang]

2018-01-10 Thread Matt Benson
As I'm sure you're aware, the planned obsolescence of this approach is its obvious drawback (a similar drawback exists already in the JavaVersion parameter type). I assume this is the reason you said "technical reasons." However, wouldn't it be straight up simple, as well as future proof (if done

[lang]

2018-01-10 Thread Gary Gregory
Hi All: I find myself writing a lot of this kind of code: if (SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_1_8)) ... and Assume.assumeTrue(SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_1_8)); I think this would be more tidy: if (SystemUtils.isJavaVersionAtLeast8()) ... If this

Re: [commons-release-plugin) (Was: svn commit: r24009 - in /dev/commons/lang: ./ binaries/ source/)

2018-01-04 Thread Rob Tompkins
;>>>>> wrote: >>>>>>> >>>>>>> That looks good. Thank you Rob! >>>>>>> >>>>>>> Gary >>>>>>> >>>>>>>> On Thu, Jan 4, 2018 at 5:47 AM, Rob Tompkins <chtom

Re: [commons-release-plugin) (Was: svn commit: r24009 - in /dev/commons/lang: ./ binaries/ source/)

2018-01-04 Thread Gary Gregory
;> On Thu, Jan 4, 2018 at 5:47 AM, Rob Tompkins <chtom...@gmail.com> > >>>> wrote: > >>>>>> > >>>>>> @Gary - Below is the result from my release plugin with [lang3]. > Give > >>>> it a > >>>>>> looki

Re: [commons-release-plugin) (Was: svn commit: r24009 - in /dev/commons/lang: ./ binaries/ source/)

2018-01-04 Thread Rob Tompkins
t; >>>>> That looks good. Thank you Rob! >>>>> >>>>> Gary >>>>> >>>>>> On Thu, Jan 4, 2018 at 5:47 AM, Rob Tompkins <chtom...@gmail.com> >>>> wrote: >>>>>> >>>>>> @Gary

Re: [commons-release-plugin) (Was: svn commit: r24009 - in /dev/commons/lang: ./ binaries/ source/)

2018-01-04 Thread Gary Gregory
; looking over and let me know what you think. > >>>> > >>>> -Rob > >>>> > >>>>> On Jan 4, 2018, at 7:45 AM, chtom...@apache.org wrote: > >>>>> > >>>>> Author: chtompki > >>>>> Date:

Re: [commons-release-plugin) (Was: svn commit: r24009 - in /dev/commons/lang: ./ binaries/ source/)

2018-01-04 Thread Rob Tompkins
>>>> >>>>> On Jan 4, 2018, at 7:45 AM, chtom...@apache.org wrote: >>>>> >>>>> Author: chtompki >>>>> Date: Thu Jan 4 12:45:36 2018 >>>>> New Revision: 24009 >>>>> >>>>> Log:

Re: [commons-release-plugin) (Was: svn commit: r24009 - in /dev/commons/lang: ./ binaries/ source/)

2018-01-04 Thread Gary Gregory
e plugin with [lang3]. Give > it a > >> looking over and let me know what you think. > >> > >> -Rob > >> > >>> On Jan 4, 2018, at 7:45 AM, chtom...@apache.org wrote: > >>> > >>> Author: chtompki > >>> Date: Thu

Re: [commons-release-plugin) (Was: svn commit: r24009 - in /dev/commons/lang: ./ binaries/ source/)

2018-01-04 Thread Rob Tompkins
thor: chtompki >>> Date: Thu Jan 4 12:45:36 2018 >>> New Revision: 24009 >>> >>> Log: >>> Staging release: commons-lang3, version: 3.8-SNAPSHOT >>> >>> Added: >>> dev/commons/lang/RELEASE-NOTES.txt >>> dev/commons/l

Re: [commons-release-plugin) (Was: svn commit: r24009 - in /dev/commons/lang: ./ binaries/ source/)

2018-01-04 Thread Gary Gregory
4, 2018, at 7:45 AM, chtom...@apache.org wrote: > > > > Author: chtompki > > Date: Thu Jan 4 12:45:36 2018 > > New Revision: 24009 > > > > Log: > > Staging release: commons-lang3, version: 3.8-SNAPSHOT > > > > Added: > >dev/commons/lang/R

[commons-release-plugin) (Was: svn commit: r24009 - in /dev/commons/lang: ./ binaries/ source/)

2018-01-04 Thread Rob Tompkins
Staging release: commons-lang3, version: 3.8-SNAPSHOT > > Added: >dev/commons/lang/RELEASE-NOTES.txt >dev/commons/lang/binaries/commons-lang3-3.8-SNAPSHOT-bin.tar.gz (with > props) >dev/commons/lang/binaries/commons-lang3-3.8-SNAPSHOT-bin.tar.gz.asc >dev/com

[LANG] Re: Hello and possible addition

2018-01-02 Thread Otto Fowler
roject. While working on adding some timing functionality to a Metron feature, I came across the Stopwatch <https://commons.apache.org/proper/commons-lang/javadocs/api-release/org/apache/commons/lang3/time/StopWatch.html> class, but found that it didn’t suite my needs. What I wanted to do w

Re: [lang] Add a DaemonThreadFactory

2017-12-21 Thread Gary Gregory
t; > > Am 19.12.2017 um 17:27 schrieb Gary Gregory: > > I keep on copying this from project to project and it seems fitting for > > Commons Lang: > > In the concurrent package, there is the BasicThreadFactory class. Could > this class satisfy your needs or can it be e

Re: [lang] Add a DaemonThreadFactory

2017-12-21 Thread Chas Honton
Gary Gregory [mailto:garydgreg...@gmail.com] > Sent: Tuesday, December 19, 2017 8:27 AM > To: Commons Developers List <dev@commons.apache.org> > Subject: [lang] Add a DaemonThreadFactory > > I keep on copying this from project to project and it seems fitting for > Commons Lang: &g

RE: [lang] Add a DaemonThreadFactory

2017-12-21 Thread Roger Whitcomb
I have a class almost identical to this in my project, so +1 to this idea. ~Roger Whitcomb -Original Message- From: Gary Gregory [mailto:garydgreg...@gmail.com] Sent: Tuesday, December 19, 2017 8:27 AM To: Commons Developers List <dev@commons.apache.org> Subject: [lan

Re: [lang] Add a DaemonThreadFactory

2017-12-19 Thread Oliver Heger
Am 19.12.2017 um 17:27 schrieb Gary Gregory: > I keep on copying this from project to project and it seems fitting for > Commons Lang: In the concurrent package, there is the BasicThreadFactory class. Could this class satisfy your needs or can it be extended? Oliver >

[lang] Add a DaemonThreadFactory

2017-12-19 Thread Gary Gregory
I keep on copying this from project to project and it seems fitting for Commons Lang: import java.util.concurrent.ThreadFactory; import java.util.concurrent.atomic.AtomicLong; public final class DaemonThreadFactory implements ThreadFactory { private final static AtomicLong COUNT = new

Re: [jira] [Closed] (TEXT-107) Upversion commons-lang to 3.7

2017-12-17 Thread Pascal Schumacher
browse/TEXT-107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Schumacher closed TEXT-107. -- Upversion commons-lang to 3.7 - Key: TEXT-107 URL: https://issues.apache.or

<    3   4   5   6   7   8   9   10   11   12   >