Blog post for review: https://github.com/apache/cordova-docs/pull/530
On Tue, Mar 1, 2016 at 11:11 PM, Steven Gill wrote:
> Shaz is back tomorrow. I just wanted to get his blessing before closing
> the vote thread.
>
> On Mon, Feb 29, 2016 at 8:39 PM, Steven Gill
> wrote:
>
>> Just bumped the i
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-docs/pull/530
CB-10693 added ios 4.1.0 release blog post
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-docs CB-10693
Alternativ
Shaz is back tomorrow. I just wanted to get his blessing before closing the
vote thread.
On Mon, Feb 29, 2016 at 8:39 PM, Steven Gill wrote:
> Just bumped the ios vote thread
>
> On Mon, Feb 29, 2016 at 7:06 PM, Carlos Santana
> wrote:
>
>> Sorry that I have being MIA, was at IBM conference at
Please review the blog post. https://github.com/apache/cordova-docs/pull/529
On Fri, Feb 26, 2016 at 2:00 PM, Steven Gill wrote:
> Alright, I ended up just doing a rebase from master instead of
> cherry-picking. I think it should be all good now. Third vote sent.
>
> On Fri, Feb 26, 2016 at 9:
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-docs/pull/529
CB-10687 added android 5.1.1 release blog post
Please review
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-docs mas
GitHub user kovacs-tamas opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/187
blackberry camera fixes
handle image size from the parameters, rotate the picture to the proper
position.
You can merge this pull request into a Git repository by running:
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54685843
--- Diff: src/ios/CDVCamera.m ---
@@ -402,6 +444,115 @@ - (NSString*)tempFilePath:(NSString*)extension
return filePath;
}
Github user kovacs-tamas closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/182
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
The vote has now closed. The results are:
Positive Binding Votes: 4
Steve Gill
Alexander Sorokin
Joe Bowser
Sergey Grebnov
The vote has passed.
On Mon, Feb 29, 2016 at 9:53 PM, Sergey Grebnov (Akvelon) <
v-seg...@microsoft.com> wrote:
> I vote +1
>
> * Manually verified platform could be added
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54685214
--- Diff: src/ios/CDVCamera.m ---
@@ -344,49 +429,6 @@ -
(void)popoverControllerDidDismissPopover:(id)popoverController
self.hasPendi
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54685084
--- Diff: src/ios/CDVCamera.m ---
@@ -402,6 +444,115 @@ - (NSString*)tempFilePath:(NSString*)extension
return filePath;
}
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54685044
--- Diff: src/ios/CDVCamera.m ---
@@ -402,6 +444,115 @@ - (NSString*)tempFilePath:(NSString*)extension
return filePath;
}
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54684979
--- Diff: src/ios/CDVCamera.m ---
@@ -402,6 +444,115 @@ - (NSString*)tempFilePath:(NSString*)extension
return filePath;
}
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54684516
--- Diff: src/ios/CDVCamera.m ---
@@ -402,6 +444,115 @@ - (NSString*)tempFilePath:(NSString*)extension
return filePath;
}
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54684356
--- Diff: src/ios/CDVCamera.m ---
@@ -145,9 +201,38 @@ - (void)takePicture:(CDVInvokedUrlCommand*)command
[self.commandDelegate runInB
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-191085463
LGTM! Great work @riknoll! Very clean code and is easy to follow. Looking
forward to switching over to this.
---
If your project is set up for it, you can reply
Github user stevengill commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54684112
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null;
}
+
+/
Yes, follow semver!
If we can get a good track record of following semver, I'd like to see us
switch to ^ with our pinned platforms and plugins so minors get picked up
automatically.
On Tue, Mar 1, 2016 at 7:01 PM, Tim Barham wrote:
> It's been a long time since we did a cordova-browser release
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54684008
--- Diff: src/ios/CDVCamera.m ---
@@ -145,9 +201,38 @@ - (void)takePicture:(CDVInvokedUrlCommand*)command
[self.commandDelegate runInB
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54683445
--- Diff: src/ios/CDVCamera.m ---
@@ -145,9 +201,38 @@ - (void)takePicture:(CDVInvokedUrlCommand*)command
[self.commandDelegate runInB
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54682684
--- Diff: src/ios/CDVCamera.m ---
@@ -145,9 +201,38 @@ - (void)takePicture:(CDVInvokedUrlCommand*)command
[self.commandDelegate runInB
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/526#issuecomment-191067882
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/84#issuecomment-191067046
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54680375
--- Diff: src/ios/CDVCamera.m ---
@@ -145,9 +201,38 @@ - (void)takePicture:(CDVInvokedUrlCommand*)command
[self.commandDelegate runInB
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54680247
--- Diff: src/ios/CDVCamera.m ---
@@ -145,9 +201,38 @@ - (void)takePicture:(CDVInvokedUrlCommand*)command
[self.commandDelegate runInB
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54679929
--- Diff: src/ios/CDVCamera.m ---
@@ -78,7 +131,10 @@ + (instancetype)
createFromTakePictureArguments:(CDVInvokedUrlCommand*)command
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54678642
--- Diff: src/ios/CDVCamera.m ---
@@ -59,6 +59,59 @@ Licensed to the Apache Software Foundation (ASF) under
one
@implementation CDV
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54678618
--- Diff: src/ios/CDVCamera.m ---
@@ -59,6 +59,59 @@ Licensed to the Apache Software Foundation (ASF) under
one
@implementation CDV
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54678557
--- Diff: src/ios/CDVCamera.m ---
@@ -59,6 +59,59 @@ Licensed to the Apache Software Foundation (ASF) under
one
@implementation CDV
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-browser/pull/10#issuecomment-191031984
@amikula - this PR was closed by a commit made to `cordova-firefoxos`,
which was probably done by mistake.
But regarding this problem specifically: sin
It's been a long time since we did a cordova-browser release, and there have
been many improvements since then. Should we get a release out before the next
tools release?
If so, what should the version be? Proper npm versioning would suggest we go
with 4.1.0 (since it is more than just bug fixe
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/84#discussion_r54670241
--- Diff: README.md ---
@@ -415,7 +411,7 @@ Starts recording an audio file.
- Windows devices can use MP3, M4A and WMA formats for reco
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/84#discussion_r54670094
--- Diff: README.md ---
@@ -58,10 +58,6 @@ Although in the global scope, it is not available until
after the `deviceready`
- Only one
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/84#discussion_r54669864
--- Diff: README.md ---
@@ -58,10 +58,6 @@ Although in the global scope, it is not available until
after the `deviceready`
- Only one
Hey everyone,
The new plugin version selection implementation for cordova-lib has been in PR
[1] for a while and I plan on merging it tomorrow if nobody objects. It is a
pretty big update to the behavior of "cordova plugin add", so I wanted to give
a heads up and make sure that people are aware
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/58#discussion_r54668778
--- Diff: README.md ---
@@ -340,6 +285,61 @@ capturing a video clip, the `CaptureErrorCB` callback
executes with a
- Cordova for B
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/58#discussion_r54668668
--- Diff: README.md ---
@@ -340,6 +285,61 @@ capturing a video clip, the `CaptureErrorCB` callback
executes with a
- Cordova for B
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/526#discussion_r54667932
--- Diff: www/static/js/index.js ---
@@ -145,17 +145,48 @@ $(document).ready(function () {
// Smooth scroll to anchor links
$("a
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/58
Fixing README for display on Cordova website
I moved some stuff around because it looked awkward in the TOC for the
page. See
[here](http://cordova.apache.org/docs/en/dev/cordo
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/84#discussion_r54667450
--- Diff: README.md ---
@@ -58,10 +58,6 @@ Although in the global scope, it is not available until
after the `deviceready`
- Only one
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/526#discussion_r54666977
--- Diff: www/static/js/index.js ---
@@ -145,17 +145,48 @@ $(document).ready(function () {
// Smooth scroll to anchor links
$("a
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/528#issuecomment-191009883
@rakatyal
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-docs/pull/528
CB-10178 Fix a number of documentation issues
Here are the list of fixes
- Add more examples for icons for Windows and link to platform SDK docs.
- Ensure all references to CLI guide -
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/153#issuecomment-191008766
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
GitHub user dblotsky opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/186
CB-10720 Fixed spelling, capitalization, and other small issues.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cord
GitHub user dblotsky opened a pull request:
https://github.com/apache/cordova-plugin-console/pull/17
CB-10720 Minor spelling/formatting changes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-console CB
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media/pull/84#discussion_r54666299
--- Diff: README.md ---
@@ -415,7 +411,7 @@ Starts recording an audio file.
- Windows devices can use MP3, M4A and WMA formats for rec
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/153
Fixing README for display on Cordova website
@dblotsky @rakatyal to review
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/M
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/525#issuecomment-191007432
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/84
Fixing README for display on Cordova website
@dblotsky @rakatyal to review
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTec
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/526#discussion_r54665031
--- Diff: www/static/js/index.js ---
@@ -145,17 +145,48 @@ $(document).ready(function () {
// Smooth scroll to anchor links
$("a
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54663442
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,50 @@ module.exports = function plugin(command, targets,
opts) {
});
};
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54660579
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,50 @@ module.exports = function plugin(command, targets,
opts) {
});
};
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/129
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-globalization/pull/46
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or i
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/46#issuecomment-190957333
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-globalization/pull/46#issuecomment-190956617
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-plugin-globalization/pull/46
Minor changes to readme
@riknoll, @dblotsky: Please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cord
Github user BBosman commented on the pull request:
https://github.com/apache/cordova-docs/pull/503#issuecomment-190953715
Ping @vladimir-kotikov .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-android/pull/264#issuecomment-190952289
Right. I agree that silently passing is not good.
So, I said that we should print the warning message to the user "Warning:
in the already exists. {Skipp
Github user brodybits commented on the pull request:
https://github.com/apache/cordova-android/pull/264#issuecomment-190951704
I would favor leaving it to the plugins to use the `lib-file` instead of
`source-file` to install the libraries. A couple of things that could really
help:
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/155#discussion_r54650191
--- Diff: spec/unit/JsprojManager.spec.js ---
@@ -25,6 +25,7 @@ var AppxManifest =
require('../../template/cordova/lib/AppxManifest');
var Jspr
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/264#issuecomment-190947034
My concern with silently passing here is that there could be a
runtime/build failure because potentially the wrong version of the file is
added depending on th
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/129#issuecomment-190944752
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/129#issuecomment-190943028
@dblotsky, @riknoll: Please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/129
Minor changes to Readme
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-plugin-file-transfer
raghav-r
Github user bso-intel commented on the pull request:
https://github.com/apache/cordova-android/pull/264#issuecomment-190937260
Hi nikhill,
I am not a plugin writer so I don't know whether the plugin write can use
other tags for their purposes.
This issue was reported from
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/264#issuecomment-190929927
I agree we should improve the error messages - especially the 'Uh oh!' :)
We have three tags:
-
[lib-file](http://cordova.apache.org/docs/en/dev/pl
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/527#discussion_r54644131
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,39 @@
+---
+layout: post
+author:
+name: Raghav Katyal
+
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/527#discussion_r54639244
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,39 @@
+---
+layout: post
+author:
+name: Raghav Katyal
+
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/527#discussion_r54639014
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,39 @@
+---
+layout: post
+author:
+name: Raghav Katyal
+
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/527#discussion_r54638889
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,39 @@
+---
+layout: post
+author:
+name: Raghav Katyal
+
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/527#discussion_r54638795
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,39 @@
+---
+layout: post
+author:
+name: Raghav Katyal
+
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/527#discussion_r54638755
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,39 @@
+---
+layout: post
+author:
+name: Raghav Katyal
+
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/527#discussion_r54638717
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,31 @@
+---
+layout: post
+author:
+name: Raghav Katyal
+
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/527#discussion_r54638658
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,39 @@
+---
+layout: post
+author:
+name: Raghav Katyal
+
Github user rakatyal commented on the pull request:
https://github.com/apache/cordova-docs/pull/527#issuecomment-190883463
Addressed feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/526#issuecomment-190880778
Cool! I'm assuming this fixes the camera docs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/527#discussion_r54626152
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,31 @@
+---
+layout: post
+author:
+name: Raghav Katyal
+
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/527#discussion_r54625576
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,31 @@
+---
+layout: post
+author:
+name: Raghav Katyal
+
Github user tobiasmuecksch commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/102#issuecomment-190874401
:+1: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/527#discussion_r54624737
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,31 @@
+---
+layout: post
+author:
+name: Raghav Katyal
+
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/527#discussion_r54624115
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,31 @@
+---
+layout: post
+author:
+name: Raghav Katyal
+
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/527#discussion_r54623759
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,31 @@
+---
+layout: post
+author:
+name: Raghav Katyal
+
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/527#discussion_r54623862
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,31 @@
+---
+layout: post
+author:
+name: Raghav Katyal
+
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/527#discussion_r54623474
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,31 @@
+---
+layout: post
+author:
+name: Raghav Katyal
+
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/527#discussion_r54623383
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,31 @@
+---
+layout: post
+author:
+name: Raghav Katyal
+
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/527#discussion_r54623053
--- Diff: www/_posts/2016-02-29-docs-improvement.md ---
@@ -0,0 +1,31 @@
+---
+layout: post
+author:
+name: Raghav Katyal
+
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-docs/pull/527
Adding blog post for docs improvement
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-docs raghav-blog
Alternatively
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/185#discussion_r54620911
--- Diff: src/ios/CDVCamera.h ---
@@ -87,19 +91,51 @@ typedef NSUInteger CDVMediaType;
{}
@property (strong) CDVCameraPicker* p
I think once that plugin version constraint PR lands, we can removing
plugin pinning. Correct me if I'm wrong, but for that PR to be useful, we
need to update all of the package.json files of the plugins to include the
engine information.
I agree logging something like "fetching pinned plugin vers
GitHub user jerroydmoore opened a pull request:
https://github.com/apache/cordova-windows/pull/156
CB-10714 #2 Ignore case for --archs
Second attempt at CB-10714. Submitted an ICLA earlier today and introduced
myself to the dev@cordova.apache.org mailing list. Passes existing Unit
Yeah, no idea why it was disabled in the first place. +1 to adding it back
On Tue, Mar 1, 2016 at 10:39 AM, Nikhil Khandelwal
wrote:
> Yes, I don't see a reason to disable this.
>
> -Nikhil
>
> -Original Message-
> From: dharmendra sharma [mailto:dharam.accent...@gmail.com]
> Sent: Tuesd
Yes, I don't see a reason to disable this.
-Nikhil
-Original Message-
From: dharmendra sharma [mailto:dharam.accent...@gmail.com]
Sent: Tuesday, March 1, 2016 5:31 AM
To: dev@cordova.apache.org
Subject: Re: cordova-cli Travis CI
I suggest we should keep Travis CI. That will enhance the
+1
-Original Message-
From: Sergey Grebnov (Akvelon) [mailto:v-seg...@microsoft.com]
Sent: Monday, February 29, 2016 11:51 PM
To: dev@cordova.apache.org
Subject: RE: [Vote] 4.1.0 iOS Release
I vote +1
* Run auto-tests for core plugins with browserify option on iOS 8.1.1 device.
Log ava
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/101#issuecomment-190840500
Oops, my bad. :)
Reviewing that PR instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/174#issuecomment-190839346
@MatthewBooth can you fill out an ICLA? I need that in order to merge your
rebase. Instructions are here:
http://cordova.apache.org/contribute/contribute
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/183#issuecomment-190838635
@omefire can you take a look at this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user dieppe commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/101#issuecomment-190836981
@omefire I did close this one :wink:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/101#issuecomment-190836679
I see that you opened another PR:
https://github.com/apache/cordova-plugin-camera/pull/185
Please, close this one then.
---
If your project is set u
1 - 100 of 127 matches
Mail list logo
