Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/410#issuecomment-198858128
@mikaelkindborg thank you for submitting your app to the showcase! Sorry
that it took us so long to address your PR. The Cordova developer community had
a discuss
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/419#issuecomment-198858135
@elijahe thank you for submitting your app to the showcase! Sorry that it
took us so long to address your PR. The Cordova developer community had a
discussion tha
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/407#issuecomment-198858121
@guopengliang thank you for submitting your app to the showcase! Sorry that
it took us so long to address your PR. The Cordova developer community had a
discussio
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/449#issuecomment-198858138
@RianHitori thank you for submitting your app to the showcase! Sorry that
it took us so long to address your PR. The Cordova developer community had a
discussion
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/403#issuecomment-198858117
@gagustavo thank you for submitting your app to the showcase! Sorry that it
took us so long to address your PR. The Cordova developer community had a
discussion t
GitHub user ThillaiganeshChan opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/87
Fix for CB-10822 : Plugin Media - "cordova-plugin-media" 2.2.0 seem hâ¦
â¦ave a "position" bug with mediaSound.getCurrentPosition method.
Added a Check for Recorder
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56601156
--- Diff: src/android/FileUtils.java ---
@@ -1124,7 +1171,18 @@ public void run(JSONArray args) throws
FileExistsException, IOException, TypeMis
Github user shazron commented on the pull request:
https://github.com/apache/cordova-lib/pull/411#issuecomment-197555600
The truncated AppVeyor message says "AppVeyor was unable to build
non-mergeable pull request", which is odd since there are no conflicts (as
reported by Github)
-
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/208#issuecomment-198854215
I could reliably reproduce the "Invalid Device State" problem from here:
https://github.com/phonegap/simctl/issues/9
and the fix resolves that problem (from
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/262#issuecomment-197461655
Can we get a test attached to this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/560#issuecomment-198472751
Jira is [CB-10907](https://issues.apache.org/jira/browse/CB-10907)
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/501#issuecomment-197477488
Thanks for the feedback, @shazron! @karandeepmalik please take a look at
Shazron's comments when you have a moment. I don't know how to best reword the
content, s
Good catch! Looks like a typo.
Kindly,
Dmitry
-Original Message-
From: Tobias Bocanegra [mailto:tri...@apache.org]
Sent: Tuesday, March 15, 2016 6:59 PM
To: dev@cordova.apache.org
Subject: Re: CI Build Status 03/14
Hi,
'cordova-osx' is a bit misleading here. as the bug is for:
'cordova
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/411#issuecomment-197549676
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/155#issuecomment-198467454
@stevengill that old engine info wasn't doing anything, right? I'm good to
remove it?
---
If your project is set up for it, you can reply to this
Github user daserge commented on the pull request:
https://github.com/apache/cordova-android/pull/273#issuecomment-197348065
@dpolivy, I've sent #276
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user kostkobv commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/82#issuecomment-197350848
@omefire I've used the last version of plugin with your changes merged
within but it's still don't work - I'm still getting the same exception
("AVPlayerI
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-docs/pull/558#issuecomment-197379532
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-android/pull/278
CB-8582 Obscure INSTALL_FAILED_VERSION_DOWNGRADE error when installinâ¦
â¦g app
[Jira issue](https://issues.apache.org/jira/browse/CB-8582)
You can merge this pull request into a
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#issuecomment-197445134
@sgrebnov `fn.toString` is also a pretty nasty pattern. Adding buttons for
manual tests is literally what manual tests are. We control both the tests a
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/558#issuecomment-197417802
One last small comment. LGTM otherwise.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Looks like both pull requests have been reviewed and given the thumbs
up. I'll pull them in soon.
On Wed, Mar 16, 2016 at 2:38 PM, Carlos Santana wrote:
> changes are OK
>
> On Wed, Mar 16, 2016 at 5:05 PM Shazron wrote:
>
>> Pull requests sent, with tests:
>>
>> 1. https://github.com/apache/cor
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-docs/pull/558#issuecomment-197407826
Sorry, I wasn't aware of the current process. Reapplied changes to `dev`
version
---
If your project is set up for it, you can reply to this email and ha
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/101#issuecomment-197526519
@dblotsky We don't have manual tests - we have buttons demonstrating api
calls (for both api classes - with and without user interaction), there are n
Github user akofman commented on the pull request:
https://github.com/apache/cordova-android/pull/280#issuecomment-198109318
I already have one, do you want me to send it to you by e-mail ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56600287
--- Diff: src/android/FileUtils.java ---
@@ -433,28 +434,41 @@ public void run(JSONArray args) throws JSONException,
IOException {
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/276#discussion_r56594805
--- Diff: bin/templates/cordova/lib/emulator.js ---
@@ -363,8 +363,14 @@ module.exports.install = function(givenTarget,
buildResults) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/159#discussion_r56635687
--- Diff: spec/unit/Prepare.Win10.spec.js ---
@@ -380,3 +383,79 @@ describe('A Windows 10 project should apply the uap:
namespace prefix to
Please review and vote on this cordova-common Release
by replying to this email (and keep discussion on the DISCUSS thread)
Release issue: https://issues.apache.org/jira/browse/CB-10911
Both tools have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10911/
The packag
hmm, sounds like a reasonable solution. Right now we only reinstall plugins
saved in config.xml (which prepare does). But it makes sense to reinstall
all plugins installed.
Let me know when you have a PR.
On Wed, Mar 16, 2016 at 11:02 AM, Mefire O. wrote:
> I'd like to propose we get in a fix f
PR: https://github.com/apache/cordova-lib/pull/413
Occasionally, there is this issue that crops up, looks like there's a race
condition between the cordova-lib code and the cordova-ios code.
As a result, I will close this PR and we can proceed with the release.
Anyone else is welcome to carry out
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/412#issuecomment-197550412
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user daserge commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/276#discussion_r56474441
--- Diff: bin/templates/cordova/lib/emulator.js ---
@@ -363,8 +363,14 @@ module.exports.install = function(givenTarget,
buildResults) {
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/271#issuecomment-197461335
Can you clean up this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user vladimir-kotikov closed the pull request at:
https://github.com/apache/cordova-windows/pull/159
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Ok sounds good
Thanks,
Edna Morales
From: Carlos Santana
To: dev@cordova.apache.org
Date: 03/17/2016 04:48 PM
Subject:Re: [DISCUSS] cordova-ios release
I agree Steve
- Carlos
@csantanapr
> On Mar 17, 2016, at 4:17 PM, Steven Gill wrote:
>
> Lets do a common release first
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/276
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
GitHub user 5im0n opened a pull request:
https://github.com/apache/cordova-plugin-vibration/pull/45
fix(vibrateWithPattern): function doesn't update the pattern variableâ¦
I use constants in my application for my vibration pattern.
Each time I use the function `vibrateWithP
Github user shazron commented on the pull request:
https://github.com/apache/cordova-android/pull/280#issuecomment-198114802
CLA verified for Alexis Kofman: http://people.apache.org/unlistedclas.html
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-lib/pull/411
CB-10694 - Platform-specific configuration preferences don't override
global settings
Includes jasmine test.
You can merge this pull request into a Git repository by running:
$ git pull h
I don't entirely agree with this, since usually we do respond. We don't
just accept things that get thrown at us, which I think is the expectation.
I think we need to make sure we come to some resolution and actually solve
the problem in a timely manner. We've had both extremes of discussing a
p
On Thu, Mar 17, 2016 at 5:03 PM, Jesse wrote:
> Never trust people's answers when you ask them what they like! They are
> almost always wrong, and will tell you what they think they like, or think
> they will seem cooler if they liked.
>
>
+1
It's interesting that CoffeeScript is on this list an
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/553#issuecomment-197645372
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user daserge commented on the pull request:
https://github.com/apache/cordova-android/pull/271#issuecomment-197740753
@oratthumzap, you should rebase your commit on master so that only relevant
changes are shown.
---
If your project is set up for it, you can reply to this emai
On Thu, Mar 17, 2016 at 5:12 PM, Ryan J. Salva wrote:
> As I told some of my co-workers today:
>
> If you read the fine print, the actual statistic is “% of developers who
> are developing with the language or tech but have not expressed interest in
> continuing to do so.” Clearly, it’s not a goo
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-docs/pull/557#issuecomment-197585138
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
GitHub user vladimir-kotikov reopened a pull request:
https://github.com/apache/cordova-windows/pull/159
CB-10622 Support any MRT qualifiers for Windows icons
JIRA [CB-10622](https://issues.apache.org/jira/browse/CB-10622)
This PR fixes copying MRT images with qualifiers oth
On Thu, Mar 17, 2016 at 5:23 PM, Ryan J. Salva wrote:
> Keep in mind that the answers are limited to the technologies that Stack
> Overflow chooses to offer in their list of options. They have an "other"
> option with a text box, but people's answers are largely driven by the
> checkbox options.
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-windows/pull/161
CB-10888 Enable coverage reports collection via codecov
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-win
Tools release issue: https://issues.apache.org/jira/browse/CB-10902
On Thu, Mar 17, 2016 at 1:18 PM, Mefire O. wrote:
> PR: https://github.com/apache/cordova-lib/pull/413
>
> Occasionally, there is this issue that crops up, looks like there's a race
> condition between the cordova-lib code and
Please review and vote on this Tools Release
by replying to this email (and keep discussion on the DISCUSS thread)
Release issue: https://issues.apache.org/jira/browse/CB-10902
Both tools have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-10902/
The packages were p
I agree Steve
- Carlos
@csantanapr
> On Mar 17, 2016, at 4:17 PM, Steven Gill wrote:
>
> Lets do a common release first and then follow that up with patch ios
> release
>
>> On Thu, Mar 17, 2016 at 11:24 AM, Shazron wrote:
>>
>> I would say patch release. I had some items I wanted in the ne
Github user oratthumzap commented on the pull request:
https://github.com/apache/cordova-android/pull/271#issuecomment-197736415
@infil00p, do you want me to refactor the code or remove the pull request
altogether?
---
If your project is set up for it, you can reply to this email and
Github user pmuellr commented on the pull request:
https://github.com/apache/cordova-weinre/pull/14#issuecomment-197292090
@sgrebnov I believe you added this bit of code way back when; anything else
we need to look out for here?
---
If your project is set up for it, you can reply to
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/560#issuecomment-198162246
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
I'd like to propose we get in a fix for CB-10775 during this release:
https://issues.apache.org/jira/browse/CB-10775
It is breaking lots of people, and I have a fix that will solve this problem
temporarily until we get the more permanent 'cordova platform rm, platform add'
solution in.
It invo
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-android/pull/276
CB-10600 'cordova run android --release' does not use signed and zip-â¦
â¦aligned version of APK
De-prioritize unsigned builds
Adds an actionable hint for INSTALL_PARSE_FAILED
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56579806
--- Diff: src/android/FileUtils.java ---
@@ -1124,6 +1172,18 @@ public void run(JSONArray args) throws
FileExistsException, IOException, TypeMis
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/276#discussion_r56434511
--- Diff: bin/templates/cordova/lib/emulator.js ---
@@ -363,8 +363,14 @@ module.exports.install = function(givenTarget,
buildResults) {
GitHub user shazron opened a pull request:
https://github.com/apache/cordova-lib/pull/412
CB-9264 - Duplicate entries in config.xml
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shazron/cordova-lib CB-9264
Alternatively you ca
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/51#issuecomment-197525596
Testing this now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/553
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-android/pull/277
CB-10888 Enable coverage reports collection via codecov
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-and
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-docs/pull/560
Better syntax highlighting
Switching from prettify to rouge!
Good changes:
* Way nicer looking code blocks that we can easily edit the CSS for
* No more inline code highlightin
Github user omefire commented on the pull request:
https://github.com/apache/cordova-ios/pull/208#issuecomment-198740174
Using ios-sim 5.0.7 didn't solve the problem:
- https://ci.apache.org/builders/cordova-ios/builds/2098
-
https://ci.apache.org/builders/cordova-ios/builds/20
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/161
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
The Buildbot working for ''
has noticed that the buildslave named cordova-osx-slave went away
It last disconnected at Wed Mar 16 19:55:15 2016 (buildmaster-local time)
The admin on record (as reported by BUILDSLAVE:info/admin)
was 'Dmitry Blotsky
'.
Sincerely,
The Buildbot
https://ci.apache.o
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/553#discussion_r56441986
--- Diff: www/docs/en/dev/guide/hybrid/plugins/index.md ---
@@ -44,13 +44,12 @@ For each corresponding native interface, see the list
at the end of
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/558
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/208
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-ios/pull/208
CB-10912: update ios-sim to 5.0.7 to fix 'Invalid Device State' errors
This issue seems to have been introduced by a change in simctl, which
ios-sim relies on:
https://github.com/phon
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56606932
--- Diff: src/android/FileUtils.java ---
@@ -73,8 +73,11 @@ Licensed to the Apache Software Foundation (ASF) under
one
* Permission ca
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/414
CB-10822 CB-10833 Deduplicate platform-agnostic code
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-108
Github user limebreaker commented on the pull request:
https://github.com/apache/cordova-windows/pull/149#issuecomment-198710562
Hello, could it be that the target attr. in:
is actually completely ignored as I always get no img.target in line 360:
var images =
config.ge
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-coho/pull/114
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/195#issuecomment-197422268
LGTM. Thanks for improving testing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
Github user dblotsky closed the pull request at:
https://github.com/apache/cordova-docs/pull/551
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
changes are OK
On Wed, Mar 16, 2016 at 5:05 PM Shazron wrote:
> Pull requests sent, with tests:
>
> 1. https://github.com/apache/cordova-lib/pull/411
>
> 2. https://github.com/apache/cordova-lib/pull/412
>
> On Wed, Mar 16, 2016 at 11:13 AM, Nikhil Khandelwal
> wrote:
> > Thanks for the heads u
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/412#issuecomment-197559090
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
e
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/206
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-docs/pull/558#issuecomment-197387971
I noticed you are modifying 6.x version of the document - it's not a good
idea to do so as dev gets copied to 6.x periodically and these edits will be
lost unless
Github user rakatyal commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56607030
--- Diff: src/android/FileUtils.java ---
@@ -1124,7 +1171,18 @@ public void run(JSONArray args) throws
FileExistsException, IOException, TypeMis
Github user ChickenMythic commented on the pull request:
https://github.com/apache/cordova-weinre/pull/14#issuecomment-197308612
Thank you.
You're right for WindowsPhone (for example), Visual Studio is well suited
to debuggued webviews but it actually requires to use Visual St
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-docs/pull/557
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
GitHub user ktop opened a pull request:
https://github.com/apache/cordova-android/pull/283
CB-10897 Refactor URI Parsing for Whitelist
Fix for CB-10897.
I moved out the code that parses the 'origin' from the whitelist to a
separate function so that it can also be used to p
Rebooted the machine because the iOS simulator was goofing up and people
suggested that rebooting helped resolve the same type of goofing for them. Look
at me: neglecting to do root cause analysis all day, er'ry day.
Kindly,
Dmitry
-Original Message-
From: build...@apache.org [mailto:bu
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-android/pull/282
CB-10833 Reuse plugin installation logic from cordova-common
DO NOT MERGE
This PR is for demo purpose only and shows how the platform code will look
like after plugin addi
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/170#discussion_r56599180
--- Diff: src/android/FileUtils.java ---
@@ -73,8 +73,11 @@ Licensed to the Apache Software Foundation (ASF) under
one
* Permission ca
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/411#issuecomment-197557719
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/51#issuecomment-197549101
@adamduren I've tested this and the save/restore stuff appears to work
great! There is an issue, however, with the results that are returned in the
Some code changes I want to highlight that I want changing, in cordova-common:
1. https://issues.apache.org/jira/browse/CB-10694
Platform specific preferences are "overriden" by global preferences,
because when the merged config.xml file (root config.xml merge with
platform config.xml), the globa
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/413#issuecomment-198065158
Occasionally, there is this issue that pops up:
```
cp: no such file or directory:
/Users/omefire/Projects/tt/platforms/ios/Hello Cordova/.gitignore
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/412#issuecomment-197606599
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/276#discussion_r56369539
--- Diff: bin/templates/cordova/lib/emulator.js ---
@@ -363,8 +363,14 @@ module.exports.install = function(givenTarget,
buildResults) {
Github user omefire commented on the pull request:
https://github.com/apache/cordova-android/pull/281#issuecomment-198428878
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user riknoll commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/559#discussion_r56738586
--- Diff: www/_posts/2016-03-16-new-plugin-fetching.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Richard Knoll
+
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-lib/pull/411#issuecomment-197556043
Yeah, that is weird. Probably not an issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user dpolivy commented on the pull request:
https://github.com/apache/cordova-android/pull/273#issuecomment-197424352
@daserge Thanks! I will close this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user abarranco commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/126#issuecomment-197310054
I've been 2 days debugging my project when i figured out that this was
actually a problem. When i tried to download images from http with 301
re
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/562#issuecomment-198674853
@riknoll you're right, that PR didn't affect this. However in re-doing it I
found out that snapshotting didn't cover ToC files, and I fixed that. All's
well now,
1 - 100 of 143 matches
Mail list logo
