[GitHub] cordova-lib issue #465: CB-11605 Non-destructive platform update

2016-09-16 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-lib/pull/465 I ran this PR with node 6.4.0 and got this: ``` Error: ENOENT: no such file or directory, stat

[GitHub] cordova-ios issue #248: CB-11792 - Add Cocoapods .xcconfig includes to build...

2016-09-16 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/248 Re-opened issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-lib issue #465: CB-11605 Non-destructive platform update

2016-09-16 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-lib/pull/465 Yeah. I think the test attempts to call platforms/android/cordova/update on the old platform while I am expecting a create call. Curiously though it passes on Travis for newer node

[GitHub] cordova-plugin-statusbar pull request #64: CB-11858: Add possibility to util...

2016-09-16 Thread tobiasviehweger
GitHub user tobiasviehweger opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/64 CB-11858: Add possibility to utilize Android M feature "LightStatusBar" ### Platforms affected Android 6.0+ ### What does this PR do? This PR adds support

[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...

2016-09-16 Thread mbektchiev
Github user mbektchiev commented on the issue: https://github.com/apache/cordova-ios/pull/244 I'm not sure if the same behavior can be reproduced with `cordova-ios`. But since the code is exactly the same as the one in `cordova-android` I thought it might be good idea to keep it

[GitHub] cordova-plugin-statusbar issue #64: CB-11858: Add possibility to utilize And...

2016-09-16 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/64 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...

2016-09-16 Thread mbektchiev
Github user mbektchiev commented on the issue: https://github.com/apache/cordova-ios/pull/244 See https://github.com/Wizcorp/phonegap-facebook-plugin/tree/master/platforms/android/FacebookLib and

[GitHub] cordova-ios issue #256: CB-11854 - Create Entitlements.plist file (one each ...

2016-09-16 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-ios/pull/256 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-ios pull request #258: CB-11863 - Update xcodebuild minimum version ...

2016-09-16 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-ios/pull/258 CB-11863 - Update xcodebuild minimum version to 7.0.0 updates travis.yml as well to osx image with xcode 7.3 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-ios issue #250: CB-9762 (iOS) Add launch storyboard support

2016-09-16 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/250 re: your last commit -> https://github.com/apache/cordova-ios/pull/258 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-ios issue #258: CB-11863 - Update xcodebuild minimum version to 7.0....

2016-09-16 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/258 ## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/258?src=pr) is 56.69% (diff: 100%) > Merging [#258](https://codecov.io/gh/apache/cordova-ios/pull/258?src=pr) into

[GitHub] cordova-ios pull request #256: CB-11854 - Create Entitlements.plist file (on...

2016-09-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/256 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-contacts issue #134: CB-11855: (ios) Allow iOS to use hasPhon...

2016-09-16 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-contacts/pull/134 Cordova CI Build has one or more failures. **Commit** -

[GitHub] cordova-ios pull request #258: CB-11863 - Update xcodebuild minimum version ...

2016-09-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/258 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios issue #256: CB-11854 - Create Entitlements.plist file (one each ...

2016-09-16 Thread dpogue
Github user dpogue commented on the issue: https://github.com/apache/cordova-ios/pull/256 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-lib issue #490: Android studio

2016-09-16 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/490 ## [Current coverage](https://codecov.io/gh/apache/cordova-lib/pull/490?src=pr) is 80.38% (diff: 100%) > Merging [#490](https://codecov.io/gh/apache/cordova-lib/pull/490?src=pr) into

[GitHub] cordova-ios issue #257: CB-11860 - Update packaging strategy for Xcode 8

2016-09-16 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/257 ## [Current coverage](https://codecov.io/gh/apache/cordova-ios/pull/257?src=pr) is 56.43% (diff: 0.00%) > Merging [#257](https://codecov.io/gh/apache/cordova-ios/pull/257?src=pr) into

Nightly build #148 for cordova has succeeded!

2016-09-16 Thread Apache Jenkins Server
Nightly build #148 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/148/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-android pull request #331: Android studio

2016-09-16 Thread imhotep
GitHub user imhotep opened a pull request: https://github.com/apache/cordova-android/pull/331 Android studio Adds support for Android Studio plugin install/uninstall You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-lib pull request #490: Android studio

2016-09-16 Thread imhotep
GitHub user imhotep opened a pull request: https://github.com/apache/cordova-lib/pull/490 Android studio Adds Android Studio support Adds some logging for when patformApi fails for weird reasons. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-lib pull request #490: Android studio

2016-09-16 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/490#discussion_r79263894 --- Diff: cordova-common/src/ConfigChanges/ConfigFile.js --- @@ -193,6 +193,11 @@ function resolveConfigFilePath(project_dir, platform, file) {

Re: Xcode 8 packaging changes

2016-09-16 Thread Shazron
Like I mentioned in Kerri's discussion re: launch storyboard, the Xcode 6 requirement was an error in the docs unfortunately. We only support what Xcode was needed to submit to the App Store. We were waiting until Apple dropped Xcode 6, and we forgot to update the docs. So how do we determine if

Re: [VOTE] Plugins Release

2016-09-16 Thread Shazron
The vote has closed. The results are: Positive Binding Votes: 3 Steve Gill Shazron Abdullah Jesse MacFadyen The vote has passed. On Wed, Sep 14, 2016 at 11:22 AM, Jesse wrote: > +1 > > * Ran coho audit-license-headers over the relevant repos (all ok) > * Ran coho

[GitHub] cordova-ios issue #248: CB-11792 - Add Cocoapods .xcconfig includes to build...

2016-09-16 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/248 @dpogue check out my proposed fix in https://issues.apache.org/jira/browse/CB-11792?focusedCommentId=15495523=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15495523

[GitHub] cordova-android issue #218: CB-9696: Add possibility to use non-immersive fu...

2016-09-16 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/218 If you still want this feature, can you change it so it merges cleanly, and works with the other code that uses non-immersive as a fallback? Thanks! --- If your project is set up for it,

[GitHub] cordova-plugin-contacts pull request #134: CB-11855: (ios) Allow iOS to use ...

2016-09-16 Thread soonahn
GitHub user soonahn reopened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/134 CB-11855: (ios) Allow iOS to use hasPhoneNumber ### Platforms affected iOS ### What does this PR do? Fixes https://issues.apache.org/jira/browse/CB-11855

[GitHub] cordova-ios issue #244: CB-11771 Deep symlink directories to target project ...

2016-09-16 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/244 I tested this on the `cordova-plugin-console` plugin and `phonegap-facebook-plugin`. The results before and after applying the patch are the same. In the `PROJECTNAME/plugins` folder,