date:20151106

[GitHub] cordova-plugin-camera pull request: CB-9960 android: Fixed FileNot...

2015-11-06 Thread infil00p

Github user infil00p commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/135#issuecomment-154574485
  
Looks fine, but maybe we should just remove this check and do this another 
way.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Integrate binaries (apk / ipa) upload to stores into Cordova CLI

2015-11-06 Thread Tommy Williams

I am with Jesse… I think it would be great, but wouldn’t hold my breath.

Also agree documenting the process would be fantastic both as a reality check 
and a resource for our users.

The more we can provide after "Hello World", the better.

- tommy

On 7 November 2015 at 09:54:41, Jesse (purplecabb...@gmail.com) wrote:

Yes, I too see the value, but I think it's a bit of wishful thinking. I  
would love to be proven wrong though.  
There are vast differences between the stores submission processes, as well  
as the meta that they require. In the case of iOS, you would likely need to  
scrape the website and live with the possibility that Apple could break it  
at any time.  

I would like to see someone come up with a definitive list of the manual  
steps to take to submit an app to all the stores before we even consider  
automating the process.  
Even as a document alone this would be a great help to our users.  

@purplecabbage  
risingj.com  

On Fri, Nov 6, 2015 at 1:52 PM, Parashuram N  wrote:  

> I think this is a great idea. I understand that we already have a package  
> command and this could be a logical extension. However, will this be a  
> functionality that can be supported on multiple stores ? I am not sure if  
> this is legal on an iOS store.  
>  
>  
>  
>  
> On 11/6/15, 2:41 AM, "M Alexandre"  wrote:  
>  
> >Hello Cordova devs,  
> >  
> >Because Cordova CLI is a great tool for command line for almost everything  
> >about creating, building hybrids apps, it would be great to include a new  
> >command for uploading the generated binaries to the app stores.  
> >  
> >As far as I know, nothing exists at the moment in Cordova. I succeeded  
> >patching gradle scripts for including this feature so I could upload my  
> own  
> >generated APK to my Google Play account from a cordova command. This is  
> >very useful for including Cordova apps into Continuous Integration.  
> >  
> >Did you already think about that ? We could :  
> >  
> > 1. add an option to the "build" command => "cordova build -- release  
> > --upload"  
> > 2. or "cordova upload", that needs to build a release version of the  
> > package  
> >  
> >I described the steps and published a "dirty patch" on  
> >  
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgist.github.com%2fmysegfault%2f9d387cb7f4b08b750bad=01%7c01%7cpanarasi%40microsoft.com%7c347fcb14e8ae46e740b008d2e6ca9f74%7c72f988bf86f141af91ab2d7cd011db47%7c1=8B8YejUQ6F8obdheWvLmrPN0CCspx4zJjV%2fxnpSnjdI%3d
>   
> for Android.  
> >  
> >Thanks for your feedback.  
> >--  
> >Maxime  
>

[DISCUSS] Docs Release

2015-11-06 Thread Steven Gill

Going to do one tied to 5.4.0 tools release. Any objections or concerns?

[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...

2015-11-06 Thread stevengill

Github user stevengill commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154577821
  
I think we need @aroberson to sign and submit an ICLA 
https://www.apache.org/licenses/icla.txt 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: API for saving/restoring plugin and ...

2015-11-06 Thread riknoll

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-android/pull/236#issuecomment-154590431
  
After getting some feedback from @purplecabbage on the dev list and talking 
this over with @jasongin, it sounds as though we should cut everything from 
this resume payload besides the pending result (which means we would remove 
`app.saveState` as well). The burden will be on the app developer to maintain 
their state in local storage including the context surrounding whatever plugin 
calls they have pending. The new resume event payload would look like this:
```
{
action: "resume",
pendingResult: {
pluginServiceName: ,
pluginStatus: ,
result: 
}
}
```
I agree that this is a much better idea. We should make sure we communicate 
the need for saving state well in the Android and plugin docs so that 
developers are aware of this unique Android "feature".

Are people okay with the proposed approach for allowing plugins that are 
waiting for external results to bundle up their state on the native side? 
Alternatively, we can leave plugin developers to be good about maintaining 
their state (using something like Android preferences). This is technically 
already possible assuming that we fire events correctly, but a little clunky. 
The advantage of the approach in this PR is that it exposes the standard 
Android way of doing things on the native side with the Bundle save/restore 
API. Does that API make sense? Should we open it up to all plugins instead of 
just the plugin that is receiving the Activity result?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request: Fixes CB-4712, CB-5439 stat...

2015-11-06 Thread csantanapr

Github user csantanapr commented on the pull request:


https://github.com/apache/cordova-plugin-statusbar/pull/38#issuecomment-154596695
  
LGTM, rebase the two commits into a single one.
Basically you added an observer that anytime that you get notify about 
status bar change, you do a resize. The approach sounds reasonable.
It will be good if @shazron can take a quick look also.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] Plugins release

2015-11-06 Thread Richard Knoll

I plan on merging in https://github.com/apache/cordova-plugin-camera/pull/135 
for the camera plugin if there are no objections.

Thanks,
Richard

-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com] 
Sent: Friday, November 6, 2015 11:38 AM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Plugins release

With plugin changes, it is always nice to get reviews since it could affect 
every platform.

file:146 is merged
file: 119 LGTM
Statusbar: 38 could use a review by iOS experts

Keep em coming in!

-Steve

On Fri, Nov 6, 2015 at 5:53 AM, Simon MacDonald 
wrote:

> I agree with Jason,
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu
> b.com%2fapache%2fcordova-plugin-file%2fpull%2f146=01%7c01%7cRIKNOLL%40exchange.microsoft.com%7c1e652e1ff1074570a66908d2e6e1e10f%7c72f988bf86f141af91ab2d7cd011db47%7c1=HU0E%2fMPc3C2cD%2fNEtQlLGStzqfDX4Sm%2f3OdrdACiHb8%3d
>  should be merged.
>
> Simon Mac Donald
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fhi.im%
> 2fsimonmacdonald=01%7c01%7cRIKNOLL%40exchange.microsoft.com%7c1e6
> 52e1ff1074570a66908d2e6e1e10f%7c72f988bf86f141af91ab2d7cd011db47%7c1
> data=MXNVR%2bXGeH703bFkFHohHk6EwL8amOj4btn2kNuUPiU%3d
>
> On Thu, Nov 5, 2015 at 8:07 PM, Jason Ginchereau 
> 
> wrote:
> > I think this PR should get in the release:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu
> b.com%2fapache%2fcordova-plugin-file%2fpull%2f146=01%7c01%7cRIKNO
> LL%40exchange.microsoft.com%7c1e652e1ff1074570a66908d2e6e1e10f%7c72f98
> 8bf86f141af91ab2d7cd011db47%7c1=HU0E%2fMPc3C2cD%2fNEtQlLGStzqfDX
> 4Sm%2f3OdrdACiHb8%3d
> > It might be considered a blocker, because it is a regression that 
> > could
> cause loss of data when upgrading apps which relied on the default 
> AndroidPersistentFileLocation value.
> >
> > This would be a good one also, as it fixes a significant failure 
> > working
> with some kinds of files on Android 5.0:
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithu
> b.com%2fapache%2fcordova-plugin-file%2fpull%2f119=01%7c01%7cRIKNO
> LL%40exchange.microsoft.com%7c1e652e1ff1074570a66908d2e6e1e10f%7c72f98
> 8bf86f141af91ab2d7cd011db47%7c1=TxHgwQq3dyT4Qlo7PM%2fQ0iU3KhtoMP
> J5uU3UqGcY6yA%3d
> >
> > Jason
> >
> > -Original Message-
> > From: Steven Gill [mailto:stevengil...@gmail.com]
> > Sent: Thursday, November 5, 2015 3:09 PM
> > To: dev@cordova.apache.org
> > Subject: [DISCUSS] Plugins release
> >
> > I plan on starting a plugins release on Monday. It is going to be a 
> > big
> one.
> >
> > Please review and close as many PRs as you can before than.
> >
> > If you have PR that is ready and needs someone to look at + merge,
> please share it in this thread and we will try to get to it before the 
> release.
> > You could also share it on slack[1] in the #plugins channel.
> >
> > Let me know if we have any blockers.
> >
> > Cheers,
> > -Steve
> >
> >
> > [1]
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fslack.
> cordova.io=01%7c01%7cjasongin%40microsoft.com%7c6bb15854633242978
> d6208d2e636167f%7c72f988bf86f141af91ab2d7cd011db47%7c1=QY3Nj3rIJ
> VCSOuncqfAqTul2GKH9L0Z7FQ3oaln4vg4%3d
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Native vs. File URIs

2015-11-06 Thread Shazron

I always thought a native URI was if the image was retrieved from the
ALAssetsLibrary (Photos Album).
https://developer.apple.com/library/ios/documentation/AssetsLibrary/Reference/ALAssetsLibrary_Class/
and the file URI was the image we dumped into tmp.



On Fri, Nov 6, 2015 at 11:43 AM, Richard Knoll  wrote:
> Hey all,
>
> I was wondering if anybody could clarify for me what the difference between 
> FILE_URI and NATIVE_URI is in the camera plugin. Do we have a clear 
> definition of either? I assumed that FILE_URI would refer to an actual path 
> on the device (i.e. a URI using the "file" scheme) but the docs for the 
> camera plugin actually use a content URI as an example. This seems 
> counterintuitive, especially since the "content" scheme is specific to 
> Android. As it stands, FILE_URI and NATIVE_URI always return the same thing 
> in Android and can either give a content URI or a file URI depending on the 
> other camera options that are passed. I think we need to be clear when 
> returning URIs so that app developers can tell what they have to do with it 
> before they can use it in their app. Also, it's worth noting that the 
> FILE_URI and NATIVE_URI question is complicated by the fact that on Android 
> it is possible to pick photos using apps like Google Photos which can choose 
> files that have no local path. I also would love some clarification as to 
> where "cdvfile" fits into all of this and the type of support it has across 
> the plugins. This is in regards to CB-9548, for those interested.
>
> Thanks,
> Richard

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: API for saving/restoring plugin and ...

2015-11-06 Thread riknoll

Github user riknoll commented on the pull request:

https://github.com/apache/cordova-android/pull/236#issuecomment-154566865
  
So in terms of a common API across platforms, what part are we looking at 
generalizing? Obviously we should ensure that each platform properly fires its 
pause and resume events, but is there also a need for allowing plugins to 
communicate state as I have done here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Plugin Audit 2015

2015-11-06 Thread Steven Gill

Jesse, Simon and I spent sometime doing a plugin audit. Our recommendations
can be found at https://github.com/cordova/cordova-discuss/pull/28

Overview:
https://github.com/stevengill/cordova-discuss/blob/master/proposals/PluginsAudit2015/overview.md

Please give us feedback!

-Steve

Re: Integrate binaries (apk / ipa) upload to stores into Cordova CLI

2015-11-06 Thread Jesse

Yes, I too see the value, but I think it's a bit of wishful thinking.  I
would love to be proven wrong though.
There are vast differences between the stores submission processes, as well
as the meta that they require. In the case of iOS, you would likely need to
scrape the website and live with the possibility that Apple could break it
at any time.

I would like to see someone come up with a definitive list of the manual
steps to take to submit an app to all the stores before we even consider
automating the process.
Even as a document alone this would be a great help to our users.



@purplecabbage
risingj.com

On Fri, Nov 6, 2015 at 1:52 PM, Parashuram N  wrote:

> I think this is a great idea. I understand that we already have a package
> command and this could be a logical extension. However, will this be a
> functionality that can be supported on multiple stores ? I am not sure if
> this is legal on an iOS store.
>
>
>
>
> On 11/6/15, 2:41 AM, "M Alexandre"  wrote:
>
> >Hello Cordova devs,
> >
> >Because Cordova CLI is a great tool for command line for almost everything
> >about creating, building hybrids apps, it would be great to include a new
> >command for uploading the generated binaries to the app stores.
> >
> >As far as I know, nothing exists at the moment in Cordova. I succeeded
> >patching gradle scripts for including this feature so I could upload my
> own
> >generated APK to my Google Play account from a cordova command. This is
> >very useful for including Cordova apps into Continuous Integration.
> >
> >Did you already think about that ? We could :
> >
> >   1. add an option to the "build" command => "cordova build -- release
> >   --upload"
> >   2. or "cordova upload", that needs to build a release version of the
> >   package
> >
> >I described the steps and published a "dirty patch" on
> >
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgist.github.com%2fmysegfault%2f9d387cb7f4b08b750bad=01%7c01%7cpanarasi%40microsoft.com%7c347fcb14e8ae46e740b008d2e6ca9f74%7c72f988bf86f141af91ab2d7cd011db47%7c1=8B8YejUQ6F8obdheWvLmrPN0CCspx4zJjV%2fxnpSnjdI%3d
> for Android.
> >
> >Thanks for your feedback.
> >--
> >Maxime
>

[GitHub] cordova-docs pull request: CB-9903 added 5.4.0 tools release blog

2015-11-06 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/411


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: Integrate binaries (apk / ipa) upload to stores into Cordova CLI

2015-11-06 Thread Parashuram N

How about sending a PR to the docs, and list these tools in those docs ? These 
tools could be useful for folks who are looking at Cordova continuous 
integration scenarios. 

Speaking of which, what do folks on this usually use for Cordova continuous 
integration ? 




On 11/6/15, 4:58 PM, "Connor Pearson"  wrote:

>There are some command line tools that support uploading an ipa (
>https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fnomad%2fshenzhen%2c=01%7c01%7cpanarasi%40microsoft.com%7c5ac76df321694f5fcbe908d2e70e9a93%7c72f988bf86f141af91ab2d7cd011db47%7c1=MBoAHveBlgE6vrvhnxT0Lt2EVL0YyQVJg665dhleWMs%3d
> 
>https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2ffastlane%2fdeliver=01%7c01%7cpanarasi%40microsoft.com%7c5ac76df321694f5fcbe908d2e70e9a93%7c72f988bf86f141af91ab2d7cd011db47%7c1=9qABsUGssWTLzl6IwEF7EoPAIltEAXRcvTSAJpAmmoY%3d)
> so
>it is possible. I don't think Apple officially supports this though, so it
>may be prone to breaking.
>
>On Fri, Nov 6, 2015 at 7:08 PM, Tommy Williams  wrote:
>
>> I am with Jesse… I think it would be great, but wouldn’t hold my breath.
>>
>> Also agree documenting the process would be fantastic both as a reality
>> check and a resource for our users.
>>
>> The more we can provide after "Hello World", the better.
>>
>> - tommy
>>
>>
>> On 7 November 2015 at 09:54:41, Jesse (purplecabb...@gmail.com) wrote:
>>
>> Yes, I too see the value, but I think it's a bit of wishful thinking. I
>> would love to be proven wrong though.
>> There are vast differences between the stores submission processes, as well
>> as the meta that they require. In the case of iOS, you would likely need to
>> scrape the website and live with the possibility that Apple could break it
>> at any time.
>>
>> I would like to see someone come up with a definitive list of the manual
>> steps to take to submit an app to all the stores before we even consider
>> automating the process.
>> Even as a document alone this would be a great help to our users.
>>
>>
>>
>> @purplecabbage
>> https://na01.safelinks.protection.outlook.com/?url=risingj.com=01%7c01%7cpanarasi%40microsoft.com%7c5ac76df321694f5fcbe908d2e70e9a93%7c72f988bf86f141af91ab2d7cd011db47%7c1=6PrW3aEC6BJUhcm9TTlW58SyXQIkKVgONK23a3SCj1Y%3d
>>
>> On Fri, Nov 6, 2015 at 1:52 PM, Parashuram N 
>> wrote:
>>
>> > I think this is a great idea. I understand that we already have a package
>> > command and this could be a logical extension. However, will this be a
>> > functionality that can be supported on multiple stores ? I am not sure if
>> > this is legal on an iOS store.
>> >
>> >
>> >
>> >
>> > On 11/6/15, 2:41 AM, "M Alexandre"  wrote:
>> >
>> > >Hello Cordova devs,
>> > >
>> > >Because Cordova CLI is a great tool for command line for almost
>> everything
>> > >about creating, building hybrids apps, it would be great to include a
>> new
>> > >command for uploading the generated binaries to the app stores.
>> > >
>> > >As far as I know, nothing exists at the moment in Cordova. I succeeded
>> > >patching gradle scripts for including this feature so I could upload my
>> > own
>> > >generated APK to my Google Play account from a cordova command. This is
>> > >very useful for including Cordova apps into Continuous Integration.
>> > >
>> > >Did you already think about that ? We could :
>> > >
>> > > 1. add an option to the "build" command => "cordova build -- release
>> > > --upload"
>> > > 2. or "cordova upload", that needs to build a release version of the
>> > > package
>> > >
>> > >I described the steps and published a "dirty patch" on
>> > >
>> >
>> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgist.github.com%2fmysegfault%2f9d387cb7f4b08b750bad=01%7c01%7cpanarasi%40microsoft.com%7c347fcb14e8ae46e740b008d2e6ca9f74%7c72f988bf86f141af91ab2d7cd011db47%7c1=8B8YejUQ6F8obdheWvLmrPN0CCspx4zJjV%2fxnpSnjdI%3d
>> > for Android.
>> > >
>> > >Thanks for your feedback.
>> > >--
>> > >Maxime
>> >
>>

[GitHub] cordova-plugin-camera pull request: CB-9960 android: Fixed FileNot...

2015-11-06 Thread jasongin

Github user jasongin commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/135#issuecomment-154568849
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-9960 android: Fixed FileNot...

2015-11-06 Thread riknoll

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/135#issuecomment-154577011
  
I was trying to preserve the existing behavior, but I totally agree it's 
not ideal. What we lose by doing this check is the filename and EXIF data for 
images not on the device. I wonder if the filename is in fact retrievable using 
the ContentResolver (I haven't looked into it that closely). We might be able 
to grab the EXIF when we get the filestream in `getScaledbitmap()`. That might 
be a bit more robust overall.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: CB-9960 android: Fixed FileNot...

2015-11-06 Thread infil00p

Github user infil00p commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/135#issuecomment-154577826
  
I think that's what #112 does.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...

2015-11-06 Thread aroberson

Github user aroberson commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154581790
  
I will get to this tonight.



> On Nov 6, 2015, at 5:38 PM, Steve Gill  wrote:
> 
> I think we need @aroberson to sign and submit an ICLA 
https://www.apache.org/licenses/icla.txt
> 
> â
> Reply to this email directly or view it on GitHub.
> 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [VOTE] Tools Release (attempt 3)

2015-11-06 Thread Steven Gill

The vote has now closed. The results are:

Positive Binding Votes: 4
Steve Gill
Alexander Sorokin
Parashuram N
Sergey Grebnov

The vote has passed. I will now publish to dist + npm. I will also
publish the release blog post.


On Thu, Nov 5, 2015 at 10:27 PM, Sergey Grebnov (Akvelon) <
v-seg...@microsoft.com> wrote:

> +1
>
> * Verified ability to install/uninstall Cordova on Windows
> * Verified blank app could be created
> * Verified iOS, Android, Windows platforms could be added and built (iOS
> prepare only )
> * Reviewed release notes
> * Verified cordova run --list
>
> -Sergey Grebnov
>
> -Original Message-
> From: Parashuram N [mailto:panar...@microsoft.com]
> Sent: Friday, November 6, 2015 12:50 AM
> To: dev@cordova.apache.org
> Subject: Re: [VOTE] Tools Release (attempt 3)
>
> I vote +1.
>
> * Verified tags
> * Ability to install/uninstall Cordova
> * Ability to update Cordova
> * Ability to create blank app for Windows, WP8, Android
> * Ability to build/run apps
> * Reviewed release notes
> * Verified versions
> * Verified line breaks
> * Verified 'cordova serve'
> * Verified that browserified app builds and runs correctly
>
>
>
>
>
>
> On 11/5/15, 5:04 AM, "Alexander Sorokin (Akvelon)" 
> wrote:
>
> >I vote +1.
> >
> >* Verified tags
> >* Ability to install/uninstall Cordova
> >* Ability to update Cordova
> >* Ability to create blank app for Windows, WP8, Android
> >* Ability to build/run apps
> >* Reviewed release notes
> >* Verified versions
> >* Verified line breaks
> >* Verified 'cordova serve'
> >* Verified that browserified app builds and runs correctly
> >
> >-Original Message-
> >From: Steven Gill [mailto:stevengil...@gmail.com]
> >Sent: Thursday, November 5, 2015 12:14 AM
> >To: dev@cordova.apache.org
> >Subject: [VOTE] Tools Release (attempt 3)
> >
> >Please review and vote on this Tools Release by replying to this email
> >(and keep discussion on the DISCUSS thread)
> >
> >Release issue:
> >https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fissues
> >.apache.org%2fjira%2fbrowse%2fCB-9903=01%7c01%7cv-alsoro%40microso
> >ft.com%7c2896234d7f1e4ec5e8bc08d2e55cfb97%7c72f988bf86f141af91ab2d7cd01
> >1db47%7c1=4sUp2hjJV7Tc47wBBfO0TZKfWIgLY5pH3RVN8W1lWBM%3d
> >
> >Tools have been published to
> >dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9903/
> >
> >The packages were published from their corresponding git tags:
> >
> >cordova-js: 4.1.2 (90546bd136)
> >cordova-lib: 5.4.0 (f977a71539)
> >cordova-plugman: 1.0.5 (3449d5b251)
> >cordova-cli: 5.4.0 (81716f6599)
> >
> >Upon a successful vote I will upload the archives to dist/, publish them
> to npm, and post the corresponding blog post.
> >
> >Voting guidelines:
> >https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub
> >.com%2fapache%2fcordova-coho%2fblob%2fmaster%2fdocs%2frelease-voting.md
> >=01%7c01%7cv-alsoro%40microsoft.com%7c2896234d7f1e4ec5e8bc08d2e55c
> >fb97%7c72f988bf86f141af91ab2d7cd011db47%7c1=NxhEbqqhiuJlpTwTuQlUb
> >owcqe65lbJWFsPfpWWYJVc%3d
> >
> >Voting will go on for a minimum of 48 hours.
> >
> >I vote +1:
> >* Ran coho audit-license-headers over the relevant repos
> >* Ran coho check-license to ensure all dependencies and subdependencies
> >have Apache-compatible licenses
> >* Created and ran mobilespec on android
> >?B 
> >CB ? ?[  X  ܚX K??K[XZ[? ??] ][  X  ܚX P? ܙ?ݘK \?X ?K ܙ B  ܈?Y??]?[ۘ[??
> >  [X[ ? ??K[XZ[? ??] Z?[??? ܙ?ݘK \?X ?K ܙ B
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>

Re: [DISCUSS] Docs Release

2015-11-06 Thread Andrey Kurdumov

+1
7 Ноя 2015 г. 6:25 пользователь "Steven Gill" 
написал:

> Going to do one tied to 5.4.0 tools release. Any objections or concerns?
>

Re: Integrate binaries (apk / ipa) upload to stores into Cordova CLI

2015-11-06 Thread Connor Pearson

Would a hook or plugin work better then?

On Fri, Nov 6, 2015 at 8:42 PM, Shazron  wrote:

> The problem with using "unofficial" methods is, at least for some of
> our code contributors *cough IBM*, it won't fly with them, and IMO I'd
> rather not support unofficial methods as well in this project.
>
> e.g. http://stackoverflow.com/a/13232352 which appears to show a
> command line tool that allows upload, but guess what, they removed it
> in Xcode 7.1 
>
> On Fri, Nov 6, 2015 at 4:58 PM, Connor Pearson  wrote:
> > There are some command line tools that support uploading an ipa (
> > https://github.com/nomad/shenzhen, https://github.com/fastlane/deliver)
> so
> > it is possible. I don't think Apple officially supports this though, so
> it
> > may be prone to breaking.
> >
> > On Fri, Nov 6, 2015 at 7:08 PM, Tommy Williams 
> wrote:
> >
> >> I am with Jesse… I think it would be great, but wouldn’t hold my breath.
> >>
> >> Also agree documenting the process would be fantastic both as a reality
> >> check and a resource for our users.
> >>
> >> The more we can provide after "Hello World", the better.
> >>
> >> - tommy
> >>
> >>
> >> On 7 November 2015 at 09:54:41, Jesse (purplecabb...@gmail.com) wrote:
> >>
> >> Yes, I too see the value, but I think it's a bit of wishful thinking. I
> >> would love to be proven wrong though.
> >> There are vast differences between the stores submission processes, as
> well
> >> as the meta that they require. In the case of iOS, you would likely
> need to
> >> scrape the website and live with the possibility that Apple could break
> it
> >> at any time.
> >>
> >> I would like to see someone come up with a definitive list of the manual
> >> steps to take to submit an app to all the stores before we even consider
> >> automating the process.
> >> Even as a document alone this would be a great help to our users.
> >>
> >>
> >>
> >> @purplecabbage
> >> risingj.com
> >>
> >> On Fri, Nov 6, 2015 at 1:52 PM, Parashuram N 
> >> wrote:
> >>
> >> > I think this is a great idea. I understand that we already have a
> package
> >> > command and this could be a logical extension. However, will this be a
> >> > functionality that can be supported on multiple stores ? I am not
> sure if
> >> > this is legal on an iOS store.
> >> >
> >> >
> >> >
> >> >
> >> > On 11/6/15, 2:41 AM, "M Alexandre"  wrote:
> >> >
> >> > >Hello Cordova devs,
> >> > >
> >> > >Because Cordova CLI is a great tool for command line for almost
> >> everything
> >> > >about creating, building hybrids apps, it would be great to include a
> >> new
> >> > >command for uploading the generated binaries to the app stores.
> >> > >
> >> > >As far as I know, nothing exists at the moment in Cordova. I
> succeeded
> >> > >patching gradle scripts for including this feature so I could upload
> my
> >> > own
> >> > >generated APK to my Google Play account from a cordova command. This
> is
> >> > >very useful for including Cordova apps into Continuous Integration.
> >> > >
> >> > >Did you already think about that ? We could :
> >> > >
> >> > > 1. add an option to the "build" command => "cordova build -- release
> >> > > --upload"
> >> > > 2. or "cordova upload", that needs to build a release version of the
> >> > > package
> >> > >
> >> > >I described the steps and published a "dirty patch" on
> >> > >
> >> >
> >>
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgist.github.com%2fmysegfault%2f9d387cb7f4b08b750bad=01%7c01%7cpanarasi%40microsoft.com%7c347fcb14e8ae46e740b008d2e6ca9f74%7c72f988bf86f141af91ab2d7cd011db47%7c1=8B8YejUQ6F8obdheWvLmrPN0CCspx4zJjV%2fxnpSnjdI%3d
> >> > for Android.
> >> > >
> >> > >Thanks for your feedback.
> >> > >--
> >> > >Maxime
> >> >
> >>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-windows pull request: Add support for back button on win10

2015-11-06 Thread EionRobb

Github user EionRobb commented on the pull request:

https://github.com/apache/cordova-windows/pull/120#issuecomment-154648176
  
I wouldn't personally make it look for the "MSAppHost/3.0" string, maybe 
doing a regex match on that to see if it's version 3.0 or higher might be 
better?
```
parseInt(navigator.appVersion.match(/MSAppHost\/([0-9]+)/)[1]) >= 3
```
or something, just to futureproof it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: Fixed NullPointer Exception in A...

2015-11-06 Thread aroberson

Github user aroberson commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/119#issuecomment-154613677
  
I filled it out and sent it to the secretary.

Thanks,

Adam Roberson

On 11/6/15 5:38 PM, Steve Gill wrote:
>
> I think we need @aroberson  to sign and 
> submit an ICLA https://www.apache.org/licenses/icla.txt
>
> â
> Reply to this email directly or view it on GitHub 
> 
.
>




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-android pull request: CB-9831 CB-9835 CB-9932 Added e2e te...

2015-11-06 Thread alsorokin

GitHub user alsorokin opened a pull request:

https://github.com/apache/cordova-android/pull/238

CB-9831 CB-9835 CB-9932 Added e2e tests

https://issues.apache.org/jira/browse/CB-9831
https://issues.apache.org/jira/browse/CB-9835
https://issues.apache.org/jira/browse/CB-9932

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MSOpenTech/cordova-android e2e

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-android/pull/238.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #238


commit 0cbda02ca62e716cc59002ea9bfbef6991f53e45
Author: Alexander Sorokin 
Date:   2015-11-02T15:58:13Z

CB-9831 CB-9835 CB-9932 Added e2e tests




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Default value for required variables

2015-11-06 Thread mbektchiev

GitHub user mbektchiev opened a pull request:

https://github.com/apache/cordova-docs/pull/415

Default value for required variables



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Icenium/cordova-docs bektchiev/default-value

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-docs/pull/415.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #415


commit e4d1266767009f22af61552f6265d31ecc17aa5c
Author: Martin Bektchiev 
Date:   2015-11-06T08:51:48Z

Default value for required variables




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Plugins release

2015-11-06 Thread julio cesar sanchez

I was writing a mail with the same subject, luckily I saw your message
before sending.

I have this PR for statusbar plugin (ios), it fixes at least 2 jira issues
related to hotspot/call status bar and maybe a lot of more webview
size/resize issues (will check once it's merged)
https://github.com/apache/cordova-plugin-statusbar/pull/38



2015-11-06 2:07 GMT+01:00 Jason Ginchereau :

> I think this PR should get in the release:
> https://github.com/apache/cordova-plugin-file/pull/146
> It might be considered a blocker, because it is a regression that could
> cause loss of data when upgrading apps which relied on the default
> AndroidPersistentFileLocation value.
>
> This would be a good one also, as it fixes a significant failure working
> with some kinds of files on Android 5.0:
> https://github.com/apache/cordova-plugin-file/pull/119
>
> Jason
>
> -Original Message-
> From: Steven Gill [mailto:stevengil...@gmail.com]
> Sent: Thursday, November 5, 2015 3:09 PM
> To: dev@cordova.apache.org
> Subject: [DISCUSS] Plugins release
>
> I plan on starting a plugins release on Monday. It is going to be a big
> one.
>
> Please review and close as many PRs as you can before than.
>
> If you have PR that is ready and needs someone to look at + merge, please
> share it in this thread and we will try to get to it before the release.
> You could also share it on slack[1] in the #plugins channel.
>
> Let me know if we have any blockers.
>
> Cheers,
> -Steve
>
>
> [1]
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fslack.cordova.io=01%7c01%7cjasongin%40microsoft.com%7c6bb15854633242978d6208d2e636167f%7c72f988bf86f141af91ab2d7cd011db47%7c1=QY3Nj3rIJVCSOuncqfAqTul2GKH9L0Z7FQ3oaln4vg4%3d
>

Re: [DISCUSS] Plugins release

2015-11-06 Thread julio cesar sanchez

Yeah, but I was told that my pull requests still had to pass reviews.

As the issues are related to the native webview size, I can't think any
test to add that can check that.

The pull request fixes CB-4712 and CB-5439 but it might fix other webview
size related issues as side effect. I've just tested for CB-4712 and
CB-5439, but once it's merged I'll check all the pending statusbar issues
to see if they were fixed too. Or I can check them this weekend before the
plugin is relesed, but didn't want to add more CBs to the pull request name
as only the first one was linked.


2015-11-06 12:37 GMT+01:00 Carlos Santana :

> Julio,
> You are a committer now :-), you can go ahead and merge if it's ready.
>
> Any manual or auto tests you can add or the one that exist today enough?
>
> What you mean by once it's merge you can check? You mean for any other
> uses cases in addition of the ones you already fixed
>
> - Carlos
> @csantanapr
>
> > On Nov 6, 2015, at 5:56 AM, julio cesar sanchez 
> wrote:
> >
> > I was writing a mail with the same subject, luckily I saw your message
> > before sending.
> >
> > I have this PR for statusbar plugin (ios), it fixes at least 2 jira
> issues
> > related to hotspot/call status bar and maybe a lot of more webview
> > size/resize issues (will check once it's merged)
> > https://github.com/apache/cordova-plugin-statusbar/pull/38
> >
> >
> >
> > 2015-11-06 2:07 GMT+01:00 Jason Ginchereau :
> >
> >> I think this PR should get in the release:
> >> https://github.com/apache/cordova-plugin-file/pull/146
> >> It might be considered a blocker, because it is a regression that could
> >> cause loss of data when upgrading apps which relied on the default
> >> AndroidPersistentFileLocation value.
> >>
> >> This would be a good one also, as it fixes a significant failure working
> >> with some kinds of files on Android 5.0:
> >> https://github.com/apache/cordova-plugin-file/pull/119
> >>
> >> Jason
> >>
> >> -Original Message-
> >> From: Steven Gill [mailto:stevengil...@gmail.com]
> >> Sent: Thursday, November 5, 2015 3:09 PM
> >> To: dev@cordova.apache.org
> >> Subject: [DISCUSS] Plugins release
> >>
> >> I plan on starting a plugins release on Monday. It is going to be a big
> >> one.
> >>
> >> Please review and close as many PRs as you can before than.
> >>
> >> If you have PR that is ready and needs someone to look at + merge,
> please
> >> share it in this thread and we will try to get to it before the release.
> >> You could also share it on slack[1] in the #plugins channel.
> >>
> >> Let me know if we have any blockers.
> >>
> >> Cheers,
> >> -Steve
> >>
> >>
> >> [1]
> >>
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fslack.cordova.io=01%7c01%7cjasongin%40microsoft.com%7c6bb15854633242978d6208d2e636167f%7c72f988bf86f141af91ab2d7cd011db47%7c1=QY3Nj3rIJVCSOuncqfAqTul2GKH9L0Z7FQ3oaln4vg4%3d
> >>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-plugin-file pull request: Fix default persistent file loca...

2015-11-06 Thread macdonst

Github user macdonst commented on the pull request:


https://github.com/apache/cordova-plugin-file/pull/146#issuecomment-154414663
  
@jasongin +1

Yeah, the change to compatibility looks like a mistake. It is supposed to 
be "internal" as of the 3.0.0 release.e


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-coho pull request: CB-9962 Fixed CI builds

2015-11-06 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-coho/pull/103


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: Add support for back button on win10

2015-11-06 Thread sgrebnov

Github user sgrebnov commented on the pull request:

https://github.com/apache/cordova-windows/pull/120#issuecomment-154416603
  
@EionRobb could you please verify the following change: 
```
parseInt(window.clientInformation.userAgent.match(/Windows NT 
([0-9.]+)/)[1]) >= 10
->
navigator.appVersion.indexOf('MSAppHost/3.0') !== -1
```
to support Mobile 10 as well


https://github.com/apache/cordova-windows/commit/02a1ded1edb70d38f9259f8ab4543887514a19f8#diff-39f17a8caa1889e86840a9f4c1dd99b2R127


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file pull request: Fix default persistent file loca...

2015-11-06 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-file/pull/146


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Update to plugin.md regarding Cordova-A...

2015-11-06 Thread dpogue

Github user dpogue commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/409#discussion_r44178488
  
--- Diff: www/_posts/2015-11-05-cordova-android-5.0.0.md ---
@@ -0,0 +1,57 @@
+---
+layout: post
+author:
+name:Joe Bowser
+url: https://twitter.com/infil00p
+title:  "Apache Cordova 5.0.0"
+categories: announcements
+tags: news releases
+---
+We are happy to announce that Cordova Android 5.0.0` has been released.
+
+With this release, there is now support for Android Marshmallow permission 
checking in plugins.  Due to the nature of the recent Android changes, the
+major version has been incremented to reflect the new API changes.  Only 
plugins that use certain permissions as defined by Google are affected
+by this change.
+
+Information on how to use the new Android Permission APIs can be found in 
the Cordova documentation, which can be found here.
--- End diff --

Missing link to the relevant docs


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Plugins release

2015-11-06 Thread Steven Gill

With plugin changes, it is always nice to get reviews since it could affect
every platform.

file:146 is merged
file: 119 LGTM
Statusbar: 38 could use a review by iOS experts

Keep em coming in!

-Steve

On Fri, Nov 6, 2015 at 5:53 AM, Simon MacDonald 
wrote:

> I agree with Jason,
> https://github.com/apache/cordova-plugin-file/pull/146 should be
> merged.
>
> Simon Mac Donald
> http://hi.im/simonmacdonald
>
> On Thu, Nov 5, 2015 at 8:07 PM, Jason Ginchereau 
> wrote:
> > I think this PR should get in the release:
> https://github.com/apache/cordova-plugin-file/pull/146
> > It might be considered a blocker, because it is a regression that could
> cause loss of data when upgrading apps which relied on the default
> AndroidPersistentFileLocation value.
> >
> > This would be a good one also, as it fixes a significant failure working
> with some kinds of files on Android 5.0:
> https://github.com/apache/cordova-plugin-file/pull/119
> >
> > Jason
> >
> > -Original Message-
> > From: Steven Gill [mailto:stevengil...@gmail.com]
> > Sent: Thursday, November 5, 2015 3:09 PM
> > To: dev@cordova.apache.org
> > Subject: [DISCUSS] Plugins release
> >
> > I plan on starting a plugins release on Monday. It is going to be a big
> one.
> >
> > Please review and close as many PRs as you can before than.
> >
> > If you have PR that is ready and needs someone to look at + merge,
> please share it in this thread and we will try to get to it before the
> release.
> > You could also share it on slack[1] in the #plugins channel.
> >
> > Let me know if we have any blockers.
> >
> > Cheers,
> > -Steve
> >
> >
> > [1]
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fslack.cordova.io=01%7c01%7cjasongin%40microsoft.com%7c6bb15854633242978d6208d2e636167f%7c72f988bf86f141af91ab2d7cd011db47%7c1=QY3Nj3rIJVCSOuncqfAqTul2GKH9L0Z7FQ3oaln4vg4%3d
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[GitHub] cordova-plugin-file-transfer pull request: getCookies bugfix

2015-11-06 Thread jeroenv

Github user jeroenv commented on the pull request:


https://github.com/apache/cordova-plugin-file-transfer/pull/107#issuecomment-154436541
  
@daserge All pictures selected from Dropbox fail when i use File Transfer 
plugin together with Crosswalk Webview.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Integrate binaries (apk / ipa) upload to stores into Cordova CLI

2015-11-06 Thread M Alexandre

Hello Cordova devs,

Because Cordova CLI is a great tool for command line for almost everything
about creating, building hybrids apps, it would be great to include a new
command for uploading the generated binaries to the app stores.

As far as I know, nothing exists at the moment in Cordova. I succeeded
patching gradle scripts for including this feature so I could upload my own
generated APK to my Google Play account from a cordova command. This is
very useful for including Cordova apps into Continuous Integration.

Did you already think about that ? We could :

   1. add an option to the "build" command => "cordova build -- release
   --upload"
   2. or "cordova upload", that needs to build a release version of the
   package

I described the steps and published a "dirty patch" on
https://gist.github.com/mysegfault/9d387cb7f4b08b750bad for Android.

Thanks for your feedback.
--
Maxime

Re: [DISCUSS] Plugins release

2015-11-06 Thread Carlos Santana

Julio,
You are a committer now :-), you can go ahead and merge if it's ready. 

Any manual or auto tests you can add or the one that exist today enough?

What you mean by once it's merge you can check? You mean for any other uses 
cases in addition of the ones you already fixed

- Carlos
@csantanapr

> On Nov 6, 2015, at 5:56 AM, julio cesar sanchez  
> wrote:
> 
> I was writing a mail with the same subject, luckily I saw your message
> before sending.
> 
> I have this PR for statusbar plugin (ios), it fixes at least 2 jira issues
> related to hotspot/call status bar and maybe a lot of more webview
> size/resize issues (will check once it's merged)
> https://github.com/apache/cordova-plugin-statusbar/pull/38
> 
> 
> 
> 2015-11-06 2:07 GMT+01:00 Jason Ginchereau :
> 
>> I think this PR should get in the release:
>> https://github.com/apache/cordova-plugin-file/pull/146
>> It might be considered a blocker, because it is a regression that could
>> cause loss of data when upgrading apps which relied on the default
>> AndroidPersistentFileLocation value.
>> 
>> This would be a good one also, as it fixes a significant failure working
>> with some kinds of files on Android 5.0:
>> https://github.com/apache/cordova-plugin-file/pull/119
>> 
>> Jason
>> 
>> -Original Message-
>> From: Steven Gill [mailto:stevengil...@gmail.com]
>> Sent: Thursday, November 5, 2015 3:09 PM
>> To: dev@cordova.apache.org
>> Subject: [DISCUSS] Plugins release
>> 
>> I plan on starting a plugins release on Monday. It is going to be a big
>> one.
>> 
>> Please review and close as many PRs as you can before than.
>> 
>> If you have PR that is ready and needs someone to look at + merge, please
>> share it in this thread and we will try to get to it before the release.
>> You could also share it on slack[1] in the #plugins channel.
>> 
>> Let me know if we have any blockers.
>> 
>> Cheers,
>> -Steve
>> 
>> 
>> [1]
>> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fslack.cordova.io=01%7c01%7cjasongin%40microsoft.com%7c6bb15854633242978d6208d2e636167f%7c72f988bf86f141af91ab2d7cd011db47%7c1=QY3Nj3rIJVCSOuncqfAqTul2GKH9L0Z7FQ3oaln4vg4%3d
>> 

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: Add support for back button on win10

2015-11-06 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-windows/pull/120


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Plugins release

2015-11-06 Thread Carlos Santana

Yes that makes sense Julio, don't add more CBs to the PR. Let's keep PR
focus one thing at a time.
I will review and add comments.

On Fri, Nov 6, 2015 at 7:25 AM julio cesar sanchez 
wrote:

> Yeah, but I was told that my pull requests still had to pass reviews.
>
> As the issues are related to the native webview size, I can't think any
> test to add that can check that.
>
> The pull request fixes CB-4712 and CB-5439 but it might fix other webview
> size related issues as side effect. I've just tested for CB-4712 and
> CB-5439, but once it's merged I'll check all the pending statusbar issues
> to see if they were fixed too. Or I can check them this weekend before the
> plugin is relesed, but didn't want to add more CBs to the pull request name
> as only the first one was linked.
>
>
> 2015-11-06 12:37 GMT+01:00 Carlos Santana :
>
> > Julio,
> > You are a committer now :-), you can go ahead and merge if it's ready.
> >
> > Any manual or auto tests you can add or the one that exist today enough?
> >
> > What you mean by once it's merge you can check? You mean for any other
> > uses cases in addition of the ones you already fixed
> >
> > - Carlos
> > @csantanapr
> >
> > > On Nov 6, 2015, at 5:56 AM, julio cesar sanchez <
> jcesarmob...@gmail.com>
> > wrote:
> > >
> > > I was writing a mail with the same subject, luckily I saw your message
> > > before sending.
> > >
> > > I have this PR for statusbar plugin (ios), it fixes at least 2 jira
> > issues
> > > related to hotspot/call status bar and maybe a lot of more webview
> > > size/resize issues (will check once it's merged)
> > > https://github.com/apache/cordova-plugin-statusbar/pull/38
> > >
> > >
> > >
> > > 2015-11-06 2:07 GMT+01:00 Jason Ginchereau :
> > >
> > >> I think this PR should get in the release:
> > >> https://github.com/apache/cordova-plugin-file/pull/146
> > >> It might be considered a blocker, because it is a regression that
> could
> > >> cause loss of data when upgrading apps which relied on the default
> > >> AndroidPersistentFileLocation value.
> > >>
> > >> This would be a good one also, as it fixes a significant failure
> working
> > >> with some kinds of files on Android 5.0:
> > >> https://github.com/apache/cordova-plugin-file/pull/119
> > >>
> > >> Jason
> > >>
> > >> -Original Message-
> > >> From: Steven Gill [mailto:stevengil...@gmail.com]
> > >> Sent: Thursday, November 5, 2015 3:09 PM
> > >> To: dev@cordova.apache.org
> > >> Subject: [DISCUSS] Plugins release
> > >>
> > >> I plan on starting a plugins release on Monday. It is going to be a
> big
> > >> one.
> > >>
> > >> Please review and close as many PRs as you can before than.
> > >>
> > >> If you have PR that is ready and needs someone to look at + merge,
> > please
> > >> share it in this thread and we will try to get to it before the
> release.
> > >> You could also share it on slack[1] in the #plugins channel.
> > >>
> > >> Let me know if we have any blockers.
> > >>
> > >> Cheers,
> > >> -Steve
> > >>
> > >>
> > >> [1]
> > >>
> >
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fslack.cordova.io=01%7c01%7cjasongin%40microsoft.com%7c6bb15854633242978d6208d2e636167f%7c72f988bf86f141af91ab2d7cd011db47%7c1=QY3Nj3rIJVCSOuncqfAqTul2GKH9L0Z7FQ3oaln4vg4%3d
> > >>
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>

[GitHub] cordova-plugin-camera pull request: iOS: new resizable cropping re...

2015-11-06 Thread riknoll

Github user riknoll commented on the pull request:


https://github.com/apache/cordova-plugin-camera/pull/131#issuecomment-154495633
  
There are a number of JIRAs that are unhappy with the native iOS crop 
(CB-9930, CB-2648), but I agree that this needs to be discussed on the mailing 
list. I also wonder if this should be left to a third party plugin since this 
pull isn't replacing the native crop and is based off an external library 
already. I totally agree that cropping in general does not seem very useful as 
it currently exists in the camera plugin (especially on Android) and so I 
wonder if we should even be encouraging people to use allowEdit as opposed to 
other options. If we decide that it is an important feature that makes sense to 
be in our plugin, we should look into doing something about Android as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Update to plugin.md regarding Cordova-A...

2015-11-06 Thread dpogue

Github user dpogue commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/409#discussion_r44178971
  
--- Diff: www/docs/en/edge/guide/platforms/android/plugin.md ---
@@ -259,9 +259,100 @@ As of Cordova 2.0, Plugins can no longer directly 
access the
 methods exist on the `Context`, so both `getContext()` and
 `getActivity()` can return the required object.
 
+## Android Permissions
+
+Android permissions until recently have been handled at install-time 
instead
+of runtime.  These permissions are required to be declared on an 
application that uses
+the permissions, and these permissions need to be added to the Android 
Manifest.  This can be
+accomplished by using the config.xml to inject these permissions in the 
AndroidManifest.xml file.
+The example below uses the Contacts permission.
+
+
+
+
+
+## Android Permissions (Cordova-Android 5.0.x and greater)
+
+Android 6.0 "Marshmallow" introduced a new permissions model where
+the user can turn on and off permissions as necessary.  This means that
+applications must handle these permission changes to be future-proof, which
+was the focus of the Cordova-Android 5.0 release.
+
+The permissions that need to be handled at runtime can be found in the 
Android Developer
+documentation here.
+
+As far as a plugin is concerned, the permission can be requested by 
calling the permission method, which signature is as follows:
+
+cordova.reqquestPermission(CordovaPlugin plugin, int requestCode, 
String permission);
--- End diff --

typo: `reqquestPermission` -> `requestPermission`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-camera pull request: feature CB-8777 Add option onl...

2015-11-06 Thread riknoll

Github user riknoll commented on a diff in the pull request:

https://github.com/apache/cordova-plugin-camera/pull/80#discussion_r44180556
  
--- Diff: src/android/CameraLauncher.java ---
@@ -270,18 +279,20 @@ public void getImage(int srcType, int returnType, int 
encodingType) {
 croppedUri = null;
 if (this.mediaType == PICTURE) {
 intent.setType("image/*");
-if (this.allowEdit) {
+if (this.onlyGalleries) {
--- End diff --

Shouldn't `allowEdit` be kept separate from this feature? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [DISCUSS] Cordova-Windows Release

2015-11-06 Thread Sergey Grebnov (Akvelon)

Hi guys,

I've started the Vote thread, but I see that release tag has not been 
automatically mirrored from asf to github. Is it a known issue - should this be 
done manually?

4.2.0 tag exists  here [1]  but I don't see it on github[2]

[1]https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git;a=commit;h=b56900f1d227f33633ded3ab0aa3f56a10ae7c74
 

[2] https://github.com/apache/cordova-windows/tags 

Thx!
-Sergey

-Original Message-
From: Sergey Grebnov (Akvelon) 
Sent: Thursday, November 5, 2015 1:57 PM
To: dev@cordova.apache.org
Subject: RE: [DISCUSS] Cordova-Windows Release

I've tested mobilespec build artefacts (uap, win81) using Windows App Cert Kit 
and all tests pass.

I see that we've just merged back button fix for WP8.1 so I plan to test and 
merge related fix[1] for Windows10  to have full back button support and 
proceed w/ release.

[1] https://github.com/apache/cordova-windows/pull/120

-Sergey
-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com]
Sent: Thursday, November 5, 2015 1:15 AM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Cordova-Windows Release

+1 and do minor release since it include more than bug fixes.

On Tue, Nov 3, 2015 at 12:10 PM Jesse  wrote:

> +1
> Sounds good. I want to test some of the recent line-ending 
> gitattribute changes with AppStore submission, so a release would be the 
> perfect test.
>
> > On Nov 2, 2015, at 11:18 PM, Sergey Grebnov (Akvelon) <
> v-seg...@microsoft.com> wrote:
> >
> > If we agree to do a release:
> >
> > Most of the changes in master are bugfixes, but there is new Visual
> Studio 14 template (version update), Cumulative build and hosted 
> environments support so I propose to do minor release (4.2.0) instead 
> of patch (4.1.1). Thoughts?
> >
> > Thx!
> > Sergey
> > -Original Message-
> > From: Sergey Grebnov (Akvelon)
> > Sent: Tuesday, November 3, 2015 10:10 AM
> > To: dev@cordova.apache.org
> > Subject: [DISCUSS] Cordova-Windows Release
> >
> > Hi guys, last Windows release was in August and there are important
> changes landed to repo master from that time including:
> >  * Better Windows 10 in hosted environment support
> >  * Create/prepare fixes for non-Windows env (Linux/OSX)
> >  * Cumulative build support (windows10 and windows 8.1)
> >  * Fixes for general build failures
> >
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgit
> > hub.com%2fapache%2fcordova-windows%2fcompare%2f4.1.x...master=0
> > 1%7c01%7cv-segreb%40microsoft.com%7c6d60e65c973f45758f2808d2e56574d8
> > %7c72f988bf86f141af91ab2d7cd011db47%7c1=q5Xg3gy10YuO6pqgrhL%2b
> > kstxzou35oWmuctQd%2bATgNY%3d
> >
> > Does anyone have any reason to delay a cordova-windows platform release?
> > Any outstanding patches to land?
> >
> > If not, I will start the release tomorrow.
> >
> > Thx!
> > Sergey
> >
> >
> > 
> > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

RE: [DISCUSS] Cordova-Windows Release

2015-11-06 Thread Sergey Grebnov (Akvelon)

The Vote thread also starts with "Please review and vote on this 5.0.0 Android 
Release" which should be actually " Please review and vote on this 4.2.0 
Windows Release ".

Should I restart  Vote due to this mistake?

Thx!
Sergey
-Original Message-
From: Sergey Grebnov (Akvelon) [mailto:v-seg...@microsoft.com] 
Sent: Friday, November 6, 2015 11:12 PM
To: dev@cordova.apache.org
Subject: RE: [DISCUSS] Cordova-Windows Release

Hi guys,

I've started the Vote thread, but I see that release tag has not been 
automatically mirrored from asf to github. Is it a known issue - should this be 
done manually?

4.2.0 tag exists  here [1]  but I don't see it on github[2]

[1]https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgit-wip-us.apache.org%2frepos%2fasf%3fp%3dcordova-windows.git%3ba%3dcommit%3bh%3db56900f1d227f33633ded3ab0aa3f56a10ae7c74=01%7c01%7cv-segreb%40microsoft.com%7cba5291f3705243fa61cd08d2e6e68cc4%7c72f988bf86f141af91ab2d7cd011db47%7c1=JOLj3gPwJI5avqMkOleHP%2bB%2bAU0MIhg7j33mXGFdfr0%3d
 

[2] 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fapache%2fcordova-windows%2ftags=01%7c01%7cv-segreb%40microsoft.com%7cba5291f3705243fa61cd08d2e6e68cc4%7c72f988bf86f141af91ab2d7cd011db47%7c1=We46tqvJ5ihE01jGrecRdo%2bGiwaZwDaJnPXddimFZBc%3d
 

Thx!
-Sergey

-Original Message-
From: Sergey Grebnov (Akvelon)
Sent: Thursday, November 5, 2015 1:57 PM
To: dev@cordova.apache.org
Subject: RE: [DISCUSS] Cordova-Windows Release

I've tested mobilespec build artefacts (uap, win81) using Windows App Cert Kit 
and all tests pass.

I see that we've just merged back button fix for WP8.1 so I plan to test and 
merge related fix[1] for Windows10  to have full back button support and 
proceed w/ release.

[1] 
https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fapache%2fcordova-windows%2fpull%2f120=01%7c01%7cv-segreb%40microsoft.com%7cba5291f3705243fa61cd08d2e6e68cc4%7c72f988bf86f141af91ab2d7cd011db47%7c1=8hkECiqIg06EblDoJ5Los0JU4R9JhuXeqFA6xJG2aZg%3d

-Sergey
-Original Message-
From: Carlos Santana [mailto:csantan...@gmail.com]
Sent: Thursday, November 5, 2015 1:15 AM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Cordova-Windows Release

+1 and do minor release since it include more than bug fixes.

On Tue, Nov 3, 2015 at 12:10 PM Jesse  wrote:

> +1
> Sounds good. I want to test some of the recent line-ending 
> gitattribute changes with AppStore submission, so a release would be the 
> perfect test.
>
> > On Nov 2, 2015, at 11:18 PM, Sergey Grebnov (Akvelon) <
> v-seg...@microsoft.com> wrote:
> >
> > If we agree to do a release:
> >
> > Most of the changes in master are bugfixes, but there is new Visual
> Studio 14 template (version update), Cumulative build and hosted 
> environments support so I propose to do minor release (4.2.0) instead 
> of patch (4.1.1). Thoughts?
> >
> > Thx!
> > Sergey
> > -Original Message-
> > From: Sergey Grebnov (Akvelon)
> > Sent: Tuesday, November 3, 2015 10:10 AM
> > To: dev@cordova.apache.org
> > Subject: [DISCUSS] Cordova-Windows Release
> >
> > Hi guys, last Windows release was in August and there are important
> changes landed to repo master from that time including:
> >  * Better Windows 10 in hosted environment support
> >  * Create/prepare fixes for non-Windows env (Linux/OSX)
> >  * Cumulative build support (windows10 and windows 8.1)
> >  * Fixes for general build failures
> >
> > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgit
> > hub.com%2fapache%2fcordova-windows%2fcompare%2f4.1.x...master=0
> > 1%7c01%7cv-segreb%40microsoft.com%7c6d60e65c973f45758f2808d2e56574d8
> > %7c72f988bf86f141af91ab2d7cd011db47%7c1=q5Xg3gy10YuO6pqgrhL%2b
> > kstxzou35oWmuctQd%2bATgNY%3d
> >
> > Does anyone have any reason to delay a cordova-windows platform release?
> > Any outstanding patches to land?
> >
> > If not, I will start the release tomorrow.
> >
> > Thx!
> > Sergey
> >
> >
> > 
> > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request: Update to plugin.md regarding Cordova-A...

2015-11-06 Thread dpogue

Github user dpogue commented on a diff in the pull request:

https://github.com/apache/cordova-docs/pull/409#discussion_r44179259
  
--- Diff: www/docs/en/edge/guide/platforms/android/plugin.md ---
@@ -259,9 +259,100 @@ As of Cordova 2.0, Plugins can no longer directly 
access the
 methods exist on the `Context`, so both `getContext()` and
 `getActivity()` can return the required object.
 
+## Android Permissions
+
+Android permissions until recently have been handled at install-time 
instead
+of runtime.  These permissions are required to be declared on an 
application that uses
+the permissions, and these permissions need to be added to the Android 
Manifest.  This can be
+accomplished by using the config.xml to inject these permissions in the 
AndroidManifest.xml file.
+The example below uses the Contacts permission.
+
+
+
+
+
+## Android Permissions (Cordova-Android 5.0.x and greater)
+
+Android 6.0 "Marshmallow" introduced a new permissions model where
+the user can turn on and off permissions as necessary.  This means that
+applications must handle these permission changes to be future-proof, which
+was the focus of the Cordova-Android 5.0 release.
+
+The permissions that need to be handled at runtime can be found in the 
Android Developer
+documentation here.
+
+As far as a plugin is concerned, the permission can be requested by 
calling the permission method, which signature is as follows:
+
+cordova.reqquestPermission(CordovaPlugin plugin, int requestCode, 
String permission);
+
+To cut down on verbosity, it's standard practice to assign this to a local 
static variable:
+
+public static final String READ = Manifest.permission.READ_CONTACTS;
+
+
+Then, in the exec method, the permission should be checked:
+
+if(cordova.hasPermission(READ)) {
+search(executeArgs);
+}
+else
+{
+getReadPermission(SEARCH_REQ_CODE);
--- End diff --

Not clear here if `SEARCH_REQ_CODE` is an Android constant or something 
defined by the plugin author. From the code further down, it seems like it's 
author-defined in the plugin?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Native vs. File URIs

2015-11-06 Thread Richard Knoll

Hey all,

I was wondering if anybody could clarify for me what the difference between 
FILE_URI and NATIVE_URI is in the camera plugin. Do we have a clear definition 
of either? I assumed that FILE_URI would refer to an actual path on the device 
(i.e. a URI using the "file" scheme) but the docs for the camera plugin 
actually use a content URI as an example. This seems counterintuitive, 
especially since the "content" scheme is specific to Android. As it stands, 
FILE_URI and NATIVE_URI always return the same thing in Android and can either 
give a content URI or a file URI depending on the other camera options that are 
passed. I think we need to be clear when returning URIs so that app developers 
can tell what they have to do with it before they can use it in their app. 
Also, it's worth noting that the FILE_URI and NATIVE_URI question is 
complicated by the fact that on Android it is possible to pick photos using 
apps like Google Photos which can choose files that have no local path. I also 
would love some clarification as to where "cdvfile" fits into all of this and 
the type of support it has across the plugins. This is in regards to CB-9548, 
for those interested.

Thanks,
Richard

Re: [DISCUSS] Plugins release

2015-11-06 Thread Simon MacDonald

I agree with Jason,
https://github.com/apache/cordova-plugin-file/pull/146 should be
merged.

Simon Mac Donald
http://hi.im/simonmacdonald

On Thu, Nov 5, 2015 at 8:07 PM, Jason Ginchereau  wrote:
> I think this PR should get in the release: 
> https://github.com/apache/cordova-plugin-file/pull/146
> It might be considered a blocker, because it is a regression that could cause 
> loss of data when upgrading apps which relied on the default 
> AndroidPersistentFileLocation value.
>
> This would be a good one also, as it fixes a significant failure working with 
> some kinds of files on Android 5.0: 
> https://github.com/apache/cordova-plugin-file/pull/119
>
> Jason
>
> -Original Message-
> From: Steven Gill [mailto:stevengil...@gmail.com]
> Sent: Thursday, November 5, 2015 3:09 PM
> To: dev@cordova.apache.org
> Subject: [DISCUSS] Plugins release
>
> I plan on starting a plugins release on Monday. It is going to be a big one.
>
> Please review and close as many PRs as you can before than.
>
> If you have PR that is ready and needs someone to look at + merge, please 
> share it in this thread and we will try to get to it before the release.
> You could also share it on slack[1] in the #plugins channel.
>
> Let me know if we have any blockers.
>
> Cheers,
> -Steve
>
>
> [1] 
> https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2fslack.cordova.io=01%7c01%7cjasongin%40microsoft.com%7c6bb15854633242978d6208d2e636167f%7c72f988bf86f141af91ab2d7cd011db47%7c1=QY3Nj3rIJVCSOuncqfAqTul2GKH9L0Z7FQ3oaln4vg4%3d

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-windows pull request: Add support for back button on win10

2015-11-06 Thread sgrebnov

Github user sgrebnov commented on the pull request:

https://github.com/apache/cordova-windows/pull/120#issuecomment-154417511
  
PS. changing `appViewBackButtonVisibility ` on Mobile 10 does not take any 
effect, standard phone back button works as expected (correctly handled using 
`backrequested` event)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [DISCUSS] Cordova-Windows Release

2015-11-06 Thread Steven Gill

In terms of the tag and mirroring, here is the response I got from infra
last time about android's tag and if it gets automatically updated.

"It is automated, however if you just updated a tag, the mirroring daemon
will not sync as there is no substance to the change (same got for just
creating a new branch with no changes). "
You can just file an issue to infra and they can manual update it.

I wouldn't worry about the vote android 5.0.0 part, just respond to the
vote thread with the fixed line.


On Fri, Nov 6, 2015 at 12:17 PM, Sergey Grebnov (Akvelon) <
v-seg...@microsoft.com> wrote:

> The Vote thread also starts with "Please review and vote on this 5.0.0
> Android Release" which should be actually " Please review and vote on this
> 4.2.0 Windows Release ".
>
> Should I restart  Vote due to this mistake?
>
> Thx!
> Sergey
> -Original Message-
> From: Sergey Grebnov (Akvelon) [mailto:v-seg...@microsoft.com]
> Sent: Friday, November 6, 2015 11:12 PM
> To: dev@cordova.apache.org
> Subject: RE: [DISCUSS] Cordova-Windows Release
>
> Hi guys,
>
> I've started the Vote thread, but I see that release tag has not been
> automatically mirrored from asf to github. Is it a known issue - should
> this be done manually?
>
> 4.2.0 tag exists  here [1]  but I don't see it on github[2]
>
> [1]
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgit-wip-us.apache.org%2frepos%2fasf%3fp%3dcordova-windows.git%3ba%3dcommit%3bh%3db56900f1d227f33633ded3ab0aa3f56a10ae7c74=01%7c01%7cv-segreb%40microsoft.com%7cba5291f3705243fa61cd08d2e6e68cc4%7c72f988bf86f141af91ab2d7cd011db47%7c1=JOLj3gPwJI5avqMkOleHP%2bB%2bAU0MIhg7j33mXGFdfr0%3d
>
> [2]
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fapache%2fcordova-windows%2ftags=01%7c01%7cv-segreb%40microsoft.com%7cba5291f3705243fa61cd08d2e6e68cc4%7c72f988bf86f141af91ab2d7cd011db47%7c1=We46tqvJ5ihE01jGrecRdo%2bGiwaZwDaJnPXddimFZBc%3d
>
> Thx!
> -Sergey
>
> -Original Message-
> From: Sergey Grebnov (Akvelon)
> Sent: Thursday, November 5, 2015 1:57 PM
> To: dev@cordova.apache.org
> Subject: RE: [DISCUSS] Cordova-Windows Release
>
> I've tested mobilespec build artefacts (uap, win81) using Windows App Cert
> Kit and all tests pass.
>
> I see that we've just merged back button fix for WP8.1 so I plan to test
> and merge related fix[1] for Windows10  to have full back button support
> and proceed w/ release.
>
> [1]
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fapache%2fcordova-windows%2fpull%2f120=01%7c01%7cv-segreb%40microsoft.com%7cba5291f3705243fa61cd08d2e6e68cc4%7c72f988bf86f141af91ab2d7cd011db47%7c1=8hkECiqIg06EblDoJ5Los0JU4R9JhuXeqFA6xJG2aZg%3d
>
> -Sergey
> -Original Message-
> From: Carlos Santana [mailto:csantan...@gmail.com]
> Sent: Thursday, November 5, 2015 1:15 AM
> To: dev@cordova.apache.org
> Subject: Re: [DISCUSS] Cordova-Windows Release
>
> +1 and do minor release since it include more than bug fixes.
>
> On Tue, Nov 3, 2015 at 12:10 PM Jesse  wrote:
>
> > +1
> > Sounds good. I want to test some of the recent line-ending
> > gitattribute changes with AppStore submission, so a release would be the
> perfect test.
> >
> > > On Nov 2, 2015, at 11:18 PM, Sergey Grebnov (Akvelon) <
> > v-seg...@microsoft.com> wrote:
> > >
> > > If we agree to do a release:
> > >
> > > Most of the changes in master are bugfixes, but there is new Visual
> > Studio 14 template (version update), Cumulative build and hosted
> > environments support so I propose to do minor release (4.2.0) instead
> > of patch (4.1.1). Thoughts?
> > >
> > > Thx!
> > > Sergey
> > > -Original Message-
> > > From: Sergey Grebnov (Akvelon)
> > > Sent: Tuesday, November 3, 2015 10:10 AM
> > > To: dev@cordova.apache.org
> > > Subject: [DISCUSS] Cordova-Windows Release
> > >
> > > Hi guys, last Windows release was in August and there are important
> > changes landed to repo master from that time including:
> > >  * Better Windows 10 in hosted environment support
> > >  * Create/prepare fixes for non-Windows env (Linux/OSX)
> > >  * Cumulative build support (windows10 and windows 8.1)
> > >  * Fixes for general build failures
> > >
> > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgit
> > > hub.com%2fapache%2fcordova-windows%2fcompare%2f4.1.x...master=0
> > > 1%7c01%7cv-segreb%40microsoft.com%7c6d60e65c973f45758f2808d2e56574d8
> > > %7c72f988bf86f141af91ab2d7cd011db47%7c1=q5Xg3gy10YuO6pqgrhL%2b
> > > kstxzou35oWmuctQd%2bATgNY%3d
> > >
> > > Does anyone have any reason to delay a cordova-windows platform
> release?
> > > Any outstanding patches to land?
> > >
> > > If not, I will start the release tomorrow.
> > >
> > > Thx!
> > > Sergey
> > >
> > >
> > > 
> > > - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > > For additional commands, e-mail: dev-h...@cordova.apache.org
> > >
> >
> >

Re: [DISCUSS] Cordova-Windows Release

2015-11-06 Thread Jesse

or push an empty commit
--allow-empty


@purplecabbage
risingj.com

On Fri, Nov 6, 2015 at 1:37 PM, Steven Gill  wrote:

> In terms of the tag and mirroring, here is the response I got from infra
> last time about android's tag and if it gets automatically updated.
>
> "It is automated, however if you just updated a tag, the mirroring daemon
> will not sync as there is no substance to the change (same got for just
> creating a new branch with no changes). "
> You can just file an issue to infra and they can manual update it.
>
> I wouldn't worry about the vote android 5.0.0 part, just respond to the
> vote thread with the fixed line.
>
>
> On Fri, Nov 6, 2015 at 12:17 PM, Sergey Grebnov (Akvelon) <
> v-seg...@microsoft.com> wrote:
>
> > The Vote thread also starts with "Please review and vote on this 5.0.0
> > Android Release" which should be actually " Please review and vote on
> this
> > 4.2.0 Windows Release ".
> >
> > Should I restart  Vote due to this mistake?
> >
> > Thx!
> > Sergey
> > -Original Message-
> > From: Sergey Grebnov (Akvelon) [mailto:v-seg...@microsoft.com]
> > Sent: Friday, November 6, 2015 11:12 PM
> > To: dev@cordova.apache.org
> > Subject: RE: [DISCUSS] Cordova-Windows Release
> >
> > Hi guys,
> >
> > I've started the Vote thread, but I see that release tag has not been
> > automatically mirrored from asf to github. Is it a known issue - should
> > this be done manually?
> >
> > 4.2.0 tag exists  here [1]  but I don't see it on github[2]
> >
> > [1]
> >
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgit-wip-us.apache.org%2frepos%2fasf%3fp%3dcordova-windows.git%3ba%3dcommit%3bh%3db56900f1d227f33633ded3ab0aa3f56a10ae7c74=01%7c01%7cv-segreb%40microsoft.com%7cba5291f3705243fa61cd08d2e6e68cc4%7c72f988bf86f141af91ab2d7cd011db47%7c1=JOLj3gPwJI5avqMkOleHP%2bB%2bAU0MIhg7j33mXGFdfr0%3d
> >
> > [2]
> >
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fapache%2fcordova-windows%2ftags=01%7c01%7cv-segreb%40microsoft.com%7cba5291f3705243fa61cd08d2e6e68cc4%7c72f988bf86f141af91ab2d7cd011db47%7c1=We46tqvJ5ihE01jGrecRdo%2bGiwaZwDaJnPXddimFZBc%3d
> >
> > Thx!
> > -Sergey
> >
> > -Original Message-
> > From: Sergey Grebnov (Akvelon)
> > Sent: Thursday, November 5, 2015 1:57 PM
> > To: dev@cordova.apache.org
> > Subject: RE: [DISCUSS] Cordova-Windows Release
> >
> > I've tested mobilespec build artefacts (uap, win81) using Windows App
> Cert
> > Kit and all tests pass.
> >
> > I see that we've just merged back button fix for WP8.1 so I plan to test
> > and merge related fix[1] for Windows10  to have full back button support
> > and proceed w/ release.
> >
> > [1]
> >
> https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgithub.com%2fapache%2fcordova-windows%2fpull%2f120=01%7c01%7cv-segreb%40microsoft.com%7cba5291f3705243fa61cd08d2e6e68cc4%7c72f988bf86f141af91ab2d7cd011db47%7c1=8hkECiqIg06EblDoJ5Los0JU4R9JhuXeqFA6xJG2aZg%3d
> >
> > -Sergey
> > -Original Message-
> > From: Carlos Santana [mailto:csantan...@gmail.com]
> > Sent: Thursday, November 5, 2015 1:15 AM
> > To: dev@cordova.apache.org
> > Subject: Re: [DISCUSS] Cordova-Windows Release
> >
> > +1 and do minor release since it include more than bug fixes.
> >
> > On Tue, Nov 3, 2015 at 12:10 PM Jesse  wrote:
> >
> > > +1
> > > Sounds good. I want to test some of the recent line-ending
> > > gitattribute changes with AppStore submission, so a release would be
> the
> > perfect test.
> > >
> > > > On Nov 2, 2015, at 11:18 PM, Sergey Grebnov (Akvelon) <
> > > v-seg...@microsoft.com> wrote:
> > > >
> > > > If we agree to do a release:
> > > >
> > > > Most of the changes in master are bugfixes, but there is new Visual
> > > Studio 14 template (version update), Cumulative build and hosted
> > > environments support so I propose to do minor release (4.2.0) instead
> > > of patch (4.1.1). Thoughts?
> > > >
> > > > Thx!
> > > > Sergey
> > > > -Original Message-
> > > > From: Sergey Grebnov (Akvelon)
> > > > Sent: Tuesday, November 3, 2015 10:10 AM
> > > > To: dev@cordova.apache.org
> > > > Subject: [DISCUSS] Cordova-Windows Release
> > > >
> > > > Hi guys, last Windows release was in August and there are important
> > > changes landed to repo master from that time including:
> > > >  * Better Windows 10 in hosted environment support
> > > >  * Create/prepare fixes for non-Windows env (Linux/OSX)
> > > >  * Cumulative build support (windows10 and windows 8.1)
> > > >  * Fixes for general build failures
> > > >
> > > > https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgit
> > > > hub.com%2fapache%2fcordova-windows%2fcompare%2f4.1.x...master=0
> > > > 1%7c01%7cv-segreb%40microsoft.com%7c6d60e65c973f45758f2808d2e56574d8
> > > > %7c72f988bf86f141af91ab2d7cd011db47%7c1=q5Xg3gy10YuO6pqgrhL%2b
> > > > kstxzou35oWmuctQd%2bATgNY%3d
> > > >
> > > > Does anyone have any reason to delay a cordova-windows platform
>

Re: Integrate binaries (apk / ipa) upload to stores into Cordova CLI

2015-11-06 Thread Parashuram N

I think this is a great idea. I understand that we already have a package 
command and this could be a logical extension. However, will this be a 
functionality that can be supported on multiple stores ? I am not sure if this 
is legal on an iOS store. 




On 11/6/15, 2:41 AM, "M Alexandre"  wrote:

>Hello Cordova devs,
>
>Because Cordova CLI is a great tool for command line for almost everything
>about creating, building hybrids apps, it would be great to include a new
>command for uploading the generated binaries to the app stores.
>
>As far as I know, nothing exists at the moment in Cordova. I succeeded
>patching gradle scripts for including this feature so I could upload my own
>generated APK to my Google Play account from a cordova command. This is
>very useful for including Cordova apps into Continuous Integration.
>
>Did you already think about that ? We could :
>
>   1. add an option to the "build" command => "cordova build -- release
>   --upload"
>   2. or "cordova upload", that needs to build a release version of the
>   package
>
>I described the steps and published a "dirty patch" on
>https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgist.github.com%2fmysegfault%2f9d387cb7f4b08b750bad=01%7c01%7cpanarasi%40microsoft.com%7c347fcb14e8ae46e740b008d2e6ca9f74%7c72f988bf86f141af91ab2d7cd011db47%7c1=8B8YejUQ6F8obdheWvLmrPN0CCspx4zJjV%2fxnpSnjdI%3d
> for Android.
>
>Thanks for your feedback.
>--
>Maxime

49 matches

Mail list logo