Nightly build #330 for cordova has succeeded!

[Apache Jenkins Server]

Nightly build #330 for cordova has succeeded!
The latest nightly has been published and you can try it out with 'npm i -g 
cordova@nightly'

For details check build console at 
https://builds.apache.org/job/cordova-nightly/330/consoleFull

-
Jenkins for Apache Cordova

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [VOTE] 6.2.3 Android release

[Shazron]

I vote +1:
* Ran coho audit-license-headers over the relevant repos
* Ran coho check-license to ensure all repo sources have Apache-compatible
licenses
* verified signatures and hashes on tarballs
* on Android SDK Tools 26.0.1 and 26.0.2 I ran (all passed):
  - bin/create
  - cordova/build
  - cordova/run --emulator
  - cordova/run --device to a real device
* on Android SDK Tools 26.0.1 and 26.0.2 I ran (all passed) with
cordova-cli@6.5.0:
  - cordova build
  - cordova run --emulator
  - cordova run --device to a real device

On Thu, May 4, 2017 at 11:47 AM, Joe Bowser  wrote:

> I vote +1
>
> * Ran mobile spec testing the new emulator-handling code, via `cordova
> run --emulator`, w/ latest plugin code.
> * Ensured can use bin/create to create project
> * Ran empty project created by bin/create against emulator
> * Created a project with the CLI and ran it on the emulator
>
> On Tue, May 2, 2017 at 5:02 PM, Filip Maj  wrote:
>
> > Please review and vote on this 6.2.3 Android Release by replying to
> > this email (and keep discussion on the DISCUSS thread - am
> > piggy-backing on the 6.2.2 release DISCUSS thread)
> >
> > Release issue: https://issues.apache.org/jira/browse/CB-12746
> >
> > The archive has been published to
> > dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-12746
> >
> > The package was published from its corresponding git tag:
> > cordova-android: 6.2.3 (c0df73c3)
> >
> > Note that you can test it out via:
> >
> > cordova platform add https://github.com/apache/cordova-android#6.2.3
> >
> > Upon a successful vote I will upload the archive to dist/, publish it
> > to npm, and post the blog post.
> >
> > I have also sent a PR for the blog post related to this release -
> > reviews requested, please take a look:
> > https://github.com/apache/cordova-docs/pull/702
> >
> > Voting guidelines:
> > https://github.com/apache/cordova-coho/blob/master/docs/rele
> ase-voting.md
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran mobile spec on a real device, w/ latest plugin code.
> > * Ran mobile spec testing the new emulator-handling code, via `cordova
> > run --emulator`, w/ latest plugin code.
> > * Ensured can create a new project using cordova-cli, and run on both
> > device and emulator
> > * Ensured can use the bin/create script.
> > * Double-checked reported versions via `cordova/version` script.
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>

[GitHub] cordova-plugin-splashscreen issue #107: Browser platform brought closer to i...

[ranma42]

Github user ranma42 commented on the issue:

https://github.com/apache/cordova-plugin-splashscreen/pull/107
  
Is this PR ready for merge? Are there still issues that need to be fixed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15/commits/c006d6673d8c2ab39536a55055062df635c4afdd)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-wkwebview-engine-pr/15/)

 0 tests run, 0 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine issue #15: Ionic changes to WKWebView (For C...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-wkwebview-engine/pull/15/commits/09a47d8d4e8db68a2211e93337debc7e6fd53031)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-wkwebview-engine-pr/14/)

 0 tests run, 0 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [VOTE] 6.2.3 Android release

[Joe Bowser]

I vote +1

* Ran mobile spec testing the new emulator-handling code, via `cordova
run --emulator`, w/ latest plugin code.
* Ensured can use bin/create to create project
* Ran empty project created by bin/create against emulator
* Created a project with the CLI and ran it on the emulator

On Tue, May 2, 2017 at 5:02 PM, Filip Maj  wrote:

> Please review and vote on this 6.2.3 Android Release by replying to
> this email (and keep discussion on the DISCUSS thread - am
> piggy-backing on the 6.2.2 release DISCUSS thread)
>
> Release issue: https://issues.apache.org/jira/browse/CB-12746
>
> The archive has been published to
> dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-12746
>
> The package was published from its corresponding git tag:
> cordova-android: 6.2.3 (c0df73c3)
>
> Note that you can test it out via:
>
> cordova platform add https://github.com/apache/cordova-android#6.2.3
>
> Upon a successful vote I will upload the archive to dist/, publish it
> to npm, and post the blog post.
>
> I have also sent a PR for the blog post related to this release -
> reviews requested, please take a look:
> https://github.com/apache/cordova-docs/pull/702
>
> Voting guidelines:
> https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md
>
> Voting will go on for a minimum of 48 hours.
>
> I vote +1:
> * Ran mobile spec on a real device, w/ latest plugin code.
> * Ran mobile spec testing the new emulator-handling code, via `cordova
> run --emulator`, w/ latest plugin code.
> * Ensured can create a new project using cordova-cli, and run on both
> device and emulator
> * Ensured can use the bin/create script.
> * Double-checked reported versions via `cordova/version` script.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> For additional commands, e-mail: dev-h...@cordova.apache.org
>
>

[DISCUSS] cordova 7.0.1 release

[Steven Gill]

No time to celebrate here :P

Need to do a cordova-create@1.1.1 release so it treats our hello-world-app
like a normal template. This way, it will copy the template_src directory
when creating a new app. Cordova-lib and cli will need updates just to
update cordova-create.

This means any new project created with the default cordova-app-hello-world
will start with a package.json. Right now, users have to type `cordova
prepare` to generate the package.json.

Issue: https://issues.apache.org/jira/browse/CB-12765
PR: https://github.com/apache/cordova-create/pull/7

Re: [ANNOUNCE] cordova@7 tools released!

[Steven Gill]

Docs got updated to 7.x too!
http://cordova.apache.org/docs/en/latest/index.html

On Thu, May 4, 2017 at 8:33 PM, Steven Gill  wrote:

> Tweet: https://twitter.com/apachecordova/status/860200505267687424
> Blog: http://cordova.apache.org/news/2017/05/04/cordova-7.html
>

[ANNOUNCE] cordova@7 tools released!

[Steven Gill]

Tweet: https://twitter.com/apachecordova/status/860200505267687424
Blog: http://cordova.apache.org/news/2017/05/04/cordova-7.html

[GitHub] cordova-coho pull request #148: CB-12758 - Add cordova-fetch, cordova-common...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-coho/pull/148


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib issue #552: CB-12757 : Was previously saving wrong spec in confi...

[codecov-io]

Github user codecov-io commented on the issue:

https://github.com/apache/cordova-lib/pull/552
  
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/552?src=pr=h1) 
Report
> Merging 
[#552](https://codecov.io/gh/apache/cordova-lib/pull/552?src=pr=desc) into 
[master](https://codecov.io/gh/apache/cordova-lib/commit/c51b8f860a83221db970bd5a27b7fde447cee976?src=pr=desc)
 will **decrease** coverage by `0.02%`.
> The diff coverage is `53.33%`.

[![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-lib/pull/552/graphs/tree.svg?token=KwBjKMXLqA=pr=150=650)](https://codecov.io/gh/apache/cordova-lib/pull/552?src=pr=tree)

```diff
@@Coverage Diff @@
##   master #552  +/-   ##
==
- Coverage79.5%   79.48%   -0.03% 
==
  Files  57   57  
  Lines3942 3943   +1 
  Branches  827  828   +1 
==
  Hits 3134 3134  
- Misses808  809   +1
```


| [Impacted 
Files](https://codecov.io/gh/apache/cordova-lib/pull/552?src=pr=tree) | 
Coverage Δ | |
|---|---|---|
| 
[cordova-lib/src/cordova/plugin.js](https://codecov.io/gh/apache/cordova-lib/pull/552?src=pr=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGx1Z2luLmpz)
 | `85.26% <53.33%> (-0.2%)` | :arrow_down: |

--

[Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-lib/pull/552?src=pr=continue).
> **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute  (impact)`, `ø = not affected`, `? = missing 
data`
> Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-lib/pull/552?src=pr=footer). 
Last update 
[c51b8f8...7b26aef](https://codecov.io/gh/apache/cordova-lib/pull/552?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #552: CB-12757 : Was previously saving wrong spec i...

[audreyso]

GitHub user audreyso opened a pull request:

https://github.com/apache/cordova-lib/pull/552

CB-12757 : Was previously saving wrong spec in config.xml for git plugins.




### Platforms affected


### What does this PR do?

Was previously saving wrong spec in config.xml for git plugins.

### What testing has been done on this change?


### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [X] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/audreyso/cordova-lib CB-12757

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-lib/pull/552.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #552


commit 349693249febd62a0828aaf27c07d98c22c45a6f
Author: Audrey So 
Date:   2017-05-04T17:08:47Z

CB-12757 : if there's a plugin  dependency in pkgJson, use that one for 
config




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-wkwebview-engine issue #30: Allow XHR to file:// and allow lo...

[TheMattRay]

Github user TheMattRay commented on the issue:

https://github.com/apache/cordova-plugin-wkwebview-engine/pull/30
  
Created plugin from your code samples and some testing:

[](https://github.com/TheMattRay/cordova-plugin-wkwebviewxhrfix)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-docs pull request #699: cordova7_post : cordova7 release post

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-docs/pull/699


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file-transfer issue #178: CB-12745: Adding support for non ba...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-file-transfer/pull/178
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-file-transfer/pull/178/commits/6d3379e935a37e6b4c77b000e6c270388cbe22ce)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/77/)

 318 tests run, 15 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [VOTE] Tools Release (cordova@7)

[Steven Gill]

The vote has now closed. The results are:

Positive Binding Votes: (# of PMC members that +1'ed)

Steve Gill
Shazron Abdullah
Alexander Sorokin

The vote has passed.


On Tue, May 2, 2017 at 7:09 PM, Shazron  wrote:

> I vote +1:
> * Ran coho audit-license-headers over the relevant repos
> * Ran coho check-license to ensure all repo sources have Apache-compatible
> licenses
> * verified signatures and hashes on tarballs
>
>
>
> On Tue, May 2, 2017 at 5:49 AM,  wrote:
>
> > I vote +1.
> >
> > * Verified tags
> > * Ability to install/uninstall Cordova
> > * Ability to update Cordova
> > * Ability to create blank app for Windows, Android, iOS
> > * Ability to build/run apps
> > * Verified versions
> > * Verified line breaks
> > * Verified 'cordova serve'
> > * Verified that browserified app builds and runs correctly
> > * Ensured --nobuild option works
> > * Ensured compatibility with Visual Studio
> >
> > Thanks,
> > Alexander Sorokin
> >
> > -Original Message-
> > From: Steven Gill [mailto:stevengil...@gmail.com]
> > Sent: Tuesday, May 2, 2017 3:16 AM
> > To: dev@cordova.apache.org
> > Subject: [VOTE] Tools Release (cordova@7)
> >
> > Please review and vote on this Tools Release by replying to this email
> > (and keep discussion on the DISCUSS thread)
> >
> > Release issue: https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FCB-
> > 12747=02%7C01%7Cv-alsoro%40microsoft.com%
> > 7C848dbf8d68ce457a301608d490f082f4%7C72f988bf86f141af91ab2d7cd011
> > db47%7C1%7C0%7C636292810111584665=mlWQ23O3nZ3l6MtKHGZO%
> > 2FaewiC4ossckSMm70ylbNTU%3D=0
> >
> > Both tools have been published to
> > dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-12747/
> >
> > The packages were published from their corresponding git tags:
> >
> > cordova-create: 1.1.0 (af9ad26ec8)
> > cordova-lib: 7.0.0 (46defeb86e)
> > cordova-plugman: 1.5.0 (bbc6b9b3ab)
> > cordova-cli: 7.0.0 (3963506ef0)
> > cordova-lib: fetch-1.1.0 (46defeb86e)
> > cordova-lib: common-2.0.3 (46defeb86e)
> > cordova-app-hello-world: 3.12.0 (a82a0c5523)
> >
> > Upon a successful vote I will upload the archives to dist/, publish them
> > to npm, and post the corresponding blog post.
> >
> > Voting guidelines:
> > https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%
> > 2Frelease-voting.md=02%7C01%7Cv-alsoro%40microsoft.com%
> > 7C848dbf8d68ce457a301608d490f082f4%7C72f988bf86f141af91ab2d7cd011
> > db47%7C1%7C0%7C636292810111594673=4ZDi55SPHQ4EoTd9LeTau6qONfcJAN
> > BcghQj3%2FH6HDc%3D=0
> >
> > Voting will go on for a minimum of 48 hours.
> >
> > I vote +1:
> > * Ran coho audit-license-headers over the relevant repos
> > * Ran coho check-license to ensure all dependencies and subdependencies
> > have Apache-compatible licenses
> > * Ensured continuous build was green when repos were tagged
> > * Ran through testing section at
> > https://na01.safelinks.protection.outlook.com/?url=
> > https%3A%2F%2Fgithub.com%2Fapache%2Fcordova-coho%2Fblob%2Fmaster%2Fdocs%
> > 2Ftools-release-process.md%23test=02%7C01%7Cv-alsoro%
> 40microsoft.com%
> > 7C848dbf8d68ce457a301608d490f082f4%7C72f988bf86f141af91ab2d7cd011
> > db47%7C1%7C0%7C636292810111594673=xQzEibtfDfotVHfc4l8uyfRsx97u6g
> > 1Qi%2FXSjl0LPiY%3D=0
> >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
> > For additional commands, e-mail: dev-h...@cordova.apache.org
> >
> >
>

[GitHub] cordova-node-xcode pull request #1: Fix possible null-access error in "remov...

[ZauberNerd]

GitHub user ZauberNerd opened a pull request:

https://github.com/apache/cordova-node-xcode/pull/1

Fix possible null-access error in "removeFromFrameworksPbxGroup"

The method `project.removeFromFrameworksPbxGroup` directly tries to
access `children` on `project.pbxGroupByName` - but this method might
return `null` if no such group exists.
To prevent a runtime error when trying to access a property on `null` we
can add a check whether the requested group "Frameworks" does exist in
the project and only then continue with the removal of the file.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ZauberNerd/cordova-node-xcode 
fix-removeFromFrameworksPbxGroup

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-node-xcode/pull/1.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1


commit 4dee445feec7dc886b9fd176ab28445e682ae631
Author: ZauberNerd 
Date:   2017-05-04T13:24:06Z

Fix possible null-access error in "removeFromFrameworksPbxGroup"

The method `project.removeFromFrameworksPbxGroup` directly tries to
access `children` on `project.pbxGroupByName` - but this method might
return `null` if no such group exists.
To prevent a runtime error when trying to access a property on `null` we
can add a check whether the requested group "Frameworks" does exist in
the project and only then continue with the removal of the file.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-device-orientation issue #34: CB-12667 android: Added logic f...

[matrosov-nikita]

Github user matrosov-nikita commented on the issue:

https://github.com/apache/cordova-plugin-device-orientation/pull/34
  
@filmaj, I can confirm that auto and manual tests work w/ my fix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar issue #79: Browser: Check callback exists before ca...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-statusbar/pull/79
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-statusbar/pull/79/commits/5d97cfab37f55ce69eebb1c8f9c9c50768c870f1)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-statusbar-pr/47/)

 24 tests run, 0 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-statusbar pull request #79: Browser: Check callback exists be...

[imgx64]

GitHub user imgx64 opened a pull request:

https://github.com/apache/cordova-plugin-statusbar/pull/79

Browser: Check callback exists before calling it

### Platforms affected
Browser.

### What does this PR do?
Fix exception in Browser platform when calling StatusBar.styleDefault() 
(The error is: ERROR TypeError: win is not a function).

### What testing has been done on this change?
I Ran it in a browser, and it stopped throwing the exception.

### Checklist
(I think this change is too trivial for the below, but I can do it it if 
necessary)
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/imgx64/cordova-plugin-statusbar patch-1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-statusbar/pull/79.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #79


commit 5d97cfab37f55ce69eebb1c8f9c9c50768c870f1
Author: imgx64 
Date:   2017-05-04T10:02:38Z

Browser: Check callback exists before calling it




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-vibration issue #54: AndroidThings: Enable Cordova-plugin-vib...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-vibration/pull/54
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-vibration/pull/54/commits/d1e43775a100b9615a2a4eee6ac69a52858073b3)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-vibration-pr/26/)

 3 tests run, 0 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-vibration pull request #54: AndroidThings: Enable Cordova-plu...

[fujunwei]

GitHub user fujunwei reopened a pull request:

https://github.com/apache/cordova-plugin-vibration/pull/54

AndroidThings: Enable Cordova-plugin-vibration on Android Things plat…

…form

The vibrate device is using ump buzzer library.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fujunwei/cordova-plugin-vibration buzzer

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-vibration/pull/54.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #54


commit d1e43775a100b9615a2a4eee6ac69a52858073b3
Author: junweifu 
Date:   2017-05-04T07:10:07Z

AndroidThings: Enable Cordova-plugin-vibration on Android Things platform

The vibrate device is using ump buzzer library.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-vibration issue #54: AndroidThings: Enable Cordova-plugin-vib...

[cordova-qa]

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-vibration/pull/54
  
Cordova CI Build has one or more failures. 

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-vibration/pull/54/commits/d1e43775a100b9615a2a4eee6ac69a52858073b3)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-vibration-pr/25/)

 3 tests run, 0 skipped, 0 failed.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-vibration pull request #54: AndroidThings: Enable Cordova-plu...

[fujunwei]

Github user fujunwei closed the pull request at:

https://github.com/apache/cordova-plugin-vibration/pull/54


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-vibration pull request #54: AndroidThings: Enable Cordova-plu...

[fujunwei]

GitHub user fujunwei opened a pull request:

https://github.com/apache/cordova-plugin-vibration/pull/54

AndroidThings: Enable Cordova-plugin-vibration on Android Things plat…

…form

The vibrate device is using ump buzzer library.



### Platforms affected


### What does this PR do?


### What testing has been done on this change?


### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fujunwei/cordova-plugin-vibration buzzer

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-vibration/pull/54.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #54


commit d1e43775a100b9615a2a4eee6ac69a52858073b3
Author: junweifu 
Date:   2017-05-04T07:10:07Z

AndroidThings: Enable Cordova-plugin-vibration on Android Things platform

The vibrate device is using ump buzzer library.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-plugin-file issue #199: CB-12355: (iOS) fix FileEntry.file.type

[svzi]

Github user svzi commented on the issue:

https://github.com/apache/cordova-plugin-file/pull/199
  
So when we can expect a solution for this? Looks like the test have already 
passed, 9 days ago... I would strongly appreciate any progress here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h...@cordova.apache.org