[GitHub] cordova-android pull request: CB-10618 Handle gradle frameworks on...

2016-02-15 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-android/pull/259 CB-10618 Handle gradle frameworks on plugin installation/uninstallation An implementation for [CB-10618](https://issues.apache.org/jira/browse/CB-10618) This PR brings

[DISCUSS] Cordova-common 1.1.0 release

2016-02-15 Thread Vladimir Kotikov (Akvelon)
Hi, guys. I'm planning to do a minor release for cordova-common. Here is the list of JIRAs to be resolved in this release (aka RELEASENOTES): * CB-10052 Improve superspawn to allow to handle spawned process io streams * CB-10176 Cordova-common should contain a default logger implementation *

[GitHub] cordova-lib pull request: CB-10592 Don't quote platform specific a...

2016-02-12 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/386#discussion_r52731347 --- Diff: cordova-lib/src/cordova/util.js --- @@ -297,7 +297,7 @@ function ensurePlatformOptionsCompatible (platformOptions) { }).map

[GitHub] cordova-lib pull request: CB-10518 Correct log level and error mes...

2016-02-12 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/383#discussion_r52794358 --- Diff: cordova-lib/src/cordova/targets.js --- @@ -25,9 +25,9 @@ var cordova_util = require('./util'), function handleError(error

[GitHub] cordova-lib pull request: CB-10518 Correct log level and error mes...

2016-02-12 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/383#discussion_r52794281 --- Diff: cordova-lib/src/cordova/run.js --- @@ -44,7 +44,7 @@ module.exports = function run(options) { }).then(function

[GitHub] cordova-lib pull request: CB-10518 Correct log level and error mes...

2016-02-12 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/383#discussion_r52793854 --- Diff: cordova-lib/src/cordova/compile.js --- @@ -40,7 +40,7 @@ module.exports = function compile(options) { }).then(function

[GitHub] cordova-lib pull request: CB-10592 Don't quote platform specific a...

2016-02-12 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/386#discussion_r52796519 --- Diff: cordova-lib/src/cordova/util.js --- @@ -297,7 +297,7 @@ function ensurePlatformOptionsCompatible (platformOptions) { }).map

[GitHub] cordova-lib pull request: CB-10592 Don't quote platform specific a...

2016-02-11 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/386#discussion_r52712187 --- Diff: cordova-lib/src/cordova/util.js --- @@ -297,7 +297,7 @@ function ensurePlatformOptionsCompatible (platformOptions) { }).map

RE: [VOTE] Plugins Release

2016-02-11 Thread Vladimir Kotikov (Akvelon)
The vote has now closed. The results are: Positive Binding Votes: 3 Vladimir Kotikov Alexander Sorokin Sergey Grebnov The vote has passed - Best regards, Vladimir -Original Message- From: Sergey Grebnov (Akvelon) [mailto:v-seg...@microsoft.com] Sent: Thursday, February 11, 2016 11:45

[GitHub] cordova-lib pull request: CB-10592 Don't quote platform specific a...

2016-02-11 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/386 CB-10592 Don't quote platform specific args values See JIRA [CB-10592](https://issues.apache.org/jira/browse/CB-10592) You can merge this pull request into a Git repository by running

[GitHub] cordova-lib pull request: CB-10519 Wrap all sync calls inside of `...

2016-02-10 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/384 CB-10519 Wrap all sync calls inside of `cordova.raw` methods into promises This is a fix for [CB-10519](https://issues.apache.org/jira/browse/CB-10519) This PR fixes the issue

[GitHub] cordova-lib pull request: CB-10584 Splashscreen plugin crashes the...

2016-02-10 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/385#discussion_r52569334 --- Diff: cordova-lib/src/plugman/browserify.js --- @@ -106,7 +106,7 @@ module.exports = function doBrowserify (project, platformApi

[GitHub] cordova-lib pull request: CB-10518 Correct log level and error mes...

2016-02-10 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/383 CB-10518 Correct log level and error messages for some cordova errors Issue [CB-10518](https://issues.apache.org/jira/browse/CB-10518) You can merge this pull request into a Git

[VOTE] Plugins Release

2016-02-09 Thread Vladimir Kotikov (Akvelon)
Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-10557 The plugins have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-10557

[GitHub] cordova-docs pull request: CB-10557 Adds plugins release blog post

2016-02-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/495#discussion_r52357723 --- Diff: www/_posts/2016-02-09-plugins-release.md --- @@ -0,0 +1,63 @@ +--- +layout: post +author: +name: Vladimir Kotikov

[GitHub] cordova-js pull request: CB-10558 Update cordova-js according to w...

2016-02-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-js/pull/131#issuecomment-181774989 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

RE: [DISCUSS] Plugin patch release

2016-02-09 Thread Vladimir Kotikov (Akvelon)
I'm going to start vote soon. Here is updated release notes for this release: ## cordova-plugin file ### 4.1.1 (Feb 09, 2016) * Edit package.json license to match SPDX id * [CB-10419](https://issues.apache.org/jira/browse/CB-10419) cordova-plugin-file 4.0.0 error with browserify workflow ##

[GitHub] cordova-lib pull request: CB-10430 Allow to modify events source

2016-02-09 Thread vladimir-kotikov
Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-lib/pull/370 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-lib pull request: CB-10430 Adds forwardEvents method to ea...

2016-02-09 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/382 CB-10430 Adds forwardEvents method to easily connect two EventEmitters This fixes CB-10430. This change is needed to allow platform connect own `events` instance to another

[GitHub] cordova-lib pull request: CB-10430 Allow to modify events source

2016-02-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/370#issuecomment-181906497 Closing this for now. I'll reopen another PR with updated implementation. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-lib pull request: CB-10430 Adds forwardEvents method to ea...

2016-02-09 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/382#issuecomment-181910107 @nikhilkh, could you please take a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[REVIEW] Plugins release blog post

2016-02-09 Thread Vladimir Kotikov (Akvelon)
Please review and comment: https://github.com/apache/cordova-docs/pull/495 - Best regards, Vladimir - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10567 Bubble up `cordova.raw.run()` e...

2016-02-09 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/381 CB-10567 Bubble up `cordova.raw.run()` error to the caller JIRA [CB-10567](https://issues.apache.org/jira/browse/CB-10567) You can merge this pull request into a Git repository

[GitHub] cordova-docs pull request: CB-10557 Adds plugins release blog post

2016-02-09 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-docs/pull/495 CB-10557 Adds plugins release blog post Release issue: [CB-10557](https://issues.apache.org/jira/browse/CB-10557) You can merge this pull request into a Git repository by running

[GitHub] cordova-plugin-media pull request: CB-10476 - fix problem where ca...

2016-02-08 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/78#issuecomment-181298201 @riknoll, I was going to start plugins release on Tue. Would you be able to merge this before? --- If your project is set up for it, you can

[GitHub] cordova-plugin-file-transfer pull request: CB-8407 Fix downloading...

2016-02-05 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/63#issuecomment-180444839 @Fuchur84, please file an issue on [our issue tracker](https://issues.apache.org/jira/browse/CB) so it could be seen by other devs

[GitHub] cordova-lib pull request: CB-10482 Remove references to windows8 f...

2016-02-05 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/378#issuecomment-180243971 Added a few comments, otherwise LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-lib pull request: CB-10482 Remove references to windows8 f...

2016-02-05 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/378#discussion_r51986870 --- Diff: cordova-lib/spec-cordova/metadata/windows_parser.spec.js --- @@ -115,31 +110,9 @@ describe('windows8 project parser', function

[GitHub] cordova-docs pull request: CB-10495 Adds cordova-windows 4.3.1 rel...

2016-02-04 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-docs/pull/485 CB-10495 Adds cordova-windows 4.3.1 release blog post You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-docs CB

RE: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos

2016-02-04 Thread Vladimir Kotikov (Akvelon)
Steve said don't go mad and kill your self looking trying reach 100% for the repo, use it in a way that make sense. On Tue, Feb 2, 2016 at 7:34 AM Vladimir Kotikov (Akvelon) < v-vlk...@microsoft.com> wrote: > This is not only about visualization. > Codecov also stores previous result a

RE: [REVIEW] cordova-windows 4.3.1 blog post

2016-02-04 Thread Vladimir Kotikov (Akvelon)
Please review and comment: https://github.com/apache/cordova-docs/pull/485 - Best regards, Vladimir - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

RE: [VOTE] InAppBrowser Plugin Release

2016-02-04 Thread Vladimir Kotikov (Akvelon)
I vote +1. * Verified signatures and hashes * Ran coho audit-license-headers over the repo * Ran plugin auto tests to ensure they are passing - Best regards, Vladimir -Original Message- From: Alexander Sorokin (Akvelon) [mailto:v-als...@microsoft.com] Sent: Wednesday, February 3, 2016

[REVIEW] cordova-windows 4.3.1 blog post

2016-02-04 Thread Vladimir Kotikov (Akvelon)
Please review and comment: https://github.com/apache/cordova-docs/pull/485 - Best regards, Vladimir - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request: CB-10531 Enable coverage reports for cor...

2016-02-04 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/377 CB-10531 Enable coverage reports for cordova-lib This PR adds integration with codecov.io There is also a few improvements for Travis and Appveyor configs and npm tasks

[GitHub] cordova-lib pull request: CB-10482 Remove references to windows8 f...

2016-02-04 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/378#discussion_r51986491 --- Diff: cordova-lib/src/cordova/metadata/windows_parser.js --- @@ -65,135 +53,13 @@ require('util').inherits(windows_parser, Parser

[GitHub] cordova-lib pull request: CB-10482 Remove references to windows8 f...

2016-02-04 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/378#discussion_r51986428 --- Diff: cordova-lib/src/cordova/metadata/windows_parser.js --- @@ -65,135 +53,13 @@ require('util').inherits(windows_parser, Parser

[GitHub] cordova-lib pull request: CB-10430 Allow to modify events source

2016-02-04 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/370#issuecomment-180026635 Guys, just a couple of ideas, based on discussion with Nikhil: 1, Instead of overwriting `events` instance in common, platform might set a reference

RE: [VOTE] Cordova windows 4.3.1 release

2016-02-04 Thread Vladimir Kotikov (Akvelon)
The vote has now closed. The results are: Positive Binding Votes: 3 Vladimir Kotikov Alexander Sorokin Jesse MacFadyen The vote has passed. - Best regards, Vladimir -Original Message- From: Alexander Sorokin (Akvelon) [mailto:v-als...@microsoft.com] Sent: Tuesday, February 2, 2016 3

[GitHub] cordova-lib pull request: CB-10459: cordova platform list should m...

2016-02-03 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/368#issuecomment-179092390 @sarangan12, LGTM, merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-lib pull request: CB-10430 Allow to modify events source

2016-02-03 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/370#issuecomment-179297923 No, this is not a part of API. However, this might be critical for some external tools to get this information. @nikhilkh, what do you think about

[GitHub] cordova-lib pull request: CB-10465 Pass correct options to prepare...

2016-02-03 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/374 CB-10465 Pass correct options to prepare from compile This fixes incorrect behaviour of `cordova emulate` command, which results in restoring all saved platforms even when only

[GitHub] cordova-lib pull request: CB-10465 Pass correct options to prepare...

2016-02-03 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/374#issuecomment-179262628 @sgrebnov, PTAL --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-lib pull request: CB-10176 Adds CordovaLogger class, based...

2016-02-03 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/375 CB-10176 Adds CordovaLogger class, based on logger module from cordova-cli This is an implementation for [CB-10176](https://issues.apache.org/jira/browse/CB-10176) This PR adds

[GitHub] cordova-lib pull request: CB-10176 Adds standard logger, based on ...

2016-02-03 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/375#issuecomment-179682858 @purplecabbage, i'd say to CamelCase for classes and lowerCamelCase for the rest --- If your project is set up for it, you can reply to this email

[GitHub] cordova-lib pull request: CB-10497 Prefer .bat over .cmd on window...

2016-02-02 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/371#issuecomment-178623860 Tested this, and it seems to work fine. Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-lib pull request: CB-10052 Expose child process' io stream...

2016-02-02 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/369#issuecomment-178520650 @dblotsky, it seems that didn't really understand your idea. Could you please clarify, where do you propose to return `stdout` and `stderr` from

RE: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos

2016-02-02 Thread Vladimir Kotikov (Akvelon)
This is not only about visualization. Codecov also stores previous result and performs an analysis, how coverage has changed. Take a look at the comment, made by codecov bot at the PR: https://github.com/vladimir-kotikov/cordova-lib/pull/2 - Best regards, Vladimir -Original Message

[GitHub] cordova-lib pull request: CB-10052 Expose child process' io stream...

2016-02-02 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/369#issuecomment-178564407 @dblotsky, is this good to go? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib pull request: CB-10430 Allow to modify events source

2016-02-02 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/370#issuecomment-178554295 @dblotsky, @purplecabbage, thanks for feedback. Agree, this probably smells fishy. However, the only one option i see apart from this one is to setup

[GitHub] cordova-lib pull request: CB-10430 Allow to modify events source

2016-02-02 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/370#issuecomment-178561020 Because we've been logging these events all the time before cordova refactoring. Many of these events doesn't have much value though, and could be safely

[VOTE] Cordova windows 4.3.1 release

2016-02-01 Thread Vladimir Kotikov (Akvelon)
Please review and vote on this cordova-windows 4.3.1 release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-10495 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-10495

[GitHub] cordova-docs pull request: CB-10332 Android Guide Improvements

2016-02-01 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-docs/pull/471#issuecomment-177849723 @riknoll, +1, makes sense --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-inappbrowser pull request: CB-10456 InAppBrowser is...

2016-02-01 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/143#issuecomment-177913909 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-inappbrowser pull request: CB-10441 Add auto tests ...

2016-02-01 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/142#issuecomment-177913876 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-lib pull request: CB-10430 Allow to modify events source

2016-02-01 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/370 CB-10430 Allow to modify events source This fixes [CB-10430](https://issues.apache.org/jira/browse/CB-10430). This change is needed to allow other tools to replace default

[GitHub] cordova-lib pull request: CB-10052 Expose child process' io stream...

2016-02-01 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/369 CB-10052 Expose child process' io streams via promise progress notification This implements [CB-10052](https://issues.apache.org/jira/browse/CB-10052). The `superspawn.spawn

[GitHub] cordova-lib pull request: CB-10052 Expose child process' io stream...

2016-02-01 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/369#discussion_r51532148 --- Diff: cordova-common/src/superspawn.js --- @@ -113,11 +139,15 @@ exports.spawn = function(cmd, args, opts

RE: [DISCUSS] Enabling coverage reports collection and analysis for cordova repos

2016-02-01 Thread Vladimir Kotikov (Akvelon)
> Though I do believe it is important not to chase 100% code coverage. > > > On Mon, Feb 1, 2016 at 6:21 AM, Vladimir Kotikov (Akvelon) < > v-vlk...@microsoft.com> wrote: > > > Hey, guys > > > > I've spent a couple of hours and have a prototype of how we c

[GitHub] cordova-lib pull request: CB-10052 Expose child process' io stream...

2016-02-01 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/369#issuecomment-178421841 Returning data instead of raw eventEmitter is IMO just less complex for caller API, because you, as a caller, do not need to create handlers, subscribe

[DISCUSS] Enabling coverage reports collection and analysis for cordova repos

2016-02-01 Thread Vladimir Kotikov (Akvelon)
-kotikov/cordova-lib [2] https://github.com/vladimir-kotikov/cordova-lib/pull/2 [3] https://codecov.io/github/vladimir-kotikov/cordova-lib - Best regards, Vladimir - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org

[DISCUSS] Cordova windows 4.3.1 release

2016-01-29 Thread Vladimir Kotikov (Akvelon)
Hi all We're planning to do a patch release of cordova-windows (proposed version is 4.3.1) to address some regressions. Here is the patches to be included in this release: * CB-10394 Do not cache manifest file while getting package name * CB-10446 Windows 10 Cordova Application

[GitHub] cordova-docs pull request: CB-10332 Android Guide Improvements

2016-01-29 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/471#discussion_r51309545 --- Diff: www/docs/en/dev/guide/platforms/android/index.md --- @@ -32,276 +32,152 @@ development. For a comparison of the two development

[GitHub] cordova-docs pull request: CB-10332 Android Guide Improvements

2016-01-29 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/471#discussion_r51309554 --- Diff: www/docs/en/dev/guide/platforms/android/index.md --- @@ -32,276 +32,152 @@ development. For a comparison of the two development

[GitHub] cordova-cli pull request: Add cordova CLI readme docs

2016-01-29 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/233#discussion_r51310924 --- Diff: doc/readme.md --- @@ -0,0 +1,337 @@ + + +#Cordova Command-line-interface (CLI) Reference + +##Syntax

[GitHub] cordova-cli pull request: Add cordova CLI readme docs

2016-01-29 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/233#discussion_r51311693 --- Diff: doc/readme.md --- @@ -0,0 +1,337 @@ + + +#Cordova Command-line-interface (CLI) Reference + +##Syntax

[GitHub] cordova-cli pull request: Add cordova CLI readme docs

2016-01-29 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/233#discussion_r51311142 --- Diff: doc/readme.md --- @@ -0,0 +1,337 @@ + + +#Cordova Command-line-interface (CLI) Reference + +##Syntax

[GitHub] cordova-windows pull request: CB-10394 Do not cache manifest file ...

2016-01-28 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/143#issuecomment-176045173 I've created [CB-10463](https://issues.apache.org/jira/browse/CB-10463) for appxmanifest improvements --- If your project is set up for it, you can

[GitHub] cordova-android pull request: Parse options correctly

2016-01-28 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/248#issuecomment-176068570 Verified and it seems to work fine now with all possible combinations of `--` and other args (i tested with `--ant`, `--keystore` and `--alias

[GitHub] cordova-windows pull request: CB-10303 Add tests to cover argument...

2016-01-28 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-windows/pull/145 CB-10303 Add tests to cover arguments parsing regression You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova

[GitHub] cordova-windows pull request: CB-10303 Add tests to cover argument...

2016-01-28 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/145#issuecomment-176142684 @nikhilkh, could you please take a look, when possible --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-android pull request: Parse options correctly

2016-01-27 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/248#issuecomment-175576742 @Mitko-Kerezov, my bad, i missed you name in CLA list Regarding the > the usage of -- basically suggests "I want to stop passing

[GitHub] cordova-android pull request: CB-10138 Adds missing plugin metadat...

2016-01-27 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/254#issuecomment-175599710 @sgrebnov, PTAL --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-android pull request: CB-10138 Adds missing plugin metadat...

2016-01-27 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-android/pull/254 CB-10138 Adds missing plugin metadata to plugin_list module This is a fix for [CB-10138](https://issues.apache.org/jira/browse/CB-10138) You can merge this pull request into a Git

[GitHub] cordova-windows pull request: CB-10394 Do not cache manifest file ...

2016-01-27 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/143#issuecomment-175617770 @nikhilkh, it seems there is another, more general way to resolve this. We might reuse the same caching facility as used by `ConfigChanges` module

[GitHub] cordova-android pull request: CB-10421 Fixes exception when callin...

2016-01-26 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-android/pull/252 CB-10421 Fixes exception when calling run script with --help option See [CB-10421](https://issues.apache.org/jira/browse/CB-10421) You can merge this pull request into a Git

[GitHub] cordova-lib pull request: CB-10432 Adds e2e test to protect agains...

2016-01-26 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/366 CB-10432 Adds e2e test to protect against future regressions This PR adds test to cover the regression, reported in [CB-10432](https://issues.apache.org/jira/browse/CB-10432) You can

[GitHub] cordova-windows pull request: CB-10394 Do not cache manifest file ...

2016-01-26 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-windows/pull/143 CB-10394 Do not cache manifest file while getting package name This fixes [CB-10394](https://issues.apache.org/jira/browse/CB-10394) You can merge this pull request into a Git

[GitHub] cordova-android pull request: CB-10421 Fixes exception when callin...

2016-01-26 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/252#issuecomment-175032613 @sgrebnov, could you please take a look --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-plugin-inappbrowser pull request: CB-10428 Fix syntax erro...

2016-01-26 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/141#issuecomment-175004173 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

RE: [DISCUSS] Old platforms support deprecation

2016-01-25 Thread Vladimir Kotikov (Akvelon)
we have not released a platform API > implementation and do not plan to e.g. WP8, WebOS, Ubuntu - we should > support them for longer unless the cost is significant. > > -Nikhil > > -Original Message- > From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft

[GitHub] cordova-lib pull request: CB-10432 Fix plugin installation for new...

2016-01-25 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/365 CB-10432 Fix plugin installation for newly added platform A fix for [CB-10432](https://issues.apache.org/jira/browse/CB-10432) You can merge this pull request into a Git repository

RE: [DISCUSS] Old platforms support deprecation

2016-01-22 Thread Vladimir Kotikov (Akvelon)
he update by then. OSX already has a PR for PlatformAPI changes. I think this sounds fine. Deprecated platforms would still work with old versions of cordova. On Jan 22, 2016 6:58 AM, "Vladimir Kotikov (Akvelon)" < v-vlk...@microsoft.com> wrote: > Hi guys. > > Starting from upcom

[DISCUSS] Old platforms support deprecation

2016-01-22 Thread Vladimir Kotikov (Akvelon)
Hi guys. Starting from upcoming cordova release (6.0.0) we have PlatformApi implemented and used by three major platforms (Android, iOS and Windows). This means that we now have a lot of code in cordova-lib which exists there only for maintaining compatibility with previous platforms versions.

[GitHub] cordova-android pull request: CB-10157 Uninstall app from device/e...

2016-01-21 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-android/pull/251 CB-10157 Uninstall app from device/emulator only when signed apk is already installed JIRA: [CB-10157](https://issues.apache.org/jira/browse/CB-10157) You can merge this pull

[GitHub] cordova-android pull request: Parse options correctly

2016-01-21 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/248#issuecomment-173500760 The second fix LGTM. Regarding the first - looks like it breaks the scenario when platform-specific options are passed behind `--` arguments

[GitHub] cordova-android pull request: CB-10406 Fixes an exception, thrown ...

2016-01-21 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-android/pull/250 CB-10406 Fixes an exception, thrown when building using Ant See [CB-10406](https://issues.apache.org/jira/browse/CB-10406) You can merge this pull request into a Git repository

[GitHub] cordova-windows pull request: CB-10381 fix the bug when removing a...

2016-01-20 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/140#issuecomment-173475729 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-camera pull request: [iOS] Fixed how checks access ...

2016-01-15 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/146#issuecomment-171915964 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-lib pull request: [CB-10274] Make www directory the defaul...

2016-01-12 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/360#issuecomment-170846785 Thanks @stevengill, @bradleyjames. Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

RE: [Vote] Windows 4.3.0 Release

2016-01-12 Thread Vladimir Kotikov (Akvelon)
: missing semver dependency. I vote -1. -Original Message- From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] Sent: Monday, January 11, 2016 5:08 PM To: dev@cordova.apache.org Subject: [Vote] Windows 4.3.0 Release Please review and vote on this 4.3.0 Windows Release by replying

RE: [DISCUSS] Cordova-windows 4.3.0 release

2016-01-12 Thread Vladimir Kotikov (Akvelon)
-Original Message- From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] Sent: Tuesday, January 5, 2016 4:18 PM To: dev@cordova.apache.org Subject: [DISCUSS] Cordova-windows 4.3.0 release Hi all, I plan to do a minor cordova-windows release (bump to 4.3.0) to release PlatformApi

[Vote] Windows 4.3.0 Release attempt 2

2016-01-12 Thread Vladimir Kotikov (Akvelon)
Please review and vote on this 4.3.0 Windows Release (2nd attempt) by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-10299 The archive has been published to dist/dev:

[GitHub] cordova-docs pull request: CB-10299 Adds windows@4.3.0 release blo...

2016-01-11 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-docs/pull/453 CB-10299 Adds windows@4.3.0 release blog post See [CB-10299](https://issues.apache.org/jira/browse/CB-10299) You can merge this pull request into a Git repository by running

[REVIEW] cordova-windows 4.3.0 blog post

2016-01-11 Thread Vladimir Kotikov (Akvelon)
Please review and comment: https://github.com/apache/cordova-docs/pull/453 - Best regards, Vladimir - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

[Vote] Windows 4.3.0 Release

2016-01-11 Thread Vladimir Kotikov (Akvelon)
Please review and vote on this 4.3.0 Windows Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-10299 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-10299 The

[GitHub] cordova-lib pull request: [CB-10274] Make www directory the defaul...

2016-01-11 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/360#issuecomment-170584322 @stevengill, what do you think about this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-windows pull request: CB-10303 Fixes build arguments parsi...

2016-01-06 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-windows/pull/135 CB-10303 Fixes build arguments parsing This PR fixes the issuesfrom [CB-10303](https://issues.apache.org/jira/browse/CB-10303) You can merge this pull request into a Git

[GitHub] cordova-windows pull request: CB-10303 Fixes build arguments parsi...

2016-01-06 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/135#issuecomment-169303730 @sgrebnov, could you please review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-lib pull request: [CB-10274] Make www directory the defaul...

2016-01-05 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/360#discussion_r48829695 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -186,6 +186,14 @@ module.exports = function plugin(command, targets, opts

[GitHub] cordova-android pull request: Include native libraries from armeab...

2016-01-05 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-android/pull/243#issuecomment-168974522 I don't have an experience in this area, so i'd prefer to @infil00p or @stevengill took a look at this --- If your project is set up for it, you can

<    3   4   5   6   7   8   9   10   11   12   >