Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/227
@filmaj, sure, my congratulations :)
@stevengill, could you please take a look?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-lib/pull/565
@filmaj, done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/227
@filmaj, I've added a section in docs for Data URIs, could you please take
a look?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-android/pull/397
@filmaj, thanks for the information, I'm planning to merge in once Appveyor
is fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/227
@filmaj, I would expand this section
(https://github.com/apache/cordova-plugin-inappbrowser#more-usage-info) by
adding samples with Data URIs.
But, for now, I
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-android/pull/397
@filmaj, updated. But I little doubt about folders names after prepare,
this PR just skips the removal of an original package if names (manifestId and
androidPkgName) differ
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/227
Seems that it's supported on browser platform only (for now I've verified
for android, windows, ios, browser platforms). I've updated PR to add support
for windows
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-android/pull/397
CB-13031: Fix bug with case-sensitivity of android-packageName
### Platforms affected
self
### What does this PR do?
Steps to reproduce:
1) cordova
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/227
CB-12969 android: Added support for data URIs
### Platforms affected
Android
### What does this PR do?
Adds support for data Uri (e.g
Github user matrosov-nikita commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/237#discussion_r127480714
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -171,6 +182,54 @@ function getAvailableUAPVersions
Github user matrosov-nikita commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/237#discussion_r127481484
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -171,6 +182,54 @@ function getAvailableUAPVersions
Github user matrosov-nikita commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/237#discussion_r127480919
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -171,6 +182,54 @@ function getAvailableUAPVersions
Github user matrosov-nikita commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/237#discussion_r127480213
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -171,6 +182,54 @@ function getAvailableUAPVersions
Github user matrosov-nikita commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/237#discussion_r127481238
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -171,6 +182,54 @@ function getAvailableUAPVersions
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-android/pull/362
@filmaj, done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-android/pull/362
Regarding changes in `spec/e2e/helpers/projectActions.js`, script path
within this
[command](https://github.com/apache/cordova-android/blob/master/spec/e2e/helpers/projectActions.js
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-android/pull/362
This bug affects user only if project path includes spaces.
Repro steps:
1) Create project in folder with space in name (i.e `C:\my projects\sample`)
2) Run `cordova
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-windows/pull/235
CB-11968: Add support for config-file in config.xml
### Platforms affected
### What does this PR do?
This logic is needed to apply changes using 'device
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-android/pull/388
@filmaj, is it good to merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-lib/pull/565
@filmaj, thanks for the information. I'm looking forward to getting back
working CI.
Also, I think that I should create a new issue for this bug.
---
If your project is set up
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-android/pull/388
Suppress line 'Picked up _JAVA_OPTIONS' from stderr
### Platforms affected
android
### What does this PR do?
If `_JAVA_OPTIONS` variable is defined
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-lib/pull/565
Platform's spec is ignored in config.xml if package.json doesn't contain
dependency for platform
### Platforms affected
all
### What does this PR do?
Steps
Github user matrosov-nikita closed the pull request at:
https://github.com/apache/cordova-plugin-media/pull/138
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/138
@filmaj, thanks :) I've merged this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-browser/pull/31
Also, I think you need to send this PR in the cordova-serve
(https://github.com/apache/cordova-serve)
---
If your project is set up for it, you can reply to this email and have your
Github user matrosov-nikita commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/31#discussion_r121171981
--- Diff: node_modules/cordova-serve/src/exec.js ---
@@ -29,7 +29,15 @@ var child_process = require('child_process'),
module.exports
Github user matrosov-nikita commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/31#discussion_r121171609
--- Diff: node_modules/cordova-serve/src/exec.js ---
@@ -29,7 +29,15 @@ var child_process = require('child_process'),
module.exports
Github user matrosov-nikita commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/31#discussion_r121171521
--- Diff: node_modules/cordova-serve/src/exec.js ---
@@ -29,7 +29,15 @@ var child_process = require('child_process'),
module.exports
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/212
@filmaj, done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/34
@filmaj, done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/212
@filmaj, I don't have committer rights.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/34
@filmaj, @infil00p, do I need to do something else on this issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/212
@filmaj, no, the same pr was merged into DefinitelyTyped repo
(https://github.com/DefinitelyTyped/DefinitelyTyped/pull/14138)
---
If your project is set up for it, you
Github user matrosov-nikita commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/555#discussion_r120073277
--- Diff: cordova-fetch/index.js ---
@@ -148,9 +148,15 @@ function trimID(target) {
target = parts[1
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-plugin-media/pull/138
@alsorokin, could you please take a look at this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/34
@petrot, what do you mean 'compass problem`. Do you have any particular
cases which don't work for you? I could test them with this fix.
---
If your project is set
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-lib/pull/559
Display deprecation message when installing a platform with version lower
than api compatible
### Platforms affected
all
### What does this PR do?
Repro
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-lib/pull/557
CB-12787: Fix plugin installation with --link option
### Platforms affected
all
### What does this PR do?
Fix logic for installation plugins with `--link
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-lib/pull/554
I'm investigating what's causing CI failures.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-lib/pull/555
I'm investigating what's causing CI failures.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-lib/pull/555
Improve logic for searching plugin id in case of module already exists in
node_modules
### Platforms affected
all
### What does this PR do?
Steps
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-lib/pull/554
CB-12738: Cordova ignores plugin dependency version on windows platform
### Platforms affected
windows
### What does this PR do?
Steps to reproduce w
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-lib/pull/542
@stevengill, I think we should use version from `cordova-lib/package.json`
rather than package.json from the application. Quick fix:
https://github.com/matrosov-nikita/cordova-lib
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/34
@filmaj, I can confirm that auto and manual tests work w/ my fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/34
@infil00p, sorry for late reply, I've tested a plugin with two Samsung
devices:
1) Samsung Galaxy Core Prime VE Duos SM-G361H (Android 5.1)
