[GitHub] [creadur-whisker] ottlinger merged pull request #101: Bump actions/checkout from 3 to 4

ottlinger merged PR #101: URL: https://github.com/apache/creadur-whisker/pull/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [creadur-tentacles] ottlinger merged pull request #82: Bump actions/checkout from 3 to 4

ottlinger merged PR #82: URL: https://github.com/apache/creadur-tentacles/pull/82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [creadur-whisker] dependabot[bot] opened a new pull request, #101: Bump actions/checkout from 3 to 4

dependabot[bot] opened a new pull request, #101: URL: https://github.com/apache/creadur-whisker/pull/101 Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases.

[GitHub] [creadur-rat] dependabot[bot] opened a new pull request, #155: Bump actions/cache from 3.3.1 to 3.3.2

dependabot[bot] opened a new pull request, #155: URL: https://github.com/apache/creadur-rat/pull/155 Bumps [actions/cache](https://github.com/actions/cache) from 3.3.1 to 3.3.2. Release notes Sourced from https://github.com/actions/cache/releases;>actions/cache's releases.

[GitHub] [creadur-whisker] ottlinger merged pull request #102: Bump actions/cache from 3.3.1 to 3.3.2

ottlinger merged PR #102: URL: https://github.com/apache/creadur-whisker/pull/102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [creadur-whisker] dependabot[bot] opened a new pull request, #102: Bump actions/cache from 3.3.1 to 3.3.2

dependabot[bot] opened a new pull request, #102: URL: https://github.com/apache/creadur-whisker/pull/102 Bumps [actions/cache](https://github.com/actions/cache) from 3.3.1 to 3.3.2. Release notes Sourced from https://github.com/actions/cache/releases;>actions/cache's releases.

[GitHub] [creadur-tentacles] dependabot[bot] opened a new pull request, #82: Bump actions/checkout from 3 to 4

dependabot[bot] opened a new pull request, #82: URL: https://github.com/apache/creadur-tentacles/pull/82 Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases.

[GitHub] [creadur-rat] dependabot[bot] opened a new pull request, #154: Bump actions/checkout from 3 to 4

dependabot[bot] opened a new pull request, #154: URL: https://github.com/apache/creadur-rat/pull/154 Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. Release notes Sourced from https://github.com/actions/checkout/releases;>actions/checkout's releases.

[GitHub] [creadur-rat] ottlinger merged pull request #154: RAT-311: Bump actions/checkout from 3 to 4

ottlinger merged PR #154: URL: https://github.com/apache/creadur-rat/pull/154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [creadur-rat] ottlinger merged pull request #155: RAT-311: Bump actions/cache from 3.3.1 to 3.3.2

ottlinger merged PR #155: URL: https://github.com/apache/creadur-rat/pull/155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [creadur-tentacles] dependabot[bot] opened a new pull request, #83: Bump actions/cache from 3.3.1 to 3.3.2

dependabot[bot] opened a new pull request, #83: URL: https://github.com/apache/creadur-tentacles/pull/83 Bumps [actions/cache](https://github.com/actions/cache) from 3.3.1 to 3.3.2. Release notes Sourced from https://github.com/actions/cache/releases;>actions/cache's releases.

Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]

jbonofre commented on code in PR #161: URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1378419481 ## apache-rat-core/src/main/java/org/apache/rat/Report.java: ## @@ -349,29 +357,20 @@ private Report() { * @return the IReportale instance containing the

Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]

Claudenw commented on code in PR #161: URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1378464274 ## apache-rat-core/src/main/java/org/apache/rat/Report.java: ## @@ -349,29 +357,20 @@ private Report() { * @return the IReportale instance containing the

Re: [PR] RAT-321 cleanup of testing issues [creadur-rat]

Claudenw commented on code in PR #159: URL: https://github.com/apache/creadur-rat/pull/159#discussion_r1375379728 ## apache-rat-core/src/main/java/org/apache/rat/Report.java: ## @@ -147,27 +146,106 @@ public static final void main(String[] args) throws Exception { if

Re: [PR] RAT-321 cleanup of testing issues [creadur-rat]

Claudenw commented on PR #159: URL: https://github.com/apache/creadur-rat/pull/159#issuecomment-1784014472 absolutely. if you have a standard setup I would gladly follow it. Perhaps it would make sense to add a checkstyle process to align the code base and keep it so. On Sat,

Re: [PR] RAT-321 cleanup of testing issues [creadur-rat]

Claudenw commented on PR #159: URL: https://github.com/apache/creadur-rat/pull/159#issuecomment-1784036020 How can I view the output of the tests on the CI system? On Sat, Oct 28, 2023 at 10:13 PM P. Ottlinger ***@***.***> wrote: > @Claudenw

Re: [PR] RAT-321 cleanup of testing issues [creadur-rat]

ottlinger commented on code in PR #159: URL: https://github.com/apache/creadur-rat/pull/159#discussion_r1375315127 ## apache-rat-plugin/src/test/java/org/apache/rat/mp/BetterAbstractMojoTestCase.java: ## @@ -0,0 +1,118 @@ + +/* + * Licensed to the Apache Software Foundation

Re: [PR] RAT-321 cleanup of testing issues [creadur-rat]

ottlinger commented on code in PR #159: URL: https://github.com/apache/creadur-rat/pull/159#discussion_r1375313971 ## apache-rat-core/src/main/java/org/apache/rat/configuration/LicenseReader.java: ## @@ -37,9 +38,16 @@ public interface LicenseReader { /** * Reads the

Re: [PR] RAT-321 cleanup of testing issues [creadur-rat]

ottlinger commented on code in PR #159: URL: https://github.com/apache/creadur-rat/pull/159#discussion_r1375315470 ## apache-rat-core/pom.xml: ## @@ -15,113 +15,134 @@ See the License for the specific language governing permissions and limitations under the License. -->

Re: [PR] RAT-321 cleanup of testing issues [creadur-rat]

ottlinger commented on code in PR #159: URL: https://github.com/apache/creadur-rat/pull/159#discussion_r1375315406 ## pom.xml: ## @@ -59,8 +59,8 @@ agnostic home for software distribution comprehension and audit tools. 3.5.0 3.20.0 -0.16 -0.17-SNAPSHOT

Re: [PR] RAT-321 cleanup of testing issues [creadur-rat]

Claudenw commented on code in PR #159: URL: https://github.com/apache/creadur-rat/pull/159#discussion_r1375381637 ## apache-rat-core/pom.xml: ## @@ -15,113 +15,134 @@ See the License for the specific language governing permissions and limitations under the License. -->

Re: [PR] RAT-321 cleanup of testing issues [creadur-rat]

ottlinger commented on PR #159: URL: https://github.com/apache/creadur-rat/pull/159#issuecomment-1783910332 @Claudenw would it be possible to use a different file formatter? Many changes seem to be due to other line lengths. Before pushing changes in XML - especially pom.xml et.al -

Re: [PR] RAT-321 cleanup of testing issues [creadur-rat]

Claudenw commented on code in PR #159: URL: https://github.com/apache/creadur-rat/pull/159#discussion_r1375381939 ## apache-rat-plugin/src/test/java/org/apache/rat/mp/BetterAbstractMojoTestCase.java: ## @@ -0,0 +1,118 @@ + +/* + * Licensed to the Apache Software Foundation

Re: [PR] RAT-321 cleanup of testing issues [creadur-rat]

ottlinger commented on code in PR #159: URL: https://github.com/apache/creadur-rat/pull/159#discussion_r1375315563 ## apache-rat-core/src/main/java/org/apache/rat/Report.java: ## @@ -147,27 +146,106 @@ public static final void main(String[] args) throws Exception { if

Re: [PR] RAT-321 cleanup of testing issues [creadur-rat]

ottlinger commented on PR #159: URL: https://github.com/apache/creadur-rat/pull/159#issuecomment-1789714822 @Claudenw Thanks for the many fixes - let's see how things evolve in other scenarios and additional PRs. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] RAT-321 cleanup of testing issues [creadur-rat]

ottlinger commented on code in PR #159: URL: https://github.com/apache/creadur-rat/pull/159#discussion_r1379350975 ## apache-rat-core/src/main/java/org/apache/rat/Report.java: ## @@ -147,27 +146,106 @@ public static final void main(String[] args) throws Exception { if

Re: [PR] RAT-321 cleanup of testing issues [creadur-rat]

ottlinger merged PR #159: URL: https://github.com/apache/creadur-rat/pull/159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]

ottlinger commented on code in PR #161: URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1379361410 ## apache-rat-core/src/main/java/org/apache/rat/Report.java: ## @@ -349,29 +357,20 @@ private Report() { * @return the IReportale instance containing the

Re: [PR] RAT-321 cleanup of testing issues [creadur-rat]

ottlinger commented on PR #159: URL: https://github.com/apache/creadur-rat/pull/159#issuecomment-1789705372 > absolutely. if you have a standard setup I would gladly follow it. Perhaps it would make sense to add a checkstyle process to align the code base and keep it so. I proposed

Re: [PR] RAT-328 io supplier close issue [creadur-rat]

Claudenw closed pull request #162: RAT-328 io supplier close issue URL: https://github.com/apache/creadur-rat/pull/162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] RAT-328 io supplier close issue [creadur-rat]

Claudenw opened a new pull request, #162: URL: https://github.com/apache/creadur-rat/pull/162 Fix for RAT-328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] RAT-328 io supplier close issue [creadur-rat]

Claudenw commented on PR #162: URL: https://github.com/apache/creadur-rat/pull/162#issuecomment-1791279316 Wrong code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] RAT-328 Fix for IOSupplier issue includes javadoc updates [creadur-rat]

Claudenw opened a new pull request, #163: URL: https://github.com/apache/creadur-rat/pull/163 Ensured the System.out does not get closed and updated javadocs. Added class to allow others to wrap similar streams in a no close format. -- This is an automated message from the Apache

[PR] RAT-329 - Added md processing [creadur-rat]

Claudenw opened a new pull request, #164: URL: https://github.com/apache/creadur-rat/pull/164 Added md processing for inserting licenses. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]

ottlinger commented on PR #161: URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1792037119 Please make sure to rebase as changes came in via https://github.com/apache/creadur-rat/pull/163/files - thanks. -- This is an automated message from the Apache Git Service. To

Re: [PR] RAT-328 Fix for IOSupplier issue includes javadoc updates [creadur-rat]

ottlinger commented on PR #163: URL: https://github.com/apache/creadur-rat/pull/163#issuecomment-1792033798 Thanks for the fix, I'll add a changelog entry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] RAT-328 Fix for IOSupplier issue includes javadoc updates [creadur-rat]

ottlinger merged PR #163: URL: https://github.com/apache/creadur-rat/pull/163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]

jbonofre commented on PR #161: URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1792040351 I will but I need time : we have been hit by the storm and no electricity for now :/ -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]

Claudenw commented on PR #161: URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1792545538 I have a re based branch of JB's work. If you want I can submit that. On Fri, Nov 3, 2023, 09:29 JB Onofré ***@***.***> wrote: > I will but I need time : we have been hit

Re: [PR] RAT-329 - Added md and yaml processing [creadur-rat]

ottlinger commented on PR #164: URL: https://github.com/apache/creadur-rat/pull/164#issuecomment-1793733403 Cool enhancement - thanks :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] RAT-329 - Added md and yaml processing [creadur-rat]

ottlinger merged PR #164: URL: https://github.com/apache/creadur-rat/pull/164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] RAT-322: add option to be able to scan hidden directories and minor cleanups [creadur-rat]

Claudenw commented on code in PR #160: URL: https://github.com/apache/creadur-rat/pull/160#discussion_r1377179769 ## apache-rat-plugin/src/main/java/org/apache/rat/mp/RatCheckMojo.java: ## @@ -109,6 +118,7 @@ public void execute() throws MojoExecutionException,

Re: [PR] RAT-322: add option to be able to scan hidden directories and minor cleanups [creadur-rat]

jbonofre commented on code in PR #160: URL: https://github.com/apache/creadur-rat/pull/160#discussion_r1377225416 ## apache-rat-plugin/src/main/java/org/apache/rat/mp/RatCheckMojo.java: ## @@ -109,6 +118,7 @@ public void execute() throws MojoExecutionException,

Re: [PR] RAT-322: add option to be able to scan hidden directories and minor cleanups [creadur-rat]

Claudenw commented on code in PR #160: URL: https://github.com/apache/creadur-rat/pull/160#discussion_r1377291820 ## apache-rat-core/src/main/java/org/apache/rat/walker/DirectoryWalker.java: ## Review Comment: If you add the AbstractFileFilter then it is probably advisable

Re: [PR] RAT-322: add option to be able to scan hidden directories and minor cleanups [creadur-rat]

Claudenw commented on code in PR #160: URL: https://github.com/apache/creadur-rat/pull/160#discussion_r1377224154 ## apache-rat-plugin/src/main/java/org/apache/rat/mp/RatCheckMojo.java: ## @@ -109,6 +118,7 @@ public void execute() throws MojoExecutionException,

Re: [PR] RAT-322: add option to be able to scan hidden directories and minor cleanups [creadur-rat]

jbonofre commented on code in PR #160: URL: https://github.com/apache/creadur-rat/pull/160#discussion_r1377218838 ## apache-rat-plugin/src/main/java/org/apache/rat/mp/RatCheckMojo.java: ## @@ -109,6 +118,7 @@ public void execute() throws MojoExecutionException,

Re: [PR] RAT-322: add option to be able to scan hidden directories and minor cleanups [creadur-rat]

jbonofre commented on PR #160: URL: https://github.com/apache/creadur-rat/pull/160#issuecomment-1786512973 @ottlinger sure, I will :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] RAT-322: add option to be able to scan hidden directories and minor cleanups [creadur-rat]

Claudenw commented on code in PR #160: URL: https://github.com/apache/creadur-rat/pull/160#discussion_r1377289839 ## apache-rat-core/src/main/java/org/apache/rat/walker/DirectoryWalker.java: ## Review Comment: I agree. However, if we switch to

Re: [PR] RAT-322: add option to be able to scan hidden directories and minor cleanups [creadur-rat]

Claudenw commented on PR #160: URL: https://github.com/apache/creadur-rat/pull/160#issuecomment-1786697563 Thank you for the DirectoryWalkerTest. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] RAT-322: add option to be able to scan hidden directories and minor cleanups [creadur-rat]

jbonofre commented on code in PR #160: URL: https://github.com/apache/creadur-rat/pull/160#discussion_r1377217935 ## apache-rat-core/src/main/java/org/apache/rat/walker/DirectoryWalker.java: ## Review Comment: I'm not sure: I think it's already covered by the excludes. If

Re: [PR] RAT-321 cleanup of testing issues [creadur-rat]

ottlinger commented on PR #159: URL: https://github.com/apache/creadur-rat/pull/159#issuecomment-1783912504 @Claudenw tests are failing on windows nodes - I assume due to encoding issues do you see the test failure/GHA results? e.g.

Re: [PR] RAT-321 cleanup of testing issues [creadur-rat]

Claudenw commented on code in PR #159: URL: https://github.com/apache/creadur-rat/pull/159#discussion_r1375381748 ## pom.xml: ## @@ -59,8 +59,8 @@ agnostic home for software distribution comprehension and audit tools. 3.5.0 3.20.0 -0.16 -0.17-SNAPSHOT +

Re: [PR] RAT-322: add option to be able to scan hidden directories and minor cleanups [creadur-rat]

jbonofre commented on PR #160: URL: https://github.com/apache/creadur-rat/pull/160#issuecomment-1784632099 @ottlinger As discussed in Jira  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] RAT-322: add option to be able to scan hidden directories and minor cleanups [creadur-rat]

jbonofre opened a new pull request, #160: URL: https://github.com/apache/creadur-rat/pull/160 * add support to scan hidden directories flag to `DirectoryWalker` * add scan hidden directories to the `ReportConfiguration` * cleanup `Walker` moving `isRestricted` to the `DirectoryWalker`

Re: [PR] RAT-322: add option to be able to scan hidden directories and minor cleanups [creadur-rat]

ottlinger commented on PR #160: URL: https://github.com/apache/creadur-rat/pull/160#issuecomment-1785002625 @jbonofre can you add an entry in the changelog? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] RAT-322: add option to be able to scan hidden directories and minor cleanups [creadur-rat]

ottlinger commented on code in PR #160: URL: https://github.com/apache/creadur-rat/pull/160#discussion_r1375938723 ## apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java: ## @@ -194,7 +195,7 @@ public void addLicense(ILicense license) { * Adds multiple

Re: [PR] RAT-322: add option to be able to scan hidden directories and minor cleanups [creadur-rat]

ottlinger commented on PR #160: URL: https://github.com/apache/creadur-rat/pull/160#issuecomment-178486 @Claudenw is this in sync with what you proposed in RAT-323? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] RAT-322: add option to be able to scan hidden directories and minor cleanups [creadur-rat]

jbonofre commented on code in PR #160: URL: https://github.com/apache/creadur-rat/pull/160#discussion_r1375978739 ## apache-rat-core/src/main/java/org/apache/rat/ReportConfiguration.java: ## @@ -194,7 +195,7 @@ public void addLicense(ILicense license) { * Adds multiple

Re: [PR] RAT-322: add option to be able to scan hidden directories and minor cleanups [creadur-rat]

jbonofre commented on PR #160: URL: https://github.com/apache/creadur-rat/pull/160#issuecomment-1784902812 I quickly discussed with @Claudenw on Slack. I think it's aligned. As I detected issue in missing ASF headers in files located in hidden directories, it would be great to release a

Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]

ottlinger commented on PR #161: URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1787054660 Would it be possible to add a test for the newly created behaviour? (apart from the changelog entry ;)) I guess that the docs need to be updated, too: *

Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]

jbonofre commented on code in PR #161: URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1377878696 ## apache-rat-core/src/main/java/org/apache/rat/Report.java: ## @@ -349,29 +357,20 @@ private Report() { * @return the IReportale instance containing the

Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]

jbonofre commented on PR #161: URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1787582488 I will rebase and update accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]

Claudenw commented on code in PR #161: URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1377861349 ## apache-rat-core/src/main/java/org/apache/rat/Report.java: ## @@ -349,29 +357,20 @@ private Report() { * @return the IReportale instance containing the

Re: [PR] RAT-322: add option to be able to scan hidden directories and minor cleanups [creadur-rat]

jbonofre commented on code in PR #160: URL: https://github.com/apache/creadur-rat/pull/160#discussion_r1377878125 ## apache-rat-core/src/main/java/org/apache/rat/walker/DirectoryWalker.java: ## Review Comment: OK, let me update the PR then. Thanks. -- This is an

Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]

jbonofre commented on PR #161: URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1787127829 @ottlinger good points. Let me update the PR accordingly. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]

jbonofre commented on PR #161: URL: https://github.com/apache/creadur-rat/pull/161#issuecomment-1793374793 I should be back online today. So I will tackle that. Thanks ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] RAT-321 cleanup of testing issues [creadur-rat]

Claudenw opened a new pull request, #159: URL: https://github.com/apache/creadur-rat/pull/159 Several tests were failing but not being reported as failed. This fix addresses those. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] RAT-321 cleanup of testing issues [creadur-rat]

Claudenw commented on PR #159: URL: https://github.com/apache/creadur-rat/pull/159#issuecomment-1783841893 I had to change the github script to install the jars and then run the site build as a separate execution. In this way the site build works because it can find the core-test jar

[PR] RAT-320: Add -o/--output option to CLI [creadur-rat]

jbonofre opened a new pull request, #161: URL: https://github.com/apache/creadur-rat/pull/161 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] RAT-320: Add -o/--output option to CLI [creadur-rat]

jbonofre commented on code in PR #161: URL: https://github.com/apache/creadur-rat/pull/161#discussion_r1376539769 ## apache-rat-core/src/main/java/org/apache/rat/Report.java: ## @@ -349,29 +357,20 @@ private Report() { * @return the IReportale instance containing the

[GitHub] [creadur-tentacles] dependabot[bot] opened a new pull request, #84: Bump actions/setup-java from 3.12.0 to 3.13.0

dependabot[bot] opened a new pull request, #84: URL: https://github.com/apache/creadur-tentacles/pull/84 Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3.12.0 to 3.13.0. Release notes Sourced from

[GitHub] [creadur-rat] dependabot[bot] opened a new pull request, #156: Bump actions/setup-java from 3.12.0 to 3.13.0

dependabot[bot] opened a new pull request, #156: URL: https://github.com/apache/creadur-rat/pull/156 Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3.12.0 to 3.13.0. Release notes Sourced from

[GitHub] [creadur-whisker] dependabot[bot] opened a new pull request, #103: Bump actions/setup-java from 3.12.0 to 3.13.0

dependabot[bot] opened a new pull request, #103: URL: https://github.com/apache/creadur-whisker/pull/103 Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3.12.0 to 3.13.0. Release notes Sourced from

Re: [PR] RAT-321: text based configuration [creadur-rat]

Claudenw commented on PR #157: URL: https://github.com/apache/creadur-rat/pull/157#issuecomment-1752108298 I recognize that this is a massive change and will take some time to process. If you have any questions or want to see extra tests please let me know and I will endeavour to complete

[PR] Rat 321 text based configuration [creadur-rat]

Claudenw opened a new pull request, #157: URL: https://github.com/apache/creadur-rat/pull/157 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] WIP: RAT-259: Extract CLI class [creadur-rat]

Claudenw commented on PR #11: URL: https://github.com/apache/creadur-rat/pull/11#issuecomment-1767930119 If we merge #157 then we could close this merge request and focus on aligning the CLI, Maven, and ANT interfaces to ensure that they support the basic functionality defined in the

Re: [PR] RAT-321: text based configuration [creadur-rat]

Claudenw commented on PR #157: URL: https://github.com/apache/creadur-rat/pull/157#issuecomment-1768516412 @ottlinger how do we proceed? I do not have access to merge and I am unsure of the process to create a release so I think I need you to guide and/or execute this process. If you

Re: [PR] RAT-321: text based configuration [creadur-rat]

ottlinger commented on PR #157: URL: https://github.com/apache/creadur-rat/pull/157#issuecomment-1769177998 @Claudenw I'll start preparations for a new RC during the weekend (as the changelog and Jira needs some more attention before a new RC can be created). How would you summarize the

Re: [PR] RAT-321: text based configuration [creadur-rat]

ottlinger merged PR #157: URL: https://github.com/apache/creadur-rat/pull/157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] RAT-321: Fix for bad reporting of license status for non standard documents [creadur-rat]

ottlinger commented on PR #158: URL: https://github.com/apache/creadur-rat/pull/158#issuecomment-1774086790 I do not really now the exact difference between the two licenses but cannot find any official documentation about it - https://www.apache.org/licenses/LICENSE-2.0.html should be

Re: [PR] RAT-321: Fix for bad reporting of license status for non standard documents [creadur-rat]

ottlinger commented on PR #158: URL: https://github.com/apache/creadur-rat/pull/158#issuecomment-1774082790 As https://github.com/ottlinger/fotorenamer/pull/317 is a AL-licensed project I assume this would make sense to not break most of the existing RAT customers. -- This is an

Re: [PR] WIP: RAT-259: Extract CLI class [creadur-rat]

ottlinger closed pull request #11: WIP: RAT-259: Extract CLI class URL: https://github.com/apache/creadur-rat/pull/11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] RAT-321: Fix for bad reporting of license status for non standard documents [creadur-rat]

Claudenw commented on PR #158: URL: https://github.com/apache/creadur-rat/pull/158#issuecomment-1774080131 ASL licenses have copyright statements in them. I don't know who uses that difference but it was in the original code base. the name says that it is an "Applied Apache License" --

Re: [PR] RAT-321: Fix for bad reporting of license status for non standard documents [creadur-rat]

Claudenw commented on PR #158: URL: https://github.com/apache/creadur-rat/pull/158#issuecomment-1774085745 OK. So Licenses really don't have a unique category. AL and ASL should both report as AL. I can fix this fairly easily I think. -- This is an automated message from the Apache

Re: [PR] WIP: RAT-259: Extract CLI class [creadur-rat]

ottlinger commented on PR #11: URL: https://github.com/apache/creadur-rat/pull/11#issuecomment-1774087834 I'll close this PR as work performed in RAT-321 changed the way RAT can be configured. A new PR should adress the possibility to specify a list of files to be scanned via RAT's CLI.

[PR] Fix for bad reporting of license status for non standard documents [creadur-rat]

Claudenw opened a new pull request, #158: URL: https://github.com/apache/creadur-rat/pull/158 Fix for bad reporting of license status for non standard documents (e.g. binary). Collected license filtering into new LicenseSetFactory class and applied it where expected. Added more

Re: [PR] WIP: RAT-259: Extract CLI class [creadur-rat]

Claudenw commented on PR #11: URL: https://github.com/apache/creadur-rat/pull/11#issuecomment-1774078882 I think this was done in RAT-321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] RAT-321: Fix for bad reporting of license status for non standard documents [creadur-rat]

ottlinger commented on PR #158: URL: https://github.com/apache/creadur-rat/pull/158#issuecomment-1774078935 @Claudenw there seems to be a "breaking" change. ASL2-licensed files are marked as "ASL" in the report, although the report says: `Files with Apache License headers will be marked

Re: [PR] RAT-321: Fix for bad reporting of license status for non standard documents [creadur-rat]

Claudenw commented on PR #158: URL: https://github.com/apache/creadur-rat/pull/158#issuecomment-1774081160 In the earlier version the Applied license would only trigger if the copyright came after something that identified the Apache license. So the copyright had to be first. Because it

Re: [PR] RAT-321: Fix for bad reporting of license status for non standard documents [creadur-rat]

ottlinger commented on PR #158: URL: https://github.com/apache/creadur-rat/pull/158#issuecomment-1774088337 @Claudenw please use RAT-321 as prefix in your commits to properly get the commits accounted on the Jira ticket. Thanks. -- This is an automated message from the Apache Git

Re: [PR] RAT-321: Fix for bad reporting of license status for non standard documents [creadur-rat]

ottlinger commented on PR #158: URL: https://github.com/apache/creadur-rat/pull/158#issuecomment-1774077678 Thanks for the fix - I'll apply it and verify. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] RAT-321: Fix for bad reporting of license status for non standard documents [creadur-rat]

ottlinger merged PR #158: URL: https://github.com/apache/creadur-rat/pull/158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Bump com.fasterxml.jackson.module:jackson-module-jaxb-annotations from 2.15.2 to 2.15.3 [creadur-tentacles]

dependabot[bot] opened a new pull request, #85: URL: https://github.com/apache/creadur-tentacles/pull/85 Bumps [com.fasterxml.jackson.module:jackson-module-jaxb-annotations](https://github.com/FasterXML/jackson-modules-base) from 2.15.2 to 2.15.3. Commits

Re: [PR] Bump actions/setup-java from 3.12.0 to 3.13.0 [creadur-whisker]

ottlinger merged PR #103: URL: https://github.com/apache/creadur-whisker/pull/103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] TENTACLES-16: Bump com.fasterxml.jackson.module:jackson-module-jaxb-annotations from 2.15.2 to 2.15.3 [creadur-tentacles]

ottlinger merged PR #85: URL: https://github.com/apache/creadur-tentacles/pull/85 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] TENTACLES-16: Updates actions/cache from 3.3.1 to 3.3.2 [creadur-tentacles]

ottlinger merged PR #83: URL: https://github.com/apache/creadur-tentacles/pull/83 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] TENTACLES-16: Bump actions/setup-java from 3.12.0 to 3.13.0 [creadur-tentacles]

ottlinger merged PR #84: URL: https://github.com/apache/creadur-tentacles/pull/84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] RAT-321: text based configuration [creadur-rat]

ottlinger commented on PR #157: URL: https://github.com/apache/creadur-rat/pull/157#issuecomment-1764081462 @Claudenw if I get it correctly there are no functional changes of existing functionality. Thus I'd prefer to merge your changes and prepare a release of RAT in order to collect

Re: [PR] RAT-321: text based configuration [creadur-rat]

Claudenw commented on PR #157: URL: https://github.com/apache/creadur-rat/pull/157#issuecomment-1764200268 There are differences in the UI for Maven and Ant when not using the standard definitions. Preparing a release and collecting feedback seems like a viable path. I think we

Re: [PR] RAT-311: Bump actions/setup-java from 3.12.0 to 3.13.0 [creadur-rat]

ottlinger merged PR #156: URL: https://github.com/apache/creadur-rat/pull/156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   3   4   5   6   7   8   9   10   >