[GitHub] mbeckerle commented on a change in pull request #139: Updating to set encoding of CLI output to UTF-8

mbeckerle commented on a change in pull request #139: Updating to set encoding of CLI output to UTF-8 URL: https://github.com/apache/incubator-daffodil/pull/139#discussion_r234393091 ## File path: daffodil-cli/src/main/scala/org/apache/daffodil/Main.scala ## @@ -845,7

[GitHub] mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM.

mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM. URL: https://github.com/apache/incubator-daffodil/pull/140#discussion_r234391440 ## File path: build.sbt ## @@ -63,30 +63,33 @@ lazy val sapi =

[GitHub] mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM.

mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM. URL: https://github.com/apache/incubator-daffodil/pull/140#discussion_r234390740 ## File path:

[GitHub] mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM.

mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM. URL: https://github.com/apache/incubator-daffodil/pull/140#discussion_r234391723 ## File path:

[GitHub] mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM.

mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM. URL: https://github.com/apache/incubator-daffodil/pull/140#discussion_r234391661 ## File path:

[GitHub] mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM.

mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM. URL: https://github.com/apache/incubator-daffodil/pull/140#discussion_r234390499 ## File path:

[GitHub] mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM.

mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM. URL: https://github.com/apache/incubator-daffodil/pull/140#discussion_r234390316 ## File path:

[GitHub] mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM.

mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM. URL: https://github.com/apache/incubator-daffodil/pull/140#discussion_r234390231 ## File path:

[GitHub] mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM.

mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM. URL: https://github.com/apache/incubator-daffodil/pull/140#discussion_r234391470 ## File path: .gitignore ## @@ -36,6 +36,11 @@ daffodil-extra/* # ignore all

[GitHub] mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM.

mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM. URL: https://github.com/apache/incubator-daffodil/pull/140#discussion_r234390397 ## File path:

[GitHub] mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM.

mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM. URL: https://github.com/apache/incubator-daffodil/pull/140#discussion_r234391116 ## File path: daffodil-tdml/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala

[GitHub] mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM.

mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM. URL: https://github.com/apache/incubator-daffodil/pull/140#discussion_r234390675 ## File path:

[GitHub] mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM.

mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM. URL: https://github.com/apache/incubator-daffodil/pull/140#discussion_r234390928 ## File path: daffodil-tdml/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala

[GitHub] mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM.

mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM. URL: https://github.com/apache/incubator-daffodil/pull/140#discussion_r234389918 ## File path: build.sbt ## @@ -63,30 +63,33 @@ lazy val sapi =

[GitHub] mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM.

mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM. URL: https://github.com/apache/incubator-daffodil/pull/140#discussion_r234391067 ## File path: daffodil-tdml/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala

[GitHub] mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM.

mbeckerle commented on a change in pull request #140: TDML Runner and test changes for Cross Validation with IBM. URL: https://github.com/apache/incubator-daffodil/pull/140#discussion_r234390010 ## File path:

[GitHub] mbeckerle opened a new pull request #140: TDML Runner and test changes for Cross Validation with IBM.

mbeckerle opened a new pull request #140: TDML Runner and test changes for Cross Validation with IBM. URL: https://github.com/apache/incubator-daffodil/pull/140 This review goes with one that is outside of the Daffodil repo here: OpenDFDL/ibmDFDLCrossTester#1 This is a very

[GitHub] mbeckerle commented on issue #129: Cross Testing Capability with IBM DFDL

mbeckerle commented on issue #129: Cross Testing Capability with IBM DFDL URL: https://github.com/apache/incubator-daffodil/pull/129#issuecomment-439565861 I have incorporated all the feedback from this code review into the code base. However, the change set is quite large, and

[GitHub] mbeckerle commented on a change in pull request #129: Cross Testing Capability with IBM DFDL

mbeckerle commented on a change in pull request #129: Cross Testing Capability with IBM DFDL URL: https://github.com/apache/incubator-daffodil/pull/129#discussion_r234380997 ## File path: daffodil-tdml/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala ## @@

[GitHub] mbeckerle commented on a change in pull request #129: Cross Testing Capability with IBM DFDL

mbeckerle commented on a change in pull request #129: Cross Testing Capability with IBM DFDL URL: https://github.com/apache/incubator-daffodil/pull/129#discussion_r234380239 ## File path: daffodil-tdml/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala ## @@

[GitHub] mbeckerle commented on a change in pull request #129: Cross Testing Capability with IBM DFDL

mbeckerle commented on a change in pull request #129: Cross Testing Capability with IBM DFDL URL: https://github.com/apache/incubator-daffodil/pull/129#discussion_r234380037 ## File path: daffodil-tdml/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala ## @@ -89,44

[GitHub] mbeckerle commented on a change in pull request #129: Cross Testing Capability with IBM DFDL

mbeckerle commented on a change in pull request #129: Cross Testing Capability with IBM DFDL URL: https://github.com/apache/incubator-daffodil/pull/129#discussion_r234379500 ## File path: daffodil-propgen/src/main/resources/org/apache/daffodil/xsd/DFDL_part2_attributes.xsd

[GitHub] efinnegan commented on a change in pull request #139: Updating to set encoding of CLI output to UTF-8

efinnegan commented on a change in pull request #139: Updating to set encoding of CLI output to UTF-8 URL: https://github.com/apache/incubator-daffodil/pull/139#discussion_r234360650 ## File path: daffodil-cli/src/main/scala/org/apache/daffodil/Main.scala ## @@ -845,7

[GitHub] efinnegan opened a new pull request #139: Updating to set encoding of CLI output to UTF-8

efinnegan opened a new pull request #139: Updating to set encoding of CLI output to UTF-8 URL: https://github.com/apache/incubator-daffodil/pull/139 Without an encoding specified the system default is used for outputting the infoset in the CLI, which could result in unexpected output.

[jira] [Assigned] (DAFFODIL-2011) CLI should always use UTF-8 encoding when outputting the infoset

[ https://issues.apache.org/jira/browse/DAFFODIL-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elizabeth Fahl reassigned DAFFODIL-2011: Assignee: Elizabeth Fahl > CLI should always use UTF-8 encoding when

[jira] [Resolved] (DAFFODIL-1840) dfdl:initiator="%" does not cause a error or warning

[ https://issues.apache.org/jira/browse/DAFFODIL-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elizabeth Fahl resolved DAFFODIL-1840. -- Resolution: Fixed Fix Version/s: (was: 2.4.0) 2.3.0

[GitHub] efinnegan closed pull request #138: Adding error when dfdl:initiator is "%"

efinnegan closed pull request #138: Adding error when dfdl:initiator is "%" URL: https://github.com/apache/incubator-daffodil/pull/138 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[jira] [Resolved] (DAFFODIL-565) tolerate attributeFormDefault on xs:schema

[ https://issues.apache.org/jira/browse/DAFFODIL-565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elizabeth Fahl resolved DAFFODIL-565. - Resolution: Fixed Fix Version/s: 2.3.0 Fixed in commit

[GitHub] efinnegan closed pull request #136: Changing to ignore attributeFormDefault

efinnegan closed pull request #136: Changing to ignore attributeFormDefault URL: https://github.com/apache/incubator-daffodil/pull/136 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] mbeckerle commented on a change in pull request #138: Adding error when dfdl:initiator is "%"

mbeckerle commented on a change in pull request #138: Adding error when dfdl:initiator is "%" URL: https://github.com/apache/incubator-daffodil/pull/138#discussion_r234307323 ## File path:

[GitHub] mbeckerle commented on a change in pull request #138: Adding error when dfdl:initiator is "%"

mbeckerle commented on a change in pull request #138: Adding error when dfdl:initiator is "%" URL: https://github.com/apache/incubator-daffodil/pull/138#discussion_r234308617 ## File path: