mbeckerle commented on a change in pull request #214: Sequences and Separators
Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285797819
##
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/ChoiceGroup.scala
##
I think that is my point. We have a legacy format that defines non-standard
charsets that are used no where else, to the point where we are naming the
encoding based on the context in which it is used in a particular format. If we
want to think of DFDL as a general format description language,
I think the number and variety of these things is fairly small.
They're all about exactly 1 legacy data format, mil-std-6016, so that's not an
argument for a generalized facility. I doubt there are many more of them even
in that specification.
So I suggest we simply add these encodings as we
mbeckerle commented on a change in pull request #214: Sequences and Separators
Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285687800
##
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/ElementBase.scala
##
mbeckerle commented on a change in pull request #214: Sequences and Separators
Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285661559
##
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/ElementBase.scala
##
mbeckerle commented on a change in pull request #214: Sequences and Separators
Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285771432
##
File path:
daffodil-test-ibm1/src/test/resources/test-suite/ibm-contributed/dpaext1.tdml
mbeckerle commented on a change in pull request #214: Sequences and Separators
Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285728285
##
File path:
daffodil-propgen/src/main/scala/org/apache/daffodil/propGen/PropertyGenerator.scala
mbeckerle commented on a change in pull request #214: Sequences and Separators
Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285764233
##
File path:
mbeckerle commented on a change in pull request #214: Sequences and Separators
Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285736028
##
File path:
mbeckerle commented on a change in pull request #214: Sequences and Separators
Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285729326
##
File path:
mbeckerle commented on a change in pull request #214: Sequences and Separators
Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285689250
##
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/LocalElementMixin.scala
mbeckerle commented on a change in pull request #214: Sequences and Separators
Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285728026
##
File path:
mbeckerle commented on a change in pull request #214: Sequences and Separators
Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285734097
##
File path:
mbeckerle commented on a change in pull request #214: Sequences and Separators
Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285694312
##
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/ModelGroup.scala
##
mbeckerle commented on a change in pull request #214: Sequences and Separators
Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285767389
##
File path:
mbeckerle commented on a change in pull request #214: Sequences and Separators
Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285710834
##
File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/Term.scala
##
@@
mbeckerle commented on a change in pull request #214: Sequences and Separators
Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285725063
##
File path: daffodil-lib/src/main/scala/org/apache/daffodil/api/WarnID.scala
##
@@
mbeckerle commented on a change in pull request #214: Sequences and Separators
Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285725419
##
File path:
mbeckerle commented on a change in pull request #214: Sequences and Separators
Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285738792
##
File path:
mbeckerle commented on a change in pull request #214: Sequences and Separators
Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285687889
##
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/ElementBase.scala
##
mbeckerle commented on a change in pull request #214: Sequences and Separators
Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285657866
##
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/ChoiceGroup.scala
##
mbeckerle commented on a change in pull request #214: Sequences and Separators
Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285689883
##
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/LocalElementMixin.scala
Michael Beckerle created DAFFODIL-2132:
--
Summary: isKnownNotEmpty for delimiters is misused. Need
isKnownNonZeroLength for delimiters
Key: DAFFODIL-2132
URL:
Does it make sense to add support for defining these in schema? The charsets I
am adding are pretty speicific; and, questions of public disclosure aside, do
not really seem to fit in the global codebase. We can get away with doing this
since we happen to be Daffodil Devs, so there is a low
Thanks.
Do we require approval to include new link16 encodings in the public
repository? If not, can we include the dfi/dui as we are currently doing with
264:1?
From: Beckerle, Mike
Sent: Monday, May 20, 2019 12:57:41 PM
To: dev@daffodil.apache.org
Subject:
Michael Beckerle created DAFFODIL-2131:
--
Summary: isFixedLength and related methods in ElementBase need
cleanup
Key: DAFFODIL-2131
URL: https://issues.apache.org/jira/browse/DAFFODIL-2131
The encodings are in daffodil-io, and for these small charsets it's very very
easy to support them.
There is already a 6 bit charset for DFI 264 DUI 001, and also some 5-bit
encodings. All this was motivated by Link16.
Take a look at file X_DFDL_6_BIT_DFI_264_DUI_001.scala
In working on schema for mil-std-6016, I have discovered a 6 bit character
encoding that is distinct from the X-DFDL-US-ASCII-6-BIT-PACKED encoding we
already support. What would the process for supporting this be?
Brandon T. Sloane
Associate, Services
bslo...@tresys.com | tresys.com
Looks good to me
On Mon, May 20, 2019, 8:27 AM Beckerle, Mike wrote:
> No objections from me.
>
>
> From: Sloane, Brandon
> Sent: Monday, May 20, 2019 11:23:37 AM
> To: dev@daffodil.apache.org
> Subject: New commit to enumeration PR
>
> I know that this PR has
No objections from me.
From: Sloane, Brandon
Sent: Monday, May 20, 2019 11:23:37 AM
To: dev@daffodil.apache.org
Subject: New commit to enumeration PR
I know that this PR has already been reviewed, but when I rebased it back onto
the latest version of master, I
I know that this PR has already been reviewed, but when I rebased it back onto
the latest version of master, I discovered that it exposed a regression in
master.
There is now a second commit in the PR to fix this. Assuming no one objects, I
can squash this into the main enumerations commit.
The issue I am dealing with now is choiceDispathcKey="../branch", where
../branch is a valid path that that happens to contain the value of an
empty-string at runtime. At a minimum, this needs to be a runtime schema
definition error.
From: Beckerle, Mike
Sent:
Correct. Runtime SDE, same thing is true for delimiters. If they are "" at
runtime that is an SDE.
From: Sloane, Brandon
Sent: Monday, May 20, 2019 11:11:58 AM
To: dev@daffodil.apache.org
Subject: Re: Schema Definition Error vs Processing Error for empty
Nevermind that response. I thought we were still on the changes for a default
branch.
As for clarification that choiceDispatchKey="" is an SDE, I think that we
should just assume this is SDE. That is the conservative design choice.
From: Beckerle, Mike
Sent:
Ressurecting this thread, as this seems to be triggering a regression in the
enum support PR.
Has the DFDL workgroup responded?
From: Beckerle, Mike
Sent: Tuesday, April 30, 2019 3:16:54 PM
To: dev@daffodil.apache.org
Subject: Re: Schema Definition Error vs
35 matches
Mail list logo
