[PATCH 4/6] RHEVM unit tests: allow triggering of rerecording with env var VCR_RECORD

From: David Lutterkort Setting VCR_RECORD=all will rerecord the fixtures --- server/tests/drivers/rhevm/common.rb | 9 - server/tests/test_helper.rb | 8 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/server/tests/drivers/rhevm/common.rb b/server/tests

[PATCH 3/6] * server/tests/test_helper.rb: simplify defaulting of user/passeword/provider

From: David Lutterkort --- server/tests/test_helper.rb | 39 --- 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/server/tests/test_helper.rb b/server/tests/test_helper.rb index 61ee26d..55d2ff5 100644 --- a/server/tests/test_helper.rb +++ b/ser

[PATCH 5/6] * server/tests/test_helper.rb: allow accessing preferred items from config

From: David Lutterkort --- server/tests/test_helper.rb | 7 +++ 1 file changed, 7 insertions(+) diff --git a/server/tests/test_helper.rb b/server/tests/test_helper.rb index 9d37ccf..8bcb374 100644 --- a/server/tests/test_helper.rb +++ b/server/tests/test_helper.rb @@ -124,6 +124,13 @@ modul

Parametrize RHEV-M unit tests

These patches change things so that the RHEV-M tests do not depend on any hardcoded values. Rather, everything is now read from ~/.deltacloud/config. The new entries for rhevm in that file should be: rhevm: user: USERNAME password: PASSWORD provider: https://rhevm.example.co

[PATCH 1/6] RHEVM tests: have VCR match only on path and query, not full URI

From: David Lutterkort --- server/tests/drivers/rhevm/common.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/tests/drivers/rhevm/common.rb b/server/tests/drivers/rhevm/common.rb index 14a51f9..b3d3a63 100644 --- a/server/tests/drivers/rhevm/common.rb +++ b/server/t

[PATCH 2/6] RHEVM tests: do not record username/password/hostname with VCR

From: David Lutterkort --- server/tests/drivers/rhevm/common.rb | 8 1 file changed, 8 insertions(+) diff --git a/server/tests/drivers/rhevm/common.rb b/server/tests/drivers/rhevm/common.rb index b3d3a63..88d7d36 100644 --- a/server/tests/drivers/rhevm/common.rb +++ b/server/tests/dri

[jira] [Assigned] (DTACLOUD-487) Keypair support for ovirt backend

[ https://issues.apache.org/jira/browse/DTACLOUD-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph J. VLcek reassigned DTACLOUD-487: Assignee: Joseph J. VLcek > Keypair support for ovirt backend > -

[jira] [Closed] (DTACLOUD-229) DC returns 500 (unhandled exception) when EC2 instance is terminated

[ https://issues.apache.org/jira/browse/DTACLOUD-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph J. VLcek closed DTACLOUD-229. Resolution: Cannot Reproduce Assignee: Joseph J. VLcek This works for me. Closing:

[jira] [Closed] (DTACLOUD-239) unable to run the command rake package

[ https://issues.apache.org/jira/browse/DTACLOUD-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph J. VLcek closed DTACLOUD-239. Resolution: Cannot Reproduce Assignee: Joseph J. VLcek This works for me when follo

[jira] [Resolved] (DTACLOUD-241) floppyinject silently fails on RHEVM

[ https://issues.apache.org/jira/browse/DTACLOUD-241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph J. VLcek resolved DTACLOUD-241. -- Resolution: Cannot Reproduce Assignee: Joseph J. VLcek Closing this as no longe

Re: rake test in server/

On 03/07/2013 03:32 PM, David Lutterkort wrote: > On Thu, 2013-03-07 at 14:23 -0500, jvlcek wrote: >> The latest bits seem to run fine. See the attached. > What RUby version do you use ? Can you send me your Gemfile.lock ? keelhaul % ruby -v ruby 1.9.3p385 (2013-02-06 revision 39114) [x86_64-linux

Re: rake test in server/

On Thu, 2013-03-07 at 14:23 -0500, jvlcek wrote: > The latest bits seem to run fine. See the attached. What RUby version do you use ? Can you send me your Gemfile.lock ? > I believe the issue is the patch: > 0001-RHEVM-tests-have-VCR-match-only-on-path-and-query-no.path > the match_request_on is

Re: rake test in server/

On 03/07/2013 02:23 PM, jvlcek wrote: > On 03/07/2013 12:49 PM, David Lutterkort wrote: >> On Thu, 2013-03-07 at 09:14 -0500, jvlcek wrote: >>> On 03/06/2013 08:31 PM, David Lutterkort wrote: Am I the only one who runs into errors running 'rake test' ? I've got a bunch of fixes that I'll

Re: [PATCH] SITE: Improvements Add white box unit test description.

Hi Joe, looks fine to me, couple comments: On Wed, 2013-03-06 at 17:49 -0500, jvl...@redhat.com wrote: > diff --git a/site/content/running-the-white-box-tests.md > b/site/content/running-the-white-box-tests.md > new file mode 100644 > index 000..542cd34 > --- /dev/null > +++ b/site/content/r

Re: rake test in server/

On 03/07/2013 12:49 PM, David Lutterkort wrote: > On Thu, 2013-03-07 at 09:14 -0500, jvlcek wrote: >> On 03/06/2013 08:31 PM, David Lutterkort wrote: >>> Am I the only one who runs into errors running 'rake test' ? I've got a >>> bunch of fixes that I'll send out in a minute, but I still get errors

Re: SITE: Improvements Add white box unit test description.

Thank you for the git rebase help Marios! The rebased patch is available at: http://tracker.deltacloud.org/set/379 Thanks again! Joe V. On 03/07/2013 03:10 AM, mar...@redhat.com wrote: > Hey Joe - thanks this is great - though I've only done a visual > inspection as the patches won't apply a

Re: rake test in server/

On Thu, 2013-03-07 at 09:14 -0500, jvlcek wrote: > On 03/06/2013 08:31 PM, David Lutterkort wrote: > > Am I the only one who runs into errors running 'rake test' ? I've got a > > bunch of fixes that I'll send out in a minute, but I still get errors > > from test:drivers:rhevm - seems like the fixtu

Re: rake test in server/

On 03/06/2013 08:31 PM, David Lutterkort wrote: > Am I the only one who runs into errors running 'rake test' ? I've got a > bunch of fixes that I'll send out in a minute, but I still get errors > from test:drivers:rhevm - seems like the fixtures need to be rerecorded. > > Can others run rake test s

[jira] [Commented] (DTACLOUD-476) Ruby Client gem is missing: deltacloud-client.gemspec doc/

[ https://issues.apache.org/jira/browse/DTACLOUD-476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13595904#comment-13595904 ] Michal Fojtik commented on DTACLOUD-476: I completely removed the 'doc' director

[jira] [Resolved] (DTACLOUD-481) Digitalocean driver: Can't delete an STOPPED instance - delete op advertized on a RUNNING instance only

[ https://issues.apache.org/jira/browse/DTACLOUD-481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michal Fojtik resolved DTACLOUD-481. Resolution: Fixed Assignee: Michal Fojtik Nice one, state machine fixed: http://tr

[jira] [Resolved] (DTACLOUD-482) Digitalocean driver: Required to pass image_id, realm_is and hwp_id to create an instance - missing any errors out

[ https://issues.apache.org/jira/browse/DTACLOUD-482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michal Fojtik resolved DTACLOUD-482. Resolution: Fixed Assignee: Michal Fojtik Hi, It is perfectly fine to errors out w

[jira] [Commented] (DTACLOUD-503) Digitalocean: GET /api/realms/realm_id always returns the first realm

[ https://issues.apache.org/jira/browse/DTACLOUD-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13595888#comment-13595888 ] Michal Fojtik commented on DTACLOUD-503: Correction: http://tracker.deltacloud.

[jira] [Closed] (DTACLOUD-496) /api/addresses returns 500 when cimi frontend is also enabled

[ https://issues.apache.org/jira/browse/DTACLOUD-496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michal Fojtik closed DTACLOUD-496. -- Resolution: Duplicate Assignee: Michal Fojtik This is a duplicate of https://issues.apa

[jira] [Commented] (DTACLOUD-503) Digitalocean: GET /api/realms/realm_id always returns the first realm

[ https://issues.apache.org/jira/browse/DTACLOUD-503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13595884#comment-13595884 ] Michal Fojtik commented on DTACLOUD-503: Fix here: http://tracker.deltacloud.org

[jira] [Resolved] (DTACLOUD-503) Digitalocean: GET /api/realms/realm_id always returns the first realm

[ https://issues.apache.org/jira/browse/DTACLOUD-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michal Fojtik resolved DTACLOUD-503. Resolution: Fixed > Digitalocean: GET /api/realms/realm_id always returns the first r

[PATCH core] DigitalOcean: Fix filtering of realms (DTACLOUD-503)

From: Michal Fojtik Signed-off-by: Michal fojtik --- server/lib/deltacloud/drivers/digitalocean/digitalocean_driver.rb | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/server/lib/deltacloud/drivers/digitalocean/digitalocean_driver.rb b/server/lib/deltacloud/drivers/d

[jira] [Assigned] (DTACLOUD-503) Digitalocean: GET /api/realms/realm_id always returns the first realm

[ https://issues.apache.org/jira/browse/DTACLOUD-503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michal Fojtik reassigned DTACLOUD-503: -- Assignee: Michal Fojtik > Digitalocean: GET /api/realms/realm_id always returns t

[jira] [Commented] (DTACLOUD-507) Possible conflict of Deltacloud model classes with Rails classes

[ https://issues.apache.org/jira/browse/DTACLOUD-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13595865#comment-13595865 ] Michal Fojtik commented on DTACLOUD-507: Fix available here: http://tracker.delt

[PATCH core 5/5] Core: Updated travis to run deltacloud-client tests

From: Michal Fojtik Signed-off-by: Michal fojtik --- .travis.yml | 6 ++ 1 file changed, 6 insertions(+) diff --git a/.travis.yml b/.travis.yml index 9651c9a..e720039 100644 --- a/.travis.yml +++ b/.travis.yml @@ -11,7 +11,13 @@ install: - cd server - bundle install - bin/deltacl

Complete rewrite of deltacloud-client

Good news everyone! I started a complete rewrite of the deltacloud-client component of Deltacloud core repo few week ago, because: 1. Too much *magic* in the current client (meta-programming, etc) 2. No documentation (see 1)) 3. Hard to navigate in code and fix bugs (see 1,2) 4. Hard to add colle

[PATCH core 2/3] Core: Moved Deltacloud models to Deltacloud:: namespace (DTACLOUD-507)

From: Michal Fojtik Signed-off-by: Michal fojtik --- server/lib/deltacloud/api.rb | 11 +- server/lib/deltacloud/collections/images.rb| 2 +- server/lib/deltacloud/collections/instances.rb | 4 +- server/lib/deltacloud/drivers/base_driver.rb | 1 +

[PATCH core 3/3] Core: Fixed tests to use Deltacloud::MODEL

From: Michal Fojtik Signed-off-by: Michal fojtik --- .../deltacloud/collections/instances_collection_test.rb| 5 - server/tests/deltacloud/common.rb | 2 +- server/tests/drivers/ec2/buckets_test.rb | 2 +- server/tests/drivers/ec2/images_te

[PATCH core 1/3] Core: make 'turn' to report colored dots

From: Michal Fojtik Signed-off-by: Michal fojtik --- server/tests/test_helper.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/server/tests/test_helper.rb b/server/tests/test_helper.rb index 61ee26d..b0184f3 100644 --- a/server/tests/test_helper.rb +++ b/server/tests/test_helper.rb @@ -2

[jira] [Commented] (DTACLOUD-506) The core_ext extensions override Rails some methods

[ https://issues.apache.org/jira/browse/DTACLOUD-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13595798#comment-13595798 ] Michal Fojtik commented on DTACLOUD-506: Fix for this issue: http://tracker.del

[PATCH core] Core: re-use core_ext methods in String if they exists (DTACLOUD-506)

From: Michal Fojtik Signed-off-by: Michal fojtik --- server/lib/deltacloud/core_ext/array.rb | 1 + server/lib/deltacloud/core_ext/integer.rb | 22 ++ server/lib/deltacloud/core_ext/string.rb | 73 +++ 3 files changed, 59 insertions(+), 37 deletions(-)

Re: CIMI::Models split to CIMI::Services (rev 2) WIP

On 03/06, David Lutterkort wrote: > On Mon, 2013-03-04 at 10:57 +0100, Michal Fojtik wrote: > > On 03/01, David Lutterkort wrote: > > > On Fri, 2013-03-01 at 14:40 +0100, Michal Fojtik wrote: > > > > - ResourceMetada are now broken and need to be fixed. > > > > (an informative warning included ;-

Re: CIMI::Models split to CIMI::Services (rev 2) WIP

On 03/06, David Lutterkort wrote: > On Wed, 2013-03-06 at 15:41 +0100, Michal Fojtik wrote: > > On 03/05, David Lutterkort wrote: > > > I've addressed that issue and uploaded a new patch series > > > ( http://tracker.deltacloud.org/set/368 ) > > > > For some reason, all patches have empty body :-)

Re: Revamp how we setup the DB and misc fixes

On 03/06, lut...@redhat.com wrote: ACK && pushed. -- MIchal > > These are mostly minor fixes, especially to address some breakage I had > because I am using rerun. > > The major change in these patches is that all tests now run in the test > environemnt, and that they run against an (empty)

[jira] [Created] (DTACLOUD-507) Possible conflict of Deltacloud model classes with Rails classes

Michal Fojtik created DTACLOUD-507: -- Summary: Possible conflict of Deltacloud model classes with Rails classes Key: DTACLOUD-507 URL: https://issues.apache.org/jira/browse/DTACLOUD-507 Project: Delta

[jira] [Created] (DTACLOUD-506) The core_ext extensions override Rails some methods

Michal Fojtik created DTACLOUD-506: -- Summary: The core_ext extensions override Rails some methods Key: DTACLOUD-506 URL: https://issues.apache.org/jira/browse/DTACLOUD-506 Project: DeltaCloud

Re: SITE: Improvements Add white box unit test description.

Hey Joe - thanks this is great - though I've only done a visual inspection as the patches won't apply after I pushed the fixes for DTACLOUD-478/479 - once you rebase I'll push to site, thanks, marios On 07/03/13 00:49, jvl...@redhat.com wrote: > This patch adds the section "Validate contribution