Re: CDI Query import

2013-06-26 Thread Thomas Hug
Ok, starting to prepare a commit - still some small cleanups to do (like
making rat happy :) but should be ready soon.

Summarizing some of the previous discussions:
- it should go into a dedicated module
- which is named 'data' (discussion happened some time ago, but we had not
many votes on any name AFAIR)

BTW, saw that the root POM still refers to the incubation URLs.

On Sat, Jun 22, 2013 at 9:23 AM, Ove Ranheim oranh...@gmail.com wrote:

 Hi Mark,

 In what timeframe would CDI Query be imported as a module to Deltaspike?

 Is the final name elected to be Data?

 Ove

 On Jun 16, 2013, at 8:39 AM, Mark Struberg strub...@yahoo.de wrote:

  Hi Thomas, great stuff.
 
  Give us plz a few days to review and do the necessary preparations for
 the import.
  I've seen you have an ASF iCLA on file already, so this part should be
 fine ;)
 
  LieGrue,
  strub
 
 
 
 
  - Original Message -
  From: Thomas Hug thomas@gmail.com
  To: dev@deltaspike.apache.org dev@deltaspike.apache.org
  Cc:
  Sent: Friday, 14 June 2013, 11:55
  Subject: CDI Query import
 
  Hey all
 
  Any suggestions on how to proceed with the CDI Query import? So far we
 have
  - a proposal on the API [1]
  - a cleaned out branch depending on DS core and PartialBeans, running on
  the JBoss, TomEE and Glassfish profiles [2]
  - a reasonable amount of documentation [3]
  So what'd be next, anything still to adapt/missing?
 
  [1] https://cwiki.apache.org/DeltaSpike/repository-drafts.html
  [2] https://github.com/ctpconsulting/query/tree/dsimport
  [3] https://github.com/ctpconsulting/query/tree/dsimport#readme
 




Re: CDI Query import

2013-06-16 Thread Arne Limburg
Hi Thomas,

Great work so far. I just browsed through the doc and add two minor
corrections (see my pull request).

Will take a look at the code now.

Also I have some suggestions for features, but I guess I can add them
myself, once we have added this to deltaspike

Cheers,
Arne

Am 14.06.13 11:55 schrieb Thomas Hug unter thomas@gmail.com:

Hey all

Any suggestions on how to proceed with the CDI Query import? So far we
have
- a proposal on the API [1]
- a cleaned out branch depending on DS core and PartialBeans, running on
the JBoss, TomEE and Glassfish profiles [2]
- a reasonable amount of documentation [3]
So what'd be next, anything still to adapt/missing?

[1] https://cwiki.apache.org/DeltaSpike/repository-drafts.html
[2] https://github.com/ctpconsulting/query/tree/dsimport
[3] https://github.com/ctpconsulting/query/tree/dsimport#readme



Re: CDI Query import

2013-06-14 Thread Thomas Andraschko
sorry for this question, i didn't read other posts but why can't this be
used on a plain servlet container?


2013/6/14 Karl Kildén karl.kil...@gmail.com

 Sorry if I missed out on some of the discussions about this but I think the
 lack of support for a plain servlet container is a big disappointment and a
 big loss of potential users in my immediate network.

 I really like the module though, can't wait etc. Thanks for doing it

 Cheers


 2013/6/14 Thomas Hug thomas@gmail.com

  Hey all
 
  Any suggestions on how to proceed with the CDI Query import? So far we
 have
  - a proposal on the API [1]
  - a cleaned out branch depending on DS core and PartialBeans, running on
  the JBoss, TomEE and Glassfish profiles [2]
  - a reasonable amount of documentation [3]
  So what'd be next, anything still to adapt/missing?
 
  [1] https://cwiki.apache.org/DeltaSpike/repository-drafts.html
  [2] https://github.com/ctpconsulting/query/tree/dsimport
  [3] https://github.com/ctpconsulting/query/tree/dsimport#readme
 



Re: CDI Query import

2013-06-14 Thread Karl Kildén
Hi Thomas! I got that from the third link (temp docs)

In order to use the DeltaSpike data module, you have to run your
application in a Java EE container supporting at least the Java EE 6 Web
Profile. Other configurations like running it inside Tomcat or even a Java
SE application are possible but currently not supported.

cheers


2013/6/14 Thomas Andraschko andraschko.tho...@gmail.com

 sorry for this question, i didn't read other posts but why can't this be
 used on a plain servlet container?


 2013/6/14 Karl Kildén karl.kil...@gmail.com

  Sorry if I missed out on some of the discussions about this but I think
 the
  lack of support for a plain servlet container is a big disappointment
 and a
  big loss of potential users in my immediate network.
 
  I really like the module though, can't wait etc. Thanks for doing it
 
  Cheers
 
 
  2013/6/14 Thomas Hug thomas@gmail.com
 
   Hey all
  
   Any suggestions on how to proceed with the CDI Query import? So far we
  have
   - a proposal on the API [1]
   - a cleaned out branch depending on DS core and PartialBeans, running
 on
   the JBoss, TomEE and Glassfish profiles [2]
   - a reasonable amount of documentation [3]
   So what'd be next, anything still to adapt/missing?
  
   [1] https://cwiki.apache.org/DeltaSpike/repository-drafts.html
   [2] https://github.com/ctpconsulting/query/tree/dsimport
   [3] https://github.com/ctpconsulting/query/tree/dsimport#readme
  
 



Re: CDI Query import

2013-06-14 Thread Thomas Andraschko
AFAICS it's just based on JPA and CDI, right?



2013/6/14 Thomas Hug thomas@gmail.com

 Hey Karl
 I don't see a reason this should not work even with e.g. Weld SE - but I
 basically wanted to say that I have neither tried it nor is it CI tested so
 far ;-)
 Something we can put on the todo list to have the Weld and OWB profile
 running as well.


 On Fri, Jun 14, 2013 at 1:58 PM, John D. Ament john.d.am...@gmail.com
 wrote:

  Karl,
 
  Maybe you could give it a try and let us know if it works? You'd need at
  least JPA, CDI runtime to get it working.
 
 
  On Fri, Jun 14, 2013 at 7:40 AM, Karl Kildén karl.kil...@gmail.com
  wrote:
 
   Hi Thomas! I got that from the third link (temp docs)
  
   In order to use the DeltaSpike data module, you have to run your
   application in a Java EE container supporting at least the Java EE 6
 Web
   Profile. Other configurations like running it inside Tomcat or even a
  Java
   SE application are possible but currently not supported.
  
   cheers
  
  
   2013/6/14 Thomas Andraschko andraschko.tho...@gmail.com
  
sorry for this question, i didn't read other posts but why can't this
  be
used on a plain servlet container?
   
   
2013/6/14 Karl Kildén karl.kil...@gmail.com
   
 Sorry if I missed out on some of the discussions about this but I
  think
the
 lack of support for a plain servlet container is a big
 disappointment
and a
 big loss of potential users in my immediate network.

 I really like the module though, can't wait etc. Thanks for doing
 it

 Cheers


 2013/6/14 Thomas Hug thomas@gmail.com

  Hey all
 
  Any suggestions on how to proceed with the CDI Query import? So
 far
   we
 have
  - a proposal on the API [1]
  - a cleaned out branch depending on DS core and PartialBeans,
  running
on
  the JBoss, TomEE and Glassfish profiles [2]
  - a reasonable amount of documentation [3]
  So what'd be next, anything still to adapt/missing?
 
  [1] https://cwiki.apache.org/DeltaSpike/repository-drafts.html
  [2] https://github.com/ctpconsulting/query/tree/dsimport
  [3] https://github.com/ctpconsulting/query/tree/dsimport#readme
 

   
  
 



Re: CDI Query import

2013-06-14 Thread Romain Manni-Bucau
Jpa-repository sounds fine as a jpa submodule for me
Le 14 juin 2013 19:56, John D. Ament john.d.am...@gmail.com a écrit :

 i thought it was a separate module from JPA at inception.


 On Fri, Jun 14, 2013 at 1:08 PM, Jason Porter lightguard...@gmail.com
 wrote:

  Sounds like we need to create a new module for this, or put it into the
 JPA
  module. Any objections for just doing the code dump into the jpa module?
 
 
  On Fri, Jun 14, 2013 at 6:40 AM, Thomas Hug thomas@gmail.com
 wrote:
 
   Valid point, thnx for the feedback!
  
  
   On Fri, Jun 14, 2013 at 2:30 PM, Karl Kildén karl.kil...@gmail.com
   wrote:
  
Hi,
   
Okay sounds good. I guess I interpreted it to it's worst meaning :-)
 I
would be glad to try to test it with a plain Tomcat during the coming
  two
weeks but sounds like it should work.
   
I think the final docs should be formulated a little different if you
   want
people to try it out and create bug reports with issues etc. At least
myself If I was on a plain tomcat and read that I would give up if I
  had
   an
issue.
   
   
2013/6/14 Thomas Hug thomas@gmail.com
   
 Hey Karl
 I don't see a reason this should not work even with e.g. Weld SE -
  but
   I
 basically wanted to say that I have neither tried it nor is it CI
   tested
so
 far ;-)
 Something we can put on the todo list to have the Weld and OWB
  profile
 running as well.


 On Fri, Jun 14, 2013 at 1:58 PM, John D. Ament 
  john.d.am...@gmail.com
 wrote:

  Karl,
 
  Maybe you could give it a try and let us know if it works? You'd
  need
at
  least JPA, CDI runtime to get it working.
 
 
  On Fri, Jun 14, 2013 at 7:40 AM, Karl Kildén 
  karl.kil...@gmail.com
  wrote:
 
   Hi Thomas! I got that from the third link (temp docs)
  
   In order to use the DeltaSpike data module, you have to run
 your
   application in a Java EE container supporting at least the Java
  EE
   6
 Web
   Profile. Other configurations like running it inside Tomcat or
   even a
  Java
   SE application are possible but currently not supported.
  
   cheers
  
  
   2013/6/14 Thomas Andraschko andraschko.tho...@gmail.com
  
sorry for this question, i didn't read other posts but why
  can't
this
  be
used on a plain servlet container?
   
   
2013/6/14 Karl Kildén karl.kil...@gmail.com
   
 Sorry if I missed out on some of the discussions about this
   but I
  think
the
 lack of support for a plain servlet container is a big
 disappointment
and a
 big loss of potential users in my immediate network.

 I really like the module though, can't wait etc. Thanks for
   doing
 it

 Cheers


 2013/6/14 Thomas Hug thomas@gmail.com

  Hey all
 
  Any suggestions on how to proceed with the CDI Query
  import?
   So
 far
   we
 have
  - a proposal on the API [1]
  - a cleaned out branch depending on DS core and
  PartialBeans,
  running
on
  the JBoss, TomEE and Glassfish profiles [2]
  - a reasonable amount of documentation [3]
  So what'd be next, anything still to adapt/missing?
 
  [1]
   https://cwiki.apache.org/DeltaSpike/repository-drafts.html
  [2] https://github.com/ctpconsulting/query/tree/dsimport
  [3]
https://github.com/ctpconsulting/query/tree/dsimport#readme
 

   
  
 

   
  
 
 
 
  --
  Jason Porter
  http://en.gravatar.com/lightguardjp
 



Re: CDI Query import

2013-06-14 Thread Gerhard Petracek
+1 for a separated module.

regards,
gerhard



2013/6/14 Romain Manni-Bucau rmannibu...@gmail.com

 Jpa-repository sounds fine as a jpa submodule for me
 Le 14 juin 2013 19:56, John D. Ament john.d.am...@gmail.com a écrit :

  i thought it was a separate module from JPA at inception.
 
 
  On Fri, Jun 14, 2013 at 1:08 PM, Jason Porter lightguard...@gmail.com
  wrote:
 
   Sounds like we need to create a new module for this, or put it into the
  JPA
   module. Any objections for just doing the code dump into the jpa
 module?
  
  
   On Fri, Jun 14, 2013 at 6:40 AM, Thomas Hug thomas@gmail.com
  wrote:
  
Valid point, thnx for the feedback!
   
   
On Fri, Jun 14, 2013 at 2:30 PM, Karl Kildén karl.kil...@gmail.com
wrote:
   
 Hi,

 Okay sounds good. I guess I interpreted it to it's worst meaning
 :-)
  I
 would be glad to try to test it with a plain Tomcat during the
 coming
   two
 weeks but sounds like it should work.

 I think the final docs should be formulated a little different if
 you
want
 people to try it out and create bug reports with issues etc. At
 least
 myself If I was on a plain tomcat and read that I would give up if
 I
   had
an
 issue.


 2013/6/14 Thomas Hug thomas@gmail.com

  Hey Karl
  I don't see a reason this should not work even with e.g. Weld SE
 -
   but
I
  basically wanted to say that I have neither tried it nor is it CI
tested
 so
  far ;-)
  Something we can put on the todo list to have the Weld and OWB
   profile
  running as well.
 
 
  On Fri, Jun 14, 2013 at 1:58 PM, John D. Ament 
   john.d.am...@gmail.com
  wrote:
 
   Karl,
  
   Maybe you could give it a try and let us know if it works?
 You'd
   need
 at
   least JPA, CDI runtime to get it working.
  
  
   On Fri, Jun 14, 2013 at 7:40 AM, Karl Kildén 
   karl.kil...@gmail.com
   wrote:
  
Hi Thomas! I got that from the third link (temp docs)
   
In order to use the DeltaSpike data module, you have to run
  your
application in a Java EE container supporting at least the
 Java
   EE
6
  Web
Profile. Other configurations like running it inside Tomcat
 or
even a
   Java
SE application are possible but currently not supported.
   
cheers
   
   
2013/6/14 Thomas Andraschko andraschko.tho...@gmail.com
   
 sorry for this question, i didn't read other posts but why
   can't
 this
   be
 used on a plain servlet container?


 2013/6/14 Karl Kildén karl.kil...@gmail.com

  Sorry if I missed out on some of the discussions about
 this
but I
   think
 the
  lack of support for a plain servlet container is a big
  disappointment
 and a
  big loss of potential users in my immediate network.
 
  I really like the module though, can't wait etc. Thanks
 for
doing
  it
 
  Cheers
 
 
  2013/6/14 Thomas Hug thomas@gmail.com
 
   Hey all
  
   Any suggestions on how to proceed with the CDI Query
   import?
So
  far
we
  have
   - a proposal on the API [1]
   - a cleaned out branch depending on DS core and
   PartialBeans,
   running
 on
   the JBoss, TomEE and Glassfish profiles [2]
   - a reasonable amount of documentation [3]
   So what'd be next, anything still to adapt/missing?
  
   [1]
https://cwiki.apache.org/DeltaSpike/repository-drafts.html
   [2]
 https://github.com/ctpconsulting/query/tree/dsimport
   [3]
 https://github.com/ctpconsulting/query/tree/dsimport#readme
  
 

   
  
 

   
  
  
  
   --
   Jason Porter
   http://en.gravatar.com/lightguardjp