[
http://issues.apache.org/jira/browse/DIRMINA-235?page=comments#action_12441948
]
Greg Duffy commented on DIRMINA-235:
You, sir, deserve a beer and a cookie for that one. Geez.
Reliable hang of DS during query
[
http://issues.apache.org/jira/browse/DIRMINA-277?page=comments#action_12440639
]
Greg Duffy commented on DIRMINA-277:
No biggie. Enjoy your holiday, and get around to it after the hangover wears
off :) It can wait.
I should have
[
http://issues.apache.org/jira/browse/DIRMINA-162?page=comments#action_12436125
]
Greg Duffy commented on DIRMINA-162:
Sorry about that! I tried my best to resist the format keystroke in Eclipse,
but I must have slipped up. I know how
[
http://issues.apache.org/jira/browse/DIRMINA-162?page=comments#action_12436127
]
Greg Duffy commented on DIRMINA-162:
I think the v7 version works for locking on startExpiringIfNotStarted, at least
when running the test case here.
The
[ http://issues.apache.org/jira/browse/DIRMINA-162?page=all ]
Greg Duffy updated DIRMINA-162:
---
Attachment: mina-datagram-session-management-v7.diff
Yargh. In this one (v7), I do the lock upgrade correctly in the
startExpiringIfNotStarted method of
[ http://issues.apache.org/jira/browse/DIRMINA-162?page=all ]
Greg Duffy updated DIRMINA-162:
---
Attachment: mina-datagram-session-management-v6.diff
Updated per Trustin's suggestions.
datagram session management fails
-
[
http://issues.apache.org/jira/browse/DIRMINA-162?page=comments#action_12434913
]
Greg Duffy commented on DIRMINA-162:
No problem, happy to lend a hand :) MINA makes my work easier, so it's more
than a fair trade.
I can get to patching
[
http://issues.apache.org/jira/browse/DIRMINA-162?page=comments#action_12434623
]
Greg Duffy commented on DIRMINA-162:
I always forget something after I hit 'submit'.
In ExpiringSessionRecycler, I liked your idea of using the List as the
[
http://issues.apache.org/jira/browse/DIRMINA-162?page=comments#action_12434628
]
Greg Duffy commented on DIRMINA-162:
And, in an astounding extra $0.02, I also wanted to remind you to update the
IoHandler javadoc since it indicates that
[
http://issues.apache.org/jira/browse/DIRMINA-162?page=comments#action_12433772
]
Greg Duffy commented on DIRMINA-162:
Great! I'm happy I could help. I'll leave the refactoring to you, since you
have a better view of the high level stuff.
[ http://issues.apache.org/jira/browse/DIRMINA-162?page=all ]
Greg Duffy updated DIRMINA-162:
---
Attachment: mina-datagram-session-management-v2.diff
Attached is the next version with IoSessionRecycler per Trustin's and my
comments. I still am not sure
[
http://issues.apache.org/jira/browse/DIRMINA-162?page=comments#action_12433566
]
Greg Duffy commented on DIRMINA-162:
Also, I could not find a good implementation of an expiring map, so I wrote my
own. Please review that code carefully
[ http://issues.apache.org/jira/browse/DIRMINA-162?page=all ]
Greg Duffy updated DIRMINA-162:
---
Attachment: mina-datagram-session-management-v3.diff
Minor change to build filter chain only when a session isn't recycled (save
some clocks :)
datagram
[ http://issues.apache.org/jira/browse/DIRMINA-162?page=all ]
Greg Duffy updated DIRMINA-162:
---
Attachment: mina-datagram-session-management.diff
Here's my first stab at fixing this. Could somebody please review it? I haven't
touched the MINA code before
[
http://issues.apache.org/jira/browse/DIRMINA-162?page=comments#action_12433326
]
Greg Duffy commented on DIRMINA-162:
Sorry to double post, but I also wonder what do about this (mentioned in
previous message):
The only current problem
[
http://issues.apache.org/jira/browse/DIRMINA-162?page=comments#action_1241
]
Greg Duffy commented on DIRMINA-162:
I did reply on this issue page, it's a few comments above, I guess I fooled you
with my '' marks :)
1. OK, I did not
16 matches
Mail list logo