[ http://issues.apache.org/jira/browse/DIRMINA-162?page=comments#action_12434913 ] Greg Duffy commented on DIRMINA-162: ------------------------------------
No problem, happy to lend a hand :) MINA makes my work easier, so it's more than a fair trade. I can get to patching the remaining stuff (IoHandler, defaulting to ExpiringSessionRecycler) within the next couple of days or so. I agree that ExpiringSessionRecycler should be the default now that I think about all the events flying around the filter chain with NOOP, and starting the expiration after the first put is a good compromise. Nice to have util-concurrent for that, since a double check lock is actually thread-safe with ReentrantReadWriteLock. Do you want me to add an IdentityHashMap for session lookup? It would mean extra synchronization, and it would affect only the 'remove(IoSession)' method AFAIK. Are the costs to generate the key high enough to justify that? > datagram session management fails > --------------------------------- > > Key: DIRMINA-162 > URL: http://issues.apache.org/jira/browse/DIRMINA-162 > Project: Directory MINA > Issue Type: Bug > Affects Versions: 0.9 > Reporter: Rainer Bieniek > Assigned To: Trustin Lee > Priority: Minor > Fix For: 1.0 > > Attachments: mina-datagram-session-management-v2.diff, > mina-datagram-session-management-v3.diff, > mina-datagram-session-management-v4.diff, > mina-datagram-session-management-v5.diff, > mina-datagram-session-management.diff > > > As of mina 0.9.0 the session management does not work in various ways: > - a new session is created per received package. The worker thread does not > cache created session but only assign the select key to the session and drops > it after processing the package. It would be better to attach the session to > the RegistrationRequest and check it while processing the received package. > - the provided IoFilterChainBuilder does get applied to the created datagram > session. It is cached in the RegistrationRequest but not used on the session > - The sessionClose lifecycle event is not applied on the session either. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
