Re: [directory-server] 01/02: Bumped up ehcache version to 3.6.1

2019-03-30 Thread Emmanuel Lécharny
On 30/03/2019 09:38, Stefan Seelmann wrote: On 1/21/19 5:04 AM, Emmanuel Lécharny wrote: On 21/01/2019 03:16, Richard Sand wrote: HI guys - I cloned master to start swapping the ehcahe3 to caffeine. But because caffeine is actually a bit more similar to ehcache2, I’m thinking of going back t

Re: [directory-server] 01/02: Bumped up ehcache version to 3.6.1

2019-03-30 Thread Stefan Seelmann
On 1/21/19 5:04 AM, Emmanuel Lécharny wrote: > > On 21/01/2019 03:16, Richard Sand wrote: >> HI guys - >> >> I cloned master to start swapping the ehcahe3 to caffeine. But because >> caffeine is actually a bit more similar to ehcache2, I’m thinking of >> going back to AM25 and starting from there.

Re: [directory-server] 01/02: Bumped up ehcache version to 3.6.1

2019-01-20 Thread Emmanuel Lécharny
On 21/01/2019 03:16, Richard Sand wrote: HI guys - I cloned master to start swapping the ehcahe3 to caffeine. But because caffeine is actually a bit more similar to ehcache2, I’m thinking of going back to AM25 and starting from there. What do you think? Sure ! There are not that many chan

Re: [directory-server] 01/02: Bumped up ehcache version to 3.6.1

2019-01-20 Thread Richard Sand
HI guys - I cloned master to start swapping the ehcahe3 to caffeine. But because caffeine is actually a bit more similar to ehcache2, I’m thinking of going back to AM25 and starting from there. What do you think? Best regards, Richard > On Jan 11, 2019, at 5:31 PM, Emmanuel Lécharny wrote:

Re: [directory-server] 01/02: Bumped up ehcache version to 3.6.1

2019-01-12 Thread Richard Sand
Caffeine has a jsr-107 adapter - we could do jsr-107 and provide a default caffeine implementation and configuration, wdyt? Sent from my iPhone > On Jan 11, 2019, at 5:31 PM, Emmanuel Lécharny wrote: > > >> On 11/01/2019 23:11, Stefan Seelmann wrote: >> On 1/6/19 3:18 AM, Stefan Seelmann wrot

Re: [directory-server] 01/02: Bumped up ehcache version to 3.6.1

2019-01-11 Thread Emmanuel Lécharny
On 11/01/2019 23:11, Stefan Seelmann wrote: On 1/6/19 3:18 AM, Stefan Seelmann wrote: Also the server build now fails with Java 11. That's because ehcache 3 uses JAXB (I assume to load XML config), but JAXB was removed from Java SE in 11. Solution is to add JAXB dependency. Would be nice to av

Re: [directory-server] 01/02: Bumped up ehcache version to 3.6.1

2019-01-11 Thread Richard Sand
I haven’t but I’ll give it a shot this weekend and keep you posted Sent from my iPhone > On Jan 11, 2019, at 5:11 PM, Stefan Seelmann wrote: > > On 1/6/19 3:18 AM, Stefan Seelmann wrote: >>> Also the server build now fails with Java 11. That's because ehcache 3 >>> uses JAXB (I assume to load X

Re: [directory-server] 01/02: Bumped up ehcache version to 3.6.1

2019-01-11 Thread Stefan Seelmann
On 1/6/19 3:18 AM, Stefan Seelmann wrote: >> Also the server build now fails with Java 11. That's because ehcache 3 >> uses JAXB (I assume to load XML config), but JAXB was removed from Java >> SE in 11. Solution is to add JAXB dependency. Would be nice to avoid that. I give up. I searched and tri

Re: [directory-server] 01/02: Bumped up ehcache version to 3.6.1

2019-01-05 Thread Stefan Seelmann
On 1/5/19 8:40 PM, Stefan Seelmann wrote: > Maybe it's the perfect time, because I'm struggling with using ApacheDS > with ehcache3 in Studio, OSGi related issues. This is fixed now. I had to downgrade to version 3.5.3, see https://github.com/ehcache/ehcache3/issues/2554 for details. But I'd real

Re: [directory-server] 01/02: Bumped up ehcache version to 3.6.1

2019-01-05 Thread Stefan Seelmann
Maybe it's the perfect time, because I'm struggling with using ApacheDS with ehcache3 in Studio, OSGi related issues. Also the server build now fails with Java 11. That's because ehcache 3 uses JAXB (I assume to load XML config), but JAXB was removed from Java SE in 11. Solution is to add JAXB dep

Re: [directory-server] 01/02: Bumped up ehcache version to 3.6.1

2019-01-05 Thread Richard Sand
Want me to open a pull request for jsr107 and a default caffeine impl? Or is this not the time -Richard > On Jan 5, 2019, at 1:42 AM, Emmanuel Lécharny wrote: > > >> On 05/01/2019 03:05, Richard Sand wrote: >> Sorry I should have brought that up at the start! >> >> When have you planned to i

Re: [directory-server] 01/02: Bumped up ehcache version to 3.6.1

2019-01-04 Thread Emmanuel Lécharny
On 05/01/2019 03:05, Richard Sand wrote: Sorry I should have brought that up at the start! When have you planned to implement jsr-107? We haven't... This came quite late  (2014) and we even haven't discussed about it yet :-) Having gone through this exercise, I think abstracting ehcach

Re: [directory-server] 01/02: Bumped up ehcache version to 3.6.1

2019-01-04 Thread Richard Sand
Sorry I should have brought that up at the start! When have you planned to implement jsr-107? Having gone through this exercise, I think abstracting ehcache from the code is a good idea. Also I checked out Caffeine and tested it in my company’s product, so far it seems good as a lightweight loc

Re: [directory-server] 01/02: Bumped up ehcache version to 3.6.1

2019-01-04 Thread Emmanuel Lécharny
On 05/01/2019 00:45, Stefan Seelmann wrote: On 1/4/19 8:05 AM, elecha...@apache.org wrote: diff --git a/kerberos-codec/src/test/java/org/apache/directory/server/kerberos/shared/replay/ReplayCacheImplTest.java b/kerberos-codec/src/test/java/org/apache/directory/server/kerberos/shared/replay/

Re: [directory-server] 01/02: Bumped up ehcache version to 3.6.1

2019-01-04 Thread Stefan Seelmann
On 1/4/19 8:05 AM, elecha...@apache.org wrote: > diff --git > a/kerberos-codec/src/test/java/org/apache/directory/server/kerberos/shared/replay/ReplayCacheImplTest.java > > b/kerberos-codec/src/test/java/org/apache/directory/server/kerberos/shared/replay/ReplayCacheImplTest.java > index 33d6c2e.