[dpdk-dev] [PATCH] maintainers: claim responsability for xen

2016-11-11 Thread Tan, Jianfeng
Hi Thomas and Konrad, On 11/11/2016 2:59 AM, Konrad Rzeszutek Wilk wrote: > On Wed, Nov 9, 2016 at 5:03 PM, Thomas Monjalon > wrote: >> 2016-11-07 07:38, Jianfeng Tan: >>> As some users are still using xen as the hypervisor, I suggest to >>> continue support for xen in DPDK. And from 16.11, I

[dpdk-dev] [PATCH 2/2] examples/tep_term: Fix packet len for multi-seg mbuf

2016-10-24 Thread Tan, Jianfeng
> -Original Message- > From: Michael Qiu [mailto:qdy220091330 at gmail.com] > Sent: Tuesday, October 18, 2016 1:49 PM > To: dev at dpdk.org > Cc: Tan, Jianfeng; Michael Qiu > Subject: [PATCH 2/2] examples/tep_term: Fix packet len for multi-seg mbuf > >

[dpdk-dev] [PATCH 1/2] examples/tep_term: Fix l4_len issue

2016-10-24 Thread Tan, Jianfeng
> -Original Message- > From: Michael Qiu [mailto:qdy220091330 at gmail.com] > Sent: Tuesday, October 18, 2016 1:49 PM > To: dev at dpdk.org > Cc: Tan, Jianfeng; Michael Qiu > Subject: [PATCH 1/2] examples/tep_term: Fix l4_len issue > > l4_len is not fixed, althro

[dpdk-dev] [PATCH] pdump: fix dir permissions value in mkdir call

2016-10-13 Thread Tan, Jianfeng
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Reshma Pattan > Sent: Monday, October 10, 2016 10:36 PM > To: dev at dpdk.org > Cc: Pattan, Reshma > Subject: [dpdk-dev] [PATCH] pdump: fix dir permissions value in mkdir call > > From: Reshma Pattan > >

[dpdk-dev] 17.02 Roadmap

2016-10-13 Thread Tan, Jianfeng
Hi Thomas, On 10/11/2016 4:42 AM, Thomas Monjalon wrote: > Thanks Tim for the interesting inputs. > Some of them may require a dedicated thread to continue the discussion > based on some preliminary specifications or drafts. [...] >> Interrupt Mode Support in Virtio PMD: Support for interrupt

[dpdk-dev] [RFC][PATCH V2 1/3] examples/vhost: Add vswitch (generic switch) framework

2016-09-13 Thread Tan, Jianfeng
Hi Pankaj, On 9/12/2016 6:55 PM, Pankaj Chauhan wrote: > On 9/9/2016 2:26 PM, Tan, Jianfeng wrote: >> Hi Pankaj, >> >> Thanks for the massive and great work. > > Hi Jianfeng, > > Thanks for the review. >> >> On 9/5/2016 6:54 PM, Pankaj Chauhan wrote:

[dpdk-dev] [PATCH 1/2] examples/tep_term: fix offload on VXLAN failure

2016-09-13 Thread Tan, Jianfeng
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Monday, September 12, 2016 5:36 PM > To: Tan, Jianfeng; Yuanhan Liu > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/2] examples/tep_term: fix offload on > VX

[dpdk-dev] [PATCH 1/2] examples/tep_term: fix offload on VXLAN failure

2016-09-12 Thread Tan, Jianfeng
Hi Yuanhan, > -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Sunday, September 11, 2016 8:09 PM > To: Tan, Jianfeng > Cc: dev at dpdk.org; Ananyev, Konstantin; Wu, Jingjing; Kavanagh, Mark B; > Thomas Monjalon > Subject: Re:

[dpdk-dev] [RFC] igb_uio: deprecate iomem and ioport mapping

2016-09-09 Thread Tan, Jianfeng
Hi David, Thank you for reviewing this. On 9/9/2016 5:06 PM, David Marchand wrote: > Hello Jianfeng, > > On Thu, Sep 1, 2016 at 4:16 AM, Jianfeng Tan > wrote: >> Previously in igb_uio, iomem is mapped, and both ioport and io mem >> are recorded into uio framework, which is duplicated and makes

[dpdk-dev] [RFC][PATCH V2 1/3] examples/vhost: Add vswitch (generic switch) framework

2016-09-09 Thread Tan, Jianfeng
Hi Pankaj, Thanks for the massive and great work. On 9/5/2016 6:54 PM, Pankaj Chauhan wrote: > Introduce support for a generic framework for handling of switching between > physical and vhost devices. The vswitch framework introduces the following > concept: > > 1. vswitch_dev: Vswitch device is

[dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages

2016-09-09 Thread Tan, Jianfeng
On 9/9/2016 2:03 PM, Yuanhan Liu wrote: >> GET_PROTOCOL_FEATURES >> is not supported yet. I see those features in PROTOCOL_FEATURES is for live >> migration (right?). > Not exactly. PROTOCOL_FEATURES was firstly introduced while MQ was > enabled. Thus it's no wonder MQ is the first protocol

[dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages

2016-09-09 Thread Tan, Jianfeng
On 9/9/2016 12:19 PM, Yuanhan Liu wrote: >> >> >> Never mind, above fix on the vhost side will not take effect on >> existing >> vpp-vhost implementations. >> >> Actually, I was talking about the DPDK vhost implementation :) >> >> >> This patch is talking about vpp's

[dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages

2016-09-09 Thread Tan, Jianfeng
On 9/8/2016 8:18 PM, Yuanhan Liu wrote: > On Thu, Sep 08, 2016 at 04:53:22PM +0800, Tan, Jianfeng wrote: >> >> On 9/6/2016 4:20 PM, Yuanhan Liu wrote: >>> On Tue, Sep 06, 2016 at 03:54:30PM +0800, Tan, Jianfeng wrote: >>>> Hi Yuanhan, >>>>

[dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages

2016-09-08 Thread Tan, Jianfeng
On 9/6/2016 4:20 PM, Yuanhan Liu wrote: > On Tue, Sep 06, 2016 at 03:54:30PM +0800, Tan, Jianfeng wrote: >> Hi Yuanhan, >> >> >> On 9/6/2016 2:42 PM, Yuanhan Liu wrote: >>> On Fri, Aug 05, 2016 at 11:36:42AM +, Jianfeng Tan wrote: >>>> When

[dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages

2016-09-06 Thread Tan, Jianfeng
Hi Yuanhan, On 9/6/2016 2:42 PM, Yuanhan Liu wrote: > On Fri, Aug 05, 2016 at 11:36:42AM +, Jianfeng Tan wrote: >> When virtio_user is used with VPP's native vhost user, it cannot >> send/receive any packets. >> >> The root cause is that vpp-vhost-user translates the message >>

[dpdk-dev] virtio kills qemu VM after stopping/starting ports

2016-09-05 Thread Tan, Jianfeng
Hi, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tan, Jianfeng > Sent: Friday, September 2, 2016 8:54 PM > To: Kyle Larose; dev at dpdk.org > Cc: Xie, Huawei; yuanhan.liu at linux.intel.com > Subject: Re: [dpdk-dev] virtio kills qemu

[dpdk-dev] [RFC] igb_uio: deprecate iomem and ioport mapping

2016-09-02 Thread Tan, Jianfeng
On 9/2/2016 8:31 PM, Ferruh Yigit wrote: > On 9/1/2016 3:16 AM, Jianfeng Tan wrote: >> Previously in igb_uio, iomem is mapped, and both ioport and io mem >> are recorded into uio framework, which is duplicated and makes the >> code too complex. >> >> For iomem, DPDK user space code never opens

[dpdk-dev] virtio kills qemu VM after stopping/starting ports

2016-09-02 Thread Tan, Jianfeng
Hi Kyle, On 9/2/2016 8:35 PM, Kyle Larose wrote: > >> -Original Message- >> From: Tan, Jianfeng [mailto:jianfeng.tan at intel.com] >> Sent: Friday, September 02, 2016 2:56 AM >> To: Kyle Larose; dev at dpdk.org >> Cc: huawei.xie at intel.com; yuanhan.liu

[dpdk-dev] virtio kills qemu VM after stopping/starting ports

2016-09-02 Thread Tan, Jianfeng
Hi Kyle, On 9/2/2016 4:53 AM, Kyle Larose wrote: > Hello everyone, > > In my own testing, I recently stumbled across an issue where I could get qemu > to exit when sending traffic to my application. To do this, I simply needed > to do the following: > > 1) Start my virtio interfaces > 2) Send

[dpdk-dev] vhost [query] : support for multiple ports and non VMDQ devices in vhost switch

2016-08-18 Thread Tan, Jianfeng
Hi Maxime, > -Original Message- > From: Maxime Coquelin [mailto:maxime.coquelin at redhat.com] > Sent: Thursday, August 18, 2016 3:43 PM > To: Tan, Jianfeng; Yuanhan Liu; Pankaj Chauhan > Cc: dev at dpdk.org; hemant.agrawal at nxp.com; shreyansh.jain at nxp.com > Subj

[dpdk-dev] vhost [query] : support for multiple ports and non VMDQ devices in vhost switch

2016-08-18 Thread Tan, Jianfeng
Hi Maxime, On 8/17/2016 7:18 PM, Maxime Coquelin wrote: > Hi Jianfeng, > > On 08/17/2016 04:33 AM, Tan, Jianfeng wrote: >> Hi, >> >> Please review below proposal of Pankaj and myself after an offline >> discussion. (Pankaj, please correct me if I'm going som

[dpdk-dev] [PATCH] examples/vhost: remove VLAN strip option

2016-08-18 Thread Tan, Jianfeng
Hi Maxime, > -Original Message- > From: Maxime Coquelin [mailto:maxime.coquelin at redhat.com] > Sent: Thursday, August 18, 2016 3:52 PM > To: Tan, Jianfeng; dev at dpdk.org > Cc: yuanhan.liu at linux.intel.com > Subject: Re: [dpdk-dev] [PATCH] examples/vhost: remove

[dpdk-dev] vhost [query] : support for multiple ports and non VMDQ devices in vhost switch

2016-08-17 Thread Tan, Jianfeng
Hi, Please review below proposal of Pankaj and myself after an offline discussion. (Pankaj, please correct me if I'm going somewhere wrong). a. Remove HW dependent option, --strip-vlan, because different kinds of NICs behave differently. It's a bug fix. b. Abstract switching logic into a

[dpdk-dev] [PATCH 2/3] net/virtio_user: fix wrong sequence of messages

2016-08-08 Thread Tan, Jianfeng
Hi Stephen, > -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Saturday, August 6, 2016 12:36 AM > To: Tan, Jianfeng > Cc: dev at dpdk.org; yuanhan.liu at linux.intel.com; Wang, Zhihong; > lining18 at jd.com > Subject: Re:

[dpdk-dev] [PATCH 3/3] net/virtio_user: fix dev not freed after init error

2016-08-08 Thread Tan, Jianfeng
Hi Stephen, > -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Saturday, August 6, 2016 12:34 AM > To: Tan, Jianfeng > Cc: dev at dpdk.org; yuanhan.liu at linux.intel.com; Wang, Zhihong; > lining18 at jd.com > Subject: Re:

[dpdk-dev] [PATCH v3] i40: fix the VXLAN TSO issue

2016-07-29 Thread Tan, Jianfeng
Hi, On 7/18/2016 7:56 PM, Zhe Tao wrote: > Problem: > When using the TSO + VXLAN feature in i40e, the outer UDP length fields in > the multiple UDP segments which are TSOed by the i40e will have a > wrong value. > > Fix this problem by adding the tunnel type field in the i40e descriptor > which

[dpdk-dev] [PATCH v3] i40: fix the VXLAN TSO issue

2016-07-29 Thread Tan, Jianfeng
> -Original Message- > From: Ananyev, Konstantin > Sent: Friday, July 29, 2016 4:46 PM > To: Tan, Jianfeng; dev at dpdk.org > Cc: Wu, Jingjing > Subject: RE: [dpdk-dev] [PATCH v3] i40: fix the VXLAN TSO issue > > Hi Jianfeng, > > > > > Hi, >

[dpdk-dev] [PATCH v3] i40: fix the VXLAN TSO issue

2016-07-26 Thread Tan, Jianfeng
Hi Konstantin, On 7/19/2016 6:29 PM, Ananyev, Konstantin wrote: > >> Problem: >> When using the TSO + VXLAN feature in i40e, the outer UDP length fields in >> the multiple UDP segments which are TSOed by the i40e will >> have a wrong value. >> >> Fix this problem by adding the tunnel type

[dpdk-dev] [PATCH v2] examples/vhost: fix perf regression

2016-07-21 Thread Tan, Jianfeng
Self-Nack this patch because the commit log needs change further. > -Original Message- > From: Tan, Jianfeng > Sent: Thursday, July 21, 2016 8:24 AM > To: dev at dpdk.org > Cc: yuanhan.liu at linux.intel.com; Wang, Zhihong; Xu, Qian Q; Tan, Jianfeng > Subject: [PATCH

[dpdk-dev] [PATCH] examples/vhost: fix perf regression

2016-07-20 Thread Tan, Jianfeng
On 7/20/2016 2:13 PM, Yuanhan Liu wrote: > On Wed, Jul 20, 2016 at 01:50:34PM +0800, Tan, Jianfeng wrote: >> >> On 7/20/2016 12:38 PM, Yuanhan Liu wrote: >>> On Tue, Jul 19, 2016 at 01:53:11PM +, Jianfeng Tan wrote: >>>> We find significant perferm

[dpdk-dev] [PATCH] examples/vhost: fix perf regression

2016-07-20 Thread Tan, Jianfeng
On 7/20/2016 12:38 PM, Yuanhan Liu wrote: > On Tue, Jul 19, 2016 at 01:53:11PM +, Jianfeng Tan wrote: >> We find significant perfermance drop introduced by below commit, >> when vhost example is started with --mergeable 0 and inside vm, >> kernel virtio-net driver is used to do ip based

[dpdk-dev] [PATCH] examples/vhost: fix perf regression

2016-07-20 Thread Tan, Jianfeng
Hi Yuanhan, On 7/20/2016 9:44 AM, Yuanhan Liu wrote: > On Tue, Jul 19, 2016 at 01:53:11PM +, Jianfeng Tan wrote: >> We find significant perfermance drop introduced by below commit, >> when vhost example is started with --mergeable 0 and inside vm, >> kernel virtio-net driver is used to do ip

[dpdk-dev] [PATCH] doc: fix vhost setup in tep-termination app guide

2016-07-20 Thread Tan, Jianfeng
Hi Mark, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Mark Kavanagh > Sent: Tuesday, July 19, 2016 11:32 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] doc: fix vhost setup in tep-termination app > guide > > - Fix vhost setup flags > - Add minor

[dpdk-dev] [PATCH] virtio: fix packet corruption

2016-07-19 Thread Tan, Jianfeng
Hi Oliver, > -Original Message- > From: Olivier Matz [mailto:olivier.matz at 6wind.com] > Sent: Tuesday, July 19, 2016 10:00 PM > To: Tan, Jianfeng; dev at dpdk.org; Xie, Huawei; yuanhan.liu at > linux.intel.com > Subject: Re: [PATCH] virtio: fix packet corruption >

[dpdk-dev] [PATCH] virtio: fix packet corruption

2016-07-19 Thread Tan, Jianfeng
> -Original Message- > From: Olivier Matz [mailto:olivier.matz at 6wind.com] > Sent: Tuesday, July 19, 2016 9:11 PM > To: Tan, Jianfeng; dev at dpdk.org; Xie, Huawei; yuanhan.liu at > linux.intel.com > Subject: Re: [PATCH] virtio: fix packet corruption > > Hi

[dpdk-dev] [PATCH] virtio: fix packet corruption

2016-07-19 Thread Tan, Jianfeng
Hi Oliver, > -Original Message- > From: Olivier Matz [mailto:olivier.matz at 6wind.com] > Sent: Tuesday, July 19, 2016 8:32 PM > To: dev at dpdk.org; Tan, Jianfeng; Xie, Huawei; yuanhan.liu at > linux.intel.com > Subject: [PATCH] virtio: fix packet corruption > &g

[dpdk-dev] Possible Bug: DPDK 16.04 Empty packet_type

2016-07-06 Thread Tan, Jianfeng
Hi, On 7/6/2016 3:54 AM, Craig, Chris A. wrote: > We recently upgraded our environment to the 16.04 version of DPDK on a 14.04 > installation of Ubuntu. After upgrading, we noticed our code was behaving > oddly. After further inspection, we discovered the `packet_type` attribute of > the

[dpdk-dev] [PATCH 1/4] net/virtio-user: fix return value not checked

2016-07-05 Thread Tan, Jianfeng
Hi Yuanhan, > -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Friday, July 1, 2016 10:16 AM > To: Tan, Jianfeng > Cc: dev at dpdk.org; Xie, Huawei; Mcnamara, John > Subject: Re: [PATCH 1/4] net/virtio-user: fix return value not c

[dpdk-dev] [PATCH] eal: add option --avail-cores to detect lcores

2016-07-01 Thread Tan, Jianfeng
Hi Thomas, > > > > > > Looking at your special case, if the user did set an isolcpus option > > > for another use, with no -c/-l, I understand the dpdk application > > > won't care too much about it. > > > So, this seems like somehow rude to the rest of the system and > unwanted. > > > > The case

[dpdk-dev] [PATCH v9 3/6] virtio-user: add vhost user adapter layer

2016-06-24 Thread Tan, Jianfeng
Hi Yigit, > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, June 23, 2016 5:02 PM > To: Tan, Jianfeng; dev at dpdk.org > Cc: Xie, Huawei; rich.lane at bigswitch.com; yuanhan.liu at linux.intel.com; > mst at redhat.com; nakajima.yoshihiro at lab.

[dpdk-dev] [PATCH] net/virtio-user: fix implicit int to enum conversion

2016-06-24 Thread Tan, Jianfeng
Hi Stephen, > -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Friday, June 24, 2016 4:51 AM > To: Tan, Jianfeng > Cc: dev at dpdk.org; yuanhan.liu at linux.intel.com; Xie, Huawei > Subject: Re: [dpdk-dev] [PATCH] net/virtio-

[dpdk-dev] Assembly code

2016-06-22 Thread Tan, Jianfeng
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Mahdi Moradmand > Badie > Sent: Wednesday, June 22, 2016 5:21 AM > To: dev at dpdk.org > Subject: [dpdk-dev] Assembly code > > Dear All, > > I used the default format of Makefile (as follow) which is

[dpdk-dev] [PATCH] virtio: fix allocating virtnet_rx not mem aligned

2016-06-13 Thread Tan, Jianfeng
On 6/13/2016 5:21 PM, Yuanhan Liu wrote: > On Sun, Jun 12, 2016 at 02:29:42PM +, Jianfeng Tan wrote: >> Compile DPDK with clang, below line in virtio_rxtx.c could be >> optimized with four "VMOVAPS ymm, m256". >>memset(>fake_mbuf, 0, sizeof(rxvq->fake_mbuf)); >> >> This instruction

[dpdk-dev] [PATCH v2 4/4] virtio-user: handle ctrl-q in driver

2016-06-13 Thread Tan, Jianfeng
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Monday, June 13, 2016 6:14 PM > To: Tan, Jianfeng > Cc: dev at dpdk.org; rich.lane at bigswitch.com; mst at redhat.com; > nakajima.yoshihiro at lab.ntt.co.jp; p.fe

[dpdk-dev] [PATCH] virtio: fix allocating virtnet_rx not mem aligned

2016-06-13 Thread Tan, Jianfeng
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Monday, June 13, 2016 5:52 PM > To: Tan, Jianfeng > Cc: dev at dpdk.org; Xie, Huawei > Subject: Re: [dpdk-dev] [PATCH] virtio: fix allocating virtnet_rx not mem > aligned >

[dpdk-dev] [PATCH] virito: fix reuse index in nested loop

2016-06-13 Thread Tan, Jianfeng
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Monday, June 13, 2016 4:58 PM > To: Tan, Jianfeng > Cc: dev at dpdk.org; Xie, Huawei > Subject: Re: [PATCH] virito: fix reuse index in nested loop > > On Sun, Jun 12,

[dpdk-dev] [PATCH v5 0/6] Virtio-net PMD: QEMU QTest extension for container

2016-06-06 Thread Tan, Jianfeng
Hi, On 6/6/2016 5:30 PM, Tetsuya Mukawa wrote: > On 2016/06/06 17:49, Yuanhan Liu wrote: >> On Mon, Jun 06, 2016 at 05:33:31PM +0900, Tetsuya Mukawa wrote: > [My solution] > - Pros > Basic principle of my implementation is not to reinvent the wheel. Yes, that's a good point.

[dpdk-dev] [PATCH v5 0/6] Virtio-net PMD: QEMU QTest extension for container

2016-06-06 Thread Tan, Jianfeng
Hi, On 6/6/2016 5:28 PM, Tetsuya Mukawa wrote: > On 2016/06/06 17:03, Tan, Jianfeng wrote: >> Hi, >> >> >> On 6/6/2016 1:10 PM, Tetsuya Mukawa wrote: >>> Hi Yuanhan, >>> >>> Sorry for late replying. >>> >>> On 2016/06/03

[dpdk-dev] [PATCH v6 6/7] virtio-user: add new virtual pci driver for virtio

2016-06-06 Thread Tan, Jianfeng
Hi Yuanhan, On 6/6/2016 4:01 PM, Yuanhan Liu wrote: > On Thu, Jun 02, 2016 at 09:54:36AM +, Jianfeng Tan wrote: >> + >> +desc_addr = (uint64_t)vq->mz->addr; >> +avail_addr = desc_addr + vq->vq_nentries * sizeof(struct vring_desc); >> +used_addr = RTE_ALIGN_CEIL(avail_addr +

[dpdk-dev] [PATCH v5 0/6] Virtio-net PMD: QEMU QTest extension for container

2016-06-06 Thread Tan, Jianfeng
Hi, On 6/6/2016 1:10 PM, Tetsuya Mukawa wrote: > Hi Yuanhan, > > Sorry for late replying. > > On 2016/06/03 13:17, Yuanhan Liu wrote: >> On Thu, Jun 02, 2016 at 06:30:18PM +0900, Tetsuya Mukawa wrote: >>> Hi Yuanhan, >>> >>> On 2016/06/02 16:31, Yuanhan Liu wrote: But still, I'd ask do we

[dpdk-dev] [PATCH v5 7/8] virtio-user: add a new vdev named virtio-user

2016-06-02 Thread Tan, Jianfeng
Hi Yuanhan, On 6/1/2016 4:26 PM, Yuanhan Liu wrote: > On Mon, May 30, 2016 at 10:55:38AM +, Jianfeng Tan wrote: >> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c >> b/drivers/net/virtio/virtio_user/virtio_user_dev.c >> index 41d8ad1..5e4f60b 100644 >> ---

[dpdk-dev] [PATCH v5 2/8] virtio: clean up virtio_dev_queue_setup

2016-06-01 Thread Tan, Jianfeng
Hi Yuanhan, > -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Wednesday, June 1, 2016 3:38 PM > To: Tan, Jianfeng > Cc: dev at dpdk.org; Xie, Huawei; rich.lane at bigswitch.com; mst at > redhat.com; > nakajima.yoshihiro at l

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-05-31 Thread Tan, Jianfeng
Hi, On 5/30/2016 8:24 PM, Ilya Maximets wrote: > On 30.05.2016 15:00, Tan, Jianfeng wrote: >> Hi, >> >>> -Original Message- >>> From: Ilya Maximets [mailto:i.maximets at samsung.com] >>> Sent: Friday, May 20, 2016 8:50 PM >>> To: dev a

[dpdk-dev] about rx checksum flags

2016-05-31 Thread Tan, Jianfeng
Hi Oliver, On 5/30/2016 11:26 PM, Olivier Matz wrote: > Hi, > > I'm planning to add the support for offloads in virtio-net pmd. > It appears that the current rx flags in mbuf are not sufficient to > describe the state of a packet received from a virtual driver. > I think we need a way to say

[dpdk-dev] [PATCH] vhost: fix segfault on bad descriptor address.

2016-05-30 Thread Tan, Jianfeng
Hi, > -Original Message- > From: Ilya Maximets [mailto:i.maximets at samsung.com] > Sent: Friday, May 20, 2016 8:50 PM > To: dev at dpdk.org; Xie, Huawei; Yuanhan Liu > Cc: Dyasly Sergey; Heetae Ahn; Tan, Jianfeng; Ilya Maximets > Subject: [PATCH] vhost: fix segfault

[dpdk-dev] [PATCH] eal: add option --avail-cores to detect lcores

2016-05-19 Thread Tan, Jianfeng
Hi David, On 5/18/2016 8:46 PM, David Marchand wrote: > Hello Jianfeng, > > On Wed, Mar 9, 2016 at 2:05 PM, Panu Matilainen > wrote: >> On 03/08/2016 07:38 PM, Tan, Jianfeng wrote: >>> Hi Panu, >>> >>> On 3/8/2016 4:54 PM, Panu Matilainen wrote: &g

[dpdk-dev] [PATCH v4] eal: make hugetlb initialization more robust

2016-05-19 Thread Tan, Jianfeng
Hi Thomas & Sergio, On 5/18/2016 4:06 PM, Sergio Gonzalez Monroy wrote: > On 17/05/2016 17:40, Thomas Monjalon wrote: >> 2016-05-12 00:44, Jianfeng Tan: >>> This patch adds an option, --huge-trybest, to use a recover >>> mechanism to >>> the case that there are not so many hugepages (declared

[dpdk-dev] [PATCH v4] eal: make hugetlb initialization more robust

2016-05-19 Thread Tan, Jianfeng
Hi David, On 5/18/2016 12:39 AM, David Marchand wrote: > Hello Jianfeng, > > On Thu, May 12, 2016 at 2:44 AM, Jianfeng Tan > wrote: >> This patch adds an option, --huge-trybest, to use a recover mechanism to >> the case that there are not so many hugepages (declared in sysfs), which >> can be

[dpdk-dev] [PATCH v4 6/8] virtio-user: add new virtual pci driver for virtio

2016-05-16 Thread Tan, Jianfeng
Hi Yuanhan, > -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Friday, May 13, 2016 12:45 PM > To: Tan, Jianfeng > Cc: dev at dpdk.org; Xie, Huawei; rich.lane at bigswitch.com; mst at > redhat.com; > nakajima.yoshihiro at l

[dpdk-dev] [PATCH v4 6/8] virtio-user: add new virtual pci driver for virtio

2016-05-13 Thread Tan, Jianfeng
Hi Michael, On 5/13/2016 1:02 AM, Michael S. Tsirkin wrote: > On Thu, May 12, 2016 at 03:08:05PM +0800, Tan, Jianfeng wrote: >> (2) It's more aligned to previous logic to hide the detail to differentiate >> modern/legacy device. > Why is there a need to support legacy interf

[dpdk-dev] [PATCH v4 6/8] virtio-user: add new virtual pci driver for virtio

2016-05-13 Thread Tan, Jianfeng
On 5/13/2016 12:40 AM, Yuanhan Liu wrote: > On Thu, May 12, 2016 at 03:08:05PM +0800, Tan, Jianfeng wrote: >>>> +static int >>>> +vdev_setup_queue(struct virtio_hw *hw __rte_unused, struct virtqueue *vq) >>>> +{ >>>> + /* Changed to use virtua

[dpdk-dev] [PATCH v4 6/8] virtio-user: add new virtual pci driver for virtio

2016-05-12 Thread Tan, Jianfeng
Hi yuanhan, On 5/12/2016 10:12 AM, Yuanhan Liu wrote: > On Fri, Apr 29, 2016 at 01:18:34AM +, Jianfeng Tan wrote: >> +static void >> +vdev_read_dev_config(struct virtio_hw *hw, uint64_t offset, >> + void *dst, int length) >> +{ >> +int i; >> +struct virtio_user_hw

[dpdk-dev] [PATCH v3] eal: make hugetlb initialization more robust

2016-05-10 Thread Tan, Jianfeng
Hi Sergio, > -Original Message- > From: Gonzalez Monroy, Sergio > Sent: Tuesday, May 10, 2016 4:55 PM > To: Tan, Jianfeng; dev at dpdk.org > Cc: david.marchand at 6wind.com; nhorman at tuxdriver.com > Subject: Re: [PATCH v3] eal: make hugetlb initialization more robust &

[dpdk-dev] [PATCH v2] virtio: fix modify drv_flags for specific device

2016-05-09 Thread Tan, Jianfeng
Hi David and Yuanhan, > -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Thursday, May 5, 2016 7:18 AM > To: Tan, Jianfeng > Cc: David Marchand; dev at dpdk.org; Xie, Huawei > Subject: Re: [PATCH v2] virtio: fix modify drv_flags f

[dpdk-dev] [PATCH v3 1/2] virtio: cleanup virtio_dev_queue_setup()

2016-05-09 Thread Tan, Jianfeng
Hi Yuanhan, > -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Thursday, May 5, 2016 11:20 AM > To: Tan, Jianfeng > Cc: dev at dpdk.org; Xie, Huawei > Subject: Re: [PATCH v3 1/2] virtio: cleanup virtio_dev_queue_setup() > > On

[dpdk-dev] [PATCH 0/2] mempool: add stack (fifo) mempool handler

2016-05-06 Thread Tan, Jianfeng
Hi David, On 5/6/2016 2:29 AM, David Hunt wrote: > This patch set adds a fifo stack handler to the external mempool > manager. Just a minor confusion for me. Usually, we refer stack as LIFO and queue as FIFO. So is there any particular reason why we call "stack (fifo)" here? Thanks, Jianfeng

[dpdk-dev] [PATCH v3 2/2] virtio: fix memory leak of virtqueue memzones

2016-05-05 Thread Tan, Jianfeng
Hi Yuanhan, > -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Thursday, May 5, 2016 11:28 AM > To: Tan, Jianfeng > Cc: dev at dpdk.org; Xie, Huawei > Subject: Re: [dpdk-dev] [PATCH v3 2/2] virtio: fix memory leak of virtqueue &g

[dpdk-dev] [PATCH v2] eal: make hugetlb initialization more robust

2016-05-04 Thread Tan, Jianfeng
Hi Sergio, On 5/4/2016 7:07 PM, Sergio Gonzalez Monroy wrote: > On 08/03/2016 01:42, Jianfeng Tan wrote: >> This patch adds an option, --huge-trybest, to use a recover mechanism to >> the case that there are not so many hugepages (declared in sysfs), which >> can be used. It relys on a mem

[dpdk-dev] [PATCH v4 0/8] virtio support for container

2016-04-29 Thread Tan, Jianfeng
Sorry, forget to mention, this patchset depends on: - [PATCH v2] virtio: fix modify drv_flags for specific device - [PATCH v3 0/2] virtio: fix memory leak of virtqueue memzones Thanks, Jianfeng > -Original Message- > From: Tan, Jianfeng > Sent: Friday, April 29, 201

[dpdk-dev] [PATCH v2 0/2] virtio: fix memory leak of virtqueue memzones

2016-04-28 Thread Tan, Jianfeng
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Tan, Jianfeng > Sent: Friday, April 29, 2016 3:05 AM > To: dev at dpdk.org > Cc: Xie, Huawei; yuanhan.liu at linux.intel.com > Subject: Re: [dpdk-dev] [PATCH v2 0/2] virtio: fix memory

[dpdk-dev] [PATCH v2 0/2] virtio: fix memory leak of virtqueue memzones

2016-04-28 Thread Tan, Jianfeng
Self NACK. Missed to reset vq->started. > -Original Message- > From: Tan, Jianfeng > Sent: Friday, April 29, 2016 3:04 AM > To: dev at dpdk.org > Cc: Xie, Huawei; yuanhan.liu at linux.intel.com; Tan, Jianfeng > Subject: [PATCH v2 0/2] virtio: fix memory leak

[dpdk-dev] [PATCH] virtio: fix memory leak of virtqueue memzones

2016-04-28 Thread Tan, Jianfeng
Hi Yuanhan, On 4/28/2016 6:37 AM, Yuanhan Liu wrote: > On Tue, Apr 26, 2016 at 12:32:12PM +, Jianfeng Tan wrote: >> Issue: When virtio was proposed in DPDK, there is no API to free memzones. >> But this has changed since rte_memzone_free() has been implemented by >> commit ff909fe21f. > The

[dpdk-dev] [PATCH] virtio: fix modify drv_flags for specific device

2016-04-27 Thread Tan, Jianfeng
Hi, On 4/26/2016 7:53 PM, David Marchand wrote: > On Tue, Apr 26, 2016 at 4:24 AM, Jianfeng Tan > wrote: >> Issue: virtio's drv_flags are decided by devices types (modern vs legacy), >> and which kernel driver is used, and the negotiated features (especially >> VIRTIO_NET_STATUS) with backend,

[dpdk-dev] [PATCH] eal: add option --avail-cores to detect lcores

2016-04-26 Thread Tan, Jianfeng
Hi, Since some guys are asking about the status of this patch, I'd like to ping if anyone still has concerns. Current conclusion is: with option --avail-cores. Thanks, Jianfeng On 3/4/2016 6:05 PM, Jianfeng Tan wrote: > This patch adds option, --avail-cores, to use lcores which are available >

[dpdk-dev] [PATCH] virtio: fix segfault when transmit pkts

2016-04-26 Thread Tan, Jianfeng
Hi Stephen, On 4/26/2016 12:48 PM, Stephen Hemminger wrote: > On Thu, 21 Apr 2016 12:36:10 + > Jianfeng Tan wrote: > >> Issue: when using virtio nic to transmit pkts, it causes segment fault. >> >> How to reproduce: >> a. start testpmd with vhost. >> $testpmd -c 0x3 -n 4 --socket-mem 1024,0

[dpdk-dev] [PATCH v2] virtio: fix segfault when transmit pkts

2016-04-26 Thread Tan, Jianfeng
Hi Yuanhan, > -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Tuesday, April 26, 2016 11:43 AM > To: Tan, Jianfeng > Cc: dev at dpdk.org; Xie, Huawei > Subject: Re: [PATCH v2] virtio: fix segfault when transmit pkts > > On Mo

[dpdk-dev] [PATCH] virtio: fix segfault when transmit pkts

2016-04-25 Thread Tan, Jianfeng
Hi Yuanhan & Huawei, On 4/22/2016 10:23 PM, Xie, Huawei wrote: > On 4/22/2016 6:43 AM, Yuanhan Liu wrote: >> On Thu, Apr 21, 2016 at 12:36:10PM +, Jianfeng Tan wrote: >>> Issue: when using virtio nic to transmit pkts, it causes segment fault. >> Jianfeng, >> >> It's good to describe the

[dpdk-dev] [PATCH v3 2/2] virtio/vdev: add a new vdev named eth_cvio

2016-04-22 Thread Tan, Jianfeng
Hi, On 4/22/2016 3:36 PM, David Marchand wrote: > Hello, > > On Fri, Apr 22, 2016 at 7:15 AM, Tan, Jianfeng > wrote: >> On 4/21/2016 4:51 PM, David Marchand wrote: >>> virtio code relies on drv_flags (even updating it while this should be >>> per-devic

[dpdk-dev] [PATCH v3 2/2] virtio/vdev: add a new vdev named eth_cvio

2016-04-22 Thread Tan, Jianfeng
Hi Yuanhan, On 4/22/2016 6:14 AM, Yuanhan Liu wrote: > On Thu, Apr 21, 2016 at 02:56:36AM +, Jianfeng Tan wrote: >> Add a new virtual device named eth_cvio, it can be used just like >> eth_ring, eth_null, etc. >> >> Configured parameters include: >>- rx (optional, 1 by default), number of

[dpdk-dev] [PATCH v3 1/2] virtio/vdev: add embeded device emulation

2016-04-22 Thread Tan, Jianfeng
Hi Yuanhan, On 4/22/2016 6:01 AM, Yuanhan Liu wrote: > On Thu, Apr 21, 2016 at 02:56:35AM +, Jianfeng Tan wrote: >> Background: Previously, we usually use a virtio device in QEMU/VM's >> context as below pic shows. Virtio nic is emulated in QEMU, and usually >> presented in VM as a PCI

[dpdk-dev] [PATCH v3 2/2] virtio/vdev: add a new vdev named eth_cvio

2016-04-22 Thread Tan, Jianfeng
Hi Thomas, On 4/21/2016 6:05 PM, Thomas Monjalon wrote: > 2016-04-21 02:56, Jianfeng Tan: >> Add a new virtual device named eth_cvio, it can be used just like >> eth_ring, eth_null, etc. > Why this name eth_cvio? > Why the prefix eth_? > The virtio-net driver uses a kernel device. Here it is a

[dpdk-dev] [PATCH v3 2/2] virtio/vdev: add a new vdev named eth_cvio

2016-04-22 Thread Tan, Jianfeng
Hi, On 4/21/2016 4:51 PM, David Marchand wrote: > Hello, > > On Thu, Apr 21, 2016 at 4:56 AM, Jianfeng Tan > wrote: >> Add a new virtual device named eth_cvio, it can be used just like >> eth_ring, eth_null, etc. >> >> Configured parameters include: >>- rx (optional, 1 by default), number

[dpdk-dev] TSO support for Virtio_pmd

2016-04-20 Thread Tan, Jianfeng
Hi Nissim, On 4/20/2016 2:10 PM, Nissim Nisimov wrote: > Hi all, > > I see some additions in dpdk 16.04 to support TSO for vhost-user dpdk driver > with vanilla linux virtio VM. > > Does dpdk Virtio driver support TSO with the current code? Virtio pmd driver does not support TSO for now. > if

[dpdk-dev] [PATCH v2 0/5] virtio support for container

2016-04-14 Thread Tan, Jianfeng
Hi Thomas, On 4/14/2016 12:14 AM, Thomas Monjalon wrote: > Hi Jianfeng, > > Thanks for raising the container issues and proposing some solutions. > General comments below. > > 2016-02-05 19:20, Jianfeng Tan: >> This patchset is to provide high performance networking interface (virtio) >> for

[dpdk-dev] [PATCH] vhost: call rte_vhost_enable_guest_notification only on enabled queues

2016-04-08 Thread Tan, Jianfeng
On 4/7/2016 11:29 PM, Loftus, Ciara wrote: >> On 4/7/2016 8:29 AM, Rich Lane wrote: >>> If the vhost PMD were configured with more queues than the guest, the >> old >>> code would segfault in rte_vhost_enable_guest_notification due to a NULL >>> virtqueue pointer. >>> >>> Fixes: ee584e9710b9

[dpdk-dev] [PATCH] vhost: call rte_vhost_enable_guest_notification only on enabled queues

2016-04-07 Thread Tan, Jianfeng
Hi, On 4/7/2016 8:29 AM, Rich Lane wrote: > If the vhost PMD were configured with more queues than the guest, the old > code would segfault in rte_vhost_enable_guest_notification due to a NULL > virtqueue pointer. > > Fixes: ee584e9710b9 ("vhost: add driver on top of the library") >

[dpdk-dev] [PATCH] vhost: Fix retrieval of numa information in PMD

2016-04-06 Thread Tan, Jianfeng
On 4/6/2016 2:17 PM, Yuanhan Liu wrote: > On Wed, Apr 06, 2016 at 02:05:51PM +0800, Tan, Jianfeng wrote: >> >> On 4/6/2016 1:44 PM, Yuanhan Liu wrote: >>> On Wed, Apr 06, 2016 at 01:32:12PM +0800, Tan, Jianfeng wrote: >>>> Hi, >>>> >>&g

[dpdk-dev] [PATCH] vhost: Fix retrieval of numa information in PMD

2016-04-06 Thread Tan, Jianfeng
On 4/6/2016 1:44 PM, Yuanhan Liu wrote: > On Wed, Apr 06, 2016 at 01:32:12PM +0800, Tan, Jianfeng wrote: >> Hi, >> >> Just out of interest, seems that the message handling thread which runs >> new_device() is pthread_create() from the thread which calls the >> d

[dpdk-dev] [PATCH] vhost: Fix retrieval of numa information in PMD

2016-04-06 Thread Tan, Jianfeng
Hi, Just out of interest, seems that the message handling thread which runs new_device() is pthread_create() from the thread which calls the dev_start(), usually master thread, right? But it's not necessary to be the master thread to poll pkts from this vhost port, right? So what's the

[dpdk-dev] [PATCH] doc: update supported features of virtio

2016-04-05 Thread Tan, Jianfeng
Hi, On 4/5/2016 4:20 PM, Thomas Monjalon wrote: > 2016-04-05 03:58, Jianfeng Tan: >> - ethertype filter X X >> + ethertype filter X X >> X X > Are you sure about ethertype filter in virtio? I do not see it. Sorry,

[dpdk-dev] [PATCH v2] virtio: use zeroed memory for simple TX header

2016-04-05 Thread Tan, Jianfeng
Hi, On 4/5/2016 12:26 PM, Yuanhan Liu wrote: > On Tue, Apr 05, 2016 at 11:20:05AM +0800, Tan, Jianfeng wrote: >> Hi, >> >> On 4/5/2016 10:11 AM, Rich Lane wrote: >>> For simple TX the virtio-net header must be zeroed, but it was using memory >>> that had be

[dpdk-dev] [PATCH v2] virtio: use zeroed memory for simple TX header

2016-04-05 Thread Tan, Jianfeng
Hi, On 4/5/2016 10:11 AM, Rich Lane wrote: > For simple TX the virtio-net header must be zeroed, but it was using memory > that had been initialized with indirect descriptor tables. This resulted in > "unsupported gso type" errors from librte_vhost. > > We can use the same memory for every

[dpdk-dev] [PATCH] doc: fill nics features matrix for mlx4 & mlx5

2016-03-31 Thread Tan, Jianfeng
Hi, On 3/31/2016 7:00 PM, Adrien Mazarguil wrote: > On Thu, Mar 31, 2016 at 06:55:41PM +0800, Tan, Jianfeng wrote: >> Hi, >> >> On 3/31/2016 6:22 PM, Adrien Mazarguil wrote: >>> Signed-off-by: Adrien Mazarguil >>> ---

[dpdk-dev] [PATCH] doc: fill nics features matrix for mlx4 & mlx5

2016-03-31 Thread Tan, Jianfeng
Hi, On 3/31/2016 6:22 PM, Adrien Mazarguil wrote: > Signed-off-by: Adrien Mazarguil > --- > doc/guides/nics/overview.rst | 56 > ++-- > 1 file changed, 28 insertions(+), 28 deletions(-) > > diff --git a/doc/guides/nics/overview.rst

[dpdk-dev] [PATCH 2/2] doc: update which PMDs can parse packet type

2016-03-26 Thread Tan, Jianfeng
Hi Bruce, On 3/25/2016 10:21 PM, Bruce Richardson wrote: > On Fri, Mar 25, 2016 at 11:15:36AM +0800, Jianfeng Tan wrote: >> Signed-off-by: Jianfeng Tan >> --- >> doc/guides/nics/overview.rst | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git

[dpdk-dev] [PATCH v4 1/3] ethdev: refine API to query supported packet types

2016-03-25 Thread Tan, Jianfeng
NACK. I'll send an independent patchset for this. Thanks, Jianfeng > -Original Message- > From: Tan, Jianfeng > Sent: Friday, March 25, 2016 8:48 AM > To: dev at dpdk.org > Cc: Tan, Jianfeng; Ananyev, Konstantin; Zhang, Helin; Richardson, Bruce > Subject: [PATCH v4 1

[dpdk-dev] [PATCH v2 0/5] virtio support for container

2016-03-25 Thread Tan, Jianfeng
On 3/24/2016 9:45 PM, Neil Horman wrote: > On Thu, Mar 24, 2016 at 11:10:50AM +0800, Tan, Jianfeng wrote: >> Hi Neil, >> >> On 3/24/2016 3:17 AM, Neil Horman wrote: >>> On Fri, Feb 05, 2016 at 07:20:23PM +0800, Jianfeng Tan wrote: >>>> v1->v2:

[dpdk-dev] [PATCH v2 0/5] virtio support for container

2016-03-24 Thread Tan, Jianfeng
dev/hugepages:/dev/hugepages \ >> dpdk-app-l2fwd l2fwd -c 0x4 -n 4 -m 1024 --no-pci \ >> --vdev=eth_cvio0,path=/var/run/usvhost -- -p 0x1 >> >> f. Used with vhost-net >> $: modprobe vhost >> $: modprobe vhost-net >> $: docker run -i -t --privile

[dpdk-dev] [PATCH v9 01/11] ethdev: add API to query supported packet types

2016-03-18 Thread Tan, Jianfeng
Hi Thomas, On 3/15/2016 4:50 AM, Jianfeng Tan wrote: > Add a new API rte_eth_dev_get_supported_ptypes to query what packet types > can be filled by given already started device (or its pmd rx burst function > has already been decided). > > Signed-off-by: Jianfeng Tan > Acked-by: Konstantin

[dpdk-dev] Fwd: EAL: map_all_hugepages(): mmap failed: Cannot allocate memory

2016-03-18 Thread Tan, Jianfeng
On 3/18/2016 6:41 AM, John Wei wrote: > I am setting up OVS inside a Linux container. This OVS is built using DPDK > library. > During the startup of ovs-vswitchd, it core dumped due to fail to mmap. >in eal_memory.c > virtaddr = mmap(vma_addr, hugepage_sz, PROT_READ |

  1   2   3   >