[dpdk-dev] Solarflare PMD submission question

2016-11-18 Thread Andrew Rybchenko
On 10/28/2016 05:43 PM, Andrew Rybchenko wrote: > On 10/28/2016 03:33 PM, Thomas Monjalon wrote: >> 2016-10-28 13:50, Andrew Rybchenko: >>> The only thing which comes to my mind is to split libefx import on >>> subsystem >>> basis (few files per subsystem). It is artificial and added files will

[dpdk-dev] [RFC PATCH 6/6] eal: removing eth_driver

2016-11-18 Thread Shreyansh Jain
sorry for delay in responding; somehow I didn't notice this email. On Thursday 17 November 2016 06:23 PM, Jan Blunck wrote: > On Thu, Nov 17, 2016 at 6:30 AM, Shreyansh Jain > wrote: >> This patch demonstrates how eth_driver can be replaced with appropriate >> changes for rte_xxx_driver from

[dpdk-dev] [PATCH] crypto: remove unused digest-appended feature

2016-11-18 Thread John Griffin
On 17/11/16 17:33, Fiona Trahe wrote: > The cryptodev API had specified that if the digest address field was > left empty on an authentication operation, then the PMD would assume > the digest was appended to the source or destination data. > This case was not handled at all by most PMDs and

[dpdk-dev] [PATCH] examples/ethtool: fix bug in drvinfo callback

2016-11-18 Thread Qiming Yang
Function pcmd_drvinfo_callback uses struct info to get the ethtool infomation of each port. Struct info will store the infomation of previous port until this infomation be updated. This patch fixes this issue. Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")

[dpdk-dev] [PATCH v2] nfp: report link speed using hardware info

2016-11-18 Thread Thomas Monjalon
2016-11-18 16:06, Alejandro Lucero: > Previous reported speed was hardcoded. > > Signed-off-by: Alejandro Lucero > --- > drivers/net/nfp/nfp_net.c | 28 ++-- > drivers/net/nfp/nfp_net_ctrl.h | 13 + > 2 files changed, 39 insertions(+), 2 deletions(-)

[dpdk-dev] [PATCH v1] maintainers: update lthreads maintainer

2016-11-18 Thread John McNamara
Signed-off-by: John McNamara --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index d6bb8f8..2744212 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -677,7 +677,7 @@ F: examples/netmap_compat/ F:

[dpdk-dev] [PATCH v1] maintainers: update procinfo maintainer

2016-11-18 Thread John McNamara
Update procinfo maintainer and name of the application. Signed-off-by: John McNamara --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index d6bb8f8..c40e9e0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -618,9 +618,9 @@ M: Pablo

[dpdk-dev] [PATCH] net/bonding: improve non-ip packets RSS

2016-11-18 Thread Haifeng Lin
Most ethernet not support non-ip packets RSS and only first queue can used to receive. In this scenario lacp bond can only use one queue even if multi queue configured. We use below formula to change the map between bond_qid and slave_qid to let at least slave_num queues to receive packets:

[dpdk-dev] [PATCH v2] nfp: report link speed using hardware info

2016-11-18 Thread Alejandro Lucero
On Fri, Nov 18, 2016 at 4:29 PM, Thomas Monjalon wrote: > 2016-11-18 16:06, Alejandro Lucero: > > Previous reported speed was hardcoded. > > > > Signed-off-by: Alejandro Lucero > > --- > > drivers/net/nfp/nfp_net.c | 28 ++-- > > drivers/net/nfp/nfp_net_ctrl.h | 13

[dpdk-dev] Fwd: |WARNING| [PATCH] nfp: report link speed using hardware info

2016-11-18 Thread Thomas Monjalon
2016-11-18 15:31, Alejandro Lucero: > On Fri, Nov 18, 2016 at 3:24 PM, Ferruh Yigit > wrote: > > > On 11/18/2016 3:10 PM, Alejandro Lucero wrote: > > > Hi Thomas, > > > > > > I got this email when sending a patch some minutes ago. > > > > > > The point is I trusted script/checkpatches.sh which

[dpdk-dev] pmdinfogen issues: cross compilation for ARM fails with older host compiler

2016-11-18 Thread Bruce Richardson
On Fri, Nov 18, 2016 at 08:50:52AM -0500, Neil Horman wrote: > On Fri, Nov 18, 2016 at 12:03:19PM +, Hemant Agrawal wrote: > > > -Original Message- > > > From: Neil Horman [mailto:nhorman at tuxdriver.com] > > > On Tue, Nov 15, 2016 at 09:34:16AM +, Hemant Agrawal wrote: > > > > >

[dpdk-dev] Fwd: |WARNING| [PATCH] nfp: report link speed using hardware info

2016-11-18 Thread Thomas Monjalon
2016-11-18 15:24, Ferruh Yigit: > On 11/18/2016 3:10 PM, Alejandro Lucero wrote: > > Hi Thomas, > > > > I got this email when sending a patch some minutes ago. > > > > The point is I trusted script/checkpatches.sh which did not report those > > warnings. > > Am I doing anything wrong when using

[dpdk-dev] [PATCH] vdev: fix missing alias check on uninit

2016-11-18 Thread Anatoly Burakov
Fixes: d63eed6b2dca ("eal: add driver name alias") Signed-off-by: Anatoly Burakov --- lib/librte_eal/common/eal_common_vdev.c | 8 1 file changed, 8 insertions(+) diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c index 0ff2377..7d6e54f

[dpdk-dev] [PATCH v2] nfp: report link speed using hardware info

2016-11-18 Thread Alejandro Lucero
Previous reported speed was hardcoded. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 28 ++-- drivers/net/nfp/nfp_net_ctrl.h | 13 + 2 files changed, 39 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c

[dpdk-dev] [PATCH 0/4] libeventdev API and northbound implementation

2016-11-18 Thread Bruce Richardson
+Thomas On Fri, Nov 18, 2016 at 03:25:18PM +, Bruce Richardson wrote: > On Fri, Nov 18, 2016 at 11:14:58AM +0530, Jerin Jacob wrote: > > As previously discussed in RFC v1 [1], RFC v2 [2], with changes > > described in [3] (also pasted below), here is the first non-draft series > > for this

[dpdk-dev] [PATCH v5 4/4] latencystats: added new library for latency stats

2016-11-18 Thread Remy Horton
Add a library designed to calculate latency statistics and report them to the application when queried. The library measures minimum, average and maximum latencies, and jitter in nano seconds. The current implementation supports global latency stats, i.e. per application stats. Added new field to

[dpdk-dev] [PATCH v5 3/4] app/test-pmd: add support for bitrate statistics

2016-11-18 Thread Remy Horton
Signed-off-by: Remy Horton --- app/test-pmd/testpmd.c | 36 1 file changed, 36 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index a0332c2..60c635f 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -78,6 +78,10

[dpdk-dev] [PATCH v5 1/4] lib: add information metrics library

2016-11-18 Thread Remy Horton
This patch adds a new information metric library that allows other modules to register named metrics and update their values. It is intended to be independent of ethdev, rather than mixing ethdev and non-ethdev information in xstats. Signed-off-by: Remy Horton --- MAINTAINERS

[dpdk-dev] [PATCH v5 0/4] Expanded statistics reporting

2016-11-18 Thread Remy Horton
This patchset extends statistics reporting to include peak and average data-rate metrics. It comes in two parts: a statistics reporting library, and a bitrate calculation library that uses it. This structure is intended to seperate statistic reporting from ethdev and allow more flexible metric

[dpdk-dev] Fwd: |WARNING| [PATCH] nfp: report link speed using hardware info

2016-11-18 Thread Alejandro Lucero
On Fri, Nov 18, 2016 at 3:31 PM, Alejandro Lucero < alejandro.lucero at netronome.com> wrote: > > > On Fri, Nov 18, 2016 at 3:24 PM, Ferruh Yigit > wrote: > >> On 11/18/2016 3:10 PM, Alejandro Lucero wrote: >> > Hi Thomas, >> > >> > I got this email when sending a patch some minutes ago. >> > >>

[dpdk-dev] Fwd: |WARNING| [PATCH] nfp: report link speed using hardware info

2016-11-18 Thread Alejandro Lucero
On Fri, Nov 18, 2016 at 3:26 PM, Ferruh Yigit wrote: > On 11/18/2016 3:10 PM, Alejandro Lucero wrote: > > Hi Thomas, > > > > I got this email when sending a patch some minutes ago. > > > > The point is I trusted script/checkpatches.sh which did not report those > > warnings. > > Am I doing

[dpdk-dev] Fwd: |WARNING| [PATCH] nfp: report link speed using hardware info

2016-11-18 Thread Alejandro Lucero
On Fri, Nov 18, 2016 at 3:24 PM, Ferruh Yigit wrote: > On 11/18/2016 3:10 PM, Alejandro Lucero wrote: > > Hi Thomas, > > > > I got this email when sending a patch some minutes ago. > > > > The point is I trusted script/checkpatches.sh which did not report those > > warnings. > > Am I doing

[dpdk-dev] Fwd: |WARNING| [PATCH] nfp: report link speed using hardware info

2016-11-18 Thread Ferruh Yigit
On 11/18/2016 3:10 PM, Alejandro Lucero wrote: > Hi Thomas, > > I got this email when sending a patch some minutes ago. > > The point is I trusted script/checkpatches.sh which did not report those > warnings. > Am I doing anything wrong when using checkpatches.sh? > > > -- Forwarded

[dpdk-dev] [PATCH 0/4] libeventdev API and northbound implementation

2016-11-18 Thread Bruce Richardson
On Fri, Nov 18, 2016 at 11:14:58AM +0530, Jerin Jacob wrote: > As previously discussed in RFC v1 [1], RFC v2 [2], with changes > described in [3] (also pasted below), here is the first non-draft series > for this new API. > > [1] http://dpdk.org/ml/archives/dev/2016-August/045181.html > [2]

[dpdk-dev] Fwd: |WARNING| [PATCH] nfp: report link speed using hardware info

2016-11-18 Thread Ferruh Yigit
On 11/18/2016 3:10 PM, Alejandro Lucero wrote: > Hi Thomas, > > I got this email when sending a patch some minutes ago. > > The point is I trusted script/checkpatches.sh which did not report those > warnings. > Am I doing anything wrong when using checkpatches.sh? I am also getting same

[dpdk-dev] [PATCH] lib/librte_mempool: a redundant word in comment

2016-11-18 Thread Olivier Matz
Hi Wei, 2lOn 11/15/2016 07:54 AM, Zhao1, Wei wrote: > Hi, john > >> -Original Message- >> From: Mcnamara, John >> Sent: Monday, November 14, 2016 6:30 PM >> To: Zhao1, Wei ; dev at dpdk.org >> Cc: olivier.matz at 6wind.com; Zhao1, Wei >> Subject: RE: [dpdk-dev] [PATCH]

[dpdk-dev] Fwd: |WARNING| [PATCH] nfp: report link speed using hardware info

2016-11-18 Thread Alejandro Lucero
Hi Thomas, I got this email when sending a patch some minutes ago. The point is I trusted script/checkpatches.sh which did not report those warnings. Am I doing anything wrong when using checkpatches.sh? -- Forwarded message -- From: Date: Fri, Nov 18,

[dpdk-dev] [PATCH] lib/librte_mempool: a redundant of socket_id assignment

2016-11-18 Thread Olivier Matz
Hi Wei, On 11/14/2016 11:25 AM, Mcnamara, John wrote: > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Wei Zhao >> Sent: Monday, November 14, 2016 2:16 AM >> To: dev at dpdk.org >> Cc: olivier.matz at 6wind.com; Zhao1, Wei >> Subject: [dpdk-dev] [PATCH]

[dpdk-dev] [PATCH] nfp: report link speed using hardware info

2016-11-18 Thread Alejandro Lucero
Previous reported speed was hardcoded. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 31 +-- drivers/net/nfp/nfp_net_ctrl.h | 13 + 2 files changed, 42 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c

[dpdk-dev] [PATCH v2] i40e: Fix eth_i40e_dev_init sequence on ThunderX

2016-11-18 Thread Bruce Richardson
On Fri, Nov 18, 2016 at 04:52:13AM -0800, Satha Rao wrote: > i40e_asq_send_command: rd32 & wr32 under ThunderX gives unpredictable >results. To solve this include rte memory barriers > > Signed-off-by: Satha Rao > --- > drivers/net/i40e/base/i40e_osdep.h | 14

[dpdk-dev] Clarification for - SoC specific driver based common sub component placing

2016-11-18 Thread Thomas Monjalon
2016-11-18 14:38, Thomas Monjalon: > 2016-11-18 12:44, Hemant Agrawal: > > We like to introduce NXP's DPAA (Data Path Acceleration Architecture Gen2) > > Poll mode drivers into the DPDK. > > > > We need some clarification w.r.t the right placing of some dependent > > components, which can be

[dpdk-dev] Clarification for - SoC specific driver based common sub component placing

2016-11-18 Thread Thomas Monjalon
2016-11-18 12:44, Hemant Agrawal: > We like to introduce NXP's DPAA (Data Path Acceleration Architecture Gen2) > Poll mode drivers into the DPDK. > > We need some clarification w.r.t the right placing of some dependent > components, which can be common across drivers. E.g. We have hardware

[dpdk-dev] Clarification for - SoC specific driver based common sub component placing

2016-11-18 Thread Hemant Agrawal
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, November 18, 2016 7:13 PM > To: Hemant Agrawal > Cc: dev at dpdk.org > Subject: Re: Clarification for - SoC specific driver based common sub > component > placing > > 2016-11-18 14:38,

[dpdk-dev] [PATCH v5] latencystats: added new library for latency stats

2016-11-18 Thread Remy Horton
On 15/11/2016 21:37, Reshma Pattan wrote: [..] > This pacth is dependent on http://dpdk.org/dev/patchwork/patch/16927/ There are merge issues, so will combine this patch into the v6 of the above patchset. ..Remy

[dpdk-dev] [PATCH] pmdinfogen: Fix pmdinfogen to select proper endianess on cross-compile

2016-11-18 Thread Neil Horman
pmdinfogen has a bug in which, during build, it pulls in rte_byteorder.h to obtain the rte macros for byteswapping between the cpu byte order and big or little endian. Unfortunately, pmdinfogen is a tool that is only meant to be run during the build of dpdk components, and so, it runs on the

[dpdk-dev] pmdinfogen issues: cross compilation for ARM fails with older host compiler

2016-11-18 Thread Neil Horman
On Fri, Nov 18, 2016 at 04:37:38PM +, Bruce Richardson wrote: > On Fri, Nov 18, 2016 at 08:50:52AM -0500, Neil Horman wrote: > > On Fri, Nov 18, 2016 at 12:03:19PM +, Hemant Agrawal wrote: > > > > -Original Message- > > > > From: Neil Horman [mailto:nhorman at tuxdriver.com] > > >

[dpdk-dev] Proposal for a new Committer model

2016-11-18 Thread Neil Horman
On Thu, Nov 17, 2016 at 09:20:50AM +, Mcnamara, John wrote: > Repost from the moving at dpdk.org mailing list to get a wider audience. > Original thread: http://dpdk.org/ml/archives/moving/2016-November/59.html > > > Hi, > > I'd like to propose a change to the DPDK committer model.

[dpdk-dev] Clarification for - SoC specific driver based common sub component placing

2016-11-18 Thread Hemant Agrawal
Hi all, We like to introduce NXP's DPAA (Data Path Acceleration Architecture Gen2) Poll mode drivers into the DPDK. We need some clarification w.r.t the right placing of some dependent components, which can be common across drivers. E.g. We have hardware queue and buffer manager driver. This

[dpdk-dev] pmdinfogen issues: cross compilation for ARM fails with older host compiler

2016-11-18 Thread Hemant Agrawal
> -Original Message- > From: Neil Horman [mailto:nhorman at tuxdriver.com] > On Tue, Nov 15, 2016 at 09:34:16AM +, Hemant Agrawal wrote: > > > On Mon, Nov 14, 2016 at 02:29:24AM +0530, Jerin Jacob wrote: > > > > On Fri, Nov 11, 2016 at 10:34:39AM +, Hemant Agrawal wrote: > > > > >

[dpdk-dev] [PATCH 01/22] ethdev: introduce generic flow API

2016-11-18 Thread Adrien Mazarguil
Hi Beilei, On Fri, Nov 18, 2016 at 06:36:31AM +, Xing, Beilei wrote: > Hi Adrien, > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Adrien Mazarguil > > Sent: Thursday, November 17, 2016 12:23 AM > > To: dev at dpdk.org > > Cc: Thomas Monjalon ; De

[dpdk-dev] [PATCH 4/4] app/test: unit test case for eventdev APIs

2016-11-18 Thread Jerin Jacob
This commit adds basic unit tests for the eventdev API. commands to run the test app: ./build/app/test -c 2 RTE>>eventdev_common_autotest Signed-off-by: Jerin Jacob --- MAINTAINERS | 1 + app/test/Makefile| 2 + app/test/test_eventdev.c | 776

[dpdk-dev] [PATCH 2/4] eventdev: implement the northbound APIs

2016-11-18 Thread Jerin Jacob
This patch set defines the southbound driver interface and implements the common code required for northbound eventdev API interface. Signed-off-by: Jerin Jacob --- config/common_base |6 + lib/Makefile |1 +

[dpdk-dev] [PATCH 1/4] eventdev: introduce event driven programming model

2016-11-18 Thread Jerin Jacob
In a polling model, lcores poll ethdev ports and associated rx queues directly to look for packet. In an event driven model, by contrast, lcores call the scheduler that selects packets for them based on programmer-specified criteria. Eventdev library adds support for event driven programming

[dpdk-dev] [PATCH 0/4] libeventdev API and northbound implementation

2016-11-18 Thread Jerin Jacob
As previously discussed in RFC v1 [1], RFC v2 [2], with changes described in [3] (also pasted below), here is the first non-draft series for this new API. [1] http://dpdk.org/ml/archives/dev/2016-August/045181.html [2] http://dpdk.org/ml/archives/dev/2016-October/048592.html [3]

[dpdk-dev] [PATCH 3/3] net/mlx5: do not invalidate title CQE

2016-11-18 Thread Ferruh Yigit
On 11/17/2016 10:38 AM, Adrien Mazarguil wrote: > On Thu, Nov 17, 2016 at 10:49:56AM +0100, Nelio Laranjeiro wrote: >> We can leave the title completion queue entry untouched since its contents >> are not modified. >> >> Reported-by: Liming Sun >> Signed-off-by: Nelio Laranjeiro <...> >

[dpdk-dev] [dpdk-stable] [PATCH 2/3] net/mlx5: fix wrong htons

2016-11-18 Thread Ferruh Yigit
On 11/17/2016 10:38 AM, Adrien Mazarguil wrote: > On Thu, Nov 17, 2016 at 10:49:55AM +0100, Nelio Laranjeiro wrote: >> Completion queue entry data uses network endian, to access them we should use >> ntoh*(). >> >> Fixes: c305090bbaf8 ("net/mlx5: replace countdown with threshold for Tx >>

[dpdk-dev] [dpdk-stable] [PATCH 1/3] net/mlx5: fix leak when starvation occurs

2016-11-18 Thread Ferruh Yigit
On 11/17/2016 10:37 AM, Adrien Mazarguil wrote: > On Thu, Nov 17, 2016 at 10:49:54AM +0100, Nelio Laranjeiro wrote: >> The list of segments to free was wrongly manipulated ending by only freeing >> the first segment instead of freeing all of them. The last one still >> belongs to the NIC and thus

[dpdk-dev] [PATCH 5/5] ethtool: dispaly bus info and firmware version

2016-11-18 Thread Remy Horton
On 17/11/2016 17:42, Qiming Yang wrote: > This patch enhances the ethtool-API to support to show the > bus information and firmware version as same as kernel > version ethtool displayed. Suggest rewording as: This patch enhances the ethtool example to support to show bus information and

[dpdk-dev] [PATCH 1/5] ethdev: add firmware version get

2016-11-18 Thread Remy Horton
On 17/11/2016 17:42, Qiming Yang wrote: > This patch added API for 'rte_eth_dev_fwver_get' > > void rte_eth_dev_fwver_get(uint8_t port_id, > char *fw_version, int fw_length); Suggest description such as: This patch adds ethdev API for fetching firmware version. Also see Thomas's comments.

[dpdk-dev] pmdinfogen issues: cross compilation for ARM fails with older host compiler

2016-11-18 Thread Neil Horman
On Fri, Nov 18, 2016 at 12:03:19PM +, Hemant Agrawal wrote: > > -Original Message- > > From: Neil Horman [mailto:nhorman at tuxdriver.com] > > On Tue, Nov 15, 2016 at 09:34:16AM +, Hemant Agrawal wrote: > > > > On Mon, Nov 14, 2016 at 02:29:24AM +0530, Jerin Jacob wrote: > > > > >

[dpdk-dev] [PATCH v2 1/1] mempool: Add sanity check when secondary link in less mempools than primary

2016-11-18 Thread Jean Tourrilhes
On Fri, Nov 18, 2016 at 04:11:12PM +0100, Olivier Matz wrote: > Hi Jean, > > > Do you mind if we put back this conversation on the ML? Oh, I forgot to do it ? I intended to. Bummer. Please do so. > I think your example shows that there is no linker magic: you just > need the same

[dpdk-dev] [PATCH 01/22] ethdev: introduce generic flow API

2016-11-18 Thread Xing, Beilei
Hi Adrien, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Adrien Mazarguil > Sent: Thursday, November 17, 2016 12:23 AM > To: dev at dpdk.org > Cc: Thomas Monjalon ; De Lara Guarch, > Pablo ; Olivier Matz > > Subject: [dpdk-dev] [PATCH 01/22] ethdev:

[dpdk-dev] [PATCH v2] i40e: Fix eth_i40e_dev_init sequence on ThunderX

2016-11-18 Thread Satha Rao
i40e_asq_send_command: rd32 & wr32 under ThunderX gives unpredictable results. To solve this include rte memory barriers Signed-off-by: Satha Rao --- drivers/net/i40e/base/i40e_osdep.h | 14 ++ 1 file changed, 14 insertions(+) diff --git

[dpdk-dev] [PATCH 1/5] ethdev: add firmware version get

2016-11-18 Thread Yang, Qiming
Yes, that's my fault. I have set their statuses to 'suspended' Qiming -Original Message- From: Horton, Remy Sent: Friday, November 18, 2016 9:10 AM To: Yang, Qiming ; dev at dpdk.org Cc: Wu, Jingjing ; Chen, Jing D Subject: Re: [PATCH 1/5] ethdev: add firmware version get On

[dpdk-dev] [PATCH 1/5] ethdev: add firmware version get

2016-11-18 Thread Yang, Qiming
Hi, Thomas -Original Message- From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] Sent: Thursday, November 17, 2016 9:37 PM To: Yang, Qiming Cc: dev at dpdk.org; Horton, Remy ; Wu, Jingjing ; Chen, Jing D Subject: Re: [dpdk-dev] [PATCH 1/5] ethdev: add firmware version get