Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-16 Thread Jan Mędala
> > ​>At this point we need to have only pseudo-header checksum for TSO. Maybe > there will be new requirements, but that's something I cannot predict at > this point. > > Ok great, then we'll add a patch for ENA for v14, unless you guys would > like to do it yourself. > ​ ​That'd be great!​ >We

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-16 Thread Ananyev, Konstantin
Hi Jan, ​>Hello, ​ >>Is there any update on that subject? ​>At this point we need to have only pseudo-header checksum for TSO. Maybe there will be new requirements, but that's something I cannot predict at this point. Ok great, then we'll add a patch for ENA for v14, unless you guys would li

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-16 Thread Jan Mędala
​Hello, ​ > Is there any update on that subject? > ​At this point we need to have only pseudo-header checksum for TSO. Maybe there will be new requirements, but that's something I cannot predict at this point. ​ > So it seems that standard pseudo-header checksum calculation should be > enough.

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-15 Thread Ananyev, Konstantin
Hi Jan, > > Hi Jan, > > >Hello, > > >Sorry for late response. > > >From ENA perspective, we need to dig deeper about the requirements and use > >cases, but I'm pretty confident (95%) that ena will > need to implement tx_prep() API. There is at least one >scenario, when HW > relay on partial

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-13 Thread Ferruh Yigit
On 12/6/2016 3:53 PM, Ferruh Yigit wrote: > On 11/28/2016 11:03 AM, Thomas Monjalon wrote: >> We need attention of every PMD developers on this thread. >> >> Reminder of what Konstantin suggested: >> " >> - if the PMD supports TX offloads AND >> - if to be able use any of these offloads the upper l

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-12 Thread Ananyev, Konstantin
> > > This means vmxnet3 PMD also should be updated, right? > > > > Yes, that's right. > > > > >Should that update > > > be part of tx_prep patchset? Or separate patch? > > > > Another question I suppose is who will do the actual patch for vmxnet3. > > Yong, are you ok to do the patch for vmxnet3

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-12 Thread Ananyev, Konstantin
Hi Jan, >Hello, >Sorry for late response. >From ENA perspective, we need to dig deeper about the requirements and use >cases, but I'm pretty confident (95%) that ena will need to implement >tx_prep() API. There is at least one >scenario, when HW relay on partial >checksum. Could you let us k

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-09 Thread Jan Mędala
Hello, Sorry for late response. >From ENA perspective, we need to dig deeper about the requirements and use cases, but I'm pretty confident (95%) that ena will need to implement tx_prep() API. There is at least one scenario, when HW relay on partial checksum. Jan

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-08 Thread Yong Wang
an Medala ; Jakub > Palider ; John Daley ; Adrien > Mazarguil ; Alejandro Lucero > ; Rasesh Mody > ; Jacob, Jerin ; > Yuanhan Liu ; Kulasek, TomaszX > ; olivier.m...@6wind.com > Subject: RE: [dpdk-dev] [PATCH v12 0/6] add Tx preparation > > > Hi Ferruh, > > &g

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-07 Thread Alejandro Lucero
Lucero > > >> ; Rasesh Mody > > >> ; Jacob, Jerin ; > > >> Yuanhan Liu ; Kulasek, TomaszX > > >> ; olivier.m...@6wind.com > > >> Subject: RE: [dpdk-dev] [PATCH v12 0/6] add Tx preparation > > >> > > >> Hi > >

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-07 Thread Ananyev, Konstantin
etanel Belgazal ; Evgeny > Schemeilin ; Alejandro Lucero > ; Yong Wang ; > Andrew Rybchenko ; Hemant Agrawal > ; Kulasek, TomaszX > > Subject: Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation > > On Wed, Dec 07, 2016 at 10:13:14AM +, Ananyev, Konstantin wrote: > > &

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-07 Thread Yuanhan Liu
On Wed, Dec 07, 2016 at 10:13:14AM +, Ananyev, Konstantin wrote: > > Hi Yliu, > > > > > On Tue, Dec 06, 2016 at 03:53:42PM +, Ferruh Yigit wrote: > > > > Please, we need a comment for each driver saying > > > > "it is OK, we do not need any checksum preparation for TSO" > > > > or > > >

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-07 Thread Ananyev, Konstantin
Hi Yliu, > > On Tue, Dec 06, 2016 at 03:53:42PM +, Ferruh Yigit wrote: > > > Please, we need a comment for each driver saying > > > "it is OK, we do not need any checksum preparation for TSO" > > > or > > > "yes we have to implement tx_prepare or TSO will not work in this mode" > > > > > So

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-07 Thread Adrien Mazarguil
On Tue, Dec 06, 2016 at 08:31:35PM +, Ananyev, Konstantin wrote: > > Hi Konstantin, > > > > On Tue, Dec 06, 2016 at 10:56:26AM +, Ananyev, Konstantin wrote: > > > > > > Hi Adrien, > > > > > > > > > > > On Mon, Dec 05, 2016 at 04:43:52PM +, Ananyev, Konstantin wrote: > > > > [...] > > >

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-07 Thread Ananyev, Konstantin
t;> > >> Cc: Harish Patil ; dev@dpdk.org; Rahul Lakkireddy > >> ; Stephen Hurd > >> ; Jan Medala ; Jakub > >> Palider ; John Daley ; Adrien > >> Mazarguil ; Alejandro Lucero > >> ; Rasesh Mody > >> ; Jacob, Jerin ; > >> Yuanhan Liu ;

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-07 Thread Ferruh Yigit
akkireddy >> ; Stephen Hurd >> ; Jan Medala ; Jakub >> Palider ; John Daley ; Adrien >> Mazarguil ; Alejandro Lucero >> ; Rasesh Mody >> ; Jacob, Jerin ; >> Yuanhan Liu ; Kulasek, TomaszX >> ; olivier.m...@6wind.com >> Subject: RE: [dpdk-dev] [

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-07 Thread Yuanhan Liu
On Tue, Dec 06, 2016 at 03:53:42PM +, Ferruh Yigit wrote: > > Please, we need a comment for each driver saying > > "it is OK, we do not need any checksum preparation for TSO" > > or > > "yes we have to implement tx_prepare or TSO will not work in this mode" > > Sorry for late. For virtio, I th

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-06 Thread Andrew Rybchenko
On 12/06/2016 06:53 PM, Ferruh Yigit wrote: On 11/28/2016 11:03 AM, Thomas Monjalon wrote: We need attention of every PMD developers on this thread. Reminder of what Konstantin suggested: " - if the PMD supports TX offloads AND - if to be able use any of these offloads the upper layer SW would

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-06 Thread Ananyev, Konstantin
> Hi Konstantin, > > On Tue, Dec 06, 2016 at 10:56:26AM +, Ananyev, Konstantin wrote: > > > > Hi Adrien, > > > > > > > > On Mon, Dec 05, 2016 at 04:43:52PM +, Ananyev, Konstantin wrote: > > > [...] > > > > > On Fri, Dec 02, 2016 at 01:00:55AM +, Ananyev, Konstantin wrote: > > > > > [

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-06 Thread Yong Wang
lider ; John Daley ; Adrien > Mazarguil ; Alejandro Lucero > ; Rasesh Mody > ; Jacob, Jerin ; > Yuanhan Liu ; Kulasek, TomaszX > ; olivier.m...@6wind.com > Subject: RE: [dpdk-dev] [PATCH v12 0/6] add Tx preparation > > Hi > > > > > > > > > > 2

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-06 Thread Ferruh Yigit
On 11/28/2016 11:03 AM, Thomas Monjalon wrote: > We need attention of every PMD developers on this thread. > > Reminder of what Konstantin suggested: > " > - if the PMD supports TX offloads AND > - if to be able use any of these offloads the upper layer SW would have to: > * modify the content

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-06 Thread Adrien Mazarguil
Hi Konstantin, On Tue, Dec 06, 2016 at 10:56:26AM +, Ananyev, Konstantin wrote: > > Hi Adrien, > > > > > On Mon, Dec 05, 2016 at 04:43:52PM +, Ananyev, Konstantin wrote: > > [...] > > > > On Fri, Dec 02, 2016 at 01:00:55AM +, Ananyev, Konstantin wrote: > > > > [...] > > > > > > On W

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-06 Thread Ananyev, Konstantin
Hi Adrien, > > On Mon, Dec 05, 2016 at 04:43:52PM +, Ananyev, Konstantin wrote: > [...] > > > On Fri, Dec 02, 2016 at 01:00:55AM +, Ananyev, Konstantin wrote: > > > [...] > > > > > On Wed, Nov 30, 2016 at 10:54:50AM +, Ananyev, Konstantin wrote: > > > > > [...] > > > > > > Do you hav

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-05 Thread Adrien Mazarguil
On Mon, Dec 05, 2016 at 04:43:52PM +, Ananyev, Konstantin wrote: [...] > > On Fri, Dec 02, 2016 at 01:00:55AM +, Ananyev, Konstantin wrote: > > [...] > > > > On Wed, Nov 30, 2016 at 10:54:50AM +, Ananyev, Konstantin wrote: > > > > [...] > > > > > Do you have anything particular in mind

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-05 Thread Ananyev, Konstantin
Hi Adrien, > > Hi Konstantin, > > On Fri, Dec 02, 2016 at 01:00:55AM +, Ananyev, Konstantin wrote: > [...] > > > On Wed, Nov 30, 2016 at 10:54:50AM +, Ananyev, Konstantin wrote: > > > [...] > > > > > Something is definitely needed here, and only PMDs can provide it. I > > > > > think >

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-05 Thread Adrien Mazarguil
Hi Konstantin, On Fri, Dec 02, 2016 at 01:00:55AM +, Ananyev, Konstantin wrote: [...] > > On Wed, Nov 30, 2016 at 10:54:50AM +, Ananyev, Konstantin wrote: > > [...] > > > > Something is definitely needed here, and only PMDs can provide it. I > > > > think > > > > applications should not h

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-04 Thread Ananyev, Konstantin
Hi > > > > 2016-11-30 17:42, Ananyev, Konstantin: > > > > >Please, we need a comment for each driver saying > > > > >"it is OK, we do not need any checksum preparation for TSO" > > > > >or > > > > >"yes we have to implement tx_prepare or TSO will not work in this > > mode" > > > > > > > > > > > >

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-02 Thread Yong Wang
ley ; Adrien > Mazarguil ; Alejandro Lucero > ; Rasesh Mody > ; Jacob, Jerin ; > Yuanhan Liu ; Yong Wang > ; Kulasek, TomaszX > ; olivier.m...@6wind.com > Subject: Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation > > 2016-11-30 17:42, Ananyev, Konstantin: > > >

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-01 Thread Ananyev, Konstantin
Hi Adrien, > > Hi Konstantin, > > On Wed, Nov 30, 2016 at 10:54:50AM +, Ananyev, Konstantin wrote: > [...] > > > Something is definitely needed here, and only PMDs can provide it. I think > > > applications should not have to clear checksum fields or initialize them > > > to > > > some mag

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-01 Thread Jerin Jacob
On Thu, Dec 01, 2016 at 09:58:31AM +0100, Thomas Monjalon wrote: > 2016-12-01 08:15, Adrien Mazarguil: > > I'm perhaps a bit pessimistic mind you, but I do not think tx_prepare() will > > remain optional for long. Sure, PMDs that do not implement it do not care, > > I'm focusing on applications, fo

[dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-01 Thread Rahul Lakkireddy
Hi Thomas, On Monday, November 11/28/16, 2016 at 16:33:06 +0530, Thomas Monjalon wrote: > We need attention of every PMD developers on this thread. > > Reminder of what Konstantin suggested: > " > - if the PMD supports TX offloads AND > - if to be able use any of these offloads the upper layer SW

[dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-01 Thread Ferruh Yigit
On 11/30/2016 6:26 PM, Thomas Monjalon wrote: > 2016-11-30 17:42, Ananyev, Konstantin: Please, we need a comment for each driver saying "it is OK, we do not need any checksum preparation for TSO" or "yes we have to implement tx_prepare or TSO will not work in this mode" >>>

[dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-01 Thread Thomas Monjalon
2016-12-01 08:15, Adrien Mazarguil: > I'm perhaps a bit pessimistic mind you, but I do not think tx_prepare() will > remain optional for long. Sure, PMDs that do not implement it do not care, > I'm focusing on applications, for which the performance impact of calling > tx_prepare() followed by tx_b

[dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-01 Thread Adrien Mazarguil
Hi Tomasz, On Wed, Nov 30, 2016 at 10:30:54AM +, Kulasek, TomaszX wrote: [...] > > > In my opinion the second approach is both faster to applications and > > > more friendly from a usability perspective, am I missing something > > obvious? > > > > I think it was not clearly explained in this

[dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-01 Thread Adrien Mazarguil
Hi Konstantin, On Wed, Nov 30, 2016 at 10:54:50AM +, Ananyev, Konstantin wrote: [...] > > Something is definitely needed here, and only PMDs can provide it. I think > > applications should not have to clear checksum fields or initialize them to > > some magic value, same goes for any other off

[dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-01 Thread Jerin Jacob
On Wed, Nov 30, 2016 at 07:26:36PM +0100, Thomas Monjalon wrote: > 2016-11-30 17:42, Ananyev, Konstantin: > > > >Please, we need a comment for each driver saying > > > >"it is OK, we do not need any checksum preparation for TSO" > > > >or > > > >"yes we have to implement tx_prepare or TSO will not

[dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-11-30 Thread Thomas Monjalon
2016-11-30 17:42, Ananyev, Konstantin: > > >Please, we need a comment for each driver saying > > >"it is OK, we do not need any checksum preparation for TSO" > > >or > > >"yes we have to implement tx_prepare or TSO will not work in this mode" > > > > > > > qede PMD doesn?t currently support TSO ye

[dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-11-30 Thread Harish Patil
> > > >Hi Harish, >> >> >> >We need attention of every PMD developers on this thread. >> > >> >Reminder of what Konstantin suggested: >> >" >> >- if the PMD supports TX offloads AND >> >- if to be able use any of these offloads the upper layer SW would have >> >to: >> >* modify the contents o

[dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-11-30 Thread Ananyev, Konstantin
Hi Harish, > > > >We need attention of every PMD developers on this thread. > > > >Reminder of what Konstantin suggested: > >" > >- if the PMD supports TX offloads AND > >- if to be able use any of these offloads the upper layer SW would have > >to: > >* modify the contents of the packet OR

[dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-11-30 Thread Harish Patil
>We need attention of every PMD developers on this thread. > >Reminder of what Konstantin suggested: >" >- if the PMD supports TX offloads AND >- if to be able use any of these offloads the upper layer SW would have >to: >* modify the contents of the packet OR >* obey HW specific restrict

[dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-11-30 Thread Ajit Khaparde
On Mon, ?? Nov 28, 2016 at 5:03 AM, Thomas Monjalon wrote: > We need attention of every PMD developers on this thread. > > Reminder of what Konstantin suggested: > " > - if the PMD supports TX offloads AND > - if to be able use any of these offloads the upper layer SW would have to: > * modif

[dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-11-30 Thread Ananyev, Konstantin
> ; Jakub Palider ; John Daley > > (johndale) ; Adrien Mazarguil > > ; Alejandro Lucero > > ; Harish Patil > > ; Rasesh Mody ; Jerin > > Jacob ; Yuanhan Liu > > ; Yong Wang > > Cc: Tomasz Kulasek ; > > konstantin.ananyev at intel.com; olivier.matz at 6wind

[dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-11-30 Thread Ananyev, Konstantin
Hi Adrien, > > On Mon, Nov 28, 2016 at 12:03:06PM +0100, Thomas Monjalon wrote: > > We need attention of every PMD developers on this thread. > > I've been following this thread from the beginning while working on rte_flow > and wanted to see where it was headed before replying. (I know, v11 was

[dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-11-30 Thread Kulasek, TomaszX
Hi, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, November 30, 2016 09:50 > To: Adrien Mazarguil ; Kulasek, TomaszX > > Cc: dev at dpdk.org; Ananyev, Konstantin ; > olivier.matz at 6wind.com > Subject: Re: [

[dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-11-30 Thread Thomas Monjalon
2016-11-30 08:40, Adrien Mazarguil: [...] > I understand tx_prep() automates this process, however I'm wondering why > isn't the TX burst function doing that itself. Using nb_mtu_seg_max as an > example, tx_prep() has an extra check in case of TSO that the TX burst > function does not perform. This

[dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-11-30 Thread Adrien Mazarguil
On Mon, Nov 28, 2016 at 12:03:06PM +0100, Thomas Monjalon wrote: > We need attention of every PMD developers on this thread. I've been following this thread from the beginning while working on rte_flow and wanted to see where it was headed before replying. (I know, v11 was submitted about 1 month

[dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-11-30 Thread John Daley (johndale)
> ; Alejandro Lucero > ; Harish Patil > ; Rasesh Mody ; Jerin > Jacob ; Yuanhan Liu > ; Yong Wang > Cc: Tomasz Kulasek ; > konstantin.ananyev at intel.com; olivier.matz at 6wind.com > Subject: Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation > > We need attention of

[dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-11-28 Thread Thomas Monjalon
We need attention of every PMD developers on this thread. Reminder of what Konstantin suggested: " - if the PMD supports TX offloads AND - if to be able use any of these offloads the upper layer SW would have to: * modify the contents of the packet OR * obey HW specific restrictions then i

[dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-11-23 Thread Tomasz Kulasek
As discussed in that thread: http://dpdk.org/ml/archives/dev/2015-September/023603.html Different NIC models depending on HW offload requested might impose different requirements on packets to be TX-ed in terms of: - Max number of fragments per packet allowed - Max number of fragments per TSO