[GitHub] paul-rogers commented on issue #1403: DRILL-6634: Add udf module under contrib directory and move some udfs into it

paul-rogers commented on issue #1403: DRILL-6634: Add udf module under contrib directory and move some udfs into it URL: https://github.com/apache/drill/pull/1403#issuecomment-409084223 @arina-ielchiieva, if the test dependencies are available than all is good. Any remaining issues can be

[GitHub] Ben-Zvi commented on a change in pull request #1409: DRILL-6644: Don't reserve space for incoming probe batches unnecessarily during the build phase.

Ben-Zvi commented on a change in pull request #1409: DRILL-6644: Don't reserve space for incoming probe batches unnecessarily during the build phase. URL: https://github.com/apache/drill/pull/1409#discussion_r206370742 ## File path:

[GitHub] parthchandra commented on issue #1399: DRILL-6631: Streaming agg causes queries with Lateral and Unnest to r…

parthchandra commented on issue #1399: DRILL-6631: Streaming agg causes queries with Lateral and Unnest to r… URL: https://github.com/apache/drill/pull/1399#issuecomment-409057440 @ilooner yes this is ready to commit This is

[GitHub] parthchandra commented on a change in pull request #1399: DRILL-6631: Streaming agg causes queries with Lateral and Unnest to r…

parthchandra commented on a change in pull request #1399: DRILL-6631: Streaming agg causes queries with Lateral and Unnest to r… URL: https://github.com/apache/drill/pull/1399#discussion_r206365440 ## File path:

[GitHub] amansinha100 commented on issue #1407: PartitionLimit changes for Lateral and Unnest.

amansinha100 commented on issue #1407: PartitionLimit changes for Lateral and Unnest. URL: https://github.com/apache/drill/pull/1407#issuecomment-409055597 +1 for the DRILL-6636 (commit 9351cc6b6d593fedefc4411d0cd9a95dc89eb152). cc @HanumathRao .

[GitHub] amansinha100 commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest

amansinha100 commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest URL: https://github.com/apache/drill/pull/1401#discussion_r206363481 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/FilterPrel.java

[GitHub] amansinha100 commented on a change in pull request #1407: PartitionLimit changes for Lateral and Unnest.

amansinha100 commented on a change in pull request #1407: PartitionLimit changes for Lateral and Unnest. URL: https://github.com/apache/drill/pull/1407#discussion_r206361495 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/LimitPrel.java

[GitHub] amansinha100 commented on a change in pull request #1407: PartitionLimit changes for Lateral and Unnest.

amansinha100 commented on a change in pull request #1407: PartitionLimit changes for Lateral and Unnest. URL: https://github.com/apache/drill/pull/1407#discussion_r206261710 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/LimitPrel.java

[GitHub] amansinha100 commented on a change in pull request #1407: PartitionLimit changes for Lateral and Unnest.

amansinha100 commented on a change in pull request #1407: PartitionLimit changes for Lateral and Unnest. URL: https://github.com/apache/drill/pull/1407#discussion_r206261027 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/LimitPrel.java

[VOTE] Apache Drill release 1.14.0 - RC2

 Hi Drillers,     Proposing the *third* Release Candidate (RC2) for the Apache Drill, version 1.14.0 . This RC2 includes 235 committed Jiras [1]. Thanks to all the Drill developers who works hard and contributed to this release. The RC2 tarballs are hosted at [2] , and the Maven artifacts

[GitHub] gparai commented on issue #1372: DRILL-6589: Push transitive closure predicates past aggregates/projects

gparai commented on issue #1372: DRILL-6589: Push transitive closure predicates past aggregates/projects URL: https://github.com/apache/drill/pull/1372#issuecomment-409037074 @ilooner I do not think these are related to changes in this PR. Anyways, I have rebased to latest-master and see

[GitHub] ilooner commented on issue #1372: DRILL-6589: Push transitive closure predicates past aggregates/projects

ilooner commented on issue #1372: DRILL-6589: Push transitive closure predicates past aggregates/projects URL: https://github.com/apache/drill/pull/1372#issuecomment-409029716 @gparai It looks like this change has compilation issues with the latest master. Could you rebase onto the latest

Re: [VOTE] Apache Drill release 1.14.0 - RC1

 Hi Arina,     The RC1 (and now RC2) are being built in a separate branch - 1.14.0 ; building the RC.. over the master would require a forced push (as the top of master is marked 1.15.0-SNAPSHOT). We can just work by cherry-picking the needed commits into the 1.14.0 branch. It is about the

[GitHub] ilooner commented on issue #1399: DRILL-6631: Streaming agg causes queries with Lateral and Unnest to r…

ilooner commented on issue #1399: DRILL-6631: Streaming agg causes queries with Lateral and Unnest to r… URL: https://github.com/apache/drill/pull/1399#issuecomment-409023836 @parthchandra @Ben-Zvi is this still ready to commit? I see a couple of minor unaddressed comments.

[GitHub] ilooner closed pull request #1404: DRILL-6639: Exception happens while displaying operator profiles for …

ilooner closed pull request #1404: DRILL-6639: Exception happens while displaying operator profiles for … URL: https://github.com/apache/drill/pull/1404 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] ilooner closed pull request #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics

ilooner closed pull request #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics URL: https://github.com/apache/drill/pull/1406 This is a PR merged from a forked repository. As GitHub hides the original

[GitHub] ilooner closed pull request #1402: DRILL-6638: Fix TestE2EUnnestAndLateral tests introduced with DRILL-6546

ilooner closed pull request #1402: DRILL-6638: Fix TestE2EUnnestAndLateral tests introduced with DRILL-6546 URL: https://github.com/apache/drill/pull/1402 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

Re: [VOTE] Apache Drill release 1.14.0 - RC1

Hi Boaz, it's unfortunate we have to have second iteration of RC. New RC will contain two commits (one from previous iteration) from: https://github.com/apache/drill/pull/1404 https://github.com/apache/drill/pull/1406 But I believe we should merge them into master first before creating new RC.

Re: [VOTE] Apache Drill release 1.14.0 - RC1

  OK -- RC1 is off; will produce RC2 soon with the PR #1406 (and thanks Vitalii for the other comments) Boaz On 7/30/18 9:53 AM, Charles Givre wrote: I attempted to build from source and got the following errors: Results : Failed tests:

[GitHub] ilooner opened a new pull request #1409: DRILL-6644: Don't reserve space for incoming probe batches unnecessarily during the build phase.

ilooner opened a new pull request #1409: DRILL-6644: Don't reserve space for incoming probe batches unnecessarily during the build phase. URL: https://github.com/apache/drill/pull/1409 ## Problem Previously the memory calculator for HashJoin was reserving space for the worst case

[GitHub] ilooner opened a new pull request #1408: DRILL-6453: Resolve deadlock when reading from build and probe sides simultaneously in HashJoin

ilooner opened a new pull request #1408: DRILL-6453: Resolve deadlock when reading from build and probe sides simultaneously in HashJoin URL: https://github.com/apache/drill/pull/1408 # The Problem Originally hash join sniffed the first data holding batch in the probe and build

[GitHub] vvysotskyi commented on a change in pull request #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics

vvysotskyi commented on a change in pull request #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics URL: https://github.com/apache/drill/pull/1406#discussion_r206262927 ## File path:

[GitHub] amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature

amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-408948442 Since most of my comments have been addressed, I am +1. Thanks @weijietong. Once you address @sohami 's comments, the next steps would be:

[GitHub] vrozov commented on a change in pull request #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics

vrozov commented on a change in pull request #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics URL: https://github.com/apache/drill/pull/1406#discussion_r206253131 ## File path:

[GitHub] HanumathRao commented on issue #1401: DRILL-6616: Batch Processing for Lateral/Unnest

HanumathRao commented on issue #1401: DRILL-6616: Batch Processing for Lateral/Unnest URL: https://github.com/apache/drill/pull/1401#issuecomment-408937958 @amansinha100 Thank you for the review. I have made changes to the code. Please let me know if any other changes are needed.

[GitHub] HanumathRao commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest

HanumathRao commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest URL: https://github.com/apache/drill/pull/1401#discussion_r206249771 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java

[GitHub] HanumathRao commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest

HanumathRao commented on a change in pull request #1401: DRILL-6616: Batch Processing for Lateral/Unnest URL: https://github.com/apache/drill/pull/1401#discussion_r206249561 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/FilterPrel.java

Re: [VOTE] Apache Drill release 1.14.0 - RC1

I attempted to build from source and got the following errors: Results : Failed tests: TestConvertCountToDirectScan.ensureCorrectCountWithMissingStatistics:153->PlanTestBase.testPlanMatchingPatterns:84->PlanTestBase.testPlanMatchingPatterns:103 Found unwanted pattern in plan:

[GitHub] vvysotskyi commented on a change in pull request #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics

vvysotskyi commented on a change in pull request #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics URL: https://github.com/apache/drill/pull/1406#discussion_r206245343 ## File path:

[GitHub] sohami commented on issue #1401: DRILL-6616: Batch Processing for Lateral/Unnest

sohami commented on issue #1401: DRILL-6616: Batch Processing for Lateral/Unnest URL: https://github.com/apache/drill/pull/1401#issuecomment-408920143 +1 for changes related to DRILL-6618: Unnest changes for implicit column.

[GitHub] sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

sohami commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r205962087 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/BloomFilterCreator.java ## @@ -0,0 +1,41

[GitHub] vrozov commented on a change in pull request #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics

vrozov commented on a change in pull request #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics URL: https://github.com/apache/drill/pull/1406#discussion_r206211786 ## File path:

[GitHub] vrozov commented on a change in pull request #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics

vrozov commented on a change in pull request #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics URL: https://github.com/apache/drill/pull/1406#discussion_r206192588 ## File path:

Re: [VOTE] Apache Drill release 1.14.0 - RC1

Hi all! I'm in the process of verifying the Drill RC1. And I always get BUILD FAILURE for "mvn clean install". It is related to DRILL-6641 (PR is on review). It fails randomly from Jira description, but for me the test fails every time. Does anybody else have this issue? Or maybe it is my local

[GitHub] amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r206189964 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java ## @@

[GitHub] amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

amansinha100 commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r206188551 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/BloomFilterCreator.java ## @@ -0,0

[jira] [Created] (DRILL-6647) Update Calcite version to 1.17.0

Volodymyr Vysotskyi created DRILL-6647: -- Summary: Update Calcite version to 1.17.0 Key: DRILL-6647 URL: https://issues.apache.org/jira/browse/DRILL-6647 Project: Apache Drill Issue

[GitHub] vvysotskyi commented on a change in pull request #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics

vvysotskyi commented on a change in pull request #1406: DRILL-6641: Fix columnValueCounts in ParquetGroupScanStatistics when ParquetGroupScan has RowGroupInfo without column statistics URL: https://github.com/apache/drill/pull/1406#discussion_r206145290 ## File path:

Re: Metadata management improvement

Hello, Thanks a lot for all these feedbacks, trying to respond to everything below: @Parth: "I don't think we would want to maintain a TTL for the metadata store so introducing one now would mean that we might break backward compatibility down the road." Yes, I am aware of this activity

[GitHub] weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r206055252 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/BloomFilterCreator.java ## @@ -0,0

[GitHub] weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature

weijietong commented on a change in pull request #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#discussion_r206054896 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/work/filter/BloomFilter.java ## @@ -0,0 +1,176

[GitHub] jbimbert commented on issue #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file

jbimbert commented on issue #1298: DRILL-5796: Filter pruning for multi rowgroup parquet file URL: https://github.com/apache/drill/pull/1298#issuecomment-408788137 @vrozov Done. This is an automated message from the Apache