[GitHub] kkhatua commented on issue #1279: DRILL-5735: Allow search/sort in the Options webUI

2018-08-20 Thread GitBox
kkhatua commented on issue #1279: DRILL-5735: Allow search/sort in the Options webUI URL: https://github.com/apache/drill/pull/1279#issuecomment-414550320 Done. Rebased and squashed. Cleared unit and functional tests. This

[GitHub] bbevens commented on issue #1435: Parquet compression is disabled by default

2018-08-20 Thread GitBox
bbevens commented on issue #1435: Parquet compression is disabled by default URL: https://github.com/apache/drill/pull/1435#issuecomment-414500798 I've updated the doc to change default type from snappy to none. This pull request can be closed. Thanks!

[GitHub] bbevens commented on issue #1292: Add doc: Using Saiku Analytics with Apache Drill

2018-08-20 Thread GitBox
bbevens commented on issue #1292: Add doc: Using Saiku Analytics with Apache Drill URL: https://github.com/apache/drill/pull/1292#issuecomment-414499979 Hi @brenopolanski, I created an Ecosystem section where we will add community and commercial offerings based on Apache Drill. I created

[GitHub] Ben-Zvi closed pull request #1433: DRILL-6685: Fixed exception when reading Parquet data

2018-08-20 Thread GitBox
Ben-Zvi closed pull request #1433: DRILL-6685: Fixed exception when reading Parquet data URL: https://github.com/apache/drill/pull/1433 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[jira] [Created] (DRILL-6702) OperatingSystemMXBean class cast exception when loaded under IBM JVM

2018-08-20 Thread Rob Wu (JIRA)
Rob Wu created DRILL-6702: - Summary: OperatingSystemMXBean class cast exception when loaded under IBM JVM Key: DRILL-6702 URL: https://issues.apache.org/jira/browse/DRILL-6702 Project: Apache Drill

Re: Drill Hangout tomorrow 08/21

2018-08-20 Thread Volodymyr Vysotskyi
Hi all, I and Vitalii Diravka want to give the presentation with our ideas connected with Drill Metadata management project (DRILL-6552 ). We will be happy to discuss it and choose the right way for further development. Kind regards, Volodymyr

[jira] [Created] (DRILL-6701) Non-admin users can access options page via restapi

2018-08-20 Thread Krystal (JIRA)
Krystal created DRILL-6701: -- Summary: Non-admin users can access options page via restapi Key: DRILL-6701 URL: https://issues.apache.org/jira/browse/DRILL-6701 Project: Apache Drill Issue Type: Bug

Drill Hangout tomorrow 08/21

2018-08-20 Thread Hanumath Rao Maduri
The Apache Drill Hangout will be held tomorrow at 10:00am PST; please let us know should you have a topic for tomorrow's hangout. We will also ask for topics at the beginning of the hangout. Hangout Link - https://hangouts.google.com/hangouts/_/event/ci4rdiju8bv04a64efj5fedd0lc Regards, Hanu

[GitHub] ilooner commented on issue #1405: DRILL-6640: Modifying DotDrillUtil implementation to avoid using globStatus calls

2018-08-20 Thread GitBox
ilooner commented on issue #1405: DRILL-6640: Modifying DotDrillUtil implementation to avoid using globStatus calls URL: https://github.com/apache/drill/pull/1405#issuecomment-414435259 Sorry for the delayed review @kr-arjun. Please use BaseDirTestWatcher for creating temp directories in

[GitHub] vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-20 Thread GitBox
vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r211361059 ## File path: common/src/test/java/org/apache/drill/test/SubDirTestWatcher.java ## @@ -83,10

Re: "Crude-but-effective" Arrow integration

2018-08-20 Thread Paul Rogers
Hi Ted, We may be confusing two very different ideas. The one is a Drill-to-Arrow adapter on Drill's periphery, this is the "crude-but-effective" integration suggestion. On the periphery we are not changing existing code, we're just building an adapter to read Arrow data into Drill, or convert

[GitHub] vrozov commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-20 Thread GitBox
vrozov commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r211351021 ## File path: common/src/test/java/org/apache/drill/test/SubDirTestWatcher.java ## @@ -83,10

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-20 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r211344318 ## File path: common/src/test/java/org/apache/drill/test/SubDirTestWatcher.java ## @@ -83,10

[GitHub] amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature

2018-08-20 Thread GitBox
amansinha100 commented on issue #1334: DRILL-6385: Support JPPD feature URL: https://github.com/apache/drill/pull/1334#issuecomment-414392376 @sohami thanks for the detailed follow-up review and running the regression tests with the PR (I assume with default setting of run-time pushdown

[jira] [Created] (DRILL-6700) Graceful shutdown from command line against parquet tables fails

2018-08-20 Thread Krystal (JIRA)
Krystal created DRILL-6700: -- Summary: Graceful shutdown from command line against parquet tables fails Key: DRILL-6700 URL: https://issues.apache.org/jira/browse/DRILL-6700 Project: Apache Drill

[GitHub] vrozov commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-20 Thread GitBox
vrozov commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r211334757 ## File path: common/src/test/java/org/apache/drill/test/SubDirTestWatcher.java ## @@ -83,10

Re: "Crude-but-effective" Arrow integration

2018-08-20 Thread Ted Dunning
Inline. On Mon, Aug 20, 2018 at 9:20 AM Paul Rogers wrote: > ... > By contrast, migrating Drill internals to Arrow has always been seen as > the bulk of the cost; costs which the "crude-but-effective" suggestion > seeks to avoid. Some of the full-integration costs include: > > * Reworking

Re: "Crude-but-effective" Arrow integration

2018-08-20 Thread Paul Rogers
Hi Ted, The "crude but effective" integration suggestion allows Drill to participate in an Arrow pipeline with minimal work. By contrast, migrating Drill internals to Arrow has always been seen as the bulk of the cost; costs which the "crude-but-effective" suggestion seeks to avoid. Some of

Re: "Crude-but-effective" Arrow integration

2018-08-20 Thread Paul Rogers
Hi Charles, Regarding UDFs and Arrow: if Arrow is used just as an interface format (as outlined in the original post), then Drill's internals continue to use Drill value vectors and UDFs are unchanged. If Arrow is adopted internally in Drill, then vast amounts of runtime code must change (see

[GitHub] vvysotskyi commented on issue #1264: DRILL-6422: Update guava to 23.0 and shade it

2018-08-20 Thread GitBox
vvysotskyi commented on issue #1264: DRILL-6422: Update guava to 23.0 and shade it URL: https://github.com/apache/drill/pull/1264#issuecomment-414372108 @vrozov, I don't mind of creating a separate PR, but I still think that it is unnecessary, since we need to merge the first PR, publish

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-20 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r211279104 ## File path: common/src/test/java/org/apache/drill/test/SubDirTestWatcher.java ## @@ -83,10

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-20 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r211305912 ## File path:

[GitHub] vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-20 Thread GitBox
vvysotskyi commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r211305444 ## File path:

[GitHub] sachouche commented on issue #1433: DRILL-6685: Fixed exception when reading Parquet data

2018-08-20 Thread GitBox
sachouche commented on issue #1433: DRILL-6685: Fixed exception when reading Parquet data URL: https://github.com/apache/drill/pull/1433#issuecomment-414368128 Arina, - First of all, thank you for the review! - With regard to the test, I see your point as I have considered the same;

Re: "Crude-but-effective" Arrow integration

2018-08-20 Thread Ted Dunning
This makes it sound like allocation is the important difference. As such that might mean that converting drill would be easier than was thought. On Sat, Aug 18, 2018, 16:44 Paul Rogers wrote: > Hi All, > > Charles recently suggested why Arrow integration could be helpful. (See > quote below.)

Re: "Crude-but-effective" Arrow integration

2018-08-20 Thread Charles Givre
Hi Paul, This is a very interesting approach. i really like the concept in that it sounds like we could prove the value of the Arrow integration without “major surgery” to Drill. If it proves to be valuable we could proceed with deeper integration, or if we determine that it is not

[GitHub] vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-20 Thread GitBox
vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r211243710 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaFilter.java

[GitHub] vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-20 Thread GitBox
vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r211242647 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/schema/ObjectSchema.java ##

[GitHub] vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-20 Thread GitBox
vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r211214140 ## File path:

[GitHub] vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-20 Thread GitBox
vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r211236890 ## File path:

[GitHub] vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-20 Thread GitBox
vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r211232521 ## File path:

[GitHub] vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-20 Thread GitBox
vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r211240663 ## File path:

[GitHub] vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-20 Thread GitBox
vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r211237733 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZookeeperClient.java

[GitHub] vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-20 Thread GitBox
vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r211213987 ## File path: common/src/test/java/org/apache/drill/test/SubDirTestWatcher.java ## @@ -83,10

[GitHub] vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-20 Thread GitBox
vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r211222476 ## File path:

[GitHub] vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-20 Thread GitBox
vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r211228814 ## File path:

[GitHub] vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-20 Thread GitBox
vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r211218552 ## File path:

[GitHub] vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-20 Thread GitBox
vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r211202697 ## File path: common/src/main/java/org/apache/drill/common/KerberosUtil.java ## @@ -57,9 +57,9

[GitHub] vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-20 Thread GitBox
vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r211243271 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java

[GitHub] vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones

2018-08-20 Thread GitBox
vdiravka commented on a change in pull request #1397: DRILL-6633: Replace usage of Guava classes by JDK ones URL: https://github.com/apache/drill/pull/1397#discussion_r211200356 ## File path:

[GitHub] arina-ielchiieva commented on issue #1409: DRILL-6644: Don't reserve space for incoming probe batches unnecessarily during the build phase.

2018-08-20 Thread GitBox
arina-ielchiieva commented on issue #1409: DRILL-6644: Don't reserve space for incoming probe batches unnecessarily during the build phase. URL: https://github.com/apache/drill/pull/1409#issuecomment-414274214 @ilooner I'll remove ready-to-commit label, please put it back when test

[GitHub] arina-ielchiieva commented on issue #1433: DRILL-6685: Fixed exception when reading Parquet data

2018-08-20 Thread GitBox
arina-ielchiieva commented on issue #1433: DRILL-6685: Fixed exception when reading Parquet data URL: https://github.com/apache/drill/pull/1433#issuecomment-414271589 @sachouche I don't have strong opinion of that, so PR can go as is, though since all your tests using the same options,

[GitHub] arina-ielchiieva commented on issue #1279: DRILL-5735: Allow search/sort in the Options webUI

2018-08-20 Thread GitBox
arina-ielchiieva commented on issue #1279: DRILL-5735: Allow search/sort in the Options webUI URL: https://github.com/apache/drill/pull/1279#issuecomment-414270793 @kkhatua please squash the commits. This is an automated

[GitHub] arina-ielchiieva commented on a change in pull request #1126: DRILL-6179: Added pcapng-format support

2018-08-20 Thread GitBox
arina-ielchiieva commented on a change in pull request #1126: DRILL-6179: Added pcapng-format support URL: https://github.com/apache/drill/pull/1126#discussion_r211207014 ## File path: protocol/src/main/protobuf/UserBitShared.proto ## @@ -343,6 +343,7 @@ enum

[GitHub] arina-ielchiieva commented on a change in pull request #1126: DRILL-6179: Added pcapng-format support

2018-08-20 Thread GitBox
arina-ielchiieva commented on a change in pull request #1126: DRILL-6179: Added pcapng-format support URL: https://github.com/apache/drill/pull/1126#discussion_r211205567 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcapng/PcapngFormatPlugin.java

[GitHub] Vlad-Storona commented on issue #1126: DRILL-6179: Added pcapng-format support

2018-08-20 Thread GitBox
Vlad-Storona commented on issue #1126: DRILL-6179: Added pcapng-format support URL: https://github.com/apache/drill/pull/1126#issuecomment-414262364 @paul-rogers thanks for the great review. This is an automated message from

[jira] [Created] (DRILL-6699) Drill client session authorization

2018-08-20 Thread Oleksandr Kalinin (JIRA)
Oleksandr Kalinin created DRILL-6699: Summary: Drill client session authorization Key: DRILL-6699 URL: https://issues.apache.org/jira/browse/DRILL-6699 Project: Apache Drill Issue Type: