[GitHub] [drill] bitblender commented on a change in pull request #1702: DRILL-7107 Unable to connect to Drill 1.15 through ZK

bitblender commented on a change in pull request #1702: DRILL-7107 Unable to connect to Drill 1.15 through ZK URL: https://github.com/apache/drill/pull/1702#discussion_r268885320 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java ##

[GitHub] [drill] kkhatua commented on issue #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

kkhatua commented on issue #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#issuecomment-476368650 @vvysotskyi made changes and verified that tests passed. ---

[GitHub] [drill] kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r268800813 ## File path: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java #

[GitHub] [drill] kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r268772086 ## File path: exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillPreparedStatement.java ##

[GitHub] [drill] kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r268771066 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java ###

[GitHub] [drill] kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r268769689 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java ###

[GitHub] [drill] kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r268768631 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOptio

[GitHub] [drill] kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r268767703 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java ###

[GitHub] [drill] kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r268767018 ## File path: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java #

[GitHub] [drill] kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r268766977 ## File path: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl

[GitHub] [drill] kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

kkhatua commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r268766549 ## File path: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java #

[GitHub] [drill] sohami commented on a change in pull request #1681: DRILL-7051: Upgrade jetty

sohami commented on a change in pull request #1681: DRILL-7051: Upgrade jetty URL: https://github.com/apache/drill/pull/1681#discussion_r268740814 ## File path: pom.xml ## @@ -2553,7 +2548,13 @@ 4.0.1 provided - + +

Re: [DISCUSS] 1.16.0 release

Hi Aman Thanks for the information. Given we need 2 weeks of estimated dev effort for parquet metadata caching and other open items have also estimated similar remaining effort, I would like to propose first release cut-off date as *Apr 8, 2019.* Please try to include all the major feature work by

[GitHub] [drill] arina-ielchiieva commented on issue #1680: DRILL-7077: Add Function to Facilitate Time Series Analysis

arina-ielchiieva commented on issue #1680: DRILL-7077: Add Function to Facilitate Time Series Analysis URL: https://github.com/apache/drill/pull/1680#issuecomment-476264054 +1, LGTM. Please squash the commits. This is an a

[GitHub] [drill] ihuzenko commented on a change in pull request #1680: DRILL-7077: Add Function to Facilitate Time Series Analysis

ihuzenko commented on a change in pull request #1680: DRILL-7077: Add Function to Facilitate Time Series Analysis URL: https://github.com/apache/drill/pull/1680#discussion_r268716085 ## File path: contrib/udfs/src/test/java/org/apache/drill/exec/udfs/TestNearestDateFunctions.java

[GitHub] [drill] ihuzenko commented on a change in pull request #1680: DRILL-7077: Add Function to Facilitate Time Series Analysis

ihuzenko commented on a change in pull request #1680: DRILL-7077: Add Function to Facilitate Time Series Analysis URL: https://github.com/apache/drill/pull/1680#discussion_r268714887 ## File path: contrib/udfs/src/main/java/org/apache/drill/exec/udfs/NearestDateUtils.java

[GitHub] [drill] cgivre commented on issue #1637: DRILL-7032: Ignore corrupt rows in a PCAP file

cgivre commented on issue #1637: DRILL-7032: Ignore corrupt rows in a PCAP file URL: https://github.com/apache/drill/pull/1637#issuecomment-476254011 Commits squashed. Thanks! This is an automated message from the Apache Git

[GitHub] [drill] arina-ielchiieva commented on issue #1637: DRILL-7032: Ignore corrupt rows in a PCAP file

arina-ielchiieva commented on issue #1637: DRILL-7032: Ignore corrupt rows in a PCAP file URL: https://github.com/apache/drill/pull/1637#issuecomment-476251224 +1, LGTM. @cgivre please squash the commits. This is an automated

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r268658212 ## File path: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementI

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r268655998 ## File path: exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillPreparedStatement.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r268650777 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/SystemOp

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r268648485 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r268659959 ## File path: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java

[GitHub] [drill] cgivre commented on a change in pull request #1637: DRILL-7032: Ignore corrupt rows in a PCAP file

cgivre commented on a change in pull request #1637: DRILL-7032: Ignore corrupt rows in a PCAP file URL: https://github.com/apache/drill/pull/1637#discussion_r268688621 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/decoder/Packet.java ## @@ -3

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r268658531 ## File path: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillStatementImpl.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r268660625 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r268647133 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r268656219 ## File path: exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillStatement.java

[GitHub] [drill] vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option

vvysotskyi commented on a change in pull request #1714: DRILL-7048: Implement JDBC Statement.setMaxRows() with System Option URL: https://github.com/apache/drill/pull/1714#discussion_r268656547 ## File path: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillCursor.java ##

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1711: DRILL-7011: Support schema in scan framework

arina-ielchiieva commented on a change in pull request #1711: DRILL-7011: Support schema in scan framework URL: https://github.com/apache/drill/pull/1711#discussion_r268603780 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/easy/text/compliant/TestCsvWithSche

[GitHub] [drill] arina-ielchiieva edited a comment on issue #1711: DRILL-7011: Support schema in scan framework

arina-ielchiieva edited a comment on issue #1711: DRILL-7011: Support schema in scan framework URL: https://github.com/apache/drill/pull/1711#issuecomment-476166889 @paul-rogers Actually when I was presenting the schema provisioning design, there were a proposal to add schema property

[GitHub] [drill] arina-ielchiieva commented on issue #1711: DRILL-7011: Support schema in scan framework

arina-ielchiieva commented on issue #1711: DRILL-7011: Support schema in scan framework URL: https://github.com/apache/drill/pull/1711#issuecomment-476166889 @paul-rogers Actually when I was presenting the schema provisioning design, there were a proposal to add schema property `drill.

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1711: DRILL-7011: Support schema in scan framework

arina-ielchiieva commented on a change in pull request #1711: DRILL-7011: Support schema in scan framework URL: https://github.com/apache/drill/pull/1711#discussion_r268603780 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/easy/text/compliant/TestCsvWithSche

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1711: DRILL-7011: Support schema in scan framework

arina-ielchiieva commented on a change in pull request #1711: DRILL-7011: Support schema in scan framework URL: https://github.com/apache/drill/pull/1711#discussion_r268604275 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/easy/text/compliant/TestCsvWithSche

[GitHub] [drill] vdiravka commented on a change in pull request #1672: DRILL-7049 return VARBINARY as a string with escaped non printable bytes

vdiravka commented on a change in pull request #1672: DRILL-7049 return VARBINARY as a string with escaped non printable bytes URL: https://github.com/apache/drill/pull/1672#discussion_r268565353 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/util/ValueVectorEleme

[GitHub] [drill] vdiravka commented on a change in pull request #1681: DRILL-7051: Upgrade jetty

vdiravka commented on a change in pull request #1681: DRILL-7051: Upgrade jetty URL: https://github.com/apache/drill/pull/1681#discussion_r268551237 ## File path: pom.xml ## @@ -85,6 +85,7 @@ 0.9.10 1.8.2 4.0.2 +9.4.15.v20190215 Review comment: Fina

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1637: DRILL-7032: Ignore corrupt rows in a PCAP file

arina-ielchiieva commented on a change in pull request #1637: DRILL-7032: Ignore corrupt rows in a PCAP file URL: https://github.com/apache/drill/pull/1637#discussion_r268515281 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/decoder/Packet.java ###

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1637: DRILL-7032: Ignore corrupt rows in a PCAP file

arina-ielchiieva commented on a change in pull request #1637: DRILL-7032: Ignore corrupt rows in a PCAP file URL: https://github.com/apache/drill/pull/1637#discussion_r268515281 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/decoder/Packet.java ###