[GitHub] [drill] paul-rogers commented on issue #1830: DRILL-7333: Set container record count where missing

2019-07-29 Thread GitBox
paul-rogers commented on issue #1830: DRILL-7333: Set container record count where missing URL: https://github.com/apache/drill/pull/1830#issuecomment-516247510 @arina-ielchiieva, thanks much for the reviews and the suggestions. I would tend to doubt that the RPC errors I'm seeing are due

[GitHub] [drill] paul-rogers commented on issue #1829: DRILL-7096: Develop vector for canonical Map

2019-07-29 Thread GitBox
paul-rogers commented on issue #1829: DRILL-7096: Develop vector for canonical Map URL: https://github.com/apache/drill/pull/1829#issuecomment-516246460 @KazydubB, thanks for the explanations. Probably not productive for us to continue to debate the design now that the code is done.

Re: [ANNOUNCE] New Committer: Anton Gozhyi

2019-07-29 Thread Anton Gozhiy
Thank you all, I'm glad to be part of the community! On Mon, Jul 29, 2019 at 8:11 PM Kunal Khatua wrote: > Congratulations, Anton!! Very well deserved! > On 7/29/2019 9:11:30 AM, Vitalii Diravka wrote: > My congratulations Anton! You deserved it! > > Kind regards > Vitalii > > > On Mon, Jul

Re: [ANNOUNCE] New Committer: Anton Gozhyi

2019-07-29 Thread Kunal Khatua
Congratulations, Anton!! Very well deserved! On 7/29/2019 9:11:30 AM, Vitalii Diravka wrote: My congratulations Anton! You deserved it! Kind regards Vitalii On Mon, Jul 29, 2019 at 1:13 PM Arina Ielchiieva wrote: > Congratulations Anton! Thanks for your contributions. > > Kind regards, >

Re: [ANNOUNCE] New Committer: Anton Gozhyi

2019-07-29 Thread Vitalii Diravka
My congratulations Anton! You deserved it! Kind regards Vitalii On Mon, Jul 29, 2019 at 1:13 PM Arina Ielchiieva wrote: > Congratulations Anton! Thanks for your contributions. > > Kind regards, > Arina > > On Mon, Jul 29, 2019 at 12:55 PM Павел Семенов > > wrote: > > > Congratulations Anton

[GitHub] [drill] KazydubB edited a comment on issue #1829: DRILL-7096: Develop vector for canonical Map

2019-07-29 Thread GitBox
KazydubB edited a comment on issue #1829: DRILL-7096: Develop vector for canonical Map URL: https://github.com/apache/drill/pull/1829#issuecomment-516003913 Hi @paul-rogers, thank you for your elaborate comment. This map is intended to be a map in Java's sense, with strict key and map

[GitHub] [drill] KazydubB commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map

2019-07-29 Thread GitBox
KazydubB commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map URL: https://github.com/apache/drill/pull/1829#discussion_r308254638 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetReader.java

[GitHub] [drill] KazydubB commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map

2019-07-29 Thread GitBox
KazydubB commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map URL: https://github.com/apache/drill/pull/1829#discussion_r308256681 ## File path: exec/vector/src/main/java/org/apache/drill/exec/vector/complex/TrueMapVector.java ## @@

[GitHub] [drill] KazydubB commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map

2019-07-29 Thread GitBox
KazydubB commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map URL: https://github.com/apache/drill/pull/1829#discussion_r308254061 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java ## @@

[GitHub] [drill] KazydubB commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map

2019-07-29 Thread GitBox
KazydubB commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map URL: https://github.com/apache/drill/pull/1829#discussion_r308253708 ## File path: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java

[GitHub] [drill] KazydubB commented on issue #1829: DRILL-7096: Develop vector for canonical Map

2019-07-29 Thread GitBox
KazydubB commented on issue #1829: DRILL-7096: Develop vector for canonical Map URL: https://github.com/apache/drill/pull/1829#issuecomment-516003913 Hi @paul-rogers, thank you for your elaborate answer. This map is intended to be a map in Java's sense, with strict key and map types.

[GitHub] [drill] agozhiy commented on issue #1825: DRILL-7084: ResultSet getObject method throws not implemented excepti…

2019-07-29 Thread GitBox
agozhiy commented on issue #1825: DRILL-7084: ResultSet getObject method throws not implemented excepti… URL: https://github.com/apache/drill/pull/1825#issuecomment-515993881 @KazydubB, I addressed your comments, could you please review?

[GitHub] [drill] agozhiy commented on a change in pull request #1825: DRILL-7084: ResultSet getObject method throws not implemented excepti…

2019-07-29 Thread GitBox
agozhiy commented on a change in pull request #1825: DRILL-7084: ResultSet getObject method throws not implemented excepti… URL: https://github.com/apache/drill/pull/1825#discussion_r308231790 ## File path: exec/jdbc/src/test/java/org/apache/drill/jdbc/DrillResultSetTest.java

[GitHub] [drill] agozhiy commented on a change in pull request #1825: DRILL-7084: ResultSet getObject method throws not implemented excepti…

2019-07-29 Thread GitBox
agozhiy commented on a change in pull request #1825: DRILL-7084: ResultSet getObject method throws not implemented excepti… URL: https://github.com/apache/drill/pull/1825#discussion_r308225518 ## File path: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillResultSetImpl.java

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map

2019-07-29 Thread GitBox
arina-ielchiieva commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map URL: https://github.com/apache/drill/pull/1829#discussion_r308201572 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetComplex.java

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map

2019-07-29 Thread GitBox
arina-ielchiieva commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map URL: https://github.com/apache/drill/pull/1829#discussion_r308201572 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetComplex.java

[GitHub] [drill] ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map

2019-07-29 Thread GitBox
ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map URL: https://github.com/apache/drill/pull/1829#discussion_r308168057 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetGroupConverter.java

[GitHub] [drill] ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map

2019-07-29 Thread GitBox
ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map URL: https://github.com/apache/drill/pull/1829#discussion_r308171788 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetReader.java

[GitHub] [drill] ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map

2019-07-29 Thread GitBox
ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map URL: https://github.com/apache/drill/pull/1829#discussion_r308161746 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/record/TypedFieldId.java ## @@ -188,6

[GitHub] [drill] ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map

2019-07-29 Thread GitBox
ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map URL: https://github.com/apache/drill/pull/1829#discussion_r308173710 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetReader.java

[GitHub] [drill] ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map

2019-07-29 Thread GitBox
ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map URL: https://github.com/apache/drill/pull/1829#discussion_r308153779 ## File path: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java

[GitHub] [drill] ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map

2019-07-29 Thread GitBox
ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map URL: https://github.com/apache/drill/pull/1829#discussion_r308156608 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatchSizer.java ## @@

[GitHub] [drill] ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map

2019-07-29 Thread GitBox
ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map URL: https://github.com/apache/drill/pull/1829#discussion_r308194929 ## File path: exec/vector/src/main/java/org/apache/drill/exec/vector/complex/TrueMapVector.java ## @@

[GitHub] [drill] ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map

2019-07-29 Thread GitBox
ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map URL: https://github.com/apache/drill/pull/1829#discussion_r308168126 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetGroupConverter.java

[GitHub] [drill] ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map

2019-07-29 Thread GitBox
ihuzenko commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map URL: https://github.com/apache/drill/pull/1829#discussion_r308173946 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetReader.java

[GitHub] [drill] asfgit closed pull request #1827: DRILL-7327: Log Regex Plugin Won't Recognize Schema

2019-07-29 Thread GitBox
asfgit closed pull request #1827: DRILL-7327: Log Regex Plugin Won't Recognize Schema URL: https://github.com/apache/drill/pull/1827 This is an automated message from the Apache Git Service. To respond to the message,

Re: [ANNOUNCE] New Committer: Anton Gozhyi

2019-07-29 Thread Arina Ielchiieva
Congratulations Anton! Thanks for your contributions. Kind regards, Arina On Mon, Jul 29, 2019 at 12:55 PM Павел Семенов wrote: > Congratulations Anton ! Well done. > > пн, 29 июл. 2019 г. в 12:54, Bohdan Kazydub : > > > Congratulations Anton! > > > > On Mon, Jul 29, 2019 at 12:44 PM Igor

Re: [ANNOUNCE] New Committer: Anton Gozhyi

2019-07-29 Thread Bohdan Kazydub
Congratulations Anton! On Mon, Jul 29, 2019 at 12:44 PM Igor Guzenko wrote: > Congratulations Anton! > > On Mon, Jul 29, 2019 at 12:09 PM denysord88 wrote: > > > Congratulations Anton! Well deserved! > > > > On 07/29/2019 12:02 PM, Volodymyr Vysotskyi wrote: > > > The Project Management

Re: [ANNOUNCE] New Committer: Anton Gozhyi

2019-07-29 Thread Igor Guzenko
Congratulations Anton! On Mon, Jul 29, 2019 at 12:09 PM denysord88 wrote: > Congratulations Anton! Well deserved! > > On 07/29/2019 12:02 PM, Volodymyr Vysotskyi wrote: > > The Project Management Committee (PMC) for Apache Drill has invited Anton > > Gozhyi to become a committer, and we are

[GitHub] [drill] asfgit closed pull request #1828: DRILL-7332: Allow parsing empty schema

2019-07-29 Thread GitBox
asfgit closed pull request #1828: DRILL-7332: Allow parsing empty schema URL: https://github.com/apache/drill/pull/1828 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [drill] asfgit closed pull request #1824: DRILL-7205: Drill fails to start when authentication is disabled

2019-07-29 Thread GitBox
asfgit closed pull request #1824: DRILL-7205: Drill fails to start when authentication is disabled URL: https://github.com/apache/drill/pull/1824 This is an automated message from the Apache Git Service. To respond to the

Re: [ANNOUNCE] New Committer: Anton Gozhyi

2019-07-29 Thread denysord88
Congratulations Anton! Well deserved! On 07/29/2019 12:02 PM, Volodymyr Vysotskyi wrote: The Project Management Committee (PMC) for Apache Drill has invited Anton Gozhyi to become a committer, and we are pleased to announce that he has accepted. Anton Gozhyi has been contributing to Drill for

[ANNOUNCE] New Committer: Anton Gozhyi

2019-07-29 Thread Volodymyr Vysotskyi
The Project Management Committee (PMC) for Apache Drill has invited Anton Gozhyi to become a committer, and we are pleased to announce that he has accepted. Anton Gozhyi has been contributing to Drill for more than a year and a half. He did significant contributions as a QA, including reporting

[GitHub] [drill] arina-ielchiieva edited a comment on issue #1830: DRILL-7333: Set container record count where missing

2019-07-29 Thread GitBox
arina-ielchiieva edited a comment on issue #1830: DRILL-7333: Set container record count where missing URL: https://github.com/apache/drill/pull/1830#issuecomment-515863945 @paul-rogers mostly rpc errors are caused by other tests failures or lack of resources. Currently if we look in

[GitHub] [drill] arina-ielchiieva commented on issue #1830: DRILL-7333: Set container record count where missing

2019-07-29 Thread GitBox
arina-ielchiieva commented on issue #1830: DRILL-7333: Set container record count where missing URL: https://github.com/apache/drill/pull/1830#issuecomment-515863945 @paul-rogers mostly rpc errors are caused by other tests failures. Currently if we look in travis there are still IOB