[GitHub] [drill] paul-rogers commented on a change in pull request #2056: DRILL-7701: EVF V2 Scan Framework

2020-04-18 Thread GitBox
paul-rogers commented on a change in pull request #2056: DRILL-7701: EVF V2 Scan Framework URL: https://github.com/apache/drill/pull/2056#discussion_r410816122 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/scan/v3/file/FileScanUtils.java ##

[GitHub] [drill] paul-rogers opened a new pull request #2062: DRILL-7711: Add data path, parameter filter pushdown to HTTP plugin

2020-04-18 Thread GitBox
paul-rogers opened a new pull request #2062: DRILL-7711: Add data path, parameter filter pushdown to HTTP plugin URL: https://github.com/apache/drill/pull/2062 # [DRILL-7711](https://issues.apache.org/jira/browse/DRILL-7711): Add data path, parameter filter pushdown to HTTP plugin #

Re: Druid Storage Plugin for Drill

2020-04-18 Thread Charles Givre
I don't mean to be a pain in the you know where about this... I very much would like to see this as a part of Drill. Best, -- C > On Apr 18, 2020, at 4:54 PM, Ankush Kapur wrote: > > Apologies for being MIA, got hung-up at work really bad. > > Yes, I did start working on the changes reques

[GitHub] [drill] paul-rogers edited a comment on issue #2054: DRILL-6168: Revise format plugin table functions

2020-04-18 Thread GitBox
paul-rogers edited a comment on issue #2054: DRILL-6168: Revise format plugin table functions URL: https://github.com/apache/drill/pull/2054#issuecomment-615934230 @arina-ielchiieva, yes, we can modify the queries to force the incorrect behavior. We could add a yet another option to turn o

[jira] [Created] (DRILL-7711) Add data path, parameter filter pushdown to HTTP plugin

2020-04-18 Thread Paul Rogers (Jira)
Paul Rogers created DRILL-7711: -- Summary: Add data path, parameter filter pushdown to HTTP plugin Key: DRILL-7711 URL: https://issues.apache.org/jira/browse/DRILL-7711 Project: Apache Drill Issu

Re: Druid Storage Plugin for Drill

2020-04-18 Thread Ankush Kapur
Apologies for being MIA, got hung-up at work really bad. Yes, I did start working on the changes requested in the review. Will act on the other things you mentioned, as well. Thank you for following-up though, helps if someone is watching over :) - Ankush On Fri, Apr 17, 2020 at 12:56 AM Charle

[GitHub] [drill] paul-rogers closed pull request #2045: DRILL-7683: Add "message parsing" to new JSON loader

2020-04-18 Thread GitBox
paul-rogers closed pull request #2045: DRILL-7683: Add "message parsing" to new JSON loader URL: https://github.com/apache/drill/pull/2045 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [drill] paul-rogers opened a new pull request #2045: DRILL-7683: Add "message parsing" to new JSON loader

2020-04-18 Thread GitBox
paul-rogers opened a new pull request #2045: DRILL-7683: Add "message parsing" to new JSON loader URL: https://github.com/apache/drill/pull/2045 # [DRILL-7683](https://issues.apache.org/jira/browse/DRILL-7683): Add "message parsing" to new JSON loader ## Description Worked on

[GitHub] [drill] paul-rogers commented on issue #2054: DRILL-6168: Revise format plugin table functions

2020-04-18 Thread GitBox
paul-rogers commented on issue #2054: DRILL-6168: Revise format plugin table functions URL: https://github.com/apache/drill/pull/2054#issuecomment-615934230 @arina-ielchiieva, yes, we can modify the queries to force the incorrect behavior. We could add a yet another option to turn off inhe

[GitHub] [drill] vvysotskyi commented on a change in pull request #2060: DRILL-7706: Implement Drill RDBMS Metastore for Tables component

2020-04-18 Thread GitBox
vvysotskyi commented on a change in pull request #2060: DRILL-7706: Implement Drill RDBMS Metastore for Tables component URL: https://github.com/apache/drill/pull/2060#discussion_r410729508 ## File path: metastore/rdbms-metastore/src/main/resources/db/changelog/changes/initial_ddls

[GitHub] [drill] vvysotskyi commented on a change in pull request #2060: DRILL-7706: Implement Drill RDBMS Metastore for Tables component

2020-04-18 Thread GitBox
vvysotskyi commented on a change in pull request #2060: DRILL-7706: Implement Drill RDBMS Metastore for Tables component URL: https://github.com/apache/drill/pull/2060#discussion_r410730382 ## File path: metastore/rdbms-metastore/src/main/resources/db/changelog/changes/initial_ddls

[GitHub] [drill] vvysotskyi commented on a change in pull request #2060: DRILL-7706: Implement Drill RDBMS Metastore for Tables component

2020-04-18 Thread GitBox
vvysotskyi commented on a change in pull request #2060: DRILL-7706: Implement Drill RDBMS Metastore for Tables component URL: https://github.com/apache/drill/pull/2060#discussion_r410700439 ## File path: metastore/rdbms-metastore/README.md ## @@ -0,0 +1,140 @@ +# RDBMS Met

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2056: DRILL-7701: EVF V2 Scan Framework

2020-04-18 Thread GitBox
arina-ielchiieva commented on a change in pull request #2056: DRILL-7701: EVF V2 Scan Framework URL: https://github.com/apache/drill/pull/2056#discussion_r410711887 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/v3/lifecycle/ScanLifecycle.java

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2056: DRILL-7701: EVF V2 Scan Framework

2020-04-18 Thread GitBox
arina-ielchiieva commented on a change in pull request #2056: DRILL-7701: EVF V2 Scan Framework URL: https://github.com/apache/drill/pull/2056#discussion_r410087452 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/scan/v3/lifecycle/TestOutputBatchBuild

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2056: DRILL-7701: EVF V2 Scan Framework

2020-04-18 Thread GitBox
arina-ielchiieva commented on a change in pull request #2056: DRILL-7701: EVF V2 Scan Framework URL: https://github.com/apache/drill/pull/2056#discussion_r410711733 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/v3/lifecycle/ReaderLifecycle.java

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2056: DRILL-7701: EVF V2 Scan Framework

2020-04-18 Thread GitBox
arina-ielchiieva commented on a change in pull request #2056: DRILL-7701: EVF V2 Scan Framework URL: https://github.com/apache/drill/pull/2056#discussion_r410088714 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/scan/v3/file/FileScanUtils.java #

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2056: DRILL-7701: EVF V2 Scan Framework

2020-04-18 Thread GitBox
arina-ielchiieva commented on a change in pull request #2056: DRILL-7701: EVF V2 Scan Framework URL: https://github.com/apache/drill/pull/2056#discussion_r410086985 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/scan/v3/lifecycle/TestScanLifecycleSch

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2056: DRILL-7701: EVF V2 Scan Framework

2020-04-18 Thread GitBox
arina-ielchiieva commented on a change in pull request #2056: DRILL-7701: EVF V2 Scan Framework URL: https://github.com/apache/drill/pull/2056#discussion_r410711451 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/v3/file/FileScanLifecycle.java #

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2056: DRILL-7701: EVF V2 Scan Framework

2020-04-18 Thread GitBox
arina-ielchiieva commented on a change in pull request #2056: DRILL-7701: EVF V2 Scan Framework URL: https://github.com/apache/drill/pull/2056#discussion_r409840961 ## File path: exec/vector/src/main/java/org/apache/drill/exec/vector/complex/AbstractContainerVector.java ##

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2056: DRILL-7701: EVF V2 Scan Framework

2020-04-18 Thread GitBox
arina-ielchiieva commented on a change in pull request #2056: DRILL-7701: EVF V2 Scan Framework URL: https://github.com/apache/drill/pull/2056#discussion_r409840377 ## File path: exec/vector/src/main/java/org/apache/drill/exec/vector/complex/AbstractContainerVector.java ##

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #2056: DRILL-7701: EVF V2 Scan Framework

2020-04-18 Thread GitBox
arina-ielchiieva commented on a change in pull request #2056: DRILL-7701: EVF V2 Scan Framework URL: https://github.com/apache/drill/pull/2056#discussion_r410711431 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/v3/file/FileScanLifecycle.java #

[GitHub] [drill] arina-ielchiieva commented on issue #2060: DRILL-7706: Implement Drill RDBMS Metastore for Tables component

2020-04-18 Thread GitBox
arina-ielchiieva commented on issue #2060: DRILL-7706: Implement Drill RDBMS Metastore for Tables component URL: https://github.com/apache/drill/pull/2060#issuecomment-615879117 @paul-rogers good questions. Though none of them are addressed in this PR, since this PR only adds support for D

[jira] [Created] (DRILL-7710) Fix TestMetastoreCommands#testDefaultSegment test

2020-04-18 Thread Arina Ielchiieva (Jira)
Arina Ielchiieva created DRILL-7710: --- Summary: Fix TestMetastoreCommands#testDefaultSegment test Key: DRILL-7710 URL: https://issues.apache.org/jira/browse/DRILL-7710 Project: Apache Drill

[GitHub] [drill] arina-ielchiieva commented on issue #2054: DRILL-6168: Revise format plugin table functions

2020-04-18 Thread GitBox
arina-ielchiieva commented on issue #2054: DRILL-6168: Revise format plugin table functions URL: https://github.com/apache/drill/pull/2054#issuecomment-615869665 @paul-rogers is there a way to modify queries so they will pass before and after your PR? For example, add `fieldDelimiter` to t

Re: [NOTICE] Maven 3.6.3

2020-04-18 Thread Arina Ielchiieva
Looks like decision was made to stay on the Maven 3.6.3. For those who want to follow the discussion, please see Jira and PR: https://issues.apache.org/jira/browse/DRILL-7708 https://github.com/apache/drill/pull/2061

Re: [DISCUSS]: Masking Creds in Query Plans

2020-04-18 Thread Arina Ielchiieva
Agree, that we should not display sensitive data, like passwords, I would say the best option is to mask it during output. Kind regards, Arina > On Apr 17, 2020, at 5:34 PM, Charles Givre wrote: > > Hello all, > I was thinking about this, if a user were to execute an EXPLAIN PLAN FOR > query